--- Log opened Thu Jan 07 00:00:08 2021 00:01 -!- da39a3ee5e6b4b0d [~da39a3ee5@ppp-223-24-94-18.revip6.asianet.co.th] has joined #bitcoin-core-dev 00:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:07 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/3b6d1b61d316...f13e03cda272 00:07 < bitcoin-git> bitcoin/master 1c65c07 practicalswift: Don't declare de facto const member functions as non-const 00:07 < bitcoin-git> bitcoin/master 31b136e practicalswift: Don't declare de facto const reference variables as non-const 00:07 < bitcoin-git> bitcoin/master f13e03c MarcoFalke: Merge #20584: Declare de facto const reference variables/member functions ... 00:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:07 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20584: Declare de facto const reference variables/member functions as const (master...const-member-fn-and-const-ref-var) https://github.com/bitcoin/bitcoin/pull/20584 00:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:10 -!- da39a3ee5e6b4b0d [~da39a3ee5@ppp-223-24-94-18.revip6.asianet.co.th] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 00:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:10 < bitcoin-git> [gui] MarcoFalke merged pull request #165: Save QSplitter state in QSettings (master...201225-geo) https://github.com/bitcoin-core/gui/pull/165 00:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:10 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f13e03cda272...8a720ced5ff2 00:10 < bitcoin-git> bitcoin/master 90f9fc2 Hennadii Stepanov: qt: Save QSplitter state in QSettings 00:10 < bitcoin-git> bitcoin/master 8a720ce MarcoFalke: Merge bitcoin-core/gui#165: Save QSplitter state in QSettings 00:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:17 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 00:19 -!- da39a3ee5e6b4b0d [~da39a3ee5@ppp-223-24-94-18.revip6.asianet.co.th] has joined #bitcoin-core-dev 00:24 < jonasschnelli> should we remove? https://github.com/bitcoin/bitcoin/issues/9913#issuecomment-755960500 00:29 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 00:35 < jonasschnelli> nm... I missread the issue 00:39 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 00:42 -!- joelklabo [~textual@108-196-216-127.lightspeed.sntcca.sbcglobal.net] has quit [Ping timeout: 260 seconds] 00:43 -!- asdlkfjwerpoicvx [~flack@p200300d46f24de009c017d5b6f0c8201.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 00:45 -!- m1rror51 [~cataly5m@static.65.177.203.116.clients.your-server.de] has quit [Ping timeout: 256 seconds] 00:46 < wumpus> yeah I think promising people a bounty for implementing something is okay 00:47 -!- m1rror51 [~cataly5m@static.65.177.203.116.clients.your-server.de] has joined #bitcoin-core-dev 00:50 < wumpus> given the amount of work involved $300 is not that much, but it does show people want this particular feature badly, and actually offering money is much better than the usual entitled "when????" github post 01:15 < jonasschnelli> indeed 01:16 < jonasschnelli> I vaguely remember getting a BTC bounty when I implemented the initial HD wallets patch 01:16 < jonasschnelli> Can't remember the website though 01:17 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has quit [Ping timeout: 264 seconds] 01:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:40 < bitcoin-git> [bitcoin] stackman27 opened pull request #20874: test: Run mempool_limit.py even with wallet disabled (master...diswallet_mempoollimit) https://github.com/bitcoin/bitcoin/pull/20874 01:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:04 -!- kexkey [~kexkey@static-198-54-132-107.cust.tzulo.com] has quit [Ping timeout: 240 seconds] 02:06 -!- da39a3ee5e6b4b0d [~da39a3ee5@ppp-223-24-94-18.revip6.asianet.co.th] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 02:23 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:12e2:1db3:d5d3:fa35:5ac1] has joined #bitcoin-core-dev 02:29 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 02:57 < jonatack> I received a (non-trivial) bounty recently for some larger PR reviewing done in October just before the feature freeze. 02:57 < jonatack> jonasschnelli: maybe from bitcoin acks 02:58 < jonasschnelli> jonatack: nice. No mine was before bitcoinacks existed 02:59 < jonatack> there is a 2M sat bounty open since Sept for reviewing #19160 at my suggestion, no one has reviewed it yet since https://twitter.com/TooWumboToFail/status/1347110826008735744?s=20 02:59 < gribble> https://github.com/bitcoin/bitcoin/issues/19160 | multiprocess: Add basic spawn and IPC support by ryanofsky · Pull Request #19160 · bitcoin/bitcoin · GitHub 03:18 -!- Tennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev 03:34 < wumpus> jonatack: something that surprised me (but no big deal) is that "-netinfo help" only works when there is a remote server, even though the help message is entirely formatted locally 03:38 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 240 seconds] 03:39 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 03:39 < jonatack> wumpus: ah! i didn't think of trying that. you are referring to "error: Could not connect to the server 127.0.0.1:8332 Make sure the bitcoind server is running and that you are connecting to the correct RPC port."? 03:43 < jonatack> i'll see if can move the help check earlier 03:43 < wumpus> jonatack: yes, that, while testing the help message I did somehow not expect it to need the RPC server running 03:48 < wumpus> jonatack: I also noticed that "netinfo 5" behaves like "netinfo 0", instead of "netinfo 4" 03:50 < jonatack> wumpus: good point, maybe invalid integers should raise too 03:51 < jonatack> yes, just as the summary help doesn't need the server, e.g. ./src/bitcoin-cli -h | grep -A4 netinfo 03:52 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 03:55 < wumpus> jonatack: the behavior I'd personally expect is either a) higher, not (yet?) defined levels act as the highest defined level b) it raises an error 03:55 < wumpus> yes maybe an explicit error is best 04:01 < wumpus> I think something we need to expicitly warn against is using this output in scripts in favor of parsing JSON, it's not a stable interface, maybe we do this already 04:01 < wumpus> (the same we did for readelf, human readable formats are for humans not for machine parsing) 04:04 < jonatack> in the new help, as suggested here? https://github.com/bitcoin/bitcoin/pull/20829#issuecomment-755420094 04:07 < jonatack> i thought it was understood that software clients shouldn't depend on client-side cli commands, e.g. instead of -netinfo they should consume getpeerinfo and getnetworkinfo that are subject to API stability constraints 04:08 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:12e2:1db3:d5d3:fa35:5ac1] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 04:11 < jonatack> hm, git grepping for "unstable\| stable" doesn't turn up much explanation on this. Maybe it's not obvious. I'll look at clarifying. 04:11 < wumpus> I think it's generally understoof, but it doesn't hurt to explicitly mention it, a new user might not be aware what the division between client/server side is exactly 04:12 < jonatack> 👍 04:12 < wumpus> yes, as Luke-jr mentions too 04:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:26 < bitcoin-git> [bitcoin] SamuelMarks opened pull request #20875: [*.cc,*.cpp] Reduce push_back (master...push-back) https://github.com/bitcoin/bitcoin/pull/20875 04:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:31 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 04:32 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 04:41 -!- real_or_random [~real_or_r@2a02:c207:3002:7468::1] has quit [Quit: ZNC 1.7.5 - https://znc.in] 04:43 -!- real_or_random [~real_or_r@173.249.7.254] has joined #bitcoin-core-dev 04:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:43 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8a720ced5ff2...efe03ceb582d 04:43 < bitcoin-git> bitcoin/master f2d93b2 Michael Tidwell: gitian-keys: add miketwenty1 key 04:43 < bitcoin-git> bitcoin/master efe03ce Wladimir J. van der Laan: Merge #20859: gitian-keys: add miketwenty1 key 04:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:43 < bitcoin-git> [bitcoin] laanwj merged pull request #20859: gitian-keys: add miketwenty1 key (master...master) https://github.com/bitcoin/bitcoin/pull/20859 04:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:50 -!- worc3131 [~quassel@2a02:c7f:dcc4:6500:cf0e:3346:8766:ab20] has joined #bitcoin-core-dev 04:51 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:12e2:1db3:d5d3:fa35:5ac1] has joined #bitcoin-core-dev 05:01 -!- worc3131 [~quassel@2a02:c7f:dcc4:6500:cf0e:3346:8766:ab20] has quit [Ping timeout: 272 seconds] 05:02 -!- worc3131 [~quassel@2a02:c7f:dcc4:6500:cf0e:3346:8766:ab20] has joined #bitcoin-core-dev 05:05 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 05:07 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 05:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 05:23 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 05:23 < wumpus> rc5 binaries up: https://bitcoincore.org/bin/bitcoin-core-0.21.0/test.rc5/ 05:24 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 05:25 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 05:25 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 05:26 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 05:30 -!- rah1 [~rah@217.146.82.202] has quit [Remote host closed the connection] 05:36 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:12e2:1db3:d5d3:fa35:5ac1] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 05:41 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 05:42 -!- opsec_x12 [~opsec_x12@c-67-183-29-123.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 05:46 -!- opsec_x12 [~opsec_x12@c-67-183-29-123.hsd1.wa.comcast.net] has quit [Client Quit] 05:47 -!- newz2000 [~newz2000@178.162.212.214] has joined #bitcoin-core-dev 05:48 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:12e2:1db3:d5d3:fa35:5ac1] has joined #bitcoin-core-dev 05:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:59 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/efe03ceb582d...42675e783337 05:59 < bitcoin-git> bitcoin/master fa0a717 MarcoFalke: net: Move CConnman/NetEventsInterface after CNode in header file 05:59 < bitcoin-git> bitcoin/master fa21068 MarcoFalke: net: Move SocketSendData lock annotation to header 05:59 < bitcoin-git> bitcoin/master 42675e7 MarcoFalke: Merge #20864: net: Move SocketSendData lock annotation to header 05:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:59 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20864: net: Move SocketSendData lock annotation to header (master...2101-netLock) https://github.com/bitcoin/bitcoin/pull/20864 05:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:00 < bitcoin-git> [gui] MarcoFalke merged pull request #173: Follow Qt docs when implementing rowCount and columnCount (master...210102-table) https://github.com/bitcoin-core/gui/pull/173 06:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:00 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/42675e783337...4b8b71e63041 06:00 < bitcoin-git> bitcoin/master 195fcb5 Hennadii Stepanov: qt: Follow Qt docs when implementing rowCount and columnCount 06:00 < bitcoin-git> bitcoin/master 4b8b71e MarcoFalke: Merge bitcoin-core/gui#173: Follow Qt docs when implementing rowCount and ... 06:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:01 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 06:02 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:09 -!- kexkey [~kexkey@static-198-54-132-171.cust.tzulo.com] has joined #bitcoin-core-dev 06:22 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has quit [Remote host closed the connection] 06:28 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 06:29 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 06:35 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 06:44 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 06:46 -!- MTennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev 06:47 -!- Tennis [~Tennis@unaffiliated/tennis] has quit [Ping timeout: 246 seconds] 06:47 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 260 seconds] 06:48 -!- belcher_ is now known as belcher 06:53 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Remote host closed the connection] 06:55 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 07:07 -!- promag [~promag@188.250.84.129] has quit [Remote host closed the connection] 07:09 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection] 07:09 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev 07:09 -!- promag [~promag@188.250.84.129] has quit [Remote host closed the connection] 07:11 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:12e2:1db3:d5d3:fa35:5ac1] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 07:17 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev 07:32 -!- promag [~promag@83.223.224.52] has joined #bitcoin-core-dev 07:32 -!- lightlike [~lightlike@p200300c7ef19fc0034e2d3ab670ebeac.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 07:37 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Ping timeout: 240 seconds] 07:39 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 07:41 -!- worc3131 [~quassel@2a02:c7f:dcc4:6500:cf0e:3346:8766:ab20] has quit [Ping timeout: 272 seconds] 07:42 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 264 seconds] 07:46 -!- nickler [~nickler@static.219.205.69.159.clients.your-server.de] has quit [Remote host closed the connection] 07:57 -!- nickler [~nickler@static.219.205.69.159.clients.your-server.de] has joined #bitcoin-core-dev 07:58 -!- promag [~promag@83.223.224.52] has quit [Remote host closed the connection] 08:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:02 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20876: test: Replace getmempoolentry with testmempoolaccept in MiniWallet (master...2101-testMiniWalletNoSubmit) https://github.com/bitcoin/bitcoin/pull/20876 08:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:06 < bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/4b8b71e63041...3a6acd177210 08:06 < bitcoin-git> bitcoin/master fa121f0 MarcoFalke: fuzz: Use ConsumeNode in process_messages target 08:06 < bitcoin-git> bitcoin/master fa42da2 MarcoFalke: fuzz: Use ConsumeNode in process_message target 08:06 < bitcoin-git> bitcoin/master faaef94 MarcoFalke: fuzz: [refactor] Extract ALL_CONNECTION_TYPES constant 08:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:06 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20789: fuzz: Rework strong and weak net enum fuzzing (master...2012-fuzzRefactor) https://github.com/bitcoin/bitcoin/pull/20789 08:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:21 < bitcoin-git> [bitcoin] jonatack opened pull request #20877: netinfo: user help and argument parsing improvements (master...netinfo-help-follow-ups) https://github.com/bitcoin/bitcoin/pull/20877 08:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:55 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 08:55 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services] 08:55 -!- vasild_ is now known as vasild 08:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:58 < bitcoin-git> [bitcoin] laanwj pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/3a6acd177210...b6a71b80d28c 08:58 < bitcoin-git> bitcoin/master 589f958 Fabian Jahr: build: Check for 128 bit integer support 08:58 < bitcoin-git> bitcoin/master 0b4d290 Fabian Jahr: crypto: Add Num3072 implementation 08:58 < bitcoin-git> bitcoin/master adc708c Fabian Jahr: crypto: Add MuHash3072 implementation 08:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:58 < bitcoin-git> [bitcoin] laanwj merged pull request #19055: Add MuHash3072 implementation (master...csi-1-muhash) https://github.com/bitcoin/bitcoin/pull/19055 08:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:59 < jonatack> congrats fjahr! \o/ 09:01 < wumpus> yess 09:03 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has joined #bitcoin-core-dev 09:11 < fjahr> wohooo \o/ 09:12 < jnewbery> great! 09:18 -!- glozow [uid453516@gateway/web/irccloud.com/x-netvovtobqfafxal] has joined #bitcoin-core-dev 09:31 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-fqmqdesvfbargkli] has quit [Quit: Connection closed for inactivity] 09:31 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 09:33 < wumpus> hebasto: #18710 is great, it needs very careful review due to script validation being consensus critical, but good to get rid of another boost::thread_group use (on of the last I think?) 09:33 < gribble> https://github.com/bitcoin/bitcoin/issues/18710 | Add local thread pool to CCheckQueue by hebasto · Pull Request #18710 · bitcoin/bitcoin · GitHub 09:33 -!- davterra [~davterra@static-198-54-134-68.cust.tzulo.com] has joined #bitcoin-core-dev 09:34 < wumpus> oh, only the scheduler left 09:35 < hebasto> ^ right 09:35 < sipa> oooh! 09:36 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev 09:40 -!- promag [~promag@188.250.84.129] has quit [Remote host closed the connection] 09:40 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev 09:42 -!- kvaciral [~kvaciral@212.8.251.11] has joined #bitcoin-core-dev 10:10 -!- az0re [~az0re@gateway/tor-sasl/az0re] has joined #bitcoin-core-dev 10:10 -!- newz2000 [~newz2000@178.162.212.214] has quit [Ping timeout: 260 seconds] 10:14 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 10:17 -!- jespada [~jespada@90.254.245.49] has quit [Ping timeout: 264 seconds] 10:19 -!- jespada [~jespada@90.254.245.49] has joined #bitcoin-core-dev 10:21 -!- asdlkfjwerpoicvx [~flack@p200300d46f24de009c017d5b6f0c8201.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!] 10:29 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 10:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:42 < bitcoin-git> [bitcoin] laanwj pushed 14 commits to master: https://github.com/bitcoin/bitcoin/compare/b6a71b80d28c...d7e2401c629b 10:42 < bitcoin-git> bitcoin/master 02ccf69 Hennadii Stepanov: refactor: Move port mapping code to its own module 10:42 < bitcoin-git> bitcoin/master 28e2961 Hennadii Stepanov: refactor: Replace magic number with named constant 10:42 < bitcoin-git> bitcoin/master 8b50d1b Hennadii Stepanov: net: Keep trying to use UPnP when -upnp=1 10:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:43 < bitcoin-git> [bitcoin] laanwj merged pull request #18077: net: Add NAT-PMP port forwarding support (master...20200130-natpmp) https://github.com/bitcoin/bitcoin/pull/18077 10:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:43 < hebasto> \o/ 10:43 < hebasto> wumpus: thanks! 10:48 < wumpus> hebasto: thanks for sticking with it 10:52 < jonasschnelli> Well done hebasto 10:55 < wumpus> btw, is it time to tag 0.19.2? doesn't seem another rc is needed 10:55 < hebasto> jonasschnelli: thanks 10:55 < achow101> ack 10:57 < jonasschnelli> wumpus: yes. ack. 10:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:59 < bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.19: https://github.com/bitcoin/bitcoin/compare/33cbedef28eb...2f9f9b37b595 10:59 < bitcoin-git> bitcoin/0.19 2f9f9b3 Wladimir J. van der Laan: build: Bump rc to final 10:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:59 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 10:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:59 < bitcoin-git> [bitcoin] laanwj pushed tag v0.19.2: https://github.com/bitcoin/bitcoin/compare/v0.19.2 10:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:59 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 10:59 < wumpus> ^^ 10:59 < MarcoFalke> nice 11:00 < achow101> just in time for the meeting 11:00 < MarcoFalke> wen #20738 ? 11:00 < gribble> https://github.com/bitcoin/bitcoin/issues/20738 | [0.20] final rc2 backports by MarcoFalke · Pull Request #20738 · bitcoin/bitcoin · GitHub 11:00 < wumpus> MarcoFalke: next, I guess 11:00 < wumpus> #startmeeting 11:00 < core-meetingbot> Meeting started Thu Jan 7 19:00:59 2021 UTC. The chair is wumpus. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings. 11:00 < core-meetingbot> Available commands: action commands idea info link nick 11:01 < jonasschnelli> hi 11:01 < MarcoFalke> hi 11:01 < sipa> hi 11:01 < hebasto> hi 11:01 < wumpus> #bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik 11:01 < achow101> hi 11:01 < wumpus> petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild wumpus 11:01 < jonasschnelli> first meeting in 2021 \o 11:01 < jb55> hi 11:02 < wumpus> i thought it's still december 2020 :) 11:02 < MarcoFalke> wumpus: happy new year :) 11:02 < jb55> eternal december 11:02 < wumpus> no proposed meeting topics in http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt 11:02 < sipa> it is March 313th 11:02 < nehan> hi! happy new year 11:02 < wumpus> MarcoFalke: thank you, same to you! 11:02 < Murch> hi 11:03 < MarcoFalke> #proposedmeetingtopic 0.21.0 release 11:03 < jamesob> hi 11:03 < wumpus> any last minute meeting topic suggestions? 11:03 < wumpus> #topic High priority for review 11:03 < core-meetingbot> topic: High priority for review 11:03 < wumpus> https://github.com/bitcoin/bitcoin/projects/8 10 blockers, 1 chasing concept ACK 11:04 < luke-jr> hi 11:04 < jonatack> hi 11:04 < wumpus> anything to add/remove, or almost ready to merge? 11:05 < promag> #20017 for concept ack 11:05 < gribble> https://github.com/bitcoin/bitcoin/issues/20017 | rpc: Add RPCContext by promag · Pull Request #20017 · bitcoin/bitcoin · GitHub 11:05 < fjahr> hi 11:06 < wumpus> promag: added 11:06 < wumpus> anything else? 11:07 < jnewbery> hi 11:07 < ajonas> hi 11:08 < wumpus> thanks sipa, good to see more review on #19806 11:08 < gribble> https://github.com/bitcoin/bitcoin/issues/19806 | validation: UTXO snapshot activation by jamesob · Pull Request #19806 · bitcoin/bitcoin · GitHub 11:08 < jamesob> yup, thanks sipa 11:08 < jamesob> will look at, at least, the tsan error tonight 11:09 < wumpus> #topic 0.21.0 release (MarcoFalke) 11:09 < core-meetingbot> topic: 0.21.0 release (MarcoFalke) 11:09 < MarcoFalke> https://github.com/bitcoin/bitcoin/milestone/45 11:10 < sipa> so, #20849 and/or #20852, and rc6? 11:10 < gribble> https://github.com/bitcoin/bitcoin/issues/20849 | net: disconnect peers by address without using a subnet by vasild · Pull Request #20849 · bitcoin/bitcoin · GitHub 11:10 < gribble> https://github.com/bitcoin/bitcoin/issues/20852 | net: allow CSubNet of non-IP networks by vasild · Pull Request #20852 · bitcoin/bitcoin · GitHub 11:10 < wumpus> let's at least wait a week or two before tagging final, I'm sure if people start testing issues will come up 11:10 < MarcoFalke> sipa: Or none of them 11:10 -!- davterra [~davterra@static-198-54-134-68.cust.tzulo.com] has quit [Remote host closed the connection] 11:10 < jnewbery> wumpus: can we move #20557 to high priority bug fixes? PR #16702 broke some aspects of addrman deserialization and it'd be nice to fix them 11:10 < gribble> https://github.com/bitcoin/bitcoin/issues/20557 | addrman: Fix new table bucketing during unserialization by jnewbery · Pull Request #20557 · bitcoin/bitcoin · GitHub 11:10 < gribble> https://github.com/bitcoin/bitcoin/issues/16702 | p2p: supplying and using asmap to improve IP bucketing in addrman by naumenkogs · Pull Request #16702 · bitcoin/bitcoin · GitHub 11:10 < wumpus> I'm confused about #20849 11:10 < gribble> https://github.com/bitcoin/bitcoin/issues/20849 | net: disconnect peers by address without using a subnet by vasild · Pull Request #20849 · bitcoin/bitcoin · GitHub 11:11 < MarcoFalke> wumpus: It is a smaller-impact fix than 20852 11:11 < wumpus> (but I posted that on the issue) 11:11 < wumpus> MarcoFalke: ok, yes that's true 11:11 < sipa> wumpus: 20852 is the more general fix, but perhaps more invasive than what we want for 0.21 11:11 < MarcoFalke> There havne't been any blocker issues reported since rc3 11:12 < wumpus> but using a diffrent solution for 0.21 is going to make future backports harder 11:12 < MarcoFalke> rc4 and rc5 only contained test and doc fixups, IIRC 11:12 < MarcoFalke> so I think we can also tag rc5 as -final 11:12 < wumpus> so I'd prefer to just bite the bullet and do #20852 on both master and 0.21 (maybe 0.21.1?) 11:12 < gribble> https://github.com/bitcoin/bitcoin/issues/20852 | net: allow CSubNet of non-IP networks by vasild · Pull Request #20852 · bitcoin/bitcoin · GitHub 11:12 < sipa> not being able to disconnect misbehaving tor nodes seems like something worth addressing 11:12 -!- davterra [~davterra@static-198-54-134-68.cust.tzulo.com] has joined #bitcoin-core-dev 11:13 < wumpus> yes, rc4 and rc5 were doc only 11:13 < wumpus> apart from the torv2->torv3 signet seed change 11:15 < wumpus> MarcoFalke: ofc, assuming nothing comes up with rc5 11:15 < wumpus> so we could make it depend on that, if a rc6 is needed for another reason, include, say, 20852 11:16 < wumpus> ok, this starts to be a monologue, any other topics? 11:17 < MarcoFalke> sipa: *outbound tor nodes 11:17 < MarcoFalke> sipa: Delaying the release will also delay already included bugfixes that exist in previous releases 11:17 < MarcoFalke> So I think it is a trade-off 11:18 < sipa> ? 11:18 < wumpus> I don't think in itself it warrants delaying the release 11:18 < sipa> ok 11:21 < wumpus> of course we could merge it and do rc6 right now but that'd not be very mindful of people that just started testing rc5, better to stick with a rc per week at most 11:22 < MarcoFalke> rc5 pretty much only needs testing on macOS 11:22 < MarcoFalke> apart from the signature, nothing changed code-wise 11:23 < luke-jr> could always just go 0.21.1 sooner too 11:23 < wumpus> if there's no other topics, that's a short first meeting of the year 11:23 < wumpus> MarcoFalke: luke-jr: agree 11:23 < MarcoFalke> luke-jr: 0.21.0.1 ;) 11:23 < jonasschnelli> rc5 pretty much only needs testing on macOS 11:23 < jonasschnelli> ^ why? 11:23 < MarcoFalke> jonasschnelli: Only documentation fixups were merged 11:23 < luke-jr> MarcoFalke: no reason for that mess :P 11:23 < MarcoFalke> (compared to rc3) 11:23 < jonasschnelli> It was testable on macOS before rc5 11:23 < luke-jr> oh, I have a possible topic 11:24 < luke-jr> Debian wants to include bitcoin core again 11:24 < wumpus> #topic Debian package (luke-jr) 11:24 < core-meetingbot> topic: Debian package (luke-jr) 11:24 < MarcoFalke> fedora as well 11:24 < luke-jr> does anyone want to possibly maintain whatever version they release, for their maintenance period? 11:24 < luke-jr> (IIRC 3 years?) 11:25 < jonasschnelli> thats about 6 version steps?!... 11:25 < luke-jr> they're also using system leveldb, which is another issue to resolve - not sure what they're going to do in that regard 11:25 < luke-jr> jonasschnelli: yeah :/ 11:25 -!- crisn2blink [d12203c2@regus-business-centers-katy-209-34-3-194.consolidated.net] has joined #bitcoin-core-dev 11:25 < wumpus> I don't particularly feel like repeating this discussion, we've had it before and I don't think anything changed? 11:25 < jonasschnelli> Smells after troubles 11:25 < luke-jr> wumpus: just thought I'd mention it in case anyone is interested :p 11:25 < wumpus> FWIW, I still think it's a bad idea 11:26 < luke-jr> IF they resolve the leveldb side, and if someone is willing to maintain it that long… not sure there's any other objections to have? 11:26 < wumpus> but so is auto-updating bitcoin core in general 11:26 < luke-jr> hmm 11:26 < luke-jr> but we already allow auto-updates via Snap etc 11:27 < wumpus> (defiitely between major releases, or when there's a softfork, or policy changes, or...) 11:27 < sipa> oh i have a topic: how reasonable is it for us to produce a docker image inside gitian? 11:27 < MarcoFalke> It is not auto update, only update on `apt update`, no? 11:27 < luke-jr> MarcoFalke: Debian supports auto-upgrade optionally 11:27 < sipa> MarcoFalke: i don't think that's a meaningful difference 11:28 < sipa> it's not like you're going to review all the things that get changed when updating 11:28 < sipa> also, auto-update can be enabled 11:28 < luke-jr> If we are auto-updating via official Snaps, I don't think we can make that objection 11:28 < wumpus> right, the point is that bitcoin needs *special* review compared to upgrading other software 11:28 < MarcoFalke> I do review them (at least of the important packages) 11:29 < luke-jr> MarcoFalke: can you confirm the Snap situation? 11:29 < MarcoFalke> luke-jr: Yes, there is an auto-update footgun 11:29 < MarcoFalke> I think it is optional 11:29 < MarcoFalke> Also, there are tracks for previous releaes 11:30 < sipa> regardless, i don't think we're ready for 3-year maintenance 11:30 < MarcoFalke> So even with auto-update you can say "only auto update on the 0.19 branch" 11:30 < jonasschnelli> yes 11:30 < MarcoFalke> (no one uses the tracks, though) 11:30 < wumpus> I definitely have no interest in maintaining a 3-year old release 11:31 < jonasschnelli> plus core is very easy to "install" on most systems thanks to the static binaries 11:31 < wumpus> maintaining he releases we do is already overwhelming enough sometimes 11:32 < luke-jr> anyway, I guess it's moot unless someone wants to maintain for 3 years.. 11:32 < MarcoFalke> sipa: Creating a docker image should be trivial. Not sure if it is deterministic, though. 11:32 < luke-jr> I've done it before, but having no funding, I'm not too inclinded to repeat it 11:32 < jonasschnelli> no fun(ding) 11:32 < wumpus> it's definitely a job that would require funding, no one is going to do it for fun :) 11:33 < wumpus> if there are really companies that want to run a three-year old stable, make them fund it 11:33 < sipa> MarcoFalke: i read that docker images can be identified by their hash, so if creating one is deterministic, that may be something people are interested in having 11:33 < sipa> (i've never used docker myself, though) 11:33 < wumpus> okok docker 11:33 < wumpus> #topic Docker image generation in gitian 11:33 < core-meetingbot> topic: Docker image generation in gitian 11:33 < MarcoFalke> sipa: me neither 11:34 < achow101> in theory it is deterministic because you can specify parent image hashes 11:34 < jonasschnelli> sipa: why inside gitian? What are the benefits? 11:34 < achow101> in practice, I've had no such luck 11:34 < MarcoFalke> jonasschnelli: For release binaries 11:34 < sipa> jonasschnelli: otherwise we're relying on external people to do it? 11:34 < MarcoFalke> We could also just include a docker script 11:35 < jonasschnelli> Wait? For uploading the gitian built deterministic release binary? 11:35 < sipa> jonasschnelli: the idea is that we could publish a docker image hash, together with the release binaries & their hashes 11:35 < MarcoFalke> no, in parallel to the snap package, also offer a docker package 11:36 < sipa> jonasschnelli: and if that hash if verified through gitian, it means it has the same standard of review and auditability as the rest of the release process 11:36 < jonasschnelli> okay.. I see. 11:37 < sipa> i'm just mentioning this because i saw https://github.com/bitcoin-core/packaging/issues/55, and it seems doing it inside gitian is an almost trivial change for us, apart from some initial work to set up the scripts 11:37 < sipa> jamesob seems to maintain a script for building docker images? 11:38 < MarcoFalke> I just feel that we need a docker expert to pull this off. Also, it would be sad if that blocked progress on guix 11:38 < luke-jr> hmm, true 11:38 < wumpus> so the question then would be: for what platforms? we can't quite do {docker,tar.gz} for all supported platforms 11:38 < sipa> wumpus: good point 11:39 < sipa> do people do docker for more than just x86_64 linux? 11:39 < luke-jr> can we add a file to the .tar.gz to run it as a docker? 11:39 < MarcoFalke> sipa: Also arm 11:39 < MarcoFalke> wumpus: Which is why I'd rather publish a docker script 11:39 < wumpus> i'd be surprised if it wouldn't be used on arm64 11:39 < wumpus> as for the other platforms, probably rarely 11:40 < sipa> MarcoFalke: okay, i'm not all that familiar with the different mechanics 11:40 < wumpus> MarcoFalke: agree, it's the same binaries anyhow packaged differently 11:40 < MarcoFalke> sipa: the docker script builds the docker image, so it is just one step less to do for us 11:40 < sipa> and your suggestion would be to have the script inside the release tgz? 11:41 < MarcoFalke> jup 11:41 < sipa> seems reasonable 11:41 < sipa> (plus having some sort of CI to see if the script works?) 11:42 < wumpus> yes 11:42 < MarcoFalke> hmm, maybe the idea isn't that good because we couldn't reference the gitian built binaries in the script 11:43 < luke-jr> why not? 11:43 < wumpus> as i see it it'd convert a set of gitian-built binaries to a docker image, deterministically 11:44 < MarcoFalke> ok, so the user has to provide the binaries. fair enough 11:44 < luke-jr> the binaries are right there with the script, no? 11:44 < sipa> if it's deterministic to do so even in a fairly uncontrolled environment, that'd still permit publishing the resulting hashes 11:44 * dongcarl looks back at `guix pack --format=docker` 11:44 < sipa> dongcarl: o? 11:44 < wumpus> luke-jr: oh... of course 11:45 < wumpus> luke-jr: it'd be shipped with the binary tarball, not the source one 11:45 < luke-jr> right 11:45 < sipa> right 11:45 < luke-jr> (well, part of source too I assume) 11:45 < wumpus> right it has to come from somewhere 11:46 < wumpus> dongcarl: hah! 11:46 * dongcarl still trying to find the goal of this discussion 11:47 < sipa> dongcarl: it seems docker is popular (i don't know why, i've never used it), so it'd be great if we have a direct path from our release process to something people can run directly 11:47 < wumpus> yes, for example btcpayserver uses docker IIRC? 11:47 < dongcarl> sipa: Stupid question: why aren't the release binaries enough for this? 11:48 < jonatack> yes iirc dockre is btcpay's recommended installation method 11:48 < achow101> dongcarl: people are just using docker images published by other people that contain the release binaries. afaiu, the point is for us to publish those images instead 11:48 < sipa> dongcarl: that requires people to build their own image from it, using a script they get from... somewhere? 11:48 < sipa> MarcoFalke has a point that just making publishing the script as part of the process may be enough 11:49 < wumpus> it would use the same release binaries, just package them 11:49 < sipa> i think publishing the image directly would be slightly more convenient (and also allow others to build on top of it, i think?) 11:49 < achow101> in the end, it's still our release binaries, but the images themselves may contain other stuff that could be malicious. hence the desire for the developers to create an official one 11:49 < MarcoFalke> sipa: The image can still be published, even if we include only the script in the release 11:49 < sipa> MarcoFalke: if it's deterministic, yes 11:50 < jonatack> https://docs.btcpayserver.org/Docker/ 11:50 < sipa> but i somehow expect that if a guix pack --format=docker exists... that'd be pretty likely to be deterministic ;) 11:51 < sipa> there isn't so much to discuss here i guess, a lot depends on what work people are willing to put into it 11:51 < sipa> but it's good to get an idea about the sentiment 11:51 < dongcarl> I think the only risk is Docker's determinism 11:51 < dongcarl> The actual Dockerfile will be like... 4 lines? 11:52 < MarcoFalke> dongcarl: People will ask for features, so the file surely will grow 11:52 < sipa> jamesob's Dockerfile seems quite a bit longer: https://github.com/jamesob/docker-bitcoind/blob/master/Dockerfile 11:52 < wumpus> i guess it's bascially glibc and the bitcoind binary? 11:53 < wumpus> if we'd link bitcoind statically with musl libc there wouldn't even be dependency on that 11:53 < luke-jr> MarcoFalke: what features are even possible? 11:53 < MarcoFalke> "I want to supply the cookie file from outside" 11:53 < sipa> "I want it to mine signet!" 11:53 < luke-jr> that's not runtime? 11:54 < MarcoFalke> "I want to run the gui in docker" 11:54 < wumpus> a docker image with bitcoind that's, just bitcoind :) 11:54 < dongcarl> I'm not entirely sure I see the point in this, let them use the binaries, it's currently clear that the Dockerfiles are not official, and we can't account for all features. Is there a particular event that makes us more worried now? 11:54 < sipa> dongcarl: no 11:55 < wumpus> MarcoFalke: nah 11:55 < MarcoFalke> dongcarl: ppl are asking for it for years 11:55 < sipa> i think the dockerfiles being unofficial is suboptimal 11:55 < sipa> s/official/not going through the same review process/ 11:55 < wumpus> there's plenty of ways to run sandboxed GUI (flatpak, snap) there's no point using docker for that, everyone uses docker for server components 11:56 < dongcarl> I think we should do what we do for the systemd services 11:56 < dongcarl> Make it clear that it's just for reference 11:56 < dongcarl> If we do add a Dockerfile I don't want it to bloat over time 11:58 < sipa> yes, that's a delicate line... but i think it'd be better if there was an actual dockerfile that was reviewed and known to be kept working 11:59 < sipa> enough on this i guess 11:59 < wumpus> okay, let's conclude the meeting then, thanks everyone for attending 11:59 < wumpus> #endmeeting 11:59 < core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt 11:59 < core-meetingbot> Meeting ended Thu Jan 7 19:59:31 2021 UTC. 11:59 < core-meetingbot> Minutes: https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2021/bitcoin-core-dev.2021-01-07-19.00.moin.txt 11:59 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:01 < sipa> luke-jr: a comment on your addition to the release notes... i think it's confusing (mixing measuring support/opinions vs measuring safety of updating), and i don't think it means much in any case as update patterns for major versions are very different from minor ones 12:02 < dongcarl> Would love to get some review on #19683, which is blocking Guix progress right now. 12:02 < gribble> https://github.com/bitcoin/bitcoin/issues/19683 | depends: Pin clang search paths for darwin host by dongcarl · Pull Request #19683 · bitcoin/bitcoin · GitHub 12:03 < sipa> that said the release notes should probably say something about non-active taproot support being included? 12:03 < luke-jr> sipa: the goal is to encourage users to mimick the softofrk upgrade pattern 12:04 < sipa> luke-jr: yes, i understand, but i don't think it achieves that 12:04 < sipa> major releases are fundamentally different from minor ones 12:04 < luke-jr> sipa: not perfectly, no, but it should get us closer? 12:04 < sipa> as is, i think the comment adds more confusion than it helps anything 12:04 < luke-jr> right now it looks like upgrades take a very long time 12:05 < wumpus> luke-jr: can you rebase #14066 please? I think it makes sense to add a new platform in the beginning of the release cycle for 0.21, not at the end, or should I pick it up? 12:05 < gribble> https://github.com/bitcoin/bitcoin/issues/14066 | gitian-linux: Build binaries for 64-bit POWER by luke-jr · Pull Request #14066 · bitcoin/bitcoin · GitHub 12:05 < wumpus> 22.0* 12:05 < luke-jr> wumpus: sure 12:05 < jonasschnelli> scanning a xpub with scanblocks (#20664) from block 400'000 to tip on a standard machine takes 1m35s (m/0/* m/1/*, range 0-250). That unexpected fast IMO. 12:05 < gribble> https://github.com/bitcoin/bitcoin/issues/20664 | Add scanblocks RPC call by jonasschnelli · Pull Request #20664 · bitcoin/bitcoin · GitHub 12:05 < sipa> jonasschnelli: nice 12:06 < jonasschnelli> Combining this with rescanblockchain (importing older wallets),.. 12:06 < jonasschnelli> and add support for blockfilters in prune mode 12:07 < jonasschnelli> from genesis ist also only 2m13s 12:07 < sipa> jonasschnelli: the scanblocks approach can't be used for pre-descriptor wallets iirc, because we don't have a way to enumerate all sPKs that match a wallet (i think; achow101 may have) 12:08 < luke-jr> sipa: eh, I would think it's easier for older wallets 12:08 < jonasschnelli> sipa: good point 12:08 < luke-jr> oh, because of the key mutability 12:08 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 264 seconds] 12:09 < achow101> there's a commit in the descriptor wallet migration pr to compute all spks for a legacy wallet 12:09 < sipa> luke-jr: take things into account like importing a multisig script may result in suddenly making the P2SH version of it watched, but only under the condition that all the related keys are in the wallet etc 12:09 < sipa> it's definitely possible, just nontrivial 12:09 < sipa> achow101: ok cool 12:10 < jonasschnelli> I guess fastscan versus deepscan could be an option for legacy wallets... 12:11 < jonasschnelli> I guess there is no way to detect whether a deepscan is necessary for a legacy wallet before actually completing a deepscan and compare with a fastscan. 12:11 < sipa> not sure what those terms mean 12:12 < jonasschnelli> fastscan (blockfilter), deepscan (how we do it now) 12:12 < sipa> they shouldn't ever differ? 12:12 < jonasschnelli> [...] because we don't have a way to enumerate all sPKs that match a wallet (i think; achow101 may have) 12:12 < sipa> if we have the code for doing the fast one, and we're confident in it, we should use it 12:12 < sipa> otherwise we shouldn't do it at all 12:13 < sipa> jonasschnelli: i should have said "that is blocked on having such functionality, which is nontrivial" - but it's not impossible 12:13 < jonasschnelli> ok 12:16 -!- Laur [d5e96edd@213.233.110.221] has joined #bitcoin-core-dev 12:21 -!- Laur [d5e96edd@213.233.110.221] has left #bitcoin-core-dev [] 12:22 < sipa> fwiw, i've enabled cirrus CI for the bitcoin-core/secp256k1 repo 12:22 < sipa> is that potentially using up some credits someone paid for? 12:22 < sipa> MarcoFalke: ? 12:22 < MarcoFalke> no 12:23 < sipa> those are only on the bitcoin org? 12:23 < MarcoFalke> There are some free credits: https://cirrus-ci.com/settings/github/bitcoin-core 12:23 -!- GankMove [~GankMove@dsl-lprbng11-54f88d-13.dhcp.inet.fi] has quit [Read error: Connection reset by peer] 12:23 < MarcoFalke> But they won't get used unless you specify `use_compute_credits: true` in the yaml 12:24 < MarcoFalke> Credits for the other org: https://cirrus-ci.com/settings/github/bitcoin 12:25 < sipa> ok great 12:25 < real_or_random> nice ok 12:36 < sipa> dongcarl: the song on 19683 is great (thanks aj?) 12:37 < dongcarl> Hehe yeah all credits to aj! 12:38 < sipa> what is $$(...) ? 12:38 < sipa> doesn't seem to work in my shell 12:39 < sipa> in https://github.com/bitcoin/bitcoin/pull/19683/commits/107f33d434ebbe6f93fa187e2af1f6f850e82d3b 12:41 < jb55> isnt that a makefile 12:41 < sipa> oh, it's makefile-quoting $ 12:42 < sipa> jb55: thanks, indeed 12:42 < wumpus> right it's token concatenation in make 12:44 < wumpus> or, no, you're right, it's quoting 12:48 < sipa> lol @ rwc2021 registration 12:48 < sipa> "Enter the last name of one of the inventors of RSA to prove that you are human." 12:49 < real_or_random> yeah they're using the same captcha for all their conferences now 12:49 < sdaftuar> Cocks? 12:49 < real_or_random> yes, Cocks workds 12:50 < sipa> nice 12:52 < real_or_random> and they'll have a virtual "cards against cryptography" game in the venue :D 12:52 < real_or_random> "venue" 12:53 -!- troygior1hev [~troygiors@bras-base-barion1858w-grc-01-216-209-164-24.dsl.bell.ca] has joined #bitcoin-core-dev 12:53 < sipa> real_or_random: haha 12:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:58 < bitcoin-git> [bitcoin] achow101 opened pull request #20880: gitian: Use custom MacOS code signing tool (master...use-signapple) https://github.com/bitcoin/bitcoin/pull/20880 12:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:58 < achow101> ^ hopefully that's the end of this code signing saga 12:59 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 13:02 -!- crisn2blink [d12203c2@regus-business-centers-katy-209-34-3-194.consolidated.net] has quit [Remote host closed the connection] 13:04 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 13:05 < dongcarl> sipa: When you eval a call in make, it is sometimes necessary to double-quote using $$, see: https://www.gnu.org/software/make/manual/html_node/Eval-Function.html 13:06 * dongcarl has a branch that double-quotes all of our eval'd calls in depends and should publish that at some point 13:06 -!- mol [~mol@unaffiliated/molly] has quit [Read error: Connection reset by peer] 13:07 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 13:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:08 < bitcoin-git> [bitcoin] laanwj pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/d7e2401c629b...86a8b35f321d 13:08 < bitcoin-git> bitcoin/master f6cec0b Evan Klitzke: util: Refactor FileCommit from an #if sequence nested in #else, to a seque... 13:08 < bitcoin-git> bitcoin/master 844d650 Evan Klitzke: util: Prefer Mac-specific F_FULLSYNC over fdatasync in FileCommit 13:08 < bitcoin-git> bitcoin/master ce5cbae Evan Klitzke: util.h: Document FileCommit function 13:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:08 < bitcoin-git> [bitcoin] laanwj merged pull request #14501: Fix possible data race when committing block files (master...fsync_dir) https://github.com/bitcoin/bitcoin/pull/14501 13:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:09 < sipa> dongcarl: cool, thx 13:09 < dongcarl> :-) 13:15 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 13:15 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 13:15 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 13:15 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 13:25 -!- Kozuch [~Kozuch@81.0.198.168] has joined #bitcoin-core-dev 13:41 < sipa> achow101: i'm confused about 20871... it looks like p3yot3 is already using 0.21 code? 13:41 < achow101> sipa: I'm pretty sure the problem is that the wallet version is 169900 but there is no hd seed 13:41 < achow101> the only way to resolve that is to do the upgrade again with 0.21 13:42 < achow101> this is quite an unfortunate bug. in 0.17, we added upgrading to hd wallets, but forgot about encrypted wallets. if you tried to do that with an encrypted wallet, the version number would be increased, but no hd stuff created 13:45 < sipa> so what's the problem? i thought he didn't want to run pre-release code, but he clearly already is 13:45 < achow101> the problem is he didn't do upgradewallet 13:46 < achow101> I'm writing a response with some more detail 13:46 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 13:49 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 256 seconds] 13:54 -!- troygior1hev [~troygiors@bras-base-barion1858w-grc-01-216-209-164-24.dsl.bell.ca] has quit [Ping timeout: 256 seconds] 13:57 -!- glozow [uid453516@gateway/web/irccloud.com/x-netvovtobqfafxal] has quit [Quit: Connection closed for inactivity] 13:59 -!- MTennis [~Tennis@unaffiliated/tennis] has quit [Read error: Connection reset by peer] 13:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:59 < bitcoin-git> [gui] hebasto opened pull request #177: Use "fusion" style on macOS Big Sur with old Qt (master...210107-style) https://github.com/bitcoin-core/gui/pull/177 13:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:03 -!- kvaciral [~kvaciral@212.8.251.11] has quit [Quit: leaving] 14:07 -!- Guyver2__ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 14:10 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 256 seconds] 14:10 -!- Kozuch [~Kozuch@81.0.198.168] has quit [Quit: Leaving] 14:11 -!- Kozuch [~Kozuch@81.0.198.168] has joined #bitcoin-core-dev 14:14 -!- tralfaz [~davterra@static-198-54-134-60.cust.tzulo.com] has joined #bitcoin-core-dev 14:18 -!- davterra [~davterra@static-198-54-134-68.cust.tzulo.com] has quit [Ping timeout: 265 seconds] 14:23 -!- schulzemic [~ada@193.27.14.104] has joined #bitcoin-core-dev 14:24 -!- Guyver2__ [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:36 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 14:49 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has quit [Quit: The Lounge - https://thelounge.chat] 15:02 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 264 seconds] 15:12 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 15:13 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 15:18 -!- lightlike [~lightlike@p200300c7ef19fc0034e2d3ab670ebeac.dip0.t-ipconnect.de] has quit [Quit: Leaving] 15:31 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 15:40 -!- schulzemic [~ada@193.27.14.104] has quit [Quit: Konversation terminated!] 15:42 -!- Kozuch [~Kozuch@81.0.198.168] has quit [Quit: Leaving] 15:45 -!- Tennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev 15:48 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 240 seconds] 15:52 -!- tralfaz is now known as davterra 16:03 -!- promag [~promag@188.250.84.129] has quit [Remote host closed the connection] 16:04 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev 16:08 -!- promag [~promag@188.250.84.129] has quit [Ping timeout: 246 seconds] 16:09 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has quit [Ping timeout: 264 seconds] 16:13 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has joined #bitcoin-core-dev 16:18 -!- rex4539 [~rex4539@8.40.29.14] has joined #bitcoin-core-dev 16:18 -!- rex4539 [~rex4539@8.40.29.14] has quit [Client Quit] 16:23 -!- Tennis [~Tennis@unaffiliated/tennis] has quit [Read error: Connection reset by peer] 16:30 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:12e2:1db3:d5d3:fa35:5ac1] has joined #bitcoin-core-dev 16:35 -!- rex4539 [~rex4539@8.40.29.14] has joined #bitcoin-core-dev 16:35 -!- rex4539 [~rex4539@8.40.29.14] has quit [Client Quit] 16:36 -!- rex4539 [~rex4539@8.40.29.14] has joined #bitcoin-core-dev 16:36 -!- rex4539 [~rex4539@8.40.29.14] has quit [Client Quit] 16:40 -!- rex4539 [~rex4539@8.40.29.14] has joined #bitcoin-core-dev 16:40 -!- rex4539 [~rex4539@8.40.29.14] has quit [Client Quit] 16:56 -!- qubenix_ [~qubenix@66.172.11.228] has joined #bitcoin-core-dev 16:56 -!- qubenix [~qubenix@66.172.11.228] has quit [Read error: Connection reset by peer] 16:56 -!- qubenix_ is now known as qubenix 17:09 -!- rex4539 [~rex4539@8.40.29.14] has joined #bitcoin-core-dev 17:10 -!- rex4539 [~rex4539@8.40.29.14] has quit [Client Quit] 17:11 -!- rex4539 [~rex4539@8.40.29.14] has joined #bitcoin-core-dev 17:11 -!- rex4539 [~rex4539@8.40.29.14] has quit [Client Quit] 17:12 -!- rex4539 [~rex4539@8.40.29.14] has joined #bitcoin-core-dev 17:12 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has joined #bitcoin-core-dev 17:15 -!- rex4539 [~rex4539@8.40.29.14] has quit [Client Quit] 17:15 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Read error: Connection reset by peer] 17:15 -!- rex4539 [~rex4539@8.40.29.14] has joined #bitcoin-core-dev 17:16 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev 17:17 -!- rex4539 [~rex4539@8.40.29.14] has quit [Client Quit] 17:17 -!- rex4539 [~rex4539@8.40.29.14] has joined #bitcoin-core-dev 17:17 -!- rex4539 [~rex4539@8.40.29.14] has quit [Client Quit] 17:18 -!- rex4539 [~rex4539@8.40.29.14] has joined #bitcoin-core-dev 17:18 -!- rex4539 [~rex4539@8.40.29.14] has quit [Client Quit] 17:24 -!- rex4539 [~rex4539@8.40.29.14] has joined #bitcoin-core-dev 17:25 -!- rex4539 [~rex4539@8.40.29.14] has quit [Client Quit] 17:26 -!- rex4539 [~rex4539@8.40.29.14] has joined #bitcoin-core-dev 17:27 -!- rex4539 [~rex4539@8.40.29.14] has quit [Client Quit] 17:27 -!- rex4539 [~rex4539@8.40.29.14] has joined #bitcoin-core-dev 17:27 -!- rex4539 [~rex4539@8.40.29.14] has quit [Client Quit] 17:28 < ajonas> luke-jr: To piggyback on sipa's comment re the release notes, maybe I'm being too sensitive, but why would telemetry be ever be included? The mere mention puts me on edge. 17:28 < ajonas> Also, soliciting opposition on Taproot in the release notes seems somewhat out of place. 17:32 -!- rex4539 [~rex4539@8.40.29.14] has joined #bitcoin-core-dev 17:40 -!- rex4539 [~rex4539@8.40.29.14] has quit [] 17:42 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 17:46 -!- rex4539 [~rex4539@8.40.29.14] has joined #bitcoin-core-dev 17:46 -!- rex4539 [~rex4539@8.40.29.14] has quit [Client Quit] 17:47 -!- rex4539 [~rex4539@8.40.29.14] has joined #bitcoin-core-dev 17:49 -!- rex4539 [~rex4539@8.40.29.14] has quit [Client Quit] 17:53 -!- rex4539 [~rex4539@8.40.29.14] has joined #bitcoin-core-dev 17:57 -!- shesek [~shesek@164.90.217.137] has joined #bitcoin-core-dev 17:57 -!- shesek [~shesek@164.90.217.137] has quit [Changing host] 17:57 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 18:01 -!- rex4539 [~rex4539@8.40.29.14] has quit [] 18:13 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Read error: Connection reset by peer] 18:19 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 18:23 -!- rex4539 [~rex4539@8.40.29.14] has joined #bitcoin-core-dev 18:23 -!- rex4539 [~rex4539@8.40.29.14] has quit [Client Quit] 18:26 -!- rex4539 [~rex4539@8.40.29.14] has joined #bitcoin-core-dev 18:27 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 18:28 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev 18:28 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 246 seconds] 18:29 -!- rex4539 [~rex4539@8.40.29.14] has quit [Client Quit] 18:30 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 18:32 -!- rex4539 [~rex4539@8.40.29.14] has joined #bitcoin-core-dev 18:32 -!- rex4539 [~rex4539@8.40.29.14] has quit [Client Quit] 18:36 -!- rex4539 [~rex4539@8.40.29.14] has joined #bitcoin-core-dev 18:36 -!- rex4539 [~rex4539@8.40.29.14] has quit [Client Quit] 18:37 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 18:40 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Client Quit] 18:40 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 18:41 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Client Quit] 18:41 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 18:45 < fanquake> I agree with sipa & ajonas. Really not sure about the addition of that paragraph 18:46 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [] 18:47 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 18:54 < luke-jr> ajonas: I mentioned it because it wouldn't be good if users got the false impression we were using telemetry 18:54 < luke-jr> contructive would be suggesting how to rephrase it better :P 18:55 < ajonas> That’s fair. 18:57 < ajonas> I think just dropping that part would be best. 18:57 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 19:05 < luke-jr> ajonas: won't people assume there is telemetry then? 19:05 < sipa> why would they? 19:06 < sipa> you make it sound like there is a reason to :) 19:08 < sipa> i don't think the adoption of 0.21.0 is any indication specifically about how safe a softfork _in another release_ is 19:13 < luke-jr> it sets a minimum bound if we advise people treat it as one 19:13 < luke-jr> normally if someone says they're measuring usage of software, it's via telemetry 19:14 < fanquake> sets a minimum bound of what? 19:15 < luke-jr> fanquake: if we say "treat 0.21 as Taproot" and 85% upgrade within a month, we can probably assume a month is a safe timeframe to begin signalling 19:15 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Read error: Connection reset by peer] 19:16 < sipa> i don't think saying that makes that true 19:16 < sipa> most people don't read release notes 19:17 < luke-jr> sipa: if they don't, then it's only likely to be a slower upgrade than 0.21.Taproot 19:17 < sipa> so? 19:18 < luke-jr> so then it's (eg) 2 months, and only 1 month is needed; that's a safe error 19:18 < sipa> you seem to want to use adoption of bitcoin core as telemetry (even if not through an explicit call-home) 19:18 < sipa> i don't think we can do that, at all 19:18 < luke-jr> why not? 19:19 < sipa> because putting something about taproot in the release notes doesn't make "upgrading to 0.21.0" equivalent to "taproot will be safe" 19:19 < sipa> even if you hope it is 19:20 < luke-jr> it's a reasonable basis for a guess 19:20 < luke-jr> _nothing_ can provide a guarantee 19:20 < sipa> i really don't like telling people that a completely unrelated software update will be used as a signal for something unrelated 19:21 < luke-jr> we have nothing else to go on? 19:22 < luke-jr> if not past upgrades, then what? 19:22 < sipa> how has the ecosystem in the past decides that softforks are safe? 19:23 < luke-jr> pure fiat 19:23 < sipa> rough consensus 19:24 < luke-jr> that's only been to determine if a softfork should happen or not 19:24 < luke-jr> and "rough consensus" with no inputs would still be arbitrary fiat 19:26 < sipa> that's fair 19:27 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 240 seconds] 19:27 < sipa> (that rough consensus is the standard for doing a softfork or not, not for determining a safe timeline) 19:27 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev 19:27 < sipa> but i think that a safe timeline should be based on historical data, not about upgrades to a specific software version 19:28 < luke-jr> I don't have such historical data, but I suspect it isn't pretty :/ 19:28 < sipa> maybe 19:28 < sipa> it's important that an economically relevant part of the ecosystem updates before activation 19:29 < sipa> but it's hard to see how that translates to software upgrade (of an unrelated major release, of one implementation) 19:29 < luke-jr> eg, today only 39% of the network seems to run a current version (including most recent 0.18 and 0.19) 19:30 < luke-jr> almost 44% run 0.20.x 19:30 < luke-jr> based on this data, it would suggest we may need a year or longer before signalling even starts 19:31 < sipa> i don't have much of an opinion on that 19:31 < luke-jr> my hope of adding to 0.21 relnotes, is to encourage users to upgrade faster and reveal that we can be less slow about it 19:32 < sipa> that doesn't mean they'll also be faster when 0.21.taproot comes out 19:32 < luke-jr> right, but I'd hope if people upgrade specifically because of that relnote, that they will follow through with 0.21.taproot as well 19:32 < sipa> (or alternatively, people may in fact update to a minor release faster than a major one, because they want to wait for the first bugfixes) 19:33 < luke-jr> it's okay if 0.21.taproot is faster than 0.21.0 19:33 < luke-jr> the problem would only be if it was slower 19:33 < sipa> i'm just saying it's a shitty way to measure regardless 19:33 < sipa> and i'm not even sure that what we measure is relevant 19:33 < sipa> observable nodes aren't necessarily economically relevant 19:34 < luke-jr> perhaps, but I don't have anything better to form an informed opinion from 19:36 < sipa> perhaps, but putting something in the release notes isn't going to change that 19:39 < luke-jr> it will make 0.21.0's upgrade rate more positive and informative 19:39 < luke-jr> a new data point to work with 19:40 < luke-jr> (probably; at worst, no new data) 19:42 < sipa> i still find it very strange to mention that in the release notes 19:42 < sipa> it's so unrelated 19:44 < luke-jr> how else would we encourage such an effect? 19:45 < sipa> i'm not sure that we should 19:47 < sipa> and mentioning it just sounds like a weirdly pushy way to upgrade; people should upgrade because they're comfortable with it, not because of what implications their observable node version will have on the network 19:47 < luke-jr> hmm 19:48 < luke-jr> maybe a link to a web poll would be better - but it's harder to anonymise that trustlessly 19:48 < luke-jr> and we have no idea how many don't do the poll 19:49 < sipa> indeed, it's an inherently hard problem 19:49 < queip> sorry if bad idea, but, perhaps include specific option like --signal-taproot, that appends to user agent information visible in p2p (pro/against/ignore, defaulting to ignore) and mention *that* flag, along with info re taproot, in release notes? 19:49 < luke-jr> queip: many people just use the GUI 19:50 < luke-jr> and way too late to add such a thing anyway 19:50 < queip> (and GUI checkbox in options?) 19:50 < sipa> and this is _not_ about acceptance/objection to the idea 19:50 < sipa> this is about whether upgrading is safe 19:50 < luke-jr> sipa: well, we are about to release 0.20.2 also; we could mention that as an alternative way to show upgrade speed? 19:51 < sipa> i'd prefer to not mention it 19:51 < sipa> it's just confusing 19:51 < luke-jr> then we have nothing :| 19:52 < sipa> i don't see the problem 19:52 < sipa> why is it so important? 19:52 < luke-jr> most people don't want to wait until 2022-2023 for Taproot? 19:52 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 19:52 < sipa> okay? 19:53 < luke-jr> and that's the soonest our current data suggests would be safe 19:53 < sipa> i don't see why 19:53 < sipa> node count on the network is a very weak measurement of economically relevant upgrade activity at best 19:54 < luke-jr> it's all we have 19:55 < sipa> we have companies that are known to support it 19:55 < luke-jr> so companies decide Bitcoin protocol rules now? 19:56 < sipa> what? this isn't about deciding rules 19:56 < sipa> this is about coordinating a safe upgrade 19:56 < luke-jr> safety comes from rule enforcement though 19:57 < sipa> yes, by econonically relevant nodes 19:57 < luke-jr> but if companies are taken to be those, then companies could impose other rules on everyone else too 19:58 < sipa> you're taking this way too far 19:58 < luke-jr> … 19:58 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Remote host closed the connection] 19:58 < sipa> someone should just propose a reasonable upgrade mechanism, ask for feedback, and do it 19:59 < sipa> i have no opinion on what that should be, but i don't think upgrade rates of nodes matter much... and certainly not those of an unrelated software release 20:01 < sipa> and making it sound like upgrade rates will even determine that sounds weird and bad; these things should be decided using a public discussion 20:04 < luke-jr> there is no forum of discussion for all bitcoin users 20:09 < sipa> i would just say "Bitcoin Core 0.21.0 includes an implementation of the proposed Taproot (BIP 341-342) consensus rules, without activation for mainnet. Experimenting with Taproot can be done on the new Signet network where it is already active. Activation parameters will likely be included in a future minor release, and the proposed rules will not be enforced without upgrading to it." 20:09 < sipa> or something like 20:09 < sipa> that 20:10 < sipa> that shows how this release is relevant to taproot, without tying upgrade numbers to how activation will be decided (because, imho, it actually shouldn't) 20:13 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 20:16 < luke-jr> trusting big business to enforce rules is no better than trusting miners to do it 20:16 < luke-jr> even if not a perfect metric, node upgrades should be the primary thing to look at to decide when signalling starting is safe 20:18 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 240 seconds] 20:18 < luke-jr> at the end of the day, businesses need to use what their income/expenses want to pay/be paid with 20:24 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has quit [Ping timeout: 264 seconds] 20:26 -!- jeremyrubin [~jr@2607:fb90:80c6:2a8c:fdb1:1ef8:20dc:9b3c] has joined #bitcoin-core-dev 20:30 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 20:42 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 3.0] 20:55 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 20:55 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services] 20:55 -!- vasild_ is now known as vasild 20:55 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection] 20:56 < dhruvm> Where can I learn more about how the hardcoded seeds in contrib/seeds/nodes_main.txt are chosen each release? 20:57 < wumpus> dhruvm: #20237 #18506 etc 20:57 < gribble> https://github.com/bitcoin/bitcoin/issues/20237 | net: Hardcoded seeds update for 0.21 by laanwj · Pull Request #20237 · bitcoin/bitcoin · GitHub 20:57 < gribble> https://github.com/bitcoin/bitcoin/issues/18506 | net: Hardcoded seeds update for 0.20 by laanwj · Pull Request #18506 · bitcoin/bitcoin · GitHub 20:57 < dhruvm> Thanks, wumpus 21:00 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 21:01 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:12e2:1db3:d5d3:fa35:5ac1] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 21:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 21:12 < bitcoin-git> [bitcoin] laanwj pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/86a8b35f321d...76b45d5fd7eb 21:12 < bitcoin-git> bitcoin/master 107f33d Carl Dong: depends: Delay expansion of per-package vars 21:12 < bitcoin-git> bitcoin/master 3007339 Carl Dong: depends: Pin clang search paths for darwin host 21:12 < bitcoin-git> bitcoin/master 77b1ef8 Carl Dong: depends: Remove -fuse-ld line 21:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 21:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 21:12 < bitcoin-git> [bitcoin] laanwj merged pull request #19683: depends: Pin clang search paths for darwin host (master...2020-08-clang-search-path-robustness) https://github.com/bitcoin/bitcoin/pull/19683 21:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 21:30 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection] 21:31 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 21:31 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Remote host closed the connection] 21:33 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds] 21:46 -!- jonatack [~jon@213.152.162.99] has quit [Ping timeout: 240 seconds] 21:46 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 21:48 -!- jonatack [~jon@88.124.242.136] has joined #bitcoin-core-dev 21:49 -!- jeremyrubin [~jr@2607:fb90:80c6:2a8c:fdb1:1ef8:20dc:9b3c] has quit [Ping timeout: 260 seconds] 21:51 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 240 seconds] 22:04 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 22:05 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has quit [Ping timeout: 256 seconds] 22:07 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has joined #bitcoin-core-dev 22:07 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Remote host closed the connection] 22:18 -!- jespada [~jespada@90.254.245.49] has quit [Ping timeout: 240 seconds] 22:22 -!- jespada [~jespada@90.254.245.49] has joined #bitcoin-core-dev 22:22 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 22:25 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Remote host closed the connection] 22:42 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 22:47 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 240 seconds] 23:09 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has quit [Ping timeout: 240 seconds] 23:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:12 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20881: fuzz: net permission flags in net processing (master...2101-fuzzNet) https://github.com/bitcoin/bitcoin/pull/20881 23:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:19 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 23:21 -!- winz_0 [~winz@somebodyjust.farted.net] has quit [Quit: Ping timeout (120 seconds)] 23:21 -!- winz_0 [~winz@somebodyjust.farted.net] has joined #bitcoin-core-dev 23:23 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 240 seconds] 23:36 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 23:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:37 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/76b45d5fd7eb...5082324225bf 23:37 < bitcoin-git> bitcoin/master a7599c8 Michael Dietz: test: run mempool_compatibility.py even with wallet disabled 23:37 < bitcoin-git> bitcoin/master 5082324 MarcoFalke: Merge #20688: test: run mempool_compatibility.py even with wallet disabled... 23:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:38 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20688: test: run mempool_compatibility.py even with wallet disabled (master...mempool-compatibility-to-miniwallet) https://github.com/bitcoin/bitcoin/pull/20688 23:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:38 -!- virtu [~virtu@gateway/tor-sasl/virtu] has quit [Remote host closed the connection] 23:39 -!- az0re [~az0re@gateway/tor-sasl/az0re] has quit [Quit: Leaving] 23:39 -!- virtu [~virtu@gateway/tor-sasl/virtu] has joined #bitcoin-core-dev 23:40 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Remote host closed the connection] 23:53 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev 23:54 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 23:57 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection] 23:58 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 240 seconds] --- Log closed Fri Jan 08 00:00:09 2021