--- Log opened Wed Jan 13 00:00:14 2021
00:01 < fanquake> wumpus: I like how GH is 2/4 when rendering your avatar in dark mode..
00:01 < fanquake> https://0bin.net/paste/6ajdCt0b#AVXlGRuYmR9zWXvQI7ymi7ej783qLPcu4isqeLBGdnv
00:02 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has joined #bitcoin-core-dev
00:05 < wumpus> fanquake: yea it's interesting how many websites don't take transparency in avatars into account and do the weirdest things, github sometimes adds a white circle behind it, sometimes shows it as transparent... and sometimes, adds only weird white lines :)
00:20 -!- asoltys [~root@s207-81-214-2.bc.hsia.telus.net] has quit [Ping timeout: 246 seconds]
00:25 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
00:31 -!- virtu [~virtu@gateway/tor-sasl/virtu] has quit [Remote host closed the connection]
00:32 -!- asdlkfjwerpoicvx [~flack@p200300d46f24de00a0f0fc7b4b585d7b.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
00:42 -!- tadeo [~tadeo@185.103.96.147] has quit [Remote host closed the connection]
00:43 -!- hoobop1 [~hoobop@84.39.117.57] has joined #bitcoin-core-dev
00:45 -!- virtu [~virtu@gateway/tor-sasl/virtu] has joined #bitcoin-core-dev
00:46 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
00:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:48 < bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/8ffaf5c2f5aa...60427ee35f28
00:48 < bitcoin-git> bitcoin/master 0d246a5 Anthony Towns: net, net_processing: move NetEventsInterface method docs to net.h
00:48 < bitcoin-git> bitcoin/master 0df3d3f Anthony Towns: net_processing: make more of PeerManager private
00:48 < bitcoin-git> bitcoin/master a568b82 Anthony Towns: net_processing: split PeerManager into interface and implementation classes
00:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:49 < bitcoin-git> [bitcoin] laanwj merged pull request #20811: refactor: move net_processing implementation details out of header (master...202012-netproc-impl-split) https://github.com/bitcoin/bitcoin/pull/20811
00:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:52 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
00:57 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds]
00:58 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:255c:8c1d:42fb:24ab:a8e9] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
01:03 < wumpus> that said my avatar doesn't really work that well in dark mode (black on grey), should probably make it a color that works in either setting like purple
01:04 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
01:16 < darosior> re wiki: Ok, thanks
01:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:16 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/60427ee35f28...e7eb37128c31
01:16 < bitcoin-git> bitcoin/master b5e93f8 Wladimir J. van der Laan: doc: Add manual page generation for bitcoin-util
01:16 < bitcoin-git> bitcoin/master bc99ae7 Wladimir J. van der Laan: scripted-diff: Fix typo in stub manual pages
01:16 < bitcoin-git> bitcoin/master e7eb371 Wladimir J. van der Laan: Merge #20913: doc: Add manual page generation for bitcoin-util
01:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:17 < bitcoin-git> [bitcoin] laanwj merged pull request #20913: doc: Add manual page generation for bitcoin-util (master...2021_01_bitcoin_util_manpage) https://github.com/bitcoin/bitcoin/pull/20913
01:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:24 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
01:27 < MarcoFalke> > [22:11] <wumpus> unless anything comes up, i plan on merging the wiki back into the branch then tagging 0.21.0 final tomorrow
01:27 < MarcoFalke> ACK
01:41 < jonatack> wumpus: oh! i know that well. trying to remember when i did that
01:43 < jonatack> wumpus: ah, when i wrote @ <commit>?
01:44 < jonatack> i wrote "ran node @ head as a sanity check", didn't realize that would cause an issue
01:45 < jonatack> (fixed)
01:45 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
01:53 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
01:53 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
01:54 < wumpus> jonatack: thanks, it's not a big deal, @'s can appear for various reasons, but it prompted me to write https://github.com/bitcoin-core/bitcoin-maintainer-tools/pull/69
02:04 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has quit [Remote host closed the connection]
02:04 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has joined #bitcoin-core-dev
02:19 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Ping timeout: 256 seconds]
02:27 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has quit [Ping timeout: 264 seconds]
02:36 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:255c:8c1d:42fb:24ab:a8e9] has joined #bitcoin-core-dev
02:58 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:255c:8c1d:42fb:24ab:a8e9] has quit [Ping timeout: 264 seconds]
03:05 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit []
03:18 -!- Alva35Walter [~Alva35Wal@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev
04:37 -!- Alva35Walter [~Alva35Wal@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 240 seconds]
04:44 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection]
04:44 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
04:56 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:255c:8c1d:42fb:24ab:a8e9] has joined #bitcoin-core-dev
04:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:59 < bitcoin-git> [bitcoin] jnewbery opened pull request #20925: RFC: Move Peer and PeerManagerImpl to separate header (master...2021-01-peermanimplh) https://github.com/bitcoin/bitcoin/pull/20925
04:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:05 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 3.0]
05:27 -!- norisgOG_ [~norisgOG@89.45.6.92] has joined #bitcoin-core-dev
05:27 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
05:31 < norisgOG_> Hello all I have a question concering signatures in bitcoin, where in the transaction can I see which HASH_Type I have to use to calculate the transaction hash ?
05:37 -!- ogo [~ogo@gateway/tor-sasl/ogo] has quit [Remote host closed the connection]
05:37 -!- Bitcoinr [~Bitcoinr@202.185.196.193] has joined #bitcoin-core-dev
05:43 -!- Bitcoinr is now known as ray
05:44 < wumpus> norisgOG_: #bitcoin please, this channel is for development ony
05:44 -!- ray is now known as rayyy
05:46 -!- rayyy is now known as rayonx
05:47 -!- rayonx is now known as rayyy
05:48 -!- rayyy [~Bitcoinr@202.185.196.193] has quit [Quit: Exit game!]
06:14 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
06:17 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds]
06:20 -!- virtu [~virtu@gateway/tor-sasl/virtu] has quit [Remote host closed the connection]
06:22 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has joined #bitcoin-core-dev
06:36 < vasild> wumpus: what about reverting https://github.com/bitcoin/bitcoin/pull/20852 ?
06:37 < wumpus> vasild: sure, just make a PR that reverts it
06:37 < vasild> ok
06:41 < wumpus> it's too late to rush a revert, but still it's fairly easy to review
06:43 -!- lontivero [~lontivero@186.183.48.235] has joined #bitcoin-core-dev
06:44 < MarcoFalke> why revert?
06:44 < MarcoFalke> Was it wrong? I think it is just incomplete.
06:48 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 240 seconds]
06:48 < wumpus> in that case, better to improve it instead
06:49 < wumpus> the only reason to revert it would be if it's causing major issues to people running master, or there's no clear way forward
06:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:51 < bitcoin-git> [bitcoin] vasild opened pull request #20926: revert #20852 net: allow CSubNet of non-IP networks (master...revert_20852) https://github.com/bitcoin/bitcoin/pull/20926
06:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:55 < wumpus> btw: my release notes pull request listing script can't distinguish between gui and main repo PRs, is there a way to do this based on the merge commit message?
06:55 < wumpus> (i had to sort them out manually this time)
06:56 < wumpus> (which is, still, pretty easy "low numbers are gui repo" but not really ideal)
06:58 < MarcoFalke> the merge commits start with "bitcoin-core/gui#123 remove foobar"
06:58 < gribble> https://github.com/bitcoin/bitcoin/issues/123 | Spent per txout by sipa · Pull Request #123 · bitcoin/bitcoin · GitHub
06:58 < MarcoFalke> so you can do title.startswith('Merge bitcoin-core/gui#')
06:59 < wumpus> MarcoFalke: thanks
06:59 < wumpus> that sounds easy :)
07:00 < wumpus> I did use the gui#1234 convention in the release notes, likely we need to update the bitcoin-core.org HTML-izing plugin as well to recognize these and generate valid links to them
07:00 < gribble> https://github.com/bitcoin/bitcoin/issues/1234 | During initial sync, chain download pauses if peer goes away · Issue #1234 · bitcoin/bitcoin · GitHub
07:06 < vasild> MarcoFalke: so you decide to ban torv3.onion, do "setban torv3.onion add". The ban is effective and works. 2 days later bitcoin core is restarted. The ban is lost, silently.
07:06 < MarcoFalke> what would happen with the revert?
07:06 < MarcoFalke> does the rpc fail silently or verbosely?
07:07 < vasild> let me see...
07:08 < MarcoFalke> Either way, it shouldn't matter much. We are aware of the issue and know that the file format needs to change. Reverting the pull doesn't help changing the file format.
07:08 < wumpus> i guess it's this fragment: https://github.com/bitcoin-core/bitcoincore.org/blob/master/_includes/link-to-issues.md   also ping @harding 
07:09 < harding> hi
07:09 < vasild> $ bitcoin-cli setban pg6mmjiyjmcrsslvykfwnntlaru7p5svn6y2ymmju6nubxndf4pscryd.onion add
07:09 < vasild> $
07:09 < MarcoFalke> So this also silently fails
07:09 < vasild> (success)
07:09 < vasild> the log says "SweepBanned: Removed banned node ip/subnet from banlist.dat: ::/0"
07:10 < wumpus> harding: hi! for 0.21.0 we have a new kind of PR which comes from the bitcoin-core/gui repository, I've used the syntax "gui/#xxxx" to refer to these, if we want these to point to the right repository we'll need to update the link conversion
07:10 < vasild> (but nobody reads the log anyway)
07:10 < MarcoFalke> If you are worried that someone is running master and doesn't see the silent fail, you can turn it into a verbose fail. Though I'd rather prefer to spend the resources on fixing the file format
07:11 < vasild> MarcoFalke: ok, but at least if the tries to verify if the ban succeeded he will see it did not. While with the PR it will work for some time, until a restart...
07:11 < harding> wumpus: got it.  I think that should, if we do nothing, just not produce a link, which isn't ideal but at least isn't broken.  I'll look into making it work.  Thanks for the heads-up!
07:12 < wumpus> harding: that's good to know! i was afraid it would make a link to the bitcoin/bitcoin issue of the same number that would be bad, but yes that seems acceptable really
07:12 < vasild> but you are right, the difference is not so big, while the PR still fixes the DisconnectNode() issue properly
07:12 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:255c:8c1d:42fb:24ab:a8e9] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
07:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:16 < bitcoin-git> [bitcoin] vasild closed pull request #20926: revert #20852 net: allow CSubNet of non-IP networks (master...revert_20852) https://github.com/bitcoin/bitcoin/pull/20926
07:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:18 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:255c:8c1d:42fb:24ab:a8e9] has joined #bitcoin-core-dev
07:20 < vasild> What about changing banman to maintain a list of banned IP-subnets (like before 20852) - no format change in banlist.dat. Plus add a list of banned hosts and save it in `banhosts.dat` (always in addrv2 format)
07:21 < vasild> that looks like a perfect forward/backward/sideways file format compatibility
07:23 < MarcoFalke> #19748 
07:23 < gribble> https://github.com/bitcoin/bitcoin/issues/19748 | Deprecate banlist.dat · Issue #19748 · bitcoin/bitcoin · GitHub
07:24  * vasild reading...
07:26 < MarcoFalke> json probably means we can skip the serialization/deserialization and just dump the rpc argument directly
07:28 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev
07:29 < MarcoFalke> Though on startup (when the json doesn't exist) you'd have to convert the banlist.dat once to json. Not sure if that is easily possible.
07:30 -!- virtu [~virtu@gateway/tor-sasl/virtu] has joined #bitcoin-core-dev
07:30 < vasild> MarcoFalke: we have CSubNet::ToString()
07:31 < MarcoFalke> oh nice
07:32 < vasild> so, looks like putting the entries in a .json would resolve any file format addrv1 vs addrv2 issues. Will be bigger on disk and slower to write/read, but insignificantly.
07:34 < wumpus> most people aren't going to have that many bans for it to matter wrt start-up performance i guess :)
07:34 < MarcoFalke> The network has 100k nodes, so even if all nodes are banned in the json file, it should be still smaller than the largest wallet.dat we've seen
07:35 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
07:35 < wumpus> i wouldn't suggest doing the same for the peers.dat
07:36 < vasild> 100k x ~20 bytes per entry =~ 2MiB
07:36 < jonatack> i used to have a lot of bans, but it's been awhile since i was able to find the banlist, is it still online/maintained? 
07:37 < vasild> yes! :-)
07:37 < jonatack> iirc it was 700-1000 entries last time i saw it
07:37 < wumpus> gmaxwell used to maintain a ban list, but don't know if he did for a while
07:38 < jonatack> yes that one
07:38 < vasild> my "yes!" was for the banlist.dat file in the datadir
07:39 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
07:41 < vasild> I have a node that is permanently online and listening on ipv4/6 and banlist.dat is 37 bytes (I guess empty list). Lets focus on whether to put it in settings.json or in banlist.json ...
07:41 < wumpus> a separate file still makes sense imo
07:42 < jonatack> agree, banlist.json
07:45 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
07:45 < vasild> +1
07:45 < luke-jr> is github working poorly for others as well?
07:47 < vasild> luke-jr: poorly == slowly?
07:47 < jb55> like more than normal?
07:51 < luke-jr> vasild: possibly; I clicked "cancel" (to change the scope of my review comment) and it ignored me
07:52 < vasild> luke-jr: I have seen that too - clicks being ignored
08:16 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
08:23 -!- pinheadmz [~pinheadmz@68.161.139.178] has quit [Remote host closed the connection]
08:23 -!- pinheadmz [~pinheadmz@68.161.139.178] has joined #bitcoin-core-dev
08:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:33 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e7eb37128c31...22fa9673b02e
08:33 < bitcoin-git> bitcoin/master fc726e0 Sebastian Falbesoner: doc, rpc: add missing signet mentions in network name lists
08:33 < bitcoin-git> bitcoin/master 22fa967 MarcoFalke: Merge #20917: doc, rpc: add missing signet mentions in network name lists
08:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:33 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20917: doc, rpc: add missing signet mentions in network name lists (master...2021-add_missing_signet_network_name) https://github.com/bitcoin/bitcoin/pull/20917
08:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:36 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:255c:8c1d:42fb:24ab:a8e9] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
08:37 -!- kexkey [~kexkey@static-198-54-132-157.cust.tzulo.com] has joined #bitcoin-core-dev
08:39 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has quit []
08:39 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:255c:18d1:c1a9:13be:6f9e] has joined #bitcoin-core-dev
08:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:40 < bitcoin-git> [bitcoin] jnewbery opened pull request #20927: [refactor] [net] Clean up InactivityCheck() (master...2021-01-timeout-cleanup) https://github.com/bitcoin/bitcoin/pull/20927
08:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:40 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
08:41 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
08:43 -!- jouke [~jouke@a80-100-203-151.adsl.xs4all.nl] has quit [Ping timeout: 260 seconds]
08:43 -!- jouke [~jouke@a80-100-203-151.adsl.xs4all.nl] has joined #bitcoin-core-dev
08:47 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:255c:18d1:c1a9:13be:6f9e] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
08:48 < wumpus> no problems here with github today (but haven't checked if blocking works again)
08:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:49 < bitcoin-git> [gui] MarcoFalke merged pull request #148: Bugfix: GUI: Restore SendConfirmationDialog button default to "Yes" (master...bugfix_gui_bumpyes) https://github.com/bitcoin-core/gui/pull/148
08:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:49 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Remote host closed the connection]
08:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:49 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/22fa9673b02e...cb2c57845177
08:49 < bitcoin-git> bitcoin/master 8775691 Luke Dashjr: Bugfix: GUI: Restore SendConfirmationDialog button default to "Yes"
08:49 < bitcoin-git> bitcoin/master cb2c578 MarcoFalke: Merge bitcoin-core/gui#148: Bugfix: GUI: Restore SendConfirmationDialog bu...
08:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:50 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev
08:52 < achow101> can someone invite me into ##bitcoin-core-gui?
08:55 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has joined #bitcoin-core-dev
08:57 < hebasto> achow101: jonasschnelli can
08:59 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
08:59 < hebasto> achow101: cannot get op access to invite you
09:00 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
09:00 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection]
09:03 -!- asdlkfjwerpoicvx [~flack@p200300d46f24de00a0f0fc7b4b585d7b.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!]
09:04 -!- larryruane_ [uid473749@gateway/web/irccloud.com/x-tuzsiyftnkimzhqh] has joined #bitcoin-core-dev
09:05 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
09:12 < harding> wumpus: for the website release notes, https://github.com/bitcoin-core/bitcoincore.org/pull/733 
09:14 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
09:19 -!- ggmonello [5d28fbe3@93-40-251-227.ip41.fastwebnet.it] has joined #bitcoin-core-dev
09:21 -!- ggmonello [5d28fbe3@93-40-251-227.ip41.fastwebnet.it] has quit [Client Quit]
09:23 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
09:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:23 < bitcoin-git> [bitcoin] cybercore-tech opened pull request #20928: Create sustainable_wallet (master...patch-1) https://github.com/bitcoin/bitcoin/pull/20928
09:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:26 < wumpus> harding: thanks!!!
09:34 < luke-jr> why is ##bitcoin-core-gui invite-only in the first place?
09:35 < wumpus> to keep me out probably 😀
09:36 < luke-jr> :|
09:37 < wumpus> (TIL that that channel even exists)
09:38 < luke-jr> I'm usually there, but the +i messes up my rejoin on reconnect :/
09:41 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]
09:45 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has joined #bitcoin-core-dev
09:56 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
09:56 -!- Mercury_Vapor [~Mercury_V@174-082-158-108.res.spectrum.com] has quit [Read error: Connection reset by peer]
09:58 < achow101> luke-jr: I think it's because there was a bunch of spammers a few weeks ago
10:00 -!- jespada [~jespada@90.254.245.49] has quit [Ping timeout: 272 seconds]
10:00 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/]
10:00 < jb55> ah yes the antigui folks. ruthless bunch.
10:02 -!- jespada [~jespada@90.254.245.49] has joined #bitcoin-core-dev
10:02 < luke-jr> XD
10:03 < luke-jr> jb55: they only get that bad because Trump incited them <.< *hides*
10:04 < wumpus> usually requiring nickserv sign in (+r) is enough to get rid of spammers
10:05 < luke-jr> plot twist: the "spam" was just my IRC connection dropping/reconnecting in the first place
10:16 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
10:16 -!- prayank [~andr0irc@2405:205:2180:41f3:133:6444:5db:787c] has joined #bitcoin-core-dev
10:19 < prayank> Hello World. It will be helpful if one of the experienced devs could comment on this issue with : 1. Do we need to fix this? 2. What's the problem? 3. What should be the approach to fix it
10:20 < prayank> https://github.com/bitcoin/bitcoin/issues/20795
10:21 < wumpus> is everyone done editing the release notes for 0.21.0? i'd like to merge them back into the branch
10:22 < sipa> prayank: there are several open PRs that improve coin selection, but there is currently not much activity on them
10:23 < sipa> wumpus: i think that's fine
10:23 < wumpus> if manual coin selection automatically adds an extra input in some case that does definitely sound like a bug
10:24 < prayank> sipa: So the problem is with coin selection algorithm? Why is coin selection being used though if user had selected some inputs in initial tx? Or if it's designed to work like this then a warning is required so that user is aware of it
10:24 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
10:24 < sipa> prayank: eh, the wallet doesn't know that the original transaction was using coin control
10:24 < prayank> Interesting
10:26 < sipa> so i think it's expected that if you use automatic fee bumping, you'll get whatever the coin selection algorithm decides
10:27 < sipa> as for why it's not decreasing the change and instead adding another input... that may be a bug or a deficiency
10:28 < luke-jr> wumpus: ugh, it looks like MarcoFalke simply deleted the Taproot paragraph -.-
10:28 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
10:31 < prayank> sipa: Thanks. I will do more research.
10:32 -!- Mercury_Vapor [~Mercury_V@174-082-158-108.res.spectrum.com] has joined #bitcoin-core-dev
10:33 < luke-jr> wumpus: added it back in, with some rephrasing to hopefully address some of the concerns
10:34 < sipa> luke-jr: nack
10:34 < luke-jr> sipa: nack is not constructive
10:34 < sipa> luke-jr: i've spent enough time arguing to explain my position
10:34 < sipa> i don't see how this is any different from what you had before
10:37 -!- norisgOG_ [~norisgOG@89.45.6.92] has quit [Remote host closed the connection]
10:37 < wumpus> many people disagree on adding that paragraph, including the people who worked on taproot, so we're not going to 
10:37 < luke-jr> 1) it suggests the bugfix-only releases as alternative upgrade paths
10:38 < luke-jr> 2) it clarifies the absense of telemetry in the software in a way that should hopefully not be confusing
10:38 < sipa> but you're still literally arguing for telemetry... just not one built-in to the software
10:39 < luke-jr> sipa: the only "telemetry" already exists
10:39 < sipa> yes, general upgrade patterns matter
10:39 < sipa> upgrading to 0.21.0 does not
10:39 < luke-jr> that's the point of the paragraph - to make it matter
10:39 < sipa> it won't
10:40 < luke-jr> if not, then nothing is lost
10:40 < luke-jr> there are no downsides, just potential upsides
10:40 < sipa> just confusion, imho
10:40 < luke-jr> I rephrased it to avoid confusion
10:40 < luke-jr> if you think you can phrase it better, feel free
10:41 < luke-jr> but this is "perfect is enemy of the good" territory
10:41 < sipa> i did; i added a paragraph about how taproot is included but without activation on mainnet, and that testing can be done on signet
10:41 < luke-jr> that doesn't accomplish the same thing at all
10:41 < sipa> i believe that is the extent to which bitcoin core should be involved with this
10:44 < sipa> it just sounds bizarre, making it sound like bitcoin core's maintainers are going to use 0.21 upgrade numbers to decide how activation happens
10:44 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit []
10:44 < luke-jr> developers have no business deciding such things in the first place
10:44 < sipa> yes, so why is that paragraph there?
10:45 < sipa> it'
10:45 < luke-jr> because the upgrade speed of the network IS an important factor to making an educated guess on safe activation speed
10:45 < sipa> s not our job to push for activation
10:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:45 < bitcoin-git> [bitcoin] laanwj opened pull request #20929: doc: Move 0.21.0 release notes from wiki (0.21...2021-01-relnot-0.21.0) https://github.com/bitcoin/bitcoin/pull/20929
10:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:46 < sipa> luke-jr: i agree with that, but i think (a) putting a note in the release notes will not meaningfully affect people's upgrade behavior (b) makes it sound like we (as software maintainers) are taking an active position in its deployment
10:46 < luke-jr> you can ignore the data if you like, but what you're proposing by keeping the paragraph out, is interfering with others freely participating in such data review
10:46 < sdaftuar> luke-jr: that paragraph doesn't add or detract from any data that anyone would review
10:47 < luke-jr> yes it does
10:49 < luke-jr> sipa: I disagree with (a) - if I'm wrong, there's no negative outcome; as for (b), what do you perceive in that way, and how can we avoid giving that impression?
10:51 < sipa> by not talking about activation in our release notes, but just stating the facts: taproot is implemented, not active, can be tested and experimented with... we can add something about how mainnet activation is up for community discussion and will be implemented in a future version when there is agreement on that
10:51 < luke-jr> throwing out the baby with the bathwater is not a solution
10:53 -!- ogo [~ogo@gateway/tor-sasl/ogo] has joined #bitcoin-core-dev
10:54 < sipa> you argue that there is a reasonable chance it helps with anything; for that to be the case, either people would (a) adapt their 0.21 upgrade pattern to whatever they'll use for whatever potential release includes activation or (b) adapt their upgrade pattern for the release that includes activation to much what they're doing for 0.21; further it also requires (c) people participating in the 
10:54 < sipa> discussion on activation to have confidence...
10:54 < sipa> that either (a) or (b) happens sufficiently take the 0.21 upgrade numbers specifically into account; i believe all 3 are false
10:54 < luke-jr> even if all 3 were false, there is no harm done
10:54 < sipa> yes there is
10:54 < luke-jr> until we try, we won't know if you are right
10:55 < sipa> bitcoin core's developers and maintainers shouldn't be using the release notes to further the goal of activation
10:56 < sdaftuar> ^ completely agree
10:56 < luke-jr> not even to the limited extent of helping the community coordinate better data?
10:58  * jeremyrubin doubts anyone even reads the release notes
10:59 < jeremyrubin> it's probably better to just do a separate blog post if you have a point to make IMO
10:59 < luke-jr> hmm
10:59 < luke-jr> I mean, if nobody reads them, why do we even write them? >.>
10:59 < sdaftuar> jeremyrubin: i agree with that too. i think using the release notes to advocate one's own viewpoint is inappropriate in the face of disagreement from other contributors (such as the taproot author!)
11:00 < luke-jr> sdaftuar: it's not even a viewpoint
11:00 < sdaftuar> luke-jr: its a viewpoint about messaging
11:00 < luke-jr> I see your point, I agree in that respect
11:00 < luke-jr> hence why I asked
11:00 < luke-jr> [18:56:21] <luke-jr> not even to the limited extent of helping the community coordinate better data?
11:01 < jeremyrubin> I think a blog post is even more effective to that end
11:01 < luke-jr> jeremyrubin: could be. though nothing limits it to one or the other, if we could agree on something
11:02 < jeremyrubin> and w.r.t. "why write them if no one reads them", clearly people "read them". but I think it's unlikely it's anyone who is not already sufficiently plugged in that such a notice would change anything.
11:02 < sipa> i think it's more likely that someone reads this and wonders why it's mentioned at all and what bitcoin core's role in this is, than that it would affect their upgrade behavior
11:02 < sdaftuar> luke-jr: i also wouldn't really want to participate in some kind of shared "help the developers settle whether there's consensus for activation" process, for what it's worth.  
11:02 < luke-jr> what do folks think about wumpus simply including something to this effect in the ML release announcement?
11:03 < luke-jr> sdaftuar: doh, I guess it's still too unclear, since it's not about consensus for activation :/
11:03 < sdaftuar> i'm including method, timing, etc as part of all that
11:04 < luke-jr> yeah, not even then - that's all discussion to be had *based on* this (and other) data
11:04 < luke-jr> informed by*
11:04 < sipa> it's a very subtle point, the distinction between consensus for activation, and deciding a safe activation mechanism... i think that distinction exists, but it's probably lost on most people
11:05 < sdaftuar> well the point here is whether there is a group that is being spoken for in gathering information to inform debate, i believe
11:05 < sdaftuar> and i am opposed to creating such a group that is somehow affiliated with the bitcoin core software
11:06 < luke-jr> more of just telling people to speak for themselves
11:06 < sdaftuar> i strongly agree with people speaking for themselves!
11:06 < luke-jr> sipa: too subtle to come up with something that can be understood?
11:07 < luke-jr> sdaftuar: well, that's all this is, to the extent that it's speaking at all
11:15 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
11:17 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
11:22 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 264 seconds]
11:36 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev
11:52 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
11:58 < jeremyrubin> Has anyone come across an error where calling removed RPC generate *sometimes* returns error code -1, and sometimes the correct -32601?
12:06 -!- ironhelix [~p@136.144.43.97] has joined #bitcoin-core-dev
12:10 < jeremyrubin> super bizzare
12:11 < jeremyrubin> https://0bin.net/paste/QWvI7bfl#aJJFoALcc-ioThh+pajjWnNEhbfrg60/OsWe+zcD09j
12:12 < jeremyrubin> here's a tcpdump showing a failed request
12:14 -!- prayank [~andr0irc@2405:205:2180:41f3:133:6444:5db:787c] has quit [Ping timeout: 260 seconds]
12:14 < jeremyrubin> https://0bin.net/paste/kmybFKne#nuo8Vr4gm29pYeylnP3cfhib051g617Qw+H9-ncdjX+
12:15 < jeremyrubin> second pastebin tcpdump showing the correct response
12:16 < jeremyrubin> Ah so it's the param null that is the issue
12:17 < jeremyrubin> (was comparing curl and a library)
12:17 < jeremyrubin> I think this is a bug in core though -- method not found should be returned before args are checked?
12:18 < wumpus> jeremyrubin: it will give you -1 if you provide extra arguments
12:18 < wumpus> honestly i have no opinion on the behavior of removed RPC calls :)
12:19 < jeremyrubin> gotcha. It came up because I was working on testing https://github.com/jeremyrubin/rust-jsonrpc-async/ (async port of rust-jsonrpc)
12:20 < jeremyrubin> The integration test checks that methodnotfound is returned for generate above some version
12:20 < jeremyrubin> but it checks with params passed for generate, so it triggers a diff error!
12:21 < jeremyrubin> I think we should probably return methodnotfound ahead of extraarguments?
12:22 < wumpus> it's a by-effect of using RPCHelpMan in a way that's not entirely how it's supposed to, e.g. generate *implements a RPC call* that always gives an error that the RPC call doesn't exist, that said, I expect it's going to be entirely removed in another version or so, no need to put work in it
12:22 < wumpus> RPCHelpMan needs to do it in this order because the argument check needs to happen before entering the inner function body
12:23 < wumpus> sure, you could rewrite it without using RPCHelpMan, but my point is it really doesn't matter
12:25 < jeremyrubin> it could be fixed by preserving the original args I 'spose
12:25 < jeremyrubin> will fix it thos in the library :)
12:28 < wumpus> why call a non-existing RPC at all :) it's only still there as a service to (human) users following old wiki pages with bitcoin-cli, and who tend to care more about the English message than the return code
12:28 < jeremyrubin> To test that a library handles it correctly :)
12:28 < sipa> do we need a test-only permanently-removed RPC? :p
12:29 < jeremyrubin> the rpc is not removed though
12:29 < jeremyrubin> that's what makes it funny
12:29 < jeremyrubin> because it's an RPC which exists that returns methodnotfound
12:31 < sipa> well, it's an RPC is "removed" state
12:31 < sipa> implementation wise something still exists
12:33 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has quit [Read error: Connection reset by peer]
12:33 < wumpus> yes it's a bit of an easter egg, it's also intentionally not listed in "help"
12:33 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has joined #bitcoin-core-dev
12:35 < wumpus> but if you want to deterministically generate a 'method not found' error, send a method name that is unlikely to ever exist like 'sendtoip' :-)
12:36 < jeremyrubin> heh
12:38 < sipa> inflatesupply()
12:39 < jeremyrubin> it's not a huge deal; just a bit of an oddity 
13:03 -!- prayank [~andr0irc@2405:205:2180:41f3:133:6444:5db:787c] has joined #bitcoin-core-dev
13:03 -!- jonatack [~jon@134.19.179.235] has quit [Ping timeout: 246 seconds]
13:05 -!- jonatack [~jon@88.124.242.136] has joined #bitcoin-core-dev
13:05 -!- prayank [~andr0irc@2405:205:2180:41f3:133:6444:5db:787c] has quit [Read error: Connection reset by peer]
13:21 -!- prayank [~andr0irc@2405:205:2180:41f3:133:6444:5db:787c] has joined #bitcoin-core-dev
13:22 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
13:38 -!- lontivero [~lontivero@186.183.48.235] has quit [Ping timeout: 240 seconds]
13:43 -!- dviola [~diego@unaffiliated/dviola] has quit [Ping timeout: 260 seconds]
13:47 -!- dviola [~diego@187.39.20.240] has joined #bitcoin-core-dev
13:48 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 256 seconds]
13:49 -!- jonatack [~jon@88.124.242.136] has joined #bitcoin-core-dev
13:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:52 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.21: https://github.com/bitcoin/bitcoin/compare/15877d160cb8...91f06324640b
13:52 < bitcoin-git> bitcoin/0.21 66e6742 Wladimir J. van der Laan: doc: Move 0.21.0 release notes from wiki
13:52 < bitcoin-git> bitcoin/0.21 91f0632 Wladimir J. van der Laan: Merge #20929: doc: Move 0.21.0 release notes from wiki
13:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:53 < bitcoin-git> [bitcoin] laanwj merged pull request #20929: doc: Move 0.21.0 release notes from wiki (0.21...2021-01-relnot-0.21.0) https://github.com/bitcoin/bitcoin/pull/20929
13:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:53 < bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.21: https://github.com/bitcoin/bitcoin/compare/91f06324640b...95ea54ba0896
13:53 < bitcoin-git> bitcoin/0.21 95ea54b Wladimir J. van der Laan: build: Bump RC to 0 (-final)
13:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:54 < achow101> final soon?
13:56 -!- dviola [~diego@187.39.20.240] has left #bitcoin-core-dev []
13:56 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
13:56 < wumpus> yess
14:02 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 272 seconds]
14:02  * luke-jr wonders if we should fix Big Sur compatibility
14:02 < luke-jr> (for 0.21.0)
14:03 -!- jonatack [~jon@88.124.242.136] has joined #bitcoin-core-dev
14:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:04 < bitcoin-git> [bitcoin] laanwj pushed tag v0.21.0: https://github.com/bitcoin/bitcoin/compare/v0.21.0
14:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:04 < jonatack> jeremyrubin: forgive me if not relevant to your discussion, #19455 was supposed to help here
14:04 < gribble> https://github.com/bitcoin/bitcoin/issues/19455 | rpc generate: print useful help and error message by jonatack · Pull Request #19455 · bitcoin/bitcoin · GitHub
14:04 < achow101> wooo
14:04 < wumpus> ^^
14:04 < luke-jr> I guess tha'ts a no
14:05 < jonatack> ugh, freenode really does not like my vpn, i keep getting kicked
14:05 < luke-jr> I suppose there's probably some workaround from the commandline or something
14:05 < wumpus> we've held up the release on enough macos bs imo
14:05 < midnight> connectivity to the freenode servers would be the issue due to ping timeout.
14:05 < jonatack> wumpus: yay \,o,/
14:06 < midnight> $5 vps/bouncer would do the same thing for you, and likely safer for you, jonatack
14:06 < midnight> wumpus: also, yay!
14:07 < wumpus> jonatack midnight  we did it we can still do releases! (well, this is only the tag... yet 🙂)
14:08 < jonatack> midnight: thanks, yes i should. apparently my vpn is blocked by freenode since years, i should do something else, sorry for the logged in/out noise
14:10 < jonatack> wumpus: yeah, not getting any hopes up prematurely ;p
14:10 < achow101> has this been the longest rc cycle?
14:11 < jeremyrubin> jonatack: it's relevant hah
14:12 < sipa> fjahr, elichai2: i made a quick & dirty port of the secp256k1 safegcd modular inverse code to the muhash3072 field... finalizing is 45x faster with it ;)
14:12 < sipa> https://github.com/sipa/bitcoin/commits/202101_muhash_safegcd
14:12 < sipa> 4629892 ns to 77415 ns
14:14 < wumpus> achow101: i'm not sure, 5 rcs is not unheard of at least
14:14 < wumpus> for a major release
14:18 < sipa> not going to PR this until the safegcd inverse code is in libsecp256k1 (and hopefully it's easy to convince the reviewers there to have a look at the muhash3072 version too)
14:21 -!- qubenix [~qubenix@66.172.11.228] has quit [Quit: quit]
14:23 -!- qubenix [~qubenix@66.172.11.228] has joined #bitcoin-core-dev
14:29 < elichai2> sipa: damn 
14:30 < sipa> elichai2: this isn't because safegcd is so amazing (it is, but not *that* amazing; a dumb extgcd based modular inverse would probably be a lot faster than the ladder approach too)
14:30 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
14:32 < elichai2> It's only 100 loc here, which is impressive
14:33 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...]
14:37 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev
14:44 < sipa> elichai2: 200 loc
14:45 -!- kexkey [~kexkey@static-198-54-132-157.cust.tzulo.com] has quit [Quit: Scaling pentatonically]
14:46 -!- qubenix [~qubenix@66.172.11.228] has quit [Quit: quit]
14:46 -!- qubenix [~qubenix@66.172.11.228] has joined #bitcoin-core-dev
14:46 < fjahr> sipa: wow, awesome!
14:47 < elichai2> Oops (1am hehe) 
14:48 -!- kexkey [~kexkey@static-198-54-132-157.cust.tzulo.com] has joined #bitcoin-core-dev
14:48 < sipa> elichai2: peak productivity
14:49 < elichai2> I need to find time to read the long explanation you wrote in the libsecp PR about how the safegcd works, I want to understand how it works. 
14:49 < sipa> elichai2: please do; i've tried to keep it very accessible
14:50 < fjahr> will check that out as well to get a better understanding :)
14:51 < sipa> i have a markdown version of it here: https://gist.github.com/sipa/bddcf6434b25cf1ff03a277cd4927d73
14:51 < sipa> (it's a bit outdated, the one in the PR has some improvements)
14:51 < fjahr> sipa: thanks!
14:53 < sipa> "very accessible" is of course a fairly subjective statement :)
14:59 -!- ctrlbreak_MAD [~ctrlbreak@159.2.165.130] has joined #bitcoin-core-dev
15:02 -!- ctrlbreak [~ctrlbreak@159.2.165.130] has quit [Ping timeout: 240 seconds]
15:09 < sipa> ooh, gitian time!
15:09 < hebasto> yess
15:23 -!- kexkey [~kexkey@static-198-54-132-157.cust.tzulo.com] has quit [Quit: Scaling pentatonically]
15:25 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
15:28 -!- copumpkin [~copumpkin@unaffiliated/copumpkin] has joined #bitcoin-core-dev
15:37 -!- kexkey [~kexkey@static-198-54-132-157.cust.tzulo.com] has joined #bitcoin-core-dev
15:47 -!- prayank [~andr0irc@2405:205:2180:41f3:133:6444:5db:787c] has quit [Ping timeout: 264 seconds]
15:47 -!- kexkey [~kexkey@static-198-54-132-157.cust.tzulo.com] has quit [Quit: Scaling pentatonically]
15:48 -!- az0re [~az0re@gateway/tor-sasl/az0re] has joined #bitcoin-core-dev
15:52 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
15:57 -!- prayank [~andr0irc@2405:205:2180:41f3:133:6444:5db:787c] has joined #bitcoin-core-dev
15:58 -!- kexkey [~kexkey@static-198-54-132-157.cust.tzulo.com] has joined #bitcoin-core-dev
16:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
16:02 < bitcoin-git> [bitcoin] fanquake closed pull request #20928: Create sustainable_wallet (master...patch-1) https://github.com/bitcoin/bitcoin/pull/20928
16:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
16:02 -!- kexkey [~kexkey@static-198-54-132-157.cust.tzulo.com] has quit [Client Quit]
16:08 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 246 seconds]
16:17 -!- prayank [~andr0irc@2405:205:2180:41f3:133:6444:5db:787c] has quit [Quit: AndroIRC - Android IRC Client ( http://www.androirc.com )]
16:18 -!- jessepos_ [~jp@2601:645:200:162f:129:157d:4d2b:a6f4] has joined #bitcoin-core-dev
16:20 -!- jesseposner [~jp@2601:645:200:162f:f8fc:719c:d404:10c2] has quit [Ping timeout: 264 seconds]
16:21 -!- dviola [~diego@unaffiliated/dviola] has quit [Ping timeout: 272 seconds]
16:23 -!- dviola [~diego@187.39.20.240] has joined #bitcoin-core-dev
16:27 -!- dviola [~diego@187.39.20.240] has left #bitcoin-core-dev []
16:28 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
16:34 -!- jessepos_ [~jp@2601:645:200:162f:129:157d:4d2b:a6f4] has quit [Quit: Textual IRC Client: www.textualapp.com]
16:35 -!- jesseposner [~jp@2601:645:200:162f:129:157d:4d2b:a6f4] has joined #bitcoin-core-dev
16:50 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Ping timeout: 265 seconds]
16:53 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
17:01 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:255c:8c1d:42fb:24ab:a8e9] has joined #bitcoin-core-dev
17:04 -!- openoms [~quassel@91.132.136.76] has quit [Ping timeout: 256 seconds]
17:07 -!- openoms [~quassel@91.132.136.76] has joined #bitcoin-core-dev
17:09 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 246 seconds]
17:10 -!- dviola [~diego@unaffiliated/dviola] has quit [Ping timeout: 240 seconds]
17:18 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has quit [Ping timeout: 264 seconds]
17:20 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has quit [Ping timeout: 260 seconds]
17:30 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 264 seconds]
17:30 -!- sr_gi [~sr_gi@47.61.57.221] has joined #bitcoin-core-dev
17:33 -!- kexkey [~kexkey@static-198-54-132-157.cust.tzulo.com] has joined #bitcoin-core-dev
17:34 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
17:37 -!- ogo [~ogo@gateway/tor-sasl/ogo] has quit [Ping timeout: 240 seconds]
17:45 -!- kexkey [~kexkey@static-198-54-132-157.cust.tzulo.com] has quit [Quit: Scaling pentatonically]
17:45 -!- dviola [~diego@187.39.20.240] has joined #bitcoin-core-dev
17:48 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
17:51 -!- dviola [~diego@187.39.20.240] has quit [Ping timeout: 264 seconds]
17:51 -!- dviola [~diego@187.39.20.240] has joined #bitcoin-core-dev
17:54 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has joined #bitcoin-core-dev
18:01 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:255c:8c1d:42fb:24ab:a8e9] has quit [Ping timeout: 264 seconds]
18:01 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer]
18:04 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
18:14 < achow101> jonasschnelli: 0.21.0 MacOS code signature pls
18:20 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
18:30 -!- dviola [~diego@187.39.20.240] has left #bitcoin-core-dev []
18:31 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
18:38 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 264 seconds]
18:40 -!- sr_gi [~sr_gi@47.61.57.221] has quit [Ping timeout: 246 seconds]
18:56 -!- hoobop1 [~hoobop@84.39.117.57] has quit [Remote host closed the connection]
19:02 -!- kexkey [~kexkey@static-198-54-132-157.cust.tzulo.com] has joined #bitcoin-core-dev
19:03 -!- sr_gi [~sr_gi@47.61.62.148] has joined #bitcoin-core-dev
19:03 -!- kexkey [~kexkey@static-198-54-132-157.cust.tzulo.com] has quit [Client Quit]
19:06 -!- kexkey [~kexkey@static-198-54-132-109.cust.tzulo.com] has joined #bitcoin-core-dev
19:11 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
19:30 -!- yabs [450e42e2@d14-69-226-66.try.wideopenwest.com] has joined #bitcoin-core-dev
19:34 -!- DJWillis [~DJWillis@217.146.82.202] has joined #bitcoin-core-dev
19:43 -!- yabs [450e42e2@d14-69-226-66.try.wideopenwest.com] has quit [Quit: Connection closed]
19:49 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Quit: Leaving]
20:11 -!- az0re [~az0re@gateway/tor-sasl/az0re] has quit [Remote host closed the connection]
20:18 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has quit [Ping timeout: 240 seconds]
20:23 -!- Randolf [~randolf@184.70.10.188] has joined #bitcoin-core-dev
20:25 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has joined #bitcoin-core-dev
20:26 -!- ironhelix [~p@136.144.43.97] has quit [Quit: Leaving]
20:41 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:3656:8ea:afab:481d:8a34] has joined #bitcoin-core-dev
20:55 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
20:55 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services]
20:55 -!- vasild_ is now known as vasild
21:06 -!- ogo [~ogo@gateway/tor-sasl/ogo] has joined #bitcoin-core-dev
21:11 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection]
21:11 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has quit [Ping timeout: 264 seconds]
21:12 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev
21:32 -!- az0re [~az0re@gateway/tor-sasl/az0re] has joined #bitcoin-core-dev
21:44 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:3656:8ea:afab:481d:8a34] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
21:48 -!- dermoth_ [~dermoth@unaffiliated/dermoth] has joined #bitcoin-core-dev
21:48 -!- dermoth [~dermoth@unaffiliated/dermoth] has quit [Disconnected by services]
21:48 -!- dermoth_ is now known as dermoth
22:01 -!- jespada [~jespada@90.254.245.49] has quit [Ping timeout: 240 seconds]
22:03 -!- jespada [~jespada@90.254.245.49] has joined #bitcoin-core-dev
22:26 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has joined #bitcoin-core-dev
23:11 -!- az0re [~az0re@gateway/tor-sasl/az0re] has quit [Quit: Leaving]
23:17 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has quit [Ping timeout: 264 seconds]
23:28 -!- da39a3ee5e6b4b0d [~da39a3ee5@49.228.237.19] has joined #bitcoin-core-dev
23:32 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection]
23:32 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
23:43 -!- mrostecki [mrostecki@nat/suse/x-rgficojmxnxsfgtc] has quit [Quit: WeeChat 1.8]
23:44 < jonasschnelli> will do the 0.21.0 signature macOS now
23:53 < gleb> sdaftuar: I was reviewing disabletx, and I didn't get why we don't use a positive "sendtx/enabletx" message instead. Since I'm a bit late to the party, I was wondering if this was discussed at some point, so I wanted to ask here instead of adding noise to the PR.
23:53 < gleb> Also, in the BIP, "For nearly the past year" ages poorly in the context of the BIP document I think :)
23:58 < sipa> gleb: i assume part of the reason is that the positive form is implied now (you can't assume sokeone doesn't want transactions unless they tell you)
23:58 < aj> gleb, sipa: here's kindof what i'm thinking re: switching towards something more opt-in https://gist.github.com/ajtowns/9703e8ff518fbf57c381f3eb3d6c2ca1
23:58 < gleb> Well, since there is a version change, we can start assuming the opposite starting 70017
23:59 < sipa> it's slightly different for a hypthetical equivalent for addr relay... as there it seems we'd like to assume/infer that some peers don't want some types of ip addresses (and having an explicit "i do want ipv17 addresses")
--- Log closed Thu Jan 14 00:00:14 2021