--- Log opened Thu Jan 28 00:00:28 2021 00:05 -!- TallTim [~TallTim@184-83-248-206-dynamic.midco.net] has quit [Ping timeout: 246 seconds] 00:06 -!- TallTim [~TallTim@184-83-248-206-dynamic.midco.net] has joined #bitcoin-core-dev 00:12 -!- Kiminuo [~mix@193.9.112.92] has joined #bitcoin-core-dev 00:31 -!- awesome_doge [awesome-do@gateway/shell/matrix.org/x-qdjwmwfycxpyunqp] has joined #bitcoin-core-dev 01:05 < jonasschnelli> meshcollider: I think you should also add the GUI to your push mirrors when merging stuff 01:06 < jonasschnelli> ^ --- ithubmerge.pushmirrors=git@github.com:bitcoin-core/gui.git 01:06 < jonasschnelli> +g 01:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:08 < bitcoin-git> [gui] jonasschnelli merged pull request #177: Use "fusion" style on macOS Big Sur with old Qt (master...210107-style) https://github.com/bitcoin-core/gui/pull/177 01:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:08 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9deba2de764f...02b01651c562 01:08 < bitcoin-git> bitcoin/master 4e1154d Hennadii Stepanov: qt: Use "fusion" style on macOS Big Sur with old Qt 01:08 < bitcoin-git> bitcoin/master 02b0165 Jonas Schnelli: Merge bitcoin-core/gui#177: Use "fusion" style on macOS Big Sur with old Q... 01:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:12 -!- lntvdls [~manrtre@37.160.148.8] has joined #bitcoin-core-dev 01:14 -!- worc3131 [~quassel@2a02:c7f:dcc4:6500:217b:6c7a:eac3:3be9] has quit [Ping timeout: 268 seconds] 01:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:14 < bitcoin-git> [gui] jonasschnelli merged pull request #72: util: Log static plugins meta data and used style (master...200812-log) https://github.com/bitcoin-core/gui/pull/72 01:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:15 -!- lntvdls [~manrtre@37.160.148.8] has quit [Client Quit] 01:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:15 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/02b01651c562...759518354377 01:15 < bitcoin-git> bitcoin/master 957895c Hennadii Stepanov: util: Log static plugins meta data and style 01:15 < bitcoin-git> bitcoin/master 7595183 Jonas Schnelli: Merge bitcoin-core/gui#72: util: Log static plugins meta data and used sty... 01:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:17 < bitcoin-git> [bitcoin] jonasschnelli pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/759518354377...68692d33c6c5 01:17 < bitcoin-git> bitcoin/master b695148 Hennadii Stepanov: qt: Add flags to prevent a "What's This" button on Windows OS 01:17 < bitcoin-git> bitcoin/master ac7ccd6 Hennadii Stepanov: scripted-diff: Remove unused "What's This" button in dialogs on Windows 01:17 < bitcoin-git> bitcoin/master 68692d3 Jonas Schnelli: Merge bitcoin-core/gui#85: Remove unused "What's This" button in dialogs o... 01:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:17 < bitcoin-git> [gui] jonasschnelli merged pull request #85: Remove unused "What's This" button in dialogs on Windows OS (master...200907-whatsit) https://github.com/bitcoin-core/gui/pull/85 01:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:31 -!- bosch-0 [74cee4cc@116.206.228.204] has joined #bitcoin-core-dev 01:32 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 01:47 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 01:48 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 256 seconds] 01:49 -!- bosch-0 [74cee4cc@116.206.228.204] has quit [Ping timeout: 248 seconds] 01:58 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 01:58 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 02:12 -!- prayank [~andr0irc@2402:8100:206d:256b:72d2:6ce4:d87a:6e2] has joined #bitcoin-core-dev 02:16 < prayank> https://consensus-health.torproject.org/ 02:16 < prayank> https://github.com/bitcoin/bitcoin/pull/20757#issuecomment-766906173 02:24 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:26 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services] 02:26 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 02:26 -!- vasild_ is now known as vasild 02:30 -!- lntvdls [~manrtre@37.160.148.8] has joined #bitcoin-core-dev 02:30 -!- lntvdls [~manrtre@37.160.148.8] has quit [Client Quit] 02:47 < jnewbery> It's actually impossible to load the hidden review comments in #20749. Whenever I hit the "Load more..." button it instantly fails. Looking at network capture I'm getting a 400 bad request when trying to load the extra comments. 02:47 < gribble> https://github.com/bitcoin/bitcoin/issues/20749 | [Bundle 1/n] Prune g_chainman usage related to ::LookupBlockIndex by dongcarl · Pull Request #20749 · bitcoin/bitcoin · GitHub 02:47 < jnewbery> github is quickly becoming unusable to do serious review 02:52 -!- owowo [~ovovo@2a02:20c8:4124::2e] has joined #bitcoin-core-dev 02:52 -!- owowo [~ovovo@2a02:20c8:4124::2e] has quit [Changing host] 02:52 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 02:52 -!- ovovo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 240 seconds] 02:55 < wumpus> prayank: https://github.com/bitcoin/bitcoin/pull/20757#issuecomment-768969585 nope nope nope nope nope 02:56 < wumpus> jnewbery: that's been my experience as well 02:56 < fanquake_> wumpus: lol. yea we certainly aren't about to start a Tor fork.. 02:56 < wumpus> jnewbery: it's starting to look like the API is the only way to use github anymore, the website adds less and less 02:57 < wumpus> (this is really bad for a mostly web based product) 02:57 < wumpus> fanquake_: right eh 02:58 < fanquake_> jnewbery: I reported a similar issue to GitHub on the 30th of October last year. It got a reply a week later, which was basically "can't reproduce" 03:01 < fanquake_> Can anyone else confirm that hitting load more in #20749 doesn't work ? 03:01 < gribble> https://github.com/bitcoin/bitcoin/issues/20749 | [Bundle 1/n] Prune g_chainman usage related to ::LookupBlockIndex by dongcarl · Pull Request #20749 · bitcoin/bitcoin · GitHub 03:01 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Ping timeout: 260 seconds] 03:03 < wumpus> prayank: to be clear i would be happy if someone picked up Dandelion again, and was able to resolve the DoS issues, it has a limited an realistic enough scope, transaction broadcast 03:04 < wumpus> fanquake_: same now 03:04 < jnewbery> jonatack: thanks for the gh cli tip. Do you know if there's any way to also load the inline code review comments? 03:04 < wumpus> i was able to load them yesterday 03:05 < fanquake_> wumpus: great. Just wanted to triple check before posting heh 03:05 < jnewbery> I'm just seeing the top level PR review comments 03:05 < fanquake_> https://imgur.com/a/bOerpMG 03:06 < fanquake_> https://0bin.net/paste/bEEMvISZ#hKXweSD5iGIyBFzjBvgF+EfugKkx9QM8ZARoHzUGh4M 03:06 -!- belcher_ is now known as belcher 03:06 < jnewbery> fanquake_: yep - that's exactly my experience 03:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:07 < bitcoin-git> [bitcoin] MarcoFalke reopened pull request #21012: ci: Fuzz with integer sanitizer (master...2101-fuzzIntSan) https://github.com/bitcoin/bitcoin/pull/21012 03:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:08 < prayank> wumpus: I was trying to experiment with Dandelion and had few issues. Will try again this week and write about all the issues. One basic question was answered by 0xb10c on SE: https://bitcoin.stackexchange.com/questions/99602/dumpmempool-and-loadmempool-in-src-validation-cpp 03:08 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev 03:13 < wumpus> it's possible to access (https://docs.github.com/en/rest/reference/pulls#list-review-comments-in-a-repository) and even create (https://docs.github.com/en/rest/reference/pulls#create-a-review-for-a-pull-request) inline comments through the github API, the line numbers and such are available, but i checked the cli tool's docs and i can't find anything related to that 03:13 -!- darosior [~darosior@194.36.189.246] has quit [Read error: Connection reset by peer] 03:14 -!- darosior [~darosior@194.36.189.246] has joined #bitcoin-core-dev 03:15 < wumpus> e.g. https://cli.github.com/manual/gh_pr_review has nothing about specific places in the code, but might be missing someting 03:16 < wumpus> https://github.com/cli/cli/issues/359 "Fine Grained Code Review Support" 03:17 -!- rpite [~rpite@47.187.219.52] has quit [Quit: rpite] 03:18 -!- Griffin72Vanderv [~Griffin72@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev 03:21 < wumpus> so: currently no—it seems to less of an implementation issue but more of a matter of failing to agree on what would be a usable command line interface to this 03:25 < wumpus> prayank: i keep being surprised how actually-helpful the bitcoin stackexchange is 03:27 < prayank> wumpus: Not sure if I should comment on this but it's been helpful sometimes and for few things I had to ask questions on r/bitcoin and other places. 03:28 < michaelfolkson> prayank: I think you forget about the questions you get answered and just focus on those that don't. Never going to get close to 100 percent success rate 03:29 < prayank> lol maybe 03:29 < michaelfolkson> Given it is completely voluntary it is very impressive the people that dedicate time to it 03:30 -!- Griffin72Vanderv [~Griffin72@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 256 seconds] 03:30 < wumpus> prayank: then i see a reddit thread and am shocked how full of distractive trolls and nonsense it is, though it definitely has it's good threads too, but the stack exchange is just so serious and people seem to really take their time to type explanations and such that are on-point 03:32 < wumpus> michaelfolkson: exactly 03:33 < prayank> wumpus: Agree both have their own positives. Maybe I am just overthinking about few issues and hate the options available to "close" questions on Stackexchange. 03:33 < michaelfolkson> If you didn't have the moderator features you'd get the Reddit style "full of distractive trolls and nonsense" 03:34 < michaelfolkson> Moderation is never perfect but it is generally pretty high quality imo 03:34 < wumpus> michaelfolkson: it's kind of defined by that, yes 03:37 < wumpus> prayank: anyhow yeah if you write down what the specific issues are (and what you're trying to do) others might be able to help you out, fwiw there are a fair bit of dandelion-specific threads on the stack exchange too 03:38 < wumpus> you're far from the only person looking into this 03:39 < wumpus> https://bitcoin.stackexchange.com/questions/81503/what-is-the-tradeoff-between-privacy-and-implementation-complexity-of-dandelion must be the most famous one 03:41 < michaelfolkson> While you're here prayank, you just need to ACK the head commit, not ACK each individual commit 03:42 < michaelfolkson> https://jonatack.github.io/articles/how-to-review-pull-requests-in-bitcoin-core 03:42 < prayank> wumpus: I found only one thing that explains the risks involved in Dandelion on SE: https://bitcoin.stackexchange.com/a/81504/ My issues are mainly related to implementation of the this commit: https://github.com/dandelion-org/bitcoin/commit/d043e36bbe9249a78cf751c80b8d876b7d9f07ea in present code's master branch because lot of things have changed since 2018 03:42 < michaelfolkson> Referring to this btw https://github.com/bitcoin/bitcoin/pull/20757#issuecomment-768192425 03:43 < wumpus> oh yes, rebasing the work on recent source code is going to be a challenge in itself 03:44 -!- prayank [~andr0irc@2402:8100:206d:256b:72d2:6ce4:d87a:6e2] has quit [Quit: AndroIRC - Android IRC Client ( http://www.androirc.com )] 03:44 -!- prayank [~andr0irc@2402:8100:206d:256b:72d2:6ce4:d87a:6e2] has joined #bitcoin-core-dev 03:45 < wumpus> i think to do that you need to first understand every change, then see how it applies to master, git's source-context-based suggestions quickly become completely useless 03:45 < prayank> michaelfolkson: Thanks. I had seen someone doing ACKs on individual commits so thought we can do it. 03:46 < michaelfolkson> I guess if you only review one commit (or a subset of commits) then you could refer to them. But if you review all of them just ACK that head commit 03:46 < wumpus> you *can* ACK invidual commits, but that's generally if you have a special reason to 03:46 < wumpus> right 03:47 < prayank> wumpus: Yes. Trying to understand every change and there are lot of changes. 03:47 < wumpus> prayank: maybe as first pass, try to sort out which are the most important ones :) 03:48 -!- prayank [~andr0irc@2402:8100:206d:256b:72d2:6ce4:d87a:6e2] has quit [Client Quit] 03:48 < wumpus> there's alwasys ancillary things like refactors that were needed at the time to bring things into posistion which might no longer be needed, or needed completely differently 03:48 -!- prayank [~andr0irc@2402:8100:206d:256b:72d2:6ce4:d87a:6e2] has joined #bitcoin-core-dev 03:49 < prayank> Thanks. Will try and share the progress in few days. 03:49 < wumpus> ok! 03:50 -!- prayank [~andr0irc@2402:8100:206d:256b:72d2:6ce4:d87a:6e2] has quit [Remote host closed the connection] 04:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:27 < bitcoin-git> [bitcoin] chrismaddern opened pull request #21021: Seems like time... (master...patch-1) https://github.com/bitcoin/bitcoin/pull/21021 04:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:34 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 3.0] 04:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:39 < bitcoin-git> [bitcoin] fanquake closed pull request #21021: Seems like time... (master...patch-1) https://github.com/bitcoin/bitcoin/pull/21021 04:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:39 -!- rpite [~rpite@47.187.219.52] has joined #bitcoin-core-dev 04:43 -!- nejon [sid38993@gateway/web/irccloud.com/x-qfvqhbthsevgepbp] has joined #bitcoin-core-dev 04:47 -!- bosch-0 [74cee4f4@116.206.228.244] has joined #bitcoin-core-dev 04:52 -!- rpite [~rpite@47.187.219.52] has quit [Quit: rpite] 04:53 -!- rpite [~rpite@47.187.219.52] has joined #bitcoin-core-dev 04:58 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 04:58 -!- jespada [~jespada@90.254.242.138] has quit [Ping timeout: 265 seconds] 05:02 -!- jespada [~jespada@90.254.242.138] has joined #bitcoin-core-dev 05:18 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 05:33 -!- Kiminuo [~mix@193.9.112.92] has quit [Read error: Connection reset by peer] 05:34 -!- livestradamus [~quassel@unaffiliated/livestradamus] has quit [Quit: I'm out.] 05:35 -!- livestradamus [~quassel@unaffiliated/livestradamus] has joined #bitcoin-core-dev 05:40 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 264 seconds] 05:42 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 05:44 -!- darosior4 [~darosior@194.36.189.246] has joined #bitcoin-core-dev 05:45 -!- darosior [~darosior@194.36.189.246] has quit [Read error: Connection reset by peer] 05:46 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 256 seconds] 05:54 -!- jonatack [~jon@88.124.242.136] has joined #bitcoin-core-dev 05:54 -!- jonatack [~jon@88.124.242.136] has quit [Client Quit] 06:10 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 264 seconds] 06:10 -!- Guyver2__ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:14 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 06:15 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 06:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:16 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/68692d33c6c5...4d5eaf7a90bc 06:16 < bitcoin-git> bitcoin/master fa99e33 MarcoFalke: fuzz: move-only FillNode implementation to cpp file 06:16 < bitcoin-git> bitcoin/master fad3d76 MarcoFalke: fuzz: Avoid initializing version to less than MIN_PEER_PROTO_VERSION 06:16 < bitcoin-git> bitcoin/master 4d5eaf7 MarcoFalke: Merge #20995: fuzz: Avoid initializing version to less than MIN_PEER_PROTO... 06:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:16 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20995: fuzz: Avoid initializing version to less than MIN_PEER_PROTO_VERSION (master...2101-fuzzVersion0) https://github.com/bitcoin/bitcoin/pull/20995 06:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:16 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 06:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:25 < bitcoin-git> [bitcoin] fanquake opened pull request #21022: [Not for merge] pthread sanity check (master...broken_shared_mutex_sanity_check) https://github.com/bitcoin/bitcoin/pull/21022 06:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:27 -!- bosch-0 [74cee4f4@116.206.228.244] has quit [Quit: Ping timeout (120 seconds)] 06:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:28 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #21023: fuzz: Disable shuffle when merge=1 (master...2101-fuzzMerge) https://github.com/bitcoin/bitcoin/pull/21023 06:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:42 -!- jackk_ [~jackk@205.178.111.134] has joined #bitcoin-core-dev 06:43 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 06:53 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection] 06:58 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev 07:06 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 256 seconds] 07:12 -!- jackk_ [~jackk@205.178.111.134] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 07:16 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 07:17 -!- cltrbreak_MAD2 [~ctrlbreak@159.2.165.130] has joined #bitcoin-core-dev 07:19 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev 07:20 -!- ctrlbreak_MAD [~ctrlbreak@159.2.165.130] has quit [Ping timeout: 264 seconds] 07:46 -!- darosior4 is now known as darosior 08:02 -!- jonatack [~jon@88.124.242.136] has joined #bitcoin-core-dev 08:07 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 246 seconds] 08:07 -!- jonatack [jon@gateway/vpn/airvpn/jonatack] has joined #bitcoin-core-dev 08:10 -!- jonatack [jon@gateway/vpn/airvpn/jonatack] has quit [Client Quit] 08:12 -!- GankMove [~GankMove@dsl-lprbng11-54f88d-13.dhcp.inet.fi] has joined #bitcoin-core-dev 08:13 -!- jonatack [~jon@88.124.242.136] has joined #bitcoin-core-dev 08:19 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 240 seconds] 08:19 -!- jonatack [jon@gateway/vpn/airvpn/jonatack] has joined #bitcoin-core-dev 08:25 -!- GankMove [~GankMove@dsl-lprbng11-54f88d-13.dhcp.inet.fi] has quit [Changing host] 08:25 -!- GankMove [~GankMove@unaffiliated/gankmove] has joined #bitcoin-core-dev 08:26 -!- GankMove [~GankMove@unaffiliated/gankmove] has quit [Quit: GankMove] 08:27 -!- GankMove [~GankMove@unaffiliated/gankmove] has joined #bitcoin-core-dev 08:36 -!- Guyver2__ is now known as Guyver2 08:37 -!- fanquake_ [sid369002@gateway/web/irccloud.com/x-hooxevzeyzepxlxz] has quit [Read error: Connection reset by peer] 08:38 -!- fanquake_ [sid369002@gateway/web/irccloud.com/x-pllzngnlrrqggqyd] has joined #bitcoin-core-dev 08:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:44 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4d5eaf7a90bc...6ba2ffd28b6b 08:44 < bitcoin-git> bitcoin/master 624091b setpill: Fix docker args conditional 08:44 < bitcoin-git> bitcoin/master 6ba2ffd MarcoFalke: Merge #21004: contrib: Fix docker args conditional in gitian-build 08:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:45 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #21004: contrib: Fix docker args conditional in gitian-build (master...improve-gitian-build-py) https://github.com/bitcoin/bitcoin/pull/21004 08:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:48 < MarcoFalke> #proposedmeetingtopic 0.20.2 08:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:49 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #21024: appveyor: image: Previous Visual Studio 2019 (master...2101-ciAppveyorPrev) https://github.com/bitcoin/bitcoin/pull/21024 08:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:55 < dongcarl> Anyone experimented with Radicle yet and have a bitcoin-core radicle ID? 09:04 < wumpus> dongcarl: yes, let me see 09:04 < wumpus> dongcarl: rad:git:hwd1yreyfmyg5my7kskrsc5r33h5jr9anra9635hpncfs9f1wsk1eaf8f9w 09:04 < wumpus> let me start my node too 09:05 < dongcarl> I see it! 09:08 -!- rpite [~rpite@47.187.219.52] has quit [Quit: rpite] 09:08 -!- rpite [~rpite@47.187.219.52] has joined #bitcoin-core-dev 09:09 < dongcarl> Workflow seems quite different... I don't even see issues or PRs... 09:13 < vasild> All bugs have been fixed and Bitcoin Core has no issues! 09:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:13 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #21024: appveyor: image: Previous Visual Studio 2019 (master...2101-ciAppveyorPrev) https://github.com/bitcoin/bitcoin/pull/21024 09:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:14 < MarcoFalke> dongcarl: I think we still need some kind of centralized entity 09:15 < MarcoFalke> I can't imagine our workflow when half the devs don't see half the pull requests 09:15 < MarcoFalke> (You can only see the ones you "follow", according to the docs, haven't tried myself) 09:17 < dongcarl> Right, that is the current behaviour but I can see how they can introduce "remote rebroadcasting" to solve this. Surely other projects will want the same thing. 09:18 < luke-jr> MarcoFalke: at least half the devs already ignore half the PRs I suspect :P 09:19 < MarcoFalke> Also, radicle doesn't work with the normal browser 09:19 < luke-jr> but yes, it's probably important new devs get visibility 09:19 < MarcoFalke> you need to download their own software to browse 09:20 < MarcoFalke> luke-jr: Most new devs remove the word "experimental", so it would be good if no one could see those anymore. Though, rarely someone has an actual bug fix. 09:20 < MarcoFalke> Same goes for issues 09:21 < wumpus> dongcarl: the mirror should update every 15 minutes 09:22 < wumpus> dongcarl: issues and PRs haven't been implemented in the frontend yet, unfortunately, this kind of limits its usefulness at the moment 09:22 < dongcarl> Oh of course right now it's full of problems and is in alpha, I'm just thinking about a list of things still missing from radicle that perhaps can be advocated for. 09:22 < luke-jr> MarcoFalke: :/ 09:25 -!- Tokamak [~Tokamak@204.141.173.217] has joined #bitcoin-core-dev 09:48 -!- contrapumpkin is now known as copumpkin 09:52 -!- copumpkin [~copumpkin@unaffiliated/copumpkin] has quit [Quit: Bye!] 09:52 -!- copumpkin [~copumpkin@unaffiliated/copumpkin] has joined #bitcoin-core-dev 09:53 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 09:55 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 10:10 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds] 10:12 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 10:14 -!- promag_ [~promag@188.250.84.129] has joined #bitcoin-core-dev 10:14 -!- promag [~promag@188.250.84.129] has quit [Read error: Connection reset by peer] 10:24 -!- jessepos_ [~jp@2601:645:200:162f:3c9a:cd45:284b:ebea] has quit [Quit: Textual IRC Client: www.textualapp.com] 10:24 -!- jesseposner [~jp@2601:645:200:162f:3c9a:cd45:284b:ebea] has joined #bitcoin-core-dev 10:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:25 < bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/6ba2ffd28b6b...80e16cadd56c 10:25 < bitcoin-git> bitcoin/master faf8356 MarcoFalke: rpc: [refactor] Use concise C++11 code in CRPCConvertTable constructor 10:25 < bitcoin-git> bitcoin/master fa92912 MarcoFalke: rpc: Use RPCHelpMan for check-rpc-mappings linter 10:25 < bitcoin-git> bitcoin/master fa04f9b MarcoFalke: rpc: Remove duplicate name and argNames from CRPCCommand 10:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:26 < bitcoin-git> [bitcoin] laanwj merged pull request #20012: rpc: Remove duplicate name and argNames from CRPCCommand (master...2009-rpcCheckMapping) https://github.com/bitcoin/bitcoin/pull/20012 10:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:31 < bitcoin-git> [bitcoin] dongcarl opened pull request #21025: validation: Guard the active_chainstate with cs_main (master...2021-01-chainman-activechainstate-locking) https://github.com/bitcoin/bitcoin/pull/21025 10:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:38 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 256 seconds] 10:38 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 10:46 -!- rpite [~rpite@47.187.219.52] has quit [Ping timeout: 265 seconds] 11:00 < wumpus> #startmeeting 11:00 < jonasschnelli> hi 11:00 < sipa> hi 11:00 < warren> hi 11:01 < dongcarl> hi 11:01 < achow101> hi 11:01 < hebasto> h 11:01 < wumpus> #bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik 11:01 < wumpus> petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild wumpus 11:01 < warren> I have a short suggested topic, can mention later when there's an opening. 11:01 < ariard> hi 11:01 < fjahr> hi 11:01 < sipa> i like how wumpus doesn't even forget to call wumpus to the meeting 11:01 < wumpus> no proposed meeting topics in http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt 11:01 < michaelfolkson> hi 11:01 < wumpus> sipa: hah! 11:02 < jonasschnelli> heh 11:02 < jnewbery> hi 11:02 < wumpus> warren: do let us know so that we can announce it? 11:03 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection] 11:03 < wumpus> #topic High priority for review 11:03 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 11:03 < ariard> may we get #19160 as a priority (multiprocess) ? 11:03 < gribble> https://github.com/bitcoin/bitcoin/issues/19160 | multiprocess: Add basic spawn and IPC support by ryanofsky · Pull Request #19160 · bitcoin/bitcoin · GitHub 11:03 < wumpus> https://github.com/bitcoin/bitcoin/projects/8 11 blockers, 1 bugfix, 2 chasing concept ACK 11:03 < emzy> hi 11:04 < ariard> it sounds finally to attract reviewers :) 11:04 < warren> Suggested Topic: A bit concerning to me is Fedora is again approaching possible packaging and distribution of Bitcoin Core. While the openssl-based risk is now eliminated, I now intend to package Guix for Fedora and use that to make binary identical builds. I think I can handle the Fedora specific parts of this. But Guix for Bitcoin Core releases is still missing a few parts of what Gitian used to do? 11:04 < aj> hi-ish (laggy) 11:04 < jonatack> hi 11:04 < wumpus> ariard: added 11:05 < ariard> thanks! 11:05 < wumpus> 12 blockers now! anything to add/remove or that's ready for merge? 11:05 < michaelfolkson> Your #19820 is still chasing Concept ACK ariard. Keep it there or remove? 11:05 < gribble> https://github.com/bitcoin/bitcoin/issues/19820 | Transactions propagation design goals · Issue #19820 · bitcoin/bitcoin · GitHub 11:06 < ariard> michaelfolkson: it's not really consuming review time... 11:06 < jonatack> wumpus: can rm #20391 11:06 < gribble> https://github.com/bitcoin/bitcoin/issues/20391 | wallet: introduce setfeerate (an improved settxfee, in sat/vB) by jonatack · Pull Request #20391 · bitcoin/bitcoin · GitHub 11:06 < wumpus> jonatack: done 11:06 < jonatack> thanks (being on the blockers list doesn't attract review) 11:07 < michaelfolkson> ariard: Ok. I hope to drive it forward a tiny bit at some point. 11:07 < ariard> michaelfolkson: I'll try to transfer in the wiki soon and trakc all related works in this area 11:07 < wumpus> jonatack: it helps for some PRs, though not all for sure 11:08 < michaelfolkson> ariard: I think everyone would give it a Concept ACK but needs more than that ;) 11:09 < wumpus> I didn't look into that one myself because honestly not sure about the logistics of adding another global fee setting command, it seems like something ideally set per transaction 11:09 < jonatack> wumpus: it's part of a larger roadmap to migrate to sat/vB 11:10 < jonatack> we can't deprecate the feeRate options in BTC/kB as long as settxfee and estimatesmartfee are only in BTC/kB 11:11 < wumpus> jonatack: yes it's not specific to your PR, I generally agree with that roadmap, just something I've had a differing opinion about for a long time 11:11 < jonatack> but that's ok, no worries 11:11 < wumpus> anything else to discuss in regard to high prio? 11:11 < aj> re 19160, it needs rebase? also is there any roadmap for libmultiprocessing, it's out of tree, but seems pretty bitcoin specific? has it really been reviewed much? 11:12 < dongcarl> #21025 is potentially a pre-req for safely doing 2 other high-prios, but happy to table that till later 11:12 < gribble> https://github.com/bitcoin/bitcoin/issues/21025 | validation: Guard the active_chainstate with cs_main by dongcarl · Pull Request #21025 · bitcoin/bitcoin · GitHub 11:12 < ariard> aj: it needs rebase since 12 min... 11:12 < jonatack> wumpus: the idea is to make hidden/soft-deprecate settxfee and estimatesmartfee in favor of new setfeerate and estimatefeerate rpcs 11:13 < wumpus> jonatack: also, introducing a new command with a new name to introduce a new unit , might be a bit overkill 11:13 < ariard> but yeah libmultiprocess should be moved under bitcoin-core 11:13 < wumpus> jonatack: okay 11:13 < ariard> at least 11:13 < wumpus> jonatack: I do agree the new names are better 11:13 < jonatack> wumpus: i don't see a choice, but TBH i'm happy to close and move on to other things 11:13 < jonatack> leave the migration to someone else 11:13 < ariard> and yes I had a look on libmultiprocess but ofc needs more review 11:14 < jonatack> we need review more than PRs to review 11:14 < wumpus> jonatack: well don't let it up to me, it's just my opinion, I'm not going to get in the way 11:14 < wumpus> ariard: if it needs more review, adding it to high prio for review makes sense :) 11:15 < wumpus> jonatack: what does achow101 think about it? 11:15 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 256 seconds] 11:15 < sipa> jonatack: i think it's really the only convenient option to get an RPC with sat/vB units, so seems fine to me 11:15 < jonatack> achow101 wrote that they should all be in sat/vB 11:16 < wumpus> ok ,good 11:16 < jonatack> sipa: ok. anyway, no rush. we have lots to do. 11:16 < sipa> this is true 11:16 < wumpus> absolutely 11:16 < wumpus> not many topics for this meeting though, let's go to warren 's 11:17 < luke-jr> jonatack: I wouldn't close it tho 11:17 < wumpus> #topic Fedora packaging (warren) 11:17 < warren> A bit concerning to me is Fedora is again approaching possible packaging and distribution of Bitcoin Core. While the openssl-based risk is now eliminated, I now intend to package Guix for Fedora and use that to make binary identical builds. I think I can handle the Fedora specific parts of this. But Guix for Bitcoin Core releases is still missing a few parts of what Gitian used to do? 11:17 < warren> I will not be able to stop them from distributing not-deterministic Bitcoin Core for much longer. 11:17 < warren> Maybe TODO List? 11:17 < warren> 1) Bitcoin Core switch to Guix for release builds (when possible ... Guix is missing some of the architectures?) I believe we want a replacement for what Gitian used to do including exporting a particular tag from git, naming and versioning the output tarballs, anything else? 11:17 < warren> 2) Guix to additionally output .deb and .rpm packages that contain the same binary as the tarball. 11:17 < warren> 3) Debian Unstable now ships Guix. Warren is working on figuring out a way to package Guix so it would be acceptable for Fedora where it would be capable of building the above for Fedora/CentOS direct distribution. 11:18 < luke-jr> warren: distro packages *shouldn't* be identical to release binaries, but deterministic certainly does seem desirable 11:18 < luke-jr> warren: the problems with distro pkgs were discussed at the last meeting regarding Debian (which has chosen to ignore them) 11:18 < dongcarl> Status update on Guix from me: all architectures are packaged, codesigning is the main remaining task 11:18 < warren> luke-jr: Fedora can't do deterministic with its own build system anytime soon, using Guix there and here is the achievable goal in the short-term. 11:18 < achow101> dongcarl: codesigning is easy now 11:19 < warren> dongcarl: *all*? amazing! 11:19 < luke-jr> warren: sure, that's fine - but they should dynamic link to most libraries 11:19 < achow101> codesigning is also unreltaed to linux distros 11:19 < dongcarl> right 11:19 < warren> luke-jr: I believe that's an opinion not shared by most others? 11:19 -!- virtu [~virtu@gateway/tor-sasl/virtu] has quit [Ping timeout: 268 seconds] 11:19 < luke-jr> warren: dunno, if not, they're wrong ;) 11:20 < luke-jr> LevelDB is the one exception that might justify static linking 11:20 < wumpus> i'm for 100% static release binaries 11:20 < luke-jr> (in distro packages) 11:20 < warren> dongcarl: so this soon to be process eliminates gitian? is there something to handle naming and versioning outputs like gitian used to do? 11:21 < luke-jr> warren: it can't eliminate gitian.. 11:21 < dongcarl> warren: The output naming scheme is exactly Gitian's 11:21 < warren> dongcarl: can this work entirely offline with provided pre-cached downloads? That's one of the requirements of Fedora's build system 11:21 < luke-jr> Guix requires a trusted bootstrap 11:21 -!- virtu [~virtu@gateway/tor-sasl/virtu] has joined #bitcoin-core-dev 11:21 < sipa> luke-jr: you trust the system you're building on, no? 11:22 < luke-jr> sipa: yes, but Guix wants me to trust 11:22 < dongcarl> luke-jr: Is gitian different? 11:22 < MarcoFalke> luke-jr: Just use a vm 11:22 < luke-jr> dongcarl: gitian runs all untrusted bins in a VM 11:22 < wumpus> guix is an improvement to gitian in that regard, that's all 11:22 < luke-jr> MarcoFalke: that's what gitian is for ;) 11:22 < wumpus> you can run guix in a vm 11:22 < luke-jr> Guix *within* gitian is an improvement 11:22 < wumpus> you can run guix in gitian even 11:22 < wumpus> :-) 11:22 < luke-jr> Guix *without* gitian is a regression 11:23 < wumpus> well that's entirely up to you 11:23 < wumpus> guix doesn't care what you run it in 11:23 < wumpus> that's thepoint 11:23 < warren> dongcarl: can this new glorious gitianless future work entirely offline with provided pre-cached downloads? That's one of the requirements of Fedora's build system 11:23 < MarcoFalke> luke-jr: You are free to use guix in gitian, but you can't force everyone else to do the same 11:23 < warren> MarcoFalke: +1 11:24 < achow101> I agree with luke-jr for a different reason. I think gitian is an easier way to onboard new gitian builders, and existing gitian builders don't need to change anything for guix. So we should still have gitian descriptors that do the guix builds. People who want guix locally can do that too. It should all be the same. 11:24 < dongcarl> warren: Yes, I believe it's designed to do so. I will double-check 11:24 < warren> achow101: that's fine 11:24 < sipa> achow101: yeah, i'd expect we'll just change the gitian descriptors to be thin wrappers around guix 11:24 < sipa> but no reason they can't remain 11:24 < warren> if people find it more convenient to use it that way 11:24 < luke-jr> sipa: +1 11:24 < wumpus> mind that gitian is effectively unmaintained 11:25 < MarcoFalke> achow101: guix is included in debian, so it will be in Ubuntu soon. I don't see how another wrapper makes things easier 11:25 < achow101> MarcoFalke: I already have gitian setup and can't be bothered to figure out gitian :p 11:25 < achow101> * figure out guix 11:25 < luke-jr> MarcoFalke: we should not be asking people to run third-party binaries on their system to build releases 11:26 < MarcoFalke> luke-jr: Then they should be using a vm 11:26 < wumpus> and it has some long-running issues, like the inability to upgrade base images leading to very long setup+build times 11:26 < luke-jr> MarcoFalke: yes 11:26 < MarcoFalke> luke-jr: The gitian guide starts by telling people how to install the vm, so nothing changes 11:26 < luke-jr> wumpus: gitian's last merge was only a month ago, hardly unmaintained.. 11:26 < dongcarl> Is the main benefit here just a convenience script for running guix in a VM, or that people are used to the Gitian workflow? 11:26 < wumpus> then again, i'm tired of this discussion every time, if you want to use gitian then do... 11:27 < wumpus> i don't think it should be the default recommendation or 'a good way to onboard new builders' 11:27 < sipa> gitian does a few things that guix doesn't, i assume (like the creation of assert files, signing, verifying them)? 11:27 < wumpus> just make guix easy to use please 11:27 < wumpus> sipa: there is no reason why the guix wrapper couldn't do that 11:27 < sipa> wumpus: of course 11:27 < dongcarl> making guix easy to use is very much my goal 11:28 < wumpus> generating assert files is quite easy, signing them is done by gnupg 11:28 < wumpus> dongcarl: right! 11:28 < wumpus> and verifying them can be done without gitian now, e.g. see the gitian-verify.py script in maintainer-tools 11:28 < sipa> ok! 11:28 < warren> luke-jr: you can bootstrap guix yourself, why are you calling it untrusted? 11:28 < luke-jr> warren: no, I cannot 11:28 < luke-jr> warren: I spent hours trying and couldn't get anywhere 11:29 < MarcoFalke> warren: What is the policy for packages that are EOL? What is the policy for packages that went from fedora->stream->rhel? 11:29 < wumpus> I mean the whole point is that guix relies on a smaller trusted base than gitian 11:29 < warren> MarcoFalke: i need to ask what is possible from Fedora Engineering Steering Committee. I have a few things in mind like: 11:29 < aj> MarcoFalke: bitcoin's not going in stream/rhel, surely 11:29 < wumpus> gitian installs an *ubuntu* VM, it has lots of cruft 11:29 < luke-jr> wumpus: Guix is a smaller trusted base than Ubuntu, but larger than gitian for the host end 11:30 < warren> 1) Before a distro goes EOL the bitcoincore package is replaced with a final update that removes the binary. 11:30 < warren> 2) Build system CI could verify that the binary is reproducible and matches some URL upstream. 11:30 < wumpus> luke-jr: otoh if the guix trusted base is compromised so will the bitcoin core binaries 11:30 < luke-jr> warren: how about automatic upgrades and softforks? both deploying and not deploying the softfork are problematic without user consent 11:30 < sipa> wumpus: i think luke-jr's concern is about the risk that guix is malicious and say install malware in his host system; not about trusting the result of the build 11:30 < wumpus> luke-jr: it's kind of important 11:30 < wumpus> same for ubuntu right now, btw 11:30 < MarcoFalke> aj: shoudn't or can't? 11:30 * dongcarl is here but is a bit overwhelmed by the convo 11:31 < warren> luke-jr: why are you blindly trusting Ubuntu right now? 11:31 < wumpus> one compromised package in ubuntu and our binaries can be compromised 11:31 < aj> MarcoFalke: won't / isn't a rhel priority so doesn't make sense? 11:31 < wumpus> this is kind of scary 11:31 * warren hands dongcarl a calming Tribble. 11:31 < luke-jr> wumpus: yes, but we already have that problem 11:31 * sipa googles Tribble 11:31 < wumpus> luke-jr: it is mitigated by guix 11:31 < luke-jr> (with Ubuntu) 11:31 < MarcoFalke> aj: Oh, I assumed they just take all packages from fedora 11:32 < wumpus> because guix has a smaller trusted base, sure, it still has some binaries for bootstrapping, n one really solved the trusting-trust attacks yet, we can only slowly improve things 11:32 < luke-jr> wumpus: the ideal solution would be a way to bootstrap Guix without the third-party binary blobs 11:32 < warren> luke-jr does have a legitimate question about automatic upgrades. It is upstream's policy to not force users into automatic upgrades. If you install a distro package you opt-in to that. 11:33 < wumpus> luke-jr: i'm sure that's possible 11:33 < warren> There is a way however for users to opt-out of automatic distro upgrades. 11:33 < wumpus> guix is fully open source right? why couldn't you bootstrap it from an existing system? 11:33 < wumpus> givn that you have compilers and such of course 11:33 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 11:33 < warren> well that's one way to win the debate 11:33 < achow101> wumpus: from my experience, there are some usability hurdles that can make setting up guix really frustrating 11:34 < wumpus> achow101: well then we need to solve them 11:34 < aj> warren: nah, he got too close to telling the truth, so the powers that be deplatformed him 11:34 < wumpus> i don't see why that's an argument in favor of wrapping guix in ubuntu forever 11:34 < sipa> it isn't 11:34 < warren> achow101: people downloading a guix VM is no worse than people blindly trusting Ubuntu in current gitian. 11:34 < dongcarl> I'm happy to solve all of the usability problems in setting up Guix, that was an explicit goal from the beginning. To make it easier to use. 11:35 < sipa> yay. 11:35 < aj> dongcarl: <3 11:35 < dongcarl> Bootstrapping Guix from source is not the most user-friendly, but the UX problems are being solved, and the recent debian packaging outlines a for-sure way to bootstrap it from a system 11:35 < MarcoFalke> warren: Also, who would maintain the fedora package? 11:35 < warren> There is a way however for users to opt-out of automatic distro upgrades. The .rpm distributed by bitcoincore.org would be identical to the package distributed by Fedora except the Epoch number is higher. That way the Fedora package will never be seen as "newer". It retains the property desired by Bitcoin Core project that nobody is forced into automatic upgrades. 11:36 < warren> MarcoFalke: me, and everyone, because I intend it to be identical to bitcoincore.org's guix generated .rpm 11:36 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 11:36 < wumpus> fwiw gitian is also not the most user friendly, it helps that there's guides for it everywhere now, but it took ages for people to start using it 11:36 < dongcarl> I'm sure that the debian packaging rules/formula can be ported to other distros, such as Gentoo, so that people on those distros can stay within their trusted base and boostrap Guix 11:36 < sipa> i don't even invoke anything gitian related directly, all within perhaps several layers of wrapper scripts 11:37 < wumpus> in a way it's just a matter of getting used to a new way of working, i don't think we need to wait for guix to be 100% user friendly all over the board until we can start using it for release builds 11:38 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 11:38 < jonatack> this ^ 11:38 < warren> gitian is already not user friendly, it's been mostly broken for me for a few years now. 11:38 < sipa> agree 11:38 < wumpus> warren: exactly my point, gitian was never easy to use or set up 11:38 < achow101> true 11:38 < dongcarl> I am also happy to offer my time to 1. Help anyone with their setup 2. Document UX hiccups 3. Fix them so that others don't experience them 11:38 < wumpus> it's just fairly well documented now, that will happen for guix too i'm sure when we start using it 11:39 < MarcoFalke> Are we aiming to ship guix packages for the next release? 11:39 < warren> If people want easy to use guix they can download a VM. That isn't worse than the current blind trust on Ubuntu used within gitian. 11:39 < wumpus> warren: at least you have more flexibility in what VM then! 11:39 < sipa> dongcarl: how realistic do you think it is to replace all release binaries for 22.0 with guix-built ones? 11:39 < wumpus> it doesn't need to be ubuntu anymore, can be debian, or even a guix-as-a-distro VM 11:40 < jonatack> warren: we've onboarded a dozen or so new gitian signers the past 6 months, by (a) making it a bit easier to get started and (b) communicating a bit more about doing it to people 11:40 < jonatack> i'm sure can do the same with guix 11:40 < dongcarl> sipa, MarcoFalke: The missing steps before we ship 22 with guix are: codesigning, assert-file tooling, UX/non-UX debugging and testing 11:40 < warren> How difficult are the remaining things needed to switch to guix/ 11:40 < warren> ? 11:41 < MarcoFalke> dongcarl: Would those be easier if the gitian setup was used? 11:41 < dongcarl> I don't expect codesigning and assert-file tooling to be too difficult, but I don't want to make any promises w/re UX/non-UX debugging and testing 11:41 < MarcoFalke> I.e. replace the gitian build script with a guix build script, but still call gitian 11:41 < dongcarl> MarcoFalke: No, I believe using the gitian setup will probably be much more difficult 11:42 < warren> dongcarl: fedora builds have things neat thing where .rpm contains stripped binaries, but unstripped go into an optional -debuginfo package. gdb is smart enough to look at the debuginfo if you debug. Does guix have anything like that? 11:42 < dongcarl> s/much more/a bit/ 11:42 < wumpus> there's still 4.5 months left before the 22.0 feature freeze 11:42 < warren> Could we do a practice release using guix of 0.21? 11:42 < MarcoFalke> If we switch, I'd prefer to do it at least two months before freeze 11:43 < warren> 0.21.x 11:43 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 11:43 < sipa> dongcarl: what do you mean with "UX/non-UX debugging" ? 11:43 < wumpus> nack on wrapping guix in gitian, i really don't want to do a build like that 11:43 < warren> wumpus: +1 11:43 < wumpus> this almost doubles the trusted base 11:44 < dongcarl> Okay, I've been deep in the libbitcoin_kernel work as of late. But let me reload my stack, explore the scope, and get back to you all with my rough timeline expectations next week. Does that sound alright? 11:44 -!- pinheadmz [~pinheadmz@pool-71-105-114-182.nycmny.fios.verizon.net] has quit [Quit: pinheadmz] 11:44 < wumpus> dongcarl: thanks! 11:44 < warren> How difficult is it to write the remaining tooling needed to switch releases to guix? If we don't know the answer right now can we have a TODO list by next meeting? 11:44 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 11:45 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 11:45 < wumpus> how can we help? 11:45 < dongcarl> sipa: UX debugging would be going through the process to see which parts are non-intuitive and hard to use. non-UX debugging would entail testing the build output result more thoroughly 11:46 < warren> dongcarl: isn't that the same problem we have with the gitian release process? 11:46 < warren> not a new problem 11:46 < sipa> dongcarl: i'd expect the former can be alleviated by just writing documentation 11:46 < sipa> and perhaps in later steps make it more user friendly, so less needs to be documented 11:46 < MarcoFalke> do we need any assert-file tooling? 11:46 * dongcarl furiously typing 11:46 < MarcoFalke> As I understand the assert-file will list the installed ubuntu packages, but we no longer use that 11:47 < wumpus> what would a guix assert file even look like? just a list of hashes of the release files? or would you want to include more? 11:47 < wumpus> MarcoFalke: right, that 11:47 < achow101> shoudl the assert file even try to look like gitian's? 11:47 < wumpus> achow101: no reason it needs to 11:47 < MarcoFalke> so a sha256sum with a wildcard would generate the "assert file"? 11:47 < achow101> I would expect the guix assert file would be everything installed in guix 11:48 < sipa> if it's not guix-in-gitian, i see no reason why the assert file needs to be anything similar 11:48 < dongcarl> You're right, it doesn't need to. 11:48 < wumpus> it's fine with me if the assert file loks like SHA256SUMS.asc 11:48 * luke-jr kicks ISP 11:48 < sipa> it's nice if it also commits to the exact source code it was built from 11:48 < dongcarl> Here's the way fanquake and I have been verifying our outputs: https://github.com/bitcoin/bitcoin/pull/17920#issuecomment-765109583 11:48 < wumpus> sipa: true! 11:49 < dongcarl> Literally a one-liner 11:49 < wumpus> ideally it could commit to the inputs as well as the outputs 11:49 < dongcarl> Since that one-liner includes src/bitcoin-f1694757ddbc.tar.gz, it does commit to the bitcoin source 11:49 < luke-jr> it would be nice if as a result from this, we can dump everyone's signatures into the SHA256SUMS.asc file on the website 11:49 < MarcoFalke> dongcarl: Is the commit included when building tags? 11:50 < dongcarl> MarcoFalke: Sorry, not entirely sure what you mean here 11:50 < wumpus> luke-jr: that was my thinking as well 11:50 < dongcarl> luke-jr: That would be nice! I'll make a note of that 11:50 < MarcoFalke> when building a tag, the archive looks like `bitcoin-22.0.tar.gz`, not `bitcoin-fffffff.targ.gz` 11:51 < wumpus> everyone would be signing the same data so you could combine the signatures 11:51 < luke-jr> I wrote a blog post about verifying gitian sigs - it was way more complex than I'd like 11:51 < dongcarl> MarcoFalke: Yes, I believe I made sure of that some time ago, will re-check for you! 11:51 < wumpus> luke-jr: have you seen https://github.com/bitcoin-core/bitcoin-maintainer-tools#gitian-verify ? it makes things much easier 11:52 < wumpus> (e.g. tabulates the result) 11:52 < luke-jr> wumpus: that assumes the end user already has it ;) 11:52 < MarcoFalke> Though, since guix only works from git, including the commit hash in the "assert file" shouldn't be too hard 11:52 < wumpus> luke-jr: already has what? 11:52 < luke-jr> wumpus: a trusted Bitcoin Core source repo 11:53 < luke-jr> or rather, the maintainer tools repo 11:53 < wumpus> well okay sure, if you want to do it all manually 11:53 < wumpus> that's definitely a lot of work 11:53 < luke-jr> wget https://luke.dashjr.org/programs/bitcoin/files/bitcoind/0.21.0/SHA256SUMS.asc && gpg --verify SHA256SUMS.asc 11:53 < luke-jr> is a lot less 11:54 < luke-jr> (sha256sum -c too I guess) 11:54 < wumpus> i mean, sure, but that still assumes someone has all the gpg keys received and installed, but yeah 11:55 < wumpus> any other topics? 11:55 < warren> Question ... since 0.22 is months away could we aim to do a practice release on 0.21.x? 11:55 < luke-jr> WOT issues are unavoidable and not going away XD 11:55 < wumpus> warren: i would prefer to start using guix only in a major release 11:55 < MarcoFalke> wumpus: My topic was 0.20.2 :) 11:56 < warren> wumpus: not official for 0.21.x, but in parallel 11:56 < sipa> warren: or just master? 11:56 < warren> wumpus: partly because I need it to calm down the Fedora packagers 11:56 < MarcoFalke> warren: I think we can also practice on master 11:56 < sipa> why backport? 11:56 < wumpus> it's too big a change to backport, and besides, it needs the more extensive rc cycle of a major release 11:56 < warren> hmm 11:56 < wumpus> yes, practicing can be done fine on master 11:56 < warren> I'll live with that. 11:56 < sipa> or, on the guix PR branch, as long as it's not merged 11:56 < dongcarl> I'd be happy to practice with anyone and take notes :-) 11:57 < wumpus> #topic 0.20.2 (MarcoFalke) 11:57 < MarcoFalke> Basically asking if anything is left to do there 11:57 < MarcoFalke> and whether to do an rc and upload binaries 11:57 < wumpus> no idea, haven't kept track 11:58 < MarcoFalke> the rc1 was never released? 11:58 < luke-jr> MarcoFalke: I did end up finding a bug in the 0.19 bump 11:58 < luke-jr> sorry I missed the rcs 11:59 < MarcoFalke> luke-jr: huh? 11:59 * luke-jr digs it out to see if it's relevant to 0.20 11:59 < wumpus> I think it would be good if someone took over the back-releases from me, i do not have the capacity to handle that, definitely not so many at the same time 12:00 < luke-jr> I thought MarcoFalke was? 12:00 < MarcoFalke> I create the backports 12:00 < wumpus> yes, he effectively does 12:00 < wumpus> already 12:00 < MarcoFalke> Haven't run any of the release stuff scripts 12:00 < luke-jr> MarcoFalke: aha, it was a libevent dep for just bitcoin-tx builds 12:01 < luke-jr> I think it was fixed before 0.20 12:01 < luke-jr> so n/a for 0.20.2, and 0.19 will probably be dead before there's a chance to do another 12:02 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:02 < wumpus> #endmeeting 12:02 < MarcoFalke> luke-jr: 0.19 won't get any gitian binaries published, as I understood it 12:03 < luke-jr> ? this is when building from source 12:03 < wumpus> feel free to open a PR against the 0.19 branch to fix it then 12:08 < sipa> luke-jr: can i have a BIP number for bip-bech32m? (there are a few other things in the bips repo that want your attention too, i think) 12:08 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 12:11 -!- mfi_ [~matthias@p200300df3f0f7db963081d59f40a9781.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 12:12 < luke-jr> sipa: I guess use 350 12:13 < sipa> luke-jr: thanks! 12:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:21 < bitcoin-git> [bitcoin] laanwj opened pull request #21026: doc: Document use of make-tag script to make tags (master...2021-01-make-tag) https://github.com/bitcoin/bitcoin/pull/21026 12:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:24 < wumpus> ^^ might be useful if anyone else is to have a go at making releases 12:33 < achow101> is it possible to remove a task from CScheduler or maybe pause one? 12:36 < wumpus> doesn't seem like it 12:40 < sipsorcery> MarcoFalke: Did you change anything on the appveyor config? Or did one job just magically work again? 12:51 < dongcarl> For those following along the assumeutxo/chainman-deglobalizing work, please take a look at this very short PR which aims to remove the m_active_chainstate r/w footgun: #21025 12:51 < gribble> https://github.com/bitcoin/bitcoin/issues/21025 | validation: Guard the active_chainstate with cs_main by dongcarl · Pull Request #21025 · bitcoin/bitcoin · GitHub 12:52 < dongcarl> This is a prerequisite to having both work be safe, and I hope is simple enough to get in relatively quickly to unblock the two high-prio PRs 12:52 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 12:52 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 12:52 -!- mfi_ [~matthias@p200300df3f0f7db963081d59f40a9781.dip0.t-ipconnect.de] has quit [Quit: Leaving] 13:25 < luke-jr> MarcoFalke: can you please upstream https://github.com/bitcoin-core/univalue/pull/24 ? 13:29 < wumpus> dongcarl: thanks for working in that 13:29 < wumpus> on* 13:29 < dongcarl> :-) 13:37 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 13:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:44 < bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/80e16cadd56c...6a726cb534ed 13:44 < bitcoin-git> bitcoin/master 798bc0b Luke Dashjr: Support glibc-back-compat on 64-bit POWER 13:44 < bitcoin-git> bitcoin/master 63fc2b1 Luke Dashjr: gitian: Properly quote arguments in wrappers 13:44 < bitcoin-git> bitcoin/master 00f67c8 Luke Dashjr: gitian-linux: Build binaries for 64-bit POWER 13:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:44 < bitcoin-git> [bitcoin] laanwj merged pull request #20963: gitian-linux: Build binaries for 64-bit POWER (continued) (master...2021-01-power) https://github.com/bitcoin/bitcoin/pull/20963 13:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:45 < sipa> POWER, unlimited POWER! 13:49 * warren imagines beard stroking. 13:49 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 13:55 -!- Tokamak [~Tokamak@204.141.173.217] has quit [Ping timeout: 246 seconds] 13:58 -!- Tokamak [~Tokamak@204.141.173.217] has joined #bitcoin-core-dev 14:11 < wumpus> hehe "64-bit POWER" sounds a bit like some cheesy early AMD64 commercial 14:12 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [] 14:15 < sipa> brings back memories of nintendo64 14:16 < sipa> where a "64" suffix was used in way too many places 14:16 < luke-jr> was that POWER? 14:16 < sipa> MIPS, i think 14:16 < luke-jr> 64-bit MIPS? 14:16 < luke-jr> does that even exist? 14:17 < sipa> apparently it did in 1996 14:23 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds] 14:26 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services] 14:26 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 14:26 -!- vasild_ is now known as vasild 14:29 -!- jackk_ [~jackk@205.178.111.134] has joined #bitcoin-core-dev 15:02 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 15:14 < wumpus> IIRC nintendo64 didn't have an actual 64 bit processor, but two 32 bit ones 15:15 < phantomcircuit> wumpus, it was a hybrid, there were 64bit instructions 15:16 < phantomcircuit> iirc they were not useful 15:16 < wumpus> okay 15:17 < phantomcircuit> wumpus, no im wrong it's a true 64bit cpu but with a 32bit system bus... so nobody used the 64bit operations 15:19 < wumpus> i was confused with a different console then, i'm fairly sure the trick i mentioned was used somewhere 15:24 -!- proofofkeags [~proofofke@174-29-3-187.hlrn.qwest.net] has quit [Remote host closed the connection] 15:33 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 15:34 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has quit [Remote host closed the connection] 15:35 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has joined #bitcoin-core-dev 15:35 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 15:35 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-dcgzhmutntdsthom] has quit [Ping timeout: 246 seconds] 15:36 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has quit [Remote host closed the connection] 15:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 15:36 < bitcoin-git> [gui] jonatack opened pull request #201: gui: ensure inbound block relay peers have relevant services (master...inbound-block-relay) https://github.com/bitcoin-core/gui/pull/201 15:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 15:36 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has joined #bitcoin-core-dev 15:37 -!- wangchun [uid444603@gateway/web/irccloud.com/x-noqhzlwzyglfgrtn] has quit [Ping timeout: 265 seconds] 15:37 -!- wangchun_ [uid444603@gateway/web/irccloud.com/x-clwiemgrswhavjfu] has joined #bitcoin-core-dev 15:37 -!- felixweis_ [sid154231@gateway/web/irccloud.com/x-xnoihktppjcorqez] has joined #bitcoin-core-dev 15:37 -!- wallet42____ [sid154231@gateway/web/irccloud.com/x-lqwrexozzfjzdwgt] has joined #bitcoin-core-dev 15:37 -!- jakesyl_ [sid56879@gateway/web/irccloud.com/x-cdljmnidcybkxqei] has joined #bitcoin-core-dev 15:37 -!- jakesyl [sid56879@gateway/web/irccloud.com/x-ovsgclsmhkkkcxht] has quit [Ping timeout: 260 seconds] 15:37 -!- jakesyl_ is now known as jakesyl 15:37 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-djjbiuznzxhrxocp] has joined #bitcoin-core-dev 15:38 -!- wallet42___ [sid154231@gateway/web/irccloud.com/x-cyqjwvcpwnemivxk] has quit [Ping timeout: 260 seconds] 15:38 -!- felixweis [sid154231@gateway/web/irccloud.com/x-smefinmvkaltzcwo] has quit [Ping timeout: 260 seconds] 15:38 -!- felixweis_ is now known as felixweis 15:45 -!- jackk_ [~jackk@205.178.111.134] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 15:53 -!- hebasto [sid449604@gateway/web/irccloud.com/x-wksdajxeaaviknor] has quit [Ping timeout: 264 seconds] 15:54 -!- hebasto [sid449604@gateway/web/irccloud.com/x-eahswtbwpdytwihi] has joined #bitcoin-core-dev 15:56 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has quit [Remote host closed the connection] 15:57 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has joined #bitcoin-core-dev 16:00 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has quit [Remote host closed the connection] 16:04 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has joined #bitcoin-core-dev 16:04 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has quit [Max SendQ exceeded] 16:05 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has joined #bitcoin-core-dev 16:07 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has quit [Remote host closed the connection] 16:07 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has joined #bitcoin-core-dev 16:09 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has quit [Remote host closed the connection] 16:10 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has joined #bitcoin-core-dev 16:12 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has quit [Remote host closed the connection] 16:13 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 16:19 -!- ariard [~ariard@167.99.46.220] has quit [Ping timeout: 240 seconds] 16:19 -!- ariard [~ariard@167.99.46.220] has joined #bitcoin-core-dev 16:20 -!- Dev0n [~Dev0n@unaffiliated/dev0n] has quit [Ping timeout: 240 seconds] 16:20 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Ping timeout: 240 seconds] 16:20 -!- vadorovsky [vadorovsky@gateway/shell/matrix.org/x-zjekpprcfisjgbfm] has quit [Ping timeout: 246 seconds] 16:20 -!- marty[m]1 [jmacawmatr@gateway/shell/matrix.org/x-zkfvjeudcxquukgf] has quit [Ping timeout: 265 seconds] 16:22 -!- Dev0n [~Dev0n@unaffiliated/dev0n] has joined #bitcoin-core-dev 16:24 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #bitcoin-core-dev 16:25 -!- vadorovsky [vadorovsky@gateway/shell/matrix.org/x-gxjythnqxwldbaih] has joined #bitcoin-core-dev 16:26 -!- marty[m]1 [jmacawmatr@gateway/shell/matrix.org/x-iziibmrgzrlgoflz] has joined #bitcoin-core-dev 16:30 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 268 seconds] 16:34 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 16:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 16:37 < bitcoin-git> [bitcoin] luke-jr opened pull request #21028: doc/bips: Add BIPs 44, 49, and 84 (master...bips_44-49-84) https://github.com/bitcoin/bitcoin/pull/21028 16:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:37 -!- eragmus [sid136308@gateway/web/irccloud.com/x-rkgyewprsfoyakkn] has quit [Ping timeout: 240 seconds] 16:37 -!- bosma [sid103570@gateway/web/irccloud.com/x-nyexlucrheisscct] has quit [Ping timeout: 240 seconds] 16:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 16:40 < bitcoin-git> [bitcoin] luke-jr opened pull request #21029: bitcoin-cli: Correct docs (no "generatenewaddress" exists) (master...cli_doc_geNnewaddr) https://github.com/bitcoin/bitcoin/pull/21029 16:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:40 -!- bosma [sid103570@gateway/web/irccloud.com/x-nmjverzikeizgucz] has joined #bitcoin-core-dev 16:40 -!- eragmus [sid136308@gateway/web/irccloud.com/x-xuojjdcncxvkqvme] has joined #bitcoin-core-dev 16:44 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev 16:45 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 16:47 -!- promag_ [~promag@188.250.84.129] has quit [Ping timeout: 256 seconds] 16:49 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 17:01 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 268 seconds] 17:03 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 264 seconds] 17:04 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 17:04 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 17:07 -!- pinheadmz [~pinheadmz@pool-71-105-114-182.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 17:11 -!- Netsplit *.net <-> *.split quits: jrawsthorne, jesseposner 17:11 -!- Netsplit *.net <-> *.split quits: robert_spigler, icota[m], treyzania 17:12 -!- Netsplit over, joins: robert_spigler, jesseposner, jrawsthorne, treyzania, icota[m] 17:14 -!- michagogo [sid14316@wikia/Michagogo] has quit [Ping timeout: 264 seconds] 17:14 -!- satwhale[m] [satwhalebi@gateway/shell/matrix.org/x-dytcfvbwxprbtvus] has quit [Ping timeout: 240 seconds] 17:14 -!- robert_spigler [robertspig@gateway/shell/matrix.org/x-jjtbjalneajouwbt] has quit [Ping timeout: 240 seconds] 17:14 -!- michagogo_ [sid14316@wikia/Michagogo] has joined #bitcoin-core-dev 17:14 -!- Thomas[m]1 [thomaseizi@gateway/shell/matrix.org/x-hwiefydgdqewymja] has quit [Ping timeout: 240 seconds] 17:15 -!- awesome_doge [awesome-do@gateway/shell/matrix.org/x-qdjwmwfycxpyunqp] has quit [Ping timeout: 260 seconds] 17:15 -!- marty[m]1 [jmacawmatr@gateway/shell/matrix.org/x-iziibmrgzrlgoflz] has quit [Ping timeout: 246 seconds] 17:15 -!- suzziminer[m] [suzziminer@gateway/shell/matrix.org/x-afhitfudsclrtywh] has quit [Ping timeout: 268 seconds] 17:15 -!- jespada [~jespada@90.254.242.138] has quit [Ping timeout: 240 seconds] 17:16 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-ecmdusibinvigata] has quit [Ping timeout: 240 seconds] 17:18 -!- vadorovsky [vadorovsky@gateway/shell/matrix.org/x-gxjythnqxwldbaih] has quit [Ping timeout: 265 seconds] 17:23 -!- jespada [~jespada@90.254.242.138] has joined #bitcoin-core-dev 17:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 17:39 -!- pinheadmz [~pinheadmz@pool-71-105-114-182.nycmny.fios.verizon.net] has quit [Quit: pinheadmz] 17:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:42 < bitcoin-git> [gui] RandyMcMillan opened pull request #202: peers-tab: bug fix right panel toggle (master...peers-tab-sidepanel) https://github.com/bitcoin-core/gui/pull/202 17:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:43 -!- marty[m]1 [jmacawmatr@gateway/shell/matrix.org/x-afcnogluidzzptej] has joined #bitcoin-core-dev 17:44 -!- suzziminer[m] [suzziminer@gateway/shell/matrix.org/x-fgwbdkwkfumivbnf] has joined #bitcoin-core-dev 17:45 -!- awesome_doge [awesome-do@gateway/shell/matrix.org/x-kenquqdsknudpptu] has joined #bitcoin-core-dev 17:45 -!- satwhale[m] [satwhalebi@gateway/shell/matrix.org/x-mggkdhvldemorzke] has joined #bitcoin-core-dev 17:45 -!- Thomas[m]1 [thomaseizi@gateway/shell/matrix.org/x-qvpqwmvltktofajc] has joined #bitcoin-core-dev 17:47 -!- robert_spigler [robertspig@gateway/shell/matrix.org/x-lelrozeewsjoiifv] has joined #bitcoin-core-dev 17:49 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-gtzarhhklecblxod] has joined #bitcoin-core-dev 17:52 -!- vadorovsky [vadorovsky@gateway/shell/matrix.org/x-mxlqhyuuvyhqxhcb] has joined #bitcoin-core-dev 18:01 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 18:02 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 18:02 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection] 18:03 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 18:03 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 18:03 -!- vadorovsky [vadorovsky@gateway/shell/matrix.org/x-mxlqhyuuvyhqxhcb] has quit [Ping timeout: 246 seconds] 18:03 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 260 seconds] 18:03 -!- robert_spigler [robertspig@gateway/shell/matrix.org/x-lelrozeewsjoiifv] has quit [Ping timeout: 260 seconds] 18:03 -!- satwhale[m] [satwhalebi@gateway/shell/matrix.org/x-mggkdhvldemorzke] has quit [Ping timeout: 260 seconds] 18:03 -!- awesome_doge [awesome-do@gateway/shell/matrix.org/x-kenquqdsknudpptu] has quit [Ping timeout: 265 seconds] 18:04 -!- Thomas[m]1 [thomaseizi@gateway/shell/matrix.org/x-qvpqwmvltktofajc] has quit [Ping timeout: 246 seconds] 18:04 -!- suzziminer[m] [suzziminer@gateway/shell/matrix.org/x-fgwbdkwkfumivbnf] has quit [Ping timeout: 240 seconds] 18:04 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-gtzarhhklecblxod] has quit [Ping timeout: 268 seconds] 18:04 -!- marty[m]1 [jmacawmatr@gateway/shell/matrix.org/x-afcnogluidzzptej] has quit [Ping timeout: 260 seconds] 18:04 -!- Emcy_ [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 265 seconds] 18:30 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection] 18:33 -!- robert_spigler [robertspig@gateway/shell/matrix.org/x-pfgpoxykjfjtgpfk] has joined #bitcoin-core-dev 18:35 -!- vadorovsky [vadorovsky@gateway/shell/matrix.org/x-rhiihnrpyeyvtuxh] has joined #bitcoin-core-dev 18:42 -!- satwhale[m] [satwhalebi@gateway/shell/matrix.org/x-ccyfihgterhxuurn] has joined #bitcoin-core-dev 18:44 -!- awesome_doge [awesome-do@gateway/shell/matrix.org/x-sjojevqwtrqcljfc] has joined #bitcoin-core-dev 18:45 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 18:48 -!- suzziminer[m] [suzziminer@gateway/shell/matrix.org/x-atliyvhvvclkvndb] has joined #bitcoin-core-dev 18:48 -!- marty[m]1 [jmacawmatr@gateway/shell/matrix.org/x-mpozidixxyvpotar] has joined #bitcoin-core-dev 18:48 -!- Thomas[m]1 [thomaseizi@gateway/shell/matrix.org/x-twdnnrnjprnwqowk] has joined #bitcoin-core-dev 18:48 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-bfheykxakgkjxtny] has joined #bitcoin-core-dev 19:00 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 19:02 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 240 seconds] 19:21 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has quit [Remote host closed the connection] 19:27 -!- az0re [~az0re@gateway/tor-sasl/az0re] has quit [Remote host closed the connection] 19:30 -!- IPGlider9 [~IPGlider@45.76.34.219] has joined #bitcoin-core-dev 19:32 -!- dongcarl5 [~dongcarl@unaffiliated/dongcarl] has joined #bitcoin-core-dev 19:32 -!- dongcarl5 [~dongcarl@unaffiliated/dongcarl] has quit [Client Quit] 19:32 -!- dongcarl5 [~dongcarl@unaffiliated/dongcarl] has joined #bitcoin-core-dev 19:35 -!- jespada_ [~jespada@90.254.242.138] has joined #bitcoin-core-dev 19:38 -!- Netsplit *.net <-> *.split quits: jespada, dhruvm, Klox, IPGlider, esotericnonsense, Anduck, isis, niftynei, dongcarl, warren, (+3 more, use /NETSPLIT to show all of them) 19:38 -!- dongcarl5 is now known as dongcarl 19:39 -!- IPGlider9 is now known as IPGlider 19:39 -!- Netsplit over, joins: Anduck 19:40 -!- Netsplit over, joins: Klox 19:40 -!- marty[m]1 [jmacawmatr@gateway/shell/matrix.org/x-mpozidixxyvpotar] has quit [Ping timeout: 246 seconds] 19:43 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #bitcoin-core-dev 19:43 -!- Dev0n [~Dev0n@unaffiliated/dev0n] has joined #bitcoin-core-dev 19:43 -!- niftynei [~niftynei@104.131.77.55] has joined #bitcoin-core-dev 19:43 -!- warren [~warren@fedora/wombat/warren] has joined #bitcoin-core-dev 19:43 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has joined #bitcoin-core-dev 19:43 -!- dhruvm [~dhruv@165.227.49.220] has joined #bitcoin-core-dev 19:43 -!- isis [~isis@abulafia.patternsinthevoid.net] has joined #bitcoin-core-dev 19:43 -!- Dev0n [~Dev0n@unaffiliated/dev0n] has quit [Max SendQ exceeded] 19:44 -!- marty[m]1 [jmacawmatr@gateway/shell/matrix.org/x-uukuybwtlxprxvrj] has joined #bitcoin-core-dev 19:46 -!- rodarmor [sid210835@gateway/web/irccloud.com/x-ecnevpgerhrrvsyo] has joined #bitcoin-core-dev 20:00 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 20:02 -!- az0re [~az0re@gateway/tor-sasl/az0re] has joined #bitcoin-core-dev 20:18 -!- Tokamak [~Tokamak@204.141.173.217] has quit [Ping timeout: 240 seconds] 20:30 -!- Tokamak [~Tokamak@204.141.172.64] has joined #bitcoin-core-dev 20:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 20:40 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has joined #bitcoin-core-dev 20:46 -!- rpite [~rpite@47.187.219.52] has joined #bitcoin-core-dev 20:56 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 20:57 -!- rpite [~rpite@47.187.219.52] has quit [Quit: rpite] 21:00 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 268 seconds] 21:07 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 21:10 -!- az0re [~az0re@gateway/tor-sasl/az0re] has quit [Ping timeout: 268 seconds] 21:37 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 21:40 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 272 seconds] 22:02 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 22:03 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 22:12 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Read error: Connection reset by peer] 22:15 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 22:18 -!- Phong_ [~Phong_@185.163.110.109] has joined #bitcoin-core-dev 22:22 -!- ryven [~ryven@50.35.65.1] has joined #bitcoin-core-dev 22:23 -!- ryven [~ryven@50.35.65.1] has quit [Remote host closed the connection] 22:27 -!- Tokamak [~Tokamak@204.141.172.64] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 22:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 22:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:42 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e21338292015...bc5f26d4eee5 22:42 < bitcoin-git> bitcoin/master 5d1f260 Jarol Rodriguez: Improve gui/src/qt README.md 22:42 < bitcoin-git> bitcoin/master bc5f26d MarcoFalke: Merge bitcoin-core/gui#139: doc: Improve gui/src/qt README.md 22:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:43 < bitcoin-git> [gui] MarcoFalke merged pull request #139: doc: Improve gui/src/qt README.md (master...improve-qt-readme) https://github.com/bitcoin-core/gui/pull/139 22:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:44 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bc5f26d4eee5...40dd757bf6ce 22:44 < bitcoin-git> bitcoin/master faff399 MarcoFalke: ci: Fuzz with integer sanitizer 22:44 < bitcoin-git> bitcoin/master 40dd757 MarcoFalke: Merge #21012: ci: Fuzz with integer sanitizer 22:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:44 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #21012: ci: Fuzz with integer sanitizer (master...2101-fuzzIntSan) https://github.com/bitcoin/bitcoin/pull/21012 22:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:45 < bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/40dd757bf6ce...c8b83510f42c 22:45 < bitcoin-git> bitcoin/master a410ae8 Anthony Towns: net, net_processing: log disconnect reasons with -debug=net 22:45 < bitcoin-git> bitcoin/master f7edea3 Anthony Towns: net: make debug logging conditional on -debug=net 22:45 < bitcoin-git> bitcoin/master 1230210 Anthony Towns: net_processing: additional debug logging for ignored messages 22:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:45 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20724: Cleanup of -debug=net log messages (master...202012-net-log-cleanup) https://github.com/bitcoin/bitcoin/pull/20724 22:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:50 -!- rpite [~rpite@47.187.219.52] has joined #bitcoin-core-dev 22:50 -!- rpite [~rpite@47.187.219.52] has quit [Remote host closed the connection] 22:50 -!- rpite [~rpite@47.187.219.52] has joined #bitcoin-core-dev 22:57 -!- raj_149 [~quassel@ec2-18-217-191-36.us-east-2.compute.amazonaws.com] has quit [Quit: No Ping reply in 180 seconds.] 22:58 -!- raj_149 [~quassel@ec2-18-217-191-36.us-east-2.compute.amazonaws.com] has joined #bitcoin-core-dev 23:03 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds] 23:04 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 23:04 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 23:10 -!- ryven [~ryven@50.35.65.1] has joined #bitcoin-core-dev 23:11 -!- a5m0 [~a5m0@unaffiliated/a5m0] has quit [Quit: No Ping reply in 180 seconds.] 23:11 -!- mol [~mol@unaffiliated/molly] has quit [Remote host closed the connection] 23:11 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 23:13 -!- a5m0 [~a5m0@unaffiliated/a5m0] has joined #bitcoin-core-dev 23:13 -!- ryven [~ryven@50.35.65.1] has quit [Remote host closed the connection] 23:22 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 23:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:28 < bitcoin-git> [bitcoin] fanquake opened pull request #21030: refactor: move load block thread into ChainstateManager (master...revive_marco_val_loadblock_thread) https://github.com/bitcoin/bitcoin/pull/21030 23:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:43 -!- Kiminuo [~mix@193.9.112.92] has joined #bitcoin-core-dev 23:47 -!- rpite [~rpite@47.187.219.52] has quit [Ping timeout: 246 seconds] 23:49 -!- sturles_ [~sturles@sauron.uio.no] has joined #bitcoin-core-dev 23:54 -!- sturles [~sturles@unaffiliated/sturles] has quit [Quit: Ḯ'll be back] 23:55 -!- sturles_ [~sturles@sauron.uio.no] has left #bitcoin-core-dev [] --- Log closed Fri Jan 29 00:00:29 2021