--- Log opened Sat Feb 13 00:00:27 2021 00:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:11 < bitcoin-git> [bitcoin] practicalswift opened pull request #21169: fuzz: Add RPC interface fuzzing. Increase fuzzing coverage from 65% to 70%. (master...fuzzing-rpc) https://github.com/bitcoin/bitcoin/pull/21169 00:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:15 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 00:15 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 00:20 -!- nullptr| [~nullptr|@ip-94-112-13-119.net.upcbroadband.cz] has quit [Quit: ZNC - http://znc.in] 00:21 -!- nullptr| [~nullptr|@ip-94-112-13-119.net.upcbroadband.cz] has joined #bitcoin-core-dev 00:27 -!- root [~echo@139.180.133.130] has joined #bitcoin-core-dev 00:27 -!- root is now known as Guest16537 00:31 -!- exhoplex [~echo@139.180.133.130] has quit [Ping timeout: 258 seconds] 00:34 -!- harrigan [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has quit [Read error: Connection reset by peer] 00:38 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev 00:47 -!- Netsplit *.net <-> *.split quits: suzziminer[m] 00:49 -!- Netsplit *.net <-> *.split quits: sturles, btc_thc, isis, romanz_, pierre_rochard, nullptr|, dhruvm, berndj, queip, jrayhawk, (+39 more, use /NETSPLIT to show all of them) 00:49 -!- Netsplit over, joins: suzziminer[m] 00:50 -!- Dev0n [~Dev0n@unaffiliated/dev0n] has quit [Ping timeout: 264 seconds] 00:52 -!- Dev0n [~Dev0n@unaffiliated/dev0n] has joined #bitcoin-core-dev 00:52 -!- sr_gi [~sr_gi@static-125-62-230-77.ipcom.comunitel.net] has joined #bitcoin-core-dev 00:52 -!- gleb [~gleb@178.150.137.228] has joined #bitcoin-core-dev 00:52 -!- nkuttler [~nkuttler@unaffiliated/nkuttler] has joined #bitcoin-core-dev 00:52 -!- hebasto [sid449604@gateway/web/irccloud.com/x-diwgzwdyfnohchvk] has joined #bitcoin-core-dev 00:52 -!- sturles [~sturles@unaffiliated/sturles] has joined #bitcoin-core-dev 00:52 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev 00:52 -!- jakesyl [sid56879@gateway/web/irccloud.com/x-iztdehhgiceanbhh] has joined #bitcoin-core-dev 00:52 -!- tylerchambers [sid477594@gateway/web/irccloud.com/x-azrvixincmqtcbuq] has joined #bitcoin-core-dev 00:52 -!- da2ce7 [~da2ce7@opentransactions/dev/da2ce7] has joined #bitcoin-core-dev 00:52 -!- valwal_ [sid334773@gateway/web/irccloud.com/x-hzzvfdtdjawztrby] has joined #bitcoin-core-dev 00:52 -!- dburkett [sid411344@gateway/web/irccloud.com/x-fsktttelmhthtmah] has joined #bitcoin-core-dev 00:52 -!- dergoegge [sid453889@gateway/web/irccloud.com/x-vpggjtvyxjofpnen] has joined #bitcoin-core-dev 00:52 -!- Galvas [sid459296@gateway/web/irccloud.com/x-oxwszmwkhmipkqtn] has joined #bitcoin-core-dev 00:52 -!- schmidty [sid297174@gateway/web/irccloud.com/x-xvvlfkntomjeacbw] has joined #bitcoin-core-dev 00:52 -!- pierre_rochard [sid299882@gateway/web/irccloud.com/x-fqtcojnbmezqqmsv] has joined #bitcoin-core-dev 00:52 -!- SurajUpadhyay [uid421192@gateway/web/irccloud.com/x-uefgzwkzruiwmhar] has joined #bitcoin-core-dev 00:52 -!- Henry151 [~bishop@ns3007530.ip-151-80-44.eu] has joined #bitcoin-core-dev 00:52 -!- nsh [~lol@wikipedia/nsh] has joined #bitcoin-core-dev 00:52 -!- TD-Linux [~Thomas@about/essy/indecisive/TD-Linux] has joined #bitcoin-core-dev 00:52 -!- nehan [~nehan@41.213.196.104.bc.googleusercontent.com] has joined #bitcoin-core-dev 00:52 -!- Thomas[m]1 [thomaseizi@gateway/shell/matrix.org/x-kkhcnqhctimgvvhq] has quit [Ping timeout: 244 seconds] 00:52 -!- nullptr| [~nullptr|@ip-94-112-13-119.net.upcbroadband.cz] has joined #bitcoin-core-dev 00:52 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev 00:52 -!- IGHOR [~quassel@176.121.4.135] has joined #bitcoin-core-dev 00:52 -!- TallTim [~TallTim@184-83-248-206-dynamic.midco.net] has joined #bitcoin-core-dev 00:52 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 00:52 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev 00:52 -!- gwillen [~gwillen@unaffiliated/gwillen] has joined #bitcoin-core-dev 00:52 -!- willcl_ark [~quassel@cpc123780-trow7-2-0-cust177.18-1.cable.virginm.net] has joined #bitcoin-core-dev 00:52 -!- btc_thc [annalee@kosher.marriageiguana.com] has joined #bitcoin-core-dev 00:52 -!- baldur [~baldur@pool-108-30-51-126.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 00:52 -!- TheRec_ [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 00:52 -!- yunier2002 [~yunier200@c-73-85-126-91.hsd1.fl.comcast.net] has joined #bitcoin-core-dev 00:52 -!- jrayhawk [~jrayhawk@unaffiliated/jrayhawk] has joined #bitcoin-core-dev 00:52 -!- berndj [~berndj@ns1.linksynergy.co.za] has joined #bitcoin-core-dev 00:52 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #bitcoin-core-dev 00:52 -!- niftynei [~niftynei@104.131.77.55] has joined #bitcoin-core-dev 00:52 -!- warren [~warren@fedora/wombat/warren] has joined #bitcoin-core-dev 00:52 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has joined #bitcoin-core-dev 00:52 -!- dhruvm [~dhruv@165.227.49.220] has joined #bitcoin-core-dev 00:52 -!- isis [~isis@abulafia.patternsinthevoid.net] has joined #bitcoin-core-dev 00:52 -!- robert_spigler [robertspig@gateway/shell/matrix.org/x-rnsccjsdeotbttyd] has quit [Ping timeout: 244 seconds] 00:52 -!- vadorovsky [vadorovsky@gateway/shell/matrix.org/x-jwcdoyziqzjwrksl] has quit [Ping timeout: 244 seconds] 00:53 -!- suzziminer[m] [suzziminer@gateway/shell/matrix.org/x-tqulrzmjsooaovnm] has quit [Ping timeout: 258 seconds] 00:53 -!- nkuttler [~nkuttler@unaffiliated/nkuttler] has quit [Max SendQ exceeded] 00:53 -!- queip [~queip@unaffiliated/rezurus] has quit [Max SendQ exceeded] 00:53 -!- jamesob [sid180710@gateway/web/irccloud.com/x-zrkgoizuznjfbmdh] has quit [Ping timeout: 264 seconds] 00:54 -!- chrisguida[m] [chrisguida@gateway/shell/matrix.org/x-uwbcvosxtqwulhdb] has quit [Ping timeout: 265 seconds] 00:54 -!- awesome_doge [awesome-do@gateway/shell/matrix.org/x-bcawxvbklvxyzwdd] has quit [Ping timeout: 265 seconds] 00:55 -!- satwhale[m] [satwhalebi@gateway/shell/matrix.org/x-fkxtyxpyylhahkkd] has quit [Ping timeout: 240 seconds] 00:56 -!- jamesob [sid180710@gateway/web/irccloud.com/session] has joined #bitcoin-core-dev 00:56 -!- a5m0 [~a5m0@unaffiliated/a5m0] has joined #bitcoin-core-dev 00:56 -!- troygior1hev [~troygiors@d67-193-140-136.home3.cgocable.net] has joined #bitcoin-core-dev 00:56 -!- adam3us [~adam3us@unaffiliated/adam3us] has joined #bitcoin-core-dev 00:56 -!- romanz_ [~romanz@93.123.196.104.bc.googleusercontent.com] has joined #bitcoin-core-dev 00:56 -!- nckx [~nckx@tobias.gr] has joined #bitcoin-core-dev 00:56 -!- nckx [~nckx@tobias.gr] has quit [Max SendQ exceeded] 00:56 -!- jamesob [sid180710@gateway/web/irccloud.com/session] has quit [Changing host] 00:56 -!- jamesob [sid180710@gateway/web/irccloud.com/x-pzwbgahsafxohxhq] has joined #bitcoin-core-dev 00:57 -!- nckx [~nckx@tobias.gr] has joined #bitcoin-core-dev 00:57 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev 00:59 -!- nkuttler [~nkuttler@unaffiliated/nkuttler] has joined #bitcoin-core-dev 01:00 -!- harrigan- [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has joined #bitcoin-core-dev 01:01 -!- meshcollider [meshcollid@gateway/shell/ircnow/x-euyphuspntddllnf] has joined #bitcoin-core-dev 01:01 -!- thrasher` [~thrasher@173.209.42.7] has joined #bitcoin-core-dev 01:01 -!- MarcoFalke [~none@198.12.116.246] has joined #bitcoin-core-dev 01:01 -!- treyzania [~treyzania@paphos.tr3y.io] has joined #bitcoin-core-dev 01:02 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Ping timeout: 240 seconds] 01:02 -!- nkuttler [~nkuttler@unaffiliated/nkuttler] has left #bitcoin-core-dev [] 01:04 -!- jungly [~jungly@host-79-35-187-205.retail.telecomitalia.it] has joined #bitcoin-core-dev 01:19 -!- mosh [~chaos@anarchy.consolegfx.com] has quit [Quit: ZNC - https://znc.in] 01:20 -!- mosh [~chaos@anarchy.consolegfx.com] has joined #bitcoin-core-dev 01:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:23 < bitcoin-git> [bitcoin] martinus opened pull request #21170: bench: Add benchmark to write JSON into a string (master...2021-02-benchmark-BlockToJsonVerboseWrite) https://github.com/bitcoin/bitcoin/pull/21170 01:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:23 -!- Thomas[m]1 [thomaseizi@gateway/shell/matrix.org/x-bidqdarffjlpqhkh] has joined #bitcoin-core-dev 01:24 -!- mosh [~chaos@anarchy.consolegfx.com] has quit [Client Quit] 01:25 -!- mosh [~chaos@anarchy.consolegfx.com] has joined #bitcoin-core-dev 01:32 -!- suzziminer[m] [suzziminer@gateway/shell/matrix.org/x-vjdzvmrpxzbwwssa] has joined #bitcoin-core-dev 01:34 -!- satwhale[m] [satwhalebi@gateway/shell/matrix.org/x-kgtpekfbafupyfny] has joined #bitcoin-core-dev 01:34 -!- chrisguida[m] [chrisguida@gateway/shell/matrix.org/x-wzipmdzlewdyucmw] has joined #bitcoin-core-dev 01:34 -!- awesome_doge [awesome-do@gateway/shell/matrix.org/x-ocblcwesgcklpyal] has joined #bitcoin-core-dev 01:34 -!- robert_spigler [robertspig@gateway/shell/matrix.org/x-oxastgasszlqmlqv] has joined #bitcoin-core-dev 01:35 -!- vadorovsky [vadorovsky@gateway/shell/matrix.org/x-vlqewwvswlmnplyi] has joined #bitcoin-core-dev 01:38 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has joined #bitcoin-core-dev 01:42 -!- robert_spigler [robertspig@gateway/shell/matrix.org/x-oxastgasszlqmlqv] has quit [Ping timeout: 240 seconds] 01:42 -!- vadorovsky [vadorovsky@gateway/shell/matrix.org/x-vlqewwvswlmnplyi] has quit [Ping timeout: 258 seconds] 01:43 -!- Thomas[m]1 [thomaseizi@gateway/shell/matrix.org/x-bidqdarffjlpqhkh] has quit [Ping timeout: 246 seconds] 01:43 -!- awesome_doge [awesome-do@gateway/shell/matrix.org/x-ocblcwesgcklpyal] has quit [Ping timeout: 258 seconds] 01:43 -!- suzziminer[m] [suzziminer@gateway/shell/matrix.org/x-vjdzvmrpxzbwwssa] has quit [Ping timeout: 258 seconds] 01:44 -!- satwhale[m] [satwhalebi@gateway/shell/matrix.org/x-kgtpekfbafupyfny] has quit [Ping timeout: 265 seconds] 01:44 -!- chrisguida[m] [chrisguida@gateway/shell/matrix.org/x-wzipmdzlewdyucmw] has quit [Ping timeout: 265 seconds] 02:01 -!- harrigan- [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has quit [Read error: Connection reset by peer] 02:02 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 02:03 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 02:03 -!- Yogibear [b752cc2e@183.82.204.46] has joined #bitcoin-core-dev 02:03 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev 02:04 -!- Yogibear [b752cc2e@183.82.204.46] has quit [Client Quit] 02:06 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [] 02:08 -!- nkuttler [~nkuttler@unaffiliated/nkuttler] has joined #bitcoin-core-dev 02:18 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 02:24 -!- Mugisha [~Mugisha@154.70.198.175] has joined #bitcoin-core-dev 02:27 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services] 02:27 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 02:27 -!- vasild_ is now known as vasild 02:37 -!- vadorovsky [vadorovsky@gateway/shell/matrix.org/x-stbpjwleuymxmxyp] has joined #bitcoin-core-dev 02:38 -!- robert_spigler [robertspig@gateway/shell/matrix.org/x-ygwwwiqyielnmezr] has joined #bitcoin-core-dev 02:41 -!- Mugisha [~Mugisha@154.70.198.175] has quit [Ping timeout: 240 seconds] 02:51 -!- Thomas[m]1 [thomaseizi@gateway/shell/matrix.org/x-ycyubxfpwkcfbbzr] has joined #bitcoin-core-dev 02:54 -!- suzziminer[m] [suzziminer@gateway/shell/matrix.org/x-ghxqzhhaypepsody] has joined #bitcoin-core-dev 02:54 -!- awesome_doge [awesome-do@gateway/shell/matrix.org/x-fbpgallnldigntmy] has joined #bitcoin-core-dev 02:56 -!- chrisguida[m] [chrisguida@gateway/shell/matrix.org/x-ektbmspdcwetbqnu] has joined #bitcoin-core-dev 02:56 -!- satwhale[m] [satwhalebi@gateway/shell/matrix.org/x-atdhqqnvbxlqutcc] has joined #bitcoin-core-dev 03:02 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection] 03:03 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 03:07 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:11 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 03:20 -!- Mugisha [~Mugisha@154.70.198.176] has joined #bitcoin-core-dev 03:20 -!- Mugisha is now known as Guest37066 03:23 -!- Guest37066 [~Mugisha@154.70.198.176] has quit [Client Quit] 03:27 -!- ovovo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 03:28 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 272 seconds] 03:32 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has quit [Ping timeout: 240 seconds] 03:46 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 03:48 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Ping timeout: 268 seconds] 03:49 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev 03:55 -!- owowo [~ovovo@2001:ac8:28:86::4e] has joined #bitcoin-core-dev 03:55 -!- owowo [~ovovo@2001:ac8:28:86::4e] has quit [Changing host] 03:55 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 03:57 -!- ovovo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 272 seconds] 04:03 < michaelfolkson> I'm not 100 percent clear on when you should open an issue in the Core repo if you get an error you are not expecting so posting here. Maybe this should be in #bitcoin even 04:03 < michaelfolkson> Regardless I upgraded one of my 0.19 nodes (Ubuntu) to 0.21 and got this error message 04:03 < michaelfolkson> "2021-02-13T11:42:47Z ERROR: DeserializeFileDB: Failed to open file /home/michael/.bitcoin/anchors.dat" 04:04 < michaelfolkson> Is that expected? 04:07 < michaelfolkson> anchors.dat was only introduced in 0.21 right? But why should it be an error message? It is expected behavior if upgrading 04:08 < michaelfolkson> (not to have an anchor.dat file) 04:13 < michaelfolkson> I guess not having the file is a reasonable motivation for an error message 04:14 < michaelfolkson> I'm just misunderstanding when it should be labeled ERROR and when it should be "nothing to worry about" logging 04:48 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 05:07 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection] 05:07 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 05:13 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 268 seconds] 05:27 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 05:30 -!- othe1 [~othe@217.146.82.202] has quit [Remote host closed the connection] 05:33 -!- harrigan- [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has joined #bitcoin-core-dev 05:34 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Ping timeout: 246 seconds] 06:04 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 06:04 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 06:13 -!- jonatack [~jon@37.164.198.87] has joined #bitcoin-core-dev 06:15 -!- kephra [~kephra@195.140.213.38] has joined #bitcoin-core-dev 06:18 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 06:49 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 268 seconds] 06:51 -!- jonatack [~jon@37.164.198.87] has quit [Read error: Connection reset by peer] 06:51 -!- jonatack [~jon@37.164.198.87] has joined #bitcoin-core-dev 06:52 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 07:32 -!- jungly [~jungly@host-79-35-187-205.retail.telecomitalia.it] has quit [Ping timeout: 240 seconds] 07:32 -!- kcalvinalvin [~kcalvinal@ec2-52-79-199-97.ap-northeast-2.compute.amazonaws.com] has quit [Quit: ZNC 1.7.4 - https://znc.in] 07:33 -!- tralfaz [uid458765@gateway/web/irccloud.com/x-cimbsdwgmuaexqlf] has joined #bitcoin-core-dev 07:36 -!- kcalvinalvin [~kcalvinal@ec2-52-79-199-97.ap-northeast-2.compute.amazonaws.com] has joined #bitcoin-core-dev 07:38 < jonatack> michaelfolkson: that "Failed to open file" error message if no anchors.dat is found seems to be expected, if a bit surprising after an upgrade, see addrdb.cpp::DeserializeFileDB() and streams.h::CAutoFile::IsNull(), and git grep -ni "failed to open" shows that this seems to be the standard error message on file.IsNull() 07:40 < jonatack> thatsaid, idk if there is a bool flag or function for "we just upgraded" that could be checked... 07:42 < jonatack> (if the version of bitcoind is persisted somewhere) 07:42 < jonatack> i'm not aware of one 07:43 < jonatack> could it be added to settings.json? 07:44 < michaelfolkson> Instinctively when I see ERROR I think "Uh oh something is wrong" rather than "Don't worry this file isn't yet created but we can create it for you" 07:46 < michaelfolkson> Presumably if you installed 0.21 from scratch (ie not upgrading from 0.19 to 0.21) you would also get that error message 07:47 < jonatack> sure. my guess is the added complexity required to handle that more-or-less-one-off case wasn't considered to be worth it, if it was considered 07:47 < michaelfolkson> Right, makes sense, thanks 08:08 -!- harrigan- [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has quit [Read error: Connection reset by peer] 08:09 -!- harrigan [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has joined #bitcoin-core-dev 08:22 -!- tannakartikey [~kartikeyt@2409:4055:19e:f498:cc56:64be:11dc:7895] has joined #bitcoin-core-dev 08:24 -!- rc_423_ [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has quit [Ping timeout: 256 seconds] 08:24 -!- jonatack [~jon@37.164.198.87] has quit [Ping timeout: 256 seconds] 08:24 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has joined #bitcoin-core-dev 08:27 -!- harrigan [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has quit [Read error: Connection reset by peer] 08:29 -!- jonatack [jon@gateway/vpn/airvpn/jonatack] has joined #bitcoin-core-dev 08:31 -!- tannakartikey [~kartikeyt@2409:4055:19e:f498:cc56:64be:11dc:7895] has quit [Remote host closed the connection] 08:32 -!- Smartcyberhacker [8ac7344b@138.199.52.75] has joined #bitcoin-core-dev 08:33 -!- harrigan [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has joined #bitcoin-core-dev 08:35 -!- Smartcyberhacker [8ac7344b@138.199.52.75] has quit [Client Quit] 08:38 -!- jonatack [jon@gateway/vpn/airvpn/jonatack] has quit [Ping timeout: 272 seconds] 08:41 -!- jonatack [~jon@37.164.198.87] has joined #bitcoin-core-dev 08:47 -!- jonatack [~jon@37.164.198.87] has quit [Ping timeout: 256 seconds] 08:47 -!- jonatack [~jon@37.164.198.87] has joined #bitcoin-core-dev 08:49 -!- promag [~promag@188.250.84.129] has quit [Remote host closed the connection] 08:50 -!- kcalvinalvin [~kcalvinal@ec2-52-79-199-97.ap-northeast-2.compute.amazonaws.com] has quit [Quit: ZNC 1.7.4 - https://znc.in] 08:52 -!- kcalvinalvin [~kcalvinal@ec2-52-79-199-97.ap-northeast-2.compute.amazonaws.com] has joined #bitcoin-core-dev 08:55 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [] 09:16 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 09:23 -!- harrigan [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has quit [Read error: Connection reset by peer] 09:26 -!- harrigan [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has joined #bitcoin-core-dev 09:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:37 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bf3189eda65d...b08cbd09b8f0 09:37 < bitcoin-git> bitcoin/master c943326 Luke Dashjr: doc/bips: Add BIPs 43, 44, 49, and 84 09:37 < bitcoin-git> bitcoin/master b08cbd0 Wladimir J. van der Laan: Merge #21028: doc/bips: Add BIPs 43, 44, 49, and 84 09:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:37 < bitcoin-git> [bitcoin] laanwj merged pull request #21028: doc/bips: Add BIPs 43, 44, 49, and 84 (master...bips_44-49-84) https://github.com/bitcoin/bitcoin/pull/21028 09:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:54 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 09:55 -!- subatuba21 [18049855@c-24-4-152-85.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 09:56 -!- subatuba21 [18049855@c-24-4-152-85.hsd1.ca.comcast.net] has quit [Client Quit] 10:28 -!- elector [~elector@gateway/tor-sasl/elector] has joined #bitcoin-core-dev 10:30 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 264 seconds] 10:41 -!- harrigan [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has quit [Read error: Connection reset by peer] 10:42 -!- ziyuezhou [4cf235c2@76-242-53-194.lightspeed.tukrga.sbcglobal.net] has joined #bitcoin-core-dev 10:42 -!- harrigan [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has joined #bitcoin-core-dev 10:43 -!- ziyuezhou [4cf235c2@76-242-53-194.lightspeed.tukrga.sbcglobal.net] has quit [Client Quit] 11:07 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 11:16 -!- harrigan [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has quit [Read error: Connection reset by peer] 11:20 -!- harrigan [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has joined #bitcoin-core-dev 11:24 -!- dr_gorilla [53865afd@ip-83-134-90-253.dsl.scarlet.be] has joined #bitcoin-core-dev 11:42 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev 11:42 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Client Quit] 11:43 -!- dr_gorilla [53865afd@ip-83-134-90-253.dsl.scarlet.be] has quit [Quit: Connection closed] 11:53 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 11:54 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 12:05 -!- jungly [~jungly@host-79-35-187-205.retail.telecomitalia.it] has joined #bitcoin-core-dev 12:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:05 < bitcoin-git> [bitcoin] jonatack opened pull request #21171: Save client version to the settings file on shutdown (master...persist-version-on-shutdown) https://github.com/bitcoin/bitcoin/pull/21171 12:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:06 < jonatack> michaelfolkson: ^ 12:11 < michaelfolkson> Cool, I think this could be useful though others may need to be convinced on what exactly it will be used for 12:12 < michaelfolkson> Potentially it is a first step to ironing out some kinks in the upgrading process? 12:12 < michaelfolkson> Recognizing when an upgrade is happening and providing better logging around it to the user? 12:15 < jonatack> Yes, anything that could benefit from knowing if the client version changed since last shutdown. 12:17 < michaelfolkson> Nice, thanks for thinking about it and opening a PR on it. Wasn't expecting that :) 12:18 < jonatack> 👍 12:27 -!- harrigan [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has quit [Read error: Connection reset by peer] 12:32 -!- harrigan [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has joined #bitcoin-core-dev 12:33 -!- tralfaz [uid458765@gateway/web/irccloud.com/x-cimbsdwgmuaexqlf] has quit [Quit: Connection closed for inactivity] 12:37 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Quit: Leaving] 12:52 < luke-jr> I'm not sure we want to behave the same if some user sets -version=foo? 12:53 < luke-jr> maybe calling it "lastrunversion" or something less accident-prone 12:59 -!- fromBlacks [5e36309d@94.54.48.157] has joined #bitcoin-core-dev 13:02 -!- fromBlacks [5e36309d@94.54.48.157] has quit [Client Quit] 13:04 < jonatack> luke-jr: yes, hesitated to call the field "last_run_version" and went for the simpler "version", pending feedback (I'm confused by what you mean with "user sets -version=foo") 13:13 -!- jonatack_ [~jon@37.164.57.52] has joined #bitcoin-core-dev 13:15 < luke-jr> jonatack: anything in settings.json doubles as a bitcoin.conf option at least, on? 13:15 < luke-jr> no?8 13:16 -!- jonatack [~jon@37.164.198.87] has quit [Ping timeout: 256 seconds] 13:23 < jonatack_> gleb: in case it's helpful, after your latest push the erlay PR now builds for me cleanly and the functional tests run without --enable-debug, but I am still seeing the many lock order errors I described in the PR comments after building with --enable-debug 13:24 < jonatack_> luke-jr: checking 13:25 -!- prayank [~Prayank@2409:4053:10:1e6e:f4a9:ce50:495f:9508] has joined #bitcoin-core-dev 13:27 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 13:28 < jonatack_> luke-jr: yes, seems so. hm, -version isn't a conf option a 13:28 < jonatack_> afaik, but point taken to maybe use a more specific field name 13:32 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 13:34 < jonatack_> luke-jr: thanks 13:35 < luke-jr> np 13:48 < prayank> only "labelled" addresses belong to address book in bitcoin core wallet? 13:49 < luke-jr> prayank: not anymore 13:49 < luke-jr> IIRC 13:50 < prayank> Interesting. I have few questions. 13:52 < luke-jr> prayank: define "labelled" â˜ș 13:53 < luke-jr> in particular, pay attention to the distinctions in c5966a87d1f 13:54 < prayank> luke-jr: setlabel "address" "my-label" 13:55 < prayank> Checking https://github.com/bitcoin/bitcoin/commit/c5966a87d1fdd7a98f2baee5b2deddd541fdfb5a right now 13:56 < luke-jr> prayank: that will turn change into non-change 13:56 < luke-jr> I think 13:56 < prayank> luke-jr: yeah thats the issue I need to fix :) 13:56 < prayank> My questions are: 13:56 < prayank> 1. Is "wallet.cpp" the only file I should be searching in if trying to fix something related to change addresses? 13:56 < prayank> Context: https://github.com/bitcoin/bitcoin/issues/20795#issuecomment-770267178 13:56 < prayank> 2. According to comments in Cwallet::IsChange, payment to a script that is ours, but is not in the address book is "change address". Is this correct or its more complex? 13:57 < luke-jr> prayank: it can be in the address book now 13:57 < luke-jr> just not with a label 13:58 < prayank> luke-jr: What is address book in bitcoin core wallet? What makes an address belong to address book? 13:59 < luke-jr> m_address_book 14:00 -!- kephra [~kephra@195.140.213.38] has quit [Remote host closed the connection] 14:02 < prayank> luke-jr: Thanks 14:07 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev 14:17 -!- banux1 [~banux@195.140.213.38] has joined #bitcoin-core-dev 14:24 -!- prayank1 [~Prayank@49.15.234.141] has joined #bitcoin-core-dev 14:25 -!- prayank1 [~Prayank@49.15.234.141] has left #bitcoin-core-dev [] 14:26 -!- prayank [~Prayank@2409:4053:10:1e6e:f4a9:ce50:495f:9508] has quit [Ping timeout: 264 seconds] 14:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:31 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b08cbd09b8f0...43981ee2c84a 14:31 < bitcoin-git> bitcoin/master 9305862 Sjors Provoost: wallet: load flags before everything else 14:31 < bitcoin-git> bitcoin/master 43981ee Wladimir J. van der Laan: Merge #21127: wallet: load flags before everything else 14:31 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 268 seconds] 14:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:31 -!- jonatack_ [~jon@37.164.57.52] has quit [Quit: jonatack_] 14:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:31 < bitcoin-git> [bitcoin] laanwj merged pull request #21127: wallet: load flags before everything else (master...2021/02/wallet_flags) https://github.com/bitcoin/bitcoin/pull/21127 14:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:32 -!- jonatack [~jon@37.164.57.52] has joined #bitcoin-core-dev 14:32 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 14:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:40 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/43981ee2c84a...e4f0c4cd73d8 14:40 < bitcoin-git> bitcoin/master fa051c2 MarcoFalke: doc: Guix is shipped in Debian and Ubuntu 14:40 < bitcoin-git> bitcoin/master e4f0c4c Wladimir J. van der Laan: Merge #21163: doc: Guix is shipped in Debian and Ubuntu 14:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:40 < bitcoin-git> [bitcoin] laanwj merged pull request #21163: doc: Guix is shipped in Debian and Ubuntu (master...2102-docGuix) https://github.com/bitcoin/bitcoin/pull/21163 14:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:48 -!- jonatack [~jon@37.164.57.52] has quit [Read error: Connection reset by peer] 14:48 -!- jonatack_ [~jon@37.164.57.52] has joined #bitcoin-core-dev 14:56 -!- jonatack_ [~jon@37.164.57.52] has quit [Read error: Connection reset by peer] 14:56 -!- jonatack__ [~jon@37.164.57.52] has joined #bitcoin-core-dev 14:59 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 15:03 -!- jonatack__ [~jon@37.164.57.52] has quit [Quit: jonatack__] 15:03 -!- jonatack [~jon@37.164.57.52] has joined #bitcoin-core-dev 15:09 -!- harrigan [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has quit [Read error: Connection reset by peer] 15:10 -!- harrigan [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has joined #bitcoin-core-dev 15:17 -!- promag [~promag@188.250.84.129] has quit [Remote host closed the connection] 15:18 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 15:34 -!- jonatack [~jon@37.164.57.52] has quit [Read error: Connection reset by peer] 15:36 -!- jonatack [~jon@37.164.57.52] has joined #bitcoin-core-dev 15:37 -!- jonatack [~jon@37.164.57.52] has quit [Read error: Connection reset by peer] 15:37 -!- jonatack_ [~jon@37.164.57.52] has joined #bitcoin-core-dev 15:42 -!- jonatack_ [~jon@37.164.57.52] has quit [Read error: Connection reset by peer] 15:43 -!- jonatack_ [~jon@37.164.57.52] has joined #bitcoin-core-dev 16:00 -!- ogo [~ogo@gateway/tor-sasl/ogo] has quit [Remote host closed the connection] 16:00 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Read error: Connection reset by peer] 16:00 -!- elector [~elector@gateway/tor-sasl/elector] has quit [Read error: Connection reset by peer] 16:00 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection] 16:00 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Read error: Connection reset by peer] 16:00 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Read error: Connection reset by peer] 16:00 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Write error: Connection reset by peer] 16:00 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Write error: Connection reset by peer] 16:00 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Read error: Connection reset by peer] 16:00 -!- virtu [~virtu@gateway/tor-sasl/virtu] has quit [Read error: Connection reset by peer] 16:00 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Read error: Connection reset by peer] 16:00 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Read error: Connection reset by peer] 16:00 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Read error: Connection reset by peer] 16:00 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Read error: Connection reset by peer] 16:04 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev 16:04 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 16:04 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 16:05 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 16:06 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 16:06 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 16:06 -!- virtu [~virtu@gateway/tor-sasl/virtu] has joined #bitcoin-core-dev 16:11 -!- elector [~elector@gateway/tor-sasl/elector] has joined #bitcoin-core-dev 16:11 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 16:17 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 16:17 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev 16:26 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 268 seconds] 16:27 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 16:27 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 16:27 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 16:27 -!- jonatack__ [~jon@37.164.57.52] has joined #bitcoin-core-dev 16:28 -!- jonatack_ [~jon@37.164.57.52] has quit [Read error: Connection reset by peer] 16:28 -!- jonatack__ [~jon@37.164.57.52] has quit [Client Quit] 16:29 -!- jonatack [~jon@37.164.57.52] has joined #bitcoin-core-dev 16:39 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 16:46 -!- Setherson [~Setherson@108-255-110-61.lightspeed.tukrga.sbcglobal.net] has joined #bitcoin-core-dev 17:17 -!- ogo [~ogo@gateway/tor-sasl/ogo] has joined #bitcoin-core-dev 17:19 -!- tannakartikey [~tannakart@2409:4055:19e:f498:cc56:64be:11dc:7895] has joined #bitcoin-core-dev 17:26 -!- jungly_ [~jungly@host-82-61-131-239.retail.telecomitalia.it] has joined #bitcoin-core-dev 17:29 -!- baldur [~baldur@pool-108-30-51-126.nycmny.fios.verizon.net] has quit [Ping timeout: 240 seconds] 17:30 -!- jungly [~jungly@host-79-35-187-205.retail.telecomitalia.it] has quit [Ping timeout: 240 seconds] 17:36 -!- tannakartikey [~tannakart@2409:4055:19e:f498:cc56:64be:11dc:7895] has quit [Remote host closed the connection] 17:42 -!- baldur [~baldur@pool-108-30-51-126.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 17:54 -!- tannakartikey [~tannakart@2409:4055:19e:f498:cc56:64be:11dc:7895] has joined #bitcoin-core-dev 17:56 -!- tannakartikey [~tannakart@2409:4055:19e:f498:cc56:64be:11dc:7895] has quit [Remote host closed the connection] 17:58 -!- tannakartikey [~tannakart@2409:4055:19e:f498:cc56:64be:11dc:7895] has joined #bitcoin-core-dev 17:58 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Read error: Connection reset by peer] 17:58 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 18:08 -!- mosh [~chaos@anarchy.consolegfx.com] has quit [Ping timeout: 246 seconds] 18:17 -!- mosh [~chaos@anarchy.consolegfx.com] has joined #bitcoin-core-dev 18:20 -!- tannakartikey [~tannakart@2409:4055:19e:f498:cc56:64be:11dc:7895] has quit [Remote host closed the connection] 19:06 -!- ys0seri0us [9f45ba3b@static.59.186.69.159.clients.your-server.de] has joined #bitcoin-core-dev 19:29 -!- sr_gi [~sr_gi@static-125-62-230-77.ipcom.comunitel.net] has quit [Read error: Connection reset by peer] 19:29 -!- sr_gi [~sr_gi@static-125-62-230-77.ipcom.comunitel.net] has joined #bitcoin-core-dev 19:46 -!- ys0seri0us [9f45ba3b@static.59.186.69.159.clients.your-server.de] has quit [Ping timeout: 240 seconds] 20:07 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 21:25 -!- jonatack [~jon@37.164.57.52] has quit [Ping timeout: 264 seconds] 21:55 -!- banux1 [~banux@195.140.213.38] has quit [Remote host closed the connection] 22:20 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 3.0] 22:22 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 22:45 -!- them_ [~them_@217.146.82.202] has joined #bitcoin-core-dev 22:53 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 23:06 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has joined #bitcoin-core-dev 23:25 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 272 seconds] 23:32 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev 23:36 -!- promag [~promag@188.250.84.129] has quit [Ping timeout: 240 seconds] 23:43 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev 23:48 -!- promag [~promag@188.250.84.129] has quit [Ping timeout: 256 seconds] --- Log closed Sun Feb 14 00:00:28 2021