--- Log opened Tue Feb 23 00:00:37 2021
00:05 -!- bsm1175321 [~mcelrath@50-192-147-253-static.hfc.comcastbusiness.net] has quit [Ping timeout: 256 seconds]
00:08 < MarcoFalke> Time to block the spammer?
00:08 < fanquake> ☑️
00:09 < sipa> it is already done
00:25 -!- jeremyrubin [~jr@024-176-247-182.res.spectrum.com] has quit [Ping timeout: 240 seconds]
00:26 -!- jeremyrubin [~jr@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev
00:36 -!- AstroDroid [~AstroDroi@178.239.168.171] has quit [Remote host closed the connection]
00:39 -!- ddss3219 [2ff13e8f@47.241.62.143] has joined #bitcoin-core-dev
00:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:39 < bitcoin-git> [bitcoin] 4po opened pull request #21276: Update bitcoin.conf (master...patch-1) https://github.com/bitcoin/bitcoin/pull/21276
00:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:40 < bitcoin-git> [bitcoin] 4po closed pull request #21276: Update bitcoin.conf (master...patch-1) https://github.com/bitcoin/bitcoin/pull/21276
00:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:40 < bitcoin-git> [bitcoin] 4po reopened pull request #21276: Update bitcoin.conf (master...patch-1) https://github.com/bitcoin/bitcoin/pull/21276
00:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:41 < bitcoin-git> [bitcoin] fanquake closed pull request #21276: Update bitcoin.conf (master...patch-1) https://github.com/bitcoin/bitcoin/pull/21276
00:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:49 < wumpus> spam spam spam
00:52 < fanquake> wumpus: heh. I just opened this
00:52 < fanquake> https://0bin.net/paste/nsxaCiHF#PmLBoAqCwaVai-q2YHbRY++8fXG1PFQuLWXaKzHNY7M
00:53 < wumpus> fanquake: hehe good
00:53 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
00:54 < wumpus> it took the spammers quite long to discover the trick with using review comments, but unfortunately they're on to it now
00:57 -!- asdlkfjwerpoicvx [~flack@p200300d46f1aca00533dd9f79e77799f.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
01:02 -!- Guest39974 [~ToBeFree@217.146.82.202] has joined #bitcoin-core-dev
01:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:03 < bitcoin-git> [bitcoin] S3RK opened pull request #21277: wallet: listdescriptors uses normalized descriptor form (master...listdescriptors_normalized) https://github.com/bitcoin/bitcoin/pull/21277
01:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:12 -!- jungly [~jungly@host-82-61-129-61.retail.telecomitalia.it] has quit [Ping timeout: 256 seconds]
01:17 -!- jungly [~jungly@host-82-61-129-61.retail.telecomitalia.it] has joined #bitcoin-core-dev
01:18 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
01:25 -!- ddss3219 [2ff13e8f@47.241.62.143] has quit [Quit: Connection closed]
01:26 -!- queip [~queip@unaffiliated/rezurus] has quit [Remote host closed the connection]
01:30 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
01:44 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds]
01:59 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
02:02 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
02:02 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
02:07 -!- elector [~elector@gateway/tor-sasl/elector] has quit [Remote host closed the connection]
02:07 -!- elector [~elector@gateway/tor-sasl/elector] has joined #bitcoin-core-dev
02:07 -!- jeremyrubin [~jr@024-176-247-182.res.spectrum.com] has quit [Ping timeout: 240 seconds]
02:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:10 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1e7dd584a5f9...d386b5423987
02:10 < bitcoin-git> bitcoin/master e348d7e Jarol Rodriguez: qt: Add Copy Address Action to Payment Requests
02:10 < bitcoin-git> bitcoin/master d386b54 MarcoFalke: Merge bitcoin-core/gui#213: qt: Add Copy Address Action to Payment Request...
02:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:10 < bitcoin-git> [gui] MarcoFalke merged pull request #213: qt: Add Copy Address Action to Payment Requests (master...add-copyaddress-requestedpayments) https://github.com/bitcoin-core/gui/pull/213
02:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:16 < bitcoin-git> [bitcoin] laanwj pushed 11 commits to master: https://github.com/bitcoin/bitcoin/compare/d386b5423987...c263c3d7d2a4
02:16 < bitcoin-git> bitcoin/master 19db590 gzhao408: [test] remove unnecessary OP_1s from CSV and CLTV tests
02:16 < bitcoin-git> bitcoin/master 0a76a39 gzhao408: [test] fix CSV test missing OP_ADD
02:16 < bitcoin-git> bitcoin/master 158a0b2 gzhao408: Apply maximal validation flags to tx_valid tests
02:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:16 < bitcoin-git> [bitcoin] laanwj merged pull request #19698: test: apply strict verification flags for transaction tests and assert backwards compatibility (master...test-verify-flags) https://github.com/bitcoin/bitcoin/pull/19698
02:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:27 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services]
02:27 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
02:27 -!- vasild_ is now known as vasild
02:33 < aj> jnewbery: hmm, wondering if i should add dandelion to the p2p topics or leave it 'til the next one
02:34 -!- midnight [~midnight@unaffiliated/midnightmagic] has quit [Ping timeout: 244 seconds]
02:39 -!- midnight [~midnight@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
02:45 -!- nsh [~lol@wikipedia/nsh] has quit [Quit: ZNC - http://znc.in]
02:47 -!- nsh [~lol@wikipedia/nsh] has joined #bitcoin-core-dev
02:56 < jnewbery> aj: throw it on there. If we don't have time we can push it to the next meeting. We can also push one of my two back.
03:00 < hebasto> going to add a separate developer notes for Qt specific issues; which place is more appropriate doc/ or src/qt/ ?
03:08 < michaelfolkson> hebasto: I'd say doc. Where the developer notes are
03:09 < hebasto> michaelfolkson: thanks
03:09 < michaelfolkson> hebasto: Maybe call it developer-notes-qt.md ?
03:09 < michaelfolkson> That way they are next to eachother
03:10 < michaelfolkson> (alphabetically)
03:11 < hebasto> I see
03:11 -!- Kiminuo [~Kiminuo@141.98.103.212] has joined #bitcoin-core-dev
03:18 -!- Madisyn13Rath [~Madisyn13@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev
03:22 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
03:36 < Kiminuo> wumpus, MarcoFalke: Hi, could you have a look if this PR https://github.com/bitcoin/bitcoin/pull/21244 is of any use?
03:40 -!- Madisyn13Rath [~Madisyn13@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 264 seconds]
04:11 -!- smartineng [~Icedove@88.135.18.171] has quit [Quit: smartineng]
04:15 -!- smartineng [~Icedove@88.135.18.171] has joined #bitcoin-core-dev
04:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:25 < bitcoin-git> [gui] hebasto opened pull request #219: qt: Prevent the main window popup menu (master...210223-toolbar) https://github.com/bitcoin-core/gui/pull/219
04:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:38 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
04:38 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
04:50 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
04:54 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 272 seconds]
04:59 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds]
05:02 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
05:04 -!- belcher_ is now known as belcher
05:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:04 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c263c3d7d2a4...84f6c695c6a2
05:04 < bitcoin-git> bitcoin/master c7b4648 fanquake: assumptions: assume a C++17 compiler
05:04 < bitcoin-git> bitcoin/master 5e531e6 fanquake: assumptions: check C++17 assumption with MSVC
05:04 < bitcoin-git> bitcoin/master 84f6c69 MarcoFalke: Merge #21274: assumptions:  Assume C++17
05:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:05 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #21274: assumptions:  Assume C++17 (master...assuming_c++17) https://github.com/bitcoin/bitcoin/pull/21274
05:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:08 -!- prayank [~andr0irc@2402:8100:2068:610a:e46a:56ed:5797:affc] has joined #bitcoin-core-dev
05:25 -!- stevenro- [~steven@2001:19f0:6801:83a:40ba:67e:5c24:ed71] has quit [Quit: ZNC 1.7.4 - https://znc.in]
05:26 -!- stevenroose [~steven@2001:19f0:6801:83a:8d6a:4d01:704c:29f0] has joined #bitcoin-core-dev
05:30 -!- Guest39974 [~ToBeFree@217.146.82.202] has quit [Remote host closed the connection]
05:38 -!- jonatack [~jon@37.172.15.119] has joined #bitcoin-core-dev
05:38 -!- bsm1175321 [~mcelrath@50-192-147-253-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
05:47 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Quit: Leaving]
05:50 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 268 seconds]
05:55 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev
05:59 -!- rex4539_ [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev
05:59 -!- rex4539_ [~rex4539@gateway/tor-sasl/rex4539] has quit [Client Quit]
06:01 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 268 seconds]
06:08 -!- tomkap1 [~tomkap@178.239.168.171] has joined #bitcoin-core-dev
06:09 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Ping timeout: 240 seconds]
06:24 < gleb> jnewbery: Could you give me a slot at the start to talk about erlay update? No discussion, just updating folks. I can only attend only the first half of the meeting that's why asking in advance
06:26 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
06:27 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds]
06:27 -!- realname192 [~real@37.160.35.244] has joined #bitcoin-core-dev
06:30 -!- realname192 [~real@37.160.35.244] has quit [Client Quit]
06:30 -!- realnam193 [~real@37.160.35.244] has joined #bitcoin-core-dev
06:34 -!- prayank [~andr0irc@2402:8100:2068:610a:e46a:56ed:5797:affc] has quit [Ping timeout: 264 seconds]
06:40 < jnewbery> gleb: of course
06:40 < gleb> thank you!
06:41 -!- realname194 [~real@37.160.35.244] has joined #bitcoin-core-dev
06:45 -!- realnam193 [~real@37.160.35.244] has quit [Ping timeout: 265 seconds]
06:46 < wumpus> fanquake: AKZ98 is a new spammer? (what a coincidence just after banning the last one)
06:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:56 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #21279:  scripted-diff: Regenerate key_io data deterministically  (master...2102-testDetGen) https://github.com/bitcoin/bitcoin/pull/21279
06:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:59 -!- jonatack [~jon@37.172.15.119] has quit [Quit: jonatack]
06:59 -!- sr_gi [~sr_gi@static-125-62-230-77.ipcom.comunitel.net] has quit [Read error: Connection reset by peer]
06:59 < wumpus> it follows the same naming scheme as PS113, so i guess it's the same spammer and it's coordinated somehow, we might want to contact github admin adbout this
06:59 -!- sr_gi [~sr_gi@static-125-62-230-77.ipcom.comunitel.net] has joined #bitcoin-core-dev
07:04 < gleb> Wait, p2p meeting is not now?
07:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:04 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/84f6c695c6a2...78effb37f35f
07:04 < bitcoin-git> bitcoin/master faf48f2 MarcoFalke: log: Clarify log message when file does not exist
07:04 < bitcoin-git> bitcoin/master 78effb3 MarcoFalke: Merge #21222: log: Clarify log message when file does not exist
07:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:05 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #21222: log: Clarify log message when file does not exist (master...2102-logFile) https://github.com/bitcoin/bitcoin/pull/21222
07:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:08 < ariard> gleb: I think we're trying a different schedule (21utc) to fit folks on the other side of the earth
07:09 < gleb> ariard: ah okay I wasn’t aware.
07:18 -!- jonatack [~jon@37.172.15.119] has joined #bitcoin-core-dev
07:19 -!- prayank [~andr0irc@2402:8100:2068:610a:e46a:56ed:5797:affc] has joined #bitcoin-core-dev
07:24 -!- prayank [~andr0irc@2402:8100:2068:610a:e46a:56ed:5797:affc] has quit [Ping timeout: 264 seconds]
07:28 -!- realname194 [~real@37.160.35.244] has quit [Remote host closed the connection]
07:28 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
07:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:30 < bitcoin-git> [gui] hebasto opened pull request #220: qt: Do not translate file extensions (master...210223-fileext) https://github.com/bitcoin-core/gui/pull/220
07:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:31 < Norrin> ariard, gleb what are the meeting details?
07:32 < Norrin> its a public meeting that anyone can join, perhaps with mute locked on? 
07:43 < michaelfolkson> Norrin: Open to all on P2P. This channel at 21:00 UTC https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings. No mute required (be respectful obviously)
07:44 < Norrin> michaelfolkson Thanks!
07:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:52 < bitcoin-git> [bitcoin] glozow opened pull request #21280: test / bug fix in transaction_tests (master...2021-02-test-bug) https://github.com/bitcoin/bitcoin/pull/21280
07:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:54 -!- stortz [bb3fa187@187.63.161.135] has joined #bitcoin-core-dev
07:55 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev
08:17 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
08:17 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
08:25 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 264 seconds]
08:33 -!- Cory [~Cory@unaffiliated/cory] has quit [Ping timeout: 272 seconds]
08:41 -!- linkrage [~linkrage@77-85-62-127.ip.btc-net.bg] has joined #bitcoin-core-dev
08:43 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #bitcoin-core-dev
08:44 -!- harrigan [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has quit [Read error: Connection reset by peer]
08:44 < linkrage> Hi, I've just compiled bitcoin-0.8.6 from source on Ubuntu 14.04 (on purpose). It doesn't build bitcoin-cli and looks like that's on purpose ? How dow I communicate with bitcoind to set a passphrase on wallet etc. - curl only ?
08:46 -!- harrigan [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has joined #bitcoin-core-dev
08:51 -!- jeremyrubin [~jr@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev
08:53 < linkrage> got it, no worries :)
08:53 -!- linkrage [~linkrage@77-85-62-127.ip.btc-net.bg] has left #bitcoin-core-dev ["Leaving"]
08:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:57 < bitcoin-git> [bitcoin] laanwj pushed 16 commits to master: https://github.com/bitcoin/bitcoin/compare/78effb37f35f...a9335e4f129c
08:57 < bitcoin-git> bitcoin/master 87a9794 Sjors Provoost: configure: add --enable-external-signer
08:57 < bitcoin-git> bitcoin/master f7eb7ec Sjors Provoost: test: framework: add skip_if_no_external_signer
08:57 < bitcoin-git> bitcoin/master 8cf543f Sjors Provoost: wallet: add -signer argument for external signer command
08:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:57 < bitcoin-git> [bitcoin] laanwj merged pull request #16546: External signer support - Wallet Box edition (master...2019/08/hww-box2) https://github.com/bitcoin/bitcoin/pull/16546
08:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:57 < luke-jr> woo
08:59 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
09:12 -!- Cory [~Cory@unaffiliated/cory] has joined #bitcoin-core-dev
09:23 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
09:23 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
09:27 -!- asdlkfjwerpoicvx [~flack@p200300d46f1aca00533dd9f79e77799f.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!]
09:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:28 < bitcoin-git> [gui] jonatack opened pull request #221: qt, refactor: rpcconsole translatable string fixes and improvements (master...qt-rpcconsole-translation-improvements) https://github.com/bitcoin-core/gui/pull/221
09:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:29 < achow101> yay hardware wallets
09:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:29 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a9335e4f129c...1b045b5eef9a
09:29 < bitcoin-git> bitcoin/master ba7e17e Sebastian Falbesoner: rpc, test: document {previous,next}blockhash as optional
09:29 < bitcoin-git> bitcoin/master 1b045b5 MarcoFalke: Merge #21053: rpc, test: document {previous,next}blockhash as optional
09:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:30 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #21053: rpc, test: document {previous,next}blockhash as optional (master...2021-rpc-test-document-previousnextblockhash-as-optional) https://github.com/bitcoin/bitcoin/pull/21053
09:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:31 < jonatack> congrats provoostenator 
09:33 -!- Henry151 [~bishop@ns3007530.ip-151-80-44.eu] has quit [Read error: Connection reset by peer]
09:47 < jb55> awesome
09:57 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
09:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:57 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1b045b5eef9a...2e8116149ca4
09:57 < bitcoin-git> bitcoin/master 584fd91 Sebastian Falbesoner: init: only use pipe2 if availabile, check in configure
09:57 < bitcoin-git> bitcoin/master 9bac713 Sebastian Falbesoner: build: make HAVE_O_CLOEXEC available outside LevelDB (bugfix)
09:57 < bitcoin-git> bitcoin/master 2e81161 Wladimir J. van der Laan: Merge #21250: build: make HAVE_O_CLOEXEC available outside LevelDB (bugfix...
09:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:57 < bitcoin-git> [bitcoin] laanwj merged pull request #21250: build: make HAVE_O_CLOEXEC available outside LevelDB (bugfix) (master...2021-02-build-pass-have_o_cloexec) https://github.com/bitcoin/bitcoin/pull/21250
09:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:04 -!- harrigan [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has quit [Read error: Connection reset by peer]
10:06 -!- harrigan [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has joined #bitcoin-core-dev
10:09 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 268 seconds]
10:13 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
10:14 -!- eoin [4e98f210@78.152.242.16] has joined #bitcoin-core-dev
10:18 -!- eoin [4e98f210@78.152.242.16] has quit [Client Quit]
10:21 -!- stortz [bb3fa187@187.63.161.135] has quit [Quit: Connection closed]
10:24 -!- jungly [~jungly@host-82-61-129-61.retail.telecomitalia.it] has quit [Ping timeout: 272 seconds]
10:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:29 < bitcoin-git> [bitcoin] achow101 opened pull request #21283: Implement BIP 370 PSBTv2 (master...psbt2) https://github.com/bitcoin/bitcoin/pull/21283
10:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:46 < bitcoin-git> [bitcoin] danben opened pull request #21284: rpc: add the add_inputs option to bumpfee/psbtbumpfee (master...add-add-inputs-option-to-bumpfee) https://github.com/bitcoin/bitcoin/pull/21284
10:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:56 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev
10:57 -!- Cairop [d51f06f8@213.31.6.248] has joined #bitcoin-core-dev
10:59 -!- Cairop [d51f06f8@213.31.6.248] has quit [Client Quit]
11:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:07 < bitcoin-git> [bitcoin] jb55 opened pull request #21285: wallet: fix doc typo in signer option (master...signer-typo) https://github.com/bitcoin/bitcoin/pull/21285
11:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:31 < provoostenator> YES
11:31 < provoostenator> The past is here!
11:33 -!- lightlike [~lightlike@p200300c7ef179100a4f011ef5e24615f.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
11:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:37 < bitcoin-git> [bitcoin] hebasto opened pull request #21286: build: Bump minimum Qt version to 5.9.5 (master...210223-qtmin) https://github.com/bitcoin/bitcoin/pull/21286
11:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:40 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds]
11:45 < provoostenator> I rebased the GUI PR: https://github.com/bitcoin-core/gui/pull/4
11:45 < provoostenator> I think it's ready for testing and some initial review, but it's still a bit rough around the edges.
11:46 < provoostenator> ryanofsky added a suggestion on how to make asyncrhonous, though I might punt that to a new PR
11:47 < provoostenator> I also find that it crashes on (my) macOS when I use the "make deploy" version, probably some Python environment can of worms.
11:47 < provoostenator> But other than that it does actually work. Go play with it :-)
11:53 -!- jungly [~jungly@host-82-61-129-61.retail.telecomitalia.it] has joined #bitcoin-core-dev
11:54 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Read error: Connection reset by peer]
11:56 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
12:00 -!- criley88 [49e07d3a@c-73-224-125-58.hsd1.fl.comcast.net] has joined #bitcoin-core-dev
12:07 -!- ogo [~ogo@gateway/tor-sasl/ogo] has quit [Quit: Leaving]
12:10 -!- criley88 [49e07d3a@c-73-224-125-58.hsd1.fl.comcast.net] has quit [Quit: Connection closed]
12:12 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
12:19 < jnewbery> Reminder that the p2p meeting starts in 40 minutes (2100 UTC)
12:21 -!- smartineng [~Icedove@88.135.18.171] has quit [Ping timeout: 240 seconds]
12:45 -!- prayank [~Prayank@2409:4053:2d08:b361:ad7a:5d0c:7e74:e825] has joined #bitcoin-core-dev
12:46 -!- harrigan [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has quit [Read error: Connection reset by peer]
12:48 -!- harrigan [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has joined #bitcoin-core-dev
12:55 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 260 seconds]
12:55 -!- harrigan [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has quit [Read error: Connection reset by peer]
13:00 < jnewbery> #startmeeting
13:00 < core-meetingbot> Meeting started Tue Feb 23 21:00:18 2021 UTC.  The chair is jnewbery. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
13:00 < core-meetingbot> Available commands: action commands idea info link nick
13:00 < amiti> hi! 
13:00 -!- harrigan [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has joined #bitcoin-core-dev
13:00 -!- mariorz [sid490@gateway/web/irccloud.com/x-rklvsgzeyabamhpu] has quit [Ping timeout: 240 seconds]
13:00 < jnewbery> #bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik 
13:00 < jnewbery> petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild wumpus
13:00 < glozow> hi
13:00 < gleb> hi!
13:00 < sipa> hi
13:00 < ariard> hi
13:01 < hebasto> hi
13:01 -!- fjahr [sid374480@gateway/web/irccloud.com/x-wtgxofjmyomzqblb] has quit [Ping timeout: 272 seconds]
13:01 < aj> hola
13:01 < lightlike> hi
13:01 < jnewbery> hi folks. Proposed meeting topics are here: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings#23-feb-2021. Current priorities are here: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-Current-Priorities
13:01 < gribble> https://github.com/bitcoin/bitcoin/issues/23 | CORS support by gavinandresen · Pull Request #23 · bitcoin/bitcoin · GitHub
13:01 < jnewbery> buenos dias aj!
13:01 -!- mariorz [sid490@gateway/web/irccloud.com/x-nmciwajewsvvqoif] has joined #bitcoin-core-dev
13:02 -!- endogenic [sid145991@gateway/web/irccloud.com/x-fyulhxfzswxbetxf] has quit [Ping timeout: 265 seconds]
13:02 < jnewbery> #topic erlay update (gleb)
13:02 < core-meetingbot> topic: erlay update (gleb)
13:02 < gleb> I’m grateful to all folks pushed me to refactor #18261 in a similar way to txrequest.cpp.
13:02 < gribble> https://github.com/bitcoin/bitcoin/issues/18261 | Erlay: bandwidth-efficient transaction relay protocol by naumenkogs · Pull Request #18261 · bitcoin/bitcoin · GitHub
13:02 < gleb> I’m almost done with that, just need to split cpp/header, split into commits, and add a bit more comments. Gonna be ready in the next couple days.
13:02 < gleb> jnewbery jonatack amiti I recall you mentioned you’d prefer a more modular appoach. Would any of you be able to take a look during this week, before I update the main PR?
13:02 < aj> jnewbery: good nachos to you too!
13:03 < gleb> I would really appreciate initial feedback on the new modularity, and I think this would also help to save review time of those folks focusing on other aspects of the PR.
13:03 -!- fjahr [sid374480@gateway/web/irccloud.com/x-piyhmzkmzjdkkqyq] has joined #bitcoin-core-dev
13:03 < gleb> It’s just that if this new approach is also not really good (for now I personally think it is good), I’d prefer us realizing it earlier, and re-shaping it again.
13:03 < prayank> jnewbery: TIL aj is working on Dandelion 
13:03 -!- endogenic [sid145991@gateway/web/irccloud.com/x-jbdkflfwulatoesk] has joined #bitcoin-core-dev
13:03 < jnewbery> gleb: sure, I'm happy to take a look at it
13:04 < gleb> jnewbery. Great, thanks. If anyone else is willing to join john, please let me know :)
13:04 < gleb> Otherwise, that's it.
13:04 < jnewbery> where is it? how do you want me to leave review?
13:05 < amiti> gleb: I'm also down
13:05 < gleb> It's under naumenkogs/bitcoin/tree/erlay_refactored, but it's currently not ready yet, as I said.
13:05 < jnewbery> I also still think PRing minisketch separately would help move things forward
13:05 < sipa> perhaps leave a comment on the PR when you're done with the refactoring and want comments?
13:05 < ariard> or leave a message on irc here
13:05 < gleb> jnewbery: yeah, since c++ headers is merged, we can probably PR minisketch
13:06 < gleb> sipa: I'm wondering if you'd be a better candidate for merging minisketch? Just realistically, discussing the code and such
13:06 < gleb> Or you'd rather me do it?
13:07 < gleb> Not merging but creating PR I mean.
13:07 -!- jungly [~jungly@host-82-61-129-61.retail.telecomitalia.it] has quit [Ping timeout: 260 seconds]
13:07 < sipa> i'll open a PR to fix the issue that the current minisketch tests run forever (which is unexpected and confuses people)
13:07 < sipa> i think after that we could
13:07 < sipa> i
13:07 < sipa> i'm happy to PR it
13:07 < gleb> Great, thank you.
13:07 < gleb> I'll focus on the erlay part then
13:07 < jnewbery> would minisketch tests run with `make check` in the bitcoin core?
13:08 < sipa> they probably should
13:08 < sipa> (and that makes it a blocker to not have them run forever...)
13:08 < gleb> jnewbery amiti: Let's figure the best way you can help with my erlay refactor in personal messages once I'm ready
13:08 < jnewbery> gleb: just leave a comment on the PR when it's ready and I'll take a look at the branch
13:09 < amiti> +1 
13:09 < sipa> +1
13:09 < gleb> alright
13:09 < jnewbery> that PR is a bit unwieldly at this point. If you're changing the approach and minisketch is going to be split out of it, it might make sense to start a new PR, but you can decide that later
13:10 < gleb> jnewbery: I totally agree.
13:10 < aj> (+1 on a new PR to avoid all the load mores)
13:10 < sipa> yeah
13:10 < jnewbery> ok, we have three other topics:
13:10 < jnewbery> - Orphan reprocessing (jnewbery)
13:10 < jnewbery> - Peer rate-limiting (jnewbery)
13:10 < jnewbery> - Dandelion update (ajtowns)
13:11 < jnewbery> anyone want to add any quick updates or other topics before we move onto those?
13:11 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-lopkrozptkoybihj] has quit [Read error: Connection reset by peer]
13:11 -!- wangchun_ [sid444603@gateway/web/irccloud.com/x-wctqlxoztrxlnilq] has quit [Ping timeout: 272 seconds]
13:11 -!- wangchun [sid444603@gateway/web/irccloud.com/x-fqdszhcdxzjlowom] has quit [Ping timeout: 272 seconds]
13:11 < jnewbery> Dandelion update sounds like it might be the quickest, so maybe we do that first
13:11 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-gkofmiznfvtcdhdl] has joined #bitcoin-core-dev
13:11 < jnewbery> #topic dandelion update (ajtowns)
13:11 < core-meetingbot> topic: dandelion update (ajtowns)
13:12 -!- jakesyl [sid56879@gateway/web/irccloud.com/x-iztdehhgiceanbhh] has quit [Ping timeout: 265 seconds]
13:12 < aj> oh, i was happy for it to be the if-we-had-time
13:12 < aj> anyhoo
13:12 -!- wangchun_ [sid444603@gateway/web/irccloud.com/x-dywaualargxrvjui] has joined #bitcoin-core-dev
13:12 -!- wangchun [sid444603@gateway/web/irccloud.com/x-xkvtmjtertvocryp] has joined #bitcoin-core-dev
13:12 < aj> we were talking about dandelion last week, and maybe have some ideas about how to do it without needing a separate stempool. but it was pointed out there was an idea to do a -lite variant, that only stems for a single hop
13:13 < aj> that has weaker privacy support, but doesn't need new p2p messages or a separate mempool, so should be much easier to implement
13:13 -!- jakesyl [sid56879@gateway/web/irccloud.com/x-vcdpnxclfrimarst] has joined #bitcoin-core-dev
13:13 < glozow> does one-hop work? couldn't you tell where a tx originates if you knew they were one-hopping to you?
13:14 < glozow> idk if i'm missing something
13:14 < aj> i've been chatting on twitter with gulia and she's updated her sims
13:14 < gleb> do you make a new connection for one-hop, or pick from existing conns?
13:14 < jnewbery> I think if an attacker made multiple connections to you, they could tell if you're only relaying a transaction to a single peer
13:14 < aj> glozow: one-hop stem == pick one or two outbound peers and send your tx to them; when you receive a tx always flood it to everyone. so you don't immediately know if a tx was stemmed/flooded to you (and hence don't need different messages)
13:15 < aj> jnewbery: if an outbound connects back to you as an inbound, yeah
13:15 < aj> jnewbery: (you don't stem to inbounds to make that harder, i think)
13:15 < jnewbery> ah, only choose from outbounds
13:16 < aj> https://twitter.com/giuliacfanti/status/1362963585471815680 is the twitter thread, and has some graphs
13:16 < aj> it looks to me like -lite is a signficant enough improvement that it's probably worth tryng, and dandelion++ proper is enough of an improvement on that that it's still worth thinking about if we can make it feasible
13:16 < prayank> aj: I am also trying to resolve conflicts and add Dandelion code (from BIP implementation link) in current master branch. I wasn't even aware you are working on it because nobody informed on IRC, Github or SE when we discussed Dandelion. I will read the Twitter thread and DM you later.
13:17 < sipa> prayank: dandelion lite has basically nothing to do with dandelion (in terms of implementation complexity)
13:17 < aj> prayank: there's a link in that twitter thread to the irc conversation last week
13:17 < gleb> aj: Erlay does something really similar to lite, actually.
13:17 < glozow> i don't think the bip is updated for dandelion++
13:17 < glozow> is it?
13:17 < prayank> sipa: Okay 
13:17 < sipa> the bip is dandelion++ afaik
13:17 < sipa> my impression from dandelion lite is that it's basically 1% of the work to get 80% of the benefits (under vaguely reasonable assumptions)
13:18 < aj> sipa: looks more like 40%-50% of the benefits to me
13:18 < sipa> okay.
13:18 < ariard> so the model is alice initial-broadcast to bob, it's testmempoolaccepted to not let any fingerprint in bob's mempool and stems to caroll, an outbound?
13:18 < glozow> i think bob floods, no?
13:18 < lightlike> would it be either dandelion or erlay, or would both work together?
13:18 < aj> for lite, bob floods
13:18 < sipa> there is no stempool in lite, right? you just remember in the wallet itself, and the rebroadcast uses the full broadcast
13:18 < ariard> okay gotcha
13:19 < gleb> lightlike: they should work together just fine
13:19 < glozow> what if bob black-holes it?
13:19 < glozow> doesn't relay it, i mean
13:19 < sipa> glozow: rebroadcast takes care of it, just like in dandelion (correct me if i'm wrong, aj, i'm going from very vague memory)
13:19 < aj> glozow: you hit the wallet rebroadcast timer and do a flood, probably
13:19 < glozow> doesn't rebroadcast not run for 12 hours at least?
13:19 < jnewbery> can you summarise what the 40-50% benefit is?
13:20 < aj> sipa: i don't think those details are really specced anywhere
13:20 < gleb> black holes also can be detected and disconnected after one occasion.
13:20 < aj> jnewbery: the statistics used are "precision" and "recall" which measure how likely an attacker is to be able to pinpoint the originator of a tx
13:20 -!- btc_thc [annalee@kosher.marriageiguana.com] has quit [Ping timeout: 240 seconds]
13:21 < jnewbery> why is relaying to one outbound peer better than relaying to 2, or 8?
13:21 < sipa> glozow: that'd need to be adjusted then; iirc dandelion has a delay of just a few seconds
13:22 < gleb> jnewbery: other 7 of your conns + inbounds have worse idea that it originated from you
13:22 < gleb> Rather than when you relay to all of them
13:22 < amiti> I think an implementation of dandelion lite would want to add logic for checking if the txn successfully relayed / a quicker rebroadcast if not.
13:22 < aj> jnewbery: stemming to one outbound peer is what's modelled in the sim and paper; i don't think it's clear if there's a best value to use
13:22 < glozow> sipa: sorry i meant, i think currently rebroadcast is on 12-hour-ish timer, but dandelion++ spec has a several second timer. trying to wrap my head around what needs to be implemented for dandelion lite, perhaps would need to have a timer for rebroadcast-just-incase
13:23 < ariard> amiti: quite easy by probing your own mempool to see if you get an announcement back?
13:23 < amiti> yup, exactly
13:23 < gleb> jnewbery: oh sorry, I guess you ask about the exact choice, yeah, 2 could be better than 1..
13:23 < amiti> that just doesn't exist yet
13:23 < gleb> glozow: I was also wondering if rebroadcast here should happen in 10 seconds
13:24 < sipa> glozow: this would be a separate rebroadcast mechanism i believe
13:24 < gleb> I don't see why we should wait 12 hours?
13:24 < amiti> aj: is it easy to run the simulation with 2 outbounds and compare? 
13:24 < sipa> because the dandelion lite "stem" relay can't insert into the mempool
13:24 < glozow> gleb: I mean the current rebroadcast behavior on master, without adding any dandelion stuff
13:25 < ariard> i think the rebroadcast should be considered in function of opening a one-shot for the connection
13:25 < aj> amiti: the sim chooses an anonymity graph with 4 outbounds for each node, and selects one of those outbounds for relay. changing 4 to 2 or 8 is easy, but selecting more than one outbound requires code changes...
13:25 < gleb> ariard: one shot wouldn't work at all, unless nodes don't do that for foreign transactions?
13:25 < gleb> because it's obvious one-shot is a tx source
13:25 < gleb> unless tor
13:26 < aj> gleb: yeah, tor or i2p for oneshot
13:26 < amiti> aj: gotcha
13:27 < gleb> aj: sorry, is this relevant? Are we talking about oneshot over tor as a way to do d lite?
13:27 < ariard> gleb: don't we already assume bob has an easier job to guess alice is the source if you mass-connect?
13:27 < gleb> ariard: Sure, but lite would help against that even without one-shot tor
13:28 < aj> gleb: i thnk the idea is dandelion-lite should work even if your node doesn't do tor/i2p at least. (people talk about lots of things :)
13:28 < gleb> aj: without oneshot then. oneshot without tor doesn't work.
13:28 < aj> gleb: yep
13:29 < jnewbery> aj: do you need help with anything? Would you like people to review a proposal or something else?
13:30 < aj> jnewbery: no, just wanted to update people on what's going on. i don't have a particular plan on what's next at this point
13:30 < ariard> gleb: could you do one shot without tor for a low % of foreign transactions ?
13:30 < amiti> aj: so do I have this right that your current impression that we could implement lite without any protocol changes, code not being too invasive, and get ~40-50% of benefits? what are next steps? 
13:30 < amiti> oh, you just answered part of that
13:30 < gleb> I'd be willing to help. And as a separate thing, aj, we should see how to marry it with erlay in practice, once you reach that point.
13:31 < gleb> ariard: that's something was never discussed. I see that as a measure *on top*, but I'd not rely on this solo.
13:31 < aj> amiti: yes, i think that's right. not sure if more sims are worth doing first; otherwise figuring out how to be able to stem to some peers without contaminating how you respond to the peers you don't stem too would probably be the first bit of implementation
13:32 < jnewbery> aj: hopefully shouldn't be too difficult to update FindTxForGetData. We've done something similar before
13:33 < aj> jnewbery: i think working out the spec would be harder than implementing it...
13:33 < sipa> haha
13:33 < gleb> ariard: that's a cool idea to add noise against any kind of spying. But i think the problem with oneshot-no-tor is that it's success is a function of how ready we are to dos our own network :)
13:33 < jnewbery> yup
13:33 < amiti> jnewbery: something similar? what are you thinking of?
13:34 -!- Neostrada [~neostrada@213.152.188.95] has joined #bitcoin-core-dev
13:35 < jnewbery> m_recently_announced_invs
13:35 < jnewbery> maybe it just works already
13:35 < ariard> gleb: yeah I know...kinda some trade-offs we're hitting with new rebroadcast, more noise, more bandwidth
13:37 -!- Neostrada [~neostrada@213.152.188.95] has quit [Client Quit]
13:37 -!- harrigan [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has quit [Read error: Connection reset by peer]
13:37 < jnewbery> move on to the next topic?
13:37 < aj> sounds good
13:38 < jnewbery> #topic Orphan reprocessing (jnewbery)
13:38 < core-meetingbot> topic: Orphan reprocessing (jnewbery)
13:38 < jnewbery> This is something that recently came up again in #21224
13:38 < gribble> https://github.com/bitcoin/bitcoin/issues/21224 | [p2p] Halt processing of unrequested transactions by ariard · Pull Request #21224 · bitcoin/bitcoin · GitHub
13:38 < jnewbery> we currently reprocess orphan transactions in the context of the node that provided the parent
13:39 < jnewbery> ie node A sends us an orphan transaction, node B sends us its parent, we later process the orphan transaction next time we call ProcessMessages() for node B
13:39 -!- harrigan [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has joined #bitcoin-core-dev
13:39 < jnewbery> it seems a bit strange that we do this, and aj was proposing we change that as part of, or after, orphan handling is split into txorphange
13:40 < ariard> idea would be to assign orphan processing to A only?
13:40 < sipa> so that means we may punish the peer that provided parent for an invalid orphan received from someone else?
13:41 < jnewbery> that seems like a reasonable change to me. We should either process orphan reprocessing in the context of node A, or in some global context (i.e. call PeerManager.DoGenericWork())
13:41 < aj> today, we still lookup the original peer when figuring out who to punish
13:41 < jnewbery> sipa: no, we already punish the peer who provided the orphan if it's consensus invalid
13:41 < sipa> then what do you mean by "in the context of" ?
13:41 < ariard> hmmm I would rather avoid global context where you can trace back and punish dosy peers
13:42 < jnewbery> see OrphanTx.frompeer (https://github.com/bitcoin/bitcoin/blob/78effb37f35ff09733e79497bd6b06d355272d79/src/net_processing.cpp#L151-L154)
13:42 < jnewbery> sipa: we process the transaction the next time we call ProcessMessages(node B)
13:42 < ariard> *can't
13:42 < aj> sipa: we process the tx when we call ProcessMessages for peer B at present (because the child tx goes into the orphan work set of whoever provided the parent)
13:42 < amiti> I think "in the context of" refers to which node we allocate ProcessMessage time to 
13:42 < sipa> ah, i see
13:44 < aj> the idea would be to move the orphan work sets out of the Peer mapping and into a new map in the txorphanage, which can just be sorted by the frompeer, and an entry selected from it during frompeer's ProcessMessages
13:44 < jnewbery> sipa: last time this kind of change was proposed you had concerns about the fact it wouldn't be observationally equivalent: http://www.erisian.com.au/bitcoin-core-dev/log-2020-07-02.html#l-325
13:44 < aj> moving the orphan work sets out of Peer also allows g_cs_orphans to be moved into txorphanage and stop being a global
13:45 < jnewbery> aj: I like this change a lot :)
13:46 < jnewbery> my last proposal was to move orphan reprocessing to a global work queue: ttps://github.com/bitcoin/bitcoin/pull/19364 , but moving it to the work queue of the peer who sent it also seems fine
13:47 < amiti> is the core reasoning to prevent the sorta attack mentioned in this comment: https://github.com/bitcoin/bitcoin/pull/21224#issuecomment-781741925, where a peer who sends a valid txn that activates lots of invalid orphans would take up our CPU time instead of the one who will eventually be punished?  
13:47 < ariard> amiti: I'm not sure the peer who sends a valid txn can be actually the culprit for it
13:48 < amiti> ariard: what? 
13:48 < ariard> a malicious peer, if knowledgeable of tx-relay link between two peers might provoke mempool conflicts to trigger this scenario...
13:48 < ariard> le'ts say you have alice connected to bob, and mallory to both of them, you send tx A to alice, tx A' to bob
13:48 < sipa> jnewbery: i haven't paid attention to the latest discussion; i just hope the motivation is more than "this results in cleaner code for us" if changes observable behavior
13:49 < ariard> you send a set of childrens from tx A, will be relayed to bob and stored as orphan
13:50 < ariard> receiving orphans on bob side, should trigger him to fetch again tx A and thus do the work on alice account
13:51 -!- dbr [62e945dd@c-98-233-69-221.hsd1.dc.comcast.net] has joined #bitcoin-core-dev
13:51 < aj> (i think it's "add latency to Alice's transactions" more than "use up Alice's CPU time")
13:52 < amiti> aj: ok, yeah, that makes sense 
13:52 < amiti> ariard: I think you're saying that an honest peer can send a parent to invalid orphans received from a different peer? 
13:52 -!- dbr [62e945dd@c-98-233-69-221.hsd1.dc.comcast.net] has quit [Client Quit]
13:53 < ariard> aj: do we actually have this notion of peer CPU time? I don't think so...
13:53 < jnewbery> ariard: not yet. That maybe leads nicely into the next topic
13:54 < jnewbery> #topic Peer rate-limiting (jnewbery)
13:54 < core-meetingbot> topic: Peer rate-limiting (jnewbery)
13:54 < ariard> amiti: orphans can be valid there too, and it can work as received from a different peer but not exactly the scenario I was describing
13:54 < jnewbery> Again, this came up in the discussion of #21224
13:54 < aj> ariard: Mallort constructs tx A, and invalid children of A: B1, B2, B3, B4, ... Mallory relays B1..Bn to Bob. Mallory relays A to Alice. Once Bob receives A from Alice, he'll have high latency for the next tx from Alice
13:54 < gribble> https://github.com/bitcoin/bitcoin/issues/21224 | [p2p] Halt processing of unrequested transactions by ariard · Pull Request #21224 · bitcoin/bitcoin · GitHub
13:55 < ariard> amiti: the scenario described by aj is the one you were thinking of, mine orphans are announced to alice (note they're considered as orphan but valid txn by alice)
13:55 < ariard> AFAICT
13:56 < jnewbery> aj: I agree. It makes perfect sense that we don't slow down processing for Alice because of transactions that Bob relayed
13:56 < ariard> *are not considred as orphan (damn english)
13:56 < jnewbery> *that Mallory relayed
13:56 < aj> ariard: bob and alice will relay A and A' to each other, reject them as double spends, and then Alice will reject the children rather than treat them as orphans because they have a rejected parent, i think?
13:57 < ariard> aj: at first sight but you can play with rbf and add a grandparent to A and A' to make it work
13:58 < amiti> yeah, the scenario aj described is my understanding of the reasoning behind why we would change which peer context we process a parent in. 
13:58 < ariard> aj: or if A' has been announced through wtxid-relay are we going to add to rejection filter its txid? orphan parent are fetched through txid
14:00 < jnewbery> ok, that's time!
14:00 < ariard> aj: I should craft a functional test with the scenario, easier way to debate about it :)
14:01 < jnewbery> thanks everyone!
14:01 < jnewbery> #endmeeting
14:01 < core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
14:01 < core-meetingbot> Meeting ended Tue Feb 23 22:01:06 2021 UTC.  
14:01 < core-meetingbot> Minutes:        https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2021/bitcoin-core-dev.2021-02-23-21.00.moin.txt
14:02 < aj> ariard: we don't reject a tx until we've received it (the tx, not its w/txid), and we add both txid and wtxid to recentRejects?
14:04 < aj> or rather we add the txid to recentRejects as well when we know it will fail no matter the witness. maybe that's not the case for double-spends, because theoretically there could be a smaller valid witness that would meet RBF rules?
14:05 < ariard> aj: nope smaller witness valid are bounce back by current mempool logic, see #19645
14:05 < gribble> https://github.com/bitcoin/bitcoin/issues/19645 | Allow updating mempool-txn with cheaper witnesses by ariard · Pull Request #19645 · bitcoin/bitcoin · GitHub
14:07 < sipa> jnewbery: fwiw, i think that arguments about the ability for bad latency for processing of messages from unexpecting peers is a totally valid reason to change behavior
14:07 < sipa> sorry for the kneejerk reaction when this was brought up again
14:07 < aj> ariard: no, i mean if you've got tx A, and want to RBF it to tx B, but B's fee isn't high enough, then tx B' with the same txid but smaller witness data might still be accepted. If you did accept B, you won't accept B' as you point out
14:08 < aj> sipa: sounds like it needs a PR so we can do less hand-wavy review though
14:10 -!- aferreira44 [~andre@2001:1284:f013:e991:e5ae:4270:cdb:4daa] has joined #bitcoin-core-dev
14:16 < ariard> aj: okay thinking further, my naive scenario don't seem to hold but yours where mallory directly announce B1,...,Bn to Bob and relay A to Alice should work
14:16 < ariard> we do AlreadyHave() at orphan parent fetching
14:25 < hebasto> https://github.com/google/leveldb/releases/tag/1.23
14:27 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
14:27 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services]
14:27 -!- vasild_ is now known as vasild
14:30 -!- nbdD [~nb@193.201.175.17] has joined #bitcoin-core-dev
14:32 -!- nbdD [~nb@193.201.175.17] has quit [Remote host closed the connection]
14:33 -!- boltFY [~bolt@182.189.223.70] has joined #bitcoin-core-dev
14:33 -!- boltFY [~bolt@182.189.223.70] has quit [Remote host closed the connection]
14:34 -!- ovovo [~ovovo@2a02:29b8:dc01:1881::2e] has joined #bitcoin-core-dev
14:34 -!- ovovo [~ovovo@2a02:29b8:dc01:1881::2e] has quit [Changing host]
14:34 -!- ovovo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
14:35 -!- kieraHa [~kiera@WGPON-3952-85.wateen.net] has joined #bitcoin-core-dev
14:35 -!- kieraHa [~kiera@WGPON-3952-85.wateen.net] has quit [K-Lined]
14:35 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 264 seconds]
14:40 -!- Kiminuo [~Kiminuo@141.98.103.212] has quit [Ping timeout: 264 seconds]
14:41 -!- ogo [~ogo@gateway/tor-sasl/ogo] has joined #bitcoin-core-dev
14:43 -!- egp_ [~egp_@2.95.74.168] has joined #bitcoin-core-dev
14:43 -!- prayank [~Prayank@2409:4053:2d08:b361:ad7a:5d0c:7e74:e825] has left #bitcoin-core-dev []
14:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:45 < bitcoin-git> [bitcoin] abdullahnazar opened pull request #21287: Create arabmarketcap (master...abdullahnazar-patch-1-1) https://github.com/bitcoin/bitcoin/pull/21287
14:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:45 < bitcoin-git> [bitcoin] fanquake closed pull request #21287: Create arabmarketcap (master...abdullahnazar-patch-1-1) https://github.com/bitcoin/bitcoin/pull/21287
14:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:45 -!- doaks [~doaks@122.49.214.91] has joined #bitcoin-core-dev
14:46 -!- doaks [~doaks@122.49.214.91] has quit [Remote host closed the connection]
14:47 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services]
14:47 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
14:47 -!- vasild_ is now known as vasild
14:48 -!- dkrm [~dkrm@2001:41d0:8:3f7b::1] has quit [Ping timeout: 264 seconds]
14:49 -!- prusnak [sid403625@gateway/web/irccloud.com/x-etmwllgrdxlhyjsd] has quit [Ping timeout: 264 seconds]
14:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:49 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2e8116149ca4...587c986ccf88
14:49 < bitcoin-git> bitcoin/master da30c1b William Casarin: wallet: fix doc typo in signer option
14:49 < bitcoin-git> bitcoin/master 587c986 fanquake: Merge #21285: wallet: fix doc typo in signer option
14:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:50 -!- prusnak [sid403625@gateway/web/irccloud.com/x-omecvxcysclpvrhk] has joined #bitcoin-core-dev
14:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:50 < bitcoin-git> [bitcoin] fanquake merged pull request #21285: wallet: fix doc typo in signer option (master...signer-typo) https://github.com/bitcoin/bitcoin/pull/21285
14:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:51 -!- vansEU [~vans@185.214.223.36] has joined #bitcoin-core-dev
14:51 -!- vansEU [~vans@185.214.223.36] has quit [K-Lined]
15:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:06 < bitcoin-git> [bitcoin] abdullahnazar opened pull request #21288: Create arabmarketcap (master...abdullahnazar-patch-1) https://github.com/bitcoin/bitcoin/pull/21288
15:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:07 < bitcoin-git> [bitcoin] fanquake closed pull request #21288: Create arabmarketcap (master...abdullahnazar-patch-1) https://github.com/bitcoin/bitcoin/pull/21288
15:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:19 -!- lightlike [~lightlike@p200300c7ef179100a4f011ef5e24615f.dip0.t-ipconnect.de] has quit [Quit: Leaving]
15:19 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
15:20 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services]
15:20 -!- vasild_ is now known as vasild
15:28 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 268 seconds]
15:28 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev
15:32 -!- aferreira44 [~andre@2001:1284:f013:e991:e5ae:4270:cdb:4daa] has quit [Ping timeout: 264 seconds]
15:39 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 268 seconds]
15:42 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
15:49 -!- common [~common@unaffiliated/common] has joined #bitcoin-core-dev
15:51 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection]
15:52 -!- shesek [~shesek@164.90.217.137] has joined #bitcoin-core-dev
15:52 -!- shesek [~shesek@164.90.217.137] has quit [Changing host]
15:52 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
15:57 -!- TonyStone [~TonyStone@cpe-74-76-58-56.nycap.res.rr.com] has quit [Remote host closed the connection]
16:14 -!- aferreira44 [~andre@2001:1284:f013:e991:e5ae:4270:cdb:4daa] has joined #bitcoin-core-dev
16:15 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 3.0]
16:16 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
16:30 -!- willcl_ark [~quassel@cpc123780-trow7-2-0-cust177.18-1.cable.virginm.net] has quit [Ping timeout: 240 seconds]
16:30 -!- jasonzhouu [~johnny@112.10.159.148] has quit [Read error: Connection reset by peer]
16:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
16:30 < bitcoin-git> [bitcoin] dscotese opened pull request #21289: Update tc.sh (With only an explanatory comment) (master...patch-2) https://github.com/bitcoin/bitcoin/pull/21289
16:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
16:33 -!- willcl_ark [~quassel@cpc123780-trow7-2-0-cust177.18-1.cable.virginm.net] has joined #bitcoin-core-dev
16:41 -!- promag [~promag@188.250.84.129] has quit [Remote host closed the connection]
16:48 < sipa> g
16:50 -!- jonatack_ [~jon@37.172.39.154] has joined #bitcoin-core-dev
16:51 -!- thrasher` [~thrasher@173.209.42.7] has quit [Ping timeout: 240 seconds]
16:53 -!- jonatack [~jon@37.172.15.119] has quit [Ping timeout: 260 seconds]
16:53 -!- thrasher` [~thrasher@173.209.42.7] has joined #bitcoin-core-dev
16:59 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
17:15 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
17:16 -!- aferreira44 [~andre@2001:1284:f013:e991:e5ae:4270:cdb:4daa] has quit [Ping timeout: 260 seconds]
17:17 -!- chjj [~chjj@unaffiliated/chjj] has quit [Quit: WeeChat 2.2]
17:18 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev
17:19 -!- promag [~promag@188.250.84.129] has quit [Ping timeout: 240 seconds]
17:25 -!- sr_gi [~sr_gi@static-125-62-230-77.ipcom.comunitel.net] has quit [Read error: Connection reset by peer]
17:26 -!- sr_gi [~sr_gi@static-125-62-230-77.ipcom.comunitel.net] has joined #bitcoin-core-dev
17:33 -!- tomkap1 [~tomkap@178.239.168.171] has quit [Remote host closed the connection]
17:37 -!- tktkowashi [d29fc667@PPPf103.tokyo-ip.dti.ne.jp] has joined #bitcoin-core-dev
17:49 -!- chaosagent [~chaosagen@217.146.82.202] has joined #bitcoin-core-dev
17:51 -!- prayank [~andr0irc@2402:8100:206c:3216:e148:591a:9138:f010] has joined #bitcoin-core-dev
17:53 -!- prayank [~andr0irc@2402:8100:206c:3216:e148:591a:9138:f010] has quit [Remote host closed the connection]
17:58 -!- aferreira44 [~andre@2001:1284:f013:e991:e5ae:4270:cdb:4daa] has joined #bitcoin-core-dev
18:01 -!- torke [c125d743@ip-193-37-215-67.cinfuserver.com] has joined #bitcoin-core-dev
18:10 -!- aferreira44 [~andre@2001:1284:f013:e991:e5ae:4270:cdb:4daa] has quit [Ping timeout: 240 seconds]
18:19 < luke-jr> Why `-netinfo=∞` no work? /s
18:23 -!- jigawatt [~mcfly@2605:2700:1:100e:dc::f01d] has joined #bitcoin-core-dev
18:28 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
18:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
18:30 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 260 seconds]
18:31 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Read error: Connection reset by peer]
18:32 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev
18:37 -!- ogo [~ogo@gateway/tor-sasl/ogo] has quit [Quit: Leaving]
18:38 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds]
18:41 -!- aferreira44 [~andre@2001:1284:f013:e991:e5ae:4270:cdb:4daa] has joined #bitcoin-core-dev
18:53 -!- mrostecki [mrostecki@nat/suse/x-eoyhxkkdzzpwxkah] has quit [Quit: WeeChat 1.8]
18:54 -!- mrostecki [mrostecki@nat/suse/x-pqjujqdbchwaunfu] has joined #bitcoin-core-dev
19:02 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
19:03 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has quit [Ping timeout: 256 seconds]
19:03 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
19:03 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
19:07 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds]
19:09 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has joined #bitcoin-core-dev
19:13 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
19:14 -!- torke [c125d743@ip-193-37-215-67.cinfuserver.com] has quit [Ping timeout: 240 seconds]
19:16 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 268 seconds]
19:29 -!- jonatack_ [~jon@37.172.39.154] has quit [Ping timeout: 256 seconds]
19:36 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
19:41 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has quit [Ping timeout: 246 seconds]
19:43 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services]
19:43 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
19:43 -!- vasild_ is now known as vasild
19:44 -!- elector [~elector@gateway/tor-sasl/elector] has quit [Ping timeout: 268 seconds]
19:46 < luke-jr> argh, rushed removal of a feature I actually use regularly -.-
19:46 < luke-jr> https://github.com/bitcoin-core/gui/pull/211
19:48 -!- elector [~elector@gateway/tor-sasl/elector] has joined #bitcoin-core-dev
19:53 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has joined #bitcoin-core-dev
20:02 -!- elector [~elector@gateway/tor-sasl/elector] has quit [Remote host closed the connection]
20:02 -!- elector [~elector@gateway/tor-sasl/elector] has joined #bitcoin-core-dev
20:02 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Remote host closed the connection]
20:03 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection]
20:03 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
20:04 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev
20:10 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 264 seconds]
20:24 -!- tktkowashi [d29fc667@PPPf103.tokyo-ip.dti.ne.jp] has quit [Quit: Connection closed]
20:45 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
20:59 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
21:36 -!- landakram [~mark@75-111-89-129.trckcmtk02.res.dyn.suddenlink.net] has joined #bitcoin-core-dev
21:48 -!- landakram [~mark@75-111-89-129.trckcmtk02.res.dyn.suddenlink.net] has quit [Remote host closed the connection]
22:00 -!- landakram [~mark@75-111-89-129.trckcmtk02.res.dyn.suddenlink.net] has joined #bitcoin-core-dev
22:05 -!- nkligang [da453350@218.69.51.80] has joined #bitcoin-core-dev
22:07 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
22:11 -!- nkligang [da453350@218.69.51.80] has quit [Quit: Connection closed]
22:15 -!- Emcy_ [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev
22:16 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 264 seconds]
22:17 -!- aferreira44 [~andre@2001:1284:f013:e991:e5ae:4270:cdb:4daa] has quit [Ping timeout: 258 seconds]
22:39 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]
22:41 -!- Kiminuo [~Kiminuo@141.98.103.212] has joined #bitcoin-core-dev
22:45 -!- smartineng [~Icedove@88.135.18.171] has joined #bitcoin-core-dev
22:52 -!- MarcoFalke [~none@198.12.116.246] has quit [Quit: ZNC 1.7.1 - https://znc.in]
22:57 -!- MarcoFalke [~none@198.12.116.246] has joined #bitcoin-core-dev
23:20 -!- jeremyrubin [~jr@024-176-247-182.res.spectrum.com] has quit [Ping timeout: 264 seconds]
23:21 -!- Satish [3cf07265@60-240-114-101.static.tpgi.com.au] has joined #bitcoin-core-dev
23:26 < wumpus> huh i use that often too
23:26 < wumpus> it's the primary way i use to organize/label transactions in the wallet
23:28 -!- Satish [3cf07265@60-240-114-101.static.tpgi.com.au] has quit [Quit: Connection closed]
23:29 < wumpus> commented too
23:30 < wumpus> please don't go all-out GNOME here
23:34 < phantomcircuit> wumpus, the transaction view should probably tree out the ouputs but like confusing to newbies
23:34 -!- Satish [3cf07265@60-240-114-101.static.tpgi.com.au] has joined #bitcoin-core-dev
23:35 < hebasto> luke-jr: wumpus: maybe revert it?
23:38 < hebasto> is there a way to colorize test_bitcoin-qt PASS/FAIL output in bash? it's very easy to miss failed test now.
23:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:38 < bitcoin-git> [gui] laanwj opened pull request #223: qt: Re-add transaction "Edit Label" Action (master...2021-02-readd-edit-label) https://github.com/bitcoin-core/gui/pull/223
23:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:41 -!- cubancorona [~cubancoro@pool-72-77-31-161.pitbpa.ftas.verizon.net] has joined #bitcoin-core-dev
23:50 -!- jungly [~jungly@host-82-53-121-195.retail.telecomitalia.it] has joined #bitcoin-core-dev
23:53 < aj> hebasto: re-ack #18017 ?
23:53 < gribble> https://github.com/bitcoin/bitcoin/issues/18017 | txmempool: split epoch logic into class by ajtowns · Pull Request #18017 · bitcoin/bitcoin · GitHub
23:53 < aj> wumpus: ^^ could probably use some re-acks but ought to be RFM, not particular rush though
23:54 < hebasto> aj: I'm in
--- Log closed Wed Feb 24 00:00:38 2021