--- Log opened Fri Feb 26 00:00:40 2021 00:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:02 < bitcoin-git> [bitcoin] S3RK opened pull request #21302: wallet: createwallet examples for descriptor wallets (master...create_descriptor_help) https://github.com/bitcoin/bitcoin/pull/21302 00:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:17 < wumpus> neither bitcoin nor bitcoin-core has any private repositories at least 00:18 < wumpus> but no idea what 'private resources' means here either 00:20 < wumpus> but if it is read-only i suppose it's harmless 00:20 < sipa> i can't actually tell if it is read-only or not 00:33 -!- jungly [~jungly@host-95-252-118-228.retail.telecomitalia.it] has quit [Ping timeout: 276 seconds] 00:34 < wumpus> i found the page but don't entirely get it either, it doesn't seem to be individual permissions just a blanket allow on/off 00:36 -!- Kiminuo [~Kiminuo@141.98.103.116] has joined #bitcoin-core-dev 00:37 < sipa> yeah, but it seems to be something about oauth 00:37 < wumpus> i think i understand now: bitcoin-core has a policy enabled where third-party applications (enabled by organization members) have restricted access to the repositories in the organization, by adding an exception to that page, they can at most get the same permissions as the member (but up to what they actually grant) 00:38 < wumpus> the bitcoin organization does not have this policy enabled at all 00:39 < wumpus> it's a protection against accidental over-granting by members affecting the organization's repoistories 00:39 < wumpus> pretty meta 00:40 < wumpus> but in any case, with the exception enabled, it's stil up to achow101 what to grant and he cannot grant more than the access he has himself 00:41 < sipa> ah, i see 00:48 -!- jungly [~jungly@host-95-252-118-228.retail.telecomitalia.it] has joined #bitcoin-core-dev 00:49 < MarcoFalke> An organization owner has approved the following application to access private data in the Bitcoin Core organization:"Travis CI" from Travis CI GmbH 00:49 < MarcoFalke> Just got that mail ^ 00:49 < MarcoFalke> any idea what is going on. ping sipa wumpus 00:50 < sipa> i didn't do anything for travis 00:50 < sipa> i approved achow101's request for readthedocs.org 00:50 < wumpus> MarcoFalke: which one do we need to allow "Travis CI" or "Travis CI for Open Source"? 00:51 < sipa> are we still using travis? 00:51 < wumpus> i have the second one enabled now, i disabled the first 00:51 < MarcoFalke> we don't even use travis ... 00:51 < wumpus> (it said something about being requested by btcdrak) 00:51 < wumpus> ok, will disable them both then 00:52 < sipa> yeah, when i looked earlier there was a request by btcdrak pending 00:52 < sipa> which is now listed as denied 00:52 < wumpus> right, I rejected that one 00:52 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev 00:53 -!- dr-orlovsky [~dr-orlovs@31.14.40.19] has joined #bitcoin-core-dev 00:53 < MarcoFalke> ok, I can see travis is removed from the apps 00:53 < MarcoFalke> thx 01:06 -!- asdlkfjwerpoicvx [~flack@p200300d46f1aca0092cc750b8bec7536.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 01:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:08 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e49117470b77...8d37841cdf3a 01:08 < bitcoin-git> bitcoin/master a69c3b3 Ivan Metlushko: wallet: listdescriptors uses normalized descriptor form 01:08 < bitcoin-git> bitcoin/master 8d37841 Wladimir J. van der Laan: Merge #21277: wallet: listdescriptors uses normalized descriptor form 01:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:09 < bitcoin-git> [bitcoin] laanwj merged pull request #21277: wallet: listdescriptors uses normalized descriptor form (master...listdescriptors_normalized) https://github.com/bitcoin/bitcoin/pull/21277 01:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:10 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:25 -!- General31Sanford [~General31@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev 01:35 -!- NorrinRadd is now known as Norrin 01:35 < wumpus> let's make a HelpExampleCliNamed 01:35 -!- kinlo [~peter@unaffiliated/kinlo] has quit [Ping timeout: 260 seconds] 01:35 < wumpus> (re https://github.com/bitcoin/bitcoin/pull/21302#discussion_r583491133 ) 01:35 -!- honeybadger [~honeybadg@vps1648322.vs.webtropia-customer.com] has joined #bitcoin-core-dev 01:37 -!- fanquake [sid369002@gateway/web/irccloud.com/x-uofsmevexvbhbxdr] has quit [Read error: Connection reset by peer] 01:37 -!- fanquake [sid369002@gateway/web/irccloud.com/x-asrnjecwrkowwvfh] has joined #bitcoin-core-dev 01:48 -!- kinlo [~peter@unaffiliated/kinlo] has joined #bitcoin-core-dev 02:02 -!- Guest7650 [~real_or_r@2a02:c207:3002:7468::1] has quit [Quit: ZNC 1.8.2 - https://znc.in] 02:03 -!- real_or_random [~real_or_r@173.249.7.254] has joined #bitcoin-core-dev 02:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 272 seconds] 02:24 -!- General31Sanford [~General31@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 256 seconds] 02:27 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 268 seconds] 02:28 < jnewbery> interface_zmq.py is still a bit flakey. TheStack and I have identified the issue and hopefully there'll be a fix soon 02:39 < aj> 9\o/ 02:40 < aj> ^-- that's what jnewbery/thestack will look like holding up the decapitated head of the zmq bug? 02:55 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 02:59 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:11 -!- cjyou [7937cd3c@121-55-205-60.d.c200.guam.net] has joined #bitcoin-core-dev 03:18 -!- Eden80Simonis [~Eden80Sim@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev 03:19 -!- l5t3nc1 [2947095d@41.71.9.93] has joined #bitcoin-core-dev 03:20 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services] 03:20 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 03:20 -!- vasild_ is now known as vasild 03:22 -!- l5t3nc1 [2947095d@41.71.9.93] has quit [Client Quit] 03:23 -!- Eden80Simonis [~Eden80Sim@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 265 seconds] 03:28 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection] 03:30 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 03:35 < Kiminuo> https://github.com/bitcoin/bitcoin/pull/21244 does anyone want to have a look? :) 03:38 -!- cjyou [7937cd3c@121-55-205-60.d.c200.guam.net] has quit [Quit: Connection closed] 03:54 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 268 seconds] 03:56 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 04:04 -!- ishaqm [~ishaqm@79-66-7-254.dynamic.dsl.as9105.com] has joined #bitcoin-core-dev 04:30 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 268 seconds] 04:34 -!- _0x0ff- [~potatoe@2001:bc8:47b0:123::1] has quit [Quit: into the offlines] 04:34 -!- _0x0ff [~potatoe@163.172.166.225] has joined #bitcoin-core-dev 04:34 -!- _0x0ff [~potatoe@163.172.166.225] has quit [Changing host] 04:34 -!- _0x0ff [~potatoe@unaffiliated/0x0ff/x-1210984] has joined #bitcoin-core-dev 04:36 -!- tio [2ee6854b@46.230.133.75] has joined #bitcoin-core-dev 04:57 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 04:57 -!- peutetre [~peutetre@185.163.110.108] has joined #bitcoin-core-dev 05:03 -!- Kiminuo [~Kiminuo@141.98.103.116] has quit [Quit: Leaving] 05:12 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has quit [Ping timeout: 260 seconds] 05:13 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has joined #bitcoin-core-dev 05:17 -!- tio [2ee6854b@46.230.133.75] has quit [Quit: Connection closed] 05:31 -!- jungly [~jungly@host-95-252-118-228.retail.telecomitalia.it] has quit [Ping timeout: 264 seconds] 05:35 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 05:39 -!- jungly [~jungly@host-95-252-118-228.retail.telecomitalia.it] has joined #bitcoin-core-dev 05:48 -!- ivanacostarubio [~ivanacost@189.172.197.192] has joined #bitcoin-core-dev 05:49 -!- Lightsword [~Lightswor@2604:a880:1:20::1d3:9001] has quit [Quit: ZNC] 05:50 -!- Lightsword [~Lightswor@2604:a880:1:20::1d3:9001] has joined #bitcoin-core-dev 06:02 -!- sipa_ [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 06:03 -!- tralfaz is now known as davterra 06:06 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Ping timeout: 268 seconds] 06:08 -!- jonatack [~jon@37.173.36.152] has joined #bitcoin-core-dev 06:13 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Ping timeout: 272 seconds] 06:17 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 06:24 -!- brg444 [uid207215@gateway/web/irccloud.com/x-xngputqdkmzpojmw] has joined #bitcoin-core-dev 06:25 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 06:25 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 06:25 -!- emzy [~quassel@2a01:4f8:192:628a::83] has quit [Changing host] 06:25 -!- emzy [~quassel@unaffiliated/emzy] has joined #bitcoin-core-dev 06:43 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 268 seconds] 06:44 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 06:48 -!- jonatack [~jon@37.173.36.152] has quit [Read error: Connection reset by peer] 06:48 -!- jonatack_ [~jon@37.173.36.152] has joined #bitcoin-core-dev 06:55 -!- ivanacostarubio [~ivanacost@189.172.197.192] has quit [Quit: ivanacostarubio] 06:55 -!- jonatack_ [~jon@37.173.36.152] has quit [Quit: jonatack_] 06:56 -!- jonatack [~jon@37.173.36.152] has joined #bitcoin-core-dev 07:07 -!- jonatack_ [~jon@37.173.36.152] has joined #bitcoin-core-dev 07:07 -!- jonatack [~jon@37.173.36.152] has quit [Read error: Connection reset by peer] 07:08 -!- jonatack_ [~jon@37.173.36.152] has quit [Client Quit] 07:09 -!- jonatack [~jon@37.173.36.152] has joined #bitcoin-core-dev 07:12 -!- jonatack [~jon@37.173.36.152] has quit [Excess Flood] 07:13 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Ping timeout: 268 seconds] 07:14 -!- jonatack [jon@gateway/vpn/airvpn/jonatack] has joined #bitcoin-core-dev 07:19 -!- jonatack [jon@gateway/vpn/airvpn/jonatack] has quit [Ping timeout: 276 seconds] 07:24 -!- deJavu [4ebb29bb@78.187.41.187] has joined #bitcoin-core-dev 07:25 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev 07:26 -!- jonatack [~jon@37.173.36.152] has joined #bitcoin-core-dev 07:44 -!- ivanacostarubio [~ivanacost@189.172.197.192] has joined #bitcoin-core-dev 07:48 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 07:49 -!- ivanacostarubio_ [~ivanacost@189.172.197.192] has joined #bitcoin-core-dev 07:50 -!- ivanacostarubio [~ivanacost@189.172.197.192] has quit [Ping timeout: 256 seconds] 08:01 -!- ivanacostarubio_ [~ivanacost@189.172.197.192] has quit [Quit: ivanacostarubio_] 08:03 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 08:29 -!- belcher_ is now known as belcher 09:08 -!- asdlkfjwerpoicvx [~flack@p200300d46f1aca0092cc750b8bec7536.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!] 09:10 -!- Mercury_Vapor [~Mercury_V@174-082-158-108.res.spectrum.com] has joined #bitcoin-core-dev 09:12 -!- Asbestos_Vapor [~Mercury_V@174-082-158-108.res.spectrum.com] has quit [Ping timeout: 264 seconds] 09:27 < dongcarl> I find myself writing some utility functions in bash which is useful to other scripts, would ./contrib/bash-snippets be a good place to put them? 09:28 < hebasto> dev-wiki? 09:29 < dongcarl> hebasto: Meh, what I mean is functions which can be sourced and used so that we don't repeat them everywhere 09:30 < hebasto> I see 09:34 -!- mmitech___ [sid446259@gateway/web/irccloud.com/x-qljsorysylmcrttz] has quit [Ping timeout: 264 seconds] 09:35 -!- mmitech___ [sid446259@gateway/web/irccloud.com/x-rxykiegsaovaugsg] has joined #bitcoin-core-dev 09:35 -!- jonatack [~jon@37.173.36.152] has quit [Ping timeout: 265 seconds] 09:35 -!- endogenic [sid145991@gateway/web/irccloud.com/x-jbdkflfwulatoesk] has quit [Ping timeout: 260 seconds] 09:36 -!- endogenic [sid145991@gateway/web/irccloud.com/x-keltmqvirxcrragz] has joined #bitcoin-core-dev 09:36 -!- jessepos_ [~jp@2601:645:200:162f:18b0:ad00:6043:7e74] has quit [Quit: Textual IRC Client: www.textualapp.com] 09:37 -!- jesseposner [~jp@2601:645:200:162f:ed47:4e32:2608:2782] has joined #bitcoin-core-dev 09:40 -!- jonatack [~jon@37.173.36.152] has joined #bitcoin-core-dev 10:05 < shesek> what are the standardness rules for bare multisig? there's N<=3, valid pubkey first byte and size (according to CpubKey::ValidSize) and NULLDUMMY, did I miss anything? 10:06 < shesek> (NULLDUMMY being validness rather than standardness as of bip62) 10:06 < sipa_> bip62 is not consensus 10:06 -!- eoin [33252175@51.37.33.117] has joined #bitcoin-core-dev 10:06 -!- sipa_ is now known as sipa 10:07 < shesek> oh oops, yes, I was confused 10:07 < sipa> you may mean bip147 10:09 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 10:09 -!- Emcy_ [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 260 seconds] 10:09 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds] 10:11 < shesek> yes, I did, mixed some things up 10:11 < shesek> are there any checks besides these I mentioned? 10:15 < sipa> you'd need to distinguish between output creation time and spending time 10:15 < sipa> at output creation it needs to match the bare multisig template exactly (or one of the other templates) 10:16 < sipa> i don't think the contents of those keys matters 10:19 -!- mrostecki [mrostecki@nat/suse/x-jjcsmdeexpuvtwuh] has quit [Quit: WeeChat 1.8] 10:20 -!- mrostecki [mrostecki@nat/suse/x-sdnnjckashdcacrc] has joined #bitcoin-core-dev 10:20 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 10:21 -!- eoin [33252175@51.37.33.117] has quit [Quit: Connection closed] 10:31 < shesek> sipa, it was actually you that introduced a more strict checking of pubkeys in https://github.com/bitcoin/bitcoin/pull/13194 10:31 < shesek> https://github.com/bitcoin/bitcoin/issues/14104#issuecomment-417246959 10:33 < sipa> shesek: ah yes, you're right 10:37 -!- yojoots [~justin@2600:1700:19e0:4b10:395d:4876:3b09:9fed] has quit [Quit: Leaving] 10:43 < sipa> dongcarl, fanquake, wumpus: i now also did a guix build of 21298 in my debian vm with guix-master-a-week-ago-installed-from-source, and i get a mismatch on osx-unsigned.tar.gz 10:43 < sipa> the machine also crashed while building, which may mean it's just corrupted 10:43 * sipa redoes build 10:44 < dongcarl> sipa: Oh! Yeah I'd love to take a look at that 10:44 < dongcarl> sipa: Also, does `journalctl -b-1` tell you anything about what caused the crash? 10:44 < sipa> the dmg is a match, however 10:45 < sipa> dongcarl: the host machine crashed, taking the VM with it 10:45 < dongcarl> Oh okay heh 10:45 < sipa> size is 2 bytes difference 10:46 < dongcarl> sipa: Huh... Do you still have the output or did you nuke it? 10:47 < sipa> i have the output, comparing the contents of the tar now 10:48 < dongcarl> sipa: If you use diffoscope, you can use the `--json output.json` option to encapsulate just the diff, and I can take a look if you want 10:49 < sipa> pagestuff and codesign_allocate differ... 10:50 < dongcarl> sipa: Oh! We don't need those anymore, right? 10:50 < sipa> i believe we don't 10:50 < dongcarl> Okay, if that's everything then we're good :-) 10:51 < sipa> is it worth investigating what's causing the difference regardless? 10:52 < dongcarl> I think so, but I'm trying to prioritize what I do so I can keep to my timeline... If you upload the tarball somewhere I will take a look! 10:56 < sipa> dongcarl: http://bitcoin.sipa.be/builds/bitcoin-c33b199456e5-osx-unsigned-BAD.tar.gz 10:56 < dongcarl> sipa: Thanks! 11:01 < achow101> wallet meeting? 11:03 < jonatack> i'm around (reviewing 20685) 11:03 < achow101> #startmeeting 11:03 < jonatack> hola achow101 11:03 < achow101> any topics to discuss? 11:04 < jonatack> looks like some nice doc improvements are happening in HWI 11:04 -!- Kiminuo [~Kiminuo@141.98.103.116] has joined #bitcoin-core-dev 11:04 < achow101> #bitcoin-core-dev wallet Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik 11:04 < achow101> petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild wumpus 11:04 < achow101> yeah, should be getting a HWI release soon 11:05 < jonatack> #21083 is your blocker/high-prio, yes? 11:05 < gribble> https://github.com/bitcoin/bitcoin/issues/21083 | wallet: Avoid requesting fee rates multiple times during coin selection by achow101 · Pull Request #21083 · bitcoin/bitcoin · GitHub 11:05 < achow101> yes 11:06 < sipa> some review on #20861 would be helpful 11:06 < gribble> https://github.com/bitcoin/bitcoin/issues/20861 | BIP 350: Implement Bech32m and use it for v1+ segwit addresses by sipa · Pull Request #20861 · bitcoin/bitcoin · GitHub 11:06 < achow101> sipa: I'll try to review it next week 11:06 < jonatack> +1 11:06 < sipa> next week i hope to have another successor open ;) 11:07 < luke-jr> another successor? 11:07 < achow101> any news on taproot descriptors? 11:07 < sipa> taproot signing supporty 11:07 < sipa> and descriptors 11:07 < sipa> or at least, a first pass at it 11:07 < achow101> yay descriptors 11:07 < jonatack> nice 11:09 < jonatack> S3RK kindly did an in-depth review of #20391, which I'll update soon per their feedback to move the sat/vB stuff forward 11:09 < gribble> https://github.com/bitcoin/bitcoin/issues/20391 | wallet: introduce setfeerate (an improved settxfee, in sat/vB) by jonatack · Pull Request #20391 · bitcoin/bitcoin · GitHub 11:09 < jonatack> along with one adding a setestimatefee RPC 11:10 < jonatack> and fjahr's coinstats work moved forward since last meeting with a MuHash merge 11:11 < jonatack> so #19521 is next 11:11 < gribble> https://github.com/bitcoin/bitcoin/issues/19521 | Coinstats Index by fjahr · Pull Request #19521 · bitcoin/bitcoin · GitHub 11:11 < achow101> we also got the listdescriptors command this week and I think the followup to have it output normalized descriptors was also merged today 11:11 < sipa> yay 11:11 < jonatack> yess 11:12 < achow101> I'll be working on another followup so the wallet doesn't need to be unlocked to get the normalized descriptor 11:13 < achow101> anything else to discuss? 11:13 < jonatack> achow101: iirc there was some leftover feedback from the listdescriptors pull you could maybe take in the next one 11:13 < achow101> ok 11:15 < jonatack> * s/setestimatefee/estimatefeerate/ 11:15 < achow101> #endmeeting 11:15 < achow101> jonasschnelli_: I think the meeting bot died again 11:18 -!- promag [~promag@188.250.84.129] has quit [Read error: Connection reset by peer] 11:18 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev 11:20 -!- jeremyrubin [~jr@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev 11:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:27 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8d37841cdf3a...5ba5becbb5d8 11:27 < bitcoin-git> bitcoin/master 13a9fd1 Carl Dong: guix: Passthrough SDK_PATH into container 11:27 < bitcoin-git> bitcoin/master 5ba5bec Wladimir J. van der Laan: Merge #21272: guix: Passthrough SDK_PATH into container 11:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:27 < bitcoin-git> [bitcoin] laanwj merged pull request #21272: guix: Passthrough SDK_PATH into container (master...2021-02-guix-SDK-specify) https://github.com/bitcoin/bitcoin/pull/21272 11:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:36 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 11:55 -!- larryruane_ [uid473749@gateway/web/irccloud.com/x-upkfdqqafqqugupm] has quit [Quit: Connection closed for inactivity] 12:01 -!- belcher [~belcher@unaffiliated/belcher] has quit [Read error: Connection reset by peer] 12:01 -!- copumpkin [~copumpkin@unaffiliated/copumpkin] has quit [Quit: Hmmm] 12:02 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 12:04 -!- pinheadmz [~pinheadmz@pool-71-105-114-182.nycmny.fios.verizon.net] has quit [Remote host closed the connection] 12:08 -!- pinheadmz [~pinheadmz@pool-71-105-114-182.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 12:11 -!- pinheadmz [~pinheadmz@pool-71-105-114-182.nycmny.fios.verizon.net] has quit [Remote host closed the connection] 12:12 -!- pinheadmz [~pinheadmz@pool-71-105-114-182.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 12:15 -!- jungly [~jungly@host-95-252-118-228.retail.telecomitalia.it] has quit [Ping timeout: 265 seconds] 12:15 -!- deJavu [4ebb29bb@78.187.41.187] has quit [Quit: Connection closed] 12:15 -!- pinheadmz [~pinheadmz@pool-71-105-114-182.nycmny.fios.verizon.net] has quit [Remote host closed the connection] 12:16 -!- pinheadmz [~pinheadmz@pool-71-105-114-182.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 12:18 -!- pinheadmz [~pinheadmz@pool-71-105-114-182.nycmny.fios.verizon.net] has quit [Client Quit] 12:22 -!- copumpkin [~copumpkin@unaffiliated/copumpkin] has joined #bitcoin-core-dev 12:26 -!- ojoo [c15b8b3f@c3F8B5BC1.dhcp.as2116.net] has joined #bitcoin-core-dev 12:27 -!- ojoo [c15b8b3f@c3F8B5BC1.dhcp.as2116.net] has quit [Client Quit] 12:53 -!- pinheadmz [~pinheadmz@pool-71-105-114-182.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 13:05 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 13:08 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 13:09 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 13:11 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 276 seconds] 13:16 -!- dermoth_ [~dermoth@unaffiliated/dermoth] has joined #bitcoin-core-dev 13:19 -!- dermoth [~dermoth@unaffiliated/dermoth] has quit [Ping timeout: 246 seconds] 13:20 -!- belcher_ is now known as belcher 13:23 -!- ahmed517 [uid486440@gateway/web/irccloud.com/x-jrwwmvaelkpkoitx] has joined #bitcoin-core-dev 13:24 -!- jonatack_ [~jon@37.167.224.27] has joined #bitcoin-core-dev 13:25 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 268 seconds] 13:25 -!- jonatack [~jon@37.173.36.152] has quit [Ping timeout: 265 seconds] 13:42 -!- pinheadmz [~pinheadmz@pool-71-105-114-182.nycmny.fios.verizon.net] has quit [Read error: Connection reset by peer] 13:43 -!- pinheadmz [~pinheadmz@pool-71-105-114-182.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 13:48 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 13:51 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 13:51 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds] 13:59 < michaelfolkson> Hey. Does anyone have views on a config option released in Core such that the user could change lockinontimeout (lot) from false to true? (assuming lot was set to false by default) 13:59 < michaelfolkson> I'm looking for Concept NACKs ideally if anyone has one 14:02 < michaelfolkson> "I like a hidden option in Core which is always there from day one, which is lot=true or taproot-bip8-lot-true or something that would change lockinontimeout to true and also change the default user agent string so you can tell people are running it. That’s good because by the time 6 months comes almost everyone has upgraded anyway, they’ve just got to change their config." (From the Sydney Socratic) 14:18 -!- Kiminuo [~Kiminuo@141.98.103.116] has quit [Quit: Leaving] 14:32 -!- ishaqm [~ishaqm@79-66-7-254.dynamic.dsl.as9105.com] has quit [Remote host closed the connection] 14:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:56 < bitcoin-git> [bitcoin] dongcarl opened pull request #21304: guix: Various user workflow improvements (master...2021-02-guix-clean-script) https://github.com/bitcoin/bitcoin/pull/21304 14:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 15:05 -!- jeremyrubin [~jr@024-176-247-182.res.spectrum.com] has quit [Ping timeout: 256 seconds] 15:13 -!- grench [grench@gateway/vpn/protonvpn/grench] has joined #bitcoin-core-dev 15:14 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 15:20 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 15:20 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services] 15:20 -!- vasild_ is now known as vasild 15:23 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 15:26 -!- jonatack_ [~jon@37.167.224.27] has quit [Ping timeout: 264 seconds] 15:32 -!- ahmed517 [uid486440@gateway/web/irccloud.com/x-jrwwmvaelkpkoitx] has quit [Quit: Connection closed for inactivity] 15:56 -!- very_sneaky [~very_snea@45.67.96.18] has quit [Remote host closed the connection] 15:56 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 15:56 -!- very_sneaky [~very_snea@45.67.96.18] has joined #bitcoin-core-dev 16:03 -!- brg444 [uid207215@gateway/web/irccloud.com/x-xngputqdkmzpojmw] has quit [Quit: Connection closed for inactivity] 16:38 -!- jonatack_ [~jon@37.167.35.203] has joined #bitcoin-core-dev 16:42 -!- jonatack_ [~jon@37.167.35.203] has quit [Read error: Connection reset by peer] 16:44 -!- grench [grench@gateway/vpn/protonvpn/grench] has quit [Quit: Leaving] 17:42 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 264 seconds] 17:49 -!- jeremyrubin [~jr@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev 18:14 < sipa> achow101: i'm breaking my head... i don't understand how ProduceSignature ever worked at all 18:15 < achow101> sipa: where? 18:16 < sipa> if you call it through SignSignature, from multiple SPKMs, as far as i can see, if the first SPKM is able to sign, the second one will just wipe the witness 18:16 < achow101> It'll do VerifyScript and find it to be valid 18:17 < sipa> oh 18:17 < achow101> Then abort early and not change anything 18:17 < sipa> got it! 18:17 < sipa> this explains 18:17 < sipa> thanks 18:18 < sipa> it constructs a new checker objects, which doesn't have access to PrecomputedTransactionData, which is necessary to verify taproot sigs 18:18 < achow101> Yeah 18:18 < achow101> I have a pr for that actually 18:18 < sipa> oh? 18:18 < achow101> (for other reasons, but should give access to that) 18:19 < sipa> passing down the signaturecreator's checker, rather than constructing a new one? 18:19 < achow101> #21166 18:19 < gribble> https://github.com/bitcoin/bitcoin/issues/21166 | Have SignatureExtractorChecker subclass MutableTransactionSignatureChecker by achow101 · Pull Request #21166 · bitcoin/bitcoin · GitHub 18:20 < sipa> no, that doesn't work 18:20 < sipa> it's still creating a new checker 18:20 < sipa> (which includes a new MutableTransactionSignatureChecker) 18:20 < achow101> Ah, think I just don't know what you need 18:21 < sipa> yeah, it's a fine change, but it's orthogonal 18:22 < sipa> also: really, we're verifying every existing witness in a transaction being signed in every SPKM? 18:23 < achow101> I guess we are 18:23 < sipa> i'm sure there's a way to keep it in SignatureData form across those calls 18:23 < sipa> which would avoid that 18:23 < sipa> also orthogonal, of course 18:24 < achow101> Yeah. Signing performance hasn't really been a concern too 18:24 < sipa> yeah 18:24 < sipa> just seems a bit silly, it's not a big deal 18:29 < sipa> achow101: can you explain how 21166 fixes 21151? what function specifically is missing? 18:29 < achow101> CheckSequnce was missing 18:29 < sipa> i see 18:30 < achow101> Same with ChecLockTime, so op_cltv scripts don't work too 18:30 < sipa> yeah 18:47 -!- brg444 [uid207215@gateway/web/irccloud.com/x-hpmuwukpfclzfzft] has joined #bitcoin-core-dev 18:53 < sipa> achow101: i think there is a simpler solution... just don't wipe scriptWitness 18:53 < sipa> unless sigdata.witness is false 18:57 -!- aferreira44 [~andre@2001:1284:f013:8b30:d482:b4e6:24f7:b9c3] has quit [Ping timeout: 260 seconds] 19:01 < achow101> what about scriptSig? 19:01 < sipa> there are a couple things 19:02 < sipa> ideally just these functions don't get called at all for things that are already signed 19:02 < sipa> the caller has the best context to determine that, i think 19:02 < sipa> caller = wallet, rpc, psbt, ... 19:03 < achow101> not necessarily 19:03 < sipa> e.g. if you lack amount information, a VerifyScript will fail for every witness 19:03 < sipa> that doesn't mean you should wipe it 19:03 < achow101> for these non-wallet inputs, no context knows until it runs through the verifier 19:04 < sipa> ok, setting aside the question of deciding whether an input is fully signed or not 19:04 < sipa> if you somehow think it's not yet fully signed, so try to sign yourself, and fail... there is no point in wiping anything at all 19:05 < achow101> right 19:06 < sipa> and i think that's a pretty simple change 19:07 < sipa> https://explorer.bc-2.jp/tx/da68fd6ccdfd0359b94012dfa613f69c934a99a84a90e53cf01413ca832bb1b6?expand 19:08 < achow101> that might be a simple change, but I think a better/longer term solution is to overhaul the signing to be more psbt like 19:09 < achow101> so it puts things inside of SignatureData and only attempts to create a scriptSig and scriptWitness when trying to finalize 19:09 < sipa> agree 19:09 < achow101> and those shouldn't be part of the SignatureData 19:09 -!- aferreira44 [~andre@2001:1284:f013:c3de:2150:4a84:6f92:91d8] has joined #bitcoin-core-dev 19:09 < sipa> part of the complexity is the compatibility with the old raw transaction behavior where we want to be able to go from tx -> sigdata 19:10 < sipa> but we don't need that functionality for new script signing functionality 19:11 < achow101> I really just want to deprecate and remove signrawtransaction* 19:11 < achow101> but I think people still use it 19:11 < sipa> but we probably also want a function that can detect invalid scriptSig/witness data, so it can ignore it 19:11 < sipa> otherwise it'd just be: you already have witness/scriptSig -> no touch 19:31 < sipa> https://explorer.bc-2.jp/tx/dda4cb9290415952d93f52518df978d45ae1710e60e711e6786926e99d305ef9?expand <- script path spend 19:33 < sipa> made using sendtoaddress :) 19:40 < achow101> sipa: miniscript? 19:40 < achow101> or taproot? 19:41 < sipa> taproit 19:41 < sipa> *taproot 19:42 < achow101> nice 19:42 < sipa> branch needs a lot of cleaning up, but it does something now :) 20:45 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 20:45 -!- shesek [~shesek@164.90.217.137] has joined #bitcoin-core-dev 20:45 -!- shesek [~shesek@164.90.217.137] has quit [Changing host] 20:45 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 21:09 -!- pox [~pox@gateway/tor-sasl/pox] has joined #bitcoin-core-dev 21:11 -!- flag [~flag@net-93-66-71-159.cust.vodafonedsl.it] has quit [Remote host closed the connection] 21:17 -!- flag [~flag@net-5-95-187-105.cust.vodafonedsl.it] has joined #bitcoin-core-dev 21:36 -!- aferreira44 [~andre@2001:1284:f013:c3de:2150:4a84:6f92:91d8] has quit [Ping timeout: 264 seconds] 21:42 -!- aferreira44 [~andre@2001:1284:f013:c3de:2150:4a84:6f92:91d8] has joined #bitcoin-core-dev 21:47 -!- shafiunmiraz0 [~shafiunmi@103.220.205.190] has joined #bitcoin-core-dev 21:47 -!- Patriot [ae8a1cc6@174.138.28.198] has joined #bitcoin-core-dev 21:50 -!- Patriot [ae8a1cc6@174.138.28.198] has quit [Client Quit] 21:50 -!- pox [~pox@gateway/tor-sasl/pox] has quit [Remote host closed the connection] 21:50 -!- shafiunmiraz0 [~shafiunmi@103.220.205.190] has quit [Client Quit] 21:51 -!- pox [~pox@gateway/tor-sasl/pox] has joined #bitcoin-core-dev 22:00 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 22:00 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 22:21 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Remote host closed the connection] 22:22 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 22:40 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 268 seconds] 22:46 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has quit [Ping timeout: 272 seconds] 22:48 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has joined #bitcoin-core-dev 23:05 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 23:13 -!- pox [~pox@gateway/tor-sasl/pox] has quit [Remote host closed the connection] 23:14 -!- jeremyrubin [~jr@024-176-247-182.res.spectrum.com] has quit [Ping timeout: 276 seconds] 23:14 -!- pox [~pox@gateway/tor-sasl/pox] has joined #bitcoin-core-dev 23:35 -!- aferreira44 [~andre@2001:1284:f013:c3de:2150:4a84:6f92:91d8] has quit [Ping timeout: 260 seconds] 23:36 -!- brg444 [uid207215@gateway/web/irccloud.com/x-hpmuwukpfclzfzft] has quit [Quit: Connection closed for inactivity] 23:47 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 268 seconds] --- Log closed Sat Feb 27 00:00:41 2021