--- Log opened Mon Mar 08 00:00:51 2021 00:04 < S3RK> you're right. I tried to remount disk and then Deserialize or I/O error - CAutoFile::read: fread failed: unspecified iostream_category error at FlatFilePos(nFile=2479, nPos=69638818) 00:04 < S3RK> Corrupted block database detected. 00:07 < vasild> wumpus: Marco posted a link some time ago to an updated gpg key here: http://www.erisian.com.au/bitcoin-core-dev/log-2021-02-18.html#l-283 00:07 < vasild> https://keys.openpgp.org/vks/v1/by-fingerprint/B8B3F1C0E58C15DB6A81D30C3648A882F4316B9B 00:08 < vasild> MarcoFalke: wrt fuzzing, right, that is my understanding too. And if a test is changed (very little) to just do ConsumeBool() before any other consumes, that would "invalidate" the fuzz seeds, I guess. 00:14 < wumpus> vasild: thanks! 00:36 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 00:45 -!- b10c [~b10c@2a01:4f8:200:1036::1] has joined #bitcoin-core-dev 01:03 -!- shorty [b09e4084@static-176-158-64-132.ftth.abo.bbox.fr] has joined #bitcoin-core-dev 01:04 -!- shorty [b09e4084@static-176-158-64-132.ftth.abo.bbox.fr] has quit [Client Quit] 01:06 -!- devs [51a74997@151.81-167-73.customer.lyse.net] has joined #bitcoin-core-dev 01:11 -!- devs [51a74997@151.81-167-73.customer.lyse.net] has quit [Quit: Ping timeout (120 seconds)] 01:11 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Ping timeout: 264 seconds] 01:13 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev 01:27 -!- wasserstein [541ed669@84-30-214-105.cable.dynamic.v4.ziggo.nl] has joined #bitcoin-core-dev 01:30 -!- wasserstein [541ed669@84-30-214-105.cable.dynamic.v4.ziggo.nl] has left #bitcoin-core-dev [] 01:36 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 01:38 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 01:40 -!- pox [~pox@gateway/tor-sasl/pox] has joined #bitcoin-core-dev 02:26 -!- p0x [~pox@gateway/tor-sasl/pox] has joined #bitcoin-core-dev 02:27 -!- pox [~pox@gateway/tor-sasl/pox] has quit [Remote host closed the connection] 02:29 -!- d [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev 02:29 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection] 02:29 -!- d is now known as Guest69706 02:31 -!- pox [~pox@gateway/tor-sasl/pox] has joined #bitcoin-core-dev 02:31 -!- p0x [~pox@gateway/tor-sasl/pox] has quit [Ping timeout: 268 seconds] 02:42 -!- davec_ [~davec@072-183-054-196.res.spectrum.com] has quit [Read error: Connection reset by peer] 02:47 -!- davec [~davec@072-183-054-196.res.spectrum.com] has joined #bitcoin-core-dev 02:49 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 02:51 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 02:53 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [] 02:54 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 276 seconds] 03:00 -!- openoms [~quassel@cpc115064-stok20-2-0-cust91.1-4.cable.virginm.net] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 03:01 -!- openoms [~quassel@91.132.136.76] has joined #bitcoin-core-dev 03:04 -!- jonatack [~jon@37.166.102.70] has joined #bitcoin-core-dev 03:13 -!- pox [~pox@gateway/tor-sasl/pox] has quit [Quit: pox] 03:15 -!- pox [~pox@gateway/tor-sasl/pox] has joined #bitcoin-core-dev 03:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:17 < bitcoin-git> [bitcoin] vasild opened pull request #21387: fuzz: test the I2P Session public interface (master...i2p_tests) https://github.com/bitcoin/bitcoin/pull/21387 03:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:18 -!- Agustin59Aufderh [~Agustin59@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev 03:28 -!- brunog [bbb72bc8@187.183.43.200] has joined #bitcoin-core-dev 03:38 -!- whatstheplan [ac3aec4f@172.58.236.79] has joined #bitcoin-core-dev 03:55 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 04:02 -!- Agustin59Aufderh [~Agustin59@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 245 seconds] 04:02 -!- jungly [~jungly@host-87-1-193-155.retail.telecomitalia.it] has quit [Ping timeout: 264 seconds] 04:12 -!- meshcollider [meshcollid@gateway/shell/ircnow/x-jljxbfujiusanifg] has quit [Remote host closed the connection] 04:15 -!- Guyver2__ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 04:17 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 264 seconds] 04:23 -!- [LE] [~LE]@217.146.82.202] has quit [Remote host closed the connection] 04:26 -!- ishaqm [~ishaqm@79-66-4-138.dynamic.dsl.as9105.com] has joined #bitcoin-core-dev 04:34 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 04:37 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 264 seconds] 04:38 -!- Suigintou [~Suigintou@178.239.168.171] has joined #bitcoin-core-dev 04:56 -!- jtimon [~quassel@90.166.158.146.dynamic.jazztel.es] has joined #bitcoin-core-dev 05:19 < MarcoFalke> wumpus: my key is on https://keys.openpgp.org/search?q=falke.marco%40gmail.com 05:22 < MarcoFalke> vasild: integral types smaller than 2^64 are consumed from the end. Byte vectors from the beginning. 05:22 < MarcoFalke> So it could happen that adding a ConsumeBool doesn't invalidate some seeds 05:23 < vasild> I see 05:23 < MarcoFalke> Currently it looks like we are hovering around 64%-65% total coverage. Decreasing when the code changes, increasing when the fuzz engine caught up 05:25 < vasild> I wonder if I should try to create a seed _manually_, because it is known that a reply on the socket like "foobar RESULT=OK baz" would trigger more coverage 05:25 < vasild> but waiting for the fuzzed to discover this may take a looong time 05:25 < vasild> s/fuzzed/fuzzer/ 05:27 -!- meshcollider [meshcollid@gateway/shell/ircnow/x-ddmqaipvovndqpkj] has joined #bitcoin-core-dev 05:31 < darosior> vasild: manually generating a corpus is generally a pretty good idea (can't think of a scenario where it would not?), so that the fuzzing engine can start from this to discover new code paths 05:32 < vasild> alright, will try that 05:43 -!- whatstheplan [ac3aec4f@172.58.236.79] has quit [Quit: Connection closed] 05:43 -!- Guest69706 [~davterra@gateway/tor-sasl/tralfaz] has quit [Quit: Leaving] 05:47 -!- Guyver2__ is now known as Guyver2 05:59 < MarcoFalke> You can also try to embedd a dictionary in the source code (The message type fuzzers do that with the message type) 06:00 < MarcoFalke> If the replies are "OK" or "NOT_OK", you could generate them as: reply = ConsumeBool()? Pick({"OK", "NOT_OK"}) : ConsumeString() 06:01 -!- jungly [~jungly@host-87-1-193-155.retail.telecomitalia.it] has joined #bitcoin-core-dev 06:02 -!- eoin [6d4f18ef@109.79.24.239] has joined #bitcoin-core-dev 06:12 < MarcoFalke> Ideally the fuzz engine would figure out all of this by itself, but we are not there yet 06:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:20 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #21388: scripted-diff: [doc] Rename fuzz seed_dir to corpus_dir (master...2103-docInputDir) https://github.com/bitcoin/bitcoin/pull/21388 06:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:55 -!- roconnor [~roconnor@host-104-157-194-235.dyn.295.ca] has joined #bitcoin-core-dev 06:59 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 268 seconds] 07:17 -!- dacev [4e9d1848@78.157.24.72] has joined #bitcoin-core-dev 07:33 -!- sakura [176503d3@23.101.3.211] has joined #bitcoin-core-dev 07:35 -!- sakura [176503d3@23.101.3.211] has quit [Client Quit] 07:36 -!- jespada [~jespada@90.254.243.187] has quit [Ping timeout: 245 seconds] 07:38 -!- jespada [~jespada@90.254.243.187] has joined #bitcoin-core-dev 07:49 -!- dimitaracev35 [4e9d1848@78.157.24.72] has joined #bitcoin-core-dev 07:51 < Norrin> dimitaracev35 i think here would be better for that 07:52 < dimitaracev35> Ah, already asked that question here but chat seems to be quiet atm 07:52 < dimitaracev35> thanks anyways! 07:53 < Norrin> dimitaracev35 that's weird. it's not in my scrollback 07:56 < dimitaracev35> it was under a different username since I'm quite new to irc and had to make an account with weechat 07:59 -!- dacev [4e9d1848@78.157.24.72] has quit [Quit: Connection closed] 08:01 -!- eoin [6d4f18ef@109.79.24.239] has quit [Quit: Connection closed] 08:12 -!- eoin [6d4f18ef@109.79.24.239] has joined #bitcoin-core-dev 08:16 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 08:16 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 08:17 -!- JokerAscensionEx [~egp_@2.95.74.168] has quit [Remote host closed the connection] 08:34 -!- xpto [599a28fa@a89-154-40-250.cpe.netcabo.pt] has joined #bitcoin-core-dev 08:34 -!- eoin [6d4f18ef@109.79.24.239] has quit [Quit: Connection closed] 08:36 -!- xpto [599a28fa@a89-154-40-250.cpe.netcabo.pt] has quit [Client Quit] 08:37 -!- juldou [05975233@5.151.82.51] has joined #bitcoin-core-dev 08:53 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 09:05 -!- juldou [05975233@5.151.82.51] has quit [Quit: Connection closed] 09:34 -!- roconnor [~roconnor@host-104-157-194-235.dyn.295.ca] has quit [Ping timeout: 264 seconds] 09:36 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 09:44 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 09:47 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 246 seconds] 10:27 -!- dimitaracev35 [4e9d1848@78.157.24.72] has quit [Quit: Connection closed] 10:38 -!- kabaum [~kabaum@h-13-35.A163.priv.bahnhof.se] has quit [Ping timeout: 265 seconds] 10:52 -!- jungly [~jungly@host-87-1-193-155.retail.telecomitalia.it] has quit [Ping timeout: 260 seconds] 10:52 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 10:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:54 < bitcoin-git> [gui] MarcoFalke merged pull request #233: qt test: Don't bind to regtest port (master...qttest-other-port) https://github.com/bitcoin-core/gui/pull/233 10:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:54 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a22653a636e8...2067f9e5e891 10:54 < bitcoin-git> bitcoin/master e21276a Andrew Chow: qt test: Don't bind to regtest port 10:55 < bitcoin-git> bitcoin/master 2067f9e MarcoFalke: Merge bitcoin-core/gui#233: qt test: Don't bind to regtest port 10:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:57 < phantomcircuit> sipa_, hi it's march 8th 11:01 < sipa_> phantomcircuit: p2p meeting is tomorrow 1pm pacific, i believe 11:03 < phantomcircuit> ah 11:03 < phantomcircuit> ok 11:06 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 11:08 -!- stortz [b1982779@177.152.39.121] has joined #bitcoin-core-dev 11:18 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 264 seconds] 11:20 < jnewbery> next p2p meeting is tomorrow (March 9) at 21:00 UTC. Feel free to add suggested topics here: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings 11:21 -!- kabaum [~kabaum@h-13-35.A163.priv.bahnhof.se] has joined #bitcoin-core-dev 11:26 < amiti> wumpus: heads up that the Bitcoin-dev google calendar event for p2p meeting hasn't been updated for this week, but is updated after that 11:26 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 264 seconds] 11:30 -!- ishaqm [~ishaqm@79-66-4-138.dynamic.dsl.as9105.com] has quit [Remote host closed the connection] 11:30 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 11:37 -!- smctwo [~smctwo@86.98.5.100] has joined #bitcoin-core-dev 11:56 < wumpus> amiti: strange, thanks for letting me know, will take a look 11:59 < wumpus> should be corrected now 12:04 -!- stortz [b1982779@177.152.39.121] has quit [Quit: Connection closed] 12:06 -!- gandagorn [~gandagorn@5.180.62.127] has joined #bitcoin-core-dev 12:06 -!- gandagorn [~gandagorn@5.180.62.127] has left #bitcoin-core-dev [] 12:08 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:08 < ariard> jnewbery: i guess new p2p meeting hours should be bumped here https://bitcoincore.org/en/meetings/ 12:16 -!- scedastik [~textual@c-68-58-168-96.hsd1.mi.comcast.net] has joined #bitcoin-core-dev 12:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:18 < bitcoin-git> [bitcoin] fjahr opened pull request #21390: test: Test improvements for UTXO set hash tests (master...19145_followup) https://github.com/bitcoin/bitcoin/pull/21390 12:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:20 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 12:21 -!- jungly [~jungly@host-87-1-193-155.retail.telecomitalia.it] has joined #bitcoin-core-dev 12:21 -!- stortz [b1982779@177.152.39.121] has joined #bitcoin-core-dev 12:23 -!- kabaum [~kabaum@h-13-35.A163.priv.bahnhof.se] has quit [Ping timeout: 260 seconds] 12:24 -!- scedastik [~textual@c-68-58-168-96.hsd1.mi.comcast.net] has left #bitcoin-core-dev [] 12:31 -!- harrigan- [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has joined #bitcoin-core-dev 12:31 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 12:33 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Ping timeout: 260 seconds] 12:33 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 12:35 -!- scedastik [~textual@c-68-58-168-96.hsd1.mi.comcast.net] has joined #bitcoin-core-dev 12:36 -!- scedastik [~textual@c-68-58-168-96.hsd1.mi.comcast.net] has left #bitcoin-core-dev [] 12:40 -!- harrigan- [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has quit [Read error: Connection reset by peer] 12:40 -!- kabaum [~kabaum@h-13-35.A163.priv.bahnhof.se] has joined #bitcoin-core-dev 12:41 -!- vangolin [5af3066f@90.243.6.111] has joined #bitcoin-core-dev 12:43 -!- harrigan [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has joined #bitcoin-core-dev 12:46 < wumpus> ariard: jnewbery: https://github.com/bitcoin-core/bitcoincore.org/pull/757 12:49 -!- scedastik [~scedastik@c-68-58-168-96.hsd1.mi.comcast.net] has joined #bitcoin-core-dev 12:50 -!- harrigan- [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev 12:52 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev 12:52 -!- promag_ [~promag@188.250.84.129] has quit [Read error: Connection reset by peer] 12:52 -!- harrigan [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has quit [Ping timeout: 256 seconds] 12:53 -!- promag [~promag@188.250.84.129] has quit [Read error: Connection reset by peer] 12:53 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev 12:55 -!- vangolin29 [5af3066f@90.243.6.111] has joined #bitcoin-core-dev 12:59 -!- vangolin29 [5af3066f@90.243.6.111] has quit [Client Quit] 13:02 -!- smctwo [~smctwo@86.98.5.100] has quit [Remote host closed the connection] 13:02 -!- smctwo [~smctwo@86.98.5.100] has joined #bitcoin-core-dev 13:07 -!- smctwo [~smctwo@86.98.5.100] has quit [Ping timeout: 260 seconds] 13:07 -!- LRSN [d41dd2e6@212.29.210.230] has joined #bitcoin-core-dev 13:17 -!- taky [~taky@136.144.35.38] has joined #bitcoin-core-dev 13:18 -!- brunog [bbb72bc8@187.183.43.200] has quit [Quit: Connection closed] 13:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:18 < bitcoin-git> [bitcoin] dongcarl opened pull request #21391: [Bundle 5/n] Prune g_chainman usage in RPC modules (master...2020-10-libbitcoinruntime-v7) https://github.com/bitcoin/bitcoin/pull/21391 13:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:18 -!- vangolin [5af3066f@90.243.6.111] has quit [Quit: Connection closed] 13:23 -!- jonatack_ [~jon@37.166.102.70] has joined #bitcoin-core-dev 13:24 -!- jonatack [~jon@37.166.102.70] has quit [Read error: Connection reset by peer] 13:27 -!- Suigintou [~Suigintou@178.239.168.171] has quit [Remote host closed the connection] 13:27 -!- taky [~taky@136.144.35.38] has quit [Changing host] 13:27 -!- taky [~taky@unaffiliated/taky] has joined #bitcoin-core-dev 13:36 -!- stortz [b1982779@177.152.39.121] has quit [Quit: Connection closed] 13:38 -!- FrontSevens [~FrontSeve@217.146.82.202] has joined #bitcoin-core-dev 13:41 -!- jungly [~jungly@host-87-1-193-155.retail.telecomitalia.it] has quit [Ping timeout: 265 seconds] 13:41 < ariard> wumpus: thank 13:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:43 < bitcoin-git> [bitcoin] meshcollider pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/2067f9e5e891...a8b0892b743b 13:43 < bitcoin-git> bitcoin/master 51e2cd3 Andrew Chow: Have CalculateMaximumSignedTxSize also compute tx weight 13:43 < bitcoin-git> bitcoin/master 3e69939 Andrew Chow: Fail if maximum weight is too large 13:43 < bitcoin-git> bitcoin/master 48a0319 Andrew Chow: Add a test that selects too large if BnB is used 13:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:43 < bitcoin-git> [bitcoin] meshcollider merged pull request #20536: wallet: Error with "Transaction too large" if the funded tx will end up being too large after signing (master...fundtx-error-large-tx) https://github.com/bitcoin/bitcoin/pull/20536 13:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:44 -!- daveg [~biff@cpe-174-104-42-57.neo.res.rr.com] has joined #bitcoin-core-dev 13:46 -!- jungly [~jungly@host-87-1-193-155.retail.telecomitalia.it] has joined #bitcoin-core-dev 13:47 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 13:49 -!- jonatack__ [~jon@37.167.56.19] has joined #bitcoin-core-dev 13:51 < jonatack__> exit 13:52 -!- jonatack__ [~jon@37.167.56.19] has quit [Client Quit] 13:52 < luke-jr> O.o 13:52 -!- roconnor [~roconnor@host-45-58-192-182.dyn.295.ca] has joined #bitcoin-core-dev 13:52 -!- jonatack [~jon@37.167.56.19] has joined #bitcoin-core-dev 13:52 < jonatack> (oops) 13:52 -!- jonatack_ [~jon@37.166.102.70] has quit [Ping timeout: 260 seconds] 13:54 -!- eric_rox [49e4e209@c-73-228-226-9.hsd1.mn.comcast.net] has joined #bitcoin-core-dev 14:07 -!- jonatack [~jon@37.167.56.19] has quit [Ping timeout: 245 seconds] 14:07 -!- eric_rox [49e4e209@c-73-228-226-9.hsd1.mn.comcast.net] has quit [Quit: Connection closed] 14:08 -!- jeremyrubin [~jr@024-176-247-182.res.spectrum.com] has quit [Ping timeout: 245 seconds] 14:09 -!- jeremyrubin [~jr@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev 14:10 -!- daveg [~biff@cpe-174-104-42-57.neo.res.rr.com] has quit [Changing host] 14:10 -!- daveg [~biff@unaffiliated/daveg] has joined #bitcoin-core-dev 14:17 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Quit: jb55] 14:18 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 14:25 -!- jungly [~jungly@host-87-1-193-155.retail.telecomitalia.it] has quit [Ping timeout: 260 seconds] 14:27 -!- jungly [~jungly@host-87-1-193-155.retail.telecomitalia.it] has joined #bitcoin-core-dev 14:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:31 < bitcoin-git> [bitcoin] achow101 opened pull request #21392: Implement BIP 8 based Speedy Trial activation (master...bip8-speedy-trial) https://github.com/bitcoin/bitcoin/pull/21392 14:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:33 -!- taky [~taky@unaffiliated/taky] has quit [Ping timeout: 260 seconds] 14:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:34 < bitcoin-git> [bitcoin] achow101 opened pull request #21393: BIP 341: Add Speedy Trial activation parameters (master...taproot-speedy-trial) https://github.com/bitcoin/bitcoin/pull/21393 14:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:49 -!- scedastik [~scedastik@c-68-58-168-96.hsd1.mi.comcast.net] has quit [Quit: scedastik] 14:51 -!- JokerAscensionEx [~egp_@2.95.74.168] has joined #bitcoin-core-dev 15:13 -!- taky [~taky@64.64.117.140] has joined #bitcoin-core-dev 15:13 -!- taky [~taky@64.64.117.140] has quit [Changing host] 15:13 -!- taky [~taky@unaffiliated/taky] has joined #bitcoin-core-dev 15:21 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 268 seconds] 15:27 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 15:46 -!- jungly [~jungly@host-87-1-193-155.retail.telecomitalia.it] has quit [Ping timeout: 264 seconds] 16:31 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 16:31 -!- jasonzhouu [~jasonzhou@112.10.159.239] has quit [Read error: Connection reset by peer] 16:31 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 16:53 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 240 seconds] 17:01 < sipa_> anyone have i2p nodes to connect to? 17:05 < aj> sipa_: sed -i -e 's/AbstractThresholdConditionChecker/ThresholdConditionChecker/g' $(git grep -l AbstractThresholdConditionChecker src/) 17:05 < aj> gah 17:05 < aj> sipa_: https://bpa.st/OXKQ 17:05 < sipa_> i... don't think that works 17:05 < sipa_> ah, that's better 17:06 < sipa_> i hereby offer hnbbyjpxx54623l555sta7pocy3se4sdgmuebi5k6reesz5rjp6q.b32.i2p (mainnet) 17:53 -!- theChief [~Mohamed@121.6.182.56] has joined #bitcoin-core-dev 18:05 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 18:09 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 265 seconds] 18:10 -!- grubles [~unknown@96.30.199.172] has joined #bitcoin-core-dev 18:10 -!- grubles [~unknown@96.30.199.172] has quit [Changing host] 18:10 -!- grubles [~unknown@unaffiliated/grubles] has joined #bitcoin-core-dev 18:19 -!- LRSN [d41dd2e6@212.29.210.230] has quit [Ping timeout: 240 seconds] 18:26 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 18:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:28 < bitcoin-git> [bitcoin] amitiuttarwar opened pull request #21394: [doc] Improve comment about protected peers (master...2021-03-doc) https://github.com/bitcoin/bitcoin/pull/21394 18:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:28 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 260 seconds] 18:41 -!- az0re [~az0re@gateway/tor-sasl/az0re] has joined #bitcoin-core-dev 18:45 < aj> achow101: rebased the fuzzer to pull in most of the rename and the threshold part 18:46 < achow101> aj: right now I'm trying to parameterize the period in the same way 18:46 < aj> achow101: i'm not sure that's a good idea -- different periods make the Warning thing in validation less useful 18:47 < aj> achow101: (for different thresholds, the RuleChangeActivatinThreshold just needs to be <= to them) 18:47 < achow101> it's already less useful because different thresholds 18:47 < achow101> mostly doing it for code organization reasons since a threshold doesn't make sense without what the maximum is 18:48 < achow101> not necessarily allowing for different thresholds 18:48 -!- jr_ [~jr@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev 18:48 -!- jeremyrubin [~jr@024-176-247-182.res.spectrum.com] has quit [Ping timeout: 256 seconds] 18:49 -!- jr_ [~jr@024-176-247-182.res.spectrum.com] has quit [Client Quit] 18:49 < achow101> what I'm also working towards is having all the parameters set in a constructor for VBitsDeployment since I'm not convinced we don't have an initialized variable in a (test) deployment somewhere 18:49 -!- jeremyrubin [~jr@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev 18:49 < achow101> *uninitialized 18:52 -!- stortz [b1982779@177.152.39.121] has joined #bitcoin-core-dev 18:52 < aj> hmm 18:54 < aj> well, the easy solution is add a check in the unit tests that the deployment periods all match the params period, and the dep thresholds are all >= the params rulechangethreshold 19:06 -!- stortz [b1982779@177.152.39.121] has quit [Quit: Connection closed] 19:06 -!- virtu [~virtu@gateway/tor-sasl/virtu] has quit [Remote host closed the connection] 19:06 -!- virtu [~virtu@gateway/tor-sasl/virtu] has joined #bitcoin-core-dev 19:07 -!- az0re [~az0re@gateway/tor-sasl/az0re] has quit [Quit: Leaving] 19:10 < achow101> is having a fixed rule change threshold necessary? It could just search for the minimum threshold of all current deployments 19:15 < luke-jr> achow101: I'm guessing it is (or was) for the warnings 19:20 < aj> achow101: yes -- you still want warnings even if there are no current deployments (you're warning about things introduced in future releases of the code) 19:21 < achow101> luke-jr: it was for all activations, in 21392 it is just for the warnings 19:21 < achow101> aj: we always have testdummy, so when there are no active deployments, it uses testdummy's threshold 19:21 < luke-jr> hmm 19:26 < aj> achow101: seems nuts to me, we want a global "what's the lowest threshold any future deployment might have", why wouldn't we just have that as a field? 19:26 < achow101> true. we should probably lower it farther though. to 75% maybe 19:27 < aj> yep 19:28 < jeremyrubin> I think it probably makes sense to do a lower threshold -- anything over 0 probably suggests some sort of proposed rule change? 19:28 < jeremyrubin> We still warn any unknown vbit right? 19:29 < achow101> too low and we warn on all the asicboost crap 19:29 < aj> jeremyrubin: the warning is "unknown new rules activated (versionbit X)" 19:29 < aj> achow101: https://github.com/bitcoin/bitcoin/pull/21380/commits/6bea865c8e2c09150b1ebf9abce5d9684f6441f9#diff-f0697aa70d82dc886876d2b62b6c4d1c27d584c2001e1bf605f74d28a06b4d8dR250-R253 19:30 < luke-jr> I have a PR open to restore the unknown bit warnings in a asicboost-friendly way btw 19:31 < luke-jr> #15861 19:31 < gribble> https://github.com/bitcoin/bitcoin/issues/15861 | Restore warning for individual unknown version bits, as well as unknown version schemas by luke-jr · Pull Request #15861 · bitcoin/bitcoin · GitHub 19:32 < jeremyrubin> tbh I think that w.r.t. the threshold, the periods are probably of more concern? 19:32 < achow101> aj: oh nice. nit: name it m_threshold (something something style guide) 19:49 -!- biff_ [~biff@cpe-174-104-42-57.neo.res.rr.com] has joined #bitcoin-core-dev 19:50 -!- cltrbreak_MAD2 [~ctrlbreak@159.2.165.130] has joined #bitcoin-core-dev 19:50 -!- criley [~criley@c-73-224-125-58.hsd1.fl.comcast.net] has joined #bitcoin-core-dev 19:50 -!- biff_ [~biff@cpe-174-104-42-57.neo.res.rr.com] has quit [Client Quit] 19:50 -!- taky_ [~taky@64.64.117.140] has joined #bitcoin-core-dev 19:50 -!- TheRec_ [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-dev 19:50 -!- TheRec_ [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Changing host] 19:50 -!- TheRec_ [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 19:50 -!- biff_ [~biff@cpe-174-104-42-57.neo.res.rr.com] has joined #bitcoin-core-dev 19:50 -!- wumpus2 [~ircclient@pdpc/supporter/professional/wumpus] has joined #bitcoin-core-dev 19:50 -!- ossifrage_ [~ossifrage@unaffiliated/ossifrage] has joined #bitcoin-core-dev 19:51 -!- rockhouse2 [~rockhouse@unaffiliated/rockhouse] has joined #bitcoin-core-dev 19:51 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Disconnected by services] 19:51 -!- treyzania_ [~treyzania@paphos.tr3y.io] has joined #bitcoin-core-dev 19:51 -!- biff_ [~biff@cpe-174-104-42-57.neo.res.rr.com] has quit [Client Quit] 19:52 -!- jnewbery_ [~john@164.90.178.190] has joined #bitcoin-core-dev 19:52 -!- root [~echo@139.180.133.130] has joined #bitcoin-core-dev 19:52 -!- root is now known as Guest86647 19:53 -!- dlb76_ [~dlb76@88.99.80.63] has joined #bitcoin-core-dev 19:53 -!- daveg [~biff@unaffiliated/daveg] has quit [Killed (beckett.freenode.net (Nickname regained by services))] 19:53 -!- tim [~real_or_r@173.249.7.254] has joined #bitcoin-core-dev 19:54 -!- tim is now known as Guest52984 19:54 -!- pinheadmz_ [~pinheadmz@hns-contributor.dev] has joined #bitcoin-core-dev 19:54 -!- andytosh1 [~apoelstra@unaffiliated/andytoshi] has joined #bitcoin-core-dev 19:54 -!- Artea_ [~Lufia@artea.com.pt] has joined #bitcoin-core-dev 19:54 -!- hirish [~hirish@ip85.ip-137-74-20.eu] has joined #bitcoin-core-dev 19:54 -!- daveg [~biff@unaffiliated/daveg] has joined #bitcoin-core-dev 19:54 -!- aj_ [aj@139.162.42.226] has joined #bitcoin-core-dev 19:55 -!- livestradamus_ [~quassel@95.179.151.101] has joined #bitcoin-core-dev 19:55 -!- jtimon_ [~quassel@90.166.158.146.dynamic.jazztel.es] has joined #bitcoin-core-dev 19:56 -!- berndj-blackout [~berndj@ns2.linksynergy.co.za] has joined #bitcoin-core-dev 19:56 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev 19:56 -!- einyx_ [einyx@fsf/member/einyx] has joined #bitcoin-core-dev 19:58 -!- niska` [~niska@static.38.6.217.95.clients.your-server.de] has joined #bitcoin-core-dev 19:59 -!- meshcoll- [meshcollid@gateway/shell/ircnow/x-fxgnvsfciueukqqj] has joined #bitcoin-core-dev 19:59 -!- Netsplit *.net <-> *.split quits: wumpus, lio17, JokerAscensionEx, andytoshi, jnewbery, berndj, criley_, niska, treyzania, so, (+24 more, use /NETSPLIT to show all of them) 19:59 -!- berndj-blackout is now known as berndj 19:59 -!- rockhouse2 is now known as rockhouse 20:00 -!- Netsplit over, joins: lio17 20:00 -!- Netsplit over, joins: thrasher` 20:00 -!- Netsplit over, joins: pingwindyktator 20:00 -!- Netsplit over, joins: adiabat_ 20:01 -!- Netsplit over, joins: nickler, esotericnonsense 20:02 -!- Netsplit over, joins: JokerAscensionEx 20:06 -!- aj_ is now known as aj 20:06 < jeremyrubin> Do we nuke all the validation caches after a soft fork activates? 20:07 < jeremyrubin> E.g., the scriptcache? 20:08 -!- ossifrage_ is now known as ossifrage 20:10 < jeremyrubin> Ah we commit to the validation caches for those 20:10 -!- so [~so@unaffiliated/so] has joined #bitcoin-core-dev 20:10 < jeremyrubin> *validation flags 20:15 -!- niftynei [~niftynei@104.131.77.55] has joined #bitcoin-core-dev 20:19 < sipa_> yup 20:40 -!- theChief [~Mohamed@121.6.182.56] has quit [] 20:46 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 20:47 -!- shesek [~shesek@164.90.217.137] has joined #bitcoin-core-dev 20:47 -!- shesek [~shesek@164.90.217.137] has quit [Changing host] 20:47 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 21:13 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Ping timeout: 272 seconds] 21:13 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev 21:17 -!- BGL [~twenty@75-149-171-58-Washington.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 21:26 -!- gleb [~gleb@178.150.137.228] has joined #bitcoin-core-dev 21:36 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 268 seconds] 21:38 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 21:46 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [] 22:04 -!- jtimon_ [~quassel@90.166.158.146.dynamic.jazztel.es] has quit [Ping timeout: 260 seconds] 22:06 -!- smctwo [~smctwo@94.204.225.231] has joined #bitcoin-core-dev 22:08 -!- leonardo_ [uid489830@gateway/web/irccloud.com/x-jmrvfqqpvornuvwi] has quit [Quit: Connection closed for inactivity] 22:10 -!- smctwo [~smctwo@94.204.225.231] has quit [Ping timeout: 264 seconds] 22:21 -!- jesseposner [~jp@2601:645:200:162f:3167:e7cf:cd0a:198e] has quit [Quit: Textual IRC Client: www.textualapp.com] 22:43 -!- jesseposner [~jp@2601:645:200:162f:d2d:bec5:dbe:1d75] has joined #bitcoin-core-dev 22:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:55 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a8b0892b743b...6c156e49cb7a 22:55 < bitcoin-git> bitcoin/master fa4e088 MarcoFalke: wallet: Mark replaced tx to not be in the mempool anymore 22:55 < bitcoin-git> bitcoin/master 6c156e4 MarcoFalke: Merge #18842: wallet: Mark replaced tx to not be in the mempool anymore 22:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:55 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18842: wallet: Mark replaced tx to not be in the mempool anymore (master...2004-walletBumpFeeReplacedTxNoMempool) https://github.com/bitcoin/bitcoin/pull/18842 22:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:05 -!- jeremyrubin [~jr@024-176-247-182.res.spectrum.com] has quit [Ping timeout: 264 seconds] 23:21 -!- jesseposner [~jp@2601:645:200:162f:d2d:bec5:dbe:1d75] has quit [Quit: Textual IRC Client: www.textualapp.com] 23:29 -!- jonatack [~jon@37.166.110.136] has joined #bitcoin-core-dev 23:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:34 < bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/6c156e49cb7a...738fc4a59517 23:34 < bitcoin-git> bitcoin/master bf24774 Hennadii Stepanov: build, qt: Refactor internal _BITCOIN_QT_CHECK_STATIC_PLUGINS macro 23:34 < bitcoin-git> bitcoin/master 6203457 Hennadii Stepanov: build, refactor: Rename internal _BITCOIN_QT_FIND_STATIC_PLUGINS macro 23:34 < bitcoin-git> bitcoin/master 57b6522 Hennadii Stepanov: build, qt: Make Qt static libs check regardless of plugindir 23:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:35 < bitcoin-git> [bitcoin] fanquake merged pull request #21363: build, qt: Improve Qt static plugins/libs check code (master...210304-qt) https://github.com/bitcoin/bitcoin/pull/21363 23:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:40 -!- jesseposner [~jp@2601:645:200:162f:d38:a5c2:980:75b0] has joined #bitcoin-core-dev 23:43 < fanquake> oh no indeed: https://0bin.net/paste/CVaNbQ-c#jnhc392Y+u9CBfbaN+0GIHJ-vI/jLQPHJkMe/CfyAZQ 23:43 < fanquake> Apparently I'm no longer allowed to leave reviewss 23:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:47 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/738fc4a59517...461f0c781e5a 23:47 < bitcoin-git> bitcoin/master 5129b36 Hennadii Stepanov: build: Clean remnants of QTBUG-34748 fix 23:47 < bitcoin-git> bitcoin/master 173ef89 Hennadii Stepanov: build: Small libxcb.mk improvements 23:47 < bitcoin-git> bitcoin/master 461f0c7 fanquake: Merge #21382: build: Clean remnants of QTBUG-34748 fix 23:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:48 < bitcoin-git> [bitcoin] fanquake merged pull request #21382: build: Clean remnants of QTBUG-34748 fix (master...210307-libxcb) https://github.com/bitcoin/bitcoin/pull/21382 23:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:49 -!- jonatack [~jon@37.166.110.136] has quit [Read error: Connection reset by peer] 23:50 -!- jonatack [~jon@37.166.110.136] has joined #bitcoin-core-dev 23:50 -!- daveg [~biff@unaffiliated/daveg] has quit [Quit: Leaving] 23:55 -!- pox [~pox@gateway/tor-sasl/pox] has quit [Quit: pox] 23:56 -!- pox [~pox@gateway/tor-sasl/pox] has joined #bitcoin-core-dev --- Log closed Tue Mar 09 00:00:51 2021