--- Log opened Tue Mar 23 00:00:04 2021 00:02 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Remote host closed the connection] 00:03 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev 00:16 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 00:16 -!- d [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev 00:16 -!- d is now known as Guest59676 00:19 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection] 00:32 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Remote host closed the connection] 00:32 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev 00:35 -!- jungly [~jungly@host-82-59-148-94.retail.telecomitalia.it] has joined #bitcoin-core-dev 00:36 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 268 seconds] 00:37 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 00:45 -!- awesome_doge [~Thunderbi@118-163-120-175.HINET-IP.hinet.net] has quit [Ping timeout: 245 seconds] 00:45 -!- awesome_doge [~Thunderbi@118-163-120-175.HINET-IP.hinet.net] has joined #bitcoin-core-dev 00:52 -!- Guest59676 [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection] 00:52 -!- Guest59676 [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev 01:06 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 01:07 -!- shesek [~shesek@164.90.217.137] has joined #bitcoin-core-dev 01:07 -!- shesek [~shesek@164.90.217.137] has quit [Changing host] 01:07 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 01:14 -!- jespada [~jespada@90.254.243.187] has quit [Ping timeout: 245 seconds] 01:16 -!- jespada [~jespada@90.254.243.187] has joined #bitcoin-core-dev 01:21 -!- jonatack_ [~jon@37.165.23.76] has joined #bitcoin-core-dev 01:23 -!- pox [~pox@gateway/tor-sasl/pox] has quit [Remote host closed the connection] 01:24 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 01:25 -!- pox [~pox@gateway/tor-sasl/pox] has joined #bitcoin-core-dev 01:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:45 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1c3a8579c0a8...d400e672a032 01:45 < bitcoin-git> bitcoin/master 5555446 MarcoFalke: fuzz: Use ConsumeWeakEnum in addrman for service flags 01:45 < bitcoin-git> bitcoin/master d400e67 MarcoFalke: Merge #21487: fuzz: Use ConsumeWeakEnum in addrman for service flags 01:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:46 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #21487: fuzz: Use ConsumeWeakEnum in addrman for service flags (master...2103-fuzzEnumWeak) https://github.com/bitcoin/bitcoin/pull/21487 01:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:01 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d400e672a032...fd2b22bf24d8 02:01 < bitcoin-git> bitcoin/master faa9ef4 MarcoFalke: fuzz: Add tx_pool fuzz targets 02:01 < bitcoin-git> bitcoin/master fd2b22b MarcoFalke: Merge #21142: fuzz: Add tx_pool fuzz target 02:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:02 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #21142: fuzz: Add tx_pool fuzz target (master...2102-fuzzPool) https://github.com/bitcoin/bitcoin/pull/21142 02:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:08 -!- asdlkfjwerpoicvx [~flack@p200300d46f1b8800329cb01f43c29580.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 02:08 -!- awesome_doge [~Thunderbi@118-163-120-175.HINET-IP.hinet.net] has quit [Quit: awesome_doge] 02:09 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Remote host closed the connection] 02:18 -!- jonatack_ [~jon@37.165.23.76] has quit [Quit: jonatack_] 02:23 -!- Kiminuo [~Kiminuo@141.98.103.180] has joined #bitcoin-core-dev 02:25 -!- awesome_doge [~Thunderbi@118-163-120-175.HINET-IP.hinet.net] has joined #bitcoin-core-dev 02:26 -!- awesome_doge [~Thunderbi@118-163-120-175.HINET-IP.hinet.net] has quit [Client Quit] 02:29 -!- awesome_doge [~Thunderbi@118-163-120-175.HINET-IP.hinet.net] has joined #bitcoin-core-dev 02:30 -!- awesome_doge [~Thunderbi@118-163-120-175.HINET-IP.hinet.net] has quit [Remote host closed the connection] 02:38 -!- jonatack [jon@gateway/vpn/airvpn/jonatack] has joined #bitcoin-core-dev 02:53 -!- jonatack [jon@gateway/vpn/airvpn/jonatack] has quit [Ping timeout: 256 seconds] 02:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:59 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #21512: fuzz: Fix tx_pool target to properly fuzz immature outpoints (master...2103-fuzzImmaturePool) https://github.com/bitcoin/bitcoin/pull/21512 03:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:09 -!- awesome_doge [~Thunderbi@118-163-120-175.HINET-IP.hinet.net] has joined #bitcoin-core-dev 03:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:13 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fd2b22bf24d8...55ceaeb8c4a2 03:13 < bitcoin-git> bitcoin/master 1404c57 Sjors Provoost: [doc] Coin: explain that IsSpent() can also mean never existed 03:13 < bitcoin-git> bitcoin/master 55ceaeb MarcoFalke: Merge #18030: doc: Coin::IsSpent() can also mean never existed 03:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:14 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18030: doc: Coin::IsSpent() can also mean never existed (master...2020/01/doc_is_spent) https://github.com/bitcoin/bitcoin/pull/18030 03:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:24 -!- provoostenator_ [~quassel@provoostenator.sprovoost.nl] has quit [Remote host closed the connection] 03:25 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has joined #bitcoin-core-dev 03:26 -!- jonatack [~jon@37.165.23.76] has joined #bitcoin-core-dev 03:31 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 268 seconds] 03:36 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 03:37 -!- mingu [771cbc9d@119.28.188.157] has joined #bitcoin-core-dev 03:38 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has quit [Ping timeout: 272 seconds] 03:38 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has joined #bitcoin-core-dev 03:39 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 03:39 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 04:04 -!- jungly [~jungly@host-82-59-148-94.retail.telecomitalia.it] has quit [Ping timeout: 265 seconds] 04:17 -!- jungly [~jungly@host-82-59-148-94.retail.telecomitalia.it] has joined #bitcoin-core-dev 04:18 -!- Hailie38Olson [~Hailie38O@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev 04:23 -!- Hailie38Olson [~Hailie38O@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 265 seconds] 04:32 -!- jonatack [~jon@37.165.23.76] has quit [Ping timeout: 240 seconds] 04:32 -!- jonatack [~jon@37.165.23.76] has joined #bitcoin-core-dev 04:42 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 04:42 -!- jonatack_ [~jon@37.165.23.76] has joined #bitcoin-core-dev 04:42 -!- jonatack_ [~jon@37.165.23.76] has quit [Read error: Connection reset by peer] 04:42 -!- jonatack [~jon@37.165.23.76] has quit [Read error: Connection reset by peer] 04:43 -!- jonatack_ [~jon@37.165.23.76] has joined #bitcoin-core-dev 04:46 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 04:48 -!- jonatack_ [~jon@37.165.23.76] has quit [Read error: Connection reset by peer] 04:48 -!- jonatack__ [~jon@37.165.23.76] has joined #bitcoin-core-dev 04:52 -!- tronical [~tronical@139.28.218.148] has quit [Remote host closed the connection] 04:52 -!- jungly [~jungly@host-82-59-148-94.retail.telecomitalia.it] has quit [Ping timeout: 265 seconds] 04:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:59 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/55ceaeb8c4a2...3c87dbe95c92 04:59 < bitcoin-git> bitcoin/master 810b131 Hennadii Stepanov: build: Do not build unused CoreWLAN stuff in depends for macOS 04:59 < bitcoin-git> bitcoin/master 3c87dbe fanquake: Merge #21497: build: Do not opt-in unused CoreWLAN stuff in depends for ma... 04:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:00 < bitcoin-git> [bitcoin] fanquake merged pull request #21497: build: Do not opt-in unused CoreWLAN stuff in depends for macOS (master...210321-wlan) https://github.com/bitcoin/bitcoin/pull/21497 05:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:02 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 05:03 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 05:05 -!- stortz [c8b9cbcf@unaffiliated/stortz] has joined #bitcoin-core-dev 05:06 < jnewbery> Hi folks. Reminder that there's a p2p meeting at 21:00 UTC today. Feel free to add requested topics to https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings and update your priorities at https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-Current-Priorities. 05:14 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 05:18 -!- roconnor [~roconnor@host-45-58-230-226.dyn.295.ca] has joined #bitcoin-core-dev 05:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 05:27 -!- jespada [~jespada@90.254.243.187] has quit [Ping timeout: 265 seconds] 05:28 -!- Guest59676 [~davterra@gateway/tor-sasl/tralfaz] has quit [Quit: Leaving] 05:29 -!- jonatack__ [~jon@37.165.23.76] has quit [Ping timeout: 264 seconds] 05:29 -!- jespada [~jespada@90.254.243.187] has joined #bitcoin-core-dev 05:42 -!- awesome_doge [~Thunderbi@118-163-120-175.HINET-IP.hinet.net] has quit [Quit: awesome_doge] 05:43 -!- awesome_doge [~Thunderbi@118-163-120-175.HINET-IP.hinet.net] has joined #bitcoin-core-dev 05:45 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 268 seconds] 05:45 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 05:47 -!- awesome_doge [~Thunderbi@118-163-120-175.HINET-IP.hinet.net] has quit [Client Quit] 05:49 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 05:58 -!- jonatack [~jon@37.165.23.76] has joined #bitcoin-core-dev 06:02 -!- awesome_doge [~Thunderbi@118-163-120-175.HINET-IP.hinet.net] has joined #bitcoin-core-dev 06:23 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 265 seconds] 06:30 -!- shamdin [53d10c64@h83-209-12-100.cust.a3fiber.se] has joined #bitcoin-core-dev 06:31 -!- shamdin [53d10c64@h83-209-12-100.cust.a3fiber.se] has quit [Client Quit] 06:34 -!- kexkey [~kexkey@static-198-54-132-101.cust.tzulo.com] has joined #bitcoin-core-dev 06:43 -!- awesome_doge [~Thunderbi@118-163-120-175.HINET-IP.hinet.net] has quit [Quit: awesome_doge] 06:43 -!- awesome_doge [~Thunderbi@118-163-120-175.HINET-IP.hinet.net] has joined #bitcoin-core-dev 06:44 -!- awesome_doge [~Thunderbi@118-163-120-175.HINET-IP.hinet.net] has quit [Client Quit] 06:44 -!- awesome_doge [~Thunderbi@118-163-120-175.HINET-IP.hinet.net] has joined #bitcoin-core-dev 06:47 -!- Kiminuo [~Kiminuo@141.98.103.180] has quit [Ping timeout: 244 seconds] 06:47 -!- awesome_doge [~Thunderbi@118-163-120-175.HINET-IP.hinet.net] has quit [Client Quit] 06:47 -!- awesome_doge [~Thunderbi@118-163-120-175.HINET-IP.hinet.net] has joined #bitcoin-core-dev 06:49 -!- alct [~alct@139.28.218.148] has joined #bitcoin-core-dev 06:52 -!- awesome_doge [~Thunderbi@118-163-120-175.HINET-IP.hinet.net] has quit [Ping timeout: 272 seconds] 07:03 -!- jungly [~jungly@host-82-59-148-94.retail.telecomitalia.it] has joined #bitcoin-core-dev 07:08 -!- Santiago23Dare [~Santiago2@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev 07:13 -!- Santiago23Dare [~Santiago2@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 256 seconds] 07:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:14 < bitcoin-git> [gui] hebasto opened pull request #254: refactor: Drop redundant setEditTriggers(NoEditTriggers) calls (master...210323-edit) https://github.com/bitcoin-core/gui/pull/254 07:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:18 -!- adiabat_ [~adiabat@63.209.32.102] has quit [Ping timeout: 256 seconds] 07:18 -!- awesome_doge [~Thunderbi@36-225-156-67.dynamic-ip.hinet.net] has joined #bitcoin-core-dev 07:27 -!- awesome_doge [~Thunderbi@36-225-156-67.dynamic-ip.hinet.net] has quit [Ping timeout: 256 seconds] 07:29 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev 07:32 -!- awesome_doge [~Thunderbi@36-225-156-67.dynamic-ip.hinet.net] has joined #bitcoin-core-dev 07:37 -!- awesome_doge [~Thunderbi@36-225-156-67.dynamic-ip.hinet.net] has quit [Ping timeout: 244 seconds] 07:46 -!- jonatack [~jon@37.165.23.76] has quit [Ping timeout: 264 seconds] 07:50 -!- jonatack [~jon@37.165.23.76] has joined #bitcoin-core-dev 07:50 -!- awesome_doge [~Thunderbi@36-225-156-67.dynamic-ip.hinet.net] has joined #bitcoin-core-dev 07:52 -!- jungly [~jungly@host-82-59-148-94.retail.telecomitalia.it] has quit [Ping timeout: 245 seconds] 07:55 -!- jungly [~jungly@host-82-59-148-94.retail.telecomitalia.it] has joined #bitcoin-core-dev 07:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:59 < bitcoin-git> [gui] MarcoFalke merged pull request #248: Fix: For values of "Bytes transferred" and "Bytes/s" with 1000-based prefix names use 1000-based divisor instead of 1024-based (master...binary-prefix) https://github.com/bitcoin-core/gui/pull/248 07:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:00 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3c87dbe95c92...837e59eff6ac 08:00 < bitcoin-git> bitcoin/master d09ebc4 wodry: Fix wrong(1024) divisor for 1000-based prefixes 08:00 < bitcoin-git> bitcoin/master 837e59e MarcoFalke: Merge bitcoin-core/gui#248: Fix: For values of "Bytes transferred" and "By... 08:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:06 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/837e59eff6ac...681c21be9abb 08:06 < bitcoin-git> bitcoin/master fa2b95f MarcoFalke: fuzz: Style fixups 08:06 < bitcoin-git> bitcoin/master fac921f MarcoFalke: fuzz: Fix tx_pool target to properly fuzz immature outpoints 08:06 < bitcoin-git> bitcoin/master 681c21b MarcoFalke: Merge #21512: fuzz: Fix tx_pool target to properly fuzz immature outpoints... 08:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:06 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #21512: fuzz: Fix tx_pool target to properly fuzz immature outpoints (master...2103-fuzzImmaturePool) https://github.com/bitcoin/bitcoin/pull/21512 08:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:12 -!- anonim [334fa15b@51.79.161.91] has joined #bitcoin-core-dev 08:12 -!- anonim [334fa15b@51.79.161.91] has quit [Client Quit] 08:13 -!- adiabat_ [~adiabat@63.209.32.102] has joined #bitcoin-core-dev 08:16 -!- awesome_doge [~Thunderbi@36-225-156-67.dynamic-ip.hinet.net] has quit [Ping timeout: 264 seconds] 08:16 -!- CrazyPython [~crazypyth@98.122.164.118] has joined #bitcoin-core-dev 08:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 08:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:25 < bitcoin-git> [bitcoin] LarryRuane closed pull request #21484: doc: Add release notes for #18335 (master...rel-notes-18335) https://github.com/bitcoin/bitcoin/pull/21484 08:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:31 -!- awesome_doge [~Thunderbi@36-225-156-67.dynamic-ip.hinet.net] has joined #bitcoin-core-dev 08:34 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...] 08:34 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has quit [Quit: Ping timeout (120 seconds)] 08:35 -!- vadorovsky [vadorovsky@gateway/shell/matrix.org/x-xdooblneadwzwpkg] has quit [Ping timeout: 265 seconds] 08:35 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has joined #bitcoin-core-dev 08:35 -!- sturles [~sturles@unaffiliated/sturles] has quit [Ping timeout: 248 seconds] 08:35 -!- victorSN [~victorSN@unaffiliated/victorsn] has quit [Ping timeout: 245 seconds] 08:35 -!- sturles [~sturles@sauron.uio.no] has joined #bitcoin-core-dev 08:35 -!- sturles [~sturles@sauron.uio.no] has quit [Changing host] 08:35 -!- sturles [~sturles@unaffiliated/sturles] has joined #bitcoin-core-dev 08:36 -!- leanbarba[m] [leanbarbam@gateway/shell/matrix.org/x-vtyaziqsvmsoiend] has quit [Ping timeout: 240 seconds] 08:36 -!- suzziminer[m] [suzziminer@gateway/shell/matrix.org/x-ebeorgciihugwjdu] has quit [Ping timeout: 244 seconds] 08:36 -!- SebastianNoelLbk [sebasti49@gateway/shell/matrix.org/x-ssrpubiyhluienqc] has quit [Ping timeout: 244 seconds] 08:36 -!- zeropoint[m] [zeropointi@gateway/shell/matrix.org/x-vdrtvqywhotkhlfc] has quit [Ping timeout: 268 seconds] 08:37 -!- victorSN [~victorSN@unaffiliated/victorsn] has joined #bitcoin-core-dev 08:37 -!- iridis[m] [iridismatr@gateway/shell/matrix.org/x-vqnmwsxfzrnvarsv] has quit [Ping timeout: 244 seconds] 08:37 -!- vdero133[m] [vdero133ma@gateway/shell/matrix.org/x-uczbcekqtkwyttmz] has quit [Ping timeout: 244 seconds] 08:37 -!- Thomas[m]1 [thomaseizi@gateway/shell/matrix.org/x-clljcqsbmbzwpcdu] has quit [Ping timeout: 240 seconds] 08:37 -!- robert_spigler [robertspig@gateway/shell/matrix.org/x-ynqouhvuqnikmhoj] has quit [Ping timeout: 240 seconds] 08:37 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Ping timeout: 245 seconds] 08:38 -!- nickler [~nickler@static.219.205.69.159.clients.your-server.de] has quit [Ping timeout: 265 seconds] 08:38 -!- nickler [~nickler@static.219.205.69.159.clients.your-server.de] has joined #bitcoin-core-dev 08:47 -!- proofofkeags [~proofofke@205.209.28.54] has joined #bitcoin-core-dev 08:49 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #bitcoin-core-dev 08:51 -!- awesome_doge [~Thunderbi@36-225-156-67.dynamic-ip.hinet.net] has quit [Quit: awesome_doge] 08:51 -!- awesome_doge [~Thunderbi@36-225-156-67.dynamic-ip.hinet.net] has joined #bitcoin-core-dev 08:53 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 264 seconds] 08:53 -!- vadorovsky [vadorovsky@gateway/shell/matrix.org/x-mslwtptkdjjnlynw] has joined #bitcoin-core-dev 08:56 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev 08:57 -!- SebastianNoelLbk [sebasti49@gateway/shell/matrix.org/x-skwjryfcszfuexjn] has joined #bitcoin-core-dev 08:58 -!- outfawkesd [c636802e@static-198-54-128-46.cust.tzulo.com] has quit [Quit: Connection closed] 08:59 -!- OP_NOP [OP_NOP@gateway/vpn/privateinternetaccess/opnop/x-41418994] has joined #bitcoin-core-dev 09:00 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 09:00 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 09:00 -!- suzziminer[m] [suzziminer@gateway/shell/matrix.org/x-yqoebzjogqpkfvtp] has joined #bitcoin-core-dev 09:04 -!- iridis[m] [iridismatr@gateway/shell/matrix.org/x-gcoiuwfocakvbnmb] has joined #bitcoin-core-dev 09:06 -!- danben [~danben@2603-6080-cf03-7e0b-1076-2b58-fcf0-f191.res6.spectrum.com] has joined #bitcoin-core-dev 09:08 -!- zeropoint[m] [zeropointi@gateway/shell/matrix.org/x-qfmzuqyoesqmdjrf] has joined #bitcoin-core-dev 09:08 -!- stortz [c8b9cbcf@unaffiliated/stortz] has quit [Quit: Connection closed] 09:12 -!- leanbarba[m] [leanbarbam@gateway/shell/matrix.org/x-teminjuosufalrmf] has joined #bitcoin-core-dev 09:13 -!- stortz [c8b9cbcf@unaffiliated/stortz] has joined #bitcoin-core-dev 09:15 -!- robert_spigler [robertspig@gateway/shell/matrix.org/x-wkeizfzjpcqneuho] has joined #bitcoin-core-dev 09:16 -!- vdero133[m] [vdero133ma@gateway/shell/matrix.org/x-vkzkccvwgvgkxglz] has joined #bitcoin-core-dev 09:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:17 < bitcoin-git> [bitcoin] LarryRuane reopened pull request #21484: doc: Add release notes for #18335 (master...rel-notes-18335) https://github.com/bitcoin/bitcoin/pull/21484 09:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:24 -!- awesome_doge [~Thunderbi@36-225-156-67.dynamic-ip.hinet.net] has quit [Ping timeout: 258 seconds] 09:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:27 < bitcoin-git> [bitcoin] vasild opened pull request #21514: Ignore ports on I2P addresses (master...ignore_port_in_i2p) https://github.com/bitcoin/bitcoin/pull/21514 09:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:28 -!- Thomas[m]1 [thomaseizi@gateway/shell/matrix.org/x-otofsoyhwrcropyi] has joined #bitcoin-core-dev 09:33 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 09:42 -!- Kiminuo [~Kiminuo@141.98.103.180] has joined #bitcoin-core-dev 09:58 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 09:58 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 10:01 -!- shesek [~shesek@164.90.217.137] has joined #bitcoin-core-dev 10:01 -!- shesek [~shesek@164.90.217.137] has quit [Changing host] 10:01 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 10:20 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 10:22 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 10:22 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 10:27 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 10:27 -!- lightlike [~lightlike@p200300c7ef1ca90089ae1ec809ac3f97.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 10:29 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 10:29 -!- awesome_doge [~Thunderbi@36-225-156-67.dynamic-ip.hinet.net] has joined #bitcoin-core-dev 10:35 -!- asdlkfjwerpoicvx [~flack@p200300d46f1b8800329cb01f43c29580.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!] 10:49 -!- belcher_ is now known as belcher 10:59 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 11:11 -!- awesome_doge [~Thunderbi@36-225-156-67.dynamic-ip.hinet.net] has quit [Ping timeout: 272 seconds] 11:12 -!- mingu [771cbc9d@119.28.188.157] has quit [Quit: Connection closed] 11:17 -!- prayank [~Prashant_@2401:4900:30de:f516:699a:b03e:1b3a:254f] has joined #bitcoin-core-dev 11:20 -!- prayank1 [~Prashant_@2401:4900:30de:f516:849:5f6b:d99b:40d9] has joined #bitcoin-core-dev 11:21 -!- prayank [~Prashant_@2401:4900:30de:f516:699a:b03e:1b3a:254f] has quit [Ping timeout: 240 seconds] 11:23 -!- brunog [bbb72f44@187.183.47.68] has joined #bitcoin-core-dev 11:28 -!- prayank1 [~Prashant_@2401:4900:30de:f516:849:5f6b:d99b:40d9] has left #bitcoin-core-dev [] 11:29 -!- prayank [~andr0irc@2401:4900:30de:f516:f13c:594c:f3d0:3756] has joined #bitcoin-core-dev 11:33 -!- az0re [~az0re@gateway/tor-sasl/az0re] has quit [Remote host closed the connection] 11:34 -!- awesome_doge [~Thunderbi@2001-b011-4010-3816-e5f2-3498-cc08-a3f4.dynamic-ip6.hinet.net] has joined #bitcoin-core-dev 11:38 -!- awesome_doge [~Thunderbi@2001-b011-4010-3816-e5f2-3498-cc08-a3f4.dynamic-ip6.hinet.net] has quit [Ping timeout: 260 seconds] 11:51 -!- shaunsun [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has joined #bitcoin-core-dev 12:04 -!- d [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev 12:04 -!- d is now known as Guest52836 12:06 -!- p0x [~pox@gateway/tor-sasl/pox] has joined #bitcoin-core-dev 12:07 -!- pox [~pox@gateway/tor-sasl/pox] has quit [Remote host closed the connection] 12:07 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Disconnected by services] 12:07 -!- Guest52836 is now known as davterra 12:10 -!- awesome_doge [~Thunderbi@2001-b011-4010-3816-e5f2-3498-cc08-a3f4.dynamic-ip6.hinet.net] has joined #bitcoin-core-dev 12:11 -!- p0x [~pox@gateway/tor-sasl/pox] has quit [Ping timeout: 268 seconds] 12:11 -!- pox [~pox@gateway/tor-sasl/pox] has joined #bitcoin-core-dev 12:15 -!- awesome_doge [~Thunderbi@2001-b011-4010-3816-e5f2-3498-cc08-a3f4.dynamic-ip6.hinet.net] has quit [Ping timeout: 268 seconds] 12:17 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Quit: Leaving] 12:17 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 268 seconds] 12:22 -!- jungly [~jungly@host-82-59-148-94.retail.telecomitalia.it] has quit [Ping timeout: 272 seconds] 12:45 -!- jonatack_ [~jon@37.165.85.219] has joined #bitcoin-core-dev 12:49 -!- jonatack_ [~jon@37.165.85.219] has quit [Read error: Connection reset by peer] 12:49 -!- jonatack [~jon@37.165.23.76] has quit [Ping timeout: 272 seconds] 12:49 -!- jonatack_ [~jon@37.165.85.219] has joined #bitcoin-core-dev 12:53 -!- michaljanik [59ab2dc2@89-171-45-194.static.ip.netia.com.pl] has joined #bitcoin-core-dev 12:58 -!- jungly [~jungly@host-82-59-148-94.retail.telecomitalia.it] has joined #bitcoin-core-dev 12:59 -!- michaljanik [59ab2dc2@89-171-45-194.static.ip.netia.com.pl] has quit [Quit: Connection closed] 13:02 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 13:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:03 < bitcoin-git> [bitcoin] luke-jr closed pull request #21460: BIP8: Minimal common changes (master...bip8_minimal) https://github.com/bitcoin/bitcoin/pull/21460 13:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:07 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/681c21be9abb...fa2a5b8f3aeb 13:07 < bitcoin-git> bitcoin/master 180dc3c fanquake: build: miniupnpc 2.2.2 13:07 < bitcoin-git> bitcoin/master fa2a5b8 Wladimir J. van der Laan: Merge #20421: build: miniupnpc 2.2.2 13:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:07 < bitcoin-git> [bitcoin] laanwj merged pull request #20421: build: miniupnpc 2.2.2 (master...miniupnpc_220) https://github.com/bitcoin/bitcoin/pull/20421 13:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:20 -!- cornfeedhobo [~cornfeedh@unaffiliated/cornfeed] has quit [Quit: ZNC - https://znc.in] 13:25 -!- brunog [bbb72f44@187.183.47.68] has quit [Quit: Connection closed] 13:43 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 245 seconds] 13:43 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 13:56 -!- Tom8 [49db1185@c-73-219-17-133.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 13:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:58 < bitcoin-git> [bitcoin] naumenkogs opened pull request #21515: Erlay: bandwidth-efficient transaction relay protocol (master...2021-03-erlay) https://github.com/bitcoin/bitcoin/pull/21515 13:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:00 < jnewbery> #startmeeting 14:00 < core-meetingbot> Meeting started Tue Mar 23 21:00:29 2021 UTC. The chair is jnewbery. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings. 14:00 < core-meetingbot> Available commands: action commands idea info link nick 14:00 < gleb> hi! 14:00 < jnewbery> #bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik 14:00 < jnewbery> petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild wumpus 14:00 < amiti> hi 14:01 < aj> hey 14:01 < luke-jr> uh? 14:01 < jnewbery> We have one proposed topic in https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings (Erlay update from Gleb) 14:01 < jamesob> hi 14:01 < sipa> hi 14:02 < jnewbery> Feel free to share your p2p priorities here: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-Current-Priorities 14:02 < jnewbery> anyone have any quick updates or want to add a topic before we get on to erlay? 14:02 < jnewbery> ok 14:02 < jnewbery> #topic Erlay update (gleb) 14:02 < core-meetingbot> topic: Erlay update (gleb) 14:03 < gleb> So I just opened a new PR instead of the old one which was not reviewable any more. 14:03 < gleb> It's much-much refactored at this point. 14:03 < sipa> cool 14:03 < gleb> (I also believe I didn't skip any comment from the old PR except 1 or 2 debatable topics) 14:04 < glozow> hai 14:04 < gleb> I mark this as draft until I make sure it builds and passes test (including minisketch make check) smoothly 14:04 -!- proofofkeags_ [~proofofke@205.209.24.233] has joined #bitcoin-core-dev 14:04 < gleb> But generally if you're fine with reviewing code by eyes and not building, it's pretty much ready. 14:04 < jnewbery> needs rebase :) 14:04 < jamesob> exciting 14:04 < gleb> Gonna make it non-draft tomorrow I hope. And yeah, I see the rebase... 14:05 < gleb> One big question though. 14:05 < gleb> I added a lot of functional tests for any possible path of Erlay 14:05 < gleb> But no unit tests yet... What would we want there? Something as big as testing framework we have for txrequest? 14:05 < gleb> (Maybe you can answer only after reviewing, which is fine) 14:06 < sipa> i don't think the goal should "having unit tests" 14:06 < sipa> your goal is to test the code you have, and for every kind of tests, there are more and less appropriate ways of doing so 14:06 < sipa> if everything can be tested through functional tests, that's great 14:06 < jamesob> and for P2P stuff, that's actually plausible... 14:06 -!- proofofkeags [~proofofke@205.209.28.54] has quit [Ping timeout: 244 seconds] 14:07 < gleb> Well, I introduce like 5 new types of messages. 14:07 < sipa> but there are probably lower-level data structures etc that deserve testing in a more low-level way 14:07 < gleb> Testing all sequences in functional tests would be very messy... 14:08 < gleb> sipa: on the high-level I agree. On the low-level, I find it a bit challenging to find the right balance :) 14:08 < sipa> you can write a p2p fuzz tests like the net_process one that's specific to recon messages 14:09 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 256 seconds] 14:09 < sipa> i'll need to look at the code for more specific suggestions 14:09 < gleb> alright, and I'll consider what you said so far. Thanks. 14:09 < gleb> I think that's it on my side, unless people have questions. 14:10 < jnewbery> thanks gleb! 14:10 < jnewbery> anyone else want to give any updates? 14:10 < michaelfolkson> Given Erlay is a bandwidth improvement it is just a case of normal P2P testing behavior rather than ensuring any Erlay specific guarantees right? 14:11 < sipa> michaelfolkson: everything should be tested 14:11 < jnewbery> or any review begs from https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-Current-Priorities ? 14:11 < sipa> both the fact that p2p high-level goals still work (transactions propagate etc) and the fact that erlay itself works, down to as much detail as possible 14:11 < michaelfolkson> sipa: Right but I'm just thinking of where Erlay could break down and you'd need a specific test for that 14:12 < sipa> michaelfolkson: it could for example work perfectly, but be subtle different from the spec, i a way that makes it (a) useless and not actually saving bandwidth or (b) won't be compatible with other implementations 14:12 < michaelfolkson> sipa: Testing subtleties against spec, yeah that's a good one 14:12 < amiti> sure, happy to review beg for 21061 :) there are some outstanding comments I need to address, but approach feedback would be very useful!! 14:12 < sipa> #21061 14:12 < gribble> https://github.com/bitcoin/bitcoin/issues/21061 | [p2p] Introduce node rebroadcast module by amitiuttarwar · Pull Request #21061 · bitcoin/bitcoin · GitHub 14:13 < jnewbery> I'm planning to review rebroadcast soon 14:13 < lightlike> I think it's also interesting how erlay and traditional relay work together in the transition phase, my intuition says that unexpected things could happen, considering the different time scales. 14:13 < amiti> jnewbery: thanks :) 14:14 < sipa> lightlike: that's a good question, but probably something that's hard to test through automated tests (unless you mean things like it actually failing to propagate at all) 14:14 < lightlike> sipa: yes - that's probably something for simulations 14:14 < sipa> more like something to verify in simulations or large deployments 14:14 < gleb> lightlike: yeah I saw your comment earlier. 14:15 < gleb> I can try simulating that too, it's just would be so much better for us if we had an alternative simul stack crafted by non-me :) 14:15 < jnewbery> I'd appreciate some more review on #21236. It got some attention early on but it seems to have stalled a bit. 14:15 < gribble> https://github.com/bitcoin/bitcoin/issues/21236 | Net processing: Extract `addr` send functionality into MaybeSendAddr() by jnewbery · Pull Request #21236 · bitcoin/bitcoin · GitHub 14:15 < michaelfolkson> What is the Erlay transition phase? I just assumed once merged Erlay would be used by everyone with a fallback of not Erlay if it didn't work. 14:16 < sipa> michaelfolkson: there will be a time while the public mainnet bitcoin P2P network is a mix of erlay nodes and non-erlay nodes, and propagation must work well across those nodes too 14:17 < sipa> michaelfolkson: these are network-level properties e.g. what % of nodes receive a transaction within some amount of time, not something on the scale of an individual connection 14:17 < lightlike> and one type of propagation shouldn't cannibalize the other 14:17 < sipa> and without spiking bandwidth 14:17 < michaelfolkson> sipa lightlike: Ok thanks, makes sense 14:18 < jnewbery> any last updates/comments before we wrap up? 14:19 < jnewbery> #endmeeting 14:19 < core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt 14:19 < core-meetingbot> Meeting ended Tue Mar 23 21:19:23 2021 UTC. 14:19 < core-meetingbot> Minutes: https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2021/bitcoin-core-dev.2021-03-23-21.00.moin.txt 14:19 < jnewbery> thanks all! 14:19 < michaelfolkson> Thanks jnewbery 14:19 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 14:20 -!- prayank [~andr0irc@2401:4900:30de:f516:f13c:594c:f3d0:3756] has quit [Quit: AndroIRC - Android IRC Client ( http://www.androirc.com )] 14:23 < jamesob> I don't have a lot of context, but is someone going to pick up #20726? Sounds like a worthwhile change. 14:23 < gribble> https://github.com/bitcoin/bitcoin/issues/20726 | p2p: Add DISABLETX message for negotiating block-relay-only connections by sdaftuar · Pull Request #20726 · bitcoin/bitcoin · GitHub 14:24 < sipa> i'd like to see that too 14:25 -!- Tom8 [49db1185@c-73-219-17-133.hsd1.ma.comcast.net] has quit [Quit: Connection closed] 14:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:28 < bitcoin-git> [bitcoin] LarryRuane opened pull request #21516: remove unnecessary newline from chain.initWarning() argument (master...rm-unnecessary-newline) https://github.com/bitcoin/bitcoin/pull/21516 14:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:33 -!- jungly [~jungly@host-82-59-148-94.retail.telecomitalia.it] has quit [Ping timeout: 240 seconds] 14:45 -!- stortz [c8b9cbcf@unaffiliated/stortz] has quit [Quit: Connection closed] 14:47 -!- _flow_ [~none@salem.informatik.uni-erlangen.de] has quit [Quit: WeeChat 2.9] 15:07 -!- Kiminuo [~Kiminuo@141.98.103.180] has quit [Ping timeout: 265 seconds] 15:39 -!- proofofkeags__ [~proofofke@205.209.28.54] has joined #bitcoin-core-dev 15:41 -!- proofofkeags_ [~proofofke@205.209.24.233] has quit [Ping timeout: 245 seconds] 15:44 -!- d0minik [~d0minik@2a02:8108:473f:ea74:6149:e7e0:715d:39ac] has joined #bitcoin-core-dev 15:44 -!- d0minik [~d0minik@2a02:8108:473f:ea74:6149:e7e0:715d:39ac] has quit [Client Quit] 15:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 15:51 < bitcoin-git> [bitcoin] naumenkogs closed pull request #18261: Erlay: bandwidth-efficient transaction relay protocol (master...erlay) https://github.com/bitcoin/bitcoin/pull/18261 15:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 15:52 < ariard> jamesob: i'm not planning to do it, but would review it 16:19 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 16:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 16:24 < bitcoin-git> [gui] hebasto opened pull request #256: Save/restore column sizes of the tables in the Peers tab (master...210323-peers) https://github.com/bitcoin-core/gui/pull/256 16:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:31 -!- lectux [5325ac36@54.red-83-37-172.dynamicip.rima-tde.net] has joined #bitcoin-core-dev 16:37 -!- lectux [5325ac36@54.red-83-37-172.dynamicip.rima-tde.net] has quit [Quit: Connection closed] 17:02 -!- jespada [~jespada@90.254.243.187] has quit [Ping timeout: 264 seconds] 17:03 -!- jespada [~jespada@90.254.243.187] has joined #bitcoin-core-dev 17:08 -!- jonatack_ [~jon@37.165.85.219] has quit [Ping timeout: 256 seconds] 17:16 -!- proofofkeags__ [~proofofke@205.209.28.54] has quit [Ping timeout: 265 seconds] 17:21 -!- lightlike [~lightlike@p200300c7ef1ca90089ae1ec809ac3f97.dip0.t-ipconnect.de] has quit [Quit: Leaving] 17:28 -!- alct [~alct@139.28.218.148] has quit [Remote host closed the connection] 17:48 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Ping timeout: 268 seconds] 17:49 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev 17:56 < fanquake> Seems GH forgot how to colour for a minute: https://0bin.net/paste/Gok8bgWp#kVzPbN-sWO26BiHc91MiRivcoVdtipdICt0BG1eo+cg 18:02 -!- ogo [~ogo@gateway/tor-sasl/ogo] has quit [Quit: Leaving] 18:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:10 < bitcoin-git> [bitcoin] avainlakech opened pull request #21518: 0.21 (master...0.21) https://github.com/bitcoin/bitcoin/pull/21518 18:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:10 < bitcoin-git> [bitcoin] fanquake closed pull request #21518: 0.21 (master...0.21) https://github.com/bitcoin/bitcoin/pull/21518 18:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:11 < fanquake> sipa: please block avainlakech 18:11 < sipa> fanquake: already done 18:11 < fanquake> thank 18:14 < sipa> (i actually started writing "fanquake: already done" before seeing your message :p 18:15 < sipa> you are predictable 18:15 < fanquake> it did cross my mind whether I should even bother to ping you hah 18:16 < fanquake> just got a nice email from that person 18:17 < fanquake> https://0bin.net/paste/h9n8ZD4k#90gVE19z6o-tgaVY8AA7Icm0fVp2W7ufUi2EWLDXYFM 18:17 < gribble> https://github.com/bitcoin/bitcoin/issues/90 | Improve debug logging by jgarzik · Pull Request #90 · bitcoin/bitcoin · GitHub 18:20 < hebasto> fanquake: hah, last week I was banned in linguist telegram group after mentioning translation Bitcoin Core 18:27 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...] 18:27 < fanquake> hebasto: hope you got the info you needed beforehand 18:28 < hebasto> nope :) 18:28 < fanquake> Same person has followed up by emailing me a private key. “Here, take my private key, you get zero bitcoin” 18:29 < sipa> How nice. 18:29 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev 18:32 < aj> sipa: Add a comment: "round up to the next strictly larger multiple of 1000"? -- would "Have each group of tests be counted by the 1000s part, starting at 1000" be clear enough? explains more the why than the what 18:33 < sipa> aj: sgtm 18:39 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 18:45 -!- redsky [45ecd8a7@69-236-216-167.lightspeed.irvnca.sbcglobal.net] has joined #bitcoin-core-dev 18:47 -!- redsky [45ecd8a7@69-236-216-167.lightspeed.irvnca.sbcglobal.net] has left #bitcoin-core-dev [] 19:03 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 19:03 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 19:05 -!- CrazyPython [~crazypyth@98.122.164.118] has quit [Ping timeout: 264 seconds] 19:09 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 19:11 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 264 seconds] 19:11 -!- shaunsun [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has quit [Quit: Leaving] 19:30 -!- CrazyPython [~crazypyth@98.122.164.118] has joined #bitcoin-core-dev 19:32 < fanquake> “You are ruining people's lives.” 19:32 < fanquake> it really is the morning for nice emails 19:36 -!- dermoth_ [~dermoth@unaffiliated/dermoth] has joined #bitcoin-core-dev 19:39 -!- dermoth [~dermoth@unaffiliated/dermoth] has quit [Ping timeout: 256 seconds] 19:44 -!- awesome_doge [~Thunderbi@118-163-120-175.HINET-IP.hinet.net] has joined #bitcoin-core-dev 19:46 -!- awesome_doge [~Thunderbi@118-163-120-175.HINET-IP.hinet.net] has quit [Remote host closed the connection] 19:46 -!- awesome_doge [~Thunderbi@118-163-120-175.HINET-IP.hinet.net] has joined #bitcoin-core-dev 19:58 -!- outfawkesd [c636802e@static-198-54-128-46.cust.tzulo.com] has joined #bitcoin-core-dev 20:00 -!- CrazyPython [~crazypyth@98.122.164.118] has quit [Read error: Connection reset by peer] 20:05 -!- proofofkeags [~proofofke@97-118-232-73.hlrn.qwest.net] has joined #bitcoin-core-dev 20:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 20:45 < bitcoin-git> [gui] hebasto opened pull request #257: refactor: Use template function qOverload in signal-slot connections (master...210323-overload) https://github.com/bitcoin-core/gui/pull/257 20:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 20:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 20:54 < bitcoin-git> [bitcoin] fanquake pushed 25 commits to 0.21: https://github.com/bitcoin/bitcoin/compare/1bad33f952ea...a30fd40735eb 20:54 < bitcoin-git> bitcoin/0.21 c33fbab Vasil Dimov: net: allow CSubNet of non-IP networks 20:54 < bitcoin-git> bitcoin/0.21 bdce029 Vasil Dimov: test: add test for banning of non-IP addresses 20:54 < bitcoin-git> bitcoin/0.21 7bf3ed4 Luke Dashjr: Bugfix: GUI: Restore SendConfirmationDialog button default to "Yes" 20:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 20:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 20:55 < bitcoin-git> [bitcoin] fanquake merged pull request #20901: [0.21.1]: rc1 Backports (0.21...2101-2101Backports) https://github.com/bitcoin/bitcoin/pull/20901 20:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 20:55 -!- proofofkeags [~proofofke@97-118-232-73.hlrn.qwest.net] has quit [Ping timeout: 256 seconds] 21:16 < aj> fanquake: what is "your branch" that differed from 20901? is that something worth knowing about? 21:16 < aj> oh, duh, read the comment more carefully aj 21:17 < aj> fanquake: your correctly worded ACKs are ruining my life :( 21:17 < fanquake> aj: I'll try and word them more "fast and loose" going forward 21:20 < aj> oh wait, forget i said anything. i should be riffing off "said hanrahan" for fanquake ruining things 21:24 -!- awesome_doge [~Thunderbi@118-163-120-175.HINET-IP.hinet.net] has quit [Ping timeout: 245 seconds] 21:29 < aj> "We'll all be rooned" said fanquake's man // In an email most forlorn // Outside the repo, evading bans // One toasty We'n'sd'y morn. // The IRCers lurked and talked // PRs up to their ears // And talked of tests, CI and forks // As they had done for years. 21:31 < fanquake> when are you gunna release a book ? 21:32 < fanquake> aj's greatest hits. #8563 - #21489 21:32 < gribble> https://github.com/bitcoin/bitcoin/issues/8563 | Add configure check for -latomic by ajtowns · Pull Request #8563 · bitcoin/bitcoin · GitHub 21:32 < gribble> https://github.com/bitcoin/bitcoin/issues/21489 | fuzz: cleanups for versionbits fuzzer by ajtowns · Pull Request #21489 · bitcoin/bitcoin · GitHub 21:41 < aj> i have a blog, that's kinda like a book 21:46 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 21:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 21:50 < bitcoin-git> [bitcoin] achow101 opened pull request #21520: [0.21] wallet: Avoid requesting fee rates multiple times during coin selection (0.21...0.21-createtx-same-feerate) https://github.com/bitcoin/bitcoin/pull/21520 21:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:03 -!- meshcollider [meshcollid@gateway/shell/ircnow/x-qcfpgmsncdtvtiio] has quit [Ping timeout: 244 seconds] 22:34 -!- meshcollider [meshcollid@gateway/shell/ircnow/x-kzwoeyrqdbyezhhf] has joined #bitcoin-core-dev 23:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:01 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #21522: fuzz: [refactor] Use PickValue where possible (master...2103-fuzzPickValue) https://github.com/bitcoin/bitcoin/pull/21522 23:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:10 < fanquake> aj #21489 no longer draft right? 23:10 < gribble> https://github.com/bitcoin/bitcoin/issues/21489 | fuzz: cleanups for versionbits fuzzer by ajtowns · Pull Request #21489 · bitcoin/bitcoin · GitHub 23:13 -!- jonatack_ [~jon@37.165.85.219] has joined #bitcoin-core-dev 23:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:16 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fa2a5b8f3aeb...f95071a3f5d3 23:16 < bitcoin-git> bitcoin/master aa7f418 Anthony Towns: fuzz: cleanups for versionbits fuzzer 23:16 < bitcoin-git> bitcoin/master f95071a fanquake: Merge #21489: fuzz: cleanups for versionbits fuzzer 23:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:16 < bitcoin-git> [bitcoin] fanquake merged pull request #21489: fuzz: cleanups for versionbits fuzzer (master...202103-versionbits-fuzz-followups) https://github.com/bitcoin/bitcoin/pull/21489 23:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:18 < aj> what? 23:18 < aj> that was a draft 23:19 < aj> duuuuuuude 23:19 < aj> you are ruining my life 23:20 < achow101> I think that was marked as a draft for a reason 23:21 < aj> fanquake: like it said in the description, it was a draft to avoid conflicting with the speedy trial PRs. now it'll also need backporting to 0.21 23:21 < aj> also, i'm loving this ruining my life meme 23:22 < fanquake> none of the speedy trial PRs are anywhere near close to being merged right? 23:22 < aj> well they're further away now! 23:22 < aj> should've titled it DO-NOT-MERGE as well as marked it draft i suppose 23:27 < fanquake> aj: apologies. Is there an overarching issue tracking how all of these PRs piece together. It's not very clear, and they all seem to based on, or borrow commits from each other etc. 23:28 -!- danben [~danben@2603-6080-cf03-7e0b-1076-2b58-fcf0-f191.res6.spectrum.com] has quit [Ping timeout: 260 seconds] 23:29 < fanquake> I'm also just trying to figure out where the "root" of the conflict is. I assume e9e24b9ad836c4f425e6c22f1c4a179dab9e75ea ? 23:30 < aj> fanquake: there'll be neighbouring lines changed between removing the 'const x = 0' defaults and adding a 'const min_activation_height' if nothing else 23:30 < aj> fanquake: no big deal to fix in either PR, just extra rebasing we could've avoided 23:32 -!- Kiminuo [~Kiminuo@141.98.103.180] has joined #bitcoin-core-dev 23:33 < fanquake> achow101: sorry. Thanks for the quick rebase. 23:33 < aj> fanquake: you could poke at #20353 if you wanted? :) 23:33 < gribble> https://github.com/bitcoin/bitcoin/issues/20353 | configure: Support -fdebug-prefix-map and -fmacro-prefix-map by ajtowns · Pull Request #20353 · bitcoin/bitcoin · GitHub 23:33 < fanquake> aj: sure 23:35 < aj> did something make master slower to compile recently or am i just seeing things? 23:36 < fanquake> since kinda recently all the fuzz targets now get built by default, which is a decent amount of additional compilation 23:36 < fanquake> nothing super recent I can recall 23:36 < aj> nah, would have to be more recent than that 23:42 -!- mingu [771cbc9d@119.28.188.157] has joined #bitcoin-core-dev 23:46 -!- baldur [~baldur@pool-108-30-51-126.nycmny.fios.verizon.net] has quit [Ping timeout: 245 seconds] 23:48 < aj> maybe i'm just used to more ccache hits or something 23:49 < jonatack_> aj: yup same impression here, fuzz targets and qt code particularly 23:51 < jonatack_> jamesob: sipa: ariard 23:51 < jonatack_> ^ agree wrt disabletx 23:51 -!- _flow_ [~none@salem.informatik.uni-erlangen.de] has joined #bitcoin-core-dev 23:58 -!- baldur [~baldur@pool-108-30-51-126.nycmny.fios.verizon.net] has joined #bitcoin-core-dev --- Log closed Wed Mar 24 00:00:05 2021