--- Log opened Mon Apr 12 00:00:23 2021 00:16 -!- jespada [~jespada@90.254.243.187] has joined #bitcoin-core-dev 00:25 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 00:33 -!- stortz [c8b9c69a@unaffiliated/stortz] has quit [Quit: Connection closed] 00:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:34 < bitcoin-git> [bitcoin] hebasto closed pull request #21591: build, qt: Fix wrong cross-compiling detection on macOS (master...210403-cross) https://github.com/bitcoin/bitcoin/pull/21591 00:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:34 < bitcoin-git> [bitcoin] hebasto reopened pull request #21591: build, qt: Fix wrong cross-compiling detection on macOS (master...210403-cross) https://github.com/bitcoin/bitcoin/pull/21591 00:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:40 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 00:59 -!- michagogo_ is now known as michagogo 01:13 -!- asdlkfjwerpoicvx [~flack@p200300d46f169100afc5d2b75216b381.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 01:13 -!- asdlkfjwerpoicvx [~flack@p200300d46f169100afc5d2b75216b381.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 01:13 -!- asdlkfjwerpoicvx [~flack@p200300d46f169100afc5d2b75216b381.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 01:13 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 01:13 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 01:28 -!- jarthur [~jarthur@cpe-70-114-198-37.austin.res.rr.com] has quit [Quit: jarthur] 01:29 -!- ishaqm [~ishaqm@host-92-30-116-245.as13285.net] has joined #bitcoin-core-dev 01:30 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 01:57 -!- nz [d25601ef@210-86-1-239.adsl.xtra.co.nz] has joined #bitcoin-core-dev 01:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:58 < bitcoin-git> [bitcoin] fanquake closed pull request #19242: Add -uaappend option to append a literal string to user agent (master...uaappend) https://github.com/bitcoin/bitcoin/pull/19242 01:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:59 -!- nz [d25601ef@210-86-1-239.adsl.xtra.co.nz] has quit [Client Quit] 02:35 -!- worc3131 [~quassel@2a02:c7f:dcc4:6500:cf0e:3346:8766:ab20] has joined #bitcoin-core-dev 03:16 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection] 03:17 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 03:18 -!- Monica59Wintheis [~Monica59W@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev 03:23 < wumpus> instagibbs: done 03:26 -!- worc3131 [~quassel@2a02:c7f:dcc4:6500:cf0e:3346:8766:ab20] has quit [Ping timeout: 260 seconds] 03:27 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has joined #bitcoin-core-dev 03:30 -!- Monica59Wintheis [~Monica59W@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 265 seconds] 04:03 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Ping timeout: 240 seconds] 04:04 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev 04:35 -!- _kiara [4fb7cf25@bzq-79-183-207-37.red.bezeqint.net] has joined #bitcoin-core-dev 04:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:46 < bitcoin-git> [bitcoin] AlbanAndrieu closed pull request #21646: -daemonwait change to -daemon (master...master) https://github.com/bitcoin/bitcoin/pull/21646 04:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:57 -!- _kiara [4fb7cf25@bzq-79-183-207-37.red.bezeqint.net] has quit [Ping timeout: 240 seconds] 04:59 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 05:02 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 252 seconds] 05:09 -!- belcher_ is now known as belcher 05:33 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 05:40 -!- biteskola [~biteskola@170.76.76.188.dynamic.jazztel.es] has joined #bitcoin-core-dev 05:45 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 05:45 -!- rny [~rny@gateway/tor-sasl/renlord] has quit [Ping timeout: 240 seconds] 05:46 -!- rny [~rny@gateway/tor-sasl/renlord] has joined #bitcoin-core-dev 05:46 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 05:59 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Read error: Connection reset by peer] 06:03 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev 06:19 -!- jungly [~jungly@host-212-171-242-56.retail.telecomitalia.it] has quit [Ping timeout: 252 seconds] 06:33 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Ping timeout: 240 seconds] 06:34 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev 06:37 -!- EricYuzo [~EricYuzo@195.140.213.38] has joined #bitcoin-core-dev 06:39 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 06:40 -!- jungly [~jungly@host-79-55-175-219.retail.telecomitalia.it] has joined #bitcoin-core-dev 06:44 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 268 seconds] 06:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:51 < bitcoin-git> [bitcoin] vasild opened pull request #21659: net: flag relevant Sock methods with [[nodiscard]] (master...Sock_nodiscard) https://github.com/bitcoin/bitcoin/pull/21659 06:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:57 -!- moorcock75 [~niamh@aaubervilliers-654-1-61-83.w86-218.abo.wanadoo.fr] has quit [Ping timeout: 252 seconds] 06:59 -!- niamh [~niamh@aaubervilliers-654-1-61-83.w86-218.abo.wanadoo.fr] has joined #bitcoin-core-dev 07:02 -!- tlev [~tlev@li120-195.members.linode.com] has quit [Quit: Ping timeout (120 seconds)] 07:03 -!- tlev [~tlev@li120-195.members.linode.com] has joined #bitcoin-core-dev 07:10 -!- lord__ [~lord@c-66-229-1-22.hsd1.fl.comcast.net] has joined #bitcoin-core-dev 07:14 -!- jonatack [jon@gateway/vpn/airvpn/jonatack] has quit [Quit: jonatack] 07:18 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Remote host closed the connection] 07:18 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev 07:23 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 07:23 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 07:29 -!- niamh [~niamh@aaubervilliers-654-1-61-83.w86-218.abo.wanadoo.fr] has quit [Remote host closed the connection] 07:29 -!- niamh [~niamh@aaubervilliers-654-1-61-83.w86-218.abo.wanadoo.fr] has joined #bitcoin-core-dev 07:30 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 07:31 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 07:31 -!- jungly [~jungly@host-79-55-175-219.retail.telecomitalia.it] has quit [Ping timeout: 240 seconds] 07:32 -!- jonatack [jon@gateway/vpn/airvpn/jonatack] has joined #bitcoin-core-dev 07:35 -!- jungly [~jungly@host-95-248-128-191.retail.telecomitalia.it] has joined #bitcoin-core-dev 07:36 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 07:41 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 07:48 -!- niamh [~niamh@aaubervilliers-654-1-61-83.w86-218.abo.wanadoo.fr] has quit [Ping timeout: 246 seconds] 08:03 -!- _kiara [8de25c4d@141.226.92.77] has joined #bitcoin-core-dev 08:08 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 08:11 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 265 seconds] 08:21 -!- niamh [~niamh@aaubervilliers-654-1-61-83.w86-218.abo.wanadoo.fr] has joined #bitcoin-core-dev 08:28 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Ping timeout: 240 seconds] 08:34 -!- EricYuzo [~EricYuzo@195.140.213.38] has quit [Ping timeout: 260 seconds] 08:38 -!- niamh [~niamh@aaubervilliers-654-1-61-83.w86-218.abo.wanadoo.fr] has quit [Ping timeout: 240 seconds] 08:38 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev 08:39 -!- ogo [~ogo@gateway/tor-sasl/ogo] has quit [Quit: Leaving] 08:42 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 08:45 -!- _kiara [8de25c4d@141.226.92.77] has quit [Quit: Connection closed] 08:45 -!- niamh [~niamh@aaubervilliers-654-1-61-83.w86-218.abo.wanadoo.fr] has joined #bitcoin-core-dev 08:53 -!- oniijin [~oniijin@185.204.1.185] has joined #bitcoin-core-dev 08:53 -!- biteskola [~biteskola@170.76.76.188.dynamic.jazztel.es] has quit [Ping timeout: 240 seconds] 08:55 -!- jungly [~jungly@host-95-248-128-191.retail.telecomitalia.it] has quit [Ping timeout: 260 seconds] 09:00 -!- jungly [~jungly@host-79-42-191-252.retail.telecomitalia.it] has joined #bitcoin-core-dev 09:20 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 252 seconds] 09:20 -!- asdlkfjwerpoicvx [~flack@p200300d46f169100afc5d2b75216b381.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!] 09:23 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 09:25 -!- lightlike [~lightlike@p200300c7ef0eeb0004db876bc89db2cc.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 09:25 -!- jadi [~jadi@37.98.3.133] has quit [Ping timeout: 252 seconds] 09:55 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 09:56 -!- joerodgers [~joerodger@c-76-125-83-191.hsd1.ar.comcast.net] has quit [Read error: Connection reset by peer] 10:01 -!- ogo [~ogo@gateway/tor-sasl/ogo] has joined #bitcoin-core-dev 10:05 -!- ogo [~ogo@gateway/tor-sasl/ogo] has quit [Remote host closed the connection] 10:06 -!- ogo [~ogo@gateway/tor-sasl/ogo] has joined #bitcoin-core-dev 10:09 -!- _kiara [8de25c4d@141.226.92.77] has joined #bitcoin-core-dev 10:13 -!- lightlike [~lightlike@p200300c7ef0eeb0004db876bc89db2cc.dip0.t-ipconnect.de] has quit [Ping timeout: 250 seconds] 10:20 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Read error: Connection reset by peer] 10:24 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 10:24 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 10:32 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev 10:34 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Client Quit] 10:36 -!- jungly [~jungly@host-79-42-191-252.retail.telecomitalia.it] has quit [Ping timeout: 252 seconds] 10:37 -!- oozebrood [~oozebrood@bishop.xerrero.com] has quit [Quit: ZNC - https://znc.in] 10:38 -!- oozebrood [~oozebrood@bishop.xerrero.com] has joined #bitcoin-core-dev 10:44 -!- biteskola [~biteskola@170.76.76.188.dynamic.jazztel.es] has joined #bitcoin-core-dev 10:54 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 10:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:55 < bitcoin-git> [bitcoin] Emzy opened pull request #21661: doc: Fix name of script guix-build (master...patch-2) https://github.com/bitcoin/bitcoin/pull/21661 10:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:58 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 265 seconds] 10:59 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection] 11:00 -!- lightlike [~lightlike@p200300c7ef0eeb003c5461af0b34e125.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 11:00 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 11:11 -!- stortz [c8b9c69a@unaffiliated/stortz] has joined #bitcoin-core-dev 11:13 -!- ishaqm [~ishaqm@host-92-30-116-245.as13285.net] has quit [Remote host closed the connection] 11:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:15 < bitcoin-git> [bitcoin] fdoving opened pull request #21662: build,boost: update download url. (master...fdov-boost-url) https://github.com/bitcoin/bitcoin/pull/21662 11:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:27 -!- vv8 [~egp_@128-71-69-136.broadband.corbina.ru] has quit [Ping timeout: 265 seconds] 11:31 -!- moorcock75 [~niamh@128.127.26.178] has joined #bitcoin-core-dev 11:34 -!- niamh [~niamh@aaubervilliers-654-1-61-83.w86-218.abo.wanadoo.fr] has quit [Ping timeout: 240 seconds] 11:34 -!- mars [~niamh@aaubervilliers-654-1-61-83.w86-218.abo.wanadoo.fr] has joined #bitcoin-core-dev 11:37 -!- moorcock75 [~niamh@128.127.26.178] has quit [Ping timeout: 240 seconds] 11:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:56 < bitcoin-git> [bitcoin] hebasto opened pull request #21663: ci: Fix macOS brew install command (master...210412-brew) https://github.com/bitcoin/bitcoin/pull/21663 11:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:59 -!- human01 [4f8299de@athedsl-4401646.home.otenet.gr] has joined #bitcoin-core-dev 12:01 -!- jungly [~jungly@host-79-42-191-252.retail.telecomitalia.it] has joined #bitcoin-core-dev 12:01 -!- jorts is now known as nckx 12:02 -!- rny [~rny@gateway/tor-sasl/renlord] has quit [Remote host closed the connection] 12:03 -!- rny [~rny@gateway/tor-sasl/renlord] has joined #bitcoin-core-dev 12:09 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:13 < wumpus> we really need to fix the CI it's failling on almost everything 12:14 < wumpus> oh something with macos, looks like there is a PR for it #21663 12:14 < gribble> https://github.com/bitcoin/bitcoin/issues/21663 | ci: Fix macOS brew install command by hebasto · Pull Request #21663 · bitcoin/bitcoin · GitHub 12:15 < jakesyl> Anyone have any idea why a transaction version would be negative? https://github.com/btcsuite/btcd/pull/1701#issuecomment-817995493 12:19 -!- stortz [c8b9c69a@unaffiliated/stortz] has quit [Quit: Connection closed] 12:19 < sipa> jakesyl: it's a number, it can be anything 12:19 < sipa> probably just someone playing around 12:19 < luke-jr> jakesyl: see BIP 68 12:19 < hebasto> wumpus: yeah, 21663 fixed brew, but ci log shows ridiculous configure failure 12:20 < luke-jr> ie, it's not really signed 12:20 * luke-jr wonders if there's anything that *does* treat it as signed 12:21 < sipa> luke-jr: BIP68 treats it as signed, afaik 12:21 < luke-jr> sipa: it explicitly doesn't…? 12:21 < hebasto> wumpus: probably, it is related to new Autoconf 2.71 12:21 < sipa> luke-jr: you are right 12:21 < sipa> luke-jr: standardness rules may treat it as signed 12:22 < luke-jr> src/policy/policy.cpp: if (tx.nVersion > CTransaction::MAX_STANDARD_VERSION || tx.nVersion < 1) { 12:22 -!- jungly [~jungly@host-79-42-191-252.retail.telecomitalia.it] has quit [Ping timeout: 240 seconds] 12:22 < luke-jr> I'm not sure the sign matters for that 12:23 < sipa> it does 12:23 < luke-jr> how? 12:23 < luke-jr> O.o even RPC treats it as unsigned: src/core_write.cpp: entry.pushKV("version", static_cast(static_cast(tx.nVersion))); 12:23 < jakesyl> it looks like bip 68 casts nVersion to a uint32 (fEnforceBIP68) 12:23 < sipa> luke-jr: nVersion is an int32_t 12:24 < sipa> so if the serialization is 0xffffffff, it'd be interpreted as -1, and which be "< 1" 12:24 < luke-jr> sipa: yes, but if it were interpreted as 0xffffffff it would be >CTransaction::MAX_STANDARD_VERSION 12:24 < sipa> luke-jr: ah, good point! 12:24 < sipa> indeed, it doesn't matter 12:25 < sipa> at least with the current CTransaction::MAX_STANDARD_VERSION value 12:25 < luke-jr> quickly glancing over the code, I think we treat it as unsigned everywhere XD 12:25 < sipa> because the only two qualifying values are 1 and 2, and their serialization in signed and unsigned is identical 12:25 < jakesyl> only exception I can think of *might* be the rpc interface 12:25 < luke-jr> jakesyl: see above 12:26 < sipa> i vaguely recall that the RPC interface was changed a few years ago, precisely because it's semantically unsigned everywhere already 12:26 < sipa> but somehow didn't want to touch the actual data type for fear of consensus implications 12:26 < jakesyl> oh read that wrong. Got it - thanks! 12:26 < luke-jr> yeah, I'd want to do a lot more in-depth review before messing with it for that reason 12:27 < jakesyl> yeah - on btcd think we'll just match the bitcoin-core rpc interface there 12:27 < luke-jr> and frankly probably not worth it 12:27 < sipa> but at least at first glance i agree that it most likely doesn't affect anything 12:27 < jakesyl> (it's currently signed in our return) 12:27 < luke-jr> but as far as documentation, IMO we should just say it's unsigned 12:27 < sipa> yes, makes sense 12:30 -!- human01 [4f8299de@athedsl-4401646.home.otenet.gr] has quit [Quit: Connection closed] 12:33 -!- jungly [~jungly@host-79-42-191-252.retail.telecomitalia.it] has joined #bitcoin-core-dev 12:35 -!- smctwo [~smctwo@bba597217.alshamil.net.ae] has quit [] 12:38 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 12:45 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 12:53 < jakesyl> oh interesting - btw likely reason this is the first time we're seeing it (and it's on testnet) is b/c `IsStandardTx`isn't called w/ `-testnet` 12:53 < sipa> yeah 12:53 < sipa> you're unlikely to see that on mainnet 12:57 -!- _kiara [8de25c4d@141.226.92.77] has quit [Ping timeout: 240 seconds] 13:04 -!- smartineng [~Icedove@88.135.18.171] has quit [Quit: smartineng] 13:06 -!- meinwolf [~meinwolf@unaffiliated/meinwolf] has quit [Remote host closed the connection] 13:22 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 13:22 < jamesob> Anyone seen these 403 forbidden errors during CI runs before? https://github.com/bitcoin/bitcoin/pull/21526/checks?check_run_id=2327358485 13:25 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 260 seconds] 13:25 < luke-jr> only recently; but I didn't find a solution 13:25 < wumpus> jamesob: yes, see #21663 13:25 < gribble> https://github.com/bitcoin/bitcoin/issues/21663 | ci: Fix macOS brew install command by hebasto · Pull Request #21663 · bitcoin/bitcoin · GitHub 13:26 < jamesob> wumpus: thanks 13:27 < wumpus> we should merge that soon but first waiting for CI to be green 13:29 < luke-jr> oh, that's the same one? 13:31 -!- biteskola [~biteskola@170.76.76.188.dynamic.jazztel.es] has quit [Ping timeout: 240 seconds] 13:36 < wumpus> i think so 13:40 < jamesob> wumpus: I ACK'd only on the basis of the macOS CI run being green 13:47 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Read error: Connection reset by peer] 13:50 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev 13:52 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 13:54 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 14:00 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 14:03 -!- vv8 [~egp_@2.95.117.163] has joined #bitcoin-core-dev 14:17 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 14:17 -!- jungly [~jungly@host-79-42-191-252.retail.telecomitalia.it] has quit [Ping timeout: 240 seconds] 14:20 -!- lightlike [~lightlike@p200300c7ef0eeb003c5461af0b34e125.dip0.t-ipconnect.de] has quit [Quit: Leaving] 14:22 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 14:23 -!- vdero133[m] [vdero133ma@gateway/shell/matrix.org/x-duupsqvhcumjbhav] has joined #bitcoin-core-dev 14:30 -!- bclync [~bclync@89-73-214-104.dynamic.chello.pl] has joined #bitcoin-core-dev 14:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:32 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f6c44e999b7d...708517b2dd64 14:32 < bitcoin-git> bitcoin/master b738155 Hennadii Stepanov: ci: Fix macOS brew install command 14:32 < bitcoin-git> bitcoin/master 708517b W. J. van der Laan: Merge #21663: ci: Fix macOS brew install command 14:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:32 < bitcoin-git> [bitcoin] laanwj merged pull request #21663: ci: Fix macOS brew install command (master...210412-brew) https://github.com/bitcoin/bitcoin/pull/21663 14:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:33 -!- bclync [~bclync@89-73-214-104.dynamic.chello.pl] has quit [Client Quit] 14:44 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:45 -!- ovovo [~ovovo@2a02:29b8:dc01:1881::2e] has joined #bitcoin-core-dev 14:45 -!- ovovo [~ovovo@2a02:29b8:dc01:1881::2e] has quit [Changing host] 14:45 -!- ovovo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 14:47 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 260 seconds] 14:54 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 14:57 -!- jungly [~jungly@host-79-42-191-252.retail.telecomitalia.it] has joined #bitcoin-core-dev 15:10 -!- jungly [~jungly@host-79-42-191-252.retail.telecomitalia.it] has quit [Ping timeout: 265 seconds] 15:15 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 252 seconds] 15:56 -!- pncl [~pncl___@128.127.220.189] has joined #bitcoin-core-dev 15:56 -!- pncl_ [~pncl___@128.127.220.189] has joined #bitcoin-core-dev 16:14 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 16:15 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 16:34 -!- pncl [~pncl___@128.127.220.189] has quit [Ping timeout: 240 seconds] 16:35 -!- pncl_ [~pncl___@128.127.220.189] has quit [Ping timeout: 240 seconds] 16:42 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Ping timeout: 240 seconds] 16:44 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev 16:57 -!- IGHOR [~quassel@176.121.4.135] has quit [Quit: http://quassel-irc.org ? ??????????? ?????????. ????-??.] 17:01 -!- IGHOR [~quassel@176.121.4.135] has joined #bitcoin-core-dev 17:02 -!- mars [~niamh@aaubervilliers-654-1-61-83.w86-218.abo.wanadoo.fr] has quit [Remote host closed the connection] 17:02 -!- mars [~niamh@aaubervilliers-654-1-61-83.w86-218.abo.wanadoo.fr] has joined #bitcoin-core-dev 17:04 -!- IGHOR [~quassel@176.121.4.135] has quit [Client Quit] 17:08 -!- IGHOR [~quassel@176.121.4.135] has joined #bitcoin-core-dev 17:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 17:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:16 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/708517b2dd64...89b72ce045b5 17:16 < bitcoin-git> bitcoin/master 08151e1 Stephan Oeste: doc: Fix name of script guix-build 17:16 < bitcoin-git> bitcoin/master 89b72ce fanquake: Merge #21661: doc: Fix name of script guix-build 17:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:17 < bitcoin-git> [bitcoin] fanquake merged pull request #21661: doc: Fix name of script guix-build (master...patch-2) https://github.com/bitcoin/bitcoin/pull/21661 17:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:22 -!- lord__ [~lord@c-66-229-1-22.hsd1.fl.comcast.net] has quit [Ping timeout: 240 seconds] 17:24 -!- jeremyrubin [~jr@024-176-247-182.res.spectrum.com] has quit [Remote host closed the connection] 17:24 -!- jeremyrubin [~jr@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev 17:45 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 265 seconds] 17:53 -!- meinwolf [~meinwolf@unaffiliated/meinwolf] has joined #bitcoin-core-dev 18:16 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 18:44 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 19:09 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 19:11 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 19:12 -!- oniijin [~oniijin@185.204.1.185] has quit [Remote host closed the connection] 19:14 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 252 seconds] 19:14 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 19:18 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 19:18 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 19:21 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 252 seconds] 19:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 19:25 < bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/89b72ce045b5...bd65a76b9d97 19:25 < bitcoin-git> bitcoin/master b77b0cc Pieter Wuille: Add MissingDataBehavior and make TransactionSignatureChecker handle it 19:25 < bitcoin-git> bitcoin/master 3820090 Pieter Wuille: Make all SignatureChecker explicit about missing data 19:25 < bitcoin-git> bitcoin/master 497718b Pieter Wuille: Treat amount<0 also as missing data for P2WPKH/P2WSH 19:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 19:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 19:25 < bitcoin-git> [bitcoin] fanquake merged pull request #21330: Deal with missing data in signature hashes more consistently (master...202103_missing_data_verify) https://github.com/bitcoin/bitcoin/pull/21330 19:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 19:26 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 19:28 -!- Mikaela1 [~Mikaela@217.146.82.202] has joined #bitcoin-core-dev 20:06 -!- OP_NOP [OP_NOP@gateway/vpn/privateinternetaccess/opnop/x-41418994] has quit [Ping timeout: 260 seconds] 20:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 20:08 < bitcoin-git> [bitcoin] fanquake opened pull request #21664: contrib: use LIEF for macOS and Windows symbol & security checks (master...macos_win_lief) https://github.com/bitcoin/bitcoin/pull/21664 20:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 20:08 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 20:10 -!- OP_NOP [OP_NOP@gateway/vpn/privateinternetaccess/opnop/x-41418994] has joined #bitcoin-core-dev 20:14 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds] 20:16 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 20:20 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 20:23 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 20:26 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 268 seconds] 20:32 -!- Talegas [49f669f3@c-73-246-105-243.hsd1.il.comcast.net] has joined #bitcoin-core-dev 20:36 -!- Talegas [49f669f3@c-73-246-105-243.hsd1.il.comcast.net] has quit [Client Quit] 20:39 < achow101> harding: wumpus: can you make the same change to bitcoin.org that was done for bitcoincore.org to redirect users to download the 0.21-win-unsigned.exe? I'm seeing several users posting issues there about that. 21:08 -!- openoms [~quassel@gateway/tor-sasl/openoms] has quit [Remote host closed the connection] 21:08 -!- openoms [~quassel@gateway/tor-sasl/openoms] has joined #bitcoin-core-dev 21:12 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 21:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 21:17 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bd65a76b9d97...1f50f0bb389a 21:17 < bitcoin-git> bitcoin/master 1c1467f Vasil Dimov: i2p: cancel the Accept() method if waiting on the socket errors 21:17 < bitcoin-git> bitcoin/master 1f50f0b MarcoFalke: Merge #21631: i2p: always check the return value of Sock::Wait() 21:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 21:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 21:18 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #21631: i2p: always check the return value of Sock::Wait() (master...SockWait_usage_fix) https://github.com/bitcoin/bitcoin/pull/21631 21:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 21:20 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 21:23 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 21:24 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 21:27 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 21:45 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 21:54 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 22:03 -!- jadi [~jadi@37.98.3.133] has joined #bitcoin-core-dev 22:24 -!- Mikaela1 [~Mikaela@217.146.82.202] has quit [Remote host closed the connection] 22:24 -!- smartineng [~Icedove@88.135.18.171] has joined #bitcoin-core-dev 22:24 -!- smartineng [~Icedove@88.135.18.171] has quit [Excess Flood] 22:31 -!- fradua [776794cc@119.103.148.204] has joined #bitcoin-core-dev 22:33 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds] 22:33 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 22:33 -!- smartineng [~Icedove@88.135.18.171] has joined #bitcoin-core-dev 22:37 -!- fradua [776794cc@119.103.148.204] has quit [Quit: Connection closed] 23:15 -!- spake [~spake@195.140.213.38] has joined #bitcoin-core-dev 23:17 < harding> wumpus: (re achow101's comment above) if you push the -unsigned.exe binary to Bitcoin.org, I think this should be the only change necessary for the website. https://github.com/bitcoin-dot-org/Bitcoin.org/compare/master...harding:2021-04-unsigned-url?expand=1 I don't have a dev environment setup for Bitcoin.org, so it's untested. 23:26 -!- jungly [~jungly@host-95-238-197-16.retail.telecomitalia.it] has joined #bitcoin-core-dev 23:34 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 23:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:35 < bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/1f50f0bb389a...f0b457212f98 23:35 < bitcoin-git> bitcoin/master b54b2e7 Sjors Provoost: Move external signer out of wallet module 23:35 < bitcoin-git> bitcoin/master b0db187 Sjors Provoost: ci: use --enable-external-signer instead of --with-boost-process 23:35 < bitcoin-git> bitcoin/master 88d4d5f Sjors Provoost: rpc: add help for enumeratesigners and walletdisplayaddress 23:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:36 < bitcoin-git> [bitcoin] fanquake merged pull request #21467: Move external signer out of wallet module (master...2021/03/signer_no_wallet) https://github.com/bitcoin/bitcoin/pull/21467 23:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:39 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 23:40 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 23:40 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 23:41 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 23:42 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev --- Log closed Tue Apr 13 00:00:24 2021