--- Log opened Thu Jun 03 00:00:28 2021
00:05 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev
00:07 -!- smartin [~Icedove@88.135.18.171] has joined #bitcoin-core-dev
00:46 -!- SenX [~textual@2600:1700:42f0:f60:c0f4:898b:4a73:14b1] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
00:57 -!- lkqwejhhgasdjhgn [~kljkljklk@p200300d46f03bc009e794642704b3134.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
00:59 -!- evias [~evias__@196.red-88-6-131.staticip.rima-tde.net] has joined #bitcoin-core-dev
00:59 -!- evias [~evias__@196.red-88-6-131.staticip.rima-tde.net] has quit [Changing host]
00:59 -!- evias [~evias__@user/evias] has joined #bitcoin-core-dev
01:15 -!- belcher_ [~belcher@user/belcher] has quit [Quit: Leaving]
01:15 -!- promag [~promag@188.250.84.129] has quit [Read error: Connection reset by peer]
01:15 -!- belcher [~belcher@user/belcher] has joined #bitcoin-core-dev
01:15 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
01:16 -!- belcher [~belcher@user/belcher] has quit [Remote host closed the connection]
01:17 -!- belcher [~belcher@user/belcher] has joined #bitcoin-core-dev
01:43 -!- LEI [~LEI@185.57.220.232] has joined #bitcoin-core-dev
01:45 -!- LEI [~LEI@185.57.220.232] has quit [Client Quit]
01:55 -!- kvs [~root@175.102.16.34] has joined #bitcoin-core-dev
01:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:59 < bitcoin-git> [gui] promag opened pull request #354: Refactor open date range to use std::optional (master...2021-06-date-range) https://github.com/bitcoin-core/gui/pull/354
01:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:04 -!- metta [~Advanced@2a01:4f8:1c0c:49df::1] has quit [Quit: metta]
02:05 -!- upekkha [~Advanced@2a01:4f8:1c0c:49df::1] has joined #bitcoin-core-dev
02:07 -!- kvs [~root@175.102.16.34] has left #bitcoin-core-dev [WeeChat 3.1]
02:15 -!- thedragon [~thedragon@user/thedragon] has quit [Read error: Connection reset by peer]
02:16 -!- thedragon [~thedragon@user/thedragon] has joined #bitcoin-core-dev
02:20 -!- orionwl[m] [~orionwlx0@2001:470:69fc:105::80] has quit [Ping timeout: 268 seconds]
02:21 -!- vincenzopalazzo [~vincenzop@2001:470:69fc:105::a67] has quit [Ping timeout: 244 seconds]
02:21 -!- dongcarl[m] [~dongcarlm@2001:470:69fc:105::82] has quit [Ping timeout: 244 seconds]
02:21 -!- kvaciral[m] [~kvaciralx@2001:470:69fc:105::17b] has quit [Ping timeout: 244 seconds]
02:21 -!- mrjumper[m] [~mr-jumper@2001:470:69fc:105::7f1] has quit [Ping timeout: 268 seconds]
02:21 -!- prusnak[m] [~stickmatr@2001:470:69fc:105::98c] has quit [Ping timeout: 272 seconds]
02:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:38 < bitcoin-git> [bitcoin] promag opened pull request #22136: Add --disable-rpc configure option (master...2021-06-disable-rpc) https://github.com/bitcoin/bitcoin/pull/22136
02:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:42 -!- evias [~evias__@user/evias] has quit [Quit: This computer has gone to sleep]
02:48 -!- evias [~evias__@196.red-88-6-131.staticip.rima-tde.net] has joined #bitcoin-core-dev
02:48 -!- evias [~evias__@196.red-88-6-131.staticip.rima-tde.net] has quit [Changing host]
02:48 -!- evias [~evias__@user/evias] has joined #bitcoin-core-dev
02:48 -!- evias [~evias__@user/evias] has quit [Client Quit]
02:54 -!- evias [~evias__@196.red-88-6-131.staticip.rima-tde.net] has joined #bitcoin-core-dev
02:54 -!- evias [~evias__@196.red-88-6-131.staticip.rima-tde.net] has quit [Changing host]
02:54 -!- evias [~evias__@user/evias] has joined #bitcoin-core-dev
02:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:55 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #22137: util: Properly handle -noincludeconf on command line (master...2106-utilTake2) https://github.com/bitcoin/bitcoin/pull/22137
02:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:01 -!- Netsplit *.net <-> *.split quits: elichai2, berndj, xycco, MarcoFalke, meshcollider, tripleslash, jnewbery, dr-orlovsky, warren, emzy,  (+7 more, use /NETSPLIT to show all of them)
03:04 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
03:11 -!- Netsplit over, joins: laanwj, warren, dr-orlovsky, meshcollider, nickler, berndj, tripleslash, FelixWeis, elichai2, kabaum (+7 more)
03:36 < jonasschnelli> #proposedmeetingtopic: Bitcoin Code Signing Association Switzerland
03:37 -!- thedragon [~thedragon@user/thedragon] has quit [Quit: Leaving]
03:40 < michaelfolkson> #proposedmeetingtopic Reviewing progress of fortnightly Core subsystem (P2P, wallet, GUI etc) meetings
03:45 -!- SenX [~textual@2600:1700:42f0:f60:c0f4:898b:4a73:14b1] has joined #bitcoin-core-dev
03:58 -!- orionwl[m] [~orionwlx0@2001:470:69fc:105::80] has joined #bitcoin-core-dev
04:09 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
04:12 -!- SenX [~textual@2600:1700:42f0:f60:c0f4:898b:4a73:14b1] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
04:37 -!- vincenzopalazzo [~vincenzop@2001:470:69fc:105::a67] has joined #bitcoin-core-dev
04:37 -!- dongcarl[m] [~dongcarlm@2001:470:69fc:105::82] has joined #bitcoin-core-dev
04:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:58 < bitcoin-git> [bitcoin] jonatack opened pull request #22138: script: fix spelling linter raising spuriously on "invokable" (master...fix-spurious-linter-spelling) https://github.com/bitcoin/bitcoin/pull/22138
04:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:10 -!- AaronvanW [~AaronvanW@207.200.214.109] has joined #bitcoin-core-dev
05:12 -!- kvaciral[m] [~kvaciralx@2001:470:69fc:105::17b] has joined #bitcoin-core-dev
05:13 -!- thedragon [~thedragon@user/thedragon] has joined #bitcoin-core-dev
05:30 -!- lightlike [~lightlike@user/lightlike] has joined #bitcoin-core-dev
05:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:37 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a9435e34457e...d331e262f5b2
05:37 < bitcoin-git> bitcoin/master 8050eb4 Jon Atack: script: fix spelling linter raising spuriously on "invokable"
05:37 < bitcoin-git> bitcoin/master d331e26 MarcoFalke: Merge bitcoin/bitcoin#22138: script: fix spelling linter raising spuriousl...
05:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:38 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #22138: script: fix spelling linter raising spuriously on "invokable" (master...fix-spurious-linter-spelling) https://github.com/bitcoin/bitcoin/pull/22138
05:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:40 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d331e262f5b2...6fe012c6bd6a
05:40 < bitcoin-git> bitcoin/master ab86ac7 Hennadii Stepanov: build, qt: Make QWindowsVistaStylePlugin available again (regression)
05:40 < bitcoin-git> bitcoin/master 6fe012c fanquake: Merge bitcoin/bitcoin#22133: build, qt: Make QWindowsVistaStylePlugin avai...
05:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:41 < bitcoin-git> [bitcoin] fanquake merged pull request #22133: build, qt: Make QWindowsVistaStylePlugin available again (regression) (master...210602-style) https://github.com/bitcoin/bitcoin/pull/22133
05:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:42 -!- AaronvanW [~AaronvanW@207.200.214.109] has quit [Remote host closed the connection]
05:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:44 < bitcoin-git> [bitcoin] fanquake opened pull request #22139: test: add type annotations to util.get_rpc_proxy (master...type_annotations_get_rpc_proxy) https://github.com/bitcoin/bitcoin/pull/22139
05:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:47 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net]
05:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:58 < bitcoin-git> [bitcoin] jonatack opened pull request #22140: p2p, refactor: remove unneeded CNetAddr::UnserializeV1Array() (master...p2p-remove-unused-UnserializeV1Array) https://github.com/bitcoin/bitcoin/pull/22140
05:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:02 -!- thedragon [~thedragon@user/thedragon] has quit [Ping timeout: 272 seconds]
06:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:05 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6fe012c6bd6a...fcfd37f3f9dc
06:05 < bitcoin-git> bitcoin/master 3b36395 João Barbosa: depends: Fix qt.mk for mac arm64
06:05 < bitcoin-git> bitcoin/master fcfd37f fanquake: Merge bitcoin/bitcoin#22123: depends: Fix qt.mk for mac arm64
06:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:05 < bitcoin-git> [bitcoin] fanquake merged pull request #22123: depends: Fix qt.mk for mac arm64 (master...2021-06-fix-aarch64_darwin) https://github.com/bitcoin/bitcoin/pull/22123
06:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:06 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
06:08  * fanquake requests an embargo on future Qt PRs
06:08 < hebasto> fanquake: accepted
06:11 < promag> fanquake: you mean just on depends?
06:11 < hebasto> promag: https://github.com/bitcoin/bitcoin/pull/21589#issuecomment-853847289
06:12 < fanquake> promag: yes. Although I'm just being selfish, and trying to save myself rebase hassle
06:12 -!- thedragon [~thedragon@user/thedragon] has joined #bitcoin-core-dev
06:12 < fanquake> Will open a (mostly working) draft PR shortly that will explain
06:14 < promag> ah kk
06:14 < hebasto> fanquake: will it solve the problem  #20641 aims to solve?
06:14 <@gribble> https://github.com/bitcoin/bitcoin/issues/20641 | depends: Use Qt top-level build facilities by hebasto · Pull Request #20641 · bitcoin/bitcoin · GitHub
06:15 < laanwj> right just on build system ones, not GUI changes in general
06:15 < fanquake> It's not super clear to me what that PR is trying to achieve. Although I don't think these changes would make it any less possible
06:15 < promag> since you are around, what you think about --disable-rpc? (or similar)
06:15 < hebasto> fanquake: "integrate new modules into static builds"
06:16 < fanquake> Sure, but what new modules do we need?
06:16 < laanwj> because this is the right moment to merge last-minute GUI change PRs, before the translation freeze
06:16 < hebasto> fanquake: QML, ofc
06:17 < fanquake> That seems like a much larger discussion, which needs good motivation, and buy in from multiple devs, before we worry about hacking up the builds system to support it
06:17 < laanwj> i don't see a point for --disable-rpc, why increase compile time complexity?
06:17 < fanquake> I also have very little interest in rewriting our GUI in a new language.
06:19 < laanwj> all the different compile-time combinatorial complexity makes it really hard to cover all possibilities, they all take work to maintain
06:19 < promag> laanwj: be able to build without support for rpc - build for mobile for instance
06:19 < laanwj> fanquake: it's not like you need to do that :)
06:19 < hebasto> oh, it seems you missed the Project Horizon presentation :)
06:19 < laanwj> promag: why wouldn't rpc be useful on mobile?
06:20 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Quit: Leaving]
06:20 < laanwj> it's not like the RPC code is large compared to anything else, if you're going the 'embeddes sytsems need to minimize code' angle
06:20 < hebasto> QML seems the right way to lure designers into the GUI development
06:20 < promag> laanwj: just a way to be on the safe side?
06:20 < laanwj> the safe side of what?
06:21 < laanwj> just run with server=0 if you don't want to open a RPC port
06:21 < laanwj> even more, even the GUI needs most of the RPC code because of the debug console
06:23 < promag> laanwj: ok, didn't think of that 
06:24 < hebasto> one of the QML use case right now is #16883
06:24 <@gribble> https://github.com/bitcoin/bitcoin/issues/16883 | WIP: Qt: add QML based mobile GUI by icota · Pull Request #16883 · bitcoin/bitcoin · GitHub
06:24 < promag> laanwj: actually the RPC code seems to be already well split
06:24 < laanwj> but i don't see why RPC would be a bad thing inherently on mobile, sure, access control works differently, but you might still want to give other applications access in some cases-or even use the cli through somethig like termux
06:24 -!- orionwl[m] [~orionwlx0@2001:470:69fc:105::80] has quit [Quit: node-irc says goodbye]
06:24 -!- vincenzopalazzo [~vincenzop@2001:470:69fc:105::a67] has quit [Quit: node-irc says goodbye]
06:24 -!- dongcarl[m] [~dongcarlm@2001:470:69fc:105::82] has quit [Quit: node-irc says goodbye]
06:24 -!- kvaciral[m] [~kvaciralx@2001:470:69fc:105::17b] has quit [Quit: node-irc says goodbye]
06:25 -!- orionwl[m] [~orionwlx0@2001:470:69fc:105::80] has joined #bitcoin-core-dev
06:26 < promag> laanwj: we can build with --disable-wallet  think its reasonable to to have the
06:26 < promag> same thing for rpc
06:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:26 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fcfd37f3f9dc...8837f1ebde05
06:26 < bitcoin-git> bitcoin/master a58868d Hennadii Stepanov: build: Makes rcc output always deterministic
06:26 < bitcoin-git> bitcoin/master 8837f1e fanquake: Merge bitcoin/bitcoin#21654: build, qt: Make Qt rcc output always determin...
06:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:26 < bitcoin-git> [bitcoin] fanquake merged pull request #21654: build, qt: Make Qt rcc output always deterministic (master...210411-rcc) https://github.com/bitcoin/bitcoin/pull/21654
06:26 < promag> but I agree it shouldn't add burden
06:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:26 < laanwj> i really don't like that but anyhow
06:27 < promag> what? the option? or to maintain the option?
06:27 < laanwj> both
06:27 < promag> so just use runtime control
06:27 < laanwj> i think both run-time and compile-time configurability of bitcoind is getting out of hand, and i see this specific change as a good example of something that isn't really needed
06:27 < laanwj> yes
06:28 -!- vincenzopalazzo [~vincenzop@2001:470:69fc:105::a67] has joined #bitcoin-core-dev
06:28 -!- prusnak[m] [~stickmatr@2001:470:69fc:105::98c] has joined #bitcoin-core-dev
06:28 < promag> i guess you also dont like --without-libevent
06:28 < laanwj> we already disable RPC by default in bitcoin-qt iirc, and have always done so
06:28 -!- kvaciral[m] [~kvaciralx@2001:470:69fc:105::17b] has joined #bitcoin-core-dev
06:28 -!- dongcarl[m] [~dongcarlm@2001:470:69fc:105::82] has joined #bitcoin-core-dev
06:28 -!- mrjumper[m] [~mr-jumper@2001:470:69fc:105::7f1] has joined #bitcoin-core-dev
06:28 < laanwj> for fact, no, i don't
06:29 < laanwj> but that's mostly because the original plan for libevent was to use it for P2P as well
06:29 < promag> ok, I'll close the draft
06:29 < laanwj> nothing happened with that so i feel less strongly about that now
06:29 < promag> oh really?
06:30 < promag> fanquake: who said rewrite gui?
06:30 < laanwj> libevent's http server isn't *that* great, but also, no way we want to implement and maintain our own
06:30 < fanquake> My assumption is that if people want a new language to write the gui in, which is what I  understand qml to be, we would be rewriting
06:30 < fanquake> god forbid we end up with 2 guis
06:31 -!- ksprd2 [~ksprd@dfe52.neoplus.adsl.tpnet.pl] has joined #bitcoin-core-dev
06:32 < hebasto> 2 guis seems awful 
06:32 < laanwj> it could make sense for a transitional phase but yea...
06:32 < fanquake> 2 guis actually being 6 or 8, or maybe 10+ by the time you take into various platforms and runtime modes and etc etc
06:33 < laanwj> i don't disagree with the point that qt widgets is basically dead, development-wise, and QML is (with regard to Qt) the future
06:34 < fanquake> It's also unclear how easy a transition to qt 6 is going to be. Given they've seemingly thrown support for autotools /  pkg-config out the window
06:34 < hebasto> the idea is to implement Bitcoin Design Guide ideas in new widgets with QML, making transition on widget/window base
06:34 < fanquake> If we want to move to 5.15, we'll need to start maintaining x libs in depends, because at that version qt is no longer bundling them in tree
06:35 < hebasto> is reverting back  pkg-config  support in Qt6 plans?
06:35 < laanwj> wait, they removed pkg-config support? oh no... that's another boost level monstriosity
06:35 < fanquake> https://bugreports.qt.io/browse/QTBUG-86080
06:36 < fanquake> "Somewhat important", but doesn't seem to have any sort of priority
06:36 < laanwj> it's so nice to be able to use pkg-config instead of manually scanning the system in the configure scripts (like we have to do for boost, often failing)
06:37 < laanwj> well, let's stick with qt5 at least until that is fixed
06:38 < laanwj> i wonder what they suggest autotools-based projects *do*, is cmake the only option now?
06:38 < promag> regardless I'll be working on qml gui, fork is fine to me and lack of qml in depends isn't a blocker
06:38 < laanwj> promag: qml + qt5 is fine with me
06:38 < promag> laanwj: yup they went cmake
06:38 < hebasto> qt 5.15 is, actually, qt 6.beta, so there could be less benefits to move to qt 5.15
06:39 < promag> re qt6 I'm just waiting to 6.2
06:40 < promag> qtquick controls still lacks lots of features compared to qt widgets
06:40 < laanwj> there is no direct mapping, no
06:40 < promag> treeview and tableviews suck
06:41 < hebasto> promag: re "qml in depends isn't a blocker" -- compiling only with system packages?
06:42 < promag> hebasto: yes - why do we want qml now in depends?
06:42 < laanwj> fwiw i also maintained the qt based GUI as a fork for a fair while before it was merged upstream
06:42 < promag> laanwj: exactly
06:43 < laanwj> though we might want to limit changes to the interface for a while
06:43 < hebasto> promag: to make standard guix releases
06:43 < laanwj> so it's less of a rebase nightmare
06:43 < promag> same thing ryanofsky is doing with multiprocess
06:44 -!- thedragon [~thedragon@user/thedragon] has quit [Quit: Leaving]
06:44 < hebasto> promag: have you the QML fork already?
06:44 < laanwj> (that was no option at the time because the GUI and core were joined at the hip, there's better separation now)
06:44 < promag> hebasto: no :)
06:46 < hebasto> laanwj: what are drawbacks if QML fork of the GUI will live under bitcoin-core?
06:46 -!- ksprd3 [~ksprd@dhd218.neoplus.adsl.tpnet.pl] has joined #bitcoin-core-dev
06:48 -!- ksprd2 [~ksprd@dfe52.neoplus.adsl.tpnet.pl] has quit [Ping timeout: 244 seconds]
06:48 < laanwj> hebasto: do you prefer a new repository or is a branch of the existing gui repository ok?
06:50 < hebasto> a dedicated branch in the current GUI repo should be fine; promag what do you think?
06:51 -!- devrandom[m] [~devrandom@2001:470:69fc:105::d4d] has joined #bitcoin-core-dev
06:52 < hebasto> won't it break the interaction between the GUI and the main repos?
06:52 < laanwj> you would have to be more careful in that case with force-pushes and rebases
06:52 -!- devrandom[m] is now known as devrandom
06:53 < laanwj> wouldn't want to overwrite the master branch accidentally
06:53 < hebasto> right
06:53 < laanwj> but no, in principle there is no reason why branches in the bitcoin-core/gui repo would interfere with anything in bitcoin/bitccoin
06:54 < fanquake> Yes, please nothing that's is going to interfere with the actual repo, or generate any more commits then the GUI repo already does etc.
06:54 < promag> only reason for another repo is to have different maintainers
06:54 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net]
06:56 < laanwj> better to create a new repo then maybe
06:56 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
06:56 < hebasto> ^ ok
06:56 -!- vnogueira [~vnogueira@user/vnogueira] has joined #bitcoin-core-dev
06:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:57 < bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/8837f1ebde05...907d636e5e76
06:57 < bitcoin-git> bitcoin/master 985430d Russell Yanofsky: test: Add gui test for wallet receive requests
06:57 < bitcoin-git> bitcoin/master 62252c9 Russell Yanofsky: interfaces: Stop exposing wallet destdata to gui
06:57 < bitcoin-git> bitcoin/master f5ba424 Russell Yanofsky: wallet: Add IsAddressUsed / SetAddressUsed methods
06:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:58 < bitcoin-git> [bitcoin] laanwj merged pull request #21353: interfaces: Stop exposing wallet destdata to gui (master...pr/nodestg) https://github.com/bitcoin/bitcoin/pull/21353
06:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:58 < laanwj> gah i can't even fork gui into a new project under bitcoin-core
06:58 < fanquake> I'm happy for anyone to experiment, but certainly not at the expense of frequent code churn, notification noise, etc etc for the actual repo.
06:58 < laanwj> *sigh* github
06:58 < laanwj> fanquake: yes, agree
06:58 < fanquake> Given recent dicussions / interactions on the GUI repo, I'm very happy that we've got it split out
06:59 < laanwj> fanquake: same
06:59 < laanwj> it just makes sense, the *kind* of discussion is very different
07:02 < hebasto> laanwj: re "gah i can't even fork gui into a new project under bitcoin-core" -- could this be worked around?
07:03 < laanwj> hebasto: yes, i think if you fork it, rename it, and then move the project to bitcoin-core you can work around it
07:03 < promag> fanquake: +1 thats why I said fork originally 
07:05 < laanwj> alternatively i can fork it from bitcoin/bitcoin that might work buut it'd make less sense semantically, or maybe create a new repo without 'forked from' connection but that has other drawbacks, github is silly in that way
07:08 < hebasto> I don't think github let me fork the repo that is already forked under the same username
07:08 < laanwj> AHHH of couuurse you're right
07:10 < laanwj> maybe i can fork it into an organization that doesn't have a fork of bitcoin yet and do the trick
07:10 < hebasto> hope you will success
07:11 < laanwj> "bitcoin-core already has a repository in the bitcoin-core/gui network" gah
07:11 < laanwj> at least i trieeed
07:13 < hebasto> laanwj: re "create a new repo without 'forked from' connection but that has other drawbacks" -- what drawbacks?
07:13 < laanwj> you can't create a PR directly in that case
07:14 < laanwj> nor can other people with a fork of the existing repo send you PRs
07:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:14 < bitcoin-git> [bitcoin] promag closed pull request #22136: Add --disable-rpc configure option (master...2021-06-disable-rpc) https://github.com/bitcoin/bitcoin/pull/22136
07:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:16 -!- sagi [~sagi@bzq-79-178-136-188.red.bezeqint.net] has quit [Ping timeout: 244 seconds]
07:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:18 < bitcoin-git> [bitcoin] jnewbery opened pull request #22141: net processing: Remove hash and fValidatedHeaders from QueuedBlock (master...2021-06-blocks-in-flight) https://github.com/bitcoin/bitcoin/pull/22141
07:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:18 < hebasto> I think they are acceptable, wrt github restrictions
07:20 < laanwj> fanquake: regarding qt dependencies we already have the 'problem' that the release binaries don't support wayland (#19950), due to our static linkage of qt (not that there's any good alternative)
07:20 <@gribble> https://github.com/bitcoin/bitcoin/issues/19950 | [Linux] Add wayland support · Issue #19950 · bitcoin/bitcoin · GitHub
07:20 < laanwj> hebasto: ok, what would you like the repo to be called, gui-qml?
07:20 < hebasto> lgtm
07:25 < hebasto> laanwj: thanks!
07:28 < laanwj> hebasto: it's set up, same permissions as for gui, let me know if you need anything else
07:40 < promag> github ninja
07:45 < laanwj> hehe
07:45 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
07:47 -!- jonatack [jonatack@user/jonatack] has joined #bitcoin-core-dev
07:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:48 < bitcoin-git> [bitcoin] fanquake opened pull request #22142: [WIP] build: split depends Qt into native and target builds (master...split_qt_again) https://github.com/bitcoin/bitcoin/pull/22142
07:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:02 -!- GIANTWORLDKEEPER [~pjetcetal@2.95.204.25] has quit [Read error: Connection reset by peer]
08:05 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
08:05 -!- GIANTWORLDKEEPER [~pjetcetal@2.95.204.25] has joined #bitcoin-core-dev
08:07 -!- martinus [~martinus@046125249061.public.t-mobile.at] has joined #bitcoin-core-dev
08:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:12 < bitcoin-git> [bitcoin] laanwj closed pull request #21760: Add -flushwalletinterval command line arg (master...flushwalletinterval) https://github.com/bitcoin/bitcoin/pull/21760
08:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:19 < bitcoin-git> [bitcoin] jonatack opened pull request #22143: p2p: pass spans in CNetAddr by reference to const (master...netaddress-pass-spans-by-reference-to-const) https://github.com/bitcoin/bitcoin/pull/22143
08:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:20 -!- tripleslash [~triplesla@50.225.175.210] has quit [Remote host closed the connection]
08:21 -!- tripleslash [~triplesla@50.225.175.210] has joined #bitcoin-core-dev
08:21 -!- tripleslash [~triplesla@50.225.175.210] has quit [Changing host]
08:21 -!- tripleslash [~triplesla@user/tripleslash] has joined #bitcoin-core-dev
08:21 -!- tripleslash [~triplesla@user/tripleslash] has quit [Remote host closed the connection]
08:22 -!- tripleslash [~triplesla@user/tripleslash] has joined #bitcoin-core-dev
08:29 -!- lkqwejhhgasdjhgn [~kljkljklk@p200300d46f03bc009e794642704b3134.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!]
08:57 -!- thedragon [~thedragon@user/thedragon] has joined #bitcoin-core-dev
09:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:03 < bitcoin-git> [bitcoin] jonatack closed pull request #22143: p2p: pass spans in CNetAddr by reference to const (master...netaddress-pass-spans-by-reference-to-const) https://github.com/bitcoin/bitcoin/pull/22143
09:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:44 < bitcoin-git> [bitcoin] laanwj pushed 14 commits to master: https://github.com/bitcoin/bitcoin/compare/907d636e5e76...07ededa30c94
09:44 < bitcoin-git> bitcoin/master 0f1c58a Jon Atack: test: update feature_proxy to torv3
09:44 < bitcoin-git> bitcoin/master f8e9400 Jon Atack: p2p: remove torv2/ADDR_TORV2_SIZE from SetTor()
09:44 < bitcoin-git> bitcoin/master c56a1c9 Jon Atack: p2p: drop onions from IsAddrV1Compatible(), no longer relay torv2
09:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:44 < bitcoin-git> [bitcoin] laanwj merged pull request #22050: p2p: remove tor v2 support (master...torv2-remove-support) https://github.com/bitcoin/bitcoin/pull/22050
09:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:46 < achow101> are we going to do 0.20.2rc2?
09:47 < sipa> do we have tor v3 support in 0.20?
09:47 < sipa> i forget if it was 0.20 or 0.21
09:48 < achow101> I think that was 0.21
09:48 < sipa> indeed,  0.21
09:52 < sipa> that's kind of unfortunate if we want to do a new 0.20 release
09:52 < achow101> is it hard to backport torv3?
09:52 < sipa> it means backporting bip155
09:52 < laanwj> not sure how big of a problem it is, people can still use tor, just not hidden services
09:53 < sipa> that's fair, we can get away by putting it in the release notes
09:53 < laanwj> i expect it would be an awful lot of work to backport
09:53 < laanwj> p2p code changed a lot since
09:53 < laanwj> for something that is going to see very little testing
09:54 < sipa> good point, yes
09:54 < sipa> it was half a dozen PRs probably
09:55 < laanwj>  as for 0.20.2rc2, sure, let's do that
09:56 < sipa> at least PRs 19360 19534 19841 19845 19628 20119 19954 20564 20661
09:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:58 < bitcoin-git> [bitcoin] laanwj pushed tag v0.20.2rc2: https://github.com/bitcoin/bitcoin/commit/5d2ebdd2b71f
09:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:58 < laanwj> ^^
10:09 -!- SenX [~textual@2600:1700:42f0:f60:c0f4:898b:4a73:14b1] has joined #bitcoin-core-dev
10:26 -!- SenX [~textual@2600:1700:42f0:f60:c0f4:898b:4a73:14b1] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
10:27 -!- SenX [~textual@2600:1700:42f0:f60:c0f4:898b:4a73:14b1] has joined #bitcoin-core-dev
10:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:35 < bitcoin-git> [bitcoin] sipa opened pull request #22144: Randomize message processing peer order (master...202106_rand_peers) https://github.com/bitcoin/bitcoin/pull/22144
10:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:37 -!- Kiminuo [~Kiminuo@70.151.broadband3.iol.cz] has joined #bitcoin-core-dev
10:37 -!- Kiminuo58 [~Kiminuo@141.98.103.92] has joined #bitcoin-core-dev
10:41 -!- Kiminuo [~Kiminuo@70.151.broadband3.iol.cz] has quit [Ping timeout: 264 seconds]
10:47 -!- upekkha is now known as metta
11:06 -!- martinus [~martinus@046125249061.public.t-mobile.at] has quit [Remote host closed the connection]
11:15 -!- ksprd3 [~ksprd@dhd218.neoplus.adsl.tpnet.pl] has quit [Ping timeout: 272 seconds]
11:21 -!- ksprd3 [~ksprd@dfq101.neoplus.adsl.tpnet.pl] has joined #bitcoin-core-dev
11:26 -!- ksprd3 [~ksprd@dfq101.neoplus.adsl.tpnet.pl] has quit [Ping timeout: 272 seconds]
11:27 < Kiminuo58> laanwj: Thank you for having a look at https://github.com/bitcoin/bitcoin/pull/21422. A silly question - why clang 13? It's not even released yet, is it?
11:35 -!- ksprd3 [~ksprd@public-gprs385937.centertel.pl] has joined #bitcoin-core-dev
11:37 -!- ksprd3 [~ksprd@public-gprs385937.centertel.pl] has quit [Read error: Connection reset by peer]
11:50 -!- SenX [~textual@2600:1700:42f0:f60:c0f4:898b:4a73:14b1] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
11:52 -!- ksprd3 [~ksprd@public-gprs385937.centertel.pl] has joined #bitcoin-core-dev
11:57 -!- thedragon [~thedragon@user/thedragon] has quit [Quit: Leaving]
12:02 < laanwj> #startmeeting
12:02 < core-meetingbot> Meeting started Thu Jun  3 19:02:03 2021 UTC.  The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
12:02 < core-meetingbot> Available commands: action commands idea info link nick
12:02 < jonasschnelli> hi
12:02 < hebasto> hi
12:02 < kvaciral[m]> hi
12:02 < michaelfolkson> hi
12:02 < sipa> hi
12:02 < laanwj> Kiminuo58: correct, one of my builds uses clang from git, I'm not sure the error happens with other versions I thought I'd note it because it completely blocks compilation
12:03 < laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos
12:03 < laanwj> nehan NicolasDorier paveljanik petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild
12:03 < achow101> hi
12:03 < jonatack> hi
12:03 < darosior> hi
12:03 < jarolrod> Hi
12:03 < laanwj> two proposed meeting topics for today: Bitcoin Code Signing Association Switzerland (jonasschnelli), Reviewing progress of fortnightly Core subsystem (P2P, wallet, GUI etc) meetings (michaelfolkson)
12:04 < laanwj> any last minute ideas for topics?
12:04 < laanwj> #topic High priority for review
12:04 < core-meetingbot> topic: High priority for review
12:05 < laanwj> https://github.com/bitcoin/bitcoin/projects/8   currently has 11 blockers, 0 bugfixes, 0 chasing concept ACK
12:05 < laanwj> anything to add/remove or that is ready for merge?
12:05 < dongcarl> Would like to add #21866, where we say farewell to global chainman
12:05 <@gribble> https://github.com/bitcoin/bitcoin/issues/21866 | [Bundle 7/7] validation: Farewell, global Chainstate! by dongcarl · Pull Request #21866 · bitcoin/bitcoin · GitHub
12:05 < achow101> #22051 has 4 acks
12:05 <@gribble> https://github.com/bitcoin/bitcoin/issues/22051 | Basic Taproot derivation support for descriptors by sipa · Pull Request #22051 · bitcoin/bitcoin · GitHub
12:06 < laanwj> we are getting close to the point where we need to prioritize what we still want to make into 0.22
12:06 < provoostenator> hi
12:06 < jonatack> pushed a (close-to-final?) big update to #21261, hoping it can be tagged/merged for v0.22
12:06 <@gribble> https://github.com/bitcoin/bitcoin/issues/21261 | p2p: update inbound eviction protection for multiple networks, add I2P peers by jonatack · Pull Request #21261 · bitcoin/bitcoin · GitHub
12:06 < laanwj> feature freeze is the 15th according to #20851
12:06 <@gribble> https://github.com/bitcoin/bitcoin/issues/20851 | Release schedule for 22.0 · Issue #20851 · bitcoin/bitcoin · GitHub
12:06 < laanwj> which is in less than two weeks
12:07 < jonatack> (been working on it behind the scenes these past weeks with helpful offline review feedback from vasild)
12:08 < laanwj> achow101: yes, that one seems ready for merge
12:08 < laanwj> dongcarl: added
12:08 < laanwj> jonatack: tagged for 22.0
12:09 < laanwj> anything else for high prio?
12:10 < laanwj> #topic Bitcoin Code Signing Association Switzerland (jonasschnelli)
12:10 < core-meetingbot> topic: Bitcoin Code Signing Association Switzerland (jonasschnelli)
12:10 < jonasschnelli> The swiss association is now officially registered
12:10 < laanwj> congrats!
12:10 < jonasschnelli> Which means we can get code signing certificates again
12:10 < laanwj> also for macosx?
12:10 < jonasschnelli> It comes with some maintenance costs as we needed a domicile... 
12:11 < jonasschnelli> macOS should be no problem
12:11 < jonasschnelli> (also the current macOS cert is still valid for a few months)
12:12 < laanwj> i guess we could use the coredev funds for that
12:12 < jonasschnelli> the question is, do we want to keep the swiss association or do we want to focus on the US LLC?
12:12 < jonasschnelli> agree with the coredev funds
12:12 < provoostenator> Maybe keep them both for a while?
12:12 < jonasschnelli> Yes. That's also what I thought provoostenator
12:12 < laanwj> yeah some redundancy couldn't hurt
12:12 < achow101> I think it makes sense to keep both as a backup
12:13 < jonasschnelli> okay... lets keep it and see when we might want to use it
12:13 < provoostenator> Can we have certificates from both at the same time too? (but only use one)
12:14 < achow101> I was also thinking we could alternate every year, so after say 9 months, try to get a cert using the other org. that would give us 3 months to work out any issues with getting a cert issued
12:15 < laanwj> that sounds sensible to me
12:16 < jonasschnelli> agree
12:17 < laanwj> #topic Reviewing progress of fortnightly Core subsystem meetings (michaelfolkson)
12:17 < core-meetingbot> topic: Reviewing progress of fortnightly Core subsystem meetings (michaelfolkson)
12:17 < michaelfolkson> So with the Libera transition I thought it would be a good point to discuss how the subsystem meetings are going, how they could be improved etc
12:18 < michaelfolkson> The P2P ones started with a really good format https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings
12:18 < michaelfolkson> But they've kind of run out of steam in recent weeks
12:18 < michaelfolkson> The wallet one appears to struggle with attendance a lot of the time (from what I've seen)
12:18 -!- sagi [~sagi@bzq-79-178-136-188.red.bezeqint.net] has joined #bitcoin-core-dev
12:19 < michaelfolkson> I like the idea of them, I personally would like to hear what people are working on but that's just me, sample size of 1
12:19 < michaelfolkson> Perhaps 2 weeks is too regular, come round too often. Do you think attendance would be better if they were monthly?
12:20 < michaelfolkson> I think there are GUI meetings on Jitsi or at least there were
12:20 < provoostenator> I don't often show up for wallet meetings, but when I do, I find them useful.
12:20 < laanwj> wouldn't this be better to discuss in those meetings themselves, with the people attending them?
12:20 < provoostenator> (or at least quick)
12:20 < achow101> I don't think having them more or less frequently would make that much of a difference
12:20 < achow101> it isn't that much effort to have a short meeting with little discussion
12:20 < michaelfolkson> laanwj: I guess but I thought it might be useful to compare notes
12:21 < jonatack> provoostenator: achow101: agree
12:21 < achow101> but it's still useful to have the meetings for when there are things to discuss
12:21 < michaelfolkson> achow101: I think the expectation that not many will attend means that other people don't bother
12:21 < provoostenator> I don't like the time of day, but timezones are just what they are: annoying.
12:21 < jarolrod> The “GUI” meetings on jitsi are not really core dev related
12:21 < jarolrod> I think it’s fair to say there are no GUI meetings
12:22 < achow101> michaelfolkson: I don't think that's necessarily true
12:22 < jonatack> the p2p ones are really late now for CET people, so e.g. vasild and i don't attend, but i get value from reading the meeting log the next day
12:22 < michaelfolkson> But ok I'll bring up in the subsystem meetings and see how we can encourage attendance, participation
12:22 < achow101> I think that frequently, it appears that few people are attending because no one speaks. but when there is actually something to discuss, there are many more people speaking than you may think
12:22 < michaelfolkson> As I said the P2P ones started really strongly but have lost steam in recent weeks
12:23 < achow101> I suspect many people just lurk with IRC open during the meetings
12:23 < michaelfolkson> With P2P contributors were posting on the dev wiki what they were working on but I don't think many people are bothering anymore
12:23 < michaelfolkson> I like the idea but you can't force people to do it
12:23 -!- Guest45 [~Guest45@91.98.166.114] has joined #bitcoin-core-dev
12:23 < laanwj> the libera migration was kind of brutal, maybe not everyone caught up yet
12:24 < michaelfolkson> Indeed, this week appears quiet with Libera and Miami
12:24 < michaelfolkson> But I think the trend started before then
12:24 < laanwj> in any case it's going to fluctuate 
12:24 < michaelfolkson> Ok thanks, I will bring up in the individual subsystem meetings.
12:24 -!- Guest45 [~Guest45@91.98.166.114] has quit [Client Quit]
12:24 < provoostenator> Even with low attendance the logs can be useful for later, so you can even just have a monologue :-)
12:24 < jonatack> the wallet meetings are cool as-is IMO :)
12:25 < michaelfolkson> Good to know the feedback, thanks
12:25 < laanwj> anecdotally i don't think doing the meeting less often results in higher attendance, if anything it makes people forget about it more :)
12:25 < jonatack> yup
12:25 < michaelfolkson> Ok leaving as is seems the preference
12:26 < laanwj> i think that concludes today's meeting
12:26 < laanwj> thanks everyone who still made it :)
12:26 < laanwj> #endmeeting
12:26 < core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
12:26 < core-meetingbot> Meeting ended Thu Jun  3 19:26:31 2021 UTC.  
12:26 < core-meetingbot> Minutes:        https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2021/bitcoin-core-dev.2021-06-03-19.02.moin.txt
12:27 < jonatack> o/ fare-thee-well, global chainstate
12:27 < laanwj> it was a long journey
12:29 -!- smartin [~Icedove@88.135.18.171] has quit [Quit: smartin]
12:30 -!- martinus [~martinus@046125249061.public.t-mobile.at] has joined #bitcoin-core-dev
12:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:59 < bitcoin-git> [bitcoin] laanwj pushed 10 commits to master: https://github.com/bitcoin/bitcoin/compare/07ededa30c94...c7dd9ff71b9c
12:59 < bitcoin-git> bitcoin/master 4b1cc08 Pieter Wuille: Make XOnlyPubKey act like byte container
12:59 < bitcoin-git> bitcoin/master 31df02a Pieter Wuille: Change Solver() output for WITNESS_V1_TAPROOT
12:59 < bitcoin-git> bitcoin/master 41839bd Pieter Wuille: Avoid dependence on CTxDestination index order
12:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:59 < bitcoin-git> [bitcoin] laanwj merged pull request #22051: Basic Taproot derivation support for descriptors (master...202105_taproot_derive) https://github.com/bitcoin/bitcoin/pull/22051
12:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:09 < hebasto> laanwj: update-translations.py informs about multiple format specifiers mismatches; what is the best way to inform translators about that?
13:19 < laanwj> hebasto: i don't know ... maybe a notification with a list in it of languages and messages affected
13:20 < laanwj> alternatively, if they're straightforward we could fix them ourselves
13:21 < hebasto> fix them ourselves on Transifex, right?
13:21 < laanwj> yes
13:21 < hebasto> ok, I'll try it
13:22 < laanwj> often it's something trivial like 4% instead of %4
13:23 < hebasto> you are right
13:23 < hebasto> how do right-to-left systems work?
13:27 -!- bomb-on [~bomb-on@194.144.47.113] has joined #bitcoin-core-dev
13:30 < laanwj> string index 0 is rightmost, index len-1 is leftmost
13:30 < luke-jr> pretty sure %4 still tho, not 4%
13:31 < hebasto> luke-jr: thanks
13:31 < sipa> well if your editor is LTR, i'd expect you'd see all strings in source code for RTL languages in reverse
13:31 < laanwj> it will still be %4 when displayed from left-to-right
13:31 < hebasto> most of mismatches are 4% for right-to-left systems
13:32 < laanwj> e.g. the % must have an index below the 4
13:32 < luke-jr> if you're looking at it RTL, it might look like 4% while being "4%" in byte order
13:32 < luke-jr> err "%4" in byte order
13:32 < laanwj> yes
13:34  * luke-jr wonders if the fileformat change enabled us to have translations marked "incomplete" on Transifex?
13:35 < laanwj> i guess theoretically the import script could automatically correct for this specific case when it knows (through some language db) whether it is right-to-left and left-to-right ... though it would be preferable if the translators simply learned to do it right
13:35 < luke-jr> I have a script for filling in missing translations based on close matches, but ideally we'd still want a translator to look over and approve (or retranslate) them
13:37 < hebasto> luke-jr: on transifex.com translation level for 22.x looks pretty high for active languages
13:38 < hebasto> so file format had no effect on translation status
13:38 < hebasto> but it dropped the "reviewed" status
13:40 < hebasto> is there a way on transifex to see if a language is RTL or LTR?
13:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:55 < bitcoin-git> [gui] hebasto opened pull request #355: qt: Avoid ambiguous interpreting of placeholders (master...210603-placeholder) https://github.com/bitcoin-core/gui/pull/355
13:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:59 -!- evias [~evias__@user/evias] has quit [Quit: This computer has gone to sleep]
14:03 < luke-jr> hebasto: IIRC % in format strings need to be replaced by % or such, not sure if that applies to Qt
14:21 -!- evias [~evias__@user/evias] has joined #bitcoin-core-dev
14:41 < nanotube> btw, the website still seems to point to freenode irc (e.g., at the bottom here: https://bitcoincore.org/en/2021/05/01/release-0.21.1/ ). not sure if someone wants to update it to point to libera.
14:55 -!- Kiminuo58 [~Kiminuo@141.98.103.92] has quit [Ping timeout: 272 seconds]
15:01 < harding> nanotube: yeah, I think we decided here https://github.com/bitcoin-core/bitcoincore.org/pull/778#issue-651534929 not to change historical documents like release blogs.
15:04 < nanotube> harding: ok sounds reasonable, just making sure it was not forgotten. :)
15:10 < hebasto> laanwj: luke-jr: jonasschnelli: may I ask you to look into https://github.com/bitcoin-core/gui/issues/356?
15:26 < luke-jr> looks straightforwardish. kinda surprised it isn't a standard check though
15:29 -!- AaronvanW [~AaronvanW@74.212.158.196] has joined #bitcoin-core-dev
15:41 -!- bomb-on [~bomb-on@194.144.47.113] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
15:43 < luke-jr> hebasto: enabled for XLIFF only as a warning for now
15:43 < hebasto> luke-jr: thanks
15:44 < luke-jr> hebasto: is there one I can look at to verify it worked?
15:44 < hebasto> let me see...
15:45 < luke-jr> looking at a random one, it looks like the placeholders appear like that %1% you thought was a problem
15:46 < luke-jr> and now the %1% looks sane
15:47 < hebasto> luke-jr: lang Malayalam, 22.x, id 120
15:48 < hebasto> looks great
15:48 < luke-jr> hmm, I don't see the warning on it when I view
15:49 < hebasto> place holder is well-formed, but no warnings
15:49 < hebasto> maybe raise level to "error"?
15:50 < luke-jr> I removed the extra space on the end and saved, then the warning showed
15:50 < luke-jr> so I guess it just didn't re-check existing stuff
15:51 < hebasto> hmm, warning could be ignored
15:51 < luke-jr> I assume that's the difference between error and warning
15:51 < hebasto> even deleted -- https://docs.transifex.com/translation-checks/introduction-to-translation-checks#section-deleting-warnings
15:52 < luke-jr> but hopefully translators aren't going to do that? :P
15:52 < hebasto> what are drawbacks if level will be set to "error"?
15:52 < luke-jr> I guess if I made a mistake it might be more annoying
15:53 < hebasto> isn't not merging wrong translated string into the release more annoying?
15:53 < luke-jr> we already have a check for that
15:54 < hebasto> our check just ignore such strings without any feedback to translators
15:54 < luke-jr> I don't feel strongly about whether it's error or warning
15:54 < luke-jr> well, translators get preemptive feedback now ☺
15:54 < hebasto> right, let see how it will be used by them
15:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:58 < bitcoin-git> [gui] hebasto closed pull request #355: qt: Avoid ambiguous interpreting of placeholders (master...210603-placeholder) https://github.com/bitcoin-core/gui/pull/355
15:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
16:02 -!- SenX [~textual@2600:1700:42f0:f60:c0f4:898b:4a73:14b1] has joined #bitcoin-core-dev
16:07 -!- AaronvanW [~AaronvanW@74.212.158.196] has quit [Remote host closed the connection]
16:39 -!- SenX [~textual@2600:1700:42f0:f60:c0f4:898b:4a73:14b1] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
17:16 -!- lightlike [~lightlike@user/lightlike] has quit [Quit: Leaving]
17:18 < hebasto> something strange with github right now -- cannot checkout the latest `v0.20.2rc2` tag
17:18 < sipa> git fetch -t upstream ?
17:19 < hebasto> ah, `-t`-- yes, thank you
17:20 < hebasto> should go sleep, certainly 
17:22 < hebasto> sipa: but usually `fetch` fetched tags without `-t`...
17:27 < achow101> I ran into that problem too. usually fetch fetches tags but for some reason it didn't today
17:27 < hebasto> is this tag a lightweight one?
17:29 < hebasto> oh, I found out -- https://github.com/bitcoin/bitcoin/commit/5d2ebdd2b71fadfcbadc32d074c83e1ff92043b5 does not belong to the 0.20 branch
17:30 < achow101> ah, so laanwj forgot to push the branch itself
17:42 -!- evias [~evias__@user/evias] has quit [Quit: This computer has gone to sleep]
18:04 -!- jarthur [~jarthur@2603-8080-1540-002d-7c3e-5f85-a09f-91e1.res6.spectrum.com] has quit [Quit: jarthur]
18:17 -!- SenX [~textual@2600:1700:42f0:f60:c0f4:898b:4a73:14b1] has joined #bitcoin-core-dev
20:29 -!- SenX [~textual@2600:1700:42f0:f60:c0f4:898b:4a73:14b1] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
20:30 -!- ksprd3 [~ksprd@public-gprs385937.centertel.pl] has quit [Ping timeout: 264 seconds]
20:38 < jarolrod> has boost been taking a long time to download using depends recently or is it just me
20:56 -!- ksprd3 [~ksprd@public-gprs385937.centertel.pl] has joined #bitcoin-core-dev
21:33 -!- belcher_ [~belcher@user/belcher] has joined #bitcoin-core-dev
21:36 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 245 seconds]
22:00 -!- ksprd3 [~ksprd@public-gprs385937.centertel.pl] has quit [Ping timeout: 272 seconds]
22:14 -!- ksprd3 [~ksprd@public-gprs385937.centertel.pl] has joined #bitcoin-core-dev
22:19 -!- ksprd3 [~ksprd@public-gprs385937.centertel.pl] has quit [Ping timeout: 245 seconds]
22:22 -!- vnogueira [~vnogueira@user/vnogueira] has quit [Ping timeout: 252 seconds]
22:26 < martinus> ankerl
22:26 -!- martinus [~martinus@046125249061.public.t-mobile.at] has quit [Quit: Leaving]
22:29 -!- vnogueira [~vnogueira@user/vnogueira] has joined #bitcoin-core-dev
22:33 -!- ksprd3 [~ksprd@public-gprs385937.centertel.pl] has joined #bitcoin-core-dev
22:36 -!- smartin [~Icedove@88.135.18.171] has joined #bitcoin-core-dev
22:39 -!- ksprd3 [~ksprd@public-gprs385937.centertel.pl] has quit [Ping timeout: 265 seconds]
22:40 -!- vnogueira [~vnogueira@user/vnogueira] has quit [Remote host closed the connection]
22:42 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has joined #bitcoin-core-dev
22:52 -!- ksprd3 [~ksprd@public-gprs385937.centertel.pl] has joined #bitcoin-core-dev
22:58 -!- ksprd3 [~ksprd@public-gprs385937.centertel.pl] has quit [Ping timeout: 272 seconds]
23:08 -!- davterra [~davterra@178.128.106.205] has quit [Ping timeout: 245 seconds]
23:15 -!- ksprd3 [~ksprd@public-gprs385937.centertel.pl] has joined #bitcoin-core-dev
23:16 -!- vnogueira [~vnogueira@user/vnogueira] has joined #bitcoin-core-dev
23:19 -!- ksprd3 [~ksprd@public-gprs385937.centertel.pl] has quit [Ping timeout: 245 seconds]
23:26 -!- Guest32 [~Guest32@cpc157823-brnt5-2-0-cust196.4-2.cable.virginm.net] has joined #bitcoin-core-dev
23:26 -!- Guest32 [~Guest32@cpc157823-brnt5-2-0-cust196.4-2.cable.virginm.net] has left #bitcoin-core-dev []
23:31 -!- ksprd3 [~ksprd@public-gprs385937.centertel.pl] has joined #bitcoin-core-dev
23:37 -!- ksprd3 [~ksprd@public-gprs385937.centertel.pl] has quit [Ping timeout: 245 seconds]
23:51 -!- ksprd3 [~ksprd@public-gprs385937.centertel.pl] has joined #bitcoin-core-dev
23:56 -!- ksprd3 [~ksprd@public-gprs385937.centertel.pl] has quit [Ping timeout: 264 seconds]
23:59 -!- Kiminuo [~Kiminuo@141.98.103.92] has joined #bitcoin-core-dev
--- Log closed Fri Jun 04 00:00:28 2021