--- Log opened Thu Feb 24 00:00:08 2022
00:02 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has quit [Ping timeout: 260 seconds]
00:04 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has joined #bitcoin-core-dev
00:08 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has quit [Ping timeout: 245 seconds]
00:10 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has joined #bitcoin-core-dev
00:14 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
00:20 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
00:20 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
00:24 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
00:27 < laanwj> luke-jr: i think the reasoning was that including a bit of code from libgcc in the release binary was the same as statically linking libgcc, which we already do; of course IANAL and i'm happy we've got rid of that
00:28 < laanwj> luke-jr: that said, for GPL compliance, i'm happy to provide a copy of the source code upon request, either digitally or through floppies in the mail (there might be some costs and delays involved)
00:28 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
00:29 -!- hashfuncc47 [~user@2601:5c0:c280:7090:78e9:5f82:1899:8c96] has joined #bitcoin-core-dev
00:31 < laanwj> in the longer run static linking against musl libc and using clang will end any potential legal uncertanties around static building against libgcc (though i'm pretty sure we're in the clear)
00:34 < laanwj> "The libgcc library is licensed under the GNU GPL plus the GCC Runtime Library Exception (see COPYING.RUNTIME in your gcc source tree). This roughly means that you are allowed to link in libgcc into your software even if it would normally violate the GNU GPL, as long as you used a non-proprietary version of GCC."
00:41 < laanwj> no proprietary blob of any kind is involved in our build process *apart from apple SDK* which is used for the MacOS builds only, that build uses clang anyway, and there was never any libgcc code in that
01:00 -!- hashfuncc47 [~user@2601:5c0:c280:7090:78e9:5f82:1899:8c96] has quit [Ping timeout: 240 seconds]
01:09 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
01:13 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 256 seconds]
01:13 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has quit [Ping timeout: 256 seconds]
01:15 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has joined #bitcoin-core-dev
01:17 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
01:17 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
01:20 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
01:20 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
01:21 < fanquake> yes musl + clang is something I plan on looking at soon
01:24 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 256 seconds]
01:24 -!- mikehu44_ [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev
01:32 -!- jespada [~jespada@148.252.133.112] has joined #bitcoin-core-dev
01:37 -!- bomb-on [~bomb-on@194.144.47.113] has joined #bitcoin-core-dev
01:42 -!- Saloframes [~Saloframe@user/Saloframes] has quit [Ping timeout: 272 seconds]
01:45 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
01:52 -!- Saloframes [~Saloframe@user/Saloframes] has joined #bitcoin-core-dev
01:55 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
02:03 -!- kexkey [~kexkey@static-198-54-132-85.cust.tzulo.com] has quit [Ping timeout: 240 seconds]
02:04 -!- kexkey [~kexkey@static-198-54-132-101.cust.tzulo.com] has joined #bitcoin-core-dev
02:09 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 250 seconds]
02:11 < laanwj> ^^
02:15 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
02:15 -!- rex4539_ [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev
02:15 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
02:15 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
02:16 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
02:17 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 240 seconds]
02:20 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has quit [Ping timeout: 250 seconds]
02:27 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has joined #bitcoin-core-dev
02:44 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
03:01 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
03:01 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
03:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Ping timeout: 256 seconds]
03:05 -!- Guest88 [~Guest88@66.81.162.138] has joined #bitcoin-core-dev
03:06 -!- Guest88 [~Guest88@66.81.162.138] has quit [Client Quit]
03:18 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
03:18 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
03:20 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
03:22 < laanwj> achow101: re https://github.com/bitcoin/bitcoin/pull/24418#discussion_r813133287  well at least it's future proof i guess...
03:23 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has quit [Remote host closed the connection]
03:23 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has joined #bitcoin-core-dev
03:32 < laanwj> seems we've quite massively overestimated due to the size of debug.log files (?)? do you think it's worth reverting that and invalidating ACKs for to adjust it down again
03:34 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
03:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:35 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8d6f9210d90b...37637bea3a9a
03:35 < bitcoin-git> bitcoin/master ff33c5a Hennadii Stepanov: Add missed word to error message
03:35 < bitcoin-git> bitcoin/master 37637be laanwj: Merge bitcoin/bitcoin#24434: Add missed word to error message
03:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:35 < bitcoin-git> [bitcoin] laanwj merged pull request #24434: Add missed word to error message (master...220224-word) https://github.com/bitcoin/bitcoin/pull/24434
03:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:41 < bitcoin-git> [bitcoin] laanwj opened pull request #24438: qt: English (source) translations update (master...2022-02-translations-source-update) https://github.com/bitcoin/bitcoin/pull/24438
03:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:03 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
04:03 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
04:04 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
04:10 < michaelfolkson> Spam (Zamy159) https://github.com/bitcoin/bips/pull/1284#issuecomment-1048649128
04:21 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
04:21 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
04:21 < laanwj> michaelfolkson: thanks, hid the comment and blocked for a month
04:22 -!- rex4539_ [~rex4539@gateway/tor-sasl/rex4539] has quit []
04:27 -!- geyaeb [~geyaeb@gateway/tor-sasl/geyaeb] has quit [Remote host closed the connection]
04:27 -!- geyaeb [~geyaeb@gateway/tor-sasl/geyaeb] has joined #bitcoin-core-dev
04:28 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev
04:37 -!- belcher [~belcher@user/belcher] has joined #bitcoin-core-dev
04:53 < fanquake> laanwj: I think invalidating the ACKs is fine
04:54 < fanquake> It's easy to re-verify
04:57 -!- prayank [~Prayank@45.64.9.50] has joined #bitcoin-core-dev
04:59 < laanwj> right, agree, also maybe it's a mistake to combine updating consensus-critical values (nMinimumChainWork, defaultAssumeValid) in the same PR as subjective-ish values about blockchain size
04:59 < prayank> laanwj: https://github.com/bitcoin/bitcoin/pull/24418#issuecomment-1049770559 I have restarted node with -reindex-chainstate -assumevalid=0 to verify but it can take a lot of time on my machine. Maybe jonatack would be able to do it earlier.
04:59 < laanwj> maybe something to keep in mind for the release process for next time
05:00 -!- prayank [~Prayank@45.64.9.50] has left #bitcoin-core-dev []
05:00 < laanwj> prayank: yes, that's also why i'm not doing it myself
05:00 < laanwj> it would take ages on anything i have
05:21 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has quit [Remote host closed the connection]
05:24 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
05:25 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
05:25 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
05:25 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
05:25 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
05:26 -!- jespada [~jespada@148.252.133.112] has quit [Ping timeout: 240 seconds]
05:26 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
05:26 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has joined #bitcoin-core-dev
05:29 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 250 seconds]
05:31 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has quit [Ping timeout: 240 seconds]
05:37 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has joined #bitcoin-core-dev
05:37 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 240 seconds]
05:42 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has quit [Ping timeout: 245 seconds]
05:43 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
05:43 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev
05:48 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 256 seconds]
05:54 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has joined #bitcoin-core-dev
05:57 < jonatack> prayank: i'm doing it on an old, slow machine too. about 5% done on mainnet after a couple hours, so may take a couple days
05:58 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has quit [Remote host closed the connection]
05:59 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has joined #bitcoin-core-dev
06:01 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
06:01 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
06:02 -!- prayank [~Prayank@45.64.9.50] has joined #bitcoin-core-dev
06:03 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has quit [Ping timeout: 240 seconds]
06:03 < prayank> jonatack: I am doing it only for testnet and it should be done in next few hours
06:03 -!- prayank [~Prayank@45.64.9.50] has left #bitcoin-core-dev []
06:10 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
06:10 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
06:16 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev
06:21 -!- jespada [~jespada@148.252.133.112] has joined #bitcoin-core-dev
06:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:33 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/37637bea3a9a...c07287d34cac
06:33 < bitcoin-git> bitcoin/master 38020c4 laanwj: qt: English (source) translations update
06:33 < bitcoin-git> bitcoin/master c07287d fanquake: Merge bitcoin/bitcoin#24438: qt: English (source) translations update
06:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:33 < bitcoin-git> [bitcoin] fanquake merged pull request #24438: qt: English (source) translations update (master...2022-02-translations-source-update) https://github.com/bitcoin/bitcoin/pull/24438
06:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:35 -!- sdfgsdfg [~dfghsfgs@user/sdfgsdfg] has quit [Quit: ayo yoyo ayo yoyo hololo, hololo.]
06:35 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev
06:38 -!- bomb-on [~bomb-on@194.144.47.113] has quit [Read error: Connection reset by peer]
06:39 -!- bomb-on [~bomb-on@194.144.47.113] has joined #bitcoin-core-dev
06:41 -!- realies [~realies@user/realies] has quit [Ping timeout: 240 seconds]
06:46 -!- realies [~realies@user/realies] has joined #bitcoin-core-dev
07:09 -!- mikehu44_ [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 272 seconds]
07:11 -!- roconnor [~roconnor@coq/roconnor] has joined #bitcoin-core-dev
07:15 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
07:15 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
07:20 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 256 seconds]
07:25 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
07:26 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
07:35 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has joined #bitcoin-core-dev
07:53 -!- prayank [~Prayank@2402:8100:2054:de9b:ee:1dc2:cdbe:6eb7] has joined #bitcoin-core-dev
07:53 < prayank> Done
07:57 -!- prayank [~Prayank@2402:8100:2054:de9b:ee:1dc2:cdbe:6eb7] has left #bitcoin-core-dev []
08:05 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
08:05 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
08:13 -!- provoostenator [~quassel@user/provoostenator] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
08:14 -!- provoostenator [~quassel@user/provoostenator] has joined #bitcoin-core-dev
08:14 -!- provoostenator [~quassel@user/provoostenator] has quit [Client Quit]
08:14 -!- ronoaldo [~ronoaldo@187.75.45.227] has joined #bitcoin-core-dev
08:16 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
08:16 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
08:17 -!- provoostenator [~quassel@user/provoostenator] has joined #bitcoin-core-dev
08:25 -!- NorrinRadd [~username@102.67.16.112] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
08:36 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has quit [Ping timeout: 260 seconds]
08:38 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has joined #bitcoin-core-dev
08:40 -!- NorrinRadd [~username@102.67.16.112] has joined #bitcoin-core-dev
08:43 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has quit [Ping timeout: 268 seconds]
08:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:44 < bitcoin-git> [bitcoin] MarcoFalke pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/c07287d34cac...f1ce67f09fba
08:44 < bitcoin-git> bitcoin/master 76557cb MarcoFalke: test: Remove i686 from test/get_previous_releases.py
08:44 < bitcoin-git> bitcoin/master 0e4b695 Sjors Provoost: test: backwards compatibility: misc fixes
08:44 < bitcoin-git> bitcoin/master 8cba75f Sjors Provoost: test: v0.20.1 backwards compatibility
08:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:44 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has joined #bitcoin-core-dev
08:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:44 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19013: test: add v0.20.1, v0.21.0 and v22.0 to backwards compatibility test  (master...2020/05/previous_release_0.20) https://github.com/bitcoin/bitcoin/pull/19013
08:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:45 -!- NorrinRadd [~username@102.67.16.112] has quit [Client Quit]
08:51 -!- NorrinRadd [~username@102.67.16.112] has joined #bitcoin-core-dev
08:52 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 240 seconds]
08:52 -!- NorrinRadd [~username@102.67.16.112] has quit [Client Quit]
09:01 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
09:01 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
09:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:06 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #19332: test: Fix intermittent test failure in feature_backwards_compatibility (master...2006-testIntBack) https://github.com/bitcoin/bitcoin/pull/19332
09:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:26 -!- l_sx01 is now known as ls55
09:27 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
09:27 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
09:37 -!- kexkey [~kexkey@static-198-54-132-101.cust.tzulo.com] has quit [Ping timeout: 240 seconds]
09:42 -!- kexkey [~kexkey@static-198-54-132-133.cust.tzulo.com] has joined #bitcoin-core-dev
09:42 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
09:44 < achow101> does sdaftuar have a 20 GB debug.log file or something?
09:44 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 250 seconds]
09:45 -!- jespada [~jespada@148.252.133.112] has quit [Read error: Connection reset by peer]
09:47 < MarcoFalke> or 20 GB of stale blocks
09:48 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has quit [Remote host closed the connection]
09:53 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has joined #bitcoin-core-dev
09:54 -!- kexkey_ [~kexkey@static-198-54-132-117.cust.tzulo.com] has joined #bitcoin-core-dev
09:55 -!- kexkey [~kexkey@static-198-54-132-133.cust.tzulo.com] has quit [Ping timeout: 240 seconds]
09:56 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev
09:57 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has quit [Ping timeout: 240 seconds]
09:59 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has joined #bitcoin-core-dev
10:00 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
10:00 -!- kexkey [~kexkey@static-198-54-132-133.cust.tzulo.com] has joined #bitcoin-core-dev
10:02 -!- kexkey_ [~kexkey@static-198-54-132-117.cust.tzulo.com] has quit [Ping timeout: 240 seconds]
10:02 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
10:03 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
10:03 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has quit [Ping timeout: 240 seconds]
10:05 -!- kexkey [~kexkey@static-198-54-132-133.cust.tzulo.com] has quit [Ping timeout: 256 seconds]
10:05 -!- kexkey [~kexkey@static-198-54-132-117.cust.tzulo.com] has joined #bitcoin-core-dev
10:12 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has quit [Quit: Connection closed for inactivity]
10:20 < ajonas> #proposedmeetingtopic Bitcoin Core contributor survey
10:21 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has joined #bitcoin-core-dev
10:28 -!- geyaeb [~geyaeb@gateway/tor-sasl/geyaeb] has quit [Remote host closed the connection]
10:28 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
10:28 -!- geyaeb [~geyaeb@gateway/tor-sasl/geyaeb] has joined #bitcoin-core-dev
10:30 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
10:30 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
10:38 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Ping timeout: 240 seconds]
10:39 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
10:49 -!- mikehu44 [~quassel@159.65.11.175] has joined #bitcoin-core-dev
10:49 -!- mikehu44 [~quassel@159.65.11.175] has quit [Client Quit]
10:59 -!- kexkey [~kexkey@static-198-54-132-117.cust.tzulo.com] has quit [Ping timeout: 240 seconds]
11:00 < laanwj> #startmeeting
11:00 < core-meetingbot`> Meeting started Thu Feb 24 19:00:09 2022 UTC.  The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
11:00 < core-meetingbot`> Available commands: action commands idea info link nick
11:00 < achow101> hi
11:00 < jamesob> hi
11:00 < b10c> hi
11:00 < ajonas> hi
11:00 < sipa> hi
11:00 -!- kexkey [~kexkey@modemcable241.140-175-137.mc.videotron.ca] has joined #bitcoin-core-dev
11:00 < laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball
11:00 < laanwj> morcos nehan NicolasDorier paveljanik petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild
11:01 < kvaciral[m]> hi
11:01 -!- prayank [~Prayank@45.64.9.50] has joined #bitcoin-core-dev
11:01 < prayank> hi
11:01 < luke-jr> hi
11:01 < michaelfolkson> hi
11:01 < laanwj> one proposed meeting topic this week (you can propose meeting topics during the week with #proposedmeetingtopic): Bitcoin Core contributor survey (ajonas)
11:01 < laanwj> any last minute topics?
11:04 < laanwj> as the 23.0 branch-off is planned soon (2022-03-01, in less than a week), it probably makes sense to go over the milestone again
11:04 < laanwj> #topic 23.0 milestone
11:04 < core-meetingbot`> topic: 23.0 milestone
11:04 < laanwj> https://github.com/bitcoin/bitcoin/milestone/52
11:05 < luke-jr> idk if https://github.com/bitcoin-core/gui/pull/557 is too late or not (forgot about it I guess)
11:05 < laanwj> there's, some bugfixes left, as well as the usual release process items
11:06 < laanwj> 23.0 milestone for gui repo: https://github.com/bitcoin-core/gui/milestone/7
11:06 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev
11:06 < prayank> laanwj: #23524 #22834 are important, included in 23.0 milestone and RFM
11:06 <@gribble> https://github.com/bitcoin/bitcoin/issues/23524 | doc: Fix typos in endif header comments by MarcoFalke · Pull Request #23524 · bitcoin/bitcoin · GitHub
11:06 <@gribble> https://github.com/bitcoin/bitcoin/issues/22834 | net: respect -onlynet= when making outbound connections by vasild · Pull Request #22834 · bitcoin/bitcoin · GitHub
11:07 < laanwj> luke-jr: I don't know, we already had the translations freeze
11:07 < luke-jr> right
11:07 < prayank> Sorry it was #23542
11:07 < luke-jr> and unfortunately one of the strings changed in between, so it's not a simple revert
11:07 <@gribble> https://github.com/bitcoin/bitcoin/issues/23542 | net: open p2p connections to nodes that listen on non-default ports by vasild · Pull Request #23542 · bitcoin/bitcoin · GitHub
11:07 < laanwj> it's too bad we didn't catch it before merging bitcoin-core/gui#296
11:07 <@gribble> https://github.com/bitcoin/bitcoin/issues/296 | HTTP Error 404: Not Found
11:08 < luke-jr> (simple revert would have the benefit of having already been translated)
11:08 < laanwj> yes, then translation memory would just pull the old message
11:09 < laanwj> in any case we can probably still do it it's only a few messages
11:09 < laanwj> although fairly important ones that appear inthe intro that we really don't want untranslated
11:09 < laanwj> prayank: ok, thanks
11:10 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
11:10 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
11:10 -!- jarthur_ is now known as jarthur
11:10 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
11:11 -!- kexkey [~kexkey@modemcable241.140-175-137.mc.videotron.ca] has quit [Ping timeout: 256 seconds]
11:11 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
11:11 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has quit [Remote host closed the connection]
11:13 < laanwj> did anyone ever figure out what happens in  #24335?
11:13 <@gribble> https://github.com/bitcoin/bitcoin/issues/24335 | Segmentation Fault in V21 and V22 releases · Issue #24335 · bitcoin/bitcoin · GitHub
11:14 < achow101> yes
11:14 < achow101> it should be fixed by #23304
11:14 <@gribble> https://github.com/bitcoin/bitcoin/issues/23304 | wallet: Derive inactive HD chains in additional places by achow101 · Pull Request #23304 · bitcoin/bitcoin · GitHub
11:14 < laanwj> looks like an issue multiple people are having, so would be good to solve it for 0.23
11:14 < laanwj> good!
11:14 -!- kexkey [~kexkey@static-198-54-132-149.cust.tzulo.com] has joined #bitcoin-core-dev
11:15 < laanwj> I vaguely remembered there was a fix but it wasn't linked in any way :)
11:16 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has joined #bitcoin-core-dev
11:16 < laanwj> ok that's covered, anything else people would like to discuss for 23.0?
11:16 < laanwj> #24201 is labeled WIP, I don't think it should be on the milestone
11:16 <@gribble> https://github.com/bitcoin/bitcoin/issues/24201 | WIP: p2p: Avoid InitError when downgrading peers.dat by junderw · Pull Request #24201 · bitcoin/bitcoin · GitHub
11:18 < prayank> I think I can review, tACK it and WIP can be removed. Will need some clarity from PR author why is WIP mentioned. I had already commented in PR.
11:18 < jonatack> hi
11:19 < laanwj> but WIP is generally before the review phase
11:19 < laanwj> yeah, I'm not sure
11:20 -!- kexkey [~kexkey@static-198-54-132-149.cust.tzulo.com] has quit [Quit: kexkey]
11:20 < prayank> It was reviewed by multiple devs and author added WIP 5 days back
11:20 < laanwj> i see, weird
11:20 < luke-jr> laanwj: FWIW, I do have a better "translation memory" I use for Knots - but I'm not sure how easily I can send results from it back to Transifex :x
11:21 < michaelfolkson> Only 1 ACK and 1 utACK currently
11:21 < luke-jr> I think I would have to freeze all the translations, fetch, run my script on them, upload, and unfreeze - but it does take an hour or two
11:21 < michaelfolkson> Worth asking about the WIP regardless of milestone
11:22 -!- Guest3 [~Guest3@208.91.126.250] has joined #bitcoin-core-dev
11:22 < laanwj> yes
11:22 < laanwj> #topic Bitcoin Core contributor survey (ajonas)
11:22 < core-meetingbot`> topic: Bitcoin Core contributor survey (ajonas)
11:23 < ajonas> hi
11:23 < ajonas> I've written up a summary of the Bitcoin Core dev contributor survey at https://adamjonas.com/bitcoin/coredev/retro/coredev-2021-retro/
11:23 < ajonas> Thanks to those who participated and I am looking forward to bothering folks again next year
11:23 < ajonas> that's it
11:23 < laanwj> thanks ajonas!
11:24 < laanwj> it was interesting to read
11:24 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
11:25 < laanwj> any other topics people would like to discuss? or another short meeting :)
11:25 < jeremyrubin> oops
11:25 < MarcoFalke> I've created #24433 as a reply to the retro, btw
11:25 <@gribble> https://github.com/bitcoin/bitcoin/issues/24433 | doc: Explain that feedback needs to be addressed by MarcoFalke · Pull Request #24433 · bitcoin/bitcoin · GitHub
11:25 < jeremyrubin> thanks ajonas!
11:26 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev
11:26 < MarcoFalke> Section "review": https://adamjonas.com/bitcoin/coredev/retro/coredev-2021-retro/#review
11:27 < jeremyrubin> one little topic i'd like to discuss around signets if theres nothing else laanwj
11:27 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has quit [Remote host closed the connection]
11:27 < jeremyrubin> #proposedmeetingtopic: signet parameter distributions / signet data dirs improvement approach 
11:27 < laanwj> MarcoFalke: definitely agree with that
11:28 < jamesob> ajonas: cool wordcloud
11:28 < prayank> MarcoFalke: I wanted to suggest something in that PR but that would become controversial. And I was not aware of this survey.
11:28 < MarcoFalke> Another point of feedback was that sometimes pull requests with ACKs aren't merged. Sometimes I see them too, but I din't feel comfortable merging them, because I am not at all familiar with that part of the codebase.
11:29 < laanwj> MarcoFalke: makes sense to ping another maintainer then
11:29 < laanwj> or just, mention it here
11:29 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Client Quit]
11:30 < MarcoFalke> Ok, maybe this is soemthing we might want to document as well.
11:31 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev
11:31 < prayank> We can document lot of things for reviewers in which they had to ping in IRC
11:31 < laanwj> yes, in general, don't assume anyone has an overview of all issues and PRs, if there's something that needs to be addressed (or ready for merge) it's best to bring it up here
11:31 < MarcoFalke> Also, it was mentioned that there should be more domain-specific maintainers. I tend to agree, but right now we don't have enough maintainers to assign each one a single domain.
11:32 < laanwj> it doesn't help if the wallet maintainers keep stepping down :)
11:32 < laanwj> yes, that's nothing new, we've tried that since 2012 or so
11:32 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has joined #bitcoin-core-dev
11:33 < luke-jr> XD
11:34 < jeremyrubin> i think also it's helpful if current maintainers make clear areas which are more difficult to review for them -- e.g., i dont think there's that many maintainers who have deep mempool expertise (if i'm wrong here LMK), so i think things on mempool are negatively impacted by lack of reviewers who can prod along ack/merge.
11:34 < laanwj> we've always had, there's a lot of things people want and agree on but no one stepping up to do them, and we don't practice human sacrifice, not even by assigning people to be wallet maintainer :)
11:34 < jeremyrubin> Maybe current maintainers can list out what parts of the code they feel more/less confident on?
11:35 < ajonas> I don't think holding maintainers feet to the fire on what they know or what they don't is going to improve that
11:36 < luke-jr> maintainers are supposed to merge based on review ACKs, not their own personal review
11:36 < laanwj> right, lack of knowledgeable reviewers in certain areas of the code isn't going to be improved by slapping labels on people
11:36 < MarcoFalke> jeremyrubin:  Grep for ACK-comments on the commits and create a heat-map, will be less subjective
11:36 < prayank> luke-jr: +1
11:36 < luke-jr> obviously it's good if they're familiar with the scope, but it shouldn't be a barrier in itself
11:37 < MarcoFalke> luke-jr: Maintainers should be able to tell if something is a backdoor or not before merge
11:37 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has quit [Ping timeout: 250 seconds]
11:37 < luke-jr> MarcoFalke: reviewers should
11:37 < sipa> luke-jr: That's true, but I'm not sure it matters that much, because personal knowledge about a part of codebase also correlates with judging reviewer competence in that part.
11:37 < achow101> personally, I don't feel comfortable with merging something if I haven't reviewed it, and I don't feel comfortable reviewing something that I'm not familiar with
11:37 < laanwj> so like, the mempool is notoriously difficult to get people to review for, so, we make glozow mempool maintainer
11:37 < MarcoFalke> luke-jr: No one signs review comments, so a GitHub employee can hijack Bitcoin Core if maintainers blindly click the merge button without thinking
11:37 < luke-jr> maintainers aren't supposed to be a position of privilege
11:37 < jeremyrubin> i dont think i'm advocating holding feet to the fire moreso identifying where our current maintainership is stronger/weaker to aid in identifying where we might improve.
11:38 < michaelfolkson> It isn't just the maintainers knowledge, it is the maintainers' assessment of the reviewers' knowledge
11:38 < jeremyrubin> laanwj: glozow is currently one of the main people writing new mempool code, so her being a maintainer probably doesn't help much
11:38 < luke-jr> MarcoFalke: true, but hopefully the spoofed reviewers would notice before a release
11:38 < laanwj> jeremyrubin: that was exactly my point
11:38 < prayank> laanwj: NACK
11:38 < laanwj> prayank: i'm not asking you
11:39 < luke-jr> …
11:39 < prayank> laanwj: what was it?
11:39 < laanwj> i also don't think brining hijack-ability of github into this is useful now
11:39 < jeremyrubin> laanwj sorry i didn't parse the sarcasm 
11:40 < ajonas> re the mempool - I understand the frustration but the reality is that the more sensitive the code and the fewer people understand it, the harder it will be to get in. 
11:40 < ajonas> mempool actually has a lot more momentum than it did a year ago
11:40 < ajonas> so review is improving
11:40 < laanwj> the pr review meetings are probably helping!
11:40 < MarcoFalke> jeremyrubin: I don't think this is sacrasm. maintainers are naturally those that review the most. For example, I used to review every test pull request, so I became test maintainer
11:41 < ajonas> it's like p2p 2-3 years ago when it became more of an area of interest 
11:41 < laanwj> MarcoFalke: it was like half sarcasm half a serious proposal
11:41 < jeremyrubin> i think the sarcasm was that the talent pool is shallow so right now we'd be making the person writing be in a position to not merge their own thing
11:41 < luke-jr> MarcoFalke: (and you do a good job at it)
11:41 < prayank> laanwj: changing RBF policy in core because of xyz reasons in abc project is not going to improve anything FYI and it doesn't matter who is the maintainer
11:42 < luke-jr> jeremyrubin: maintainers can merge their own thing if it gets reasonable review ACKs
11:42 < laanwj> MarcoFalke: i think it'd be a good idea but not so much to get more review, just to have someone continuously involved with it in the project
11:42 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
11:43 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
11:43 < laanwj> in any case, concrete proposals for maintainers would be useful
11:43 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has joined #bitcoin-core-dev
11:44 < jeremyrubin> laanwj: that's basically what i'm trying to point out, that it'd be good if our 'maintainership coverage' is documented so that we can better it for different areas of the code
11:44 < laanwj> for different areas
11:44 < jeremyrubin> mempool as an example, but other parts too
11:44 < laanwj> preferably people stepping up themselves and not being sacrificed :p
11:44 < luke-jr> maybe more IRC "rtm" would help
11:45 < laanwj> yes
11:46 < laanwj> more discussion here would help in any case i think
11:46 < ajonas> I guess it's worth recognizing in this discussion and the summary that being a maintainer is hard 
11:46 < ajonas> thank you to those that are shouldering that load
11:47 < laanwj> as said, github just has too large volume of activity, no one can keep up with it, if there's anything of note it's good to bring it up here
11:47 < jeremyrubin> one concept: maintainers can delegate explicitly (e.g., on GH) the maintainer decision on a PR if theres not one who feels qualified
11:47 < laanwj> thanks ajonas 
11:47 < jeremyrubin> sort of in-between of being a formal maintainer v.s. giving someone else the RTM call
11:47 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has quit [Ping timeout: 240 seconds]
11:48 < laanwj> i mean the first step is just to communicate, are you unsure, ask it, don't wait until someone gets around to your PR by accident :)
11:49 < michaelfolkson> Agreed. I think just more communication is the solution rather than creating new roles
11:49 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has joined #bitcoin-core-dev
11:50 < laanwj> any other topics?
11:50 < luke-jr> I wonder if that bitcoinacks website was helpful
11:50 < michaelfolkson> I think it is fine for a maintainer to say on a PR "I think this is ready to merge but I'm not as familiar as I'd like with this part of the codebase. Any thoughts from Person A, B, C"
11:50 < jeremyrubin> i did a small one ^
11:50 < luke-jr> is it dead now?
11:50 < jeremyrubin> 11:27 #proposedmeetingtopic: signet parameter distributions / signet data dirs improvement approach 
11:50 < laanwj> #topic signet parameter distributions / signet data dirs improvement approach (jeremyrubin)
11:50 < core-meetingbot`> topic: signet parameter distributions / signet data dirs improvement approach (jeremyrubin)
11:51 < achow101> luke-jr: I tried using it a few weeks ago and it seemed to be dead
11:51 < laanwj> luke-jr: yes, i think so, the person maintaining it suddenly stopped doing so
11:51 < jeremyrubin> not much to say, but in running the ctv signet people have been having issues with datadirs because any signet goes to the same place
11:51 < jeremyrubin> it might be nice if signets had e.g. a per challenge chainstate directory or something
11:52 < jeremyrubin> or if bitcoin.conf could have multiple [signet.xyz]'s for configging different named signets
11:52 < jeremyrubin> dont really have any idea of how to approach that so if anyone has any thoughts would love them before i spend any time on it
11:53 < laanwj> luke-jr: there was some discussion about it at the time and we moved it into bitcoin-core at some point https://github.com/bitcoin-core/bitcoin-acks , but no one picked it up
11:53 < prayank> jeremyrubin: asking to backup old signet datadir, delete and relaunch can be workaround for now and maybe separate dir in future
11:53 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Quit: 404]
11:54 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has quit [Ping timeout: 245 seconds]
11:54 < jeremyrubin> prayank: certainly works for now
11:54 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
11:54 < laanwj> jeremyrubin: yes, that would make sense
11:54 < achow101> signets could be identified by the hash of the challenge, and we make datadirs like "signet_<challenge hash>"?
11:54 < jeremyrubin> i will probably just make the fork that i have make a different dir by default to skirt the problem for now (going to add default params to that branch)
11:54 < jeremyrubin> achow101: one question I had is if challenges can change over time
11:55 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
11:55 < michaelfolkson> luke-jr: It also had the problem of people not following the review guidance (Concept ACK, Approach ACK, ACK) and using tACK, utACK, crACK etc
11:55 < achow101> jeremyrubin: wouldn't that break validating old blocks?
11:55 < sipa> could they be identified by the hash of the genesis block?
11:55 < sipa> jeremyrubin: Pretty sure they challenge cannot be changed
11:55 < jeremyrubin> achow101: depends, are the old scriptcodes covered in the sig?
11:55 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev
11:55 < achow101> sipa: IIRC the genesis is shared
11:56 < sipa> jeremyrubin: the signet block hash covers the challenge
11:56 < jeremyrubin> It would also be nice if bitcoin core could have multiple signets in the chain configs
11:56 < sipa> (it's done using a fake transaction which creates a UTXO with scriptPubKey=challenge, and then another transaction spending that UTXO)
11:57 < sipa> so the prevhash of the spending input indirectly is derived from the challenge
11:57 < jeremyrubin> i think nicknames are a little better than hash of signetchallenge, although hash of signetchallenge does guarantee uniqueness
11:58 < jeremyrubin> it'd also be good if 1 bitcoin.conf could configure >1 signet so i think the [signet.xyz] format is probably right
11:59 < jeremyrubin> maybe we can do user configured nicknames, and the directory can be based on the challenge?
11:59 < sipa> i think i'd prefer that
11:59 < sipa> have dirname/configsection be signet_<hash(challenge)>, but then (perhaps later) add a way to configure a nickname for a signet, to allow easy selection on commandline?
12:00 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has joined #bitcoin-core-dev
12:01 < jeremyrubin> and i guess for backwards compat, just signet is the default one?
12:01 < sipa> right
12:01 < laanwj> right, "how to avoid collisions" and "how to configure signets user friendly" are more or less separate problems
12:01 < sipa> laanwj: exactly
12:01 < jeremyrubin> i dont think we need the signet_hashchallenge in the config section
12:01 < jeremyrubin> it's redundant with the signetchallenge field
12:02 < jeremyrubin> so maybe we can just infer it
12:02 < jeremyrubin> [anynameyoulike] signet=1 signetchallenge=x and infer it?
12:03 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
12:03 < jeremyrubin> i'll see if i can put something together with that
12:03 < laanwj> we're running out of time
12:03 < achow101> could be problematic if you did [test] signet=1
12:03 < achow101> I liked the [signet.xyz] suggestion, and just parse the xyz name from that
12:03 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
12:04 < jeremyrubin> thanks :)
12:04 < jamesob> achow: +1
12:04 < laanwj> achow101: yes, seems better to be explicit
12:04 < laanwj> minimize potential ambigiousness
12:05 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
12:05 < laanwj> anyhow, time to close the meeting, thanks everyone for attending
12:05 < laanwj> #endmeeting
12:05 < core-meetingbot`> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
12:05 < core-meetingbot`> Meeting ended Thu Feb 24 20:05:30 2022 UTC.  
12:05 < core-meetingbot`> Minutes:        https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2022/bitcoin-core-dev.2022-02-24-19.00.moin.txt
12:06 < kanzure> hi
12:06 -!- kexkey [~kexkey@static-198-54-132-85.cust.tzulo.com] has joined #bitcoin-core-dev
12:08 < laanwj> hi
12:08 < sipa> hi
12:10 < jeremyrubin> hi
12:11 -!- ronoaldo [~ronoaldo@187.75.45.227] has quit [Quit: Konversation terminated!]
12:11 < michaelfolkson> Any meeting topics?
12:12 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
12:12 < prayank> I did not ask this earlier because it could be OT. Is anyone in touch with it hebasto? I am assuming he was in Ukraine, there are lot of problems there, did not see him active since last 24 hours on Github or Twitter or meeting.
12:14 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
12:15 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
12:19 -!- prayank [~Prayank@45.64.9.50] has left #bitcoin-core-dev []
12:20 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has quit [Ping timeout: 240 seconds]
12:22 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has joined #bitcoin-core-dev
12:23 < laanwj> yes, we're in touch with him
12:26 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has quit [Ping timeout: 245 seconds]
12:28 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has joined #bitcoin-core-dev
12:34 -!- jespada [~jespada@85.255.233.175] has joined #bitcoin-core-dev
12:38 -!- baakeydow [~baake@2001:41d0:203:b12c::] has quit [Quit: baakeydow]
12:45 -!- bfsfhkacjzgcytf [~bfsfhkacj@user/bfsfhkacjzgcytf] has quit [Ping timeout: 240 seconds]
12:47 -!- Guest3 [~Guest3@208.91.126.250] has quit [Quit: Client closed]
12:55 -!- prayank [~Prayank@45.64.9.50] has joined #bitcoin-core-dev
12:56 -!- baakeydow [~baake@2001:41d0:203:b12c::] has joined #bitcoin-core-dev
12:56 < prayank> laanwj: thanks for sharing. hoping he is okay.
12:56 < prayank> Can you explain this comment so that I don't interpret this in my own way? https://bitcoin-irc.chaincode.com/bitcoin-core-dev/2022-02-24#783144;
12:56 <@gribble> https://github.com/bitcoin/bitcoin/issues/783144 | HTTP Error 404: Not Found
12:59 -!- prayank [~Prayank@45.64.9.50] has left #bitcoin-core-dev []
13:00 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
13:04 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Ping timeout: 252 seconds]
13:05 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
13:05 < michaelfolkson> prayank: It was in response to this https://bitcoin-irc.chaincode.com/bitcoin-core-dev/2022-02-24#783133;
13:05 <@gribble> https://github.com/bitcoin/bitcoin/issues/783133 | HTTP Error 404: Not Found
13:05 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
13:10 -!- prayank [~Prayank@45.64.9.50] has joined #bitcoin-core-dev
13:10 < prayank> michaelfolkson: thanks
13:10 -!- prayank [~Prayank@45.64.9.50] has left #bitcoin-core-dev []
13:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:11 < bitcoin-git> [gui] rebroad opened pull request #559: Network graph improvements (master...NetworkGraphImprovements) https://github.com/bitcoin-core/gui/pull/559
13:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:11 -!- bfsfhkacjzgcytf [~bfsfhkacj@user/bfsfhkacjzgcytf] has joined #bitcoin-core-dev
13:24 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
13:24 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
13:25 -!- engraving [~engraving@195.181.160.173.adsl.inet-telecom.org] has joined #bitcoin-core-dev
13:33 < glozow> hi there, missed the meeting but fwiw i’m happy to review people’s mempool PRs - feel free to ping me
13:33 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has quit [Ping timeout: 268 seconds]
13:39 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev
13:44 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 272 seconds]
13:50 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev
14:02 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
14:02 -!- mudsip [~mudsip@user/mudsip] has joined #bitcoin-core-dev
14:03 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
14:04 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
14:05 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds]
14:10 -!- mudsip [~mudsip@user/mudsip] has quit []
14:11 -!- jespada [~jespada@85.255.233.175] has quit [Read error: Connection reset by peer]
14:12 -!- hashfunc1160 [~user@2601:5c0:c280:7090:78e9:5f82:1899:8c96] has joined #bitcoin-core-dev
14:14 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
14:14 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
14:16 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Remote host closed the connection]
14:21 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has joined #bitcoin-core-dev
14:40 -!- hashfunc1160 [~user@2601:5c0:c280:7090:78e9:5f82:1899:8c96] has quit [Remote host closed the connection]
14:52 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has quit [Remote host closed the connection]
14:57 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev
15:02 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 260 seconds]
15:08 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev
15:13 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 256 seconds]
15:14 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has joined #bitcoin-core-dev
15:16 -!- _flood [flooded@gateway/vpn/protonvpn/flood/x-43489060] has quit [Ping timeout: 272 seconds]
15:18 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has quit [Ping timeout: 250 seconds]
15:27 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has joined #bitcoin-core-dev
15:28 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
15:28 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
15:29 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
15:30 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
15:40 -!- engraving [~engraving@195.181.160.173.adsl.inet-telecom.org] has quit [Ping timeout: 240 seconds]
15:41 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
15:50 -!- sdfgsdfg [~dfghsfgs@user/sdfgsdfg] has joined #bitcoin-core-dev
16:21 -!- Jackielove4u [uid43977@user/jackielove4u] has quit [Quit: Connection closed for inactivity]
16:23 -!- geyaeb [~geyaeb@gateway/tor-sasl/geyaeb] has quit [Remote host closed the connection]
16:24 -!- geyaeb [~geyaeb@gateway/tor-sasl/geyaeb] has joined #bitcoin-core-dev
16:31 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has quit [Ping timeout: 240 seconds]
16:32 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has joined #bitcoin-core-dev
16:53 -!- prayank [~Prayank@45.64.9.50] has joined #bitcoin-core-dev
16:56 < prayank> Assumption: This chat log is being read by people being addressed.
16:56 < prayank> I have seen putin with vitalik in 2017 and bitcoin is obviously better so expecting your infosec team runs the software created in this repository. Please stop this nonsense. No communities or countries ever achieved anything good with such things in past. Humans like you get affected at ground level maybe some people that you consider collateral damage but they are same as you. Nobody would say anything to some extent for some
16:56 < prayank>  things but it can become the downfall of Russia at some point.
16:56 -!- prayank [~Prayank@45.64.9.50] has left #bitcoin-core-dev []
17:00 -!- realies [~realies@user/realies] has quit [Quit: Ping timeout (120 seconds)]
17:00 -!- realies [~realies@user/realies] has joined #bitcoin-core-dev
17:13 -!- Guest92 [~Guest92@2001:4451:11ea:ff00:e52d:7191:6c91:cfbe] has joined #bitcoin-core-dev
17:13 -!- Guest92 [~Guest92@2001:4451:11ea:ff00:e52d:7191:6c91:cfbe] has quit [Client Quit]
17:23 -!- sdfgsdfg [~dfghsfgs@user/sdfgsdfg] has quit [Quit: ayo yoyo ayo yoyo hololo, hololo.]
17:37 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has quit [Ping timeout: 240 seconds]
17:50 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
17:51 -!- brunoerg [~brunoerg@187.183.43.40] has joined #bitcoin-core-dev
18:16 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 272 seconds]
18:18 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
18:21 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: Textual IRC Client: www.textualapp.com]
18:24 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
18:26 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
18:28 -!- lukedashjr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
18:29 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 240 seconds]
18:29 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 256 seconds]
18:30 -!- sdfgsdfg [~dfghsfgs@user/sdfgsdfg] has joined #bitcoin-core-dev
18:30 -!- lukedashjr is now known as luke-jr
18:33 -!- sdfgsdfg [~dfghsfgs@user/sdfgsdfg] has quit [Read error: Connection reset by peer]
18:34 -!- sdfgsdfg [~dfghsfgs@user/sdfgsdfg] has joined #bitcoin-core-dev
18:50 -!- sdfgsdfg [~dfghsfgs@user/sdfgsdfg] has quit [Quit: ayo yoyo ayo yoyo hololo, hololo.]
18:56 -!- brunoerg [~brunoerg@187.183.43.40] has quit [Ping timeout: 256 seconds]
19:10 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has joined #bitcoin-core-dev
19:18 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Ping timeout: 240 seconds]
19:19 -!- bomb-on [~bomb-on@194.144.47.113] has quit [Quit: aллилѹіа!]
19:43 -!- sdfgsdfg [~dfghsfgs@user/sdfgsdfg] has joined #bitcoin-core-dev
20:01 -!- greypw254 [~greypw2@grey.pw] has quit [Remote host closed the connection]
20:01 -!- greypw254 [~greypw2@grey.pw] has joined #bitcoin-core-dev
20:02 -!- greypw254 [~greypw2@grey.pw] has quit [Remote host closed the connection]
20:02 -!- greypw254 [~greypw2@grey.pw] has joined #bitcoin-core-dev
20:02 -!- greypw254 [~greypw2@grey.pw] has quit [Remote host closed the connection]
20:03 -!- greypw254 [~greypw2@grey.pw] has joined #bitcoin-core-dev
20:03 -!- greypw254 [~greypw2@grey.pw] has quit [Remote host closed the connection]
20:03 -!- greypw254 [~greypw2@grey.pw] has joined #bitcoin-core-dev
20:04 -!- greypw254 [~greypw2@grey.pw] has quit [Remote host closed the connection]
20:12 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has quit [Ping timeout: 250 seconds]
20:34 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev
20:43 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has joined #bitcoin-core-dev
21:00 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:20 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Remote host closed the connection]
21:21 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev
21:31 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
21:36 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 272 seconds]
21:47 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has quit [Ping timeout: 240 seconds]
21:49 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
22:01 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has joined #bitcoin-core-dev
22:04 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Remote host closed the connection]
22:05 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev
22:31 -!- Kaizen_Kintsugi_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has joined #bitcoin-core-dev
22:32 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 240 seconds]
22:33 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev
22:35 -!- Kaizen_K_ [Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745] has quit [Ping timeout: 256 seconds]
22:39 -!- jarthur [~jarthur@cpe-70-114-198-37.austin.res.rr.com] has quit [Quit: jarthur]
23:02 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has quit [Ping timeout: 245 seconds]
23:14 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
23:20 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
23:32 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:9dd2:147d:2158:cba2] has joined #bitcoin-core-dev
23:43 -!- hashfunca51 [~user@2601:5c0:c280:7090:78e9:5f82:1899:8c96] has joined #bitcoin-core-dev
23:46 < jeremyrubin> how does one convince bitcoind to generate nice consolidation txns?
23:46 < jeremyrubin> my signet wallet is... annoying to work with
23:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:47 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f1ce67f09fba...b00b60ed4f27
23:47 < bitcoin-git> bitcoin/master d41ed32 junderw: p2p: Avoid InitError when downgrading peers.dat
23:47 < bitcoin-git> bitcoin/master b00b60e MarcoFalke: Merge bitcoin/bitcoin#24201: p2p: Avoid InitError when downgrading peers.d...
23:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:47 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #24201: p2p: Avoid InitError when downgrading peers.dat (master...fixes/24188) https://github.com/bitcoin/bitcoin/pull/24201
23:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
--- Log closed Fri Feb 25 00:00:09 2022