--- Log opened Thu May 12 00:00:21 2022
00:01 -!- mikehu44_ [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 246 seconds]
00:02 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev
00:07 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev
00:16 -!- sipsorcery [~sipsorcer@37.228.225.67] has joined #bitcoin-core-dev
00:19 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #25112: util: Move error message formatting of NonFatalCheckError to cpp (master...2205-err-impl-🗡) https://github.com/bitcoin/bitcoin/pull/25112
00:21 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a2a8e919ee07...e3bab43329e7
00:21 < bitcoin-git> bitcoin/master 298389e fanquake: guix: bump time-machine to 998eda3067c7d21e0d9bb3310d2f5a14b8f1c681
00:21 < bitcoin-git> bitcoin/master e3bab43 fanquake: Merge bitcoin/bitcoin#25099: guix: bump time-machine to 998eda3067c7d21e0d...
00:21 < bitcoin-git> [bitcoin] fanquake merged pull request #25099: guix: bump time-machine to 998eda3067c7d21e0d9bb3310d2f5a14b8f1c681 (master...guix_time_machine_bump) https://github.com/bitcoin/bitcoin/pull/25099
00:36 -!- djb27__ [~djb27@user/djb27] has joined #bitcoin-core-dev
00:39 -!- djb27_ [djb27@user/djb27] has quit [Ping timeout: 246 seconds]
00:44 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
00:44 -!- mudsip [~mudsip@user/mudsip] has joined #bitcoin-core-dev
00:49 -!- mikehu44_ [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev
00:52 -!- mudsip [~mudsip@user/mudsip] has quit []
00:52 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
00:53 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 246 seconds]
00:57 -!- sipsorcery [~sipsorcer@37.228.225.67] has quit [Ping timeout: 240 seconds]
01:06 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e3bab43329e7...dd9f61a184d4
01:06 < bitcoin-git> bitcoin/master fab9e8a MacroFake: Remove unused GetTimeSeconds
01:06 < bitcoin-git> bitcoin/master dd9f61a MacroFake: Merge bitcoin/bitcoin#25102: Remove unused GetTimeSeconds
01:06 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #25102: Remove unused GetTimeSeconds (master...2205-no-GetTimeSeconds-😅) https://github.com/bitcoin/bitcoin/pull/25102
01:19 -!- Common__ [~Common@096-033-221-075.res.spectrum.com] has joined #bitcoin-core-dev
01:22 -!- Common_ [~Common@096-033-221-075.res.spectrum.com] has quit [Ping timeout: 260 seconds]
01:27 -!- evanlinjin_ [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev
01:39 -!- Guyver2_ [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
01:41 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has quit [Ping timeout: 256 seconds]
01:47 -!- jarthur_ [~jarthur@user/jarthur] has joined #bitcoin-core-dev
01:50 -!- jarthur [~jarthur@user/jarthur] has quit [Ping timeout: 248 seconds]
02:02 -!- evanlinjin_ [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds]
02:02 -!- kexkey [~kexkey@178.249.214.10] has quit [Ping timeout: 252 seconds]
02:05 -!- kexkey [~kexkey@178.249.214.10] has joined #bitcoin-core-dev
02:10 -!- midnight [~midnight@user/midnight] has quit [Ping timeout: 248 seconds]
02:11 -!- cold [~cold@user/cold] has quit [Ping timeout: 252 seconds]
02:13 -!- midnight [~midnight@user/midnight] has joined #bitcoin-core-dev
02:17 -!- cold [~cold@user/cold] has joined #bitcoin-core-dev
02:45 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-dev
02:45 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Changing host]
02:45 -!- TheRec [~toto@user/therec] has joined #bitcoin-core-dev
02:48 -!- nanotube [~nanotube@user/nanotube] has quit [Ping timeout: 240 seconds]
02:56 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #25113: Bump univalue subtree (master...2205-uni-bump-🕌) https://github.com/bitcoin/bitcoin/pull/25113
03:16 < bitcoin-git> [bitcoin] laanwj closed pull request #18427: Bugfix? Restore linking to libmingwthrd (master...2020mingwthrd) https://github.com/bitcoin/bitcoin/pull/18427
03:19 -!- jonatack [jonatack@user/jonatack] has joined #bitcoin-core-dev
03:31 -!- mudsip [~mudsip@user/mudsip] has joined #bitcoin-core-dev
03:44 -!- TheRec [~toto@user/therec] has quit [Ping timeout: 240 seconds]
03:46 -!- mudsip [~mudsip@user/mudsip] has quit []
04:18 -!- mikehu44_ [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 240 seconds]
04:20 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Quit: bye]
04:23 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev
04:23 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
04:32 < Earnestly> Is it possible to generate the manuals without X11 (for bitcoin-qt)?  It appears when using --version, I get 'qt.qpa.xcb: could not connect to display' and an IOT instruction abort
04:47 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-dev
04:47 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Changing host]
04:47 -!- TheRec [~toto@user/therec] has joined #bitcoin-core-dev
04:57 < hebasto> Earnestly: no, unfortunately. It seems there's an open issue in the gui repo
05:20 -!- Guest33 [~Guest33@dslb-084-060-034-236.084.060.pools.vodafone-ip.de] has quit [Quit: Client closed]
05:21 -!- mikehu44_ [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev
05:23 < bitcoin-git> [bitcoin] theStack opened pull request #25114: rpc: remove deprecated "softforks" field from getblockchaininfo (master...202205-rpc-remove_deprecated_softforks_from_getblockchaininfo) https://github.com/bitcoin/bitcoin/pull/25114
05:24 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 256 seconds]
05:29 < laanwj> seems like a bug (though, there are various compromises with regard to bitcoin-qt initialization, that might make it necessary to initialize qt before showing the options/help, dunno)
05:32 -!- sipsorcery [~sipsorcer@37.228.225.67] has joined #bitcoin-core-dev
05:35 -!- Guyver2_ [~Guyver@77-174-98-73.fixed.kpn.net] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
05:41 < laanwj> maybe it's no longer necessary to do that: we used to have the options help translatable, this is no longer the case
05:42 < laanwj> no, it's more nasty: on windows we show the help message as a dialog, that's why the logic is so late
05:44 < laanwj> see https://github.com/bitcoin/bitcoin/blob/master/src/qt/utilitydialog.cpp#L124  ; working around this means having to remove that functionality (and always print the help message to stdout), or a really ugly workaround complicating the already delicate initialization sequence even more
05:47 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #22871: Discourage CSV as NOP when locktime disable is set & discourage unknown nSequence (master...discourage-csv) https://github.com/bitcoin/bitcoin/pull/22871
05:52 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has joined #bitcoin-core-dev
06:01 -!- furszy [~furszy@186.141.197.251] has joined #bitcoin-core-dev
06:15 < bitcoin-git> [bitcoin] fanquake closed pull request #24293: (Refactor) QA: wallet_basic: Split wtx expected_fields over multiple lines to minimise merge conflicts (master...qa_wtx_expected_fields_lines) https://github.com/bitcoin/bitcoin/pull/24293
06:21 < bitcoin-git> [bitcoin] fanquake closed pull request #18689: rpc: allow dumptxoutset to dump human-readable data (master...feature-utxo-ascii) https://github.com/bitcoin/bitcoin/pull/18689
06:26 < bitcoin-git> [bitcoin] fanquake closed pull request #19358: torcontrol : avoid to set wrong outbound proxy and network settings when creating an inbound onion service. (master...pr351-bitcoin) https://github.com/bitcoin/bitcoin/pull/19358
06:27 < bitcoin-git> [bitcoin] fanquake closed pull request #19880: fix CTxMemPool::TrimToSize to put only confirmed coins in pvNoSpendsRemaining (master...simplify-trimtosize) https://github.com/bitcoin/bitcoin/pull/19880
06:29 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev
06:30 < bitcoin-git> [bitcoin] fanquake closed pull request #18988: RFC: Introducing AltNet, a pluggable framework for alternative transports (master...2020-05-rfc-altstack) https://github.com/bitcoin/bitcoin/pull/18988
06:41 < bitcoin-git> [bitcoin] fanquake closed pull request #21158: lib: Add Taproot support to libconsensus (master...libconsensus_taproot) https://github.com/bitcoin/bitcoin/pull/21158
06:43 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 240 seconds]
06:45 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
06:48 -!- furszy [~furszy@186.141.197.251] has quit []
06:58 < bitcoin-git> [bitcoin] theStack opened pull request #25115: scripted-diff: replace non-standard fixed width integer types (`u_int`... - `uint`...) (master...202205-refactor-replace_non_std_fixed_width_integer_types) https://github.com/bitcoin/bitcoin/pull/25115
07:11 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Quit: 404]
07:13 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev
07:16 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #25117: test: Check msg type in msg capture is followed by zeros (master...2205-test-zero-🚛) https://github.com/bitcoin/bitcoin/pull/25117
07:20 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
07:29 -!- jonatack [jonatack@user/jonatack] has quit [Quit: Connection closed]
07:35 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
07:37 -!- david-bakin [~david-bak@c-174-61-163-5.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
07:41 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
07:43 -!- nanotube [~nanotube@user/nanotube] has joined #bitcoin-core-dev
07:47 -!- mikehu44_ [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 240 seconds]
07:49 < bitcoin-git> [bitcoin] furszy opened pull request #25118: wallet: unify “allow/block other inputs“ concept (master...2022_coinControl_unify_allowOtherInputs) https://github.com/bitcoin/bitcoin/pull/25118
07:52 -!- ZeroMaster [~webirc@90-154-206-39.ip.btc-net.bg] has joined #bitcoin-core-dev
07:53 -!- furszy [~furszy@186.141.197.251] has joined #bitcoin-core-dev
08:02 -!- furszy [~furszy@186.141.197.251] has quit [Quit: Client closed]
08:08 -!- sipsorcery [~sipsorcer@37.228.225.67] has quit [Ping timeout: 256 seconds]
08:12 -!- jonatack [jonatack@user/jonatack] has joined #bitcoin-core-dev
08:24 -!- sipsorcery [~sipsorcer@37.228.225.67] has joined #bitcoin-core-dev
08:33 -!- ronoaldo [~ronoaldo@191.19.24.11] has joined #bitcoin-core-dev
08:53 < bitcoin-git> [bitcoin] jonatack opened pull request #25119: net, refactor: move StartExtraBlockRelayPeers() from header to implementation (master...move-StartExtraBlockRelayPeers-from-header-to-implementation) https://github.com/bitcoin/bitcoin/pull/25119
09:29 -!- jonatack [jonatack@user/jonatack] has quit [Ping timeout: 260 seconds]
09:31 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 260 seconds]
09:55 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev
09:57 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Client Quit]
09:59 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev
10:04 -!- bomb-on [~bomb-on@user/bomb-on] has joined #bitcoin-core-dev
10:06 -!- pkwsj [~pkwsj@66.44.113.38] has joined #bitcoin-core-dev
10:13 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
10:31 -!- pkwsj [~pkwsj@66.44.113.38] has quit [Ping timeout: 252 seconds]
10:33 -!- jonatack [jonatack@user/jonatack] has joined #bitcoin-core-dev
11:04 -!- sipsorcery [~sipsorcer@37.228.225.67] has quit [Ping timeout: 276 seconds]
11:24 -!- sipsorcery [~sipsorcer@37.228.225.67] has joined #bitcoin-core-dev
11:33 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Quit: Leaving...]
11:35 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f9c0:53d9:d76e:e362] has quit [Remote host closed the connection]
11:46 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f9c0:53d9:d76e:e362] has joined #bitcoin-core-dev
11:53 < bitcoin-git> [bitcoin] jonatack opened pull request #25120: test: fix DWARF string_view linker error in blockfilter_tests (master...fix-DWARF-string_view-linker-error) https://github.com/bitcoin/bitcoin/pull/25120
11:57 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
11:59 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev
12:00 -!- jonhbit [~jonhbit@130.44.168.202] has joined #bitcoin-core-dev
12:01 < laanwj> #startmeeting
12:01 < core-meetingbot> Meeting started Thu May 12 19:01:15 2022 UTC.  The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
12:01 < core-meetingbot> Available commands: action commands idea info link nick
12:01 < Murch> hi
12:01 < sipsorcery> hi
12:01 < _aj_> hiii
12:01 < fanquake> hi
12:01 < laanwj> hii
12:01 < ariard> hi
12:02 < laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball
12:02 < laanwj> morcos nehan NicolasDorier paveljanik petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild
12:02 < jonatack> hallo
12:02 < laanwj> it looks like no topics have been proposed in advance this week
12:02 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
12:02 < sipa> hi
12:03 < laanwj> it could be that glozow would like to talk about package relay updates again
12:03 < laanwj> any last minute topics?
12:04 < kvaciral> hi!
12:04 < jeremyrubin> sup
12:04 < _aj_> glozow said "another week" not "next week" last week
12:04 < laanwj> _aj_: oh, right
12:05 < laanwj> i wasn't sure
12:05 < _aj_> laanwj: me either, but irc logs don't lie right
12:05 < laanwj> #topic High priority for review
12:05 < core-meetingbot> topic: High priority for review
12:06 < _aj_> review beg for #24032 and #25109
12:06 <@gribble> https://github.com/bitcoin/bitcoin/issues/24032 | Add defaults to vDeployments to avoid uninitialized variables by ajtowns · Pull Request #24032 · bitcoin/bitcoin · GitHub
12:06 <@gribble> https://github.com/bitcoin/bitcoin/issues/25109 | Strengthen AssertLockNotHeld assertions by ajtowns · Pull Request #25109 · bitcoin/bitcoin · GitHub
12:06 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Client Quit]
12:06 -!- furszy [~furszy@186.143.133.115] has joined #bitcoin-core-dev
12:06 < laanwj> https://github.com/bitcoin/bitcoin/projects/8 has: 13 blockers, 1 chasing conept ACK
12:07 < laanwj> anything to add, remove, or that is on the list and (almost) ready for merge?
12:08 < jeremyrubin> Would be good to get more conceptual review on #22876, which is a precursor for my high prio. has conceptual ack that this is a bit of an issue in how our script flag system is set up, is an issue that affects any and all R&D on things that happen in script wrt discouraging (e.g. CTV, APO, etc). 
12:08 <@gribble> https://github.com/bitcoin/bitcoin/issues/22876 | [TESTS] Update Transaction Tests to permit setting a flag as always on and disabling the exhaustive failure test by JeremyRubin · Pull Request #22876 · bitcoin/bitcoin · GitHub
12:08 < jeremyrubin> but it seems that theres some sentiment there might be a 'purer' way to handle it... i dont have any other ideas other than what i did
12:10 < laanwj> should i add it to chasing concept ACK?
12:11 < jeremyrubin> i'm not sure
12:11 < jeremyrubin> maybe _aj_ should have a look since he's maintaining the APO branch?
12:11 < jeremyrubin> How would you write test vectors for APO without these patches?
12:11 < laanwj> oh, just added it
12:12 < jeremyrubin> seems fine
12:13 < jeremyrubin> i just want to underscore this isn't a ctv specific precursor, impacts anyone working on any opcode stuff if you want to write test vectors. so please review if you're doing that at all
12:13 < laanwj> yes it seems like a pretty general tests change, judging from the title
12:14 < laanwj> anything else to add/remove? any other topics people would like to discuss?
12:14 < _aj_> jeremyrubin: will look
12:15 -!- furszy [~furszy@186.143.133.115] has quit [Quit: Client closed]
12:16 < jeremyrubin> ah also #22954 is related to the earlier one for any following along, equivalent for tx_valid/tx_invalid
12:16 <@gribble> https://github.com/bitcoin/bitcoin/issues/22954 | [TESTS] Allow tx_invalid.json tests to include flag rules for if_unset: [A,B,C] then_unset: [D] by JeremyRubin · Pull Request #22954 · bitcoin/bitcoin · GitHub
12:16 < jeremyrubin> probably getting the first one looked over would be sufficient for now though
12:17 < laanwj> better to focus on one at a time probably
12:18 < laanwj> seems no other topics! well, another short meeting then, hope you can use the rest of the time for reviewing :)
12:18 < laanwj> #endmeeting
12:18 < core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
12:18 < core-meetingbot> Meeting ended Thu May 12 19:18:12 2022 UTC.  
12:18 < core-meetingbot> Minutes:        https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2022/bitcoin-core-dev.2022-05-12-19.01.moin.txt
12:18 -!- furszy [~furszy@186.143.133.115] has joined #bitcoin-core-dev
12:18 < jonatack> :)
12:19 < dongcarl> Hi all, just wanted to let folks know that the libbitcoinkernel 2b (#25064) and 2c ( #25065) PRs are not dependent on the much longer kernel 2a PR, they are completely separate and much shorter! 
12:19 <@gribble> https://github.com/bitcoin/bitcoin/issues/25064 | [kernel 2b/n] Add `ChainstateManager::m_adjusted_time_callback` by dongcarl · Pull Request #25064 · bitcoin/bitcoin · GitHub
12:19 <@gribble> https://github.com/bitcoin/bitcoin/issues/25065 | [kernel 2c/n] Extract only what we use of `init/common.cpp` by dongcarl · Pull Request #25065 · bitcoin/bitcoin · GitHub
12:21 -!- furszy [~furszy@186.143.133.115] has quit [Changing host]
12:21 -!- furszy [~furszy@user/furszy] has joined #bitcoin-core-dev
12:22 < jonatack> dongcarl: do you have any preference regarding which one to look at first?
12:23 -!- furszy [~furszy@user/furszy] has quit [Quit: Client closed]
12:25 -!- furszy [~furszy@user/furszy] has joined #bitcoin-core-dev
12:25 < jonatack> (24410, i guess)
12:28 < laanwj> dongcarl: thanks for the update!
12:28 -!- bomb-on [~bomb-on@user/bomb-on] has quit [Quit: aллилѹіа!]
12:30 < dongcarl> jonatack: No strong preference at all. I appreciate any review on any open PR!
12:37 -!- jonhbit [~jonhbit@130.44.168.202] has quit [Quit: Client closed]
12:40 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
12:47 < david-bakin> Can someone take a quick look at a failing `lint` run - https://cirrus-ci.com/task/5219398502842368 - I can't figure out what the error is referring to - doesn't mention a filename - how can I fix this?  Thank you!  "UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe0 in position 1141: invalid continuation byte"
12:47 < david-bakin> Seems to be when checking circular dependencies which is very odd since the only thing that is supposed to be in this PR is a new unit test.
12:48 -!- kexkey_ [~kexkey@178.249.214.20] has joined #bitcoin-core-dev
12:48 -!- kexkey_ [~kexkey@178.249.214.20] has quit [Client Quit]
12:49 < david-bakin> I suppose I should give the link to the PR, huh?  OK: https://github.com/bitcoin/bitcoin/pull/25097
12:50 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection]
12:50 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
12:51 -!- Guest33 [~Guest33@dslb-084-060-034-236.084.060.pools.vodafone-ip.de] has joined #bitcoin-core-dev
12:51 -!- kexkey [~kexkey@178.249.214.10] has quit [Ping timeout: 252 seconds]
12:53 -!- kexkey [~kexkey@178.249.214.20] has joined #bitcoin-core-dev
12:54 < sipa> these aren't really "full" death tests . la Googletest as it is not trapping
12:54 < sipa> That . is a non-UTF8 character.
12:54 < sipa> In the new file you're adding.
12:55 < sipa> The circular dependency test is trying to parse your added file, and failing.
12:56 -!- bomb-on [~bomb-on@user/bomb-on] has joined #bitcoin-core-dev
12:56 < jonatack> david-bakin: you can try running those 3 failing linters on the command line with your changes to check locally
12:59 < jonatack> i use a bash alias for checking functional tests; it cds into root and does: test/lint/lint-circular-dependencies.py ; ./test/lint/lint-python.py ; ./test/lint/lint-whitespace.py
12:59 -!- BUSY [~BUSY@user/busy] has quit [Ping timeout: 246 seconds]
12:59 < david-bakin> oh.  i thought that a-with-accent was just a unicode char i pasted in.  thanks for the instruction on how to run the linters locally, I will do that from now on
13:00 < sipa> It is a unicode character, but it's not UTF-8 encoded.
13:00 < _aj_> dongcarl: #24595?
13:00 <@gribble> https://github.com/bitcoin/bitcoin/issues/24595 | deploymentstatus: move g_versionbitscache global to ChainstateManager by ajtowns · Pull Request #24595 · bitcoin/bitcoin · GitHub
13:00 < sipa> It appears to be ISO8859-1
13:00 < jonatack> *for checking all pull requests actually
13:00 < david-bakin> eek.  then vscode did the wrong thing.  i'll have to be careful!
13:01 < sipa> iso8859-1 is common in microsoft land, i think
13:01 < sipa> https://stackoverflow.com/questions/30082741/change-the-encoding-of-a-file-in-visual-studio-code may be relevant
13:02 < david-bakin> ty! (again, as usual!)
13:03 < david-bakin> BTW, what happens if I push a change to a PR while the previous set of CI jobs are still running?  Do they get cancelled and replaced?
13:04 < sipa> yes
13:04 < david-bakin> ok
13:04 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has quit [Ping timeout: 256 seconds]
13:04 < dongcarl> _aj_: Re-review time?
13:07 < _aj_> dongcarl: pretty trivial rebase
13:08 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/dd9f61a184d4...2709ffb9da42
13:08 < bitcoin-git> bitcoin/master 672d49c Sebastian Falbesoner: scripted-diff: replace non-standard fixed width integer types (`u_int`...`...
13:08 < bitcoin-git> bitcoin/master 2709ffb fanquake: Merge bitcoin/bitcoin#25115: scripted-diff: replace non-standard fixed wid...
13:08 < bitcoin-git> [bitcoin] fanquake merged pull request #25115: scripted-diff: replace non-standard fixed width integer types (`u_int`... - `uint`...) (master...202205-refactor-replace_non_std_fixed_width_integer_types) https://github.com/bitcoin/bitcoin/pull/25115
13:09 < dongcarl> _aj_: Cool, will take a look
13:13 -!- furszy [~furszy@user/furszy] has quit [Quit: Ping timeout (120 seconds)]
13:15 < bitcoin-git> [bitcoin] fanquake closed pull request #25120: test: fix DWARF string_view linker error in blockfilter_tests (master...fix-DWARF-string_view-linker-error) https://github.com/bitcoin/bitcoin/pull/25120
13:20 -!- furszy [~furszy@user/furszy] has joined #bitcoin-core-dev
13:23 -!- furszy [~furszy@user/furszy] has quit [Client Quit]
13:28 -!- l2xl [~l2xl@188.170.194.55] has joined #bitcoin-core-dev
13:29 -!- bomb-on [~bomb-on@user/bomb-on] has quit [Quit: aллилѹіа!]
13:32 -!- BUSY [~BUSY@user/busy] has joined #bitcoin-core-dev
13:41 -!- bomb-on [~bomb-on@user/bomb-on] has joined #bitcoin-core-dev
13:42 -!- djb27_ [djb27@user/djb27] has joined #bitcoin-core-dev
13:45 -!- djb27__ [~djb27@user/djb27] has quit [Ping timeout: 256 seconds]
13:55 < bitcoin-git> [bitcoin] brunoerg opened pull request #25121: test: compare `/mempool/info` response with `getmempoolinfo` RPC (master...2022-05-rest-mempool-info) https://github.com/bitcoin/bitcoin/pull/25121
13:58 -!- Guest33 [~Guest33@dslb-084-060-034-236.084.060.pools.vodafone-ip.de] has quit [Ping timeout: 252 seconds]
14:11 -!- bomb-on [~bomb-on@user/bomb-on] has quit [Quit: aллилѹіа!]
14:32 -!- bomb-on [~bomb-on@user/bomb-on] has joined #bitcoin-core-dev
14:34 < bitcoin-git> [bitcoin] furszy opened pull request #25122: rpc: getreceivedbylabel, return early if no addresses were found in the address book. (master...2022_RPC_getreceivedbylabel_return_early) https://github.com/bitcoin/bitcoin/pull/25122
14:43 -!- kexkey [~kexkey@178.249.214.20] has quit [Quit: kexkey]
14:46 -!- djb27__ [~djb27@user/djb27] has joined #bitcoin-core-dev
14:46 -!- kexkey [~kexkey@178.249.214.20] has joined #bitcoin-core-dev
14:50 -!- djb27_ [djb27@user/djb27] has quit [Ping timeout: 276 seconds]
14:50 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:52 -!- djb27__ [~djb27@user/djb27] has quit [Ping timeout: 240 seconds]
15:03 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f9c0:53d9:d76e:e362] has quit [Remote host closed the connection]
15:04 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Ping timeout: 240 seconds]
15:04 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
15:08 -!- djb27__ [~djb27@user/djb27] has joined #bitcoin-core-dev
15:19 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:f9c0:53d9:d76e:e362] has joined #bitcoin-core-dev
15:29 -!- Acen [~acen@user/acen] has joined #bitcoin-core-dev
15:35 -!- sipsorcery [~sipsorcer@37.228.225.67] has quit [Ping timeout: 246 seconds]
15:42 -!- bomb-on [~bomb-on@user/bomb-on] has quit [Quit: aллилѹіа!]
15:47 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
15:52 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has quit [Quit: Connection closed for inactivity]
15:58 -!- l2xl [~l2xl@188.170.194.55] has quit [Remote host closed the connection]
16:04 < bitcoin-git> [bitcoin] fjahr opened pull request #25123: test: Use addconnection for robustness in index prune test (master...202205-index-prune-fix) https://github.com/bitcoin/bitcoin/pull/25123
16:15 -!- Acen [~acen@user/acen] has quit []
17:24 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
17:58 -!- kexkey [~kexkey@178.249.214.20] has quit [Quit: kexkey]
18:04 -!- kexkey [~kexkey@178.249.214.20] has joined #bitcoin-core-dev
18:16 -!- agrosant [~agrosant@79.103.56.172.dsl.dyn.forthnet.gr] has quit [Quit: Leaving]
18:27 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has joined #bitcoin-core-dev
19:57 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has quit [Read error: Connection reset by peer]
19:58 -!- z9z0b3t1c [z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c] has joined #bitcoin-core-dev
20:06 -!- a1ph4byte [~a1ph4byte@70.228.72.132] has quit [Remote host closed the connection]
20:51 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Ping timeout: 246 seconds]
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:04 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev
21:11 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds]
21:11 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
21:23 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds]
21:24 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
21:28 -!- mikehu44_ [~quassel@gateway/vpn/pia/mikehu44-jc] has joined #bitcoin-core-dev
21:31 -!- mikehu44 [~quassel@gateway/vpn/pia/mikehu44-jc] has quit [Ping timeout: 240 seconds]
21:40 -!- jarthur_ is now known as jarthur
21:53 -!- ronoaldo [~ronoaldo@191.19.24.11] has quit [Quit: Konversation terminated!]
21:55 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev
21:56 -!- david-bakin [~david-bak@c-174-61-163-5.hsd1.wa.comcast.net] has quit [Ping timeout: 252 seconds]
22:16 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Ping timeout: 248 seconds]
22:30 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2709ffb9da42...fe1fcdc62916
22:30 < bitcoin-git> bitcoin/master 1df42bc brunoerg: test: compare `/mempool/info` response with `getmempoolinfo` RPC
22:30 < bitcoin-git> bitcoin/master fe1fcdc MacroFake: Merge bitcoin/bitcoin#25121: test: compare `/mempool/info` response with `...
22:30 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #25121: test: compare `/mempool/info` response with `getmempoolinfo` RPC (master...2022-05-rest-mempool-info) https://github.com/bitcoin/bitcoin/pull/25121
22:48 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fe1fcdc62916...b3f0a34389a4
22:48 < bitcoin-git> bitcoin/master 51ec96b Jon Atack: refactor: move StartExtraBlockRelayPeers from header to implementation
22:48 < bitcoin-git> bitcoin/master b3f0a34 MacroFake: Merge bitcoin/bitcoin#25119: net, refactor: move StartExtraBlockRelayPeers...
22:48 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #25119: net, refactor: move StartExtraBlockRelayPeers() from header to implementation (master...move-StartExtraBlockRelayPeers-from-header-to-implementation) https://github.com/bitcoin/bitcoin/pull/25119
22:50 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b3f0a34389a4...1d5325a8f975
22:50 < bitcoin-git> bitcoin/master faa5a7a MacroFake: test: Check msg type in msg capture is followed by zeros
22:50 < bitcoin-git> bitcoin/master 1d5325a MacroFake: Merge bitcoin/bitcoin#25117: test: Check msg type in msg capture is follow...
22:50 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #25117: test: Check msg type in msg capture is followed by zeros (master...2205-test-zero-🚛) https://github.com/bitcoin/bitcoin/pull/25117
23:20 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev
--- Log closed Fri May 13 00:00:21 2022