--- Log opened Mon Aug 15 00:00:50 2022
00:21 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
00:56 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 268 seconds]
00:58 -!- justache [~justache@user/justache] has joined #bitcoin-core-dev
01:18 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
01:37 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
01:44 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
01:48 -!- aleggg [~aleggg@189.58.176.168.dynamic.adsl.gvt.net.br] has joined #bitcoin-core-dev
02:00 -!- adam2k[m] [~adam2kmat@2001:470:69fc:105::2:48e1] has quit [Quit: You have been kicked for being idle]
02:08 < michaelfolkson> Which maintainer is hosting the IRC Core dev meetings going forward? 
02:08 < michaelfolkson> [20:32:46]  <hebasto> #proposedmeetingtopic CMake-based build system (pr25797)
02:09 < michaelfolkson> This will be a big topic :)
02:11 < michaelfolkson> Not sure if the build guys have softened on this idea or not since it was rejected a couple of years ago
02:13 < Earnestly> Would it not be meson or bazel or some other new hotness
02:17 < michaelfolkson> Not sure if CMake can be considered the "new hotness" after two decades :)
02:18 < Earnestly> (That was the point)
02:20 < michaelfolkson> Ah ok. Yeah generally the new hotness isn't the right fit for this project, don't want to keep switching to the next shiny thing
02:32 < Earnestly> michaelfolkson: Perhaps but the point was if a new build system is considered they might consider those newer iterations instead
02:44 -!- Guest30 [~Guest30@217.33.79.34] has joined #bitcoin-core-dev
02:47 -!- weez22 [~weez22@user/weez22] has joined #bitcoin-core-dev
02:52 -!- justache [~justache@user/justache] has quit [Quit: ZNC 1.8.2 - https://znc.in]
02:52 -!- justache [~justache@user/justache] has joined #bitcoin-core-dev
02:54 -!- evanlinj1 [~root@gateway/tor-sasl/evanlinjin] has quit [Remote host closed the connection]
02:55 -!- Guest30 [~Guest30@217.33.79.34] has quit [Quit: Ping timeout (120 seconds)]
02:56 -!- evanlinj1 [~root@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev
02:58 -!- evanlinj1 [~root@gateway/tor-sasl/evanlinjin] has quit [Remote host closed the connection]
02:58 -!- evanlinj1 [~root@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev
03:02 < bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/dc9d6626835e...cc1efe909e99
03:02 < bitcoin-git> bitcoin/master 968ea66 Hennadii Stepanov: build: Adjust `qt/guix_cross_lib_path.patch`
03:02 < bitcoin-git> bitcoin/master a2e733b Hennadii Stepanov: doc: Remove no longer needed comments
03:02 < bitcoin-git> bitcoin/master d61f667 Hennadii Stepanov: build: Add objcopy host tool
03:02 < bitcoin-git> [bitcoin] fanquake merged pull request #25838: build, qt: Use `mkspecs/bitcoin-linux-g++` for all Linux hosts (master...220813-mkspec) https://github.com/bitcoin/bitcoin/pull/25838
03:19 -!- justache [~justache@user/justache] has quit [Remote host closed the connection]
03:20 -!- justache [~justache@user/justache] has joined #bitcoin-core-dev
03:27 -!- justache [~justache@user/justache] has quit [Remote host closed the connection]
03:28 -!- justache [~justache@user/justache] has joined #bitcoin-core-dev
03:29 -!- justache [~justache@user/justache] has quit [Remote host closed the connection]
03:29 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 252 seconds]
03:29 -!- justache [~justache@user/justache] has joined #bitcoin-core-dev
03:34 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/cc1efe909e99...2778cccf1c3d
03:34 < bitcoin-git> bitcoin/master 08269e5 fanquake: Squashed 'src/crc32c/' changes from 0d624261ef..0bac72c455
03:34 < bitcoin-git> bitcoin/master 9546b3a fanquake: Update crc32c subtree to latest upstream master
03:34 < bitcoin-git> bitcoin/master 2778ccc MacroFake: Merge bitcoin/bitcoin#25836: subtree: update crc32c subtree
03:34 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #25836: subtree: update crc32c subtree (master...update_crc32_subtree) https://github.com/bitcoin/bitcoin/pull/25836
03:36 < bitcoin-git> [gui] laanwj opened pull request #654: qt: Update source translations for string freeze (master...2022-08-string-freeze) https://github.com/bitcoin-core/gui/pull/654
03:36 -!- justache [~justache@user/justache] has quit [Remote host closed the connection]
03:37 -!- justache [~justache@user/justache] has joined #bitcoin-core-dev
03:42 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #25849: refactor: Remove not needed empty RPC doc std::string (master...2208-doc-str-🤑) https://github.com/bitcoin/bitcoin/pull/25849
03:42 -!- justache [~justache@user/justache] has quit [Remote host closed the connection]
03:43 -!- justache [~justache@user/justache] has joined #bitcoin-core-dev
03:48 -!- justache [~justache@user/justache] has quit [Remote host closed the connection]
03:51 < bitcoin-git> [bitcoin] laanwj opened pull request #25850: doc: Remove my key from SECURITY.md (master...2022-08-security-md) https://github.com/bitcoin/bitcoin/pull/25850
03:54 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 244 seconds]
03:56 < laanwj> michaelfolkson: I'm fine with doing the meetings for now, I'm stepping down as maintainer I'm not quitting bitcoin dev completely
03:57 < laanwj> but if someone would like to take it over that's fine with me too ofc
03:58 < michaelfolkson> Ah cool, sounds good to me
04:00 -!- justache [~justache@user/justache] has joined #bitcoin-core-dev
04:03 -!- justache [~justache@user/justache] has quit [Remote host closed the connection]
04:03 -!- justache [~justache@user/justache] has joined #bitcoin-core-dev
04:04 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
04:08 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
04:08 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
04:21 -!- justache [~justache@user/justache] has quit [Quit: ZNC 1.8.2 - https://znc.in]
04:21 -!- justache [~justache@user/justache] has joined #bitcoin-core-dev
04:22 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
04:48 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4da7:8a6e:1928:b82e] has joined #bitcoin-core-dev
05:00 < hebasto> Earnestly: Re "Would it not be meson or bazel or some other new hotness" -- the main reason is the fact that Qt 6 uses CMake
05:02 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection]
05:04 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
05:06 < MacroFake> I think the 0.18 branch can be deleted now
05:14 -!- justache [~justache@user/justache] has quit [Quit: ZNC 1.8.2 - https://znc.in]
05:15 -!- justache [~justache@user/justache] has joined #bitcoin-core-dev
05:35 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2778cccf1c3d...d9cd8b419cf9
05:35 < bitcoin-git> bitcoin/master fac09f4 MacroFake: refactor: Remove not needed empty RPC doc std::string
05:35 < bitcoin-git> bitcoin/master d9cd8b4 fanquake: Merge bitcoin/bitcoin#25849: refactor: Remove not needed empty RPC doc std...
05:35 < bitcoin-git> [bitcoin] fanquake merged pull request #25849: refactor: Remove not needed empty RPC doc std::string (master...2208-doc-str-🤑) https://github.com/bitcoin/bitcoin/pull/25849
05:37 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d9cd8b419cf9...a5d5569535b3
05:37 < bitcoin-git> bitcoin/master 38a911e laanwj: doc: Remove my key from SECURITY.md
05:37 < bitcoin-git> bitcoin/master a5d5569 MacroFake: Merge bitcoin/bitcoin#25850: doc: Remove my key from SECURITY.md
05:37 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #25850: doc: Remove my key from SECURITY.md (master...2022-08-security-md) https://github.com/bitcoin/bitcoin/pull/25850
05:46 < Earnestly> hebasto: Oh yes, I forgot that bit.  There was an issue about them reimplementing pkg-config .pc files but I haven't looked
05:58 < bitcoin-git> [bitcoin] fanquake opened pull request #25851: doc: remove msvc qt build instructions (master...remove_msvc_qt_build_instructions) https://github.com/bitcoin/bitcoin/pull/25851
06:14 < bitcoin-git> [bitcoin] fanquake opened pull request #25852: build: reorder CXXFLAGS in intrinsic checks (master...reorganise_intrinsic_flags) https://github.com/bitcoin/bitcoin/pull/25852
06:19 < bitcoin-git> [bitcoin] fanquake closed pull request #24985: doc, test: Compilation for 64-bit Windows with msys2 (master...msys2-windows-build) https://github.com/bitcoin/bitcoin/pull/24985
06:19 < bitcoin-git> [bitcoin] fanquake closed pull request #22472: fuzz: Add environment option to keep /tmp/ clean (master...master) https://github.com/bitcoin/bitcoin/pull/22472
06:24 -!- lukedashjr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
06:24 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 268 seconds]
06:26 < bitcoin-git> [bitcoin] jonatack opened pull request #25853: contrib: update testnet torv3 hardcoded seeds (master...torv3-testnet-hardcoded-seeds) https://github.com/bitcoin/bitcoin/pull/25853
06:26 -!- lukedashjr is now known as luke-jr
06:28 -!- MacroFake [~none@72.5.34.65] has quit [Quit: ZNC 1.7.5+deb4 - https://znc.in]
06:30 -!- MacroFake [~none@72.5.34.65] has joined #bitcoin-core-dev
06:31 -!- Guyver2_ [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
06:33 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has quit [Ping timeout: 256 seconds]
06:35 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has joined #bitcoin-core-dev
06:40 -!- MacroFake [~none@72.5.34.65] has quit [Quit: ZNC 1.7.5+deb4 - https://znc.in]
06:40 -!- MacroFake [~none@72.5.34.65] has joined #bitcoin-core-dev
06:41 -!- Guest7 [~Guest7@185.123.0.212] has joined #bitcoin-core-dev
06:42 -!- Guest7 [~Guest7@185.123.0.212] has quit [Client Quit]
06:43 -!- Guest7 [~Guest7@185.123.0.212] has joined #bitcoin-core-dev
06:45 -!- Guest7 [~Guest7@185.123.0.212] has quit [Client Quit]
06:54 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 248 seconds]
07:50 -!- justache [~justache@user/justache] has quit [Remote host closed the connection]
07:50 -!- justache [~justache@user/justache] has joined #bitcoin-core-dev
07:55 -!- mimmy [~mimmy@153.92.40.237] has joined #bitcoin-core-dev
08:00 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
08:06 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
08:14 -!- pablomartin [~pablomart@185.93.182.252] has joined #bitcoin-core-dev
08:19 -!- mimmy [~mimmy@153.92.40.237] has quit [Ping timeout: 256 seconds]
08:30 -!- mimmy [~mimmy@153.92.40.199] has joined #bitcoin-core-dev
08:30 -!- mimmy [~mimmy@153.92.40.199] has quit [Client Quit]
08:38 -!- Guest42 [~Guest42@180.251.222.255] has joined #bitcoin-core-dev
08:40 -!- Guest42 [~Guest42@180.251.222.255] has quit [Client Quit]
08:42 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 268 seconds]
09:00 -!- jarthur [~jarthur@user/jarthur] has joined #bitcoin-core-dev
09:09 < laanwj> MacroFake: agree, may want to make a 0.18-final tag first if there's commits on that branch that haven't made it into a release, if not it can just be removed
09:26 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection]
09:31 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
10:06 -!- pablomartin [~pablomart@185.93.182.252] has quit [Quit: Leaving]
10:18 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection]
10:20 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
10:23 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
10:37 -!- Guyver2_ [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev []
10:39 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
10:54 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 248 seconds]
10:59 < S3RK> I don't see CI running for the latest push in #25647 ? How can I kick it?
10:59 <@gribble> https://github.com/bitcoin/bitcoin/issues/25647 | wallet: return change from SelectionResult by S3RK · Pull Request #25647 · bitcoin/bitcoin · GitHub
11:00 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
11:03 < hebasto> S3RK: done
11:07 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 256 seconds]
11:09 -!- erik-ets1 [~erik@gateway/tor-sasl/erik-etsuji-kato] has joined #bitcoin-core-dev
11:09 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
11:14 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection]
11:14 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
11:27 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 268 seconds]
11:35 < bitcoin-git> [gui] hebasto merged pull request #654: Update source translations for string freeze (master...2022-08-string-freeze) https://github.com/bitcoin-core/gui/pull/654
11:35 < bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a5d5569535b3...867f5fd1b356
11:35 < bitcoin-git> bitcoin/master fcc0c84 laanwj: qt: Update source translations for string freeze
11:35 < bitcoin-git> bitcoin/master 867f5fd Hennadii Stepanov: Merge bitcoin-core/gui#654: Update source translations for string freeze
11:38 < bitcoin-git> [gui] hebasto merged pull request #598: Avoid recalculating the wallet balance - use model cache (master...2022_GUI_use_model_cached_balance) https://github.com/bitcoin-core/gui/pull/598
11:38 < bitcoin-git> [bitcoin] hebasto pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/867f5fd1b356...6d4889a694da
11:38 < bitcoin-git> bitcoin/master e62958d furszy: GUI: sendCoinsDialog, remove duplicate wallet().getBalances() call
11:38 < bitcoin-git> bitcoin/master 321335b furszy: GUI: add getter for WalletModel::m_cached_balances field
11:38 < bitcoin-git> bitcoin/master 96e3264 furszy: GUI: use cached balance in overviewpage and sendcoinsdialog
11:39 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
11:53 -!- erik-ets1 [~erik@gateway/tor-sasl/erik-etsuji-kato] has quit [Ping timeout: 268 seconds]
11:55 -!- erik-ets1 [~erik@gateway/tor-sasl/erik-etsuji-kato] has joined #bitcoin-core-dev
12:02 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
12:29 < jonatack> #25614 seems ready for merge
12:29 <@gribble> https://github.com/bitcoin/bitcoin/issues/25614 | logging: add `-loglevel` configuration option and a `trace` log level by jonatack · Pull Request #25614 · bitcoin/bitcoin · GitHub
12:32 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection]
12:38 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
12:43 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection]
12:43 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
12:44 < bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/6d4889a694da...22d96d76ab02
12:44 < bitcoin-git> bitcoin/master 05f7f31 Suhas Daftuar: Reduce bandwidth during initial headers sync when a block is found
12:44 < bitcoin-git> bitcoin/master f6a9166 Suhas Daftuar: Add functional test for block announcements during initial headers sync
12:44 < bitcoin-git> bitcoin/master 22d96d7 Andrew Chow: Merge bitcoin/bitcoin#25720: p2p: Reduce bandwidth during initial headers ...
12:44 < bitcoin-git> [bitcoin] achow101 merged pull request #25720: p2p: Reduce bandwidth during initial headers sync when a block is found (master...2022-07-reduce-headers-sync-bandwidth) https://github.com/bitcoin/bitcoin/pull/25720
13:01 -!- cryptapus [~cryptapus@user/cryptapus] has quit [Quit: Konversation terminated!]
13:06 < brunoerg> can someone pls kick CI for #25412?
13:06 <@gribble> https://github.com/bitcoin/bitcoin/issues/25412 | rest: add `/deploymentinfo` endpoint by brunoerg · Pull Request #25412 · bitcoin/bitcoin · GitHub
13:07 < hebasto> brunoerg: done
13:14 < fanquake> Anyone opposed to kicking the feature freeze date in #24987 back a week?
13:14 < fanquake> There are a number of worthwhile changes that still need to go in.
13:14 <@gribble> https://github.com/bitcoin/bitcoin/issues/24987 | Release schedule for 24.0 · Issue #24987 · bitcoin/bitcoin · GitHub
13:14 -!- cryptapus [~cryptapus@user/cryptapus] has joined #bitcoin-core-dev
13:15 < achow101> sgtm
13:15 < hebasto> +1
13:15 < fanquake> Will push all dates back 1 week.
13:23 < jarolrod> ack
13:38 < brunoerg> hebasto: thanks
13:43 < lightlike> could a maintainer have a look at #24858?  (see discussion in the last three comments there)
13:43 <@gribble> https://github.com/bitcoin/bitcoin/issues/24858 | incorrect blk file size calculation during reindex results in recoverable blk file corruption by mruddy · Pull Request #24858 · bitcoin/bitcoin · GitHub
13:58 < bitcoin-git> [bitcoin] ishaanam closed pull request #25375: rpc: add minconf option to sendall and fund transaction calls (master...fundrawtransaction_minconf) https://github.com/bitcoin/bitcoin/pull/25375
14:00 -!- evanlinj1 [~root@gateway/tor-sasl/evanlinjin] has quit [Remote host closed the connection]
14:00 -!- evanlinj1 [~root@gateway/tor-sasl/evanlinjin] has joined #bitcoin-core-dev
14:04 -!- brunoerg [~brunoerg@2804:14d:5281:8ae2:4da7:8a6e:1928:b82e] has quit []
14:08 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 244 seconds]
14:10 < _aj_> sipa: no, that's not what i was seeing; i'll update and see if i'm still seeing it
14:12 < bitcoin-git> [bitcoin] SkiingIsFun123 opened pull request #25854: Update tracing.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/25854
14:12 < bitcoin-git> [bitcoin] SkiingIsFun123 opened pull request #25855: Update translation_process.md (master...patch-2) https://github.com/bitcoin/bitcoin/pull/25855
14:27 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Remote host closed the connection]
14:27 < sipa> _aj_: Hmm, interesting.
14:35 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 248 seconds]
14:38 < _aj_> sipa: so maybe i am seeing it happen at the double height inflection point; but it still makes no sense to me why you'd switch to redownloading instead of just feeding the already validated headers through the logic
14:43 < sipa> _aj_: Ah, yes, there I agree. That's what I referred to as "moving the starting point forward" in my earlier message. That's definitely better, but it's somewhat complicated to do right.
14:43 < _aj_> sipa: i don't think you need to move the starting point forward; just pass the skipped headers through as if the peer had sent them to you
14:44 < _aj_> sipa: roughly https://github.com/ajtowns/bitcoin/commit/d7031c60d3788ec7415de9ba1137a035f5387fd8
14:44 -!- darosior [~darosior@194.36.189.246] has quit [Read error: Connection reset by peer]
14:46 -!- darosior [~darosior@194.36.189.246] has joined #bitcoin-core-dev
14:48 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
14:49 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 268 seconds]
14:55 < sipa> Ah, that is equivalent to one of the instances of moving the starting point forward, but restricted to redownloading.
14:56 < _aj_> sipa: well it's moving progress forward, not the starting point per se (m_chain_start is left alone)
14:56 < sipa> Right, during redownload the starting point doesn't actually matter anymore.
14:57 < sipa> In the logic I was working on, I also did something similar during the initial phase.
14:57 < sipa> Where it'd move the start point forward, which causes the redownload to start further ahead.
14:58 < sipa> Maybe that's not actually useful? You'll detect it when redownload starts anyway.
14:58 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
15:08 < sipa> So just to be clear about what this gains us.
15:10 < sipa> I believe it is just this: by skipping ahead more work, it increases the chance that the peer will overtake whatever other sync peers we have (possibly none, if there was one that was further ahead, but disconnected), shortening the time it takes to reach sync.
15:11 < sipa> If the "tip peer" isn't overtaken, it has no real impact, as it wouldn't shorten the time it takes to reach minchainwork, so we'll keep syncing for all the same peers, for all the same time.
15:11 < sipa> Does that sound right?
15:16 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
15:17 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection]
15:17 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 268 seconds]
15:17 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 268 seconds]
15:18 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
15:19 -!- aleggg [~aleggg@189.58.176.168.dynamic.adsl.gvt.net.br] has quit [Ping timeout: 248 seconds]
15:20 < sipa> Ok, reading your code more carefully, this does work different than what I had in mind.
15:21 < sipa> This is comparing received headers against the accepted headers chain. What I was thinking of was comparing commitments against the accepted headers chain.
15:22 < sipa> In your code, is the commitment check even needed? You're already checking the full hash.
15:22 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
15:32 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 268 seconds]
16:04 -!- PaperSword [~PaperSwor@50.126.96.22] has quit [Read error: Connection reset by peer]
16:22 < sipa> Oh, no, you indeed need the commitments to verify that the start point you're jumping to is actually an ancestor of the commitments tip you had earlier, and not on a fork.
16:34 < sipa> @_aj_ I'm a bit concerned that this may interfere with the ability to accept legitimate reorgs. If the peer switches to a different chain in between the two phases, forking off near the sync start point, there is a 1/8 or 1/16 probability that this new chain we receive matches the commitment bits we had earlier, which would cause it to be treated as a mismatching continuation later, rather than as a valid different chain.
16:35 < sipa> I guess it would only be a one-time thing; a retry after that failure would work just fine.
16:48 < luke-jr> is it intentional that the interfaces::Wallet stuff may have multiple instances per CWallet? was looking at hiding CWallet details from the RPC code, but idk if that's a good idea in this case
16:53 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
16:55 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
17:12 < _aj_> sipa: if it switches to a different start point, and doesn't skip headers, there's the same 2**-x chance that some headers will be treated as a valid redownload? i'm just thinking of it as a bandwidth optimisation (don't send me headers i clearly already have), not a meaningful logic change
17:15 < _aj_> sipa: perhaps reorging in the other direction -- where they were on some fork, but are now giving you blocks on the same chain you were expecting, so m_redownload_buffer_last_hash isn't an ancestor of m_last_tip at all would be a case you could detect earlier though
17:19 < sipa> @_aj_ Good point.
17:25 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 256 seconds]
17:35 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 268 seconds]
17:39 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
17:41 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
17:42 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
18:11 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 252 seconds]
18:43 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
18:44 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
18:53 < bitcoin-git> [bitcoin] JeremyRubin opened pull request #25856: [BugFix] Make PSBT serializations 174 compliant by excluding empty taptree from serialization (master...psbt-tap-tree-174-compliance) https://github.com/bitcoin/bitcoin/pull/25856
18:56 -!- hashfunc [~user@2601:5c0:c280:7090:10ce:87b1:d936:a45] has joined #bitcoin-core-dev
19:05 < jeremyrubin> "call coming from inside the house" q... has anyone ever seen their logs flooded with this kind of thing
19:05 < jeremyrubin> 2022-08-16T01:30:09Z ThreadRPCServer incorrect password attempt from 127.0.0.1:52167
19:05 < jeremyrubin> 2022-08-16T01:30:09Z ThreadRPCServer incorrect password attempt from 127.0.0.1:52169
19:07 < jeremyrubin> ah i think it was something i was running w stale cookie file
19:09 -!- jespada [~jespada@2803:9800:9842:8ca9:c034:74:da3:46b7] has quit [Ping timeout: 268 seconds]
19:10 -!- hashfunc [~user@2601:5c0:c280:7090:10ce:87b1:d936:a45] has quit [Remote host closed the connection]
19:11 -!- hashfunc [~user@2601:5c0:c280:7090:10ce:87b1:d936:a45] has joined #bitcoin-core-dev
19:11 -!- jespada [~jespada@2803:9800:9842:8ca9:697e:9a9e:7c3a:1937] has joined #bitcoin-core-dev
19:12 -!- hashfunc [~user@2601:5c0:c280:7090:10ce:87b1:d936:a45] has quit [Remote host closed the connection]
19:15 -!- hashfunc [~user@2601:5c0:c280:7090:10ce:87b1:d936:a45] has joined #bitcoin-core-dev
20:03 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 256 seconds]
20:09 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
20:14 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection]
20:19 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
20:42 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 256 seconds]
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:22 -!- MacroFake [~none@72.5.34.65] has quit [Quit: ZNC 1.7.5+deb4 - https://znc.in]
21:22 -!- MacroFake [~none@72.5.34.65] has joined #bitcoin-core-dev
21:36 -!- hashfunc [~user@2601:5c0:c280:7090:10ce:87b1:d936:a45] has quit [Ping timeout: 255 seconds]
21:51 -!- Heromemo [~Heromemo@176.232.63.89] has joined #bitcoin-core-dev
21:53 -!- Heromemo [~Heromemo@176.232.63.89] has quit [Client Quit]
22:07 -!- sudoforge [~sudoforge@wireguard/tunneler/sudoforge] has quit [Ping timeout: 248 seconds]
22:18 -!- jarthur [~jarthur@user/jarthur] has quit [Quit: jarthur]
22:19 -!- MacroFake [~none@72.5.34.65] has quit [Quit: ZNC 1.7.5+deb4 - https://znc.in]
22:22 -!- test_ [flooded@gateway/vpn/protonvpn/flood/x-43489060] has joined #bitcoin-core-dev
22:23 -!- MacroFake [~none@72.5.34.65] has joined #bitcoin-core-dev
22:26 -!- _flood [flooded@gateway/vpn/protonvpn/flood/x-43489060] has quit [Ping timeout: 268 seconds]
22:26 -!- MacroFake [~none@72.5.34.65] has quit [Client Quit]
22:29 -!- MacroFake [~none@72.5.34.65] has joined #bitcoin-core-dev
22:33 -!- MacroFake [~none@72.5.34.65] has quit [Client Quit]
22:43 -!- MacroFake [~none@72.5.34.65] has joined #bitcoin-core-dev
22:54 -!- MacroFake [~none@72.5.34.65] has quit [Quit: ZNC 1.7.5+deb4 - https://znc.in]
23:02 -!- MacroFake [~none@72.5.34.65] has joined #bitcoin-core-dev
23:11 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
23:37 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
23:37 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
23:39 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/22d96d76ab02...0f90b586863f
23:39 < bitcoin-git> bitcoin/master 98383d6 Stacie: doc: minor updates to guix README
23:39 < bitcoin-git> bitcoin/master 0f90b58 MacroFake: Merge bitcoin/bitcoin#25833: doc: minor updates to guix README
23:39 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #25833: doc: minor updates to guix README (master...update-guix-readme) https://github.com/bitcoin/bitcoin/pull/25833
23:43 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 248 seconds]
23:57 -!- Guest01 [~Guest0@102.132.229.19] has joined #bitcoin-core-dev
23:57 -!- Guest01 [~Guest0@102.132.229.19] has quit [Write error: Broken pipe]
23:58 -!- MHO [~MHO@102.132.229.19] has joined #bitcoin-core-dev
--- Log closed Tue Aug 16 00:00:15 2022