--- Log opened Wed Dec 21 00:00:51 2022
00:08 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8456bfac6ba2...0139a0d5c02a
00:08 < bitcoin-git> bitcoin/master 31fdc54 kdmukai: test: speed up wallet_fundrawtransaction.py and wallet_sendall.py
00:08 < bitcoin-git> bitcoin/master 0139a0d MarcoFalke: Merge bitcoin/bitcoin#26722: test: speed up the two slowest functional tes...
00:08 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #26722: test: speed up the two slowest functional tests by 18-35% via `keypoolrefill()` (master...wallet_fundrawtransaction_speedup) https://github.com/bitcoin/bitcoin/pull/26722
00:31 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500:8854:9c89:b4e9:bf9] has joined #bitcoin-core-dev
00:49 < bitcoin-git> [gui] MarcoFalke merged pull request #687: Load PSBTs using istreambuf_iterator rather than istream_iterator (master...load-psbt-istreambuf) https://github.com/bitcoin-core/gui/pull/687
00:50 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0139a0d5c02a...4cd6b3b55724
00:50 < bitcoin-git> bitcoin/master bb5ea1d Andrew Chow: qt: Load PSBTs using istreambuf_iterator rather than istream_iterator
00:50 < bitcoin-git> bitcoin/master 4cd6b3b MarcoFalke: Merge bitcoin-core/gui#687: Load PSBTs using istreambuf_iterator rather th...
00:54 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #26735: [24.x] qt: Load PSBTs using istreambuf_iterator rather than istream_iterator (24.x...2212-backport-gui-psbt-whitespace-fix-🔈) https://github.com/bitcoin/bitcoin/pull/26735
00:57 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4cd6b3b55724...dd7d82bec03c
00:57 < bitcoin-git> bitcoin/master 97115de Douglas Chimento: doc: Refactor/Format getrawtransaction RPC docs and add ScriptPubKeyDoc fu...
00:57 < bitcoin-git> bitcoin/master dd7d82b fanquake: Merge bitcoin/bitcoin#26734: doc: Fixup getrawtransaction RPC docs
00:57 < bitcoin-git> [bitcoin] fanquake merged pull request #26734: doc: Fixup getrawtransaction RPC docs (master...doc-getrawtransaction) https://github.com/bitcoin/bitcoin/pull/26734
01:04 -!- jonatack1 [~jonatack@user/jonatack] has quit [Ping timeout: 260 seconds]
01:04 -!- jonatack1 [~jonatack@user/jonatack] has joined #bitcoin-core-dev
01:06 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
01:06 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
01:23 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/dd7d82bec03c...3e536ea9ac95
01:23 < bitcoin-git> bitcoin/master 574e50a Hennadii Stepanov: ci: Use `CONFIG_SITE` variable and `--prefix` option properly
01:23 < bitcoin-git> bitcoin/master d3a8434 fanquake: ci: remove --prefix from msan job
01:23 < bitcoin-git> bitcoin/master 3e536ea fanquake: Merge bitcoin/bitcoin#26683: ci: Use `CONFIG_SITE` variable and `--prefix`...
01:23 < bitcoin-git> [bitcoin] fanquake merged pull request #26683: ci: Use `CONFIG_SITE` variable and `--prefix` option properly (master...221210-ci-dep) https://github.com/bitcoin/bitcoin/pull/26683
01:47 -!- gnaf [~gnaf@93-190-140-117.hosted-by-worldstream.net] has joined #bitcoin-core-dev
01:50 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:847b:35f5:3748:7a4b] has joined #bitcoin-core-dev
02:01 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500:8854:9c89:b4e9:bf9] has quit [Ping timeout: 255 seconds]
02:04 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/3e536ea9ac95...6d40a1a7e7f0
02:04 < bitcoin-git> bitcoin/master 7121fd8 kdmukai: test: self-sign previous release binaries for arm64 macOS
02:04 < bitcoin-git> bitcoin/master dc12f2e kdmukai: test: improve error msg on previous release tarball extraction failure
02:04 < bitcoin-git> bitcoin/master 6d40a1a MarcoFalke: Merge bitcoin/bitcoin#26694: test: `get_previous_releases.py`: M1/M2 macs ...
02:04 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #26694: test: `get_previous_releases.py`: M1/M2 macs can't run unsigned arm64 binaries; self-sign when needed (master...2022-12-fix_mac_arm64_previous_releases) https://github.com/bitcoin/bitcoin/pull/26694
02:06 -!- gnaf [~gnaf@93-190-140-117.hosted-by-worldstream.net] has quit [Quit: Konversation terminated!]
02:38 -!- BUSY [~BUSY@user/busy] has joined #bitcoin-core-dev
03:05 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:847b:35f5:3748:7a4b] has quit [Remote host closed the connection]
03:05 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:847b:35f5:3748:7a4b] has joined #bitcoin-core-dev
03:26 -!- josie [~josibake@2001:470:69fc:105::2:47a6] has quit [Ping timeout: 246 seconds]
03:26 -!- ishaanam[m] [~ishaanamm@2001:470:69fc:105::2:4078] has quit [Ping timeout: 246 seconds]
03:27 -!- stratospher[m] [~stratosph@2001:470:69fc:105::2:728e] has quit [Ping timeout: 246 seconds]
03:27 -!- laanwj [~laanwj@user/laanwj] has quit [Ping timeout: 246 seconds]
03:28 -!- jakwolf[m] [~jakwolfma@2001:470:69fc:105::2:acc8] has quit [Ping timeout: 265 seconds]
03:28 -!- denise[m] [~denisewui@2001:470:69fc:105::1:4ab8] has quit [Ping timeout: 264 seconds]
03:28 -!- sipa [~sipa@user/sipa] has quit [Ping timeout: 246 seconds]
03:29 -!- ShohamChakrabort [~shohamc1m@2001:470:69fc:105::2:d8cb] has quit [Ping timeout: 252 seconds]
03:29 -!- Murch1 [~murch@user/murch] has quit [Ping timeout: 260 seconds]
03:29 -!- Jiri[m] [~jirijirij@2001:470:69fc:105::2:c0a7] has quit [Ping timeout: 248 seconds]
03:29 -!- vincenzopalazzo [~vincenzop@2001:470:69fc:105::a67] has quit [Ping timeout: 252 seconds]
03:29 -!- dunxen [~dunxen@2001:470:69fc:105::1:fec1] has quit [Ping timeout: 265 seconds]
03:29 -!- willcl_ark [~willcl-ar@user/willcl-ark/x-8282106] has quit [Ping timeout: 265 seconds]
03:30 -!- bitcoin-git [~bitcoin-g@2001:470:69fc:105::2:690] has quit [Ping timeout: 260 seconds]
03:30 -!- virtu [~virtu@user/virtu] has quit [Ping timeout: 260 seconds]
03:30 -!- m_p78 [~m_p78@181.191.9.58] has joined #bitcoin-core-dev
03:31 -!- BlueMatt[m] [~bluemattm@2001:470:69fc:105::1:5092] has quit [Ping timeout: 260 seconds]
03:31 -!- provoostenator [~provooste@user/provoostenator] has quit [Ping timeout: 246 seconds]
03:33 -!- kakolainen[m]1 [~kakolaine@2001:470:69fc:105::34f9] has quit [Ping timeout: 264 seconds]
03:44 -!- kakolainen[m]1 [~kakolaine@2001:470:69fc:105::34f9] has joined #bitcoin-core-dev
03:55 -!- josie [~josibake@2001:470:69fc:105::2:47a6] has joined #bitcoin-core-dev
03:56 -!- ishaanam[m] [~ishaanamm@2001:470:69fc:105::2:4078] has joined #bitcoin-core-dev
04:04 -!- jakwolf[m] [~jakwolfma@2001:470:69fc:105::2:acc8] has joined #bitcoin-core-dev
04:14 -!- stratospher[m] [~stratosph@2001:470:69fc:105::2:728e] has joined #bitcoin-core-dev
04:17 -!- denise[m] [~denisewui@2001:470:69fc:105::1:4ab8] has joined #bitcoin-core-dev
04:22 -!- Jiri[m] [~jirijirij@2001:470:69fc:105::2:c0a7] has joined #bitcoin-core-dev
04:23 -!- willcl_ark [~willcl-ar@user/willcl-ark/x-8282106] has joined #bitcoin-core-dev
04:24 -!- ShohamChakrabort [~shohamc1m@2001:470:69fc:105::2:d8cb] has joined #bitcoin-core-dev
04:24 -!- Murch1 [~murch@user/murch] has joined #bitcoin-core-dev
04:26 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
04:27 -!- BlueMatt[m] [~bluemattm@2001:470:69fc:105::1:5092] has joined #bitcoin-core-dev
04:27 -!- vincenzopalazzo [~vincenzop@2001:470:69fc:105::a67] has joined #bitcoin-core-dev
04:30 -!- dunxen [~dunxen@2001:470:69fc:105::1:fec1] has joined #bitcoin-core-dev
04:32 -!- sipa [~sipa@user/sipa] has joined #bitcoin-core-dev
04:34 -!- bitcoin-git [~bitcoin-g@2001:470:69fc:105::2:690] has joined #bitcoin-core-dev
04:37 -!- virtu [~virtu@2001:470:69fc:105::2:c105] has joined #bitcoin-core-dev
04:43 -!- provoostenator [~provooste@user/provoostenator] has joined #bitcoin-core-dev
04:47 -!- laanwj [~laanwj@user/laanwj] has joined #bitcoin-core-dev
04:51 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has quit [Remote host closed the connection]
05:02 -!- m_p78 [~m_p78@181.191.9.58] has left #bitcoin-core-dev []
05:17 -!- brunoerg [~brunoerg@2804:5e70:4004:7800:198e:7d56:ee86:112e] has joined #bitcoin-core-dev
05:21 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Remote host closed the connection]
05:52 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
06:01 -!- virtu [~virtu@2001:470:69fc:105::2:c105] has quit [Changing host]
06:01 -!- virtu [~virtu@user/virtu] has joined #bitcoin-core-dev
06:09 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Quit: bye]
06:10 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
06:10 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
06:10 < bitcoin-git> [bitcoin] brunoerg opened pull request #26738: test: add coverage for unknown wallet flag in `setwalletflag` (master...2022-12-setwalletflag-unknown-error) https://github.com/bitcoin/bitcoin/pull/26738
06:10 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 255 seconds]
06:26 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 260 seconds]
06:33 -!- brunoerg [~brunoerg@2804:5e70:4004:7800:198e:7d56:ee86:112e] has quit []
06:33 -!- Cory [~Cory@user/pasha] has quit [Ping timeout: 268 seconds]
06:47 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
06:50 -!- MacroFake [~none@72.5.34.65] has quit [Quit: ZNC 1.7.5+deb4 - https://znc.in]
06:52 -!- MacroFake [~none@72.5.34.65] has joined #bitcoin-core-dev
07:26 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Remote host closed the connection]
07:26 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
07:37 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:847b:35f5:3748:7a4b] has quit [Remote host closed the connection]
07:38 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:847b:35f5:3748:7a4b] has joined #bitcoin-core-dev
07:39 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [Closing Window]
07:57 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
08:02 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:847b:35f5:3748:7a4b] has quit [Ping timeout: 252 seconds]
08:16 -!- taylor [~taylor@2620:106:a000:aaa0::290] has joined #bitcoin-core-dev
08:16 -!- taylor is now known as Guest4411
08:25 -!- yashraj [yashraj@gateway/vpn/protonvpn/yashraj] has joined #bitcoin-core-dev
08:26 -!- Guest4411 [~taylor@2620:106:a000:aaa0::290] has quit [Quit: Client closed]
08:26 -!- taylorfrommynode [~taylorfro@2620:106:a000:aaa0::290] has joined #bitcoin-core-dev
08:31 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 248 seconds]
08:33 -!- yashraj_ [yashraj@gateway/vpn/protonvpn/yashraj] has joined #bitcoin-core-dev
08:37 -!- yashraj [yashraj@gateway/vpn/protonvpn/yashraj] has quit [Ping timeout: 246 seconds]
08:38 -!- hg [~halosghos@user/halosghost] has joined #bitcoin-core-dev
08:39 -!- hernanmarino [~hernanmar@181.99.169.107] has joined #bitcoin-core-dev
08:48 -!- yashraj_ [yashraj@gateway/vpn/protonvpn/yashraj] has quit [Ping timeout: 260 seconds]
08:53 -!- kmartin [~kmartin@151.38.240.6] has joined #bitcoin-core-dev
08:54 -!- pablomartin [~pablomart@181.99.169.107] has joined #bitcoin-core-dev
08:55 -!- rozehnal_paul [~rozehnal_@142.243.254.224] has joined #bitcoin-core-dev
09:11 -!- b_101_ [~robert@189.236.6.68] has joined #bitcoin-core-dev
09:14 -!- b_101 [~robert@173.254.196.62.adsl.inet-telecom.org] has quit [Ping timeout: 272 seconds]
09:15 -!- kmartin [~kmartin@151.38.240.6] has quit [Quit: Client closed]
09:22 -!- as2333 [~as2333@host95.201-252-100.telecom.net.ar] has joined #bitcoin-core-dev
09:38 -!- p2plife [~p2plife@vps-46773dd2.vps.ovh.net] has quit [Quit: quit]
09:42 -!- b_101 [~robert@173.254.196.62.adsl.inet-telecom.org] has joined #bitcoin-core-dev
09:44 -!- b_101_ [~robert@189.236.6.68] has quit [Read error: Connection reset by peer]
09:47 -!- b_101_ [~robert@189.236.6.68] has joined #bitcoin-core-dev
09:47 -!- b_101 [~robert@173.254.196.62.adsl.inet-telecom.org] has quit [Ping timeout: 265 seconds]
09:50 -!- p2plife [~p2plife@vps-46773dd2.vps.ovh.net] has joined #bitcoin-core-dev
09:59 < bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/6d40a1a7e7f0...f3bc1a72825f
09:59 < bitcoin-git> bitcoin/master 8c5b364 Greg Sanders: Relax MIN_STANDARD_TX_NONWITNESS_SIZE to 65 non-witness bytes
09:59 < bitcoin-git> bitcoin/master b2aa9e8 Greg Sanders: Add release note for MIN_STANDARD_TX_NONWITNESS_SIZE relaxation
09:59 < bitcoin-git> bitcoin/master f3bc1a7 Andrew Chow: Merge bitcoin/bitcoin#26265: POLICY: Relax MIN_STANDARD_TX_NONWITNESS_SIZE...
10:00 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500:9f97:ce49:553a:6cb3] has joined #bitcoin-core-dev
10:12 -!- rozehnal_paul [~rozehnal_@142.243.254.224] has quit [Quit: Connection closed]
10:14 -!- hernanmarino [~hernanmar@181.99.169.107] has quit [Quit: Leaving]
10:14 -!- b_101 [~robert@173.254.196.62.adsl.inet-telecom.org] has joined #bitcoin-core-dev
10:16 -!- b_101_ [~robert@189.236.6.68] has quit [Ping timeout: 246 seconds]
10:17 < p2plife> user on #bitcoin claims after upgrade to 0.24 some old wallets broke. taylorfrommynode (voice in #bitcoin)
10:18 < p2plife> mentioning here since sounds like the kind of thing someone really should investigate
10:19 < achow101> p2plife: thanks, looking
10:22 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
10:22 < taylorfrommynode> OK, I can post here now as well. I'm seeing a pretty prevalent issue when upgrading devices from v23.0 to v24.0 where Bitcoin fails to start, often on the second restart after upgrading to v24. The log reports a message, but it isn't overly helpful and just says wallet.dat cannot be opened.
10:24 < achow101> taylorfrommynode: How have you specifieid the wallet to be opened?
10:26 < taylorfrommynode> In bitcoin.conf like this
10:26 < taylorfrommynode> main.wallet=wallet.dat
10:27 < achow101> can you try `main.wallet=`
10:27 < achow101> you're not actually supposed to give the relative path to the wallet.dat file
10:28 < achow101> or maybe main.wallet=""
10:28 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
10:30 < bitcoin-git> [bitcoin] glozow closed pull request #26265: POLICY: Relax MIN_STANDARD_TX_NONWITNESS_SIZE to 65 non-witness bytes (master...relax_too_small_tx) https://github.com/bitcoin/bitcoin/pull/26265
10:34 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:f522:f190:40b3:9561] has joined #bitcoin-core-dev
10:35 -!- pablomartin_ [~pablomart@195.140.215.182] has joined #bitcoin-core-dev
10:36 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500:9f97:ce49:553a:6cb3] has quit [Ping timeout: 264 seconds]
10:38 < taylorfrommynode> OK, I had a user comment out the wallets in their config (unfortunately, I can't reproduce myself yet) and they get this error now.
10:38 < taylorfrommynode> Error: Failed to load database path '/home/bitcoin/.bitcoin'. Data is not in recognized format.
10:38 < taylorfrommynode> That's the path to the main bitcoin data folder.
10:38 -!- pablomartin [~pablomart@181.99.169.107] has quit [Ping timeout: 246 seconds]
10:41 < achow101> can they provide a debug.log file?
10:41 < achow101> I'm fairly certain this is just a onfiguration error.
10:41 -!- _Sam-- [~sam@20.231.27.81] has joined #bitcoin-core-dev
10:42 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
10:46 < taylorfrommynode> It could be, but the config didn't change from v23 to v24.
10:48 < taylorfrommynode> Sure - https://pastebin.com/m7h87naP
10:49 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500:9f97:ce49:553a:6cb3] has joined #bitcoin-core-dev
10:51 < achow101> need to see a debug.log too
10:57 -!- mudsip [~mudsip@user/mudsip] has joined #bitcoin-core-dev
11:01 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 272 seconds]
11:09 -!- euclid[m] [~euclidhni@2001:470:69fc:105::2b6f] has joined #bitcoin-core-dev
11:19 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:f522:f190:40b3:9561] has quit [Ping timeout: 256 seconds]
11:39 -!- mudsip [~mudsip@user/mudsip] has quit []
11:39 < taylorfrommynode> OK, I got someone's wallet.dat and I can reproduce it now as well. https://pastebin.com/WGehyygV
11:40 < willcl_ark> That pastebin link doesn’t work for me?
11:43 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:f522:f190:40b3:9561] has joined #bitcoin-core-dev
11:44 < taylorfrommynode> Hmm it keeps getting removed. Try this https://paste.ee/p/dXokg
11:46 < willcl_ark> That one works.
11:52 < willcl_ark> Did that run error out then? I can only see an error from a previous run at the top.
11:53 < achow101> taylorfrommynode: what does `file wallet.dat` say?
11:54 < taylorfrommynode> Yeah, the top line shows it shutdown I think. Sorry, the log is backwards - top is latest and bottom is oldest.
11:54 < taylorfrommynode> admin@myNode:/mnt/hdd/mynode/bitcoin$ file wallet.dat
11:54 < taylorfrommynode> wallet.dat: SQLite 3.x database, application id 4190024921, last written using SQLite version 3038005
11:59 < achow101> can you double check the permissions on the file? make sure that the user that bitcoind will run as can read and write the file
11:59 < instagibbs> does downgrading fix it? I'd check that as well
12:00 < achow101> I'm fairly certain that nothing in the database opening code changed between 23.0 and 24.0
12:01 < taylorfrommynode> Unfortunately, downgrading does not fix it. Some users report that is works the first time they launch 24 and it breaks after the first restart on 24.
12:05 < taylorfrommynode> I tried tinkering with permissions and didn't see a difference.
12:05 < taylorfrommynode> 12 -rw-------  1 bitcoin bitcoin   12288 Dec 21 13:37 wallet.dat
12:07 < sipa> Is this self-compiled or released binary?
12:07 < taylorfrommynode> Released, downloaded from bitcoincore.org
12:22 < taylorfrommynode> Also, I have reports of there being issues on PCs and Raspis so it doesn't seem to be arch-specific
12:24 < p2plife> probably not but, taylorfrommynode, by any chance anything in dmesg logs, or any special protections on the system such as file ACLs there, apparmor and alike, selinux, being remote or otherwise special file system?
12:24 < instagibbs> no expert but from reading the thing that's failing a couple quick checks: "head -c 16 <wallet file>" should result in "SQLite format 3", and check the file size of the wallet to see if it's weirdly small(<512 bytes)
12:25 < sipa> Could there be two instances of bitcoind? With different datadir, but the same wallet?
12:25 < instagibbs> inability to open seems most likely...
12:25 < sipa> Is bitcoind running as user bitcoin?
12:25 < sipa> Is it a network drive?
12:28 < taylorfrommynode> I have not seen any messages about security protections causing issues. The head command does return "SQLite format 3" and the size seems normal.
12:28 < achow101> The only thing that makes sense for hitting this error is just simply failing to open the file
12:29 < instagibbs> yeah only other thing would be the file header/magic being clobbered, which it doesn't look like
12:29 < sipa> achow101: Is the sqlite version the same between 23.0 and 24.0.1?
12:29 < achow101> file is detecting the magic and app id correctly, so it's not that
12:30 < p2plife> can you open that file in sqlite program such as sqlite-browser (or how ever it was called)? does it seem fine there?  BTW. ofc do backups of everything before all this 
12:30 < instagibbs> achow101, ah nice, TIL
12:30 < instagibbs> so yeah, file permissions something something
12:30 < achow101> sipa: I think it did, but not meaningfully
12:30 < taylorfrommynode> I don't think there are two instances of bitcoind running since it loads fine if I don't load wallet.dat at startup or if disablewallet=1 is set.
12:31 < achow101> taylorfrommynode: you are able to load the wallet with loadwallet?
12:31 < taylorfrommynode> I'm trying loadwallet now to see if I get more info
12:31 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
12:34 < taylorfrommynode> Same error via loadwallet - https://pastebin.com/3epR6vYS
12:37 < taylorfrommynode> What seems extra concerning is that some users report this error even after removing the bad wallet or removing it from bitcoin.conf, they still get an error about the format of the whole datadir.
12:37 < taylorfrommynode> Error: Failed to load database path '/home/bitcoin/.bitcoin'. Data is not in recognized format.
12:38 < achow101> Can you start without a wallet, then make one with createwallet, and then unload and reload it?
12:38 < achow101> is the problem with just this one specific wallet, or in general?
12:39 -!- Guest16 [~Guest16@103.178.155.53] has joined #bitcoin-core-dev
12:39 < sipa> Can you try cat /path/to/wallet.dat | cut -c 69-72 | hd ?
12:40 < taylorfrommynode> sipa: https://pastebin.com/EueVTQ3H
12:40 < p2plife> strace - maybe run in strace to see which exact files it tries to load from disk, |grep open. also ***DO NOT PASTE*** strace as it might show part of the secret data, in form of read(....) = "..." (parts of actuall WALLET secrets)
12:41 < instagibbs> can you double check permissions of the containing directory?
12:41 -!- Guest16 [~Guest16@103.178.155.53] has quit [Client Quit]
12:41 < sipa> taylorfrommynode: Sorry, -b instead of -c
12:42 < taylorfrommynode> instagibbs: Folder perms seem fine, it runs without this wallet.
12:42 < taylorfrommynode> 4 drwxr-xr-x  6 bitcoin    bitcoin    4096 Dec 21 14:31 bitcoin
12:43 < taylorfrommynode> sipa: -b doesn't seem to change the output
12:43 < instagibbs> I see the magic, it's there
12:44 < sipa> oh yes, nvm
12:44 < sipa> all good
12:45 < achow101> It has to be the `if (!file.is_open()) return false;` line
12:45 < achow101> just no idea why the file isn't open
12:46 < willcl_ark> Have we tried restarting the machine? :P
12:47 < p2plife> taylorfrommynode, are all problems on same machine? what system(s), cpu architecture(s)?
12:49 < sipa> taylorfrommynode: Do you have the same problems with self-compiled binaries?
12:51 -!- pablomartin_ [~pablomart@195.140.215.182] has quit [Ping timeout: 268 seconds]
12:51 < taylorfrommynode> willcl_ark: Yeah, and downgrading back to v23.0.
12:52 < taylorfrommynode> p2plife: A large number of devices are seeing this issue, mini pcs and raspberry pis.
12:53 < achow101> hmm, presumably the datadir is on an external drive? Could it be a usb issue?
12:53 < taylorfrommynode> sipa: I can't reproduce the initial wallet corruption, I've only got access to already corrupted files so I can't say right now.
12:53 < achow101> taylorfrommynode: can you share the problematic wallet with us?
12:53 < taylorfrommynode> achow101: The first issues were all reported on PCs using internal SATA drives
12:53  * p2plife volounteers ;)
12:54 < p2plife> right, are any of these wallets empty or almost empty?
12:54 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:f522:f190:40b3:9561] has quit [Ping timeout: 246 seconds]
12:55 < taylorfrommynode> p2plife: The couple I have seen all seem non-empty. I went through the same process with an empty wallet and saw no issue.
12:55 < p2plife> taylorfrommynode, do the wallets load normally in sqlite-browser? should be fairly easy for remote user/owner to check that
12:56 < p2plife> just let the user test first can he even read the file (e.g. calculate sha1sum of the same file as he is about to try opening) as he will probably do it from another user (needs GUI)
12:57 < taylorfrommynode> What would look "normal"? I just opened one I was sent in sqlite browser.
12:57 < achow101> mainly looking to see if sqlite complains about it
12:58 < taylorfrommynode> I see a main table with key/value pairs and 5 keys. No obvious complaints.
12:58 < achow101> can you try adding group read-write permissions to the wallet?
12:58 < achow101> e.g. chmod g+rw wallet.dat
12:59 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
13:00 < taylorfrommynode> Changed permissions, no difference.
13:00 < sipa> Do self-compiled binaries also error out on this corrupted wallet.dat file?
13:01 < taylorfrommynode> I see 5 keys - ".version" "..." "<weird character>flags" "           bestblock" "<arrow char>bestblock_nomerkle"
13:01 < achow101> that sounds about right for a watchonly
13:02 < taylorfrommynode> Why would the keys have such crazy characters though? Makes me think it's corrupt somehow.
13:02 < p2plife> are these watchonly wallets, not with actually private keys? then they perhaps might be shared (minus the privacy consideration of linking all addresses as same user)
13:02 < achow101> the keys contain binary data
13:02 < achow101> with strings sometimes
13:03 < p2plife> what table should he see with the 1000+ privkeys for normal wallet?
13:04 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:f522:f190:40b3:9561] has joined #bitcoin-core-dev
13:04 < achow101> something like 30 ish records, with several that have a string that start with "walletdescriptor"
13:06 < p2plife> is there no exact debug logging steps of trying to load a wallet, to be turned on?  if not then maybe my above strace idea (just do not paste content of read file data)
13:06 < taylorfrommynode> I turned on all debug and it did not add any additional logs unfortunately
13:06 < achow101> there isn't. strace is probably a good idea
13:07 -!- b_101 [~robert@173.254.196.62.adsl.inet-telecom.org] has quit [Ping timeout: 272 seconds]
13:08 < sipa> if it's the std::ifstream::open that files, the example at the bottom of https://en.cppreference.com/w/cpp/io/basic_ios/exceptions may help
13:08 < sipa> (as something to add to make it report why it fails)
13:08 < sipa> s/files/fails/
13:15 < p2plife> is there some walletinfo you can paste? maybe with exact wallet type (descriptors? HD? how many keys? watchonly? privkeys? ... more?)
13:26 < taylorfrommynode> As far as I know it's watch only. Some apps require or used to use it at least, but none store funds there (unless someone manually tried to but I seriously doubt that).
13:26 < taylorfrommynode> Strace info - https://pastebin.com/eHKzcMb1
13:31 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 260 seconds]
13:32 < achow101> oh
13:33 < p2plife> so... it gets angry it can't open wallet.dat as a directory after just opening it as a file??
13:33 < achow101> that's a funny error code
13:33 < achow101> I think I know what went wrong
13:37 < achow101> taylorfrommynode: can you create a new directory inside the datadir and put the wallet.dat in there. Then in the config (or loadwallet), instead of specifying wallet.dat, specify the name of the directory
13:39 < p2plife> I would report this bug on github, sadly github shadowbans new users from emails it doesn't like. Would be great to one day move off that central platform
13:40 < p2plife> besides this work-around, this will be patched up then?
13:40 < taylorfrommynode> Success! Putting it inside a folder causes bitcoin to start as expected.
13:41 < p2plife> excellent success and as usual top notch developer's support for Bitcoin
13:42 < achow101> Here's what I think is happening. Some third party software is making the wallets and also manually manipulating the location of the wallet files on disk. Said software was using legacy wallets, which allow for plain wallet files in the walletsdir (which may also be the datadir). With 24.0, those software are also calling migratewallet to turn those legacy wallets into descriptor wallets. However we do not support wallet files directly in the 
13:42 < achow101> walletsdir for descriptor wallets and always assume the given wallet name is the directory containing the wallet.dat. Hence we get the error that open() tries to open the file as a directory.
13:42 -!- orville [~orville@c-71-202-253-228.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
13:43 < achow101> It's possible that the migration tool is accidentally making the wallet files in the wrong location, but I don't think that's the case since we use the wallet creation utilities which will always make new directories for the wallets.
13:43 < achow101> I'll need to double check that though
13:44 < achow101> the altnerative is that the third party software is copying the wallet files around and expecting the sqlite wallets to have the same behavior as bdb, which they do not.
13:45 < p2plife> is all of this in some README? types of wallet formats, which location can be used for which (and since what version it changed)? sounds important to have
13:46 < sipa> achow101: Is there a reason for not supporting descriptor wallets in arbitrary locations?
13:46 < achow101> no, but users manipulating the file locations isn't something that's really supported
13:49 < achow101> sipa: I vaguely recall a discussion about this in the pr that added sqlite, but not quite what the reasoning was, other than that this was consistent with how we wanted wallets to be handled, and since descriptor wallets were completely new, we weren't expecting backwards compatibility issues
13:49 < sipa> Makes sense.
13:53 -!- grubmn [~ufotofu@149.248.16.17] has quit [Quit: WeeChat 1.9.1]
13:54 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection]
13:55 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
13:58 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
13:59 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:f522:f190:40b3:9561] has quit [Ping timeout: 248 seconds]
13:59 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
14:01 -!- as2333 [~as2333@host95.201-252-100.telecom.net.ar] has quit [Quit: as2333]
14:01 -!- as2333 [~as2333@host95.201-252-100.telecom.net.ar] has joined #bitcoin-core-dev
14:04 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
14:04 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
14:06 < achow101> apparently migrating plain wallet files just doesn't work, so I guess it's file manipulation that's the problem
14:06 -!- taylorfrommynode [~taylorfro@2620:106:a000:aaa0::290] has quit [Quit: Client closed]
14:06 -!- taylorfrommynode [~taylorfro@2620:106:a000:aaa0::290] has joined #bitcoin-core-dev
14:28 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
14:28 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
14:40 -!- kexkey [~kexkey@static-198-54-132-140.cust.tzulo.com] has quit [Read error: Connection reset by peer]
14:40 -!- kexkey [~kexkey@static-198-54-132-140.cust.tzulo.com] has joined #bitcoin-core-dev
14:42 -!- kexkey [~kexkey@static-198-54-132-140.cust.tzulo.com] has quit [Client Quit]
14:44 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Quit: Leaving]
14:44 -!- kexkey [~kexkey@static-198-54-132-140.cust.tzulo.com] has joined #bitcoin-core-dev
14:45 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
14:55 < bitcoin-git> [bitcoin] achow101 opened pull request #26740: wallet: Migrate wallets that are not in a wallet dir (master...migrate-plain-wallet-file) https://github.com/bitcoin/bitcoin/pull/26740
14:59 -!- kexkey [~kexkey@static-198-54-132-140.cust.tzulo.com] has quit [Quit: kexkey]
15:00 -!- kexkey [~kexkey@static-198-54-132-140.cust.tzulo.com] has joined #bitcoin-core-dev
15:02 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
15:02 -!- hg [~halosghos@user/halosghost] has quit [Quit: WeeChat 3.7.1]
15:06 -!- kexkey [~kexkey@static-198-54-132-140.cust.tzulo.com] has quit [Quit: kexkey]
15:14 -!- orville [~orville@c-71-202-253-228.hsd1.ca.comcast.net] has quit [Quit: <exit all I/O streams / EOF>]
15:17 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:f522:f190:40b3:9561] has joined #bitcoin-core-dev
15:17 -!- TheRec_ [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Read error: Connection reset by peer]
15:19 -!- TheRec [~toto@84.75.225.47] has joined #bitcoin-core-dev
15:19 -!- TheRec [~toto@84.75.225.47] has quit [Changing host]
15:19 -!- TheRec [~toto@user/therec] has joined #bitcoin-core-dev
15:20 -!- kexkey [~kexkey@static-198-54-132-140.cust.tzulo.com] has joined #bitcoin-core-dev
15:32 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 255 seconds]
15:32 -!- vasild_ [~vd@user/vasild] has joined #bitcoin-core-dev
15:33 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 255 seconds]
15:34 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
15:40 -!- kexkey [~kexkey@static-198-54-132-140.cust.tzulo.com] has quit [Quit: kexkey]
15:41 -!- kexkey [~kexkey@static-198-54-132-140.cust.tzulo.com] has joined #bitcoin-core-dev
15:44 -!- kexkey [~kexkey@static-198-54-132-140.cust.tzulo.com] has quit [Client Quit]
15:47 -!- pablomartin_ [~pablomart@217.146.90.152] has joined #bitcoin-core-dev
15:48 -!- kexkey [~kexkey@static-198-54-132-140.cust.tzulo.com] has joined #bitcoin-core-dev
15:50 -!- b_101 [~robert@173.254.196.62.adsl.inet-telecom.org] has joined #bitcoin-core-dev
15:55 -!- b_101 [~robert@173.254.196.62.adsl.inet-telecom.org] has quit [Ping timeout: 246 seconds]
15:55 -!- pablomartin_ [~pablomart@217.146.90.152] has quit [Ping timeout: 260 seconds]
15:58 -!- kexkey [~kexkey@static-198-54-132-140.cust.tzulo.com] has quit [Quit: kexkey]
16:06 -!- kexkey [~kexkey@static-198-54-132-140.cust.tzulo.com] has joined #bitcoin-core-dev
16:07 -!- kexkey [~kexkey@static-198-54-132-140.cust.tzulo.com] has quit [Client Quit]
16:11 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:f522:f190:40b3:9561] has quit [Ping timeout: 246 seconds]
16:25 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:4cfb:3d74:a29b:b2da] has joined #bitcoin-core-dev
16:41 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500:9f97:ce49:553a:6cb3] has quit [Ping timeout: 265 seconds]
16:50 -!- kexkey [~kexkey@static-198-54-132-140.cust.tzulo.com] has joined #bitcoin-core-dev
16:54 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 255 seconds]
17:00 -!- MrFrancis [~MrFrancis@2001:8a0:fa4c:901:4cfb:3d74:a29b:b2da] has quit [Ping timeout: 248 seconds]
17:03 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Ping timeout: 255 seconds]
17:04 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
17:06 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
18:01 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Remote host closed the connection]
18:02 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
18:02 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
18:05 < p2plife> achow101, in that pr 26740 just now, you might want to add to description some information regarding was that a mistake, or is that for an unsupported usecase where user did something he shouldn't (and some link where it was said). either way add that problem resulted in program not starting up (no funds lost or anything), so users can be confident
18:06 < achow101> p2plife: 26740 is actually unrelated to the earlier issue
18:07 < achow101> #26739 is for that
18:07 <@gribble> https://github.com/bitcoin/bitcoin/issues/26739 | Unable to open descriptor wallets that are not in a wallet directory · Issue #26739 · bitcoin/bitcoin · GitHub
18:07 < p2plife> oh ok
18:18 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
18:19 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
18:32 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
18:41 -!- mudsip [~mudsip@user/mudsip] has joined #bitcoin-core-dev
18:53 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 255 seconds]
18:56 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
19:00 -!- as2333 [~as2333@host95.201-252-100.telecom.net.ar] has quit [Read error: Connection reset by peer]
19:06 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 260 seconds]
19:08 -!- mudsip [~mudsip@user/mudsip] has quit []
19:14 -!- gnaf [~gnaf@93-190-140-117.hosted-by-worldstream.net] has joined #bitcoin-core-dev
19:20 -!- gnaf [~gnaf@93-190-140-117.hosted-by-worldstream.net] has quit [Ping timeout: 260 seconds]
19:22 -!- b_101 [~robert@173.254.196.62.adsl.inet-telecom.org] has joined #bitcoin-core-dev
19:24 -!- gnaf [~gnaf@93-190-140-117.hosted-by-worldstream.net] has joined #bitcoin-core-dev
19:24 -!- as2333 [~as2333@host95.201-252-100.telecom.net.ar] has joined #bitcoin-core-dev
19:28 -!- gnaf [~gnaf@93-190-140-117.hosted-by-worldstream.net] has quit [Ping timeout: 268 seconds]
19:30 -!- gnaf [~gnaf@93-190-140-117.hosted-by-worldstream.net] has joined #bitcoin-core-dev
19:33 -!- b_101 [~robert@173.254.196.62.adsl.inet-telecom.org] has quit [Ping timeout: 268 seconds]
19:34 -!- pablomartin [~pablomart@190.193.221.10] has joined #bitcoin-core-dev
19:36 -!- pablomartin_ [~pablomart@185.169.233.161] has joined #bitcoin-core-dev
19:40 -!- pablomartin [~pablomart@190.193.221.10] has quit [Ping timeout: 268 seconds]
19:49 -!- gnaf [~gnaf@93-190-140-117.hosted-by-worldstream.net] has quit [Quit: Konversation terminated!]
20:05 -!- NorrinRadd [~me@64.64.116.61] has joined #bitcoin-core-dev
20:05 -!- NorrinRadd [~me@64.64.116.61] has quit [Client Quit]
20:31 -!- pablomartin_ [~pablomart@185.169.233.161] has quit [Ping timeout: 272 seconds]
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:26 -!- b_101 [~robert@173.254.196.62.adsl.inet-telecom.org] has joined #bitcoin-core-dev
21:30 -!- b_101 [~robert@173.254.196.62.adsl.inet-telecom.org] has quit [Ping timeout: 264 seconds]
21:50 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
22:21 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 256 seconds]
22:38 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
22:39 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
22:58 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection]
23:00 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
23:04 -!- sdfgsdfg [~sdfgsdfg@user/sdfgsdfg] has joined #bitcoin-core-dev
23:20 -!- as2333 [~as2333@host95.201-252-100.telecom.net.ar] has quit [Quit: as2333]
--- Log closed Thu Dec 22 00:00:50 2022