--- Log opened Thu Jul 06 00:00:51 2023
00:13 -!- salvatoshi [~salvatosh@genymobile-2-6-86.fib.nerim.net] has joined #bitcoin-core-dev
00:37 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
00:38 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
00:45 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has joined #bitcoin-core-dev
00:50 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has quit [Ping timeout: 245 seconds]
01:25 -!- stacie_ [sid563966@id-563966.uxbridge.irccloud.com] has quit [Ping timeout: 246 seconds]
01:25 -!- stacie_ [sid563966@id-563966.uxbridge.irccloud.com] has joined #bitcoin-core-dev
01:25 -!- rodarmor [sid210835@id-210835.helmsley.irccloud.com] has quit [Ping timeout: 246 seconds]
01:26 -!- jarthur [~jarthur@user/jarthur] has quit [Ping timeout: 246 seconds]
01:28 -!- rodarmor [sid210835@id-210835.helmsley.irccloud.com] has joined #bitcoin-core-dev
01:30 -!- jarthur [~jarthur@user/jarthur] has joined #bitcoin-core-dev
01:30 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
01:46 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has joined #bitcoin-core-dev
01:51 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has quit [Ping timeout: 260 seconds]
01:52 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has joined #bitcoin-core-dev
01:56 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has quit [Ping timeout: 246 seconds]
02:02 -!- Traca[m] [~irc.liber@2001:470:69fc:105::1:d463] has quit [Remote host closed the connection]
02:02 -!- Traca[m] [~irc.liber@2001:470:69fc:105::1:d463] has joined #bitcoin-core-dev
02:03 < bitcoin-git> [bitcoin] fanquake closed pull request #28032: Gitignore auto-generated Secp256k1 files (master...master) https://github.com/bitcoin/bitcoin/pull/28032
02:03 -!- Traca[m] [~irc.liber@2001:470:69fc:105::1:d463] has quit [Remote host closed the connection]
02:04 -!- Traca[m] [~irc.liber@2001:470:69fc:105::1:d463] has joined #bitcoin-core-dev
02:08 -!- ZeroMaster [~webirc@87-126-6-81.ip.btc-net.bg] has quit [Ping timeout: 245 seconds]
02:09 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has joined #bitcoin-core-dev
02:10 -!- Traca[m] [~irc.liber@2001:470:69fc:105::1:d463] has quit [Remote host closed the connection]
02:11 -!- Traca[m] [~traca@2001:470:69fc:105::1:d463] has joined #bitcoin-core-dev
02:12 -!- ZeroMaster [~webirc@87-126-6-81.ip.btc-net.bg] has joined #bitcoin-core-dev
02:13 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has quit [Ping timeout: 240 seconds]
02:14 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #28034: ci: Print full lscpu output (master...2307-ci-lscpu-) https://github.com/bitcoin/bitcoin/pull/28034
02:14 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has joined #bitcoin-core-dev
02:19 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has quit [Ping timeout: 246 seconds]
02:33 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has joined #bitcoin-core-dev
02:38 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has quit [Ping timeout: 240 seconds]
02:45 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has joined #bitcoin-core-dev
02:48 < bitcoin-git> [bitcoin] glozow pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bc4f6b13feb2...ecf3baffc0b6
02:48 < bitcoin-git> bitcoin/master 8fbb6e9 Andrew Chow: wallet: Give deprecation warning when loading a legacy wallet
02:48 < bitcoin-git> bitcoin/master ecf3baf glozow: Merge bitcoin/bitcoin#27869: wallet: Give deprecation warning when loading...
02:48 < bitcoin-git> [bitcoin] glozow merged pull request #27869: wallet: Give deprecation warning when loading a legacy wallet (master...deprecation-warning-legacy-wallet) https://github.com/bitcoin/bitcoin/pull/27869
02:50 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has quit [Ping timeout: 260 seconds]
02:51 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has joined #bitcoin-core-dev
02:55 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has quit [Ping timeout: 246 seconds]
03:13 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #28035: test: Ignore UTF-8 errors in assert_debug_log (master...2307-test-utf8-) https://github.com/bitcoin/bitcoin/pull/28035
03:17 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has joined #bitcoin-core-dev
03:26 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has quit [Ping timeout: 260 seconds]
03:33 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has joined #bitcoin-core-dev
03:37 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 245 seconds]
03:37 -!- vyHamii [~vyHamii@113.160.73.210] has quit [Remote host closed the connection]
03:38 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has quit [Ping timeout: 245 seconds]
03:39 -!- cold [~cold@user/cold] has quit [Ping timeout: 252 seconds]
03:40 -!- cold [~cold@user/cold] has joined #bitcoin-core-dev
03:44 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
03:49 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 246 seconds]
04:00 -!- test_ [flooded@gateway/vpn/protonvpn/flood/x-43489060] has joined #bitcoin-core-dev
04:04 -!- flooded [flooded@gateway/vpn/protonvpn/flood/x-43489060] has quit [Ping timeout: 245 seconds]
04:14 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has joined #bitcoin-core-dev
04:14 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
04:15 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
04:19 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has quit [Ping timeout: 260 seconds]
04:19 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
04:24 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 246 seconds]
04:36 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-dev
04:39 -!- Guest1 [~Guest1@2403:2c80:17::1053] has joined #bitcoin-core-dev
04:40 -!- Guest1 [~Guest1@2403:2c80:17::1053] has quit [Client Quit]
04:40 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 240 seconds]
04:41 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 260 seconds]
04:41 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
04:52 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has joined #bitcoin-core-dev
04:53 -!- Libra [~Libra@213.69.243.75] has joined #bitcoin-core-dev
04:53 -!- Libra [~Libra@213.69.243.75] has quit [Client Quit]
04:59 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has quit [Ping timeout: 264 seconds]
05:01 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has joined #bitcoin-core-dev
05:06 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has quit [Ping timeout: 245 seconds]
05:06 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has joined #bitcoin-core-dev
05:11 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has quit [Ping timeout: 246 seconds]
05:20 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #28036: test: Restore unlimited timeout in IndexWaitSynced (master...2307-test-restore-timeout-) https://github.com/bitcoin/bitcoin/pull/28036
05:21 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ecf3baffc0b6...c325f0fbae2d
05:21 < bitcoin-git> bitcoin/master fa956d2 MarcoFalke: ci: Print full lscpu output
05:21 < bitcoin-git> bitcoin/master c325f0f fanquake: Merge bitcoin/bitcoin#28034: ci: Print full lscpu output
05:21 < bitcoin-git> [bitcoin] fanquake merged pull request #28034: ci: Print full lscpu output (master...2307-ci-lscpu-) https://github.com/bitcoin/bitcoin/pull/28034
05:29 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
05:33 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 245 seconds]
05:36 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has joined #bitcoin-core-dev
05:36 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-dev
05:41 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 245 seconds]
05:42 -!- test_ is now known as _flood
05:43 -!- bugs_ [~bugs@user/bugs/x-5128603] has joined #bitcoin-core-dev
05:45 -!- dviola [~diego@user/dviola] has quit [Quit: WeeChat 4.0.1]
05:47 -!- dviola [~diego@user/dviola] has joined #bitcoin-core-dev
05:50 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has quit [Remote host closed the connection]
05:51 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
05:52 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
06:05 -!- b_101 [~robert@187.202.249.157] has joined #bitcoin-core-dev
06:36 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
06:56 -!- preimage [~halosghos@user/halosghost] has joined #bitcoin-core-dev
07:00 < achow101> #startmeeting
07:00 < kanzure> hi
07:00 < pinheadmz> hi
07:00 < instagibbs> hi
07:00 < achow101> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard aureleoules b10c BlueMatt brunoerg cfields darosior dergoegge dongcarl fanquake fjahr furszy gleb glozow hebasto instagibbs jamesob jarolrod jonatack josibake kallewoof kanzure kouloumos kvaciral laanwj LarryRuane lightlike luke-jr MacroFake Murch phantomcircuit pinheadmz promag provoostenator ryanofsky sdaftuar S3RK stickies-v sipa theStack TheCharlatan vasild
07:00 < josie> hi
07:00 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-dev
07:00 < achow101> #topic package relay updates (glozow)
07:00 < willcl-ark> hi
07:00 < Murch> Hi
07:01 < dergoegge> hi
07:01 < lightlike> Hi
07:01 < glozow> hi
07:01 < furszy> hi
07:01 < stickies-v> hi
07:01 < glozow> I've put up Milestone 1 PR for the p2p changes, #28031
07:01 <@gribble> https://github.com/bitcoin/bitcoin/issues/28031 | Package Relay 1/3: Introduce TxPackageTracker as Orphan Resolution Module by glozow · Pull Request #28031 · bitcoin/bitcoin · GitHub
07:01 < brunoerg> hi
07:02 < MacroFake> hi
07:02 < glozow> For mempool/validation stuff, there's been good discussion on #26711
07:02 <@gribble> https://github.com/bitcoin/bitcoin/issues/26711 | validate package transactions with their in-package ancestor sets by glozow · Pull Request #26711 · bitcoin/bitcoin · GitHub
07:02 < sipa> hi
07:02 < _aj_> hi
07:03 < jamesob> hi
07:04 < achow101> cool
07:04 < instagibbs> glozow you think you have the concrete step forward on 26711 people won't be too unhappy with? :)
07:04 < theStack> hi
07:04 < glozow> Yeah kind of, though sipa's last comment makes me wonder if he has something cool cooking
07:04 < sipa> I don't!
07:04 < instagibbs> I think sipa literally means he'll think about it more 
07:04 < instagibbs> 😂
07:04 < _aj_> glozow: have you considered reopening #27609?
07:04 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 246 seconds]
07:04 < glozow> haha okay
07:04 <@gribble> https://github.com/bitcoin/bitcoin/issues/27609 | rpc: allow submitpackage to be called outside of regtest by glozow · Pull Request #27609 · bitcoin/bitcoin · GitHub
07:05 < instagibbs> thanks for weighing in btw, really helpful to see lessons learned on the other side
07:05 < instagibbs> even if the end result ends up being very similar to prior attempt...
07:05 < _aj_> glozow: (when you cook things, they end up hot, not cool, duh)
07:05 < glozow> _aj_: not sure, I was a little worried about it not being 100% safe, and didn't want to encourage submitting directly to miners
07:05 < jamesob> _aj_: are you sure you're not a dad
07:06 < glozow> yeah I'm really glad we spent some time whiteboarding etc, since it looks like I won't need to change that much code
07:07 < instagibbs> sitll mulling package rbf or (mostly) punting for v3?
07:07 < glozow> Right now I'm thinking I (1) add the linearization step (2) when going through the ancestor subpackages, just skip when feerate isn't high enough, and abort everything if something fails for non-fee reasons. That eliminates the O(n^2) concerns.
07:08 < instagibbs> linearization beyond topo-sort, right?
07:08 < instagibbs> you're already linearizing, in a way 
07:08 < glozow> yeah sorry. ancestor score-based linearization
07:08 < sipa> glozow: I believe that works, and I'd use ancestorset-based linearization.
07:08 < instagibbs> great
07:08 < achow101> to clarify, there will be major changes to 26711 that are still in progress? should we remove it from the priority for now?
07:08 < instagibbs> sipa already doing that, just not tie-breaking based on feerate, iirc
07:09 < sipa> Worse than ancestorset linearization will miss "obvious" things that we'd evict instantly anyway, and better than ancestorset linearization is something the mining/eviction algorithms can't use anyway.
07:09 < glozow> Yeah feel free to remove. #28031 or the BIP PR if people are looking to review something
07:09 <@gribble> https://github.com/bitcoin/bitcoin/issues/28031 | Package Relay 1/3: Introduce TxPackageTracker as Orphan Resolution Module by glozow · Pull Request #28031 · bitcoin/bitcoin · GitHub
07:09 < _aj_> achow101: 28031 is already there, so 26711 should be removed imo -- one pr per project
07:09 < instagibbs> sipa agreed 👍
07:09 < glozow> sipa: yes I agree
07:10 < sipa> I can work on a trimmed-down version of my cluster linearization code that just does ancestorset linearization; it'll be overkill for this purpose, but probably end up sharing more code with stuff we'll want later.
07:11 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
07:11 < glozow> instagibbs re: package RBF. Provided things make progress, it will be easiest in a post-v3 or post-cluster world. I think I want to use `PreChecks` to get the fee information, which will also grab ancestors and conflicts. That might allow us to bake in some RBFability information into linearization and the "quit early" logic.
07:12 < instagibbs> sounds right
07:12 < instagibbs> then you only have to submit once, and fail for "any reason"
07:13 < glozow> sipa: I think that would be great if it's going to be used for cluster mempool as well. I have already written a duplicate of that logic in MiniMiner, it feels a bit of a shame to make yet another one...
07:14 < sipa> It's a pretty simple algorithm, I don't think there is a problem with using an ad-hoc implementation for now, and then switching over later.
07:14 < glozow> That's true
07:14 < sipa> Up to you.
07:15 < glozow> Ok I will just write one then. It might have customizations later with the RBF stuff anyway.
07:15 < glozow> Thanks for the offer :D
07:15 < sipa> Ok!
07:15 < instagibbs> sipa I wouldn't mind getting a sneak peak for comparison 
07:16 < glozow> So that's it for me, I'll code this up and push to the PR. Feel free to move on achow101
07:16 < achow101> sounds like progress
07:16 < achow101> #topic BIP 324 updates (sipa)
07:16 < sipa> Hi!
07:17 < sipa> I've opened an additional PR with the stream and AEAD ciphers, #28008, but leaving it as draft while the dependencies are not in.
07:17 <@gribble> https://github.com/bitcoin/bitcoin/issues/28008 | BIP324 ciphers: FSChaCha20 and FSChaCha20Poly1305 by sipa · Pull Request #28008 · bitcoin/bitcoin · GitHub
07:17 < sipa> And I'm pondering about how to structure some further things.
07:18 < sipa> #27985 remains the best thing to review now, I believe.
07:18 <@gribble> https://github.com/bitcoin/bitcoin/issues/27985 | Add support for RFC8439 variant of ChaCha20 by sipa · Pull Request #27985 · bitcoin/bitcoin · GitHub
07:19 < sipa> Happy to answer any questions, but otherwise that's it from me.
07:19 < achow101> what are those further things?
07:20 -!- abubakarsadiq_ [uid602234@id-602234.hampstead.irccloud.com] has joined #bitcoin-core-dev
07:20 < sipa> The missing pieces are the key derivation logic, the v2 transport serializer/deserializer, and application level integration (including the short id logic).
07:21 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 245 seconds]
07:21 < sipa> But some of that may end up in the same PR, I'm not sure yet.
07:22 < achow101> ah i see
07:22 < sipa> There is also integration in the functional test framework, formerly #24748 by stratospher, though I believe that's waiting for the P2P integration to be (re)done.
07:22 <@gribble> https://github.com/bitcoin/bitcoin/issues/24748 | test/BIP324: functional tests for v2 P2P encryption by stratospher · Pull Request #24748 · bitcoin/bitcoin · GitHub
07:23 < sipa> The dependencies for that are already in since last week (#24005 and #26222).
07:23 <@gribble> https://github.com/bitcoin/bitcoin/issues/24005 | test: add python implementation of Elligator swift by stratospher · Pull Request #24005 · bitcoin/bitcoin · GitHub
07:23 <@gribble> https://github.com/bitcoin/bitcoin/issues/26222 | Introduce secp256k1 module with field and group classes to test framework by sipa · Pull Request #26222 · bitcoin/bitcoin · GitHub
07:24 < achow101> #topic libbitcoinkernel updates (TheCharlatan)
07:25 < jamesob> don't think we saw a "hi" from him, so he may be out
07:26 < achow101> it looks like the current pr is #27866, although #27861 has also been getting review
07:26 <@gribble> https://github.com/bitcoin/bitcoin/issues/27866 | blockstorage: Return on fatal flush errors by TheCharlatan · Pull Request #27866 · bitcoin/bitcoin · GitHub
07:26 <@gribble> https://github.com/bitcoin/bitcoin/issues/27861 | kernel: Rm ShutdownRequested and AbortNode from validation code. by TheCharlatan · Pull Request #27861 · bitcoin/bitcoin · GitHub
07:26 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
07:26 < achow101> #topic assumeutxo updates (jamesob)
07:26 < jamesob> Not much to say here, priority is still on #27746
07:26 <@gribble> https://github.com/bitcoin/bitcoin/issues/27746 | Rework validation logic for assumeutxo by sdaftuar · Pull Request #27746 · bitcoin/bitcoin · GitHub
07:27 < jamesob> Looks pretty close in terms of review, though I don't understand the arm/tidy CI failures
07:27 < fanquake> they are unrelated
07:27 < fanquake> tidy fixed by rebase
07:27 < achow101> looks pretty close
07:28 < fanquake> arm is a test-only issue, with has fixes open
07:28 < fanquake> i.e #28036
07:28 <@gribble> https://github.com/bitcoin/bitcoin/issues/28036 | test: Restore unlimited timeout in IndexWaitSynced by MarcoFalke · Pull Request #28036 · bitcoin/bitcoin · GitHub
07:28 < sipa> stratospher: I don't think using the "respond" feature works for people on IRC.
07:29 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
07:29 < achow101> #topic Ad-hoc high priority for review
07:29 < achow101> anything to add or remove from https://github.com/orgs/bitcoin/projects/1/views/4
07:29 < MacroFake> Can I have #28012 plz
07:29 <@gribble> https://github.com/bitcoin/bitcoin/issues/28012 | util: Allow FastRandomContext::randbytes for std::byte, Allow std::byte serialization by MarcoFalke · Pull Request #28012 · bitcoin/bitcoin · GitHub
07:30 < achow101> MacroFake: added
07:30 < MacroFake> thx
07:30 < pinheadmz> I got one ACK from vasild on #27375 looking for another review to top it off
07:30 <@gribble> https://github.com/bitcoin/bitcoin/issues/27375 | net: support unix domain sockets for -proxy and -onion by pinheadmz · Pull Request #27375 · bitcoin/bitcoin · GitHub
07:31 -!- Guest3 [~Guest3@150.52.106.92.dynamic.wline.res.cust.swisscom.ch] has joined #bitcoin-core-dev
07:31 < achow101> any other topics to discuss?
07:33 -!- Guest3 [~Guest3@150.52.106.92.dynamic.wline.res.cust.swisscom.ch] has quit [Client Quit]
07:33 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 246 seconds]
07:34 < achow101> re libbitcoinkernel: TheCharlatan is having IRC issues
07:34 < _aj_> should #28026 get priority?
07:34 <@gribble> https://github.com/bitcoin/bitcoin/issues/28026 | test: bugfix, synchronize indexes synchronously by furszy · Pull Request #28026 · bitcoin/bitcoin · GitHub
07:34 < achow101> <TheCharlatan> > Don't have news for the open PRs.
07:34 < achow101> <TheCharlatan> > I've been looking at cfields' tidy plugins for bitcoin: https://github.com/theuni/bitcoin-tidy-experiments and started writing my own plugins. 
07:34 < achow101> <TheCharlatan> > Such a plugin can enforce many additional things beyond what is currently done between the compilers and the various tools in our CI. Relevant in the current kernel context, Cory has written a plugin that enforces proper handling of fatal errors. I am experimenting into a similar direction, but with a slightly different approach.
07:34 < achow101> <TheCharlatan> > In general I think these plugins have utility for many parts of the code and might catch some bugs.
07:35 < fanquake> _aj_: not necessarily over #28036
07:35 <@gribble> https://github.com/bitcoin/bitcoin/issues/28036 | test: Restore unlimited timeout in IndexWaitSynced by MarcoFalke · Pull Request #28036 · bitcoin/bitcoin · GitHub
07:35 < _aj_> fanquake: hadn't seen that
07:36 < achow101> #endmeeting
07:36 < instagibbs> thanks achow101
07:36 < sipa> instagibbs: FWIW, https://github.com/sipa/bitcoin/blob/wip_memepool_fuzz/src/cluster_linearize.h
07:37 < instagibbs> > memepool 
07:37 < instagibbs> thanks!
07:39 < sipa> The overall function is LinearizeCluster, which does bottleneck analysis (find parts of the cluster that necessarily must be included in order, e.g. a single transaction that has no parents, or a single transaction that has no children). Those bottlenecks are included without doing any kind of feerate comparison at all.
07:40 < sipa> For the rest, either FindBestAncestorSet (for ancestor set feerate quality) or FindBestCandidateSetEfficient (for optimal linearization) is invoked to find good subsets.
07:42 < sipa> And there are two helper data structures in other files, FeeFrac (an exact fee/size ratio) and BitSet (for representing subsets of clusters efficiently).
08:02 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [Closing Window]
08:03 < bitcoin-git> [bitcoin] achow101 opened pull request #28037: rpc: Drop migratewallet experimental warning (master...migrate-not-experimental) https://github.com/bitcoin/bitcoin/pull/28037
09:06 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
09:22 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
09:24 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-dev
09:28 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 246 seconds]
09:37 -!- salvatoshi [~salvatosh@genymobile-2-6-86.fib.nerim.net] has quit [Ping timeout: 245 seconds]
09:52 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 240 seconds]
09:53 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
09:56 -!- bugs_ [~bugs@user/bugs/x-5128603] has quit [Quit: Leaving]
10:19 -!- flooded [flooded@gateway/vpn/protonvpn/flood/x-43489060] has joined #bitcoin-core-dev
10:22 -!- _flood [flooded@gateway/vpn/protonvpn/flood/x-43489060] has quit [Ping timeout: 246 seconds]
10:47 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-dev
10:51 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 246 seconds]
11:09 -!- instagibbs1 [~instagibb@pool-100-15-126-231.washdc.fios.verizon.net] has joined #bitcoin-core-dev
11:10 -!- instagibbs [~instagibb@pool-100-15-126-231.washdc.fios.verizon.net] has quit [Ping timeout: 246 seconds]
11:10 -!- instagibbs1 is now known as instagibbs
11:37 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
11:50 -!- ___nick___ [~quassel@host86-164-104-156.range86-164.btcentralplus.com] has joined #bitcoin-core-dev
11:50 -!- sequences[m] [~sequences@2001:470:69fc:105::2:ffee] has joined #bitcoin-core-dev
11:59 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
12:06 -!- abubakarsadiq_ [uid602234@id-602234.hampstead.irccloud.com] has quit [Quit: Connection closed for inactivity]
12:24 -!- bugs_ [~bugs@user/bugs/x-5128603] has joined #bitcoin-core-dev
12:28 < bitcoin-git> [bitcoin] furszy opened pull request #28038: wallet: address book migration bug fixes (master...2023_bugfix_addressbook_migration) https://github.com/bitcoin/bitcoin/pull/28038
12:32 -!- ___nick___ [~quassel@host86-164-104-156.range86-164.btcentralplus.com] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
12:34 -!- ___nick___ [~quassel@host86-164-104-156.range86-164.btcentralplus.com] has joined #bitcoin-core-dev
12:35 -!- ___nick___ [~quassel@host86-164-104-156.range86-164.btcentralplus.com] has quit [Client Quit]
12:37 -!- ___nick___ [~quassel@host86-164-104-156.range86-164.btcentralplus.com] has joined #bitcoin-core-dev
12:39 < achow101> furszy: MacroFake: are #28026 and #28036 mutually exclusive?
12:39 <@gribble> https://github.com/bitcoin/bitcoin/issues/28026 | test: bugfix, synchronize indexes synchronously by furszy · Pull Request #28026 · bitcoin/bitcoin · GitHub
12:39 <@gribble> https://github.com/bitcoin/bitcoin/issues/28036 | test: Restore unlimited timeout in IndexWaitSynced by MarcoFalke · Pull Request #28036 · bitcoin/bitcoin · GitHub
12:49 < furszy> most likely, we will go with 28036.
12:51 < furszy> just waiting for marco's response. There is something that would be nice to correct there.
13:04 -!- ___nick___ [~quassel@host86-164-104-156.range86-164.btcentralplus.com] has quit [Ping timeout: 245 seconds]
13:06 < bitcoin-git> [bitcoin] theuni opened pull request #28039: wallet: don't include bdb files from our headers (master...bdb-no-include-from-headers) https://github.com/bitcoin/bitcoin/pull/28039
13:06 < bitcoin-git> [bitcoin] theuni opened pull request #28040: wallet: sqlite: don't include sqlite files from our headers (master...sqlite-no-include-from-headers) https://github.com/bitcoin/bitcoin/pull/28040
13:23 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
13:28 < bitcoin-git> [bitcoin] 1proprogrammerchant opened pull request #28041: Merge pull request #1 from bitcoin/master (master...master) https://github.com/bitcoin/bitcoin/pull/28041
13:33 < bitcoin-git> [bitcoin] hebasto closed pull request #28041: Merge pull request #1 from bitcoin/master (master...master) https://github.com/bitcoin/bitcoin/pull/28041
14:07 < bitcoin-git> [bitcoin] ryanofsky pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/c325f0fbae2d...75135c673ee6
14:07 < bitcoin-git> bitcoin/master e2d680a TheCharlatan: util: Add SignalInterrupt class and use in shutdown.cpp
14:07 < bitcoin-git> bitcoin/master edb55e2 TheCharlatan: kernel: Pass interrupt reference to chainman
14:07 < bitcoin-git> bitcoin/master 3fa9094 TheCharlatan: scripted-diff: Rename FatalError to FatalErrorf
14:07 < bitcoin-git> [bitcoin] ryanofsky merged pull request #27861: kernel: Rm ShutdownRequested and AbortNode from validation code. (master...kernelInterrupt) https://github.com/bitcoin/bitcoin/pull/27861
14:15 -!- bugs_ [~bugs@user/bugs/x-5128603] has quit [Quit: Leaving]
14:38 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-dev
14:42 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 246 seconds]
15:12 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has quit [Remote host closed the connection]
15:13 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has joined #bitcoin-core-dev
15:17 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has quit [Ping timeout: 260 seconds]
15:27 -!- vysn [~vysn@user/vysn] has quit [Remote host closed the connection]
15:34 -!- TheRec [~toto@user/therec] has quit [Read error: Connection reset by peer]
15:34 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-dev
15:34 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Changing host]
15:34 -!- TheRec [~toto@user/therec] has joined #bitcoin-core-dev
15:46 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has joined #bitcoin-core-dev
15:50 -!- preimage [~halosghos@user/halosghost] has quit [Quit: WeeChat 3.8]
15:51 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has quit [Ping timeout: 260 seconds]
16:01 -!- jarthur_ [~jarthur@user/jarthur] has joined #bitcoin-core-dev
16:03 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has joined #bitcoin-core-dev
16:03 -!- jarthur [~jarthur@user/jarthur] has quit [Ping timeout: 240 seconds]
16:05 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-dev
16:07 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has quit [Ping timeout: 240 seconds]
16:09 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Read error: Connection reset by peer]
16:19 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has joined #bitcoin-core-dev
16:24 -!- andrew_mo_ [andrew_mo_@gateway/vpn/protonvpn/andrewmo/x-47904524] has quit [Ping timeout: 245 seconds]
16:26 -!- abubakarsadiq_ [uid602234@id-602234.hampstead.irccloud.com] has joined #bitcoin-core-dev
16:28 -!- abubakarsadiq_ is now known as abubakarsadiq
17:00 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has joined #bitcoin-core-dev
17:05 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has quit [Ping timeout: 245 seconds]
17:23 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
17:27 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 240 seconds]
17:48 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has joined #bitcoin-core-dev
17:55 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has quit [Ping timeout: 260 seconds]
18:12 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has joined #bitcoin-core-dev
18:17 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has quit [Ping timeout: 260 seconds]
18:19 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has joined #bitcoin-core-dev
18:23 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has quit [Ping timeout: 246 seconds]
18:34 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has quit [Quit: Connection closed for inactivity]
18:36 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has joined #bitcoin-core-dev
18:41 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has quit [Ping timeout: 246 seconds]
18:41 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has joined #bitcoin-core-dev
18:48 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has quit [Ping timeout: 260 seconds]
18:50 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has joined #bitcoin-core-dev
18:54 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has quit [Ping timeout: 246 seconds]
19:28 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
19:33 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 250 seconds]
19:39 -!- TallTim_ [~talltim@184-83-250-114-dynamic.midco.net] has joined #bitcoin-core-dev
19:41 -!- TallTim [~talltim@184.83.250.114] has quit [Ping timeout: 246 seconds]
19:42 -!- TallTim_ is now known as TallTim
19:57 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
20:01 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 246 seconds]
20:14 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has joined #bitcoin-core-dev
20:19 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has quit [Ping timeout: 260 seconds]
20:19 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has joined #bitcoin-core-dev
20:24 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has quit [Ping timeout: 246 seconds]
20:42 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has joined #bitcoin-core-dev
20:42 -!- jarthur_ [~jarthur@user/jarthur] has quit [Ping timeout: 246 seconds]
20:46 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has quit [Ping timeout: 260 seconds]
20:49 -!- jarthur [~jarthur@user/jarthur] has joined #bitcoin-core-dev
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:11 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has joined #bitcoin-core-dev
21:16 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has quit [Ping timeout: 260 seconds]
21:22 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
21:27 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 246 seconds]
21:35 -!- dongcarl [~dongcarl@cpe-66-65-169-19.nyc.res.rr.com] has quit [Ping timeout: 264 seconds]
21:50 -!- dongcarl [~dongcarl@cpe-66-65-169-19.nyc.res.rr.com] has joined #bitcoin-core-dev
22:07 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
22:08 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection]
22:08 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
22:13 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
22:17 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 246 seconds]
22:40 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
22:46 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
22:49 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 246 seconds]
22:50 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 246 seconds]
22:54 -!- rolf [~rolf@162-1-21-31.ftth.glasoperator.nl] has joined #bitcoin-core-dev
22:54 -!- rolf [~rolf@162-1-21-31.ftth.glasoperator.nl] has quit [Client Quit]
22:56 -!- test_ [flooded@gateway/vpn/protonvpn/flood/x-43489060] has joined #bitcoin-core-dev
22:59 -!- flooded [flooded@gateway/vpn/protonvpn/flood/x-43489060] has quit [Ping timeout: 245 seconds]
23:07 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
23:08 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
23:12 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 245 seconds]
23:36 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has joined #bitcoin-core-dev
23:40 -!- brunoerg [~brunoerg@2804:14c:3bfb:8a:fd8c:5780:76e8:2f6f] has quit [Ping timeout: 264 seconds]
--- Log closed Fri Jul 07 00:00:52 2023