--- Log opened Tue Sep 12 00:00:20 2023
00:18 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has quit [Ping timeout: 255 seconds]
00:19 -!- Guest71 [~Guest71@2607:fea8:1e1f:c0:f07e:1f68:1349:3db2] has joined #bitcoin-core-dev
00:22 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
00:24 -!- Guest71 [~Guest71@2607:fea8:1e1f:c0:f07e:1f68:1349:3db2] has quit [Quit: Client closed]
00:40 -!- benwestgate [~BenWestga@035-146-116-090.res.spectrum.com] has joined #bitcoin-core-dev
00:43 -!- javi404 [~quassel@2601:582:0:2c41:91ca:6895:2072:3474] has quit [Ping timeout: 255 seconds]
00:43 -!- robobub [uid248673@id-248673.uxbridge.irccloud.com] has joined #bitcoin-core-dev
00:44 -!- benwestgate [~BenWestga@035-146-116-090.res.spectrum.com] has quit [Client Quit]
00:44 -!- benwestgate [~BenWestga@035-146-116-090.res.spectrum.com] has joined #bitcoin-core-dev
00:45 -!- javi404 [~quassel@2601:582:0:2c41:91ca:6895:2072:3474] has joined #bitcoin-core-dev
00:48 -!- vincenzopalazzo [~vincenzop@146.70.126.166] has joined #bitcoin-core-dev
00:56 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [Closing Window]
01:44 -!- dermoth [~dermoth@user/dermoth] has quit [Remote host closed the connection]
01:44 -!- dermoth [~dermoth@user/dermoth] has joined #bitcoin-core-dev
01:52 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
02:13 -!- flooded [flooded@gateway/vpn/protonvpn/flood/x-43489060] has joined #bitcoin-core-dev
02:17 -!- test_ [flooded@gateway/vpn/protonvpn/flood/x-43489060] has quit [Ping timeout: 245 seconds]
02:22 -!- dberkelmans [~dberkelma@2001:1c03:530d:8100:e4eb:4548:53e9:3df0] has joined #bitcoin-core-dev
02:50 -!- dberkelmans [~dberkelma@2001:1c03:530d:8100:e4eb:4548:53e9:3df0] has quit [Quit: Client closed]
03:28 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 245 seconds]
03:29 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
04:03 -!- vincenzopalazzo [~vincenzop@146.70.126.166] has quit [Quit: Leaving]
04:04 -!- vincenzopalazzo [~vincenzop@146.70.126.166] has joined #bitcoin-core-dev
04:05 -!- vincenzopalazzo [~vincenzop@146.70.126.166] has quit [Client Quit]
04:12 -!- vincenzo- [~vincenzop@static.14.246.108.65.clients.your-server.de] has joined #bitcoin-core-dev
04:14 < MacroFake> > [16:31] <sipa> MacroFake: any idea why DrahtBot repeatedly requests and unrequests reviews from vincenzopalazzo on #28196 ?
04:14 <@gribble> https://github.com/bitcoin/bitcoin/issues/28196 | BIP324 connection support by sipa · Pull Request #28196 · bitcoin/bitcoin · GitHub
04:14 < MacroFake> That's a GitHub bug
04:17 < MacroFake> Usually it is not possible request review from external users, only from users in a "team". GitHub usually checks for that and errors out of the API request. However, here it doesn't error out and just does something nonsensical.
04:18 < MacroFake> [19:59] <jon_atack> MacroFake: what are the criteria for DrahtBot to request PR re-reviews? I see it happening for quite a few PRs, but not for other PRs.
04:19 < MacroFake> The code is open source, but the logic should be: "If has_current_ack: re_request_stale_acks();"
04:29 -!- vincenzo- [~vincenzop@static.14.246.108.65.clients.your-server.de] has quit [Quit: ZNC 1.8.2+deb2+b1 - https://znc.in]
04:30 -!- vincenzopalazzo [~vincenzop@static.14.246.108.65.clients.your-server.de] has joined #bitcoin-core-dev
04:31 < vincenzopalazzo> MacroFake, maybe because I did not review the last version after the rebase?
04:33 < MacroFake> vincenzopalazzo: Right, but the GitHub bug is that it *un*-requests the review when the API call is for a *re*-request of a review
04:37 < vincenzopalazzo> MacroFake, I see, probably
04:42 -!- acl [~acl@41.140.34.65] has joined #bitcoin-core-dev
05:02 -!- vincenzopalazzo [~vincenzop@static.14.246.108.65.clients.your-server.de] has quit [Remote host closed the connection]
05:03 -!- vincenzopalazzo [~vincenzop@static.14.246.108.65.clients.your-server.de] has joined #bitcoin-core-dev
05:05 -!- acl [~acl@41.140.34.65] has quit [Quit: Leaving...]
05:22 -!- test_ [flooded@gateway/vpn/protonvpn/flood/x-43489060] has joined #bitcoin-core-dev
05:26 -!- flooded [flooded@gateway/vpn/protonvpn/flood/x-43489060] has quit [Ping timeout: 258 seconds]
05:32 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has joined #bitcoin-core-dev
05:50 -!- Nekorand [~Random@cm-188-171-200-176.telecable.es] has joined #bitcoin-core-dev
06:52 -!- preimage [~halosghos@user/halosghost] has joined #bitcoin-core-dev
07:14 -!- michaelfolkson [~michaelfo@138.68.143.20] has quit [Server closed connection]
07:15 -!- michaelfolkson [~michaelfo@138.68.143.20] has joined #bitcoin-core-dev
07:20 < dergoegge> MarcoFalke: according to the afl++ docs we are using __AFL_INIT (slightly) wrong: https://github.com/AFLplusplus/AFLplusplus/blob/stable/instrumentation/README.persistent_mode.md#3-deferred-initialization
07:20 < dergoegge> e.g. our initialization of tmp files and threads (test setups) before calling __AFL_INIT should/can cause problems
07:20 <@gribble> https://github.com/bitcoin/bitcoin/issues/3 | Encrypt wallet · Issue #3 · bitcoin/bitcoin · GitHub
07:21 < dergoegge> interesting that we've never seen these problems on oss-fuzz (or maybe we have?)
07:22 < dergoegge> MacroFake
07:31 -!- Nekorand [~Random@cm-188-171-200-176.telecable.es] has quit [Quit: Leaving]
08:06 -!- dberkelmans [~dberkelma@2001:1c03:530d:8100:8528:7818:2871:c5f8] has joined #bitcoin-core-dev
08:22 -!- test_ [flooded@gateway/vpn/protonvpn/flood/x-43489060] has quit [Read error: Connection reset by peer]
08:22 -!- test_ [flooded@gateway/vpn/protonvpn/flood/x-43489060] has joined #bitcoin-core-dev
08:48 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
08:49 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev []
08:50 -!- dberkelmans [~dberkelma@2001:1c03:530d:8100:8528:7818:2871:c5f8] has quit [Quit: Client closed]
09:08 < dergoegge> yea so looks like all of our targets that spin up threads on initialization don't work with the deferred fork server mode
09:14 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
09:14 -!- jonatack [~jonatack@user/jonatack] has quit [Read error: Connection reset by peer]
09:41 -!- bugs_ [~bugs@user/bugs/x-5128603] has joined #bitcoin-core-dev
10:23 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
10:27 < cfields> sipa: ok, I give up, can you explain MallocUsage() ?
10:28 < cfields> context: I'm tying myself in knots trying to get a grasp on https://github.com/bitcoin/bitcoin/pull/28385#discussion_r1323354371
10:29 < cfields> the accounting seems off, but it's not clear to me what it should be either.
10:48 < sipa> cfields: oh i know it's off; i left a comment on some PR a while ago where i re-benchmarked it all
10:48 < sipa> i probably should have opened an issue instead
10:48 < sipa> the current MallocUsage was for some old glibc, and it seems incorrect now
10:49 < sipa> i wish i remembered which PR that was
11:00 -!- airswing [~airswing@136.49.24.238] has joined #bitcoin-core-dev
11:02 -!- benwestgate [~BenWestga@035-146-116-090.res.spectrum.com] has quit [Quit: Leaving.]
11:02 -!- bugs_ [~bugs@user/bugs/x-5128603] has quit [Quit: Leaving]
11:16 -!- berndj [~berndj@197.189.254.139] has quit [Server closed connection]
11:17 -!- berndj [~berndj@197.189.254.139] has joined #bitcoin-core-dev
11:34 -!- gfdhgf [~kghuyg@87.76.253.250] has joined #bitcoin-core-dev
11:41 -!- flooded [flooded@gateway/vpn/protonvpn/flood/x-43489060] has joined #bitcoin-core-dev
11:45 -!- test_ [flooded@gateway/vpn/protonvpn/flood/x-43489060] has quit [Ping timeout: 255 seconds]
11:46 < hebasto> cfields: sipa: maybe #18086 and #26614 ?
11:46 <@gribble> https://github.com/bitcoin/bitcoin/issues/18086 | Accurately account for mempool index memory by sipa · Pull Request #18086 · bitcoin/bitcoin · GitHub
11:46 <@gribble> https://github.com/bitcoin/bitcoin/issues/26614 | Accurately account for mempool index memory by hebasto · Pull Request #26614 · bitcoin/bitcoin · GitHub
11:47 < sipa> hebasto: no, but that provided me with the right pointers!
11:47 < sipa> https://github.com/bitcoin/bitcoin/pull/27748#discussion_r1215541260
11:47 < sipa> cfields: ^
11:59 < cfields> sipa: mmm. ok, I have some reading/catching up to do. But that seems quite naive for containers, especially here where we only ever write to this unordered_map after doing a full reserve: 
11:59 < cfields> https://github.com/bitcoin/bitcoin/pull/28385/files#diff-9e09b43c9f7a145d1b601fde94995e760bec5802744f5b5b16e1f31af562b4a3R34
11:59 < sipa> cfields: ehh, what do containers have to do with MallocUsage?
11:59 < cfields> Seems the numbers would be pretty inflated compared to a relatively smart single malloc
12:00 < sipa> MallocUsage just computes how much memory an allocation of N bytes uses in heap space.
12:01 < cfields> sipa: https://github.com/bitcoin/bitcoin/pull/28385/files#diff-33f5ad9ae321c77fe0cd7e467ced4221209f9d6edb18e0d843c637295517789dR164
12:02 -!- PaperSword [~qrsnap@securemail.qrsnap.io] has joined #bitcoin-core-dev
12:02 < cfields> My understanding is that that's accounting for malloc's slight over-allocations. But I would think that reserve() would prevent the over-allocation-per-node to some extent.
12:03 < sipa> that link is not loading for me on mobile
12:03 < sipa> can you copy the relevant line?
12:04 < cfields> It's adding std::list to memusage.h:
12:04 < cfields> static inline size_t DynamicUsage(const std::list<X>& l)
12:04 < cfields> {
12:04 < cfields>     return MallocUsage(sizeof(list_node<X>)) * l.size();
12:04 < sipa> that sounds right
12:05 < sipa> where is the over-allocation?
12:07 -!- bugs_ [~bugs@user/bugs/x-5128603] has joined #bitcoin-core-dev
12:07 < sipa> std::list has one malloc per element in the list, and each element is a node with an X, and pointers backward/forward
12:08 < sipa> std::list also has no reserve()
12:08 < cfields> *sigh*
12:08 < cfields> nevermind
12:08 < cfields> Yes, that last thing heh.
12:08 < cfields> The reserve got stuck in my head. But obviously that's for the unordered_map in DisconnectedBlockTransactions, not the list.
12:09 < sipa> Ah.
12:09 < cfields> Ok, but I guess the question still stands. Because we do reserve on unordered_maps elsewhere.
12:09 < cfields> And I guess it screws up the accounting. But if it's intended to be worst case that's fine.
12:10 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
12:10 < sipa> i think the implemented code is correct besides (a) MallocUsage is outdated and (b) the exact memory layout of unordered_map data structures is ultimately guesswork as it depends on the stl
12:11 < sipa> but ignoring those two points, an unordered_map consists of a single allocated hash table, plus one allocated object per entry in the map
12:12 < sipa> the reserve only affects the size of the hash table, not the elements in iy
12:12 < sipa> *it
12:14 < sipa> https://github.com/bitcoin/bitcoin/blob/master/src/memusage.h#L167
12:14 < sipa> the first part is the allocations for the entries in the map
12:14 < sipa> thr second part is for the hash table
12:16 < cfields> ok, that all makes sense. And vector makes sense in that regard as well. 
12:16 < cfields> sipa: thanks very much for the help. I got myself good and confused :)
12:16 < sipa> cfields: yw
12:17 < hebasto> accounting allocators were able to handle most (all?) containers presicely
12:19 < hebasto> *precisely
12:26 -!- brunoerg [~brunoerg@2001:12d0:2080:2800:172:26:fffe:f00a] has joined #bitcoin-core-dev
12:59 -!- brunoerg [~brunoerg@2001:12d0:2080:2800:172:26:fffe:f00a] has quit [Remote host closed the connection]
13:07 -!- gfdhgf [~kghuyg@87.76.253.250] has quit [Quit: Leaving]
13:26 -!- brunoerg [~brunoerg@143.107.231.30] has joined #bitcoin-core-dev
14:05 -!- brunoerg [~brunoerg@143.107.231.30] has quit [Remote host closed the connection]
14:38 -!- ajonas [sid385278@id-385278.helmsley.irccloud.com] has quit [Server closed connection]
14:38 -!- ajonas [sid385278@id-385278.helmsley.irccloud.com] has joined #bitcoin-core-dev
14:38 -!- jnewbery [~john@user/jnewbery] has quit [Server closed connection]
14:38 -!- jnewbery [~john@user/jnewbery] has joined #bitcoin-core-dev
15:02 -!- pablomartin [~pablomart@89.40.212.88] has joined #bitcoin-core-dev
15:03 -!- benwestgate [~BenWestga@035-146-116-090.res.spectrum.com] has joined #bitcoin-core-dev
15:04 -!- lbia [~lbia@user/lbia] has quit [Ping timeout: 246 seconds]
15:06 -!- preimage [~halosghos@user/halosghost] has quit [Quit: WeeChat 4.0.4]
15:07 -!- benwestgate [~BenWestga@035-146-116-090.res.spectrum.com] has quit [Ping timeout: 245 seconds]
15:07 -!- vysn [~vysn@user/vysn] has quit [Remote host closed the connection]
15:14 -!- rahl [rahl@otaku.sdf.org] has quit [Server closed connection]
15:14 -!- rahl [rahl@otaku.sdf.org] has joined #bitcoin-core-dev
15:19 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Remote host closed the connection]
15:25 -!- Evel-Knievel [~Evel-Knie@user/evel-knievel] has quit [Ping timeout: 255 seconds]
15:25 -!- Evel-Knievel [~Evel-Knie@user/evel-knievel] has joined #bitcoin-core-dev
15:26 -!- bugs_ [~bugs@user/bugs/x-5128603] has quit [Quit: Leaving]
15:34 -!- benwestgate [~BenWestga@035-146-116-090.res.spectrum.com] has joined #bitcoin-core-dev
15:36 < PaperSword> Is there method in CScript that will print the op codes in the same way bitcoin-cli decodescript does?
15:37 < PaperSword> or do I have to just run ls
15:38 < PaperSword> sorry *or do I have to just iterate over the script with GetOp and print the results as I iterate through?
15:39 < sipa> PaperSword: i think you can figure out the answer for yourself, by looking at the implementation of decodescript
15:45 < sipa> the answer is no, but obviously decodescript must be doing this conversion to human-readable form in some way, and you can probably invoke and/or reuse that code
15:46 -!- Jackielove4u [uid43977@user/jackielove4u] has quit [Quit: Connection closed for inactivity]
15:50 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
16:15 < lightlike> it's a really nice side-effect of migrating to GH actions that win/mac CI now run when pushing sth to my local repo, before opening a PR.
16:24 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 255 seconds]
16:48 -!- Guest27 [~Guest27@204.116.189.61] has joined #bitcoin-core-dev
16:48 -!- Guest27 [~Guest27@204.116.189.61] has quit [Client Quit]
17:23 -!- dermoth [~dermoth@user/dermoth] has quit [Ping timeout: 246 seconds]
17:26 -!- dermoth [~dermoth@user/dermoth] has joined #bitcoin-core-dev
17:31 < PaperSword> @sipa, thank you. Sorry for being lazy. 
17:59 -!- test_ [flooded@gateway/vpn/protonvpn/flood/x-43489060] has joined #bitcoin-core-dev
18:03 -!- flooded [flooded@gateway/vpn/protonvpn/flood/x-43489060] has quit [Ping timeout: 240 seconds]
18:21 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
18:22 < dviola> bumping sqlite versions shouldn't be an issue with descriptor wallets, right?
18:39 -!- jonasschnelli [~jonasschn@static.239.36.216.95.clients.your-server.de] has quit [Server closed connection]
18:39 -!- jonasschnelli [~jonasschn@2a01:4f9:2a:2510::2] has joined #bitcoin-core-dev
18:42 -!- arik__ [sid402902@id-402902.lymington.irccloud.com] has quit [Server closed connection]
18:43 -!- arik__ [sid402902@id-402902.lymington.irccloud.com] has joined #bitcoin-core-dev
18:53 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 252 seconds]
19:04 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has quit [Quit: Connection closed for inactivity]
19:31 -!- face [~face@mail.hmel.org] has quit [Server closed connection]
19:31 -!- face [~face@mail.hmel.org] has joined #bitcoin-core-dev
19:34 -!- airswing [~airswing@136.49.24.238] has left #bitcoin-core-dev [Leaving]
20:21 -!- pablomartin [~pablomart@89.40.212.88] has quit [Ping timeout: 252 seconds]
20:35 -!- andytoshi [~apoelstra@user/andytoshi] has quit [Server closed connection]
20:35 -!- andytoshi [~apoelstra@user/andytoshi] has joined #bitcoin-core-dev
20:51 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:23 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 252 seconds]
21:58 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
21:58 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
22:15 -!- PaperSword [~qrsnap@securemail.qrsnap.io] has quit [Quit: Lost terminal]
23:02 -!- ritter74 [~ritter@191.83.133.62] has joined #bitcoin-core-dev
23:05 -!- ritter74 [~ritter@191.83.133.62] has left #bitcoin-core-dev []
23:13 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
23:13 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 246 seconds]
23:58 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
23:59 -!- puchka [~puchka@185.203.122.78] has quit [Ping timeout: 246 seconds]
--- Log closed Wed Sep 13 00:00:21 2023