--- Log opened Thu Nov 16 00:00:27 2023
00:02 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
00:07 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 256 seconds]
00:07 -!- adiabat_ [~adiabat@63.209.32.102] has quit [Server closed connection]
00:08 -!- adiabat_ [~adiabat@63.209.32.102] has joined #bitcoin-core-dev
00:12 -!- salvatoshi [~salvatosh@194.65.48.125] has joined #bitcoin-core-dev
00:20 -!- cm [~chaz@user/cm] has quit [Server closed connection]
00:20 -!- cm [~chaz@user/cm] has joined #bitcoin-core-dev
00:35 -!- S3RK [~S3RK@user/s3rk] has quit [Server closed connection]
00:36 -!- S3RK [~S3RK@user/s3rk] has joined #bitcoin-core-dev
00:36 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
00:41 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 246 seconds]
00:57 -!- TheCharlatan [~drgrid@2a01:4f9:4a:2adc::2] has quit [Server closed connection]
00:57 -!- TheCharlatan [~drgrid@2a01:4f9:4a:2adc::2] has joined #bitcoin-core-dev
01:08 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
01:10 < bitcoin-git> [bitcoin] miz1choobi opened pull request #28888: Update .editorconfig (master...patch-1) https://github.com/bitcoin/bitcoin/pull/28888
01:10 < bitcoin-git> [bitcoin] airdropbaaz opened pull request #28889: Update .cirrus.yml (master...patch-1) https://github.com/bitcoin/bitcoin/pull/28889
01:12 < bitcoin-git> [bitcoin] fanquake closed pull request #28889: Update .cirrus.yml (master...patch-1) https://github.com/bitcoin/bitcoin/pull/28889
01:12 < bitcoin-git> [bitcoin] fanquake closed pull request #28888: Update .editorconfig (master...patch-1) https://github.com/bitcoin/bitcoin/pull/28888
01:17 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 256 seconds]
01:32 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0aa014d5a34e...1430c4b989bf
01:32 < bitcoin-git> bitcoin/master defdf67 muxator: contrib: use a raw string for a regular expression literal that contains b...
01:32 < bitcoin-git> bitcoin/master 1430c4b fanquake: Merge bitcoin/bitcoin#28883: contrib: use a raw string for a regular expre...
01:32 < bitcoin-git> [bitcoin] fanquake merged pull request #28883: contrib: use a raw string for a regular expression literal that contains backslashes in signet/miner (master...miner-use-raw-strings) https://github.com/bitcoin/bitcoin/pull/28883
01:35 < bitcoin-git> [bitcoin] maflcko opened pull request #28890: rpc: Remove deprecated -rpcserialversion (master...2311-no-rpc-tx-ser-flag-) https://github.com/bitcoin/bitcoin/pull/28890
01:40 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1430c4b989bf...1ad43f95b887
01:40 < bitcoin-git> bitcoin/master 30bd4b1 fanquake: doc: remove mention of missing bdb being a configure error
01:40 < bitcoin-git> bitcoin/master 1ad43f9 fanquake: Merge bitcoin/bitcoin#28881: doc: remove mention of missing bdb being a co...
01:40 < bitcoin-git> [bitcoin] fanquake merged pull request #28881: doc: remove mention of missing bdb being a configure error (master...no_bdb_is_no_error) https://github.com/bitcoin/bitcoin/pull/28881
01:41 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1ad43f95b887...b217b806cbc7
01:41 < bitcoin-git> bitcoin/master 821a8a1 fanquake: doc: remove x86_64 build assumption from depends doc
01:41 < bitcoin-git> bitcoin/master b217b80 fanquake: Merge bitcoin/bitcoin#28884: doc: remove x86_64 build assumption from depe...
01:41 < bitcoin-git> [bitcoin] fanquake merged pull request #28884: doc: remove x86_64 build assumption from depends doc (master...depends_works_on_aarch64) https://github.com/bitcoin/bitcoin/pull/28884
01:42 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has joined #bitcoin-core-dev
01:47 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
01:49 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b217b806cbc7...eb2ab3de1a48
01:49 < bitcoin-git> bitcoin/master fe434a4 TheCharlatan: bench: Update nanobench to 4.3.11
01:49 < bitcoin-git> bitcoin/master eb2ab3d fanquake: Merge bitcoin/bitcoin#28877: bench: Update nanobench to 4.3.11
01:49 < bitcoin-git> [bitcoin] fanquake merged pull request #28877: bench: Update nanobench to 4.3.11 (master...updateNanoBench) https://github.com/bitcoin/bitcoin/pull/28877
01:52 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 268 seconds]
02:00 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
02:10 -!- Flow [~none@gentoo/developer/flow] has quit [Server closed connection]
02:10 -!- Flow [~none@gentoo/developer/flow] has joined #bitcoin-core-dev
02:16 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/eb2ab3de1a48...6b7bf907f55f
02:16 < bitcoin-git> bitcoin/master a0626cc Greg Sanders: fuzz: allow reaching MempoolAcceptResult::ResultType::DIFFERENT_WITNESS in...
02:16 < bitcoin-git> bitcoin/master 6a91791 Greg Sanders: fuzz: allow fake and duplicate inputs in tx_package_eval target
02:16 < bitcoin-git> bitcoin/master 6b7bf90 fanquake: Merge bitcoin/bitcoin#28825: fuzz: Minor improvements to tx_package_eval t...
02:16 < bitcoin-git> [bitcoin] fanquake merged pull request #28825: fuzz: Minor improvements to tx_package_eval target (master...2023-11-package_fuzz_impr) https://github.com/bitcoin/bitcoin/pull/28825
02:18 -!- lightlike [sid521075@user/lightlike] has quit [Server closed connection]
02:18 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6b7bf907f55f...04e871d62f09
02:18 < bitcoin-git> bitcoin/master 3b19100 fanquake: depends: remove PYTHONPATH from config.site
02:18 < bitcoin-git> bitcoin/master 04e871d fanquake: Merge bitcoin/bitcoin#28845: depends: remove `PYTHONPATH` from config.site
02:18 -!- lightlike [sid521075@user/lightlike] has joined #bitcoin-core-dev
02:18 < bitcoin-git> [bitcoin] fanquake merged pull request #28845: depends: remove `PYTHONPATH` from config.site (master...drop_depends_pythonpath) https://github.com/bitcoin/bitcoin/pull/28845
02:19 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/04e871d62f09...c3735e53ee49
02:19 < bitcoin-git> bitcoin/master 88e09ac Andrew Chow: tests: Fix LCOV_OPTS to be in the correct position
02:19 < bitcoin-git> bitcoin/master c3735e5 fanquake: Merge bitcoin/bitcoin#28771: tests: Fix LCOV_OPTS to be in the correct pos...
02:19 < bitcoin-git> [bitcoin] fanquake merged pull request #28771: tests: Fix LCOV_OPTS to be in the correct position (master...lcov-opts) https://github.com/bitcoin/bitcoin/pull/28771
02:21 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
02:24 -!- BeefyBoot_ [uid53341@id-53341.tinside.irccloud.com] has quit [Quit: Connection closed for inactivity]
02:26 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 260 seconds]
02:36 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c3735e53ee49...22025d06e53f
02:36 < bitcoin-git> bitcoin/master 43de4d3 Sjors Provoost: doc: fix typos
02:36 < bitcoin-git> bitcoin/master 22025d0 fanquake: Merge bitcoin/bitcoin#28605: Fix typos
02:36 < bitcoin-git> [bitcoin] fanquake merged pull request #28605: Fix typos (master...2023/10/typos) https://github.com/bitcoin/bitcoin/pull/28605
02:53 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
02:58 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 256 seconds]
03:16 -!- kalle [~quassel@user/kallewoof] has quit [Server closed connection]
03:16 -!- kalle [~quassel@user/kallewoof] has joined #bitcoin-core-dev
03:33 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
03:38 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 246 seconds]
03:43 < bitcoin-git> [bitcoin] theStack opened pull request #28891: test: fix `AddNode` unit test failure on OpenBSD (master...202311-test-fix-net_peer_connection_tests-on-BSDs) https://github.com/bitcoin/bitcoin/pull/28891
03:45 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
03:46 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 252 seconds]
03:46 < bitcoin-git> [bitcoin] maflcko closed pull request #27820: Sanitizing ports of -rpcconnect and -rpcport. (master...PortSanitizing) https://github.com/bitcoin/bitcoin/pull/27820
03:48 < bitcoin-git> [bitcoin] maflcko closed pull request #27815: CLI: Only one Request Handler can be specified. (master...cli_request_handlers) https://github.com/bitcoin/bitcoin/pull/27815
03:49 < bitcoin-git> [bitcoin] maflcko closed pull request #27814: Blocking arguments -nohelp, -noh, and -no? (master...nonohelp) https://github.com/bitcoin/bitcoin/pull/27814
04:02 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has quit [Quit: Connection closed for inactivity]
04:08 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
04:13 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 256 seconds]
04:43 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
04:48 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 246 seconds]
04:50 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has joined #bitcoin-core-dev
04:53 -!- johnzweng [~johnzweng@zweng.at] has quit [Server closed connection]
04:54 -!- johnzweng [~johnzweng@zweng.at] has joined #bitcoin-core-dev
05:04 -!- benwestgate [~BenWestga@2603-8080-74f0-5ac0-c500-c884-5e09-b9ce.res6.spectrum.com] has quit [Quit: Leaving.]
05:05 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
05:07 < maxedw> #proposedmeetingtopic 26 RC testing guide update
05:10 -!- benwestgate [~BenWestga@035-146-116-090.res.spectrum.com] has joined #bitcoin-core-dev
05:28 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
05:37 -!- pablomartin [~pablomart@185.61.158.227] has joined #bitcoin-core-dev
05:58 -!- kashifs [~kashifs@2603-7000-4600-0500-7953-516e-3ed2-ce60.res6.spectrum.com] has joined #bitcoin-core-dev
06:00 < achow101> #startmeeting
06:00 < achow101> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard aureleoules b10c BlueMatt brunoerg cfields darosior dergoegge dongcarl fanquake fjahr furszy gleb glozow hebasto instagibbs jamesob jarolrod jonatack josibake kallewoof kanzure kouloumos kvaciral laanwj LarryRuane lightlike luke-jr MacroFake Murch phantomcircuit pinheadmz promag provoostenator ryanofsky sdaftuar S3RK stickies-v sipa theStack TheCharlatan vasild
06:00 < gleb> hi
06:00 < stickies-v> hi
06:00 < RubenSomsen> hi
06:00 < furszy> hi
06:00 < maxedw> hi
06:00 < dergoegge> hi
06:00 < pinheadmz> Hi from the Q train
06:00 < achow101> There's one preproposed meeting topic this week, any last minute ones to add?
06:00 < lightlike> Hi
06:00 < brunoerg> hi
06:01 < RubenSomsen> will be doing silent payments again
06:01 < achow101> #topic package relay updates (glozow)
06:01 < achow101> glozow isn't here, but I've been told that the tracking issue has been updated #27463
06:01 <@gribble> https://github.com/bitcoin/bitcoin/issues/27463 | Package Relay Project Tracking · Issue #27463 · bitcoin/bitcoin · GitHub
06:02 < achow101> the most recent comment explains the current plan
06:02 < fjahr> hi
06:02 < achow101> the next pr for package relay is #28848
06:02 <@gribble> https://github.com/bitcoin/bitcoin/issues/28848 | bugfix, Change up submitpackage results to return results for all transactions by instagibbs · Pull Request #28848 · bitcoin/bitcoin · GitHub
06:03 < kanzure> hi
06:03 < achow101> #topic silent payments updates (RubenSomsen)
06:04 < RubenSomsen> No major changes. Still actively taking review on BIP352, responding to feedback and wanting review on #25273.
06:04 <@gribble> https://github.com/bitcoin/bitcoin/issues/25273 | wallet: Pass through transaction locktime and preset input sequences and scripts to CreateTransaction by achow101 · Pull Request #25273 · bitcoin/bitcoin · GitHub
06:04 < achow101> apparently I need to rebase
06:05 < achow101> #topic multiprocess updates (ryanofsky)
06:05 < achow101> I think ryanofsky has been out for the past little bit. #28721 was merged, next up should be #10102
06:06 <@gribble> https://github.com/bitcoin/bitcoin/issues/28721 | multiprocess compatibility updates by ryanofsky · Pull Request #28721 · bitcoin/bitcoin · GitHub
06:06 <@gribble> https://github.com/bitcoin/bitcoin/issues/10102 | Multiprocess bitcoin by ryanofsky · Pull Request #10102 · bitcoin/bitcoin · GitHub
06:06 < hebasto> hi
06:06 < achow101> #topic Ad-hoc high priority for review
06:06 < achow101> Anything to add or remove from https://github.com/orgs/bitcoin/projects/1/views/4
06:08 < achow101> #topic 26 RC testing guide update (maxedw)
06:09 < maxedw> thank you to those who have helped review and refine the 26.0 testing guide, especially stickies-v who has put a lot of time in
06:09 < maxedw> link to document: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/26.0-Release-Candidate-Testing-Guide
06:09 < maxedw> we did a run through of most of it at the pr review club yesterday
06:09 < maxedw> it went well however we didn't have the highest attendance so any extra review from people here would be appreciated
06:09 < maxedw> github issue has been created to track any feedback from here on and is linked at the top and bottom of the document
06:10 < sipa> summoning ryanofsky
06:10 < achow101> maxedw: have any issues been found yet?
06:11 < maxedw> only with the guide itself
06:11 < achow101> it seems like we could probably do the final release at this point
06:11 < achow101> there hasn't been anything to backport to an rc3 either
06:13 < achow101> Any other topics to discuss this week?
06:14 -!- conman [~con@180-150-21-3.b49615.mel.static.aussiebb.net] has quit [Ping timeout: 256 seconds]
06:15 < achow101> #endmeeting
06:15 < maxedw> thanks achow101 
06:16 < bitcoin-git> [bitcoin] maflcko opened pull request #28892:  refactor: P2P transport without serialize version and type  (master...2311-p2p-no-nVersion-) https://github.com/bitcoin/bitcoin/pull/28892
06:17 < instagibbs> (just got back, timezone change yay) re:package relay,  last comment in the thread should explain everything https://github.com/bitcoin/bitcoin/issues/27463#issuecomment-1810836012
06:21 < willcl-ark> hi
06:36 < fanquake> I've pushed changes to finalize 26.0 into #28872
06:36 <@gribble> https://github.com/bitcoin/bitcoin/issues/28872 | [26.x] Final Changes by fanquake · Pull Request #28872 · bitcoin/bitcoin · GitHub
06:41 -!- michaelfolkson [~michaelfo@138.68.143.20] has quit [Server closed connection]
06:42 -!- michaelfolkson [~michaelfo@138.68.143.20] has joined #bitcoin-core-dev
06:43 < bitcoin-git> [bitcoin] hebasto opened pull request #28893: Fix SSE4.1-related issues (master...231116-sse41) https://github.com/bitcoin/bitcoin/pull/28893
06:44 < bitcoin-git> [bitcoin] furszy opened pull request #28894: wallet: batch all atomic spkms setup db writes in a single db txn  (master...2023_wallet_batch_keypool_creation) https://github.com/bitcoin/bitcoin/pull/28894
06:54 -!- Chris_Stewart_5 [~Chris_Ste@146.70.211.247] has quit [Read error: Connection reset by peer]
06:58 -!- Chris_Stewart_5 [~Chris_Ste@97.125.2.104] has joined #bitcoin-core-dev
07:00 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has quit [Quit: Connection closed for inactivity]
07:03 < cfields> hi
07:03 < jon_atack> achow101: a few issues found 3 months ago, hopefully pushing an update to #28248 with unit test coverage for each fix
07:03 <@gribble> https://github.com/bitcoin/bitcoin/issues/28248 | p2p: peer connection bug fixes by jonatack · Pull Request #28248 · bitcoin/bitcoin · GitHub
07:03 < cfields> sorry to be late.  proposed topic: cmake update
07:04 < jon_atack> achow101: see also https://github.com/bitcoin/bitcoin/pull/28872#issuecomment-1810696940
07:04 < jon_atack> *hopefully pushing an update today
07:04 -!- Chris_Stewart_5 [~Chris_Ste@97.125.2.104] has quit [Ping timeout: 256 seconds]
07:06 -!- Chris_Stewart_5 [~Chris_Ste@146.70.211.22] has joined #bitcoin-core-dev
07:11 < cfields> oh, heh, I'm an idiot. I kept waiting for the meeting to move on. I didn't realize I missed it by an hour heh.
07:11 < cfields> Short one.
07:12 < cfields> since I missed the meeting, cmake update anyway:
07:12 < cfields> We're at our self-imposed deadline and it's simply not ready yet. It's only reasonable that we stick to the original plan of merging soon-after branching off, so we've decided to push back and aim for getting CMake merged shortly after branching off for v28 instead. That way we should have plenty of time to get CMake fully reviewed and tested, as opposed to shoving it in half-baked and buggy.
07:12 < cfields> I'd like to make it very clear that hebasto has done an amazing job with keeping the work moving and staying up-to-date. He's also volunteered to keep doing so for another full release cycle. Pushing back a release is absolutely not a reflection on his work, rather, it's on me for not prioritizing review and keeping up. I'm very sorry that this will be dragging out further.
07:12 < cfields> Thanks very much to everyone who has contributed to review so far. Nothing is changing about the review process, we just have a little more breathing room now :)
07:13 < hebasto> cfields: thank you
07:19 < maflcko> hi
07:24 < lightlike> is https://github.com/bitcoin/bitcoin/issues/28718#issuecomment-1807197107 (OOM with armv7l) something that should be looked into more before the final release?
07:26 < hebasto> lightlike: not sure if it is a release blocker, but it would be nice at least figure out the commit that changed resource usage
07:27 < sipa> I vaguely remember another issue with arm OOM
07:28 < fanquake> hebasto: have you been bisecting since you posted that comment
07:28 < hebasto> nope
07:28 < sipa> #28440
07:28 <@gribble> https://github.com/bitcoin/bitcoin/issues/28440 | Impossible to run bitcoin on a Raspberry Pi 4 with 8GB, on Raspian 64 bit, which ships a 32 bit version of Docker (ARMHF instead of ARM64) · Issue #28440 · bitcoin/bitcoin · GitHub
07:31 < fanquake> Looks like that ended up being them messing with hardware power settings? Not sure why they were running bitcoind inside a docker container, on an rpi in the first place
07:32 < fanquake> *and maybe also the wrong version of docker for their hardware?
07:32 < sipa> fanquake: yes, lots of strange circumstances there, and rightfully closed i think
07:33 < sipa> but it was the case that bitcoind *was* growing beyond what it was supposed to, with an arm7 binary
07:33 < hebasto> my issue differs from 28440 as it happens without any containerizing
07:33 < achow101> jon_atack: a pr that is both draft and needs rebase for the past week is not a good candidate for backporting soon
07:35 < jon_atack> achow101: yes, it was clean and out of draft for a couple of months. i put it back into draft in order to add full unit test coverage for each fix. and working on that.
07:35 < achow101> It's also not clear to me which/whether the bugs being fixed are regressions
07:35 < sipa> hebasto: we don't know if 28440 wouldn't also happen without containerizing
07:35 < jon_atack> the issue was reported in August
07:36 < jon_atack> achow101: it is a regression, but in general that seems to be a new standard?  aren't bug fixes worthwhile?
07:36 < jon_atack> If the regression in v26.0 is left unfixed, it would be a good idea to add a warning to the "Notable Changes" section of the release notes where the changed behavior is described, as the way nodes have until now been able to ensure connections to various networks and particularly the ones with fewer peers, via addnode, is the behavior that is impacted. 
07:36 < achow101> generally for RCs we only fix regressions or showstpping bugs
07:37 < achow101> not all bug fixes, that'd be too many and we'd just never get a release out
07:37 < achow101> I don't think that's a new standard
07:38 < jon_atack> Ok. All I can do is find bugs, propose fixes, and add tests. And in the worse case, suggest a warning in the release notes, and maybe make a source code patch release for impacted users.
07:38 < jon_atack> Was also going to update the hardcoded seeds. I guess it's too late for that too.
07:39 < lightlike> jon_atack: why don't you open a PR with just a minimal fix for the regression. It's so late in the release cycle that anything else (e.g. unit tests, refactors etc.) seem hard to get in still.
07:40 < achow101> jon_atack: which "it"? the pr lists 7 things. are they all regressions?
07:40 < jon_atack> lightlike: I understand/agree/empathize and can do that today if it's not too late.
07:41 < achow101> essentially what I'm trying to figure out is what is the minimal set of changes that would fix the known regressions. the PR is currently 15 commits, and there have been no other reported issues in the rcs.
07:41 < lightlike> jon_atack: I can't say that, but can review soon.
07:41 < jon_atack> achow101: I've been working on a more minimal changeset of 5 fixes backed by unit tests. I think the CJDNS ones are uncontroversial and can wait, as very few people use that network at the present time.
07:43 -!- BeefyBoot_ [uid53341@id-53341.tinside.irccloud.com] has joined #bitcoin-core-dev
07:43 < jon_atack> achow101: lightlike: i can do a minimal patch in one commit, i.e. the original version of it without a data structure change from map to unordered set
07:43 < jon_atack> i'll do that now
07:49 -!- preimage [~halosghos@user/halosghost] has joined #bitcoin-core-dev
07:51 -!- josie [~josibake@suhail.uberspace.de] has quit [Read error: Connection reset by peer]
07:53 -!- josie [~josibake@suhail.uberspace.de] has joined #bitcoin-core-dev
08:01 < maflcko> jon_atack: The hardcoded seeds update should happen before the branch-off, according to the documentation. branch-off happened several weeks ago, so this seems too late to start now and doesn't seem like a blocker in any case.
08:01 -!- benwestgate [~BenWestga@035-146-116-090.res.spectrum.com] has quit [Quit: Leaving.]
08:02 < jon_atack> maflcko: thanks
08:37 -!- bugs_ [~bugs@user/bugs/x-5128603] has joined #bitcoin-core-dev
08:44 < bitcoin-git> [bitcoin] jonatack opened pull request #28895: p2p: do not make automatic outbound connections to addnode peers (master...2023-11-do-not-make-automatic-outbound-connection-to-addnode-peers) https://github.com/bitcoin/bitcoin/pull/28895
08:49 -!- freesprung51 [~freesprun@user/freesprung] has quit [Ping timeout: 240 seconds]
08:49 -!- freesprung51 [~freesprun@user/freesprung] has joined #bitcoin-core-dev
09:36 -!- salvatoshi [~salvatosh@194.65.48.125] has quit [Ping timeout: 260 seconds]
09:45 -!- jamesob [~jamesob@108.44.248.162] has quit [Server closed connection]
09:45 -!- jamesob [~jamesob@108.44.248.162] has joined #bitcoin-core-dev
10:22 -!- benwestgate [~BenWestga@2603-8080-74f0-5ac0-3efe-3d6b-f0a6-919b.res6.spectrum.com] has joined #bitcoin-core-dev
10:54 -!- mudsip [~mudsip@user/mudsip] has joined #bitcoin-core-dev
10:56 -!- kashifs [~kashifs@2603-7000-4600-0500-7953-516e-3ed2-ce60.res6.spectrum.com] has quit [Ping timeout: 250 seconds]
10:56 -!- mudsip [~mudsip@user/mudsip] has quit [Client Quit]
11:01 -!- BeefyBoot_ [uid53341@id-53341.tinside.irccloud.com] has quit [Quit: Connection closed for inactivity]
11:01 -!- puchka [~puchka@185.203.122.224] has quit [Ping timeout: 256 seconds]
11:05 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
11:06 -!- zato [~zato@user/zato] has joined #bitcoin-core-dev
11:07 -!- b10c [~quassel@user/b10c] has quit [Server closed connection]
11:07 -!- b10c [~quassel@static.33.106.217.95.clients.your-server.de] has joined #bitcoin-core-dev
11:07 -!- b10c [~quassel@user/b10c] has changed host
11:27 -!- asoltys [~adam@s207-81-214-251.bc.hsia.telus.net] has quit [Server closed connection]
11:27 -!- asoltys [~adam@s207-81-214-251.bc.hsia.telus.net] has joined #bitcoin-core-dev
12:13 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
12:25 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has quit [Quit: Connection closed for inactivity]
12:51 -!- warren [~warren@fedora/wombat/warren] has quit [Server closed connection]
12:52 -!- warren [~warren@fedora/wombat/warren] has joined #bitcoin-core-dev
12:57 -!- conman [~con@180-150-21-3.b49615.mel.static.aussiebb.net] has joined #bitcoin-core-dev
13:08 -!- pablomartin [~pablomart@185.61.158.227] has quit [Remote host closed the connection]
13:16 -!- lowhope_ is now known as lowhope
13:19 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection]
13:19 -!- bob_x1 [~bob_x@user/bob-x1/x-8934932] has quit [Remote host closed the connection]
13:20 -!- bob_x1 [~bob_x@user/bob-x1/x-8934932] has joined #bitcoin-core-dev
13:24 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
13:31 -!- kevkevin [~kevkevin@2601:241:8703:7b30:9839:729b:bfee:365a] has quit [Remote host closed the connection]
14:21 -!- bugs_ [~bugs@user/bugs/x-5128603] has quit [Quit: Leaving]
14:26 -!- preimage [~halosghos@user/halosghost] has quit [Quit: WeeChat 4.1.1]
14:29 -!- kashifs [~kashifs@2603-7000-4600-0500-951d-f494-fdff-e4ac.res6.spectrum.com] has joined #bitcoin-core-dev
14:59 -!- zato [~zato@user/zato] has quit [Quit: Om mani padme hum]
15:29 -!- BeefyBoot_ [uid53341@id-53341.tinside.irccloud.com] has joined #bitcoin-core-dev
15:31 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Remote host closed the connection]
15:33 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
15:37 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 256 seconds]
15:44 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
15:49 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 256 seconds]
16:09 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
16:09 -!- MatrixBot123 [~matrixbot@2001:bc8:1820:284::1] has quit [Server closed connection]
16:09 -!- MatrixBot123 [~matrixbot@2001:bc8:1820:284::1] has joined #bitcoin-core-dev
16:19 -!- kashifs [~kashifs@2603-7000-4600-0500-951d-f494-fdff-e4ac.res6.spectrum.com] has quit [Quit: Client closed]
16:20 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Remote host closed the connection]
16:21 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
16:25 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 256 seconds]
16:36 -!- Guest46 [~Guest26@2a0d:b201:c041:b7ea:25c0:a0a4:f263:dc17] has joined #bitcoin-core-dev
16:41 -!- Guest46 [~Guest26@2a0d:b201:c041:b7ea:25c0:a0a4:f263:dc17] has quit [Quit: Client closed]
16:48 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
16:52 -!- baakeydow [~baake@2001:41d0:203:b12c::] has quit [Server closed connection]
16:53 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 256 seconds]
17:13 -!- instagibbs [~instagibb@pool-100-15-116-202.washdc.fios.verizon.net] has quit [Server closed connection]
17:13 -!- instagibbs [~instagibb@pool-100-15-116-202.washdc.fios.verizon.net] has joined #bitcoin-core-dev
17:16 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
17:21 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 260 seconds]
17:23 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
17:29 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 246 seconds]
17:46 -!- vyHamii [~vyHamii@113.190.246.18] has joined #bitcoin-core-dev
17:46 -!- kevkevin [~kevkevin@2601:243:197e:8f10:c18e:48f6:22cf:5fbd] has joined #bitcoin-core-dev
17:48 -!- BeefyBoot_ [uid53341@id-53341.tinside.irccloud.com] has quit [Quit: Connection closed for inactivity]
17:50 -!- kevkevin [~kevkevin@2601:243:197e:8f10:c18e:48f6:22cf:5fbd] has quit [Ping timeout: 256 seconds]
18:04 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
18:05 -!- achow101 [~achow101@user/achow101] has quit [Remote host closed the connection]
18:12 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
18:17 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 256 seconds]
18:22 -!- Guest86 [~Guest86@202.191.109.104] has joined #bitcoin-core-dev
18:23 -!- Guest86 [~Guest86@202.191.109.104] has quit [Client Quit]
18:37 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection]
18:38 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
18:48 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
18:53 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 260 seconds]
19:17 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
19:22 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 268 seconds]
19:22 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
19:27 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 246 seconds]
19:29 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
19:32 -!- darosior [~darosior@109.205.214.46] has quit [Server closed connection]
19:32 -!- darosior [~darosior@109.205.214.46] has joined #bitcoin-core-dev
19:37 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 245 seconds]
19:55 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
19:59 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 260 seconds]
20:18 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
20:22 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 256 seconds]
20:25 -!- achow101 [~achow101@user/achow101] has joined #bitcoin-core-dev
20:32 -!- robobub [uid248673@id-248673.uxbridge.irccloud.com] has quit [Server closed connection]
20:33 -!- robobub [uid248673@id-248673.uxbridge.irccloud.com] has joined #bitcoin-core-dev
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:07 -!- jonasschnelli [~jonasschn@2a01:4f9:3081:504d::2] has quit [Server closed connection]
21:07 -!- jonasschnelli [~jonasschn@2a01:4f9:3081:504d::2] has joined #bitcoin-core-dev
21:13 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
21:17 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 256 seconds]
21:22 -!- valwal [sid570092@id-570092.tinside.irccloud.com] has quit [Server closed connection]
21:23 -!- valwal [sid570092@id-570092.tinside.irccloud.com] has joined #bitcoin-core-dev
21:24 -!- LarryRuane [sid473749@id-473749.uxbridge.irccloud.com] has quit [Server closed connection]
21:24 -!- LarryRuane [sid473749@id-473749.uxbridge.irccloud.com] has joined #bitcoin-core-dev
21:35 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
21:36 -!- Anth0mk [~Anth0mk@2a01:4f9:c012:2c3a::1] has quit [Server closed connection]
21:36 -!- Anth0mk [~Anth0mk@2a01:4f9:c012:2c3a::1] has joined #bitcoin-core-dev
21:41 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 268 seconds]
21:41 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
21:43 -!- dergoegge [sid453889@id-453889.lymington.irccloud.com] has quit [Server closed connection]
21:43 -!- dergoegge [sid453889@id-453889.lymington.irccloud.com] has joined #bitcoin-core-dev
21:46 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 268 seconds]
21:47 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
21:51 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 246 seconds]
22:06 -!- kanzure [~kanzure@user/kanzure] has quit [Server closed connection]
22:06 -!- kanzure [~kanzure@user/kanzure] has joined #bitcoin-core-dev
22:14 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
22:19 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 256 seconds]
22:37 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
22:41 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 246 seconds]
22:47 -!- kouloumos [sid539228@id-539228.tinside.irccloud.com] has quit [Server closed connection]
22:47 -!- kouloumos [sid539228@id-539228.tinside.irccloud.com] has joined #bitcoin-core-dev
22:59 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
23:07 -!- BlueMatt [~BlueMatt@ircb.bluematt.me] has quit [Server closed connection]
23:08 -!- BlueMatt [~BlueMatt@ircb.bluematt.me] has joined #bitcoin-core-dev
23:09 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 256 seconds]
23:12 -!- ajonas [sid385278@id-385278.helmsley.irccloud.com] has quit [Server closed connection]
23:12 -!- ajonas [sid385278@id-385278.helmsley.irccloud.com] has joined #bitcoin-core-dev
23:39 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
23:41 -!- sipa [~pw@user/sipa] has quit [Server closed connection]
23:41 -!- sipa [~pw@user/sipa] has joined #bitcoin-core-dev
23:44 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 260 seconds]
--- Log closed Fri Nov 17 00:00:28 2023