--- Log opened Tue Jan 23 00:00:37 2024
00:00 -!- qxs [~qxs@gateway/tor-sasl/qxs] has joined #bitcoin-core-dev
00:06 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection]
00:08 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
00:23 -!- puchka [~puchka@185.203.122.30] has quit [Ping timeout: 256 seconds]
01:05 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
01:05 -!- Flow [~none@gentoo/developer/flow] has quit [Ping timeout: 245 seconds]
01:06 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
01:07 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
01:08 -!- qxs [~qxs@gateway/tor-sasl/qxs] has quit [Ping timeout: 240 seconds]
01:09 -!- luke-jr_ [~luke-jr@user/luke-jr] has quit [Ping timeout: 260 seconds]
01:10 -!- qxs [~qxs@gateway/tor-sasl/qxs] has joined #bitcoin-core-dev
01:12 -!- Flow [~none@gentoo/developer/flow] has joined #bitcoin-core-dev
02:05 -!- brunoerg [~brunoerg@187.183.43.117] has quit []
02:27 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
03:14 < vasild> Sjors[m]: FUZZ=banman ./src/test/fuzz/fuzz --printtoconsole=1
03:16 < Sjors[m]> vasild: thanks, I got it to work yesterday by adding the test context: https://github.com/Sjors/bitcoin/pull/31/files#diff-2661c4a956119b8a5e235ec17ab0f8a8eaec2a592b4f224f767e10cd7cf7a250R24-R26
03:17 < vasild> cool :)
03:25 -!- noonien [~noonien@user/noonien] has quit [Quit: The Lounge - https://thelounge.chat]
03:27 -!- noonien [~noonien@user/noonien] has joined #bitcoin-core-dev
03:32 -!- puchka [~puchka@185.203.122.131] has joined #bitcoin-core-dev
03:49 -!- zato [~zato@user/zato] has joined #bitcoin-core-dev
03:52 -!- qxs [~qxs@gateway/tor-sasl/qxs] has quit [Ping timeout: 240 seconds]
03:54 -!- qxs [~qxs@gateway/tor-sasl/qxs] has joined #bitcoin-core-dev
03:55 -!- noonien [~noonien@user/noonien] has quit [Quit: The Lounge - https://thelounge.chat]
03:57 -!- noonien [~noonien@user/noonien] has joined #bitcoin-core-dev
04:16 -!- noonien7 [~noonien@user/noonien] has joined #bitcoin-core-dev
04:17 -!- noonien [~noonien@user/noonien] has quit [Ping timeout: 264 seconds]
04:17 -!- noonien7 is now known as noonien
04:33 -!- puchka [~puchka@185.203.122.131] has quit [Ping timeout: 260 seconds]
05:02 -!- Guyver2_ [Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
05:06 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has quit [Ping timeout: 256 seconds]
05:15 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 240 seconds]
05:17 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
05:39 -!- Chris_Stewart_5 [~Chris_Ste@87.249.134.4] has quit [Remote host closed the connection]
05:52 < bitcoin-git> [bitcoin] Sjors opened pull request #29295: CKey: add Unserialize (master...2024/01/ckey_unserialize) https://github.com/bitcoin/bitcoin/pull/29295
06:00 -!- jonatack [~jonatack@user/jonatack] has quit [Quit: WeeChat 4.1.2]
06:07 -!- Chris_Stewart_5 [~Chris_Ste@static-68-235-44-8.cust.tzulo.com] has joined #bitcoin-core-dev
06:14 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
06:38 -!- zato [~zato@user/zato] has quit [Quit: Om mani padme hum]
06:57 < maflcko> PSA (if you see a CI failure on your pull request): https://github.com/bitcoin/bitcoin/pull/29218#issuecomment-1906227242 
07:09 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 256 seconds]
07:42 -!- puchka [~puchka@185.203.122.133] has joined #bitcoin-core-dev
08:02 -!- test_ [flooded@gateway/vpn/protonvpn/flood/x-43489060] has joined #bitcoin-core-dev
08:03 -!- furszy_ [~furszy@104.128.239.93] has joined #bitcoin-core-dev
08:03 -!- BlueMatt [~BlueMatt@ircb.bluematt.me] has joined #bitcoin-core-dev
08:03 -!- _cold [~cold@user/cold] has joined #bitcoin-core-dev
08:04 -!- Guest4 [~Guest4@37.105.223.0] has joined #bitcoin-core-dev
08:05 -!- Guest4 [~Guest4@37.105.223.0] has quit [Client Quit]
08:05 -!- lbia1 [~lbia@user/lbia] has joined #bitcoin-core-dev
08:05 -!- freedomcode [~reardenco@shrugged.reardencode.com] has joined #bitcoin-core-dev
08:08 -!- lbia [~lbia@user/lbia] has quit [Ping timeout: 264 seconds]
08:08 -!- BlueMatt_ [~BlueMatt@ircb.bluematt.me] has quit [Ping timeout: 264 seconds]
08:08 -!- furszy [~furszy@user/furszy] has quit [Ping timeout: 264 seconds]
08:08 -!- reardencode [~reardenco@shrugged.reardencode.com] has quit [Ping timeout: 264 seconds]
08:08 -!- flooded [flooded@gateway/vpn/protonvpn/flood/x-43489060] has quit [Ping timeout: 264 seconds]
08:08 -!- cold [~cold@user/cold] has quit [Ping timeout: 264 seconds]
08:21 -!- adil [~Thunderbi@2a00:f29:2a0:f1b4:85c0:b820:a38b:ee88] has joined #bitcoin-core-dev
08:47 -!- preimage [~halosghos@user/halosghost] has joined #bitcoin-core-dev
08:47 -!- preimage [~halosghos@user/halosghost] has quit [Client Quit]
08:48 -!- stmbln [~stmbln@178.19.213.182] has joined #bitcoin-core-dev
08:49 -!- stmbln [~stmbln@178.19.213.182] has left #bitcoin-core-dev []
08:52 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection]
08:52 -!- qxs [~qxs@gateway/tor-sasl/qxs] has quit [Remote host closed the connection]
08:52 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
08:52 -!- qxs [~qxs@gateway/tor-sasl/qxs] has joined #bitcoin-core-dev
08:53 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/651fb034d85e...8c9dceb962b2
08:53 < bitcoin-git> bitcoin/master 97181de Chris Stewart: Add test for negative transaction version w/ CSV to tx_valid.json
08:53 < bitcoin-git> bitcoin/master 8c9dceb fanquake: Merge bitcoin/bitcoin#29291: Add test for negative transaction version w/ ...
08:54 < bitcoin-git> [bitcoin] fanquake merged pull request #29291: Add test for negative transaction version w/ CSV to tx_valid.json (master...2024-01-11-locktime-neg-txversion-test) https://github.com/bitcoin/bitcoin/pull/29291
08:54 -!- preimage [~halosghos@user/halosghost] has joined #bitcoin-core-dev
08:55 -!- adil [~Thunderbi@2a00:f29:2a0:f1b4:85c0:b820:a38b:ee88] has quit [Quit: adil]
09:07 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8c9dceb962b2...f1ab078ed774
09:07 < bitcoin-git> bitcoin/master b8105b3 Ryan Ofsky: depends: Update libmultiprocess library to fix C++20 macos build error
09:07 < bitcoin-git> bitcoin/master f1ab078 fanquake: Merge bitcoin/bitcoin#29276: depends: Update libmultiprocess library to fi...
09:07 < bitcoin-git> [bitcoin] fanquake merged pull request #29276: depends: Update libmultiprocess library to fix C++20 macos build error (master...pr/c14) https://github.com/bitcoin/bitcoin/pull/29276
09:07 -!- zato [~zato@user/zato] has joined #bitcoin-core-dev
09:31 < bitcoin-git> [qa-assets] dergoegge opened pull request #165: Add fuzz inputs (main...2024-01-inputs) https://github.com/bitcoin-core/qa-assets/pull/165
09:36 -!- ___nick___ [~quassel@host86-130-0-114.range86-130.btcentralplus.com] has joined #bitcoin-core-dev
09:54 -!- Guest66 [~Guest66@public-gprs179905.centertel.pl] has joined #bitcoin-core-dev
09:58 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Quit: Leaving...]
10:05 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
10:11 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
10:16 < sdaftuar> glozow: I was wondering why testmempoolaccept will process (as a package/AcceptMultipleTransactions) sets of transactions that are not connected?
10:16 < sdaftuar> it seems like AcceptMultipleTransactions could be much simpler, eg for the v3 case, if we didn't have to deal with that as a possibility -- my thought was that disconnected components could be processed separately
10:16 < sdaftuar> but i wasn't sure if there was a reason that we do things this way?
10:24 -!- Guest66 [~Guest66@public-gprs179905.centertel.pl] has quit [Quit: Client closed]
10:29 -!- Talkless [~Talkless@mail.dargis.net] has quit [Ping timeout: 260 seconds]
10:34 -!- test_ is now known as _flood
10:39 < glozow> sdaftuar: the answer to that question is that I wrote #20833 not knowing anything about package relay and was actually just trying to enable a "multi testmempoolaccept" feature 😅. At the time people were suggesting #21413 as a use case, and I hadn't thought about child-with-parents topology yet
10:39 <@gribble> https://github.com/bitcoin/bitcoin/issues/20833 | rpc/validation: enable packages through testmempoolaccept by glozow · Pull Request #20833 · bitcoin/bitcoin · GitHub
10:39 <@gribble> https://github.com/bitcoin/bitcoin/issues/21413 | [rfc] add option to bypass contextual timelocks in testmempoolaccept? by glozow · Pull Request #21413 · bitcoin/bitcoin · GitHub
10:40 < glozow> Today, I can't think of a good reason... agree that it would make the most sense to packageify the transactions before sending them to validation
10:41 -!- Guyver2_ [Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev []
11:28 -!- preimage [~halosghos@user/halosghost] has quit [Ping timeout: 264 seconds]
11:33 -!- tecnecio [~tecnecio_@37.223.108.9] has joined #bitcoin-core-dev
11:34 < bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/f1ab078ed774...7cb7759b25f3
11:34 < bitcoin-git> bitcoin/master 2d58629 Richard Myers: wallet: fix coin selection tracing to return -1 when no change pos
11:34 < bitcoin-git> bitcoin/master d55fdb1 Richard Myers: Move TRACEx parameters to seperate lines
11:34 < bitcoin-git> bitcoin/master 7cb7759 Ava Chow: Merge bitcoin/bitcoin#29272: wallet: fix coin selection tracing to return ...
11:34 < bitcoin-git> [bitcoin] achow101 merged pull request #29272: wallet: fix coin selection tracing to return -1 when no change pos (master...cs-usdt-fixup) https://github.com/bitcoin/bitcoin/pull/29272
11:36 -!- zato [~zato@user/zato] has quit [Quit: Om mani padme hum]
11:38 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has quit [Quit: Connection closed for inactivity]
11:40 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
12:00 -!- qxs [~qxs@gateway/tor-sasl/qxs] has quit [Ping timeout: 240 seconds]
12:03 -!- qxs [~qxs@gateway/tor-sasl/qxs] has joined #bitcoin-core-dev
12:05 < bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7cb7759b25f3...6f732ffc3c91
12:05 < bitcoin-git> bitcoin/master 32a9f13 Vasil Dimov: wallet: avoid returning a reference to vMasterKey after releasing the mute...
12:05 < bitcoin-git> bitcoin/master 6f732ff Ava Chow: Merge bitcoin/bitcoin#28774: wallet: avoid returning a reference to vMaste...
12:05 < bitcoin-git> [bitcoin] achow101 merged pull request #28774: wallet: avoid returning a reference to vMasterKey after releasing the mutex that guards it (master...avoid_returning_reference_to_mutex_guarded_member) https://github.com/bitcoin/bitcoin/pull/28774
12:14 < bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/6f732ffc3c91...874c8bdb9e3c
12:14 < bitcoin-git> bitcoin/master 966f5de furszy: init: improve corrupted/empty settings file error msg
12:14 < bitcoin-git> bitcoin/master e901404 furszy: settings: add auto-generated warning msg for editing the file manually
12:14 < bitcoin-git> bitcoin/master 874c8bd Ava Chow: Merge bitcoin/bitcoin#29144: init: handle empty settings file gracefully
12:14 < bitcoin-git> [bitcoin] achow101 merged pull request #29144: init: handle empty settings file gracefully (master...2023_empty_settings_file) https://github.com/bitcoin/bitcoin/pull/29144
12:17 -!- preimage [~halosghos@user/halosghost] has joined #bitcoin-core-dev
12:24 -!- tecnecio [~tecnecio_@37.223.108.9] has quit [Quit: Leaving]
12:28 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 264 seconds]
12:34 -!- bugs_ [~bugs@user/bugs/x-5128603] has joined #bitcoin-core-dev
12:54 -!- ___nick___ [~quassel@host86-130-0-114.range86-130.btcentralplus.com] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
12:56 -!- ___nick___ [~quassel@host86-130-0-114.range86-130.btcentralplus.com] has joined #bitcoin-core-dev
12:56 -!- ___nick___ [~quassel@host86-130-0-114.range86-130.btcentralplus.com] has quit [Client Quit]
12:57 -!- bomb-on [~bomb-on@user/bomb-on] has joined #bitcoin-core-dev
12:58 -!- ___nick___ [~quassel@host86-130-0-114.range86-130.btcentralplus.com] has joined #bitcoin-core-dev
13:02 -!- jarthur [~jarthur@user/jarthur] has joined #bitcoin-core-dev
13:03 < bitcoin-git> [bitcoin] petertodd opened pull request #29297: RBF: Require unconfirmed inputs to come from a single conflicting transaction (master...2024-01-rbf-merging-unconfirmed-inputs) https://github.com/bitcoin/bitcoin/pull/29297
13:04 -!- ___nick___ [~quassel@host86-130-0-114.range86-130.btcentralplus.com] has quit [Ping timeout: 260 seconds]
13:12 -!- qxs [~qxs@gateway/tor-sasl/qxs] has quit [Ping timeout: 240 seconds]
13:14 -!- qxs [~qxs@gateway/tor-sasl/qxs] has joined #bitcoin-core-dev
13:22 < bitcoin-git> [bitcoin] achow101 pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/874c8bdb9e3c...2f218c664b32
13:22 < bitcoin-git> bitcoin/master 4aaee23 Ryan Ofsky: test: add ipc test to test multiprocess type conversion code
13:22 < bitcoin-git> bitcoin/master 0cc74fc Ryan Ofsky: multiprocess: Add type conversion code for serializable types
13:22 < bitcoin-git> bitcoin/master 6acec6b Ryan Ofsky: multiprocess: Add type conversion code for UniValue types
13:22 < bitcoin-git> [bitcoin] achow101 merged pull request #28921: multiprocess: Add basic type conversion hooks (master...pr/ipcc) https://github.com/bitcoin/bitcoin/pull/28921
13:24 < bitcoin-git> [bitcoin] theuni opened pull request #29298: depends: patch libool out of libnatpmp/miniupnpc (master...depends-no-libtool2) https://github.com/bitcoin/bitcoin/pull/29298
13:32 < bitcoin-git> [bitcoin] theuni closed pull request #29232: depends: remove dependency on Darwin libtool (master...depends-no-libtool) https://github.com/bitcoin/bitcoin/pull/29232
13:41 < bitcoin-git> [bitcoin] achow101 pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/2f218c664b32...e69796c79c0a
13:41 < bitcoin-git> bitcoin/master 435fe5c josibake: test: add tests for fundrawtx and sendmany rpcs
13:41 < bitcoin-git> bitcoin/master 6f569ac josibake: refactor: move normalization to new function
13:41 < bitcoin-git> bitcoin/master f7384b9 josibake: refactor: move parsing to new function
13:41 < bitcoin-git> [bitcoin] achow101 merged pull request #28560: wallet, rpc: `FundTransaction` refactor (master...fundtransaction-sffo-crecipient-refactor) https://github.com/bitcoin/bitcoin/pull/28560
14:10 -!- jonolito [~jonolito@2a00:23c4:685f:9d01::1af1] has joined #bitcoin-core-dev
14:10 -!- jonolito [~jonolito@2a00:23c4:685f:9d01::1af1] has quit [Client Quit]
14:34 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Remote host closed the connection]
14:35 -!- _cold is now known as cold
14:54 -!- vysn [~vysn@user/vysn] has quit [Remote host closed the connection]
14:59 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection]
15:00 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
15:04 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
15:09 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 240 seconds]
15:10 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
15:20 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
15:20 -!- virtu [~zef@p5dd64b84.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]
15:21 -!- preimage [~halosghos@user/halosghost] has quit [Quit: WeeChat 4.2.1]
15:30 < bitcoin-git> [bitcoin] mzumsande opened pull request #29299: validation: improve checkblockindex comments (master...202401_cbi_assert) https://github.com/bitcoin/bitcoin/pull/29299
15:35 -!- bugs_ [~bugs@user/bugs/x-5128603] has quit [Quit: Leaving]
15:38 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 256 seconds]
15:40 -!- Calabrese [~Calabrese@189.178.105.218] has joined #bitcoin-core-dev
16:01 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection]
16:01 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
16:05 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has quit [Quit: PaperSword]
16:05 < bitcoin-git> [bitcoin] furszy opened pull request #29301: init: settings, do not load auto-generated warning msg (master...2024_settings_dont_load_warning_msg) https://github.com/bitcoin/bitcoin/pull/29301
16:28 < sdaftuar> glozow: i spent some time trying to rework the testmempoolaccept() behavior, so that we would first cluster the transactions into connected components, and then iteratively invoke either AcceptMultipleTransactions or AcceptPackage on each cluster.
16:28 < sdaftuar> I discovered that this is thornier than I thought!  The code to do the clustering is simple, but after looking at tests that fail I realize that the behavior we're looking for is possibly not what I initially thought
16:30 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
16:31 < sdaftuar> it seems to me that the use case we're trying to meet with testmempoolaccept(tx1,..., txN) is to answer the question of whether the mempool would accept all of those transactions if we submitted them (one by one?)
16:31 < sdaftuar> and by grouping them into separate clusters for processing, we answer a different question, of whether each connected component of (tx1, ..., txN) would be accepted
16:32 < sdaftuar> and those are really answering different questions...
16:32 < sdaftuar> interestingly, i think this question may get easier to answer in a cluster mempool world (it's very similar to what we have to do when evaluating an RBF, I think), so now I'm reluctant to suggest "breaking" the behavior we have now (even though i think it would make the rest of the v3 implementation simpler)
16:36 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 264 seconds]
16:39 -!- Guest84 [~Guest84@2607:fb91:1924:a9d:452b:670d:4ce6:4e3f] has joined #bitcoin-core-dev
16:41 < bitcoin-git> [bitcoin] marcofleon opened pull request #29302: wallet: clarify replaced_by_txid and replaces_txid in help output (master...2024/01/clarify-documentation) https://github.com/bitcoin/bitcoin/pull/29302
17:03 -!- Guest84 [~Guest84@2607:fb91:1924:a9d:452b:670d:4ce6:4e3f] has quit [Quit: Client closed]
17:53 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
18:04 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
18:18 -!- metta [~Advanced@2a01:4f8:1c0c:49df::1] has quit []
18:18 -!- upekkha [~Advanced@2a01:4f8:1c0c:49df::1] has joined #bitcoin-core-dev
18:53 -!- pablomartin4btc [~pablomart@193.160.245.52] has quit [Remote host closed the connection]
19:38 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
20:08 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 264 seconds]
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:17 -!- jarthur [~jarthur@user/jarthur] has quit [Quit: jarthur]
21:17 -!- zato [~zato@user/zato] has joined #bitcoin-core-dev
21:40 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
21:51 -!- Calabrese [~Calabrese@189.178.105.218] has quit [Quit: Client closed]
22:07 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
22:12 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 276 seconds]
23:27 -!- stmbln [~stmbln@178.19.213.182] has joined #bitcoin-core-dev
--- Log closed Wed Jan 24 00:00:38 2024