--- Log opened Wed Jan 24 00:00:38 2024
00:10 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
00:14 -!- stmbln [~stmbln@178.19.213.182] has left #bitcoin-core-dev []
00:58 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
02:02 < glozow> sdaftuar: ah makes sense. I imagine the best way to group the transactions should involve a linearization (e.g. submitting all of them would bust a package limit so put the higher feerate ones first)?
02:04 < glozow> re: v3 complexity, I don't know how much we'd be able to chop off if we didn't have to deal with multiple connected components. A lot of it is contained within `PackageV3Checks`. We'd still need to be able to see an in-package ancestor's mempool ancestor, so we need to cache it (that's the ugliest part imo).
02:57 < bitcoin-git> [bitcoin] dergoegge opened pull request #29304: fuzz: Exit and log stdout for parse_test_list errors (master...2024-01-fuzz-list-errs) https://github.com/bitcoin/bitcoin/pull/29304
03:13 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has joined #bitcoin-core-dev
03:30 < bitcoin-git> [qa-assets] dergoegge merged pull request #165: Add fuzz inputs (main...2024-01-inputs) https://github.com/bitcoin-core/qa-assets/pull/165
03:30 < bitcoin-git> [qa-assets] dergoegge pushed 2 commits to main: https://github.com/bitcoin-core/qa-assets/compare/0745c8615dff...f468c477b88c
03:30 < bitcoin-git> qa-assets/main 79be7ff dergoegge: Add fuzz inputs
03:30 < bitcoin-git> qa-assets/main f468c47 Niklas Gögge: Merge pull request #165 from dergoegge/2024-01-inputs
04:20 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
04:22 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 264 seconds]
04:23 < instagibbs> Murch[m] this is the real mystery for me: https://github.com/bitcoin/bitcoin/pull/29264#discussion_r1463935963 adding the error string causes other coin selection routines to fail in rpc_psbt.py. something about how coin selection handles errors with and without error strings
04:23 < instagibbs> would appreciate a coin selection sleuth to tell me what to do
04:26 -!- qxs [~qxs@gateway/tor-sasl/qxs] has quit [Ping timeout: 240 seconds]
04:28 -!- qxs [~qxs@gateway/tor-sasl/qxs] has joined #bitcoin-core-dev
04:29 -!- puchka [~puchka@185.203.122.133] has quit [Ping timeout: 256 seconds]
05:31 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has quit [Quit: Connection closed for inactivity]
05:43 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
05:44 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Ping timeout: 240 seconds]
05:44 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 255 seconds]
05:56 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
05:56 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Quit: Leaving]
06:02 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
06:03 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
06:04 -!- puchka [~puchka@185.203.122.136] has joined #bitcoin-core-dev
06:15 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has joined #bitcoin-core-dev
06:18 < bitcoin-git> [bitcoin] dergoegge opened pull request #29305: fuzz: Use FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION for pow checks (master...2024-01-fuzz-unsafe-pow) https://github.com/bitcoin/bitcoin/pull/29305
06:25 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
06:30 < bitcoin-git> [bitcoin] glozow opened pull request #29306: policy: enable sibling eviction for v3 transactions (master...2024-01-sibling-eviction) https://github.com/bitcoin/bitcoin/pull/29306
06:32 -!- qxs [~qxs@gateway/tor-sasl/qxs] has quit [Remote host closed the connection]
06:33 -!- qxs [~qxs@gateway/tor-sasl/qxs] has joined #bitcoin-core-dev
06:35 < bitcoin-git> [bitcoin] vasild opened pull request #29307: util: check for errors after close and read in AutoFile (master...AutoFile_error_check) https://github.com/bitcoin/bitcoin/pull/29307
06:38 -!- zato [~zato@user/zato] has quit [Ping timeout: 256 seconds]
06:42 -!- zato [~zato@user/zato] has joined #bitcoin-core-dev
06:46 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 256 seconds]
06:58 < sdaftuar> glozow: PackageV3Checks was the thing that I found to be pretty complex :)  Reviewing it now though with a better understanding of what the use case is for testmempoolaccept
06:59 < sdaftuar> one question occurs to me as I read the code: if A is a v3 transaction, with 2 child v3 transactions (B, C), and A is in the mempool, and we call testmempoolaccept(B, C), it should fail right?  I'm struggling to see what check would catch that.
07:00 < instagibbs> each individually would work.... hard to say heh
07:00 < instagibbs> testmempoolaccept stuff is a bit of a philosophical rabbit hole imo
07:01 < sdaftuar> right now i'm feeling pretty far into the anti-testmempoolaccept camp :)
07:01 < instagibbs> :)
07:03 < instagibbs> I had an alternative idea that I think I linked to many pages of comments back, glozow in case you recall?
07:13 < instagibbs> as much as I enjoy 100 pages of LN spec discussion...
07:14 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e69796c79c0a...ea4ddd8652d9
07:14 < bitcoin-git> bitcoin/master 9d09c87 dergoegge: fuzz: Exit and log stderr for parse_test_list errors
07:14 < bitcoin-git> bitcoin/master ea4ddd8 fanquake: Merge bitcoin/bitcoin#29304: fuzz: Exit and log stderr for parse_test_list...
07:14 < bitcoin-git> [bitcoin] fanquake merged pull request #29304: fuzz: Exit and log stderr for parse_test_list errors (master...2024-01-fuzz-list-errs) https://github.com/bitcoin/bitcoin/pull/29304
07:20 < sdaftuar> glozow: instagibbs: ah, i guess this is indeed a "bug" if we think that testmempoolaccept should return failure in that case (https://paste.ec/paste/YdtPxQbC#ta7ZisfkoZI4fiTZen5r5Cp1Qn8-gUxflUvf7grC6bQ)
07:21 < instagibbs> does that test pass or fail currently :)
07:22 < sdaftuar> if you run the test, it will say all tests pass, but the test is broken -- i assert that the 2 v3 children get accepted.
07:22 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [Closing Window]
07:23 < sdaftuar> overall it seems to me like testmempoolaccept is trying to do something that is currently way too hard, so i don't think i mind that this is broken, but probably worth documenting its limitations?
07:28 < instagibbs> there's a lot of caveats to what it does vs say test package evaluation, would be nice to be documented either way
07:31 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has joined #bitcoin-core-dev
07:34 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Remote host closed the connection]
07:34 < bitcoin-git> [bitcoin] ismaelsadeeq opened pull request #29308: doc: clarify that `BroadcastTransaction` comment (master...01-2024-clarify-BroadcastTransaction-comment) https://github.com/bitcoin/bitcoin/pull/29308
07:37 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
07:37 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
07:57 < bitcoin-git> [bitcoin] dergoegge closed pull request #29305: fuzz: Use FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION for pow checks (master...2024-01-fuzz-unsafe-pow) https://github.com/bitcoin/bitcoin/pull/29305
08:05 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
08:09 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 246 seconds]
08:27 -!- puchka [~puchka@185.203.122.136] has quit [Ping timeout: 276 seconds]
08:29 -!- qxs [~qxs@gateway/tor-sasl/qxs] has quit [Ping timeout: 240 seconds]
08:29 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 240 seconds]
08:31 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
08:32 -!- qxs [~qxs@gateway/tor-sasl/qxs] has joined #bitcoin-core-dev
08:52 -!- preimage [~halosghos@user/halosghost] has joined #bitcoin-core-dev
09:00 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection]
09:00 -!- qxs [~qxs@gateway/tor-sasl/qxs] has quit [Remote host closed the connection]
09:00 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
09:01 -!- qxs [~qxs@gateway/tor-sasl/qxs] has joined #bitcoin-core-dev
09:02 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection]
09:05 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
09:05 -!- vasild [~vd@user/vasild] has quit [Client Quit]
09:06 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
09:09 < glozow> sdaftuar: ooh good catch!
09:09 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
09:13 -!- bugs_ [~bugs@user/bugs/x-5128603] has joined #bitcoin-core-dev
09:15 < glozow> Maybe requiring testmempoolaccept be 1 connected component (but still simulating a 1 by 1 submission) solve this? Though that might be more trouble than it's worth as well. testmempoolaccept has some other documented shortcomings like sometimes overestimating ancestor/descendant limits and not doing cpfp carve out. So maybe it's fine.
09:41 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
09:47 -!- ___nick___ [~quassel@host86-130-0-114.range86-130.btcentralplus.com] has joined #bitcoin-core-dev
09:48 -!- jespada [~jespada@cpc121308-nmal25-2-0-cust15.19-2.cable.virginm.net] has quit [Quit: Textual IRC Client: www.textualapp.com]
09:51 -!- Peter59 [~Peter@p200300c2a73cbe0055ef90dbd6fca9f0.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
09:54 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
09:54 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection]
09:54 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
09:55 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
09:58 -!- Peter59 [~Peter@p200300c2a73cbe0055ef90dbd6fca9f0.dip0.t-ipconnect.de] has quit [Quit: Client closed]
10:03 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
10:04 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
10:04 < bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ea4ddd8652d9...207220ce8b76
10:04 < bitcoin-git> bitcoin/master ff54314 marco: wallet: clarify replaced_by_txid and replaces_txid in help output
10:04 < bitcoin-git> bitcoin/master 207220c Ava Chow: Merge bitcoin/bitcoin#29302: wallet: clarify replaced_by_txid and replaces...
10:05 < bitcoin-git> [bitcoin] achow101 merged pull request #29302: wallet: clarify replaced_by_txid and replaces_txid in help output (master...2024/01/clarify-documentation) https://github.com/bitcoin/bitcoin/pull/29302
10:14 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 256 seconds]
10:14 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 240 seconds]
10:23 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
10:25 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
10:26 -!- gracilis [gracilis@gateway/vpn/protonvpn/gracilis] has joined #bitcoin-core-dev
10:28 -!- gracilis [gracilis@gateway/vpn/protonvpn/gracilis] has quit [Remote host closed the connection]
10:30 -!- qxs [~qxs@gateway/tor-sasl/qxs] has quit [Remote host closed the connection]
10:31 -!- qxs [~qxs@gateway/tor-sasl/qxs] has joined #bitcoin-core-dev
10:40 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has quit [Quit: Connection closed for inactivity]
10:41 -!- puchka [~puchka@185.203.122.131] has joined #bitcoin-core-dev
10:48 < sdaftuar> glozow: i'm reluctant to propose any changes right now... i think ultimately, it will make sense to push these topology checks / global limit evaluation into the mempool itself. but we can wait until we have a better design in place for the mempool that will make that easier.
10:49 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
10:51 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 256 seconds]
10:55 -!- gracilis [gracilis@gateway/vpn/protonvpn/gracilis] has joined #bitcoin-core-dev
10:55 -!- gracilis [gracilis@gateway/vpn/protonvpn/gracilis] has quit [Remote host closed the connection]
11:06 -!- mudsip [~mudsip@user/mudsip] has joined #bitcoin-core-dev
11:06 -!- mudsip [~mudsip@user/mudsip] has quit [Client Quit]
11:18 -!- Talkless [~Talkless@mail.dargis.net] has quit [Ping timeout: 260 seconds]
11:27 -!- justache [~justache@user/justache] has quit [Read error: Connection reset by peer]
11:28 -!- justache [~justache@user/justache] has joined #bitcoin-core-dev
11:41 -!- zato is now known as ao
11:42 -!- justache [~justache@user/justache] has quit [Read error: Connection reset by peer]
11:42 -!- ao is now known as samurai_
11:42 -!- samurai_ is now known as ichi
11:47 -!- ichi is now known as fufu
11:48 -!- fufu is now known as lo
11:49 -!- justache [~justache@user/justache] has joined #bitcoin-core-dev
11:52 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 264 seconds]
11:52 -!- lo is now known as tata
11:53 -!- tata is now known as tat
11:54 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Remote host closed the connection]
11:54 -!- tat is now known as love
11:54 -!- love is now known as water_
11:55 -!- water_ is now known as wind
11:56 -!- wind is now known as earth
11:57 -!- earth is now known as da
12:04 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
12:04 -!- da is now known as zato
12:04 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 240 seconds]
12:11 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
12:19 -!- pablomartin [~pablomart@185.61.158.28] has joined #bitcoin-core-dev
12:19 -!- pablomartin is now known as pablomartin4btc
12:26 -!- zato [~zato@user/zato] has quit [Quit: Om mani padme hum]
12:36 -!- ___nick___ [~quassel@host86-130-0-114.range86-130.btcentralplus.com] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
12:38 -!- ___nick___ [~quassel@host86-130-0-114.range86-130.btcentralplus.com] has joined #bitcoin-core-dev
12:38 -!- ___nick___ [~quassel@host86-130-0-114.range86-130.btcentralplus.com] has quit [Client Quit]
12:41 -!- ___nick___ [~quassel@host86-130-0-114.range86-130.btcentralplus.com] has joined #bitcoin-core-dev
12:44 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 264 seconds]
12:56 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection]
12:57 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
13:04 -!- ___nick___ [~quassel@host86-130-0-114.range86-130.btcentralplus.com] has quit [Ping timeout: 260 seconds]
13:12 < glozow> sdaftuar: 👍
13:25 -!- Zenton [~user@user/zenton] has quit [Ping timeout: 256 seconds]
13:31 -!- vysn [~vysn@user/vysn] has quit [Remote host closed the connection]
13:35 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection]
13:35 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
13:42 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 240 seconds]
13:43 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection]
13:44 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
13:45 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
13:52 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection]
13:52 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
14:04 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has joined #bitcoin-core-dev
14:16 -!- preimage [~halosghos@user/halosghost] has quit [Ping timeout: 260 seconds]
14:32 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
14:39 -!- jarthur [~jarthur@user/jarthur] has joined #bitcoin-core-dev
14:41 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
15:03 -!- bugs_ [~bugs@user/bugs/x-5128603] has quit [Quit: Leaving]
15:14 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 264 seconds]
15:51 -!- brunoerg [~brunoerg@2804:1b3:a000:9f37:39e0:85aa:1f40:ef97] has joined #bitcoin-core-dev
15:52 -!- brunoerg [~brunoerg@2804:1b3:a000:9f37:39e0:85aa:1f40:ef97] has quit [Remote host closed the connection]
16:02 -!- jonatack [~jonatack@user/jonatack] has quit [Read error: Connection reset by peer]
16:04 -!- Calabrese [~Calabrese@189.178.105.218] has joined #bitcoin-core-dev
16:06 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
16:14 -!- realies [~realies@user/realies] has quit [Quit: Ping timeout (120 seconds)]
16:15 -!- realies [~realies@user/realies] has joined #bitcoin-core-dev
16:30 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has quit [Quit: Connection closed for inactivity]
17:50 -!- szkl [uid110435@id-110435.uxbridge.irccloud.com] has joined #bitcoin-core-dev
17:51 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
18:15 -!- SpellChecker_ [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
18:16 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Ping timeout: 240 seconds]
18:24 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 268 seconds]
19:12 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
20:09 -!- puchka [~puchka@185.203.122.131] has quit [Ping timeout: 256 seconds]
20:11 -!- puchka [~puchka@185.203.122.141] has joined #bitcoin-core-dev
20:18 -!- puchka [~puchka@185.203.122.141] has quit [Ping timeout: 256 seconds]
20:19 < bitcoin-git> [bitcoin] vostrnad opened pull request #29309: Add a `-permitbarepubkey` option (master...permitbarepubkey) https://github.com/bitcoin/bitcoin/pull/29309
20:20 -!- puchka [~puchka@185.203.122.138] has joined #bitcoin-core-dev
20:21 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
20:33 -!- Calabrese [~Calabrese@189.178.105.218] has quit [Quit: Client closed]
20:54 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 264 seconds]
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:33 -!- Guest7 [~Guest7@185.181.61.141] has joined #bitcoin-core-dev
21:33 -!- Guest7 [~Guest7@185.181.61.141] has quit [Client Quit]
21:49 -!- pablomartin4btc [~pablomart@185.61.158.28] has quit [Ping timeout: 276 seconds]
22:08 -!- PaperSword1 [~Thunderbi@securemail.qrsnap.io] has joined #bitcoin-core-dev
22:09 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has quit [Ping timeout: 264 seconds]
22:09 -!- PaperSword1 is now known as PaperSword
22:13 -!- puchka [~puchka@185.203.122.138] has quit [Ping timeout: 256 seconds]
22:19 -!- puchka [~puchka@185.203.122.131] has joined #bitcoin-core-dev
22:51 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
23:08 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection]
23:16 -!- qxs [~qxs@gateway/tor-sasl/qxs] has quit [Remote host closed the connection]
23:24 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 264 seconds]
23:46 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
23:47 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
--- Log closed Thu Jan 25 00:00:39 2024