--- Log opened Wed Mar 27 00:00:09 2024
00:23 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
00:50 < laanwj> willcl-ark: i think the .tar.gz are the unsigned binaries, the .zip is the signed one, you should probably be using the zip
00:51 < laanwj> but tbh i don't know why both are being shipped
00:53 < laanwj> running non-signed binaries is possible on macos but it needs some special step to allowlist them
00:55 < laanwj> looks like the .tar.gz contain some more eg, also the command line utilities and tests, that makes sense for whoever neesd that
00:56 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 264 seconds]
01:04 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
01:25 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has joined #bitcoin-core-dev
01:29 -!- jamesob4 [~jamesob@108.44.248.162] has joined #bitcoin-core-dev
01:30 -!- jamesob [~jamesob@108.44.248.162] has quit [Ping timeout: 252 seconds]
01:30 -!- jamesob443688173 [~jamesob@108.44.248.162] has quit [Ping timeout: 252 seconds]
01:30 -!- jamesob4 is now known as jamesob
02:02 -!- aleggg [~aleggg@177.204.243.50.dynamic.adsl.gvt.net.br] has quit [Remote host closed the connection]
02:07 -!- aleggg [~aleggg@177.204.243.50.dynamic.adsl.gvt.net.br] has joined #bitcoin-core-dev
02:23 -!- cbergqvist [~chris@84-216-185-21.customers.ownit.se] has joined #bitcoin-core-dev
02:28 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
03:10 < b10c> any reason why we check ">= MAX_BLOCK_SIGOPS" in BlockAssembler::TestPackage but "> MAX_BLOCK_SIGOPS_COST" in validation? One sigop is unused (this rarely matters, just wondering if there's an undocumented reason for this)
03:13 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
03:43 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 252 seconds]
03:55 < _aj_> b10c: it's already off by nBlockSigOpsCost=400, what's an extra off by 1?
03:58 < b10c> _aj_: I'm aware - just wondering if there's an actual reason for it
03:59 < bitcoin-git> [bitcoin] fanquake opened pull request #29747: depends: fix mingw-w64 Qt DEBUG=1 build (master...fix_qt_debug_link) https://github.com/bitcoin/bitcoin/pull/29747
04:04 < _aj_> b10c: looks like it was introduced that way in #7600
04:04 <@gribble> https://github.com/bitcoin/bitcoin/issues/7600 | Mining: Select transactions using feerate-with-ancestors by sdaftuar · Pull Request #7600 · bitcoin/bitcoin · GitHub
04:07 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d04324a7056a...b8b0d6476573
04:07 < bitcoin-git> bitcoin/master fa22a43 MarcoFalke: ci: Print tsan errors to stderr
04:07 < bitcoin-git> bitcoin/master b8b0d64 fanquake: Merge bitcoin/bitcoin#29740: ci: Print tsan errors to stderr
04:07 < bitcoin-git> [bitcoin] fanquake merged pull request #29740: ci: Print tsan errors to stderr (master...2403-ci-tsan-err-) https://github.com/bitcoin/bitcoin/pull/29740
04:09 < b10c> _aj_: with a nit that it should be > and not >=   https://github.com/bitcoin/bitcoin/pull/7600/files#r67020333
04:10 < b10c> so probably just an oversight (that rarely ever matters)
04:18 < _aj_> if the nBlock numbers aren't already wild over-estimates, there's already a problem; if they are over-estimates, an off by one making them slightly worse over estimates is no big deal *shrug*
04:39 < bitcoin-git> [bitcoin] sr-gi opened pull request #29748: test: Cleans some manual checks/drops when using wait_for_getdata (master...202403-waitforgetdata-cleanup) https://github.com/bitcoin/bitcoin/pull/29748
04:40 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b8b0d6476573...28f2ca675f89
04:40 < bitcoin-git> bitcoin/master 80fa7da Brandon Odiwuor: test: Refactor subtree exclusion in lint tests
04:40 < bitcoin-git> bitcoin/master 28f2ca6 fanquake: Merge bitcoin/bitcoin#29479: test: Refactor subtree exclusion in lint tests
04:40 < bitcoin-git> [bitcoin] fanquake merged pull request #29479: test: Refactor subtree exclusion in lint tests (master...lint-subtree-excludes) https://github.com/bitcoin/bitcoin/pull/29479
04:45 -!- asher [~ash3y@216.98.225.36] has joined #bitcoin-core-dev
04:52 < sr_gi[m]> maflcko: re #29736, I've also noticed that most of the `wait_for_*` methods that check whether a type of message is present in the collection do so like: `if not not self.last_message.get...` when the safe(r) way would be `... is not None` (given many things may evaluate to False). Is that worth fixing as well?
04:52 <@gribble> https://github.com/bitcoin/bitcoin/issues/29736 | test: Extends wait_for_getheaders so a specific block hash can be checked by sr-gi · Pull Request #29736 · bitcoin/bitcoin · GitHub
05:05 -!- asher [~ash3y@216.98.225.36] has quit [Ping timeout: 256 seconds]
05:14 < fanquake> laawnj: might just be time to bite the bullet and ship everything codesigned for macOS. Running unsigned bins is going away with x86_64
05:14 < fanquake> *laanwj
05:16 -!- the_mariner [~Thunderbi@2804:29b8:518d:a89:595d:881c:a194:1f9a] has quit [Ping timeout: 240 seconds]
05:16 < stickies-v> shipping codesigned arm64 makes sense imo, kinda awkward how the first interaction users have now is getting a message that the bins are damaged and should be trashed
05:33 < laanwj> fanquake i'm not sure of the logistic issues involved with getting it to be that way with guix, but yes i think that makes sense
05:33 < stickies-v> just opened an issue on this: https://github.com/bitcoin/bitcoin/issues/29749
05:33 < willcl-ark> Well I thought I understood the code signing debate that we had been having (in #15774), but thought it was only applying to Bitcoin-Qt.app for some reason
05:33 <@gribble> https://github.com/bitcoin/bitcoin/issues/15774 | macOS App Notarization & Stapling · Issue #15774 · bitcoin/bitcoin · GitHub
05:34 < willcl-ark> But currently macOS users can't get pre built bitcoin-cli or bitcoind without this (undocumented?) step
05:35 < laanwj> it has always been that way, though apple is as usual making things harder and harder
05:35 < fanquake> will-clark: by pre-built do you mean guix?
05:35 < fanquake> Compiing yourself always works, with no additional steps to codesign
05:36 < willcl-ark> Sure:)
05:39 -!- pablomartin [~pablomart@217.146.93.18] has joined #bitcoin-core-dev
05:41 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
05:42 < bitcoin-git> [bitcoin] sr-gi opened pull request #29750: test: makes timeout a forced named argument in tests methods that use it (master...202403-test-forced-timeout) https://github.com/bitcoin/bitcoin/pull/29750
06:02 -!- BrandonOdiwuor [~BrandonOd@41.80.113.148] has joined #bitcoin-core-dev
06:04 < luke-jr_> laanwj: the .tar.gz typically are un-app-ified bins IIRC
06:14 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 256 seconds]
06:34 -!- the_mariner [~Thunderbi@177.37.233.227] has joined #bitcoin-core-dev
06:36 < laanwj> luke-jr_: yes, it is... it makes sense, i had just forgotten why
06:52 < darosior> #proposedmeetingtopic writeups and disclosure of historical bugs reported but were never published
06:53 < darosior> (Niklas & i)
06:54 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
06:59 -!- BrandonOdiwuor [~BrandonOd@41.80.113.148] has quit [Quit: Client closed]
07:31 -!- cbergqvist [~chris@84-216-185-21.customers.ownit.se] has quit [Quit: WeeChat 4.1.1]
07:31 -!- cbergqvist [~chris@84-216-185-21.customers.ownit.se] has joined #bitcoin-core-dev
07:54 -!- bugs_ [~bugs@user/bugs/x-5128603] has joined #bitcoin-core-dev
07:54 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
08:00 < bitcoin-git> [gui-qml] hebasto pushed 3 commits to main: https://github.com/bitcoin-core/gui-qml/compare/be965bfa543d...b6bf91fccf81
08:00 < bitcoin-git> gui-qml/main a7e1b25 pablomartin4btc: qml, component: correct ProxySettings behaviour
08:00 < bitcoin-git> gui-qml/main d47bc1a pablomartin4btc: qml, control: new IPAddressValueInput
08:00 < bitcoin-git> gui-qml/main b6bf91f Hennadii Stepanov: Merge bitcoin-core/gui-qml#391: Introducing an improved IP Address and Por...
08:00 < bitcoin-git> [gui-qml] hebasto merged pull request #391: Introducing an improved IP Address and Port input control in ProxySettings component (main...qml-ipaddress-valueinput) https://github.com/bitcoin-core/gui-qml/pull/391
08:12 -!- infernix [nix@spirit.infernix.net] has joined #bitcoin-core-dev
08:12 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
08:41 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [Closing Window]
08:51 -!- puchka [~puchka@185.203.122.199] has quit [Ping timeout: 255 seconds]
08:53 -!- puchka [~puchka@185.203.122.201] has joined #bitcoin-core-dev
08:59 -!- puchka [~puchka@185.203.122.201] has quit [Ping timeout: 256 seconds]
08:59 -!- puchka [~puchka@185.203.122.201] has joined #bitcoin-core-dev
09:11 -!- freesprung5126 [~freesprun@user/freesprung] has quit [Ping timeout: 260 seconds]
09:12 -!- puchka [~puchka@185.203.122.201] has quit [Ping timeout: 268 seconds]
09:13 < bitcoin-git> [bitcoin] Cachiman opened pull request #29751: Update and rename README.md to Phiahcoin. (master...patch-1) https://github.com/bitcoin/bitcoin/pull/29751
09:13 < bitcoin-git> [bitcoin] fanquake closed pull request #29751: Update and rename README.md to Phiahcoin. (master...patch-1) https://github.com/bitcoin/bitcoin/pull/29751
09:14 -!- freesprung5126 [~freesprun@user/freesprung] has joined #bitcoin-core-dev
09:14 -!- puchka [~puchka@185.203.122.201] has joined #bitcoin-core-dev
09:33 -!- Guest24 [~Guest70@2001:4898:e008:1:62a9:c579:dfd3:c27e] has joined #bitcoin-core-dev
09:34 -!- freesprung5126 [~freesprun@user/freesprung] has quit [Ping timeout: 272 seconds]
09:36 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/28f2ca675f89...7a12cbed99ca
09:36 < bitcoin-git> bitcoin/master b7e7e72 fanquake: depends: fix mingw-w64 Qt DEBUG=1 build
09:36 < bitcoin-git> bitcoin/master 7a12cbe fanquake: Merge bitcoin/bitcoin#29747: depends: fix mingw-w64 Qt DEBUG=1 build
09:36 < bitcoin-git> [bitcoin] fanquake merged pull request #29747: depends: fix mingw-w64 Qt DEBUG=1 build (master...fix_qt_debug_link) https://github.com/bitcoin/bitcoin/pull/29747
09:44 -!- Guest24 [~Guest70@2001:4898:e008:1:62a9:c579:dfd3:c27e] has quit [Ping timeout: 250 seconds]
09:45 < bitcoin-git> [bitcoin] ryanofsky pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/7a12cbed99ca...c8e397811471
09:45 < bitcoin-git> bitcoin/master 180973a ishaanam: test: Add tests for wallet mempool conflicts
09:45 < bitcoin-git> bitcoin/master ffe5ff1 ishaanam: scripted-diff: wallet: s/TxStateConflicted/TxStateBlockConflicted
09:45 < bitcoin-git> bitcoin/master d64922b ishaanam: wallet refactor: use CWalletTx member functions to determine tx state
09:45 < bitcoin-git> [bitcoin] ryanofsky merged pull request #27307: wallet: track mempool conflicts with wallet transactions (master...track_mempool_wallet_conflicts) https://github.com/bitcoin/bitcoin/pull/27307
09:45 -!- vostrnad [~vostrnad@ip-62-245-75-70.bb.vodafone.cz] has joined #bitcoin-core-dev
09:50 -!- vostrnad [~vostrnad@ip-62-245-75-70.bb.vodafone.cz] has quit [Ping timeout: 250 seconds]
09:55 -!- vostrnad [~vostrnad@ip-62-245-75-70.bb.vodafone.cz] has joined #bitcoin-core-dev
09:59 -!- Guest70 [~Guest70@2001:4898:e008:1:4a62:f22e:3037:a757] has joined #bitcoin-core-dev
10:00 < bitcoin-git> [bitcoin] AngusP opened pull request #29752: refactor: Use typesafe Wtxid in compact block encodings (master...typesafe-txid-in-cmpctblock) https://github.com/bitcoin/bitcoin/pull/29752
10:01 -!- Guest79 [~Guest42@212.129.83.198] has joined #bitcoin-core-dev
10:04 -!- vasild_ [~vd@user/vasild] has quit [Remote host closed the connection]
10:04 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
10:14 -!- Novo [uid605808@id-605808.lymington.irccloud.com] has joined #bitcoin-core-dev
10:33 < bitcoin-git> [bitcoin] LarryRuane closed pull request #29163: bitcoin-cli help detail to show full help for all RPCs (master...2024-01-help-detailed) https://github.com/bitcoin/bitcoin/pull/29163
10:44 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
11:02 -!- zeropoint [~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
11:03 -!- Guest79 [~Guest42@212.129.83.198] has quit [Quit: Client closed]
11:07 -!- vostrnad [~vostrnad@ip-62-245-75-70.bb.vodafone.cz] has quit [Quit: Client closed]
11:15 -!- Talkless [~Talkless@mail.dargis.net] has quit [Ping timeout: 255 seconds]
11:16 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
11:18 -!- Talkless [~Talkless@mail.dargis.net] has quit [Client Quit]
11:23 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
11:31 -!- Guest70 [~Guest70@2001:4898:e008:1:4a62:f22e:3037:a757] has quit [Quit: Client closed]
11:35 -!- asher [~ash3y@216.98.225.36] has joined #bitcoin-core-dev
11:39 -!- jarthur [~jarthur@user/jarthur] has joined #bitcoin-core-dev
11:52 -!- Talkless [~Talkless@mail.dargis.net] has quit [Ping timeout: 264 seconds]
12:05 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection]
12:05 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
12:14 < bitcoin-git> [gui-qml] D33r-Gee opened pull request #392: UI Only Custom Datadir  (main...qml-custom-datadir-ui) https://github.com/bitcoin-core/gui-qml/pull/392
12:24 -!- RodAgl80 [~RodAgl80@185.153.176.211] has joined #bitcoin-core-dev
12:34 -!- RodAgl80 [~RodAgl80@185.153.176.211] has quit [Quit: Textual IRC Client: www.textualapp.com]
12:38 < bitcoin-git> [bitcoin] furszy opened pull request #29753: test: fix StopIteration exception in p2p_node_network_limited.py (master...2024_test_fix_p2p_node_network_failure) https://github.com/bitcoin/bitcoin/pull/29753
13:04 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
13:06 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 268 seconds]
13:09 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
13:10 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 256 seconds]
15:15 -!- noonien80831042 [~noonien@86.125.147.232] has quit [Quit: The Lounge - https://thelounge.chat]
15:21 -!- noonien80831042 [~noonien@86.125.147.232] has joined #bitcoin-core-dev
15:22 -!- noonien808310429 [~noonien@86.125.147.232] has joined #bitcoin-core-dev
15:26 -!- noonien80831042 [~noonien@86.125.147.232] has quit [Ping timeout: 260 seconds]
16:06 -!- bugs_ [~bugs@user/bugs/x-5128603] has quit [Quit: Leaving]
16:12 -!- the_mariner [~Thunderbi@177.37.233.227] has quit [Ping timeout: 252 seconds]
16:34 -!- abubakarsadiq [uid602234@id-602234.hampstead.irccloud.com] has quit [Quit: Connection closed for inactivity]
16:38 -!- jarthur_ [~jarthur@user/jarthur] has joined #bitcoin-core-dev
16:38 -!- jarthur [~jarthur@user/jarthur] has quit [Ping timeout: 268 seconds]
17:13 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
17:21 -!- noonien808310429 [~noonien@86.125.147.232] has quit [Ping timeout: 268 seconds]
17:31 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Remote host closed the connection]
17:40 -!- asher [~ash3y@216.98.225.36] has quit [Ping timeout: 264 seconds]
18:02 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
18:06 -!- zeropoint [~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net] has quit [Quit: leaving]
18:17 -!- asher [~ash3y@216.98.225.36] has joined #bitcoin-core-dev
18:22 -!- pablomartin [~pablomart@217.146.93.18] has quit [Remote host closed the connection]
18:22 -!- pablomartin [~pablomart@217.146.93.18] has joined #bitcoin-core-dev
18:28 -!- preimage [~halosghos@user/halosghost] has joined #bitcoin-core-dev
18:35 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 264 seconds]
19:45 -!- Guest5 [~Guest5@2806:2a0:1030:3e29:348a:1acd:4059:6fe7] has joined #bitcoin-core-dev
19:51 -!- Guest5 [~Guest5@2806:2a0:1030:3e29:348a:1acd:4059:6fe7] has quit [Quit: Client closed]
20:05 -!- jarthur_ [~jarthur@user/jarthur] has quit [Ping timeout: 256 seconds]
20:12 -!- preimage [~halosghos@user/halosghost] has quit [Quit: WeeChat 4.2.1]
20:13 -!- jarthur [~jarthur@user/jarthur] has joined #bitcoin-core-dev
20:14 -!- pablomartin [~pablomart@217.146.93.18] has quit [Remote host closed the connection]
20:14 -!- pablomartin [~pablomart@217.146.93.18] has joined #bitcoin-core-dev
20:21 -!- jarthur [~jarthur@user/jarthur] has quit [Ping timeout: 268 seconds]
20:33 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
20:36 -!- pablomartin [~pablomart@217.146.93.18] has quit [Ping timeout: 264 seconds]
20:52 -!- asher [~ash3y@216.98.225.36] has quit [Ping timeout: 268 seconds]
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:05 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 268 seconds]
21:28 -!- jarthur [~jarthur@user/jarthur] has joined #bitcoin-core-dev
22:43 -!- jarthur [~jarthur@user/jarthur] has quit [Quit: jarthur]
23:03 -!- AaronvanW [~AaronvanW@user/AaronvanW] has joined #bitcoin-core-dev
23:35 -!- AaronvanW [~AaronvanW@user/AaronvanW] has quit [Ping timeout: 256 seconds]
--- Log closed Thu Mar 28 00:00:10 2024