--- Log opened Mon Apr 15 00:00:27 2024
00:08 -!- kevkevin [~kevkevin@2601:241:8703:7b30:b03e:65ee:be10:9008] has joined #bitcoin-core-dev
00:10 -!- salvatoshi [~salvatosh@genymobile-2-6-86.fib.nerim.net] has joined #bitcoin-core-dev
00:15 -!- kevkevin [~kevkevin@2601:241:8703:7b30:b03e:65ee:be10:9008] has quit [Ping timeout: 240 seconds]
00:28 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c43b:4bf2:dec1:e193] has joined #bitcoin-core-dev
00:28 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has joined #bitcoin-core-dev
00:38 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c43b:4bf2:dec1:e193] has quit [Ping timeout: 268 seconds]
00:50 -!- Earnestly [~earnest@user/earnestly] has joined #bitcoin-core-dev
00:51 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c43b:4bf2:dec1:e193] has joined #bitcoin-core-dev
00:56 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c43b:4bf2:dec1:e193] has quit [Ping timeout: 260 seconds]
01:05 < bitcoin-git> [bitcoin] dergoegge opened pull request #29869: rpc, bugfix: Enforce maximum value for setmocktime (master...2024-04-fuzz-smt) https://github.com/bitcoin/bitcoin/pull/29869
01:07 < bitcoin-git> [bitcoin] maflcko opened pull request #29870: rpc: Reword SighashFromStr error message (master...2404-rpc-SighashFromStr-) https://github.com/bitcoin/bitcoin/pull/29870
01:11 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c43b:4bf2:dec1:e193] has joined #bitcoin-core-dev
01:16 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c43b:4bf2:dec1:e193] has quit [Ping timeout: 256 seconds]
01:29 -!- bitdex_ [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
01:29 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c43b:4bf2:dec1:e193] has joined #bitcoin-core-dev
01:31 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 260 seconds]
01:39 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c43b:4bf2:dec1:e193] has quit [Ping timeout: 268 seconds]
01:52 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c43b:4bf2:dec1:e193] has joined #bitcoin-core-dev
01:55 -!- jon_atack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
01:57 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c43b:4bf2:dec1:e193] has quit [Ping timeout: 246 seconds]
01:57 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 256 seconds]
02:00 < bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/0de63b8b46ef...d29fc3a245c0
02:00 < bitcoin-git> bitcoin/master 1eea10a fanquake: Squashed 'src/minisketch/' changes from a571ba20f9..3472e2f5ec
02:00 < bitcoin-git> bitcoin/master e58e132 fanquake: Update minisketch subtree to latest master
02:00 < bitcoin-git> bitcoin/master 4722b7c fanquake: build: remove minisketch clz check
02:00 < bitcoin-git> [bitcoin] fanquake merged pull request #29823: minisketch: update subtree to 3472e2f5ec75ace39ce9243af6b3fee233a67492 (master...pull_minisketch_tree) https://github.com/bitcoin/bitcoin/pull/29823
02:04 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d29fc3a245c0...3abee5eceb41
02:04 < bitcoin-git> bitcoin/master fadf7e9 MarcoFalke: ci: Bump s390x to ubuntu:24.04
02:04 < bitcoin-git> bitcoin/master 3abee5e merge-script: Merge bitcoin/bitcoin#29856: ci: Bump s390x to ubuntu:24.04
02:05 < bitcoin-git> [bitcoin] fanquake merged pull request #29856: ci: Bump s390x to ubuntu:24.04 (master...2404-ci-s390x-) https://github.com/bitcoin/bitcoin/pull/29856
02:06 -!- Guyver2 [~Guyver@77-174-98-73.fixed.kpn.net] has left #bitcoin-core-dev [Closing Window]
02:12 -!- kevkevin [~kevkevin@2601:241:8703:7b30:b03e:65ee:be10:9008] has joined #bitcoin-core-dev
02:12 -!- kevkevin [~kevkevin@2601:241:8703:7b30:b03e:65ee:be10:9008] has quit [Remote host closed the connection]
02:13 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c43b:4bf2:dec1:e193] has joined #bitcoin-core-dev
02:18 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c43b:4bf2:dec1:e193] has quit [Ping timeout: 268 seconds]
02:30 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c43b:4bf2:dec1:e193] has joined #bitcoin-core-dev
02:35 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c43b:4bf2:dec1:e193] has quit [Ping timeout: 256 seconds]
03:06 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c43b:4bf2:dec1:e193] has joined #bitcoin-core-dev
03:13 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c43b:4bf2:dec1:e193] has quit [Remote host closed the connection]
03:14 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c43b:4bf2:dec1:e193] has joined #bitcoin-core-dev
03:18 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c43b:4bf2:dec1:e193] has quit [Ping timeout: 240 seconds]
03:28 -!- Guest39 [~Guest39@2a01:cb11:808:3a00:9917:d2cc:a2f8:c34] has joined #bitcoin-core-dev
03:30 -!- Guest39 [~Guest39@2a01:cb11:808:3a00:9917:d2cc:a2f8:c34] has quit [Client Quit]
03:51 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c43b:4bf2:dec1:e193] has joined #bitcoin-core-dev
03:57 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c43b:4bf2:dec1:e193] has quit [Ping timeout: 268 seconds]
04:05 < bitcoin-git> [bitcoin] maflcko opened pull request #29872:  test: Add missing Assert(mock_time_in = 0s) to SetMockTime  (master...2404-mocktime-) https://github.com/bitcoin/bitcoin/pull/29872
04:11 -!- the_mariner [~Thunderbi@2804:7f7:e082:64b0:8dd4:8f05:3d3:d666] has joined #bitcoin-core-dev
04:19 < bitcoin-git> [bitcoin] glozow opened pull request #29873: policy: restrict all TRUC (v3) transactions to 25KvB (master...2024-04-truc-25k) https://github.com/bitcoin/bitcoin/pull/29873
04:26 < bitcoin-git> [bitcoin] laanwj opened pull request #29874: test: Add large aligned vmov check for mingw (master...2024-04-forbidden-vmov-check) https://github.com/bitcoin/bitcoin/pull/29874
04:28 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c43b:4bf2:dec1:e193] has joined #bitcoin-core-dev
04:34 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c43b:4bf2:dec1:e193] has quit [Ping timeout: 256 seconds]
04:36 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 260 seconds]
04:38 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
04:44 < pinheadmz> #proposedmeetingtopic libevent: replace? fork & maintain? leave it alone?
05:04 -!- kevkevin [~kevkevin@2601:241:8703:7b30:b03e:65ee:be10:9008] has joined #bitcoin-core-dev
05:06 -!- kevkevin [~kevkevin@2601:241:8703:7b30:b03e:65ee:be10:9008] has quit [Remote host closed the connection]
05:07 -!- kevkevin [~kevkevin@98.226.206.182] has joined #bitcoin-core-dev
05:10 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/3abee5eceb41...58446e1d92c7
05:10 < bitcoin-git> bitcoin/master 02395ed fanquake: init: remove redundant upnp #ifdef
05:10 < bitcoin-git> bitcoin/master 92f88a9 fanquake: doc: fixup NAT-PMP help doc
05:10 < bitcoin-git> bitcoin/master 58446e1 merge-script: Merge bitcoin/bitcoin#28874: doc: fixup help output for -upnp and -natpmp
05:10 < bitcoin-git> [bitcoin] fanquake merged pull request #28874: doc: fixup help output for -upnp and -natpmp (master...redundant_upnp_ifdef) https://github.com/bitcoin/bitcoin/pull/28874
05:12 -!- kevkevin [~kevkevin@98.226.206.182] has quit [Ping timeout: 260 seconds]
05:14 < bitcoin-git> [bitcoin] StevenMia opened pull request #29875: chore: fix some typos in comments (master...master) https://github.com/bitcoin/bitcoin/pull/29875
05:25 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c43b:4bf2:dec1:e193] has joined #bitcoin-core-dev
05:26 < bitcoin-git> [bitcoin] fanquake opened pull request #29876: build: add `-Wundef` (master...add_wundef) https://github.com/bitcoin/bitcoin/pull/29876
05:30 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c43b:4bf2:dec1:e193] has quit [Ping timeout: 255 seconds]
05:32 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:61db:d7a9:f58f:4440] has quit [Remote host closed the connection]
05:43 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c43b:4bf2:dec1:e193] has joined #bitcoin-core-dev
05:47 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c43b:4bf2:dec1:e193] has quit [Ping timeout: 246 seconds]
05:54 -!- Guest62 [~Guest62@2a09:bac3:18b6:1032::19d:11f] has joined #bitcoin-core-dev
06:01 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c43b:4bf2:dec1:e193] has joined #bitcoin-core-dev
06:04 -!- twistedline [~bitcoin@185.193.125.44] has quit []
06:05 -!- twistedline [~bitcoin@185.193.125.44] has joined #bitcoin-core-dev
06:10 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c43b:4bf2:dec1:e193] has quit [Ping timeout: 268 seconds]
06:11 < bitcoin-git> [bitcoin] 0xB10C opened pull request #29877: tracing: cast block_connected duration to µs (master...2024-04-tracing-cast-duration-to-µs) https://github.com/bitcoin/bitcoin/pull/29877
06:15 < Chris_Stewart_5> achow101: sipa I was working on BIP386 and was getting hung up on this descriptor:
06:15 < Chris_Stewart_5> tr(a34b99f22c790c4e36b2b3c2c35a36db06226e41c692fc82b8b56ac1c540c5bd,{pk(xprvA2JDeKCSNNZky6uBCviVfJSKyQ1mDYahRjijr5idH2WwLsEd4Hsb2Tyh8RfQMuPh7f7RtyzTtdrbdqqsunu5Mm3wDvUAKRHSC34sJ7in334/0),{{pk(xpub6ERApfZwUNrhLCkDtcHTcxd75RbzS1ed54G1LkBUHQVHQKqhMkhgbmJbZRkrgZw4koxb5JaHWkY4ALHY2grBGRjaDMzQLcgJvLJuZZvRcEL),pk(02df12b7035bdac8e3bab862a3a83d06ea6b17b6753d52edecba9be46f5d09e076)},pk(L4rK1yDtCWe
06:15 < Chris_Stewart_5> kvXuE6oXD9jCYfFNV2cWRpVuPLBcCU2z8TrisoyY1)}})
06:15 < Chris_Stewart_5> my understanding is xonly keys are allowed in tapscript, however this seems to be a legacy pubkey? `pk(02df12b7035bdac8e3bab862a3a83d06ea6b17b6753d52edecba9be46f5d09e076)`
06:16 < Chris_Stewart_5> From a quick search, it seems this test case isn't in descriptor_tests.cpp. If I remove the parity byte the test case does seem to pass so I assume typo?
06:20 < sipa> Chris_Stewart_5: KEY expressions in tr() allow everything normal KEY expressions allow, plus a new 64-character hex
06:20 < darosior> Chris_Stewart_5: compressed pubkeys are accepted as key expressions
06:20 < sipa> the serialization to script just drops the Y coordinate
06:22 < sipa> think of it this way: xpub > regular pubkey > xonly-key, each provides a superset of the information the next one contains, so you can go from left to right while just dropping the part that doesn't matter
06:23 < sipa> tr() scripts/keypaths happen to only need the X coordinate, but there is nothing wrong with specifying keys that contain more information
06:23 < Chris_Stewart_5> Definitely confusing, but I understand from a compatability POV I guess. I presume if someone actually committed to a 33byte pubkey the branch would be unspendable?
06:24 < sipa> Chris_Stewart_5: well you can use an xpub as a KEY expression, which also contains a Y coordinate... clearly we can't outlaw that
06:24 < bitcoin-git> [bitcoin] fanquake opened pull request #29878: depends: build expat with CMake (master...depends_expat_use_cmake) https://github.com/bitcoin/bitcoin/pull/29878
06:25 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c43b:4bf2:dec1:e193] has joined #bitcoin-core-dev
06:25 < Chris_Stewart_5> Sure... but you could outlaw 33/65 keys to avoid more footguns. I guess i don't find the argument compelling that "its possible to footgun, so lets just allow all footguns!" Any way, my question is answered thank you.
06:26 < sipa> Chris_Stewart_5: you mean in an actual taproot script? as internal key you just can't use anything but an x-only key; inside a tapscript using a 33-byte key would be treated as an unknown key type
06:26 < Chris_Stewart_5> Hmm, ok. I didn't think about it from that perspective
06:27 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/58446e1d92c7...22c86140f8fe
06:27 < Chris_Stewart_5> I guess if the leaf version was 0xc0 it would be unspeandable? 
06:27 < bitcoin-git> bitcoin/master ad21f22 fanquake: ci: use clang-16 for Valgrind
06:27 < bitcoin-git> bitcoin/master 22c8614 merge-script: Merge bitcoin/bitcoin#29848: ci: use Clang 16 for Valgrind
06:27 < bitcoin-git> [bitcoin] fanquake merged pull request #29848: ci: use Clang 16 for Valgrind (master...valgrind_clang_16_noble) https://github.com/bitcoin/bitcoin/pull/29848
06:27 < sipa> Chris_Stewart_5: no, it would be ignored (so, anyone can spend)
06:27 < Chris_Stewart_5> Also why isn't the leaf version somehow put in the tr() descriptor? I assumed that would be necessary as we roll out future leaf verisons? Or did it get left on the cutting board to just get something out there?
06:28 < sipa> Chris_Stewart_5: it's implicitly 0xc0 for now
06:28 < sipa> if new leaf versions are introduced, we'll need extensions to the descriptor language anyway
06:29 < Chris_Stewart_5> :+1: that was what i was assuming. Perhaps in the future the tr() identifier could be modified to be tr_{leaf_version} or something. My understanding of tapscript is the leaf version is a "global variable" for all tapscript branch spends?
06:29 < sipa> no, each leaf can have a different leaf version
06:29 < sipa> that's why it's called the leaf version... as opposed to the witness version which is global
06:30 < Chris_Stewart_5> ah, yes that makes sense :face_palm:. That complicates things. Any way, thanks for the extremely helpful insight/answers!
06:30 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c43b:4bf2:dec1:e193] has quit [Ping timeout: 260 seconds]
06:31 < sipa> np
06:32 < sipa> if a future leaf version is called fancyscript, i could imagine a descriptor fragment fancy() that wraps around the script, and goes into tr
06:33 < Chris_Stewart_5> 64BIT_MAXI() ;) 
06:33 < sipa> so e.g. tr(KEY,[multi_a(...),fancy(multi_a(...))]) would then specify a 2-leaf taproot script where one branch is 0xc0, and the other is a fancyscript with whatever leaf version fancyscript uses
06:33 < sipa> assuming multi_a even makes sense within fancyscript of course
06:36 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c43b:4bf2:dec1:e193] has joined #bitcoin-core-dev
06:40 -!- bitdex_ [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
06:42 -!- test_ [flooded@gateway/vpn/protonvpn/flood/x-43489060] has joined #bitcoin-core-dev
06:43 -!- test_ is now known as _flood
06:46 -!- Guest62 [~Guest62@2a09:bac3:18b6:1032::19d:11f] has quit [Quit: Client closed]
07:05 < bitcoin-git> [bitcoin] glozow pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/22c86140f8fe...df609a344e53
07:05 < bitcoin-git> bitcoin/master b4c9ace brunoerg: test: check disconnection when sending sendaddrv2 after verack
07:05 < bitcoin-git> bitcoin/master df609a3 glozow: Merge bitcoin/bitcoin#29699: test: check disconnection when sending sendad...
07:05 < bitcoin-git> [bitcoin] glozow merged pull request #29699: test: check disconnection when sending sendaddrv2 after verack (master...2024-03-test-sendaddrv2-after-verack) https://github.com/bitcoin/bitcoin/pull/29699
07:06 < bitcoin-git> [bitcoin] glozow pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/df609a344e53...07720b1cdd77
07:06 < bitcoin-git> bitcoin/master c2e0489 dergoegge: [rpc, bugfix] Enforce maximum value for setmocktime
07:06 < bitcoin-git> bitcoin/master 07720b1 glozow: Merge bitcoin/bitcoin#29869: rpc, bugfix: Enforce maximum value for setmoc...
07:06 < bitcoin-git> [bitcoin] glozow merged pull request #29869: rpc, bugfix: Enforce maximum value for setmocktime (master...2024-04-fuzz-smt) https://github.com/bitcoin/bitcoin/pull/29869
07:11 -!- PaperSword [~Thunderbi@securemail.qrsnap.io] has quit [Ping timeout: 272 seconds]
07:12 < bitcoin-git> [crc32c-subtree] laanwj closed pull request #7: build: Drop endianess workaround (bitcoin-fork...drop_endian_workaround) https://github.com/bitcoin-core/crc32c-subtree/pull/7
07:12 < bitcoin-git> [crc32c-subtree] laanwj reopened pull request #7: build: Drop endianess workaround (bitcoin-fork...drop_endian_workaround) https://github.com/bitcoin-core/crc32c-subtree/pull/7
07:13 < laanwj> crc32c-subtree and leveldb-subtree have been added to receive notifications here
07:14 < fanquake> thanks
07:31 -!- puchka [~puchka@185.203.122.232] has quit [Read error: Connection reset by peer]
07:33 -!- VonNaturAustreVe [~ne0h_@user/vonnaturaustreve] has joined #bitcoin-core-dev
07:40 -!- puchka [~puchka@185.203.122.235] has joined #bitcoin-core-dev
07:40 < bitcoin-git> [bitcoin] instagibbs opened pull request #29879: fuzz: explicitly cap the vsize of RBFs for diagram checks (master...2024-04-package-rbf-overflow) https://github.com/bitcoin/bitcoin/pull/29879
07:40 < instagibbs> #29879 cc sipa dergoegge sdaftuar 
07:41 <@gribble> https://github.com/bitcoin/bitcoin/issues/29879 | fuzz: explicitly cap the vsize of RBFs for diagram checks by instagibbs · Pull Request #29879 · bitcoin/bitcoin · GitHub
07:42 -!- brunoerg [~brunoerg@2001:12d0:2080:2800:172:26:f5cb:8d3b] has joined #bitcoin-core-dev
07:52 -!- achow101 [~achow101@user/achow101] has quit [Ping timeout: 256 seconds]
08:02 -!- the_mariner [~Thunderbi@2804:7f7:e082:64b0:8dd4:8f05:3d3:d666] has quit [Ping timeout: 260 seconds]
08:03 < bitcoin-git> [qa-assets] sipa opened pull request #181: Add sipa's fuzz seeds April 2024 (main...sipa) https://github.com/bitcoin-core/qa-assets/pull/181
08:04 -!- brunoerg [~brunoerg@2001:12d0:2080:2800:172:26:f5cb:8d3b] has quit [Remote host closed the connection]
08:15 -!- AaronvanW [~AaronvanW@71pc74.sshunet.nl] has quit [Quit: Leaving...]
08:16 -!- AaronvanW [~AaronvanW@71pc74.sshunet.nl] has joined #bitcoin-core-dev
08:21 -!- brunoerg [~brunoerg@www.labes.icmc.usp.br] has joined #bitcoin-core-dev
08:30 -!- bugs_ [~bugs@user/bugs/x-5128603] has joined #bitcoin-core-dev
08:32 < Chris_Stewart_5> sipa: I do suspect that this test vector is still wrong, but I don't see an easy way to implement it in bitcoin core. The reason I suspect its wrong is because if I omit the parity byte i get the "correct" script (according to BIP386). If I add the parity byte I get something else ('5120756a5aace335408f938e4e032d56e3bbdfb9833520e3041a3518c89b3f21949b'). 
08:32 < Chris_Stewart_5> Since the test descriptor mixes private/public keys, i don't believe it can easily be dropped into descriptor_tests.cpp -- IIUC the test framework required ONLY private keys or ONLY public keys in the descriptor? https://github.com/bitcoin/bitcoin/blob/07720b1cdd77399f32124641dbe1dd267eb0cf8b/src/test/descriptor_tests.cpp#L129
08:35 -!- achow101 [~achow101@user/achow101] has joined #bitcoin-core-dev
08:38 -!- brunoerg_ [~brunoerg@2001:12d0:2080:6300:10:62:8:cd3b] has joined #bitcoin-core-dev
08:38 -!- brunoerg [~brunoerg@www.labes.icmc.usp.br] has quit [Read error: Connection reset by peer]
08:41 < sipa> Chris_Stewart_5: i'm confused; the 02 or 03 in the descriptor shouldn't affect the produced scripts
08:41 < sipa> are you saying that's not what is implemented?
08:41 -!- achow101 [~achow101@user/achow101] has quit [Remote host closed the connection]
08:42 -!- achow101 [~achow101@user/achow101] has joined #bitcoin-core-dev
08:43 < Chris_Stewart_5> Hmm, perhaps i'm confused. My understanding is the merkle root should commit to the 33 byte public key. That merkle root computation affects the serialized script in the test vector. 
08:43 -!- achow101 [~achow101@user/achow101] has quit [Remote host closed the connection]
08:43 -!- brunoerg_ [~brunoerg@2001:12d0:2080:6300:10:62:8:cd3b] has quit [Ping timeout: 240 seconds]
08:43 < darosior> Chris_Stewart_5: re your question about the test framework: no it does not require all-private strings for the private descriptor.
08:43 < sipa> in a tapscript public keys are _always_ serialized as x-only
08:43 -!- achow101 [~achow101@user/achow101] has joined #bitcoin-core-dev
08:43 < sipa> regardless of how they are described in the descriptor
08:43 -!- brunoerg [~brunoerg@www.labes.icmc.usp.br] has joined #bitcoin-core-dev
08:44 < Chris_Stewart_5> darosior: Thank you I didn't realize that. 
08:44 < darosior> Chris_Stewart_5: for instance https://github.com/bitcoin/bitcoin/blob/07720b1cdd77399f32124641dbe1dd267eb0cf8b/src/test/descriptor_tests.cpp#L639-L640
08:44 < sipa> 33-byte pubkeys do not exist in tapscript
08:45 < sipa> (nor do 65-byte pubkeys)
08:45 < instagibbs> they're unknown pubkey versions, specifically?
08:46 < sipa> instagibbs: yeah
08:46 < Chris_Stewart_5> sipa: Then I think I misunderstood you wrt to 'SCRIPT_ERR_DISCOURAGE_UPGRADABLE_PUBKEYTYPE'. My understanding was that you _do_ allow non xonly public keys in tapscript to take advantage of this upgrade capability
08:46 < sipa> Chris_Stewart_5: they're allowed, but meaningless... they're anyonecanspend
08:47 < instagibbs> descriptors aren't trying to support anyonecanspend type commitments, I suspect
08:47 < Chris_Stewart_5> so now it seems i've argued in a circle and were back to xonly keys! :P
08:47 < bitcoin-git> [leveldb-subtree] fanquake opened pull request #40: cherry-pick: Remove leveldb::port::kLittleEndian. (bitcoin-fork...cherry_pick_endian) https://github.com/bitcoin-core/leveldb-subtree/pull/40
08:48 < sipa> descriptors only support well-defined features
08:48 -!- brunoerg_ [~brunoerg@2001:12d0:2080:2800:172:26:f5cb:8d3b] has joined #bitcoin-core-dev
08:48 < sipa> they describe intent
08:48 < sipa> "pk(...)" means "check a signature with this public key!", not "emit this public key in the script"
08:50 < sipa> you can use the 66-hex format for public keys, or the xpub format in descriptors... it still means checking with the corresponding public key; in tapscript that means emitting a check with the corresponding xonly key, in p2wsh that means emitted a check with the corresponding compressed pubkey
08:51 -!- brunoerg [~brunoerg@www.labes.icmc.usp.br] has quit [Ping timeout: 256 seconds]
08:56 -!- salvatoshi [~salvatosh@genymobile-2-6-86.fib.nerim.net] has quit [Ping timeout: 264 seconds]
09:02 -!- zeropoint [~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
09:04 -!- salvatoshi [~salvatosh@lfbn-idf1-1-584-25.w86-242.abo.wanadoo.fr] has joined #bitcoin-core-dev
09:05 < sipa> i guess this can be clearer in BIP386, it's a bit ambiguous in "Modified Key Expression" section which phrasings are about the descriptor notation, and which about the emitted keys in scripts
09:06 -!- zeropoint [~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net] has quit [Client Quit]
09:06 < sipa> but in short, there is an *additional* allowed KEY expression inside tr(), the 64-char hex notation; all previously existing KEY expressions remain support (xpubs, xprvs, derivation paths, origins, WIF, hex 66-char pubkeys, ...)
09:06 -!- zeropoint [~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
09:07 < sipa> but _all_ of them are in the emitted script expanded to the corresponding 32-byte xonly key, because that's the only thing that has meaning as of BIP342
09:07 < Chris_Stewart_5> I agree it coudld be clarified
09:07 < sipa> in theory, it is legal to have 33-byte public keys in BIP342, but that's just a future extension mechanism, it has no semantics associated with it
09:08 < sipa> so it'd be a huge footgun to have descriptor expressions be mapped to that, as it's effectively an anyonecanspend
09:12 -!- brunoerg_ [~brunoerg@2001:12d0:2080:2800:172:26:f5cb:8d3b] has quit [Remote host closed the connection]
09:24 < bitcoin-git> [bitcoin] fanquake opened pull request #29880: depends: build FreeType with CMake (master...depends_freetype_use_cmake) https://github.com/bitcoin/bitcoin/pull/29880
09:24 -!- brunoerg_ [~brunoerg@2001:12d0:2080:2800:172:26:f5cb:8d3b] has joined #bitcoin-core-dev
09:25 -!- the_mariner [~Thunderbi@2804:29b8:518d:a89:4c2c:e35d:f8bc:4ad3] has joined #bitcoin-core-dev
09:28 < bitcoin-git> [bitcoin] fanquake pushed 8 commits to 27.x: https://github.com/bitcoin/bitcoin/compare/b3cd95249546...d82283950f5f
09:28 < bitcoin-git> bitcoin/27.x c4da61b laanwj: doc: Suggest installing dev packages for debian/ubuntu qt5 build
09:28 < bitcoin-git> bitcoin/27.x 753c68d laanwj: ci: Pull in qtbase5-dev instead of seperate low-level libraries
09:28 < bitcoin-git> bitcoin/27.x bde54b7 MarcoFalke: ci: Print tsan errors to stderr
09:28 < bitcoin-git> [bitcoin] fanquake merged pull request #29780: [27.x] More backports and finalize (27.x...finalize_or_rc2_27) https://github.com/bitcoin/bitcoin/pull/29780
09:29 -!- brunoerg_ [~brunoerg@2001:12d0:2080:2800:172:26:f5cb:8d3b] has quit [Ping timeout: 256 seconds]
09:30 < bitcoin-git> [bitcoin] fanquake pushed tag v27.0: https://github.com/bitcoin/bitcoin/compare/v27.0
09:57 < bitcoin-git> [bitcoin] fanquake opened pull request #29881: guix: use GCC 13 to builds releases (master...gcc_13_v2) https://github.com/bitcoin/bitcoin/pull/29881
10:02 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c43b:4bf2:dec1:e193] has quit [Remote host closed the connection]
10:05 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c43b:4bf2:dec1:e193] has joined #bitcoin-core-dev
10:11 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c43b:4bf2:dec1:e193] has quit [Ping timeout: 260 seconds]
10:11 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
10:13 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c43b:4bf2:dec1:e193] has joined #bitcoin-core-dev
10:23 -!- _flood [flooded@gateway/vpn/protonvpn/flood/x-43489060] has quit [Remote host closed the connection]
10:24 -!- _flood [flooded@gateway/vpn/protonvpn/flood/x-43489060] has joined #bitcoin-core-dev
10:25 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection]
10:26 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
10:35 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c43b:4bf2:dec1:e193] has quit [Remote host closed the connection]
10:36 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c43b:4bf2:dec1:e193] has joined #bitcoin-core-dev
10:55 -!- noonien808310429 [~noonien@86.125.147.232] has joined #bitcoin-core-dev
10:57 -!- salvatoshi [~salvatosh@lfbn-idf1-1-584-25.w86-242.abo.wanadoo.fr] has quit [Ping timeout: 246 seconds]
11:14 -!- willcl-ark [~willcl-ar@user/willcl-ark] has quit [Quit: left]
11:20 -!- willcl-ark [~willcl-ar@cpc123780-trow7-2-0-cust177.18-1.cable.virginm.net] has joined #bitcoin-core-dev
11:20 -!- willcl-ark [~willcl-ar@user/willcl-ark] has changed host
11:21 -!- pablomartin4btc [~pablomart@2.58.73.95] has joined #bitcoin-core-dev
11:22 < bitcoin-git> [bitcoin] pinheadmz opened pull request #29882: netbase: clean up Proxy logging (master...cleaner-proxy-logs) https://github.com/bitcoin/bitcoin/pull/29882
11:38 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c43b:4bf2:dec1:e193] has quit [Remote host closed the connection]
11:38 -!- kevkevin [~kevkevin@2601:241:8703:7b30:b03e:65ee:be10:9008] has joined #bitcoin-core-dev
11:41 -!- brunoerg [~brunoerg@2001:12d0:2080:2800:172:26:85cb:8d3b] has joined #bitcoin-core-dev
11:43 -!- kevkevin [~kevkevin@2601:241:8703:7b30:b03e:65ee:be10:9008] has quit [Ping timeout: 255 seconds]
11:49 < sipa> fanquake: w00t v27.0
12:10 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c43b:4bf2:dec1:e193] has joined #bitcoin-core-dev
12:11 < Sjors[m]> Mmm, build Guix fast, or continue pre-mining testnet4... :-)
12:13 < Sjors[m]> (I need the difficulty to go up to figure out if S9 firmware can't handle super low difficulty or there's another bug)
12:13 < fanquake> sipa: 🎉
12:17 -!- brunoerg [~brunoerg@2001:12d0:2080:2800:172:26:85cb:8d3b] has quit [Remote host closed the connection]
12:25 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
12:26 -!- brunoerg [~brunoerg@2001:12d0:2080:6300:10:62:8:cd3b] has joined #bitcoin-core-dev
13:10 -!- Lockesmith [~user@gateway/tor-sasl/lockesmith] has quit [Remote host closed the connection]
13:10 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection]
13:10 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
13:10 -!- Lockesmith [~user@gateway/tor-sasl/lockesmith] has joined #bitcoin-core-dev
13:15 < darosior> Can we do rocket emojis
13:17 < sipa> I'll allow it. 🚀
13:32 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c43b:4bf2:dec1:e193] has quit [Remote host closed the connection]
13:33 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c43b:4bf2:dec1:e193] has joined #bitcoin-core-dev
13:35 < laanwj> 🚀
13:37 -!- kevkevin [~kevkevin@2601:241:8703:7b30:c43b:4bf2:dec1:e193] has quit [Ping timeout: 240 seconds]
14:02 -!- lap [~lap@p200300c057275e007ce3ef24b9a2106d.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
14:04 < darosior> 🚀
14:06 < dodo> 🚀🚀🚀
14:14 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:79e7:367a:196e:1d6c] has joined #bitcoin-core-dev
14:18 -!- Guest53 [~Guest53@105.120.130.70] has joined #bitcoin-core-dev
14:18 -!- Guest53 [~Guest53@105.120.130.70] has quit [Client Quit]
14:19 -!- kevkevin [~kevkevin@2600:1700:b30:47c0:79e7:367a:196e:1d6c] has quit [Ping timeout: 268 seconds]
14:21 -!- brunoerg [~brunoerg@2001:12d0:2080:6300:10:62:8:cd3b] has quit [Remote host closed the connection]
14:21 -!- brunoerg [~brunoerg@2001:12d0:2080:6300:10:62:8:cd3b] has joined #bitcoin-core-dev
14:22 -!- bugs_ [~bugs@user/bugs/x-5128603] has quit [Quit: Leaving]
14:33 -!- brunoerg [~brunoerg@2001:12d0:2080:6300:10:62:8:cd3b] has quit [Remote host closed the connection]
14:34 -!- brunoerg [~brunoerg@2001:12d0:2080:6300:10:62:8:cd3b] has joined #bitcoin-core-dev
14:38 -!- brunoerg [~brunoerg@2001:12d0:2080:6300:10:62:8:cd3b] has quit [Ping timeout: 260 seconds]
14:42 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection]
14:43 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
14:51 -!- kevkevin [~kevkevin@2607:fb90:9bc2:aba3:3958:161f:d76b:d768] has joined #bitcoin-core-dev
15:05 -!- AaronvanW [~AaronvanW@71pc74.sshunet.nl] has quit [Quit: Leaving...]
15:39 < bitcoin-git> [bitcoin-detached-sigs] achow101 pushed 1 commit to 27.x: https://github.com/bitcoin-core/bitcoin-detached-sigs/compare/6bd151b6cf37...9d9a82642255
15:39 < bitcoin-git> bitcoin-detached-sigs/27.x 9d9a826 Ava Chow: 27.0: win sig for final
15:41 -!- kevkevin [~kevkevin@2607:fb90:9bc2:aba3:3958:161f:d76b:d768] has quit [Remote host closed the connection]
15:41 -!- kevkevin [~kevkevin@2607:fb90:9bc2:aba3:3958:161f:d76b:d768] has joined #bitcoin-core-dev
15:46 -!- kevkevin [~kevkevin@2607:fb90:9bc2:aba3:3958:161f:d76b:d768] has quit [Ping timeout: 240 seconds]
16:11 -!- Earnestly [~earnest@user/earnestly] has quit [Ping timeout: 256 seconds]
16:15 -!- kevkevin [~kevkevin@2607:fb90:9bc2:aba3:3958:161f:d76b:d768] has joined #bitcoin-core-dev
16:20 -!- kevkevin [~kevkevin@2607:fb90:9bc2:aba3:3958:161f:d76b:d768] has quit [Ping timeout: 260 seconds]
16:24 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:5d1f:b29b:3f10:61c] has joined #bitcoin-core-dev
16:25 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:5d1f:b29b:3f10:61c] has quit [Remote host closed the connection]
16:26 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:5d1f:b29b:3f10:61c] has joined #bitcoin-core-dev
16:35 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:5d1f:b29b:3f10:61c] has quit [Ping timeout: 268 seconds]
17:03 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
17:09 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 255 seconds]
17:23 -!- lap [~lap@p200300c057275e007ce3ef24b9a2106d.dip0.t-ipconnect.de] has quit [Quit: WeeChat 4.1.2]
17:39 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:5d1f:b29b:3f10:61c] has joined #bitcoin-core-dev
17:41 -!- zeropoint [~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net] has quit [Quit: leaving]
17:45 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:5d1f:b29b:3f10:61c] has quit [Ping timeout: 268 seconds]
17:58 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:5d1f:b29b:3f10:61c] has joined #bitcoin-core-dev
18:10 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:5d1f:b29b:3f10:61c] has quit [Ping timeout: 255 seconds]
18:26 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:5d1f:b29b:3f10:61c] has joined #bitcoin-core-dev
18:55 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:5d1f:b29b:3f10:61c] has quit [Ping timeout: 240 seconds]
19:00 -!- upekkha [~Advanced@2a01:4f8:1c0c:49df::1] has quit []
19:00 -!- upekkha [~Advanced@2a01:4f8:1c0c:49df::1] has joined #bitcoin-core-dev
19:02 -!- the_mariner [~Thunderbi@2804:29b8:518d:a89:4c2c:e35d:f8bc:4ad3] has quit [Ping timeout: 240 seconds]
19:08 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:5d1f:b29b:3f10:61c] has joined #bitcoin-core-dev
19:08 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
19:13 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:5d1f:b29b:3f10:61c] has quit [Ping timeout: 256 seconds]
19:23 -!- lbia [~lbia@user/lbia] has quit [Quit: lbia]
19:41 -!- asher [~ash3y@216.98.225.36] has joined #bitcoin-core-dev
19:44 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:5d1f:b29b:3f10:61c] has joined #bitcoin-core-dev
19:49 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:5d1f:b29b:3f10:61c] has quit [Ping timeout: 272 seconds]
20:16 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:5d1f:b29b:3f10:61c] has joined #bitcoin-core-dev
20:23 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:5d1f:b29b:3f10:61c] has quit [Ping timeout: 255 seconds]
20:26 -!- SpellChecker [~SpellChec@user/SpellChecker] has quit [Remote host closed the connection]
20:26 -!- SpellChecker [~SpellChec@user/SpellChecker] has joined #bitcoin-core-dev
20:37 -!- the_mariner [~Thunderbi@2804:29b8:518d:a89:4c2c:e35d:f8bc:4ad3] has joined #bitcoin-core-dev
20:42 -!- the_mariner [~Thunderbi@2804:29b8:518d:a89:4c2c:e35d:f8bc:4ad3] has quit [Ping timeout: 246 seconds]
20:47 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:5d1f:b29b:3f10:61c] has joined #bitcoin-core-dev
20:48 -!- asher [~ash3y@216.98.225.36] has quit [Quit: Leaving]
20:49 -!- ashyr [~ash3y@216.98.225.36] has joined #bitcoin-core-dev
20:52 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:5d1f:b29b:3f10:61c] has quit [Ping timeout: 246 seconds]
20:52 -!- ashyr [~ash3y@user/ashyr] has changed host
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:06 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
21:15 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 268 seconds]
21:28 -!- brunoerg [~brunoerg@187.183.43.117] has joined #bitcoin-core-dev
21:33 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Ping timeout: 256 seconds]
22:08 < bitcoin-git> [bitcoin] OkSang88 opened pull request #29885: BTC world (master...codespace-glorious-space-fishstick-v6p7xvp574x436gpj) https://github.com/bitcoin/bitcoin/pull/29885
22:09 < bitcoin-git> [bitcoin] OkSang88 closed pull request #29885: BTC world (master...codespace-glorious-space-fishstick-v6p7xvp574x436gpj) https://github.com/bitcoin/bitcoin/pull/29885
22:10 < bitcoin-git> [bitcoin] OkSang88 reopened pull request #29885: BTC world (master...codespace-glorious-space-fishstick-v6p7xvp574x436gpj) https://github.com/bitcoin/bitcoin/pull/29885
22:19 < bitcoin-git> [bitcoin] laanwj closed pull request #29885: BTC team (master...codespace-glorious-space-fishstick-v6p7xvp574x436gpj) https://github.com/bitcoin/bitcoin/pull/29885
22:21 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:5d1f:b29b:3f10:61c] has joined #bitcoin-core-dev
22:26 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:5d1f:b29b:3f10:61c] has quit [Ping timeout: 255 seconds]
22:28 -!- AaronvanW [~AaronvanW@71pc74.sshunet.nl] has joined #bitcoin-core-dev
22:45 -!- ashyr [~ash3y@user/ashyr] has quit [Quit: Leaving]
22:46 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:5d1f:b29b:3f10:61c] has joined #bitcoin-core-dev
22:51 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:5d1f:b29b:3f10:61c] has quit [Ping timeout: 268 seconds]
22:55 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:5d1f:b29b:3f10:61c] has joined #bitcoin-core-dev
23:00 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:5d1f:b29b:3f10:61c] has quit [Ping timeout: 240 seconds]
23:10 -!- TallTim_ [~talltim@165-23-61-81-dynamic.midco.net] has joined #bitcoin-core-dev
23:12 -!- TallTim [~talltim@165.23.61.81] has quit [Ping timeout: 256 seconds]
23:47 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:5d1f:b29b:3f10:61c] has joined #bitcoin-core-dev
23:52 -!- brunoerg [~brunoerg@2804:14c:3bfb:37:5d1f:b29b:3f10:61c] has quit [Ping timeout: 255 seconds]
--- Log closed Tue Apr 16 00:00:28 2024