--- Day changed Mon Jul 30 2018 00:46 -!- froyer_ [~froyer@124.19.31.4] has quit [Remote host closed the connection] 00:49 -!- tiagotrs [~user@i577A6213.versanet.de] has joined #c-lightning 00:49 -!- tiagotrs [~user@i577A6213.versanet.de] has quit [Changing host] 00:49 -!- tiagotrs [~user@unaffiliated/tiagotrs] has joined #c-lightning 01:04 -!- bitonic-cjp [~bitonic-c@92-111-70-106.static.v4.ziggozakelijk.nl] has joined #c-lightning 01:18 -!- tiagotrs [~user@unaffiliated/tiagotrs] has quit [Ping timeout: 244 seconds] 02:14 -!- tiagotrs [~user@i577A6213.versanet.de] has joined #c-lightning 02:14 -!- tiagotrs [~user@i577A6213.versanet.de] has quit [Changing host] 02:14 -!- tiagotrs [~user@unaffiliated/tiagotrs] has joined #c-lightning 02:31 -githubby:#c-lightning- [lightning] cdecker pushed 7 new commits to master: https://git.io/fN2PM 02:31 -githubby:#c-lightning- lightning/master d752a00 Rusty Russell: gossip_msg: make sure alias is NUL-terminated.... 02:31 -githubby:#c-lightning- lightning/master eae9b81 Rusty Russell: json: json_add_hex_talarr for common case of dumping a tal object in hex.... 02:31 -githubby:#c-lightning- lightning/master 5cf34d6 Rusty Russell: Remove tal_len, use tal_count() or tal_bytelen().... 02:46 -githubby:#c-lightning- [lightning] cdecker pushed 1 new commit to master: https://git.io/fN210 02:46 -githubby:#c-lightning- lightning/master 5230302 Rusty Russell: fundchannel: cap 'all' at 2^24-1 satoshi.... 02:57 -githubby:#c-lightning- [lightning] cdecker opened pull request #1775: onion: Make sure we understand the channel_update in the onionreply (master...issue-1730) https://git.io/fN2ML 03:07 -!- tiagotrs [~user@unaffiliated/tiagotrs] has quit [Ping timeout: 240 seconds] 03:40 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning 03:45 -!- renepick [577bc40d@gateway/web/freenode/ip.87.123.196.13] has joined #c-lightning 03:49 < rusty> cdecker: morning! Liked your PR which parses the error either way. We still need another that switches to truncated style, though. Distasteful as it is, we'll fix it when we get our enhanced error format (whenever that is...) 03:53 <@cdecker> Yep, working on that right now 03:53 <@cdecker> i.e., running with valgrind on my box and will push once that passes 03:54 <@cdecker> btw, trying not to show my frustration with that decision too much ;-D 03:54 <@cdecker> Couldn't resist venting in the comments :-) 03:55 < rusty> cdecker: I understand how you feel! But compromise is sometimes The Right Thing, even when it's the Wrong Thing. 03:56 <@cdecker> Righto, just making fun of the decision :-) 03:57 <@cdecker> I'll tune it down a notch ^^ 03:59 <@cdecker> btw, you're called purple on the c-lightning-slack-bridge, I guess you're using pidgin? :-p 04:01 < bitonic-cjp> Another merge conflict appeared for my pull request? 04:01 < rusty> Yeah :) Legacy from when I had to be on IBM's internal non-IRC chat network... 04:02 < bitonic-cjp> I feel like waiting for a traffic light that's red forever. :-( 04:02 <@cdecker> Oh yeah, bitonic-cjp I'll take a look at it again today and merge if all's good 04:02 <@cdecker> We've been keeping it hanging for way too long already 04:03 < bitonic-cjp> The reason I didn't do a rebase is I didn't want to invalidate your review by replacing the commits with a whole new set of commits. 04:04 <@cdecker> rusty: Pidgin is a great tool, I've been using it forever (then I decided to cut down on distractions, didn't work so well though, with reddit and youtube xD) 04:04 <@cdecker> Yeah, that's a bit of an annoyance with the rebase model 04:05 <@cdecker> The conflict is tiny though (and I broke it, sorry) 04:05 < bitonic-cjp> I am aware of the importance of security in this software, and therefore the importance of good reviews. 04:07 < bitonic-cjp> *afk* going for lunch 04:12 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #c-lightning 04:15 -!- froyer [~froyer@126.121.233.220.static.exetel.com.au] has joined #c-lightning 04:20 -!- froyer [~froyer@126.121.233.220.static.exetel.com.au] has quit [Ping timeout: 256 seconds] 04:28 < rusty> cdecker: So I'm optimisticly thinking 0.6.1 rc1 next week? I really want to get the final subdaemon shuffle done first. Changing openingd to look after idle peers has turned out to remove quite a bit of code, so I'd like that in. 04:49 < bitonic-cjp> *I'm back* 04:52 < renepick> the link at the top always shows 404 (https://botbot.me/freenode/c-lightning ) 04:56 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds] 04:57 < rusty> renepick: I know :( I keep bugging them to add logging for #c-lightning. I can try again... 04:58 < renepick> @rusty: I am just reading your patch about the tests 04:59 < renepick> what thuoghts you wanna hear? at a first glimse I think I see what you did there. I am still new to your code base so I can't out of the box say weather you oversaw something or even provide feedback on a metalevel 04:59 < renepick> so how did you mean that question? 05:03 < rusty> renepick: I wondered if I'd missed anything. I like having the compile simply fail if something unexpected is changed. I also like having runtime tests that we're not putting invalid things in the database. 05:04 < rusty> renepick: I think putting it in the header makes it hard to miss that these really, really shouldn't be changed on a whim. 05:05 < renepick> so if you ask me to verify this I will need a little more time to read that piece of code. as meintioned it is that I just started with c -lightning code and my c is kind of rusty (sorry for the word play, I don't know a better english word) 05:05 < rusty> renepick: that's fine! it's also a style question. Are there other things we could test, which are similar, which you've seen? Or do you prefer the testcase approach to this one? 05:06 -!- ebx [~ebx@unaffiliated/ebex] has joined #c-lightning 05:07 < renepick> so the thing is so far I have mainly read through the code to get a feeling of the data flow in general. It was just that comment that made me look at the test case. so therefor I can't give you an insightful answer yet 05:07 < renepick> what I though I might do in future is to add a few test cases when I have the feeling they are missing and in this way become more and more familiar with the code base 05:08 < renepick> in general I rather prefer unit tests because in my feeling it fixes the API in particular if something is as criticle as those DB entries felt 05:12 < renepick> another question regarding this issue https://github.com/ElementsProject/lightning/issues/1738 I saw your patch registering the outputs to the wallet if we see the spent of the other commitment tx. however I updated c-lightning and the funds still do not appear in ./lighting-cli listfunds (which I am not surprised by, since it has happened in the past) do you have an idea how I can claim that output? 05:15 < renepick> As far as my understanding currently goes (but it is more guessing) I should be able to find some entry of that commitment point in my state database and being able to know which derrivation of hsm_secrete would be used as a recovery point 05:24 < rusty> cdecker: feedback on your patch, sorry 05:26 < rusty> renepick: I was thinking about that, actually. Ideally we can figure out the per-commitment point and add it to the db manually, so it knows how to spend that output. cdecker is the logical one to follow up, as he wrote that code :) (The value we need might even be in that verbose eclair dump?) 05:34 -!- tiagotrs [~user@i577A6213.versanet.de] has joined #c-lightning 05:34 -!- tiagotrs [~user@i577A6213.versanet.de] has quit [Changing host] 05:34 -!- tiagotrs [~user@unaffiliated/tiagotrs] has joined #c-lightning 05:42 < rusty> cdecker: make sure you update CHANGELOG :) I'm going to do a PR after these merges to sync it to them, too. 05:54 -!- dougsland [~douglas@c-73-234-93-65.hsd1.nh.comcast.net] has joined #c-lightning 05:55 -!- shesek [~shesek@bzq-84-110-232-73.cablep.bezeqint.net] has joined #c-lightning 05:55 -!- shesek [~shesek@bzq-84-110-232-73.cablep.bezeqint.net] has quit [Changing host] 05:55 -!- shesek [~shesek@unaffiliated/shesek] has joined #c-lightning 06:25 -!- tiagotrs [~user@unaffiliated/tiagotrs] has quit [Remote host closed the connection] 06:34 -!- qubenix [~qubenix@23.226.131.131] has quit [Remote host closed the connection] 06:50 -!- froyer [~froyer@126.121.233.220.static.exetel.com.au] has joined #c-lightning 06:55 -!- froyer [~froyer@126.121.233.220.static.exetel.com.au] has quit [Ping timeout: 264 seconds] 06:56 -!- grubles [~grubles@unaffiliated/grubles] has quit [Quit: Leaving] 06:58 -!- deusexbeer [~deusexbee@093-092-181-146-dynamic-pool-adsl.wbt.ru] has quit [Ping timeout: 268 seconds] 07:00 -!- deusexbeer [~deusexbee@093-092-181-146-dynamic-pool-adsl.wbt.ru] has joined #c-lightning 07:17 -!- grubles [~grubles@unaffiliated/grubles] has joined #c-lightning 07:23 -!- tiagotrs [~user@i577A6213.versanet.de] has joined #c-lightning 07:23 -!- tiagotrs [~user@i577A6213.versanet.de] has quit [Changing host] 07:23 -!- tiagotrs [~user@unaffiliated/tiagotrs] has joined #c-lightning 07:32 -!- harding [quassel@2600:3c03::f03c:91ff:fe7b:78d1] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.] 07:33 -!- harding [quassel@2600:3c03::f03c:91ff:fe7b:78d1] has joined #c-lightning 07:45 -!- grafcaps [~haroldbr@050-090-083-229.res.spectrum.com] has joined #c-lightning 07:49 -!- qubenix [~qubenix@107.152.99.41] has joined #c-lightning 07:50 -!- deusexbeer [~deusexbee@093-092-181-146-dynamic-pool-adsl.wbt.ru] has quit [Ping timeout: 268 seconds] 07:50 -!- grafcaps [~haroldbr@050-090-083-229.res.spectrum.com] has quit [Ping timeout: 260 seconds] 07:53 -!- deusexbeer [~deusexbee@093-092-177-009-dynamic-pool-adsl.wbt.ru] has joined #c-lightning 08:01 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 08:02 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #c-lightning 08:19 -!- grafcaps [~haroldbr@104.137.194.255] has joined #c-lightning 08:29 -!- booyah [~bb@193.25.1.157] has quit [Read error: Connection reset by peer] 08:29 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 08:30 -!- booyah [~bb@193.25.1.157] has joined #c-lightning 08:30 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #c-lightning 08:57 -!- tiagotrs [~user@unaffiliated/tiagotrs] has quit [Ping timeout: 244 seconds] 09:01 -!- booyah [~bb@193.25.1.157] has quit [Ping timeout: 260 seconds] 09:05 -!- bitonic-cjp [~bitonic-c@92-111-70-106.static.v4.ziggozakelijk.nl] has quit [Quit: Leaving] 09:06 -!- booyah [~bb@193.25.1.157] has joined #c-lightning 09:30 -!- contrapumpkin [~copumpkin@haskell/developer/copumpkin] has joined #c-lightning 09:31 -!- booyah [~bb@193.25.1.157] has quit [Ping timeout: 260 seconds] 09:32 -!- copumpkin [~copumpkin@haskell/developer/copumpkin] has quit [Ping timeout: 240 seconds] 09:54 -!- booyah [~bb@193.25.1.157] has joined #c-lightning 10:07 -!- annonch [d82f98f2@gateway/web/freenode/ip.216.47.152.242] has joined #c-lightning 10:10 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 260 seconds] 10:29 -!- qubenix [~qubenix@107.152.99.41] has quit [Remote host closed the connection] 10:48 -!- shesek [~shesek@bzq-84-110-54-72.cablep.bezeqint.net] has joined #c-lightning 10:48 -!- shesek [~shesek@bzq-84-110-54-72.cablep.bezeqint.net] has quit [Changing host] 10:48 -!- shesek [~shesek@unaffiliated/shesek] has joined #c-lightning 11:24 -!- rabidus [~rabidus@85-23-137-40.bb.dnainternet.fi] has quit [Ping timeout: 244 seconds] 11:26 -!- rabidus [~rabidus@85-23-137-40.bb.dnainternet.fi] has joined #c-lightning 11:37 -!- buZz [~buzz@dragonbox/pyrate/buZz] has quit [Quit: Reconnecting] 11:37 -!- buZz [~buzz@dragonbox/pyrate/buZz] has joined #c-lightning 12:19 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #c-lightning 12:19 < Chris_Stewart_5> what is the minimum information needed in bitcoin.conf? `rpcuser` and `rpcpassword`? 12:30 < grubles> yeah i believe so 12:31 < grubles> not sure you even need those actually 12:31 < Chris_Stewart_5> One of my guys tried it without and it complained :S. Going to be safe and just tell users to specify them 12:31 < Chris_Stewart_5> grubles: Thanks! 12:35 < grubles> np! 12:48 -!- tiagotrs [~user@i577A6827.versanet.de] has joined #c-lightning 12:48 -!- tiagotrs [~user@i577A6827.versanet.de] has quit [Changing host] 12:48 -!- tiagotrs [~user@unaffiliated/tiagotrs] has joined #c-lightning 12:48 -!- froyer [~froyer@126.121.233.220.static.exetel.com.au] has joined #c-lightning 12:53 -!- froyer [~froyer@126.121.233.220.static.exetel.com.au] has quit [Ping timeout: 268 seconds] 13:02 -!- dougsland [~douglas@c-73-234-93-65.hsd1.nh.comcast.net] has quit [Ping timeout: 244 seconds] 13:05 -githubby:#c-lightning- [lightning] cdecker opened pull request #1777: Consider channel parameters before selecting for a route (master...capacity-check) https://git.io/fNaSe 13:09 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Ping timeout: 260 seconds] 13:10 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning 13:10 < molz> Chris_Stewart_5, i don't have rpcuser and rpcpassword in my bitcoin.conf, what happened probably because the guy is not running his bitcoind with "--server" or put "server-1" in his bitcoin.conf 13:11 < molz> er "server=1" rather 13:12 < molz> "server=1" will create a .cookie file and from what i understand if he runs lightningd on the same machine, that takes care of it 13:14 < molz> also 'rpcuser' and 'rpcpassword' are deprecated now, he needs to use rpcauth 13:15 < Chris_Stewart_5> molz: Thanks. I think you are right on the cookie thing. 13:23 -!- deusexbeer [~deusexbee@093-092-177-009-dynamic-pool-adsl.wbt.ru] has quit [Quit: Konversation terminated!] 13:24 -!- sturles [~sturles@unaffiliated/sturles] has quit [Ping timeout: 244 seconds] 13:44 -!- sturles [~sturles@ulrik.uio.no] has joined #c-lightning 13:44 -!- sturles [~sturles@ulrik.uio.no] has quit [Changing host] 13:44 -!- sturles [~sturles@unaffiliated/sturles] has joined #c-lightning 14:06 -!- yoyo_ [uid312116@gateway/web/irccloud.com/x-feqdpydjzjnobycj] has quit [Read error: Connection reset by peer] 14:06 -!- yoyo_ [uid312116@gateway/web/irccloud.com/x-hnpoeyiihgspiqki] has joined #c-lightning 14:12 -!- booyah [~bb@193.25.1.157] has quit [Ping timeout: 256 seconds] 14:19 -githubby:#c-lightning- [lightning] rustyrussell pushed 3 new commits to master: https://git.io/fNaFS 14:19 -githubby:#c-lightning- lightning/master f449f9d Christian Decker: onion: Make sure we understand the channel_update in the onionreply... 14:19 -githubby:#c-lightning- lightning/master 6bbea74 Christian Decker: pay: Strip the type prefix from nested channel_updates... 14:19 -githubby:#c-lightning- lightning/master d3edfc8 Christian Decker: onion: Print the extracted channel_update and onionreply to debug... 14:21 -!- qubenix [~qubenix@s91904423.blix.com] has joined #c-lightning 14:28 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Ping timeout: 240 seconds] 14:32 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 264 seconds] 15:28 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 15:29 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #c-lightning 15:31 -githubby:#c-lightning- [lightning] wythe opened pull request #1779: Added json_tok_sha256 (master...add-tok-sha256) https://git.io/fNahA 15:43 -!- renepick [577bc40d@gateway/web/freenode/ip.87.123.196.13] has quit [Quit: Page closed] 15:58 -!- tiagotrs [~user@unaffiliated/tiagotrs] has quit [Ping timeout: 260 seconds] 16:55 -!- froyer [~froyer@124.19.31.4] has joined #c-lightning 17:14 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #c-lightning 17:23 -!- deusexbeer [~deusexbee@079-170-138-040-dynamic-pool-adsl.wbt.ru] has joined #c-lightning 17:34 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds] 18:47 -!- grafcaps [~haroldbr@104.137.194.255] has quit [Ping timeout: 268 seconds] 18:55 -!- grafcaps [~haroldbr@050-090-083-229.res.spectrum.com] has joined #c-lightning 18:58 -!- qubenix [~qubenix@s91904423.blix.com] has quit [Remote host closed the connection] 19:40 -!- dougsland [~douglas@c-73-234-93-65.hsd1.nh.comcast.net] has joined #c-lightning 20:08 -!- qubenix [~qubenix@104.200.129.53] has joined #c-lightning 20:15 -!- grafcaps [~haroldbr@050-090-083-229.res.spectrum.com] has quit [Ping timeout: 268 seconds] 20:18 -!- dougsland [~douglas@c-73-234-93-65.hsd1.nh.comcast.net] has quit [Ping timeout: 264 seconds] 20:24 -!- froyer [~froyer@124.19.31.4] has quit [Remote host closed the connection] 20:33 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning 20:33 -!- froyer [~froyer@124.19.31.4] has joined #c-lightning 21:02 -!- nverdhan [31f8d32a@gateway/web/freenode/ip.49.248.211.42] has joined #c-lightning 21:04 < nverdhan> hi, trying out c-lightning. Running lightningd with network=testnet. The new address command `lightning-cli newaddr` gives me an address starting with t and I cannot send testnet coins to this address. 21:04 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 21:05 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #c-lightning 21:11 -githubby:#c-lightning- [lightning] rustyrussell pushed 1 new commit to master: https://git.io/fNVsV 21:11 -githubby:#c-lightning- lightning/master 1fca7ab Mark Beckwith: Added json_tok_sha256 (#1779)... 21:24 < polydin> nverdhan, if you're trying to get coins from a testnet faucet most likely they haven't updated their bitcoind, just send coins from the faucet to your local bitcoind testnet node and then to your lightning wallet address 21:29 < jb55> nverdhan: lightning-cli newaddr p2sh-segwit 21:34 < jb55> rusty: I'm thinking about working on an hsmd that doesn't have access to privkeys (it sends PSBTs to hw wallets, etc). Does it make sense to write a new hsm daemon instead of extending the current one? 21:35 -!- ebx [~ebx@unaffiliated/ebex] has quit [Remote host closed the connection] 21:36 < jb55> It looks like it would be a lot of work to refactor the current one to support this ... 21:36 < rusty> jb55: that's a good q. Another hsmd implies we shouldn't play with the API too much, which isn't true since we're going to want to tighten enforcement and will hand the hsmd more information to do so. Also, I want to change derivation to be like lnd's. 21:38 < rusty> jb55: I think longer term the entire hsmd goes into the hw wallet. Having the hw wallet sign every tx doesn't work from a UX POV, so you need to think carefully what it actually does (maybe hw wallet is for spending funds and funding channels, hsmd looks after per-channel stuff?) 21:39 < rusty> So, IOW I don't know. Might be one of those "try it and see how it looks"? 21:43 < nverdhan> @polydub @jb55 thanks 21:43 < jb55> rusty: that's what I was thinking, just funding channels for now. One issue is that coin selection happens in json_fund_channel and is passed as utxos to the hsmd to be signed. I'll have to think about this more since we wouldn't own the wallet... thx! 21:43 -!- nverdhan [31f8d32a@gateway/web/freenode/ip.49.248.211.42] has quit [Quit: Page closed] 22:43 -!- booyah [~bb@193.25.1.157] has joined #c-lightning 22:56 -!- Amperture [~amp@24.136.5.183] has joined #c-lightning 23:10 -!- grafcaps [~haroldbr@050-090-083-229.res.spectrum.com] has joined #c-lightning 23:15 -!- grafcaps [~haroldbr@050-090-083-229.res.spectrum.com] has quit [Ping timeout: 265 seconds] 23:34 -!- User_ [~User@180.217.140.78] has joined #c-lightning 23:37 -!- ken2812221 [~User@180.217.140.78] has quit [Ping timeout: 248 seconds] 23:59 -!- User_ [~User@180.217.140.78] has quit [Quit: Leaving]