--- Log opened Tue Mar 26 00:00:26 2019
02:01 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
02:14 -!- spinza [~spin@155.93.246.187] has joined #c-lightning
02:19 -!- bitonic-cjp [~bitonic-c@92-111-70-106.static.v4.ziggozakelijk.nl] has joined #c-lightning
03:50 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
04:11 -!- spinza [~spin@155.93.246.187] has joined #c-lightning
05:58 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]
05:59 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #c-lightning
06:02 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]
06:03 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #c-lightning
06:34 < m-schmoock> cdecker: I updated https://github.com/ElementsProject/lightning/pull/2494  please read it from top. I removed the non working 'fix' and the renaming of the strange exception. The same code raise valgrind issues yesterday on Travis... lets see
06:35 < m-schmoock> I basically have two issues here.   1. It actually raises a "should not happen" exception   2. it raises unpreditable valgrind issues that sometimes happen ans sometimes not
06:35 < m-schmoock> there is something fishy
06:54 < m-schmoock> cdecker: travis memleaks with non-modified code https://travis-ci.org/ElementsProject/lightning/jobs/511489072#L1252   https://travis-ci.org/ElementsProject/lightning/jobs/511489071#L1252   and    https://travis-ci.org/ElementsProject/lightning/jobs/511489066#L1255
06:54 < m-schmoock> happy debugging ;)
07:00 < nibbier> cdecker: full log is at https://drop.geekbox.info/c-lightning.txt, 2nd to last line is "lightningd(23590): bitcoin-cli estimatesmartfee 2 CONSERVATIVE exited with status 1" which does not look to much like an error to me, last line is about  adding some block
07:14 <@cdecker> Hi m-schmoock, thanks for investing the time
07:15 < m-schmoock> well, if we dont do it, who will?
07:16 < m-schmoock> imho we need LN more than ever to get rid of all this onchain sclaing BS  10TerraByte centralized shitcoin chain.  ^^
07:16 <@cdecker> I think we have two options here, free the objects allocated off of state individually, or make the callees (funder_channel and fundee_channel) TAKE ownership of `state` so they can free it when necessary 
07:17 < m-schmoock> what do would we prefer?
07:18 <@cdecker> Not sure tbh
07:18 < m-schmoock> I discovered this issue when implementing the channel accept hook and min config value feature
07:21 <@cdecker> Oh yeah, hooks can introduce some of these things since they can split things that used to be atomic (like freeing things allocated on tmpctx, or DB transactions)
07:23 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #c-lightning
07:37 < m-schmoock> thanks for pointing out that the valgrind issues are 'unpreditable' as they slow down the CPU that can lead to the issue itself. 
07:51 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection]
08:06 -!- shesek [~shesek@unaffiliated/shesek] has joined #c-lightning
08:58 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #c-lightning
09:01 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has joined #c-lightning
09:24 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection]
09:29 < m-schmoock> cdecker: I proposed a fix in this PR, lets wait for travis
10:01 -!- bitonic-cjp [~bitonic-c@92-111-70-106.static.v4.ziggozakelijk.nl] has quit [Quit: Leaving]
10:05 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has quit [Ping timeout: 255 seconds]
10:24 < m-schmoock> travis is good with the fix
10:53 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
11:19 -!- spinza [~spin@155.93.246.187] has joined #c-lightning
12:27 < m-schmoock> cdecker: I added part1 of issue #2483 as PR https://github.com/ElementsProject/lightning/pull/2506   this includes the memory leak fix. So you can decide if to merge this now seperately or later... your call. thanks for your help, im not that deep into the codebase yet...
12:27 < m-schmoock> will continue on part2 on implementing a hook for accepting channels
12:44 -!- nothingmuch [~nothingmu@unaffiliated/nothingmuch] has joined #c-lightning
13:57 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #c-lightning
15:30 -!- spinza [~spin@155.93.246.187] has quit [Read error: Connection reset by peer]
15:37 -!- spinza [~spin@155.93.246.187] has joined #c-lightning
17:24 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
17:34 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [Ping timeout: 250 seconds]
17:40 -!- spinza [~spin@155.93.246.187] has joined #c-lightning
18:31 -!- RonNa [~quassel@220-133-223-206.HINET-IP.hinet.net] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
18:38 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #c-lightning
18:54 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [Ping timeout: 255 seconds]
18:57 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #c-lightning
21:50 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #c-lightning
21:52 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 245 seconds]
--- Log closed Wed Mar 27 00:00:27 2019