--- Log opened Mon May 13 00:00:11 2019
00:23 -!- k3tan172 [k3tan@gateway/vpn/protonvpn/k3tan] has joined #c-lightning
00:25 -!- k3tan [k3tan@gateway/vpn/protonvpn/k3tan] has quit [Ping timeout: 255 seconds]
00:55 -!- k3tan172 [k3tan@gateway/vpn/protonvpn/k3tan] has quit [Remote host closed the connection]
01:00 -!- k3tan [k3tan@gateway/vpn/protonvpn/k3tan] has joined #c-lightning
03:25 -!- bitonic-cjp [~bitonic-c@92-111-70-106.static.v4.ziggozakelijk.nl] has joined #c-lightning
03:44 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
03:54 -!- spinza [~spin@155.93.246.187] has joined #c-lightning
05:12 -!- darosior [6dbe8dc1@gateway/web/freenode/ip.109.190.141.193] has joined #c-lightning
05:16 < darosior> Hi, @cdecker: I'm adding another command to pylightning and wondering if it would make sense that I order all LightningRpc's command methods alphabetically so that it would be easier to see which one are missing or to add one when there is a new RPC command ?
05:42 < m-schmoock> I was also considering reorganizing the output alphabetically. maybe the plugins commands in a second section at the end. also the output would be much more readable if it would be more like "bitcoind --help" in structure (max width, indenting, ...)
05:44 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has joined #c-lightning
05:55 < m-schmoock> we need some ascii expert here :D
05:59 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 252 seconds]
06:09 < darosior> ^^
06:18 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #c-lightning
06:32 < darosior> You are right about the `help` output, I can do that this evening (at least the alphabetical ordering)
06:48 < m-schmoock> darosior: ... see my comment int the PR
06:49 < darosior> This PR is not about ordering the output, just the code
06:49 < m-schmoock> ah okay :D lol
06:49 < m-schmoock> ill remove my stupid comment then
06:51 < darosior> x)
06:53 < m-schmoock> lets wait was jenkins thinks
07:01 < m-schmoock> I think a jslightning npm/node library would be a good addition for web(server) developers.
07:04 < darosior> Maybe, I would personally do JS only if I'm forced to (i.e. not server-side) ^^
07:16 < m-schmoock> darosior: your change breaks a test: test_check_command
07:16 < m-schmoock> https://travis-ci.org/ElementsProject/lightning/builds/531798867
07:17 < m-schmoock> about JS: yes, not a wise choice when handling programmable money :D
07:18 < m-schmoock> but it will be done and used anyway, so we can at least ensure the binding has a good implementation
07:18 < m-schmoock> and for local stuff (statistics and such) its a good option to use JS because its even less complicated
07:40 < darosior> m-shmoock: How comes we used l1.rpc.check() in the test while there was no check() method in the LightningRpc class before my PR ? Are there some more definitions elsewhere ?
07:49 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has joined #c-lightning
08:16 -!- ulrichard [~richi@dzcpe6300borminfo01-e0.static-hfc.datazug.ch] has quit [Remote host closed the connection]
08:26 -!- copumpkin [~copumpkin@haskell/developer/copumpkin] has joined #c-lightning
08:51 -!- bitonic-cjp [~bitonic-c@92-111-70-106.static.v4.ziggozakelijk.nl] has quit [Quit: Leaving]
08:57 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
09:07 -!- spinza [~spin@155.93.246.187] has joined #c-lightning
09:39 < m-schmoock> darosior: dunno, would need to check myself.
09:42 < m-schmoock> darosior: what did you change, works now for jenkins...
09:43 < darosior> m-schmoock: Yeah I used **kwargs in check()
09:44 < darosior> Instead of taking a list as the second parameter, it is consistent with how `rpc.check()` is used in test_misc.py
09:44 < darosior> btw I have not found where this rpc method came from ^^'
09:52 < m-schmoock> well thats strange
09:52 < m-schmoock> should have not worked before but did
09:52 < darosior> Yes
09:52 < darosior> Maybe it was skipped
09:53 < m-schmoock> cdecker: for me this PR is okay, what do you think?: https://github.com/ElementsProject/lightning/pull/2631/files
10:10 < m-schmoock> darosior: whats your cln node ID? do you have one?
10:10 < darosior> Yep 03678b4f041fbfbeebcafc076469df75decf81da20a53bd490172e83ce532df1fa
10:10 < darosior> What's yours ?
10:11 < m-schmoock> https://lightning.chaintools.io/node/02a2c53bc475cb92e4ab2f38a5bca56df695034ce90ad78c2f47c05911e3f79e41
10:12 < m-schmoock> min funding is 0.005btc :D I can also open up to you if you want
10:13 < m-schmoock> BTC pumping hard right now, might want reconsider minimum fundin amount soon ^^
10:14 < m-schmoock> lol, bitfinex now has a negative premium. do people even use their brains
10:15 < darosior> Yeah why not
10:15 < darosior> haha yeah a lot of fomo here in Lyon, France ^^
10:16 < m-schmoock> as if bitcoin was in a shortage at 3k €
10:16 < m-schmoock> people are having strong cognitive dissonance
10:16 < darosior> Yeah
10:17 < darosior> Who can ACK a PR ? I reviewed yours on pylightning but I don't know if it is welcomed that I put a ACK <commit>
10:18 < m-schmoock> hm, i thought I could. but sometimes the ackbot is lazy
10:18 < darosior> No but I meant, can I ?
10:19 < m-schmoock> I think you need to be collaborator, but not sure
10:19 < darosior> Ok, thanks
10:20 < m-schmoock> you can try, dont think anyone has a serious poblem with it :D
10:23 < m-schmoock> One fun talk I had today:   Guy: "Bitcoin cannot work because its deflationary"   Me: "Dude, you say it cannot work because it will only raise in price long term?"
10:23 < m-schmoock> °_°
10:31 < darosior> x)
10:40 -!- jtimon [~quassel@181.61.134.37.dynamic.jazztel.es] has joined #c-lightning
10:54 -!- darosior [6dbe8dc1@gateway/web/freenode/ip.109.190.141.193] has quit [Quit: Page closed]
11:57 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #c-lightning
12:20 -!- darosior [52432b55@gateway/web/freenode/ip.82.67.43.85] has joined #c-lightning
12:26 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #c-lightning
12:27 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 245 seconds]
12:32 < m-schmoock> cdecker: thx
12:33 < m-schmoock> ... for merging all the things \o/
12:42 <@cdecker> No problem, had a few minutes here at the conf
13:14 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #c-lightning
13:20 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #c-lightning
13:27 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Ping timeout: 246 seconds]
13:59 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 268 seconds]
15:00 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #c-lightning
15:15 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
15:19 -!- cubancorona [cubancoron@gateway/vpn/privateinternetaccess/cubancorona] has joined #c-lightning
15:21 -!- darosior [52432b55@gateway/web/freenode/ip.82.67.43.85] has quit [Quit: Page closed]
15:47 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #c-lightning
15:49 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
15:55 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 246 seconds]
16:04 -!- spinza [~spin@155.93.246.187] has joined #c-lightning
16:14 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
16:34 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #c-lightning
16:35 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 245 seconds]
16:50 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #c-lightning
17:48 < m-schmoock> Another gossip related Crash issue: https://github.com/ElementsProject/lightning/issues/2634
18:02 < m-schmoock> cdecker: can you assign rusty?
19:30 -!- jtimon [~quassel@181.61.134.37.dynamic.jazztel.es] has quit [Ping timeout: 245 seconds]
19:34 <@cdecker> Sure
20:08 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #c-lightning
20:10 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 258 seconds]
21:29 -!- copumpkin [~copumpkin@haskell/developer/copumpkin] has quit [Ping timeout: 246 seconds]
22:21 -!- cubancorona [cubancoron@gateway/vpn/privateinternetaccess/cubancorona] has quit [Remote host closed the connection]
22:22 -!- cubancorona [cubancoron@gateway/vpn/privateinternetaccess/cubancorona] has joined #c-lightning
23:04 -!- jtimon [~quassel@181.61.134.37.dynamic.jazztel.es] has joined #c-lightning
23:33 -!- grubles [~grubles@unaffiliated/grubles] has joined #c-lightning
23:45 -!- jtimon [~quassel@181.61.134.37.dynamic.jazztel.es] has quit [Ping timeout: 244 seconds]
--- Log closed Tue May 14 00:00:12 2019