--- Log opened Fri May 31 00:00:27 2019
00:17 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 248 seconds]
00:31 -!- ulrichard [~richi@dzcpe6300borminfo01-e0.static-hfc.datazug.ch] has joined #c-lightning
00:34 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Quit: Leaving.]
00:44 -!- Amperture [~amp@24.136.5.183] has quit [Remote host closed the connection]
00:57 -!- darosior [6dbe8dc1@gateway/web/freenode/ip.109.190.141.193] has joined #c-lightning
01:11 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has quit [Quit: jb55]
01:22 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #c-lightning
01:23 < jb55> testing123
03:18 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
03:21 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #c-lightning
03:24 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection]
03:25 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #c-lightning
03:27 -!- spinza [~spin@155.93.246.187] has joined #c-lightning
03:30 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection]
03:31 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #c-lightning
03:37 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection]
03:37 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #c-lightning
03:41 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection]
03:41 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #c-lightning
03:43 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection]
04:26 < k3tan> wondering if we're in a position to know the new features coming out in the next version of c-lightning and when that release will be?
04:56 <@cdecker> k3tan: sure, the next release (0.7.1) is going to be mainly a bug-fix and usability improvement release
04:56 <@cdecker> For a detailed list of changes see the changelog: https://github.com/ElementsProject/lightning/blob/master/CHANGELOG.md#unreleased
04:57 <@cdecker> On top of that there are a couple of pending PRs that may make it into the release
05:05 < m-schmoock> cdecker: Hi, can you review this bugfix PR of ZmnSCPxj? https://github.com/ElementsProject/lightning/pull/2694  
05:08 < m-schmoock> seems no big deal and fixes the issues
05:14 <@cdecker> I'm trying to reproduce the issue in a test first and then I'll check that the fix works :-)
05:14 <@cdecker> Working on it now ^^
05:23 -!- Nukeops_ [sid338452@gateway/web/irccloud.com/x-ldassjzobybrtbzp] has joined #c-lightning
05:25 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 256 seconds]
05:25 < k3tan> thanks cdecker appreciate it
05:25 -!- Nukeops [sid338452@gateway/web/irccloud.com/x-cxrdgtteenchgbgm] has quit [Ping timeout: 252 seconds]
05:25 -!- Nukeops_ is now known as Nukeops
05:28 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #c-lightning
05:28 -!- rotarydialer [~rotarydia@unaffiliated/rotarydialer] has quit [Ping timeout: 248 seconds]
05:31 -!- rotarydialer [~rotarydia@unaffiliated/rotarydialer] has joined #c-lightning
05:59 <@cdecker> m-schmoock: I reproduced #2687 in the test case added in #2690, can you check and ACK if appropriate?
05:59 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has joined #c-lightning
06:32 < m-schmoock> cdecker: done. looks fine. still running the complete testsuite and ack then just to be sure in case...
06:32 < m-schmoock> why is Travis not running on this PR?
06:32 < m-schmoock> ah, it is, my fault :D
06:34 < m-schmoock> some tests are flaky, at least on my machine
06:35 < m-schmoock> tests/test_connection.py::test_no_fee_estimate    tests/test_plugin.py::test_openchannel_hook   tests/test_misc.py::test_funding_reorg_private
06:35 < m-schmoock> does not seem related
06:42 -!- trueptolemy [c238e29e@gateway/web/freenode/ip.194.56.226.158] has joined #c-lightning
06:44 < m-schmoock> cdecker: ACK for #2690
06:49 < trueptolemy> m-schmoock: hi, did those test fail in Travis based on your own repository? usually failed because of timeout?
06:49 < m-schmoock> yes (clean master) and yes (as written in my response on GitHub) they are unrelated. Tested with master and this changeset
06:51 < m-schmoock> for the tests/test_plugin.py::test_openchannel_hook   there is a race condition, easy to fix
06:51 < m-schmoock> same for tests/test_misc.py::test_funding_reorg_private
06:52 < m-schmoock> its when some node cluses and bitcoind.generate_block(1)  is immideately called afterwards
06:52 < m-schmoock> the mempool of the bitcoind may not already seee the TX for the close
06:52 < m-schmoock> -> hence test timout
06:52 < m-schmoock> shall I fix this and PR =?
06:55 -!- trueptolemy [c238e29e@gateway/web/freenode/ip.194.56.226.158] has quit [Ping timeout: 256 seconds]
07:02 -!- trueptolemy [c238e29e@gateway/web/freenode/ip.194.56.226.158] has joined #c-lightning
07:05 -!- jtimon [~quassel@181.61.134.37.dynamic.jazztel.es] has joined #c-lightning
07:07 < trueptolemy> I also meet failure on Travis, which based on my github. They are also timeout, but occured when waited for syncing block height. I tried sync block forwardly(add sync block sentence) and worked
07:10 < trueptolemy> but finally the Travis still failed because the total cost was more than 50mins. so I guess the computing power that Travis allocated to each account is different.
07:16 -!- trueptolemy [c238e29e@gateway/web/freenode/ip.194.56.226.158] has quit [Ping timeout: 256 seconds]
07:17 < m-schmoock> I fixed the flakyness of tests/test_plugin.py::test_openchannel_hook and tests/test_misc.py::test_funding_reorg_private it, you can ACK :D    https://github.com/ElementsProject/lightning/pull/2695
07:18 < m-schmoock> cdecker: your turn, trueprolemy just left :D
07:21 < m-schmoock> same can be done tests/test_connection.py::test_no_fee_estimate   l1.wait_for_channel_onchain(l2.info['id'])  needs a loop callback and we can 'fix' the bitcoind.generate_block(100) few lines above
07:23 -!- trueptolemy [c238e29e@gateway/web/freenode/ip.194.56.226.158] has joined #c-lightning
07:23 < trueptolemy> :-)
07:23 < m-schmoock> trueptolemy: https://github.com/ElementsProject/lightning/pull/2695
07:23 < m-schmoock> :D
07:29 < trueptolemy> so quickly! let me try it on my Travis :)
07:30 < m-schmoock> hmmm I think we can do it better by this maybe: wait_for(lambda: len(bitcoind.rpc.getrawmempool()) > 0)  
07:30 < m-schmoock> and then just one generate_block
07:33 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #c-lightning
07:35 < m-schmoock> hm the bitcoind.rpc.getrawmempool trick does not work reliable
07:35 < m-schmoock> so, dunno. cdecker can tell if a wait for loop callback is better. it does seem to work
07:40 < m-schmoock> done
07:41 < m-schmoock> trueptolemy: I added the fix for fix: flake test_no_fee_estimate
07:41 < m-schmoock> same solution seem to work for me
07:42 < m-schmoock> git grep "generate_block(100)" reveals we have some more hacks that we can fix this way
07:50 < trueptolemy> m-schmoock: Thank you :) I've pushed and I'm waiting
08:04 -!- trueptolemy [c238e29e@gateway/web/freenode/ip.194.56.226.158] has quit [Ping timeout: 256 seconds]
08:11 < m-schmoock> aaaannd hes gone   
08:16 -!- trueptolemy [c238e29e@gateway/web/freenode/ip.194.56.226.158] has joined #c-lightning
08:16 -!- ulrichard [~richi@dzcpe6300borminfo01-e0.static-hfc.datazug.ch] has quit [Remote host closed the connection]
08:20 -!- trueptolemy [c238e29e@gateway/web/freenode/ip.194.56.226.158] has quit [Ping timeout: 256 seconds]
08:45 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has quit [Quit: Leaving]
08:45 -!- trueptolemy [c238e29e@gateway/web/freenode/ip.194.56.226.158] has joined #c-lightning
08:50 -!- trueptolemy [c238e29e@gateway/web/freenode/ip.194.56.226.158] has quit [Ping timeout: 256 seconds]
08:59 -!- trueptolemy [c238e29e@gateway/web/freenode/ip.194.56.226.158] has joined #c-lightning
09:02 <@cdecker> m-schmoock: the loop_callback seems a bit weird to me, it'd be better to wait for the TX to be in the memory pool before generating a block.
09:02 < m-schmoock> yes, I thought that too
09:02 < m-schmoock> but its not reliable
09:02 < m-schmoock> dunno why
09:02 < m-schmoock> having the cb in the loop does not flakes, where waiting for tx pool still does and leads to timeouts
09:02 < trueptolemy> m-schmoock: :D sorry, my internet connect is always not satble. based on your first commit, funding_reorg_private and openchannel_hook passed very well on my Travis!
09:02 <@cdecker> The callback could also be avoided by having a different check function which checks and generates on failure, no need to drag that logic into the `wait_for` function
09:03 <@cdecker> m-schmoock: yes, there is a bit of a race between the TX making it into the mempool and the block template being adjusted
09:03 < m-schmoock> testing against exceptions is also ugly :D
09:04 < m-schmoock> I think having a CB function is the 'nicer' way
09:04 <@cdecker> Maybe we can use the getblocktemplate RPC call to check if we would mine it
09:04 < m-schmoock> hm
09:04 < m-schmoock> waitfor blocktemplate 
09:04 < m-schmoock> maybe
09:04 < m-schmoock> ill check it and come back to you
09:04 <@cdecker> Thanks, great work tracking down the root cause btw :-)
09:05 < m-schmoock> yep a pleasure :D
09:05 < trueptolemy> nice work!
09:07 < m-schmoock> I tried the wait bitcoind.rpc.getrawmempool  this does not solve the problem, probably as having a TX in the mempool and in the next block template are two different things
09:09 <@cdecker> Yeah, I remember bumping against that issue before as well
09:09 < trueptolemy> m-schmoock: what do you think about adding sync_blockheight() after every bitcoin.generate_block()?
09:09 < m-schmoock> not really, as the following commands are (in general) waitfor something else (like close and such)
09:10 < m-schmoock> so syncing is implicit in these cases
09:10 < m-schmoock> gotta go now. will try getblocktemplate later. cu guys
09:13 < trueptolemy> cdecker: "We could make the logs a subscription for plugins as well", do you have plans to make hook/notifications for log?
09:16 < trueptolemy> like unusual event notification, yestoday I dicussed with jb55, but I not sure if it is indeed needed. If it's needed, I'd like to have a try :)
09:17 < jb55> trueptolemy: I mean it would be easier for most people to just install a plugin vs a script that greps the log and runs a command so it's probably worth it.
09:19 < jb55> for me I haven't been able to run any python plugins because I still have to package the python stuff in nixos '^-^
09:19 < jb55> I should get around to that...
09:19 < trueptolemy> Thank you! :)
09:21 <@cdecker> trueptolemy: I'd make them notifications since that doesn't limit us to a single consumer like hooks do
09:24 < trueptolemy> I see ^_^
09:58 -!- darosior [6dbe8dc1@gateway/web/freenode/ip.109.190.141.193] has quit [Quit: Page closed]
10:25 < m-schmoock> cdecker: +1 on the notifications :)
10:29 < m-schmoock> cdecker: we can't use getblocktemplate on the regtest as we always get "Bitcoin is not connected!" exception when calling. Do you see a way around that? otherwise I would like to stick with the lambda callback block generator
11:07 <@cdecker> Nah, please just make the checker function generate a block if it fails, I prefer not to add magic to wait_for
11:13 <@cdecker> m-schmoock: sorry for the delay reviewing lightningd/plugins#33, looks good, but you probably want to keep the type casts in there, the type annotations don't have a runtime effect afaik
11:35 < nibbier> hi. thanks for fixing my bug ( 2687) this quickly @cdecker and others. the new version breaks a bit later and way more verbose. turns out my bitcoin-cli / bitcoind does not support a 2nd argument to getfeeestimate. this means my bitcoind is outdated? should this not be detected by c-lightning? http://drop.geekbox.info/feeestimateerror.log 
11:36 <@cdecker> What's the version?
11:37 < jb55> nibbier: I think we use estimatesmartfee ?
11:38 < nibbier> oh sorry, yes. this one. see the log, this one is called, but my bitcoind (17.1) does not like the CONSERVATIVE parameter - guess this was the problem the whole time
11:41 < nibbier> cdecker: on a sidenote, bitcoind is not running locally, but connected via ssh tunnel to 17.1
11:41 <@cdecker> nibbier: that's how I have been running my nodes for some time ^^
11:42 < nibbier> also I can't find required minimum version of bitcoind... should it work with 17.1?
11:43 < nibbier> thought it would possibly detect the version wrong, as bitcoind is not running locally or such...
11:44 <@cdecker> Hm, not sure myself what version we need, 0.18.0 should be a safe option
11:48 < nibbier> guess so,  will update :)
11:50 < molz> nibbier, 'estimatesmartfee' has been supported in many version, you probably mistyped the command
11:51 < nibbier> molz, look in the log posted above. clightning issues the command and outputs the negative server reply
11:52 < nibbier> molz: also with 2 parameters for long?
11:55 < molz> nibbier, first off there's no such command 'getfeeestimate' in bitcoind 
11:55 < molz> secondly you can do 'bitcoin-cli estimatesmartfee 6
11:55 < molz> try it
11:56 < nibbier> molz: this one works, but it seems to me clightning adds the additional parameter CONSERVATIVE
11:56 < nibbier> ... and this breaks things
11:56 < molz> hm is it a new thing?
11:57 < nibbier> see clightning output http://drop.geekbox.info/feeestimateerror.log
11:57 < nibbier> running latest git
12:01 < molz> i don't have those lines when running 'bitcoin-cli estimatesmartfee 2' 
12:02 < molz> and im running c-lightning  "version": "v0.7.0",
12:04 < nibbier> molz: what bitcoind version?
12:05 < nibbier> and I'm not running bitcoin cli myself. this is called that way from clightning
12:11 < molz> nibbier i'm running 3 clightning nodes on testnet, two with bitcoind v0.18, one with bitcoind v0.17.1, they result the same 
12:13 < molz> nibbier, what do you mean you're not running bitcoin-cli? how did you run the command for 'estimatesmartfee' ?
12:14 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
12:18 < nibbier> the output in  the url above is produced by running clightingd. clightningd runs bitcoin-cli. I run clightningd
12:21 < molz> is it a new thing?
12:22 < nibbier> what? clightning has an available bitcoin-cli as dependency for like ever
12:22 < molz> never heard of 'clightningd' before, i only know 'lightningd' and 'lightning-cli'
12:22 < nibbier> lightningd then...
12:22 < molz> c-lightning depends on bitcoind, not the other way around
12:23 < molz> because lightning network is built on top of bitcoin, not the other way around
12:23 < nibbier> did I claim anything else?
12:23 < molz> im just confused by what you said
12:25 -!- trueptolemy [c238e29e@gateway/web/freenode/ip.194.56.226.158] has quit [Quit: Page closed]
12:27 < nibbier> molz: just have a look at drop.geekbox.info/feeestimateerror.log - it includes everything - the binary that is being called, the error that is being produced....
12:31 < molz> i read it, it's a strange way to call 'bitcoin-cli estimatesmartfee' which is just a simple command
12:37 -!- spinza [~spin@155.93.246.187] has joined #c-lightning
12:42 < nibbier> molz: how would you think lightningd gets the fee estimate?
12:42 < nibbier> btw: updated to 18.0 now the 2nd parameter works....
12:44 < nibbier> so I think c-lightning should complain if the available bitcoind version is not recent enough :)
13:02 < jb55> nibbier: I think we have a it documented but yeah failing fast wouldn't hurt here
13:10 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #c-lightning
13:31 < molz> jb55, is this a new way to check esteimatefee for clightning or something? 
13:31 < molz> estimatefee* 
13:31 < molz> is it documented anywhere?
13:50 < jb55> molz: ? fee estimates come from bitcoind, not c-lightning
13:59 < m-schmoock> cdecker: we can't use getblocktemplate in regtest:   https://github.com/bitcoin/bitcoin/issues/11379
14:00 < m-schmoock> rusty tried to argue, currently the only way is to change our testsuite and add another 'regtest' 'miner' so the daemon feels 'connected'
14:01 < m-schmoock> do we stick to the callback then, or do we change the regtest suite or do you have more ideas about stabilizing all the generate_block(100) tests
14:01 < m-schmoock> ?
14:08 < m-schmoock> also, sorry I squash-merged https://github.com/lightningd/plugins/pull/33  next time I try to remeber to click the right button
14:14 < molz> jb55, yea i know, thanks for clarifying :D  I thought since i didn't pay much attention to the c-lightning doc and repo maybe i missed something .. lol
14:43 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #c-lightning
14:44 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 248 seconds]
15:30 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
15:32 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
15:40 -!- jtimon_ [~quassel@181.61.134.37.dynamic.jazztel.es] has joined #c-lightning
15:42 -!- jtimon [~quassel@181.61.134.37.dynamic.jazztel.es] has quit [Quit: gone]
15:42 -!- jtimon_ [~quassel@181.61.134.37.dynamic.jazztel.es] has quit [Client Quit]
15:42 -!- jtimon [~quassel@181.61.134.37.dynamic.jazztel.es] has joined #c-lightning
15:52 -!- spinza [~spin@155.93.246.187] has joined #c-lightning
16:00 -!- ctrlbreak [~ctrlbreak@99.192.57.228] has quit [Ping timeout: 258 seconds]
17:15 -!- ctrlbreak [~ctrlbreak@142.162.47.184] has joined #c-lightning
17:35 -!- ctrlbreak [~ctrlbreak@142.162.47.184] has quit [Ping timeout: 252 seconds]
17:38 -!- ctrlbreak [~ctrlbreak@142.162.48.40] has joined #c-lightning
17:50 -!- justan0theruser is now known as justanotheruser
18:04 -!- ctrlbreak [~ctrlbreak@142.162.48.40] has quit [Ping timeout: 248 seconds]
18:16 -!- ctrlbreak [~ctrlbreak@142.162.53.44] has joined #c-lightning
18:23 -!- ctrlbreak [~ctrlbreak@142.162.53.44] has quit [Read error: Connection reset by peer]
18:24 -!- ctrlbreak [~ctrlbreak@142.162.53.44] has joined #c-lightning
18:25 -!- ctrlbreak [~ctrlbreak@142.162.53.44] has quit [Read error: Connection reset by peer]
18:48 -!- RonNa [~quassel@220-133-223-206.HINET-IP.hinet.net] has joined #c-lightning
18:50 -!- ctrlbreak [~ctrlbreak@142.134.101.32] has joined #c-lightning
20:52 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #c-lightning
20:54 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 258 seconds]
21:41 -!- StopAndDecrypt_ [~StopAndDe@206.189.214.52] has joined #c-lightning
21:41 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [Ping timeout: 272 seconds]
22:56 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning
23:08 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Quit: Leaving.]
--- Log closed Sat Jun 01 00:00:28 2019