--- Log opened Thu Oct 31 00:00:50 2019 00:08 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Quit: Leaving.] 00:48 -!- k3tan [~k3tan@unaffiliated/k3tan] has quit [Ping timeout: 240 seconds] 00:57 -!- k3tan [k3tan@gateway/vpn/protonvpn/k3tan] has joined #c-lightning 01:26 -!- k3tan [k3tan@gateway/vpn/protonvpn/k3tan] has quit [Ping timeout: 276 seconds] 02:17 -!- lxer [~lx@ip5f5bf7cc.dynamic.kabel-deutschland.de] has joined #c-lightning 02:26 -!- lxer [~lx@ip5f5bf7cc.dynamic.kabel-deutschland.de] has quit [Ping timeout: 268 seconds] 03:13 -!- kabaum [~kabaum@2001:9b1:efd:9b00::281] has joined #c-lightning 03:47 -!- k3tan [~k3tan@unaffiliated/k3tan] has joined #c-lightning 03:54 -!- k3tan [~k3tan@unaffiliated/k3tan] has quit [Ping timeout: 268 seconds] 03:55 -!- k3tan [k3tan@gateway/vpn/protonvpn/k3tan] has joined #c-lightning 04:32 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-nfufoseoysnzgsxq] has left #c-lightning [] 04:32 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-nfufoseoysnzgsxq] has joined #c-lightning 05:31 <@cdecker> fiatjaf: the plugin runs as a subprocess attached to lightningd via stdin and stdout, so it'll get at least a SIGPIPE when lightningd gets killed 05:50 -!- Victor_sueca is now known as Victorsueca 06:04 < darosior> fiatjaf: The "plugins" structure is freed when exiting normally, since all plugins are tal-allocated upon it they would be freed too and the "plugin" struct has a destructor named "destroy_plugins" which will unregister the hooks. 06:07 -!- fiatjaf9 [bad761c1@186.215.97.193] has joined #c-lightning 06:08 < darosior> "struct plugins" freeing : https://github.com/ElementsProject/lightning/blob/61383408a45960bf7fd045fc420c95478de699c0/lightningd/lightningd.c#L873 ===> will free all children (each plugin) ===> "struct plugin" destroyer: https://github.com/ElementsProject/lightning/blob/61383408a45960bf7fd045fc420c95478de699c0/lightningd/plugin.c#L48 06:13 < fiatjaf9> but then what happens with HTLCs hanging at `htlc_accepted` plugins? 06:15 < fiatjaf9> oh, I guess they're sent again to the plugin when the node restarts 07:02 -!- fiatjaf9 [bad761c1@186.215.97.193] has quit [Remote host closed the connection] 07:55 < darosior> Hmm there was a bug about this that was recently patched, I'm not sure : HTLCs are given up when stopping, I think 08:02 <@cdecker> No, `lightningd` will replay the hook call, meaning you need to make the plugin handling it idempotent 08:03 <@cdecker> From the docs: Warning: lightningd will replay the HTLCs for which it doesn't have a final verdict during startup. This means that, if the plugin response wasn't processed before the HTLC was forwarded, failed, or resolved, then the plugin may see the same HTLC again during startup. It is therefore paramount that the plugin is idempotent if it talks to an external system. 08:05 <@cdecker> This was done because you might have already triggered an external action based on the first invocation, but just didn't have time to reply to the hook call. Since we don't know what your plugin might have done we let you decide what to do with the repeated call. 08:05 <@cdecker> The logic here is that if you mark a shopping cart in an external system as paid, you just look that state up and if it is marked as paid you can just accepted again :-) 08:12 -!- mdunnio [~mdunnio@38.126.31.226] has joined #c-lightning 08:29 -!- DC34 [46200049@70.32.0.73] has joined #c-lightning 08:39 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 09:47 -!- fiatjaf24 [bad761c1@186.215.97.193] has joined #c-lightning 09:50 < fiatjaf24> that solves it for me. best approach. 09:50 -!- fiatjaf24 [bad761c1@186.215.97.193] has quit [Remote host closed the connection] 09:57 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Quit: jb55] 10:01 <@cdecker> Excellent :+1: 10:12 -!- mdunnio [~mdunnio@38.126.31.226] has joined #c-lightning 10:44 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 240 seconds] 11:11 -!- mdunnio [~mdunnio@38.126.31.226] has joined #c-lightning 11:15 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 11:15 -!- mdunnio [~mdunnio@38.126.31.226] has joined #c-lightning 11:48 -!- MasterdonX [~masterdon@176.227.241.17] has quit [Ping timeout: 240 seconds] 11:50 -!- MasterdonX [~masterdon@185.195.202.198] has joined #c-lightning 11:57 -!- reallll [~belcher@unaffiliated/belcher] has joined #c-lightning 12:01 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds] 12:03 -!- reallll is now known as belcher 12:16 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #c-lightning 12:25 < sword_smith> I had two payments on the test net that failed if any one wants to have a look: https://pastebin.com/KC6npC9s 12:25 < sword_smith> Also: If anybody wants to try out my web wallet solution with LN and onchain solutions, they can have a look at: https://pilatus.io 12:26 < sword_smith> Email address is required for signup. 2FA is required if you want to handle non-testnet assets. 12:50 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-nfufoseoysnzgsxq] has left #c-lightning [] 12:50 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-nfufoseoysnzgsxq] has joined #c-lightning 14:22 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 14:23 -!- mdunnio [~mdunnio@38.126.31.226] has joined #c-lightning 14:42 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 15:53 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning 16:13 < fiatjaf> why do I have two HTLCs at state=RCVD_REMOVE_HTLC and expiry=600960 today? 16:13 < fiatjaf> block 600960 is way in the past 16:13 < fiatjaf> (I just noticed this while looking randomly at listpeers output) 16:14 < fiatjaf> both HTLCs are for 99 satoshi 17:20 -!- DC34 [46200049@70.32.0.73] has quit [Ping timeout: 260 seconds] 19:05 < rusty> fiatjaf: good q! 19:34 -!- instagibbs [~instagibb@pool-100-15-121-126.washdc.fios.verizon.net] has quit [Ping timeout: 268 seconds] 19:51 -!- cubancorona2 [~cubancoro@pool-72-77-31-161.pitbpa.ftas.verizon.net] has joined #c-lightning 19:54 -!- cubancorona [~cubancoro@pool-72-77-31-161.pitbpa.ftas.verizon.net] has quit [Ping timeout: 246 seconds] 20:08 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #c-lightning 20:08 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [Excess Flood] 20:09 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #c-lightning 20:11 -!- cubancorona [~cubancoro@pool-72-77-31-161.pitbpa.ftas.verizon.net] has joined #c-lightning 20:14 -!- cubancorona2 [~cubancoro@pool-72-77-31-161.pitbpa.ftas.verizon.net] has quit [Ping timeout: 276 seconds] 20:33 -!- k3tan172 [~k3tan@unaffiliated/k3tan] has joined #c-lightning 20:36 -!- k3tan [k3tan@gateway/vpn/protonvpn/k3tan] has quit [Ping timeout: 264 seconds] 20:38 -!- k3tan2 [k3tan@gateway/vpn/protonvpn/k3tan] has joined #c-lightning 20:41 -!- k3tan172 [~k3tan@unaffiliated/k3tan] has quit [Ping timeout: 265 seconds] 20:53 -!- cubancorona2 [~cubancoro@pool-72-77-31-161.pitbpa.ftas.verizon.net] has joined #c-lightning 20:55 -!- cubancorona [~cubancoro@pool-72-77-31-161.pitbpa.ftas.verizon.net] has quit [Ping timeout: 265 seconds] 21:15 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-nfufoseoysnzgsxq] has left #c-lightning [] 21:16 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-nfufoseoysnzgsxq] has joined #c-lightning 21:32 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Quit: WeeChat 2.6] 21:37 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #c-lightning 22:20 -!- instagibbs [~instagibb@pool-71-178-191-230.washdc.fios.verizon.net] has joined #c-lightning 22:31 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #c-lightning 22:34 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 276 seconds] 23:21 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Quit: Leaving.] 23:59 -!- k3tan [k3tan@gateway/vpn/protonvpn/k3tan] has joined #c-lightning --- Log closed Fri Nov 01 00:00:17 2019