--- Log opened Wed Jan 29 00:00:23 2020
00:29 < vasild> fiatjaf: to get mrkd on freebsd: https://github.com/ElementsProject/lightning/blame/master/doc/INSTALL.md#L147
00:50 < zmnscpxj> rusty/cdecker: are the updates to the data_version row of TABLE vars also sent in the db_write hook?  My reading says it is but want to confirm
01:02 -!- Amperture [~amp@65.79.129.113] has quit [Ping timeout: 246 seconds]
01:55 <@cdecker> zmnscpxj: I think they are, yes, let me check
01:57 <@cdecker> Yes, they are, just checked that with the backup plugin. And we also pass the current data_version along, so you can treat the SQL statements opaquely and don't have to look through them. 
01:57 < zmnscpxj> thx
01:58 <@cdecker> The idea is that we give a complete set of queries so that replaying them against a fresh DB repopulates the exact same DB (data-wise and schema-wise)
01:59 <@cdecker> There is one exception, and those are any connection level setup queries (sqlite3 uses PRAGMA to opt in to foreign keys). Those are not persisted and need to be passed in on each connection
02:13 -!- zmnscpxj [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has quit [Quit: Leaving]
02:32 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Remote host closed the connection]
03:05 -!- belcher [~belcher@unaffiliated/belcher] has joined #c-lightning
03:10 < darosior> niftynei: do you change funding transaction's nlocktime in your monster PR ? (I could just go read it but.. ^^)
03:10 < darosior> Just noticed we set it to 0 for withdraw and funding tx
03:11 < darosior> We could set it to tip+1
03:11 < darosior> Many benefits, no obvious drawbacks ?
03:26 <@cdecker> Could lead to very inscrutable errors if one of the nodes is lagging behind while funding (it'd be transitory, but still...)
03:38 -!- orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz...]
04:13 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-zkjjaoqsjfattawp] has left #c-lightning []
04:13 < darosior> How so ?
04:13 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-zkjjaoqsjfattawp] has joined #c-lightning
04:14 <@cdecker> If I am at height X and you are at height X+1 we will sign for different timelocks, and the signatures will mismatch. This can cause signature failures that are always hard to track down, since signatures are opaque to the observer
04:14 < darosior> Ah this doesnt seem to be a good idea for funding txs then
04:15 <@cdecker> Unless we also add a field to a  "I'm planning on signing this with height=X" I would suggest not to do it
04:15 < darosior> For `withdraw`, at least ?
04:20 -!- bitdex_ [~bitdex@gateway/tor-sasl/bitdex] has joined #c-lightning
04:22 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds]
04:23 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #c-lightning
04:29 <@cdecker> Sure, I'm not saying we shouldn't do it, but we should add enough information to facilitate eventually resulting issues :-)
05:30 -!- bitdex_ [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
05:37 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 248 seconds]
06:19 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Remote host closed the connection]
06:30 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection]
06:30 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #c-lightning
06:36 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #c-lightning
06:48 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #c-lightning
07:04 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 248 seconds]
07:16 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has joined #c-lightning
07:36 < darosior> Great, I'll PR my branch then :)
07:43 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz...]
07:45 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has joined #c-lightning
08:00 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz...]
08:02 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has joined #c-lightning
08:10 < darosior> though without adding it for funding transaction
08:16 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz...]
08:19 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has joined #c-lightning
08:34 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz...]
08:48 -!- dr-orlovsky [~dr-orlovs@194.230.147.122] has joined #c-lightning
08:54 -!- dr-orlovsky [~dr-orlovs@194.230.147.122] has quit [Quit: My MacBook has gone to sleep. ZZZzzz...]
09:08 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has joined #c-lightning
09:12 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds]
09:12 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has quit [Ping timeout: 265 seconds]
09:12 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has joined #c-lightning
09:13 -!- jonatack [~jon@213.152.161.170] has joined #c-lightning
10:10 <@cdecker> Yes, for funding we'd need to go through the spec process. Might be good to bring it up during the spec meeting or the spec repo
10:16 < darosior> Ok, will do
10:18 < darosior> Btw looks like I might shill C-lightning plugins a bit at LondonBitcoinDevs while I'm in London ^^
10:19 < darosior> Ah, don't know if it's worth an issue (I don't even know my peer implementation) but I got an announcement_signature after an unilateral close ...
11:01 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Remote host closed the connection]
11:40 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #c-lightning
11:43 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
11:53 -!- vasild_ is now known as vasild
12:09 <@niftynei> darosior, no i ended up not touching it for funding txs because if there is a reorg they'll get tossed out of the mempool instead of (ostensibly) reconfirmed 
12:09 <@niftynei> the desired behavior is that they persist and get re-included
12:10 <@niftynei> at least, that was my read
12:12 <@niftynei> hmm i should probably add a note about the locktime always being zero-value in the spec eh eh
12:12 -!- dr-orlovsky [~dr-orlovs@194.230.147.122] has joined #c-lightning
12:14 -!- orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has joined #c-lightning
12:14 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #c-lightning
12:15 <@niftynei> probably lnd with the announcment_sigs; last i knew their announcement sig machinery was logically separated so they have coordination issues around announcement sig relay occassionally
12:17 -!- dr-orlovsky [~dr-orlovs@194.230.147.122] has quit [Ping timeout: 265 seconds]
12:29 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-zkjjaoqsjfattawp] has left #c-lightning []
12:30 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-zkjjaoqsjfattawp] has joined #c-lightning
12:57 -!- jonatack [~jon@213.152.161.170] has quit [Ping timeout: 265 seconds]
13:49 <@niftynei> though, reasonably, if you solved the "which block" problem, you could do a locktime at tip-6
13:52 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has joined #c-lightning
13:53 -!- orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has quit [Ping timeout: 268 seconds]
13:54 <@niftynei> awesome to have this updated for withdrawals tho :+1:
14:03 -!- PaulTroon [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Read error: Connection reset by peer]
14:29 < darosior> :)
14:29 < darosior> "though, reasonably, if you solved the "which block" problem, you could do a locktime at tip-6" => Yep, but I wonder if the benefits are worse the adding complexity ?
14:31 < darosior> Anyway channel fundings may one day become undistinguishable from normal outputs, it seems :-)
14:31 < darosior> Hmm but having the locktime to 0 would break this
14:40 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has quit [Ping timeout: 265 seconds]
14:41 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has joined #c-lightning
15:17 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning
16:14 -!- treehug88 [~textual@pool-173-56-90-115.nycmny.fios.verizon.net] has quit [Ping timeout: 268 seconds]
16:32 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has quit [Ping timeout: 265 seconds]
16:53 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]
17:05 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #c-lightning
17:12 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has joined #c-lightning
18:33 -!- zmnscpxj [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has joined #c-lightning
19:19 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #c-lightning
19:44 -!- achow101 [~achow101@unaffiliated/achow101] has quit [Ping timeout: 265 seconds]
19:48 -!- achow101 [~achow101@unaffiliated/achow101] has joined #c-lightning
20:48 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds]
20:49 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-zkjjaoqsjfattawp] has left #c-lightning []
20:49 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-zkjjaoqsjfattawp] has joined #c-lightning
20:50 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #c-lightning
21:44 -!- zmnscpxj [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has quit [Quit: Leaving]
22:37 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Quit: Leaving.]
23:40 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #c-lightning
23:43 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
23:51 -!- vasild_ is now known as vasild
--- Log closed Thu Jan 30 00:00:24 2020