--- Log opened Fri Mar 13 00:00:24 2020
00:40 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #c-lightning
00:44 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
00:44 -!- vasild_ is now known as vasild
01:00 < m-schmoock> is there a reason not to have lightning-rfc as a submodule to make bolt checks not go one dir outside?  BOLTDIR := ../lightning-rfc/
01:41 -!- Amperture [~amp@65.79.129.113] has joined #c-lightning
02:01 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-zkjjaoqsjfattawp] has left #c-lightning []
02:01 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-zkjjaoqsjfattawp] has joined #c-lightning
03:36 -!- lxer [~lx@ip5f5bf497.dynamic.kabel-deutschland.de] has joined #c-lightning
04:53 < m-schmoock> cdecker: rewriting those edgy case tests will be difficult, as I would move all the commit fee calculations into python
05:14 -!- belcher [~belcher@unaffiliated/belcher] has joined #c-lightning
05:27 <@cdecker> Agreed, but we could switch to something that captures change instead of looking for specific (internally computed) values
05:27 <@cdecker> Anyway, that's likely out of scope, so if you fix up the tests we can merge it :-)
05:34 < m-schmoock> already did
05:35 < m-schmoock> we could off er a JSON RPC api that exposes useful parts of the tx fee calculations via API, then we could re-use them in the test
05:36 < m-schmoock> liek a RPC call `ln-cli  calcfee scid [feerate] [htlc_in] [htlc_out]`
05:37 < m-schmoock> dunno exactly, something that does all the REMOTE/LOCAL tx size, current htlcs ... stuff
05:42 -!- Maitor [~goban@gateway/tor-sasl/maitor] has quit [Remote host closed the connection]
05:43 -!- Maitor [~goban@gateway/tor-sasl/maitor] has joined #c-lightning
05:49 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
06:04 -!- Maitor_ [~goban@gateway/tor-sasl/maitor] has joined #c-lightning
06:05 -!- Maitor [~goban@gateway/tor-sasl/maitor] has quit [Remote host closed the connection]
06:09 <@cdecker> That'd be cool, but I'm scared by the amount of prop drilling I'm having to do for the watchtower (tracking commit_tx outputs and handing it to the penalty tx) I can only imagine how many layers of function calls we'd need to drill through to get to the fee estimation for example
06:09 <@cdecker> But it may be worth taking a closer look
06:10 -!- mdunnio [~mdunnio@208.59.170.5] has joined #c-lightning
06:10 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection]
06:44 -!- gojiHmPFPN [~textual@c-73-47-220-190.hsd1.ma.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
07:29 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has quit [Quit: Leaving]
09:25 -!- gojiHmPFPN [~textual@c-73-47-220-190.hsd1.ma.comcast.net] has joined #c-lightning
09:38 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds]
10:33 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-zkjjaoqsjfattawp] has left #c-lightning []
10:33 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-zkjjaoqsjfattawp] has joined #c-lightning
10:38 <@niftynei> regarding versioning and plugins, we already expose the lightningd version via an environment variable, so really the only surface area that 'needs a version' would be the RPC commands
10:39 <@niftynei> i think this is probably ok though, given that the breaking json format changes have all been plugin related (changing the format of acceptable hook response; collapsing nesting on rpc_command hook payload etc)
10:40 <@niftynei> as cdecker pointed out, rpc's tend to add fields rather than remove them anyway which is mostly fine
10:40 <@niftynei> as rusty points out, we can always hit up getinfo for the version, also (or listconfigs.. one of them has it)
10:41 <@niftynei> this is easy enough to do during startup when you're attaching to an rpc file
10:42 <@niftynei> which is to say, i think we're well covered on the versioning question, as far as major versions are concerned
10:43 <@niftynei> tangentially it'd be nice to have better docs for RPC responses and plugin hook payloads but that's secondary, me thinks
10:45 -!- berndj [~berndj@azna.co.za] has quit [Ping timeout: 260 seconds]
10:50 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 272 seconds]
10:51 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #c-lightning
11:27 -!- berndj [~berndj@azna.co.za] has joined #c-lightning
12:41 -!- Maitor_ [~goban@gateway/tor-sasl/maitor] has quit [Remote host closed the connection]
12:42 -!- Maitor_ [~goban@gateway/tor-sasl/maitor] has joined #c-lightning
12:43 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
12:45 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #c-lightning
15:10 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #c-lightning
15:34 -!- zmnscpxj [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has joined #c-lightning
16:00 -!- zmnscpxj [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has quit [Remote host closed the connection]
16:01 -!- zmnscpxj [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has joined #c-lightning
16:25 -!- gojiHmPFPN [~textual@c-73-47-220-190.hsd1.ma.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
16:55 -!- lxer [~lx@ip5f5bf497.dynamic.kabel-deutschland.de] has quit [Ping timeout: 265 seconds]
16:56 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds]
16:59 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Quit: jonatack]
17:10 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #c-lightning
17:11 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
17:17 -!- mdunnio [~mdunnio@208.59.170.5] has joined #c-lightning
17:22 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 240 seconds]
17:29 -!- qubenix_ [~qubenix@66.172.11.228] has joined #c-lightning
17:31 -!- berndj-blackout [~berndj@azna.co.za] has joined #c-lightning
17:34 -!- Amperture [~amp@65.79.129.113] has quit [Remote host closed the connection]
17:34 -!- qubenix [~qubenix@66.172.11.228] has quit [Ping timeout: 240 seconds]
17:34 -!- berndj [~berndj@azna.co.za] has quit [Ping timeout: 240 seconds]
17:34 -!- ysangkok [janus@anubis.0x90.dk] has quit [Ping timeout: 240 seconds]
17:34 -!- qubenix_ is now known as qubenix
17:34 -!- berndj-blackout is now known as berndj
17:56 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #c-lightning
18:01 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #c-lightning
18:05 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Read error: Connection reset by peer]
18:21 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #c-lightning
18:42 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #c-lightning
18:44 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]
18:49 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-zkjjaoqsjfattawp] has left #c-lightning []
18:49 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-zkjjaoqsjfattawp] has joined #c-lightning
19:07 -!- zmnscpxj [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has quit [Ping timeout: 240 seconds]
19:20 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #c-lightning
19:51 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds]
20:19 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #c-lightning
20:24 -!- adam3us_ [~adam3us@unaffiliated/adam3us] has joined #c-lightning
20:28 -!- rotarydialer [~rotarydia@unaffiliated/rotarydialer] has joined #c-lightning
20:28 -!- Netsplit *.net <-> *.split quits: Victorsueca, rotarydialer_, adam3us, CubicEarth
20:37 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #c-lightning
20:39 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning
20:49 -!- mdunnio [~mdunnio@208.59.170.5] has joined #c-lightning
20:54 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 268 seconds]
21:49 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
22:51 -!- asoltys [~root@s207-81-214-2.bc.hsia.telus.net] has quit [Ping timeout: 260 seconds]
--- Log closed Sat Mar 14 00:00:22 2020