--- Log opened Thu Mar 19 00:00:27 2020
00:43 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
00:45 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #c-lightning
00:53 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
00:53 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has joined #c-lightning
01:09 -!- RubenSomsen [sid301948@gateway/web/irccloud.com/x-rxsqyqzqlochhjhg] has quit [Ping timeout: 272 seconds]
01:10 -!- RubenSomsen [sid301948@gateway/web/irccloud.com/x-hgfqzsfqbyclkema] has joined #c-lightning
01:37 < m-schmoock> cdecker: whats your opinion on this? https://github.com/ElementsProject/lightning/pull/3589#discussion_r392914977   currently we cant have a "BOLT #2" comment here, because its upcoming. The make check-source-bolt fails
02:04 -!- kexkey [~kexkey@217.138.200.221] has quit [Ping timeout: 250 seconds]
02:10 < m-schmoock> I extraced the doc STYLE cleanup commit in a seperate commit. Addressed all remarks, except the LOCAL/REMOTE thing which Im now thinking about...
02:10 < m-schmoock> https://github.com/ElementsProject/lightning/pull/3598   if someone just wants to click merge ;)
02:22 <@cdecker> m-schmoock: rusty uses a special syntax, which includes the commit in the BOLT repo something was introduced: /* BOLT-4e228a7fb4ea78af914d1ce82a63cbce8026279e #11 */
02:24 <@cdecker> That allows us to later go through and arm the checker in a cleanup once the PRs in the spec repo are merged
03:50 < m-schmoock> thx! :D didnt know that
03:50 < m-schmoock> will do
04:13 <@cdecker> I only remembered because I've seen them during reviews, I don't think it's something we've written down anywhere
05:26 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
05:28 < m-schmoock> cdecker: updated the feespike *2 pr  https://github.com/ElementsProject/lightning/pull/3589
05:37 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-txhnryyccoeyadae] has left #c-lightning []
05:38 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-txhnryyccoeyadae] has joined #c-lightning
06:42 <@cdecker> Let me check your branch against elements to see if the slack changes don't cause issues, otherwise the PR looks good :+1:
06:44 < m-schmoock> o/
07:03 -!- Amperture [~amp@65.79.129.113] has joined #c-lightning
07:10 <@cdecker> Yep, got two minor conflicts with my `cleanups` branch (PR #3568), but no worries, they are easy to re-apply. So far no new failing tests :-)
07:13 -!- instagibbs [~instagibb@pool-71-178-191-230.washdc.fios.verizon.net] has quit [Read error: Connection reset by peer]
07:29 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds]
07:47 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #c-lightning
07:49 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #c-lightning
08:39 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 265 seconds]
08:42 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #c-lightning
09:35 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #c-lightning
09:46 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
09:47 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #c-lightning
10:10 -!- treehug88 [~textual@pool-71-105-170-196.nycmny.fios.verizon.net] has joined #c-lightning
10:40 < m-schmoock> cdecker: do I need to do any changes?
10:40 < m-schmoock> but I can wait until PR #3568 is merged
10:43 <@cdecker> Nah, either can go first, no need to make things complicated.
10:43 <@cdecker> Let me look it over one last time, and then I'll merge yours, since it doesn't break anything new and the `cleanups` branch is easily rebased on top of yours
10:44 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection timed out]
10:46 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #c-lightning
10:53 < m-schmoock> okay, I can refactor all the LOCAL/THEIRS duplication afterwards as well. as you like
10:53 < m-schmoock> dont really care :D
10:54 <@cdecker> That'd be great yes :+1:
10:54 <@cdecker> Great, I just found out my review wasn't submitted the last time. Just had one comment, but still...
10:59 < m-schmoock> :D
11:00 -!- michaelfolkson [~textual@host86-132-64-99.range86-132.btcentralplus.com] has joined #c-lightning
11:00 -!- michaelfolkson [~textual@host86-132-64-99.range86-132.btcentralplus.com] has quit [Remote host closed the connection]
12:05 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has joined #c-lightning
12:05 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds]
12:17 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
12:18 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #c-lightning
12:44 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
12:45 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #c-lightning
13:12 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
13:13 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #c-lightning
13:49 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-txhnryyccoeyadae] has left #c-lightning []
13:50 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-txhnryyccoeyadae] has joined #c-lightning
13:50 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 250 seconds]
14:25 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
14:26 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #c-lightning
15:48 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #c-lightning
16:03 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
16:04 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #c-lightning
16:51 -!- zmnscpxj [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has joined #c-lightning
17:00 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
17:01 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #c-lightning
17:03 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
17:03 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #c-lightning
17:45 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-txhnryyccoeyadae] has left #c-lightning []
17:45 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-txhnryyccoeyadae] has joined #c-lightning
17:55 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-txhnryyccoeyadae] has left #c-lightning []
17:56 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-txhnryyccoeyadae] has joined #c-lightning
19:35 -!- zmnscpxj [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has quit [Remote host closed the connection]
19:35 -!- zmnscpxj [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has joined #c-lightning
19:50 -!- fiatjaf [~fiatjaf@2804:7f2:2981:26c1:ea40:f2ff:fe85:d2dc] has joined #c-lightning
19:54 -!- zmnscpxj [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has quit [Ping timeout: 240 seconds]
20:57 -!- zmnscpxj [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has joined #c-lightning
20:58 -!- Amperture [~amp@65.79.129.113] has quit [Remote host closed the connection]
21:08 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds]
22:06 -!- treehug88 [~textual@pool-71-105-170-196.nycmny.fios.verizon.net] has quit [Ping timeout: 264 seconds]
22:21 -!- afk11` [~afk11@gateway/tor-sasl/afk11] has quit [Remote host closed the connection]
22:21 -!- afk11` [~afk11@gateway/tor-sasl/afk11] has joined #c-lightning
22:30 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
22:31 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #c-lightning
--- Log closed Fri Mar 20 00:00:28 2020