--- Log opened Wed Aug 12 00:00:48 2020
00:05 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #c-lightning
00:05 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
00:46 -!- vincenzopalazzo [~vincent@host-95-246-119-127.retail.telecomitalia.it] has quit [Remote host closed the connection]
00:50 -!- jonatack [~jon@192.113.14.109.rev.sfr.net] has joined #c-lightning
01:08 -!- midnight [~midnight@unaffiliated/midnightmagic] has quit [Ping timeout: 244 seconds]
01:11 -!- midnight [~midnight@unaffiliated/midnightmagic] has joined #c-lightning
01:13 -!- vincenzopalazzo [~vincent@host-95-246-119-127.retail.telecomitalia.it] has joined #c-lightning
01:41 < vincenzopalazzo> Hi guys I question about this PR https://github.com/ElementsProject/lightning/pull/3929
01:43 < vincenzopalazzo> Why is not possible bind two onion address (in this cases)? I response such as an array inside getinfo, bring me to think that is possible have more address where bind the node
02:07 -!- rotarydialer [~rotarydia@unaffiliated/rotarydialer] has quit [Ping timeout: 245 seconds]
02:11 -!- rotarydialer [~rotarydia@unaffiliated/rotarydialer] has joined #c-lightning
02:20 < darosior> fiatjaf1: Just send a PR :)
02:49 -!- reallll [~belcher@unaffiliated/belcher] has joined #c-lightning
02:53 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Ping timeout: 265 seconds]
02:57 < darosior> vincenzopalazzo: i think that's wrong i'm pretty sure you can specify bind-addr= multiple times
02:58 < darosior> Ok just checked the manpage and effectively you cna This option can be used multiple times to add more addresses, and
02:58 < darosior>               its use disables autolisten.  If necessary, and 'always-use-proxy'
02:58 < darosior>               is not specified, a DNS lookup may be done to resolve 'IPADDRESS'
02:59 < darosior> Also, you don't bind to an onion service..
03:55 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #c-lightning
03:58 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
03:58 -!- vasild_ is now known as vasild
04:10 < shesek> fiatjaf1, this should only have an effect when amount_msat is unknown, but it is known in my case
04:11 -!- jonatack [~jon@192.113.14.109.rev.sfr.net] has quit [Ping timeout: 260 seconds]
04:12 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-xadswhvwruqyrqgr] has left #c-lightning []
04:12 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-xadswhvwruqyrqgr] has joined #c-lightning
04:46 < vincenzopalazzo> darosior: Thanks for the feedback :-)
05:41 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #c-lightning
06:46 -!- mdunnio [~mdunnio@208.59.170.5] has joined #c-lightning
06:59 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection]
07:31 -!- jonatack [~jon@37.164.92.255] has joined #c-lightning
07:36 -!- jonatack [~jon@37.164.92.255] has quit [Ping timeout: 256 seconds]
07:40 -!- jonatack [~jon@213.152.161.211] has joined #c-lightning
08:11 -!- liberliver [~Thunderbi@144.49.211.130.bc.googleusercontent.com] has quit [Quit: liberliver]
08:15 -!- jonatack [~jon@213.152.161.211] has quit [Ping timeout: 256 seconds]
08:23 -!- zmnscpxj_ [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has joined #c-lightning
08:30 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
08:41 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #c-lightning
08:53 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #c-lightning
09:58 -!- sr_gi [~sr_gi@static-144-88-225-77.ipcom.comunitel.net] has quit [Read error: Connection reset by peer]
09:59 -!- sr_gi [~sr_gi@static-144-88-225-77.ipcom.comunitel.net] has joined #c-lightning
10:01 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #c-lightning
10:25 < shesek> I think I found the issue that I was running into (or rather, accidentally stumbled into it): https://github.com/ElementsProject/lightning/pull/3881 ("Annotate payments initiated using sendonion with the amount at the destination")
10:26 < shesek> I also see that amount_msat is not guaranteed to be available, I'll add amount_sent_msat as a fallback
10:28 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Remote host closed the connection]
10:30 < shesek> though I'm not exactly sure how to display it. spark currently displays the amount received at the destination in the home feed, with fees shown separately when toggling details. I guess payments without amount_msat would have to show the amount+fees as the main amount, and without a fee?
10:31 < shesek> or maybe better to show "Fee: unknown" rather than showing 0 or not mentioning fees at all?
10:45 < shesek> also, maybe it should always show the amount+fees as the main amount? this is how I initially implemented this, but its kinda weird UX wise because users have a tendency to sent round amounts (so they send 10 millis, and the next screen shows 10.0084311 millis instead...). but the UX might be even weirder if its mixed up, sometimes includes the fee and sometimes not
10:45 < shesek> otoh, payments without amount_msat should be pretty rare for the typical user
10:45 < zmnscpxj_> show three columns: amount, fee, amount+fee
10:46 < zmnscpxj_> For those without amount-at-destination, show "fee unknown" and leave amount blank
10:46 < zmnscpxj_> seems OK?
10:46 < shesek> the main home screen, before the user clicks to toggle more details, should definitely display just one amount. so I'll at least have to figure out what to use there
10:47 < zmnscpxj_> Hmm
10:47 < zmnscpxj_> well that *is* an issue
10:47 < zmnscpxj_> I would say amount+fee is more important, but I am the sort of person who is more concerned with what I spend
10:47 < shesek> under details, it could show all three, though it might be somewhat redundant
10:47 < zmnscpxj_> besides Electrum displays amount+fee for its history tab
10:47 < zmnscpxj_> for onchain txes
10:49 < shesek> another consideration I had is that lightning fees are typically tiny, so it maybe makes more sense to exclude them compared to onchain payments
10:50 < zmnscpxj_> *shrug* well our default fee budget is 0.5%, and MPP and route randomization will start to increase our consumption of the fee budget at some point in the future
10:50 < shesek> oh, I actually just remembered that I made it include the fee in the main amount if its >0.5% of the total amount
10:51 < zmnscpxj_> haha
10:51 < shesek> or in other words, it only hides fees of <=0.5%
10:51 < shesek> ... which may be pretty confusing on its own, lol
10:51 < zmnscpxj_> yah
10:51 < shesek> I'm no so sure if this was the right call
10:51 < zmnscpxj_> just go amount+fee
10:52 < zmnscpxj_> you could have a hover that breaks it down to "paid: ###, fee: ###" for normal payments
10:54 < shesek> I guess I'll go with that, I'll just have to live with the UI being somewhat uglier because amounts are never round >_<
10:58 < shesek> oh I actually misremembered, the <0.05% thing is for incoming payments, to hide the overpayment randomization which may be confusing to users. outgoing payments always show the fee-less amount as the main amount
11:00 < shesek> (and the overpayment is then displayed separately when toggling details)
11:00 < zmnscpxj_> haha
11:01 < shesek> would you keep that or do you deem it confusing too?
11:01 < zmnscpxj_> who was the person who implemented overpaying anyway??? lnd even had a bug since they did not support overpayment.... grumble grumble
11:01  * zmnscpxj_ sneaks off before somebody points out it was zmnscpxj who did
11:02 < zmnscpxj_> I would personally go for complete honesty at default and just show overpayments as well
11:03 < zmnscpxj_> but that may be my personal preference only
11:03 < zmnscpxj_> hard decision....
11:07 < shesek> maybe I could show the fee-less amount in bitcoins plus the fee as a percentage, i.e. "1000 sat (+0.01% fee)", with the fee part in a smaller font and lighter color. or when the fee is unknown, just the total as "1010 sat"
11:08 < shesek> I'm not sure it'll fit in when the bitcoin amount is long though
11:12 -!- Galvas_ [uid459296@gateway/web/irccloud.com/x-oradxrfemdnderpm] has joined #c-lightning
11:20 -!- Netsplit *.net <-> *.split quits: Galvas, blockstream_bot
11:20 -!- Galvas_ is now known as Galvas
11:59 -!- PaulTro__ [~paultroon@86.106.121.169] has joined #c-lightning
12:00 -!- liberliver [~Thunderbi@144.49.211.130.bc.googleusercontent.com] has joined #c-lightning
12:04 -!- liberliver [~Thunderbi@144.49.211.130.bc.googleusercontent.com] has quit [Client Quit]
12:22 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-pkelupxjrwzldmme] has joined #c-lightning
13:42 -!- PaulTro__ [~paultroon@86.106.121.169] has quit [Remote host closed the connection]
14:32 -!- vincenzopalazzo [~vincent@host-95-246-119-127.retail.telecomitalia.it] has quit [Remote host closed the connection]
15:31 -!- fiatjaf1 [~fiatjaf@2804:7f2:2a82:90a5:ea40:f2ff:fe85:d2dc] has quit [Ping timeout: 260 seconds]
15:31 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #c-lightning
15:58 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
16:00 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #c-lightning
16:00 -!- reallll is now known as belcher
16:01 -!- mdunnio [~mdunnio@208.59.170.5] has joined #c-lightning
16:06 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 240 seconds]
16:51 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Remote host closed the connection]
17:29 -!- fiatjaf [~fiatjaf@2804:7f2:2a82:90a5:ea40:f2ff:fe85:d2dc] has joined #c-lightning
17:56 -!- Teoti [~teoti@167.88.20.6] has joined #c-lightning
18:44 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning
19:19 -!- mdunnio [~mdunnio@208.59.170.5] has joined #c-lightning
19:24 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 256 seconds]
19:32 -!- teotikalki [~teoti@216.154.61.220] has joined #c-lightning
19:34 -!- Teoti [~teoti@167.88.20.6] has quit [Ping timeout: 264 seconds]
19:44 -!- zmnscpxj_ [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has quit [Ping timeout: 240 seconds]
19:49 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #c-lightning
20:19 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 244 seconds]
20:38 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-pkelupxjrwzldmme] has left #c-lightning []
20:38 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-pkelupxjrwzldmme] has joined #c-lightning
20:46 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #c-lightning
21:46 -!- PaulTroo_ [~paultroon@86.106.121.169] has joined #c-lightning
21:51 -!- PaulTroo_ [~paultroon@86.106.121.169] has quit [Ping timeout: 256 seconds]
22:05 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection]
22:28 -!- mdunnio [~mdunnio@208.59.170.5] has joined #c-lightning
22:33 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 256 seconds]
23:33 -!- PaulTroo_ [~paultroon@86.106.121.169] has joined #c-lightning
--- Log closed Thu Aug 13 00:00:48 2020