--- Log opened Fri Dec 11 00:00:43 2020 00:49 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds] 00:57 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #c-lightning 01:24 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-grtgkzfemgwjcvcq] has left #c-lightning [] 01:24 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-grtgkzfemgwjcvcq] has joined #c-lightning 01:53 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds] 01:57 < m-schmoock> cdecker: while your already at merging open but done backup plugin PRs: https://github.com/lightningd/plugins/pull/169 01:57 <@cdecker> Will check next :-) 02:01 <@cdecker> Hm, why didn't I merge this way earlier? I already acked it 02:01 < m-schmoock> dunno ^^ 02:02 <@cdecker> m-schmoock, would you like to become a maintainer of the repo? That way I'm less of a bottleneck, and you've definitely proven yourself ^^ 02:03 < m-schmoock> thanks, I would apprechiate that <3 02:04 < m-schmoock> Also I updated this petty msat PR discussion https://github.com/ElementsProject/lightning/pull/4273 I think we can live with some optimizations here and there like this. But your proposal to go for an internal Decimal and just return int value on to_str and to_json seems the right approach mid-term 02:05 -!- kexkey_ [~kexkey@static-198-54-132-93.cust.tzulo.com] has quit [Ping timeout: 260 seconds] 02:07 < m-schmoock> I really try to make all basics and the plugins more usable for a broader audience. Stuff broke too often here and there... 02:07 <@cdecker> You're now a made man :+1: (imagine thick italian mafioso accent) 02:07 < m-schmoock> hehe 02:08 < m-schmoock> I think I have been maintainer in the plugin repo in the past but got inactive after a while 02:08 <@cdecker> Agree on making the Millisatoshi class more useful ^^ 02:08 < m-schmoock> It needs to be. Otherwise all the plugins will simply look like a bad compilation of int() casts :D 02:09 <@cdecker> Could be that I adjusted the community-organizer role a bit at some point, sorry if that meant an unintended drop in privileges 02:10 <@cdecker> Yeah, totally tbh I find the msat JSON decoding a bit inelegant, but can't come up with anything more elegant :-) 02:10 < m-schmoock> no probs, I got disctracted with real world stuff back then 02:10 <@cdecker> pff, real world, that's got really low graphics.... 02:10 < m-schmoock> and the plot sucks 02:11 < m-schmoock> got even worse in 2020 :D 02:12 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #c-lightning 02:17 <@cdecker> Yeah, it's a pretty bad sequel to the previous iterations, there's really no story at all 02:30 -!- cryptosoap [~cryptosoa@gateway/tor-sasl/cryptosoap] has quit [Remote host closed the connection] 02:31 -!- cryptosoap [~cryptosoa@gateway/tor-sasl/cryptosoap] has joined #c-lightning 03:01 -!- belcher [~belcher@unaffiliated/belcher] has joined #c-lightning 03:12 < darosior> +1 for the Millisatoshi class. I've always fallen back to using int(). 03:38 < m-schmoock> This basic stuff needs to be as precise and convinient as possible, otherwise people will always work around 03:40 < darosior> Saw your ping on the feeadjuster PR, doing a lightningd/plugins round now :) 03:41 <@cdecker> Great 👍 04:12 < darosior> Arf "plugin-jitrebalance.py: Killing plugin: Received a JSON-RPC response for non-existent request" 04:13 < darosior> I can know if the JIT plugin crashed just by looking at my grafana profitability stats :p 04:16 <@cdecker> rofl, fwiw I have a duplicate-result-detection in pyln-client, but I should probably release it 04:17 <@cdecker> That way the plugin logs an exception (detailing where the result was first returned), but doesn't get killed anymore 04:17 <@cdecker> Lemme release the 0.9.2 version of pyln-client 04:20 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #c-lightning 04:22 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 04:22 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Read error: Connection reset by peer] 04:22 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has joined #c-lightning 04:22 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Quit: ZNC 1.8.1 - https://znc.in] 04:22 -!- cryptosoap [~cryptosoa@gateway/tor-sasl/cryptosoap] has quit [Quit: %bye%] 04:22 -!- mryandao_ [~mryandao@gateway/tor-sasl/mryandao] has joined #c-lightning 04:22 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has joined #c-lightning 04:22 -!- cryptosoap [~cryptosoa@gateway/tor-sasl/cryptosoap] has joined #c-lightning 04:23 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 240 seconds] 04:28 < darosior> Nice, thanks :) 04:38 < darosior> So as the prophecy foretold we start having Python plugins relying on each other ^^ https://github.com/lightningd/plugins/pull/175/files#diff-f13435ce31ae725df2bdecbcd168de5b302a2091c48bf3de8f702382e9270e52R326-R331 04:55 <@cdecker> Ok, v0.9.2 of pyln-{client,proto,testing} uploaded 04:58 <@cdecker> And this is the place we protect against duplicate results: https://github.com/ElementsProject/lightning/blob/1ca2c66c540f0f917775b1ebc2634876a3437ca0/contrib/pyln-client/pyln/client/plugin.py#L89-L103 05:10 -!- liberliver [~Thunderbi@144.49.211.130.bc.googleusercontent.com] has quit [Quit: liberliver] 05:35 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #c-lightning 05:35 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services] 05:35 -!- vasild_ is now known as vasild 05:39 -!- vincenzopalazzo [~vincent@2001:b07:6474:9d49:849d:db24:7f93:fb8a] has joined #c-lightning 05:52 -!- liberliver [~Thunderbi@144.49.211.130.bc.googleusercontent.com] has joined #c-lightning 06:24 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds] 07:14 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has quit [Read error: Connection reset by peer] 07:14 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has joined #c-lightning 07:46 -!- liberliver [~Thunderbi@144.49.211.130.bc.googleusercontent.com] has quit [Quit: liberliver] 07:53 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 272 seconds] 07:56 -!- reallll [~belcher@unaffiliated/belcher] has joined #c-lightning 08:00 -!- reallll is now known as belcher 08:01 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #c-lightning 08:25 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 08:27 < m-schmoock> cdecker: wouldn't it have been better to wait with the pyln client update until we have #4273 done? 08:27 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #c-lightning 08:27 <@cdecker> Not really, to be consistent with the repo I actually went back to the v0.9.2 tag and released that 08:28 <@cdecker> Makes it way easier to match up the repo with the version 08:28 <@cdecker> No worries though, the next release is due in a month 08:28 < m-schmoock> Ah ok. Regarding #4273 : I would agree to remove the __init__(float) for now and bring that into discussion when we do the internal Decimal thingy. Ok ? Then I will make a quick cleanup on the remaning nits to get this forward 08:30 < m-schmoock> Having Millisatoshi(2/5) has pros regarding consitency (because this will be done internally anyway) and cons regarding safety which I also see ... hard choice 08:32 < m-schmoock> GitHub dark mode is soooo nice :D 08:32 < m-schmoock> no eyes bleeding anymore 08:37 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 08:37 <@cdecker> Sounds good to me ^^ 08:37 * cdecker tries dark mode as well 08:55 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Ping timeout: 256 seconds] 09:09 < m-schmoock> cdecker: I updated PR #4273 . Now without the init by float, and added a check for that its not allowed. Fixed the other nits... 09:13 -!- alko89 [~alko89@unaffiliated/alko89] has quit [Quit: ZNC 1.7.5 - https://znc.in] 09:14 -!- alko89 [~alko89@unaffiliated/alko89] has joined #c-lightning 09:15 < m-schmoock> rebased to current master. CI seemed unhappy for other non related reasons. maybe fixed by rebase 09:23 < m-schmoock> cdecker: CI has troubles linking the binaries: home/travis/build/ElementsProject/lightning/bitcoin/signature.c:360: undefined reference to `fromwire_u8_array' 09:24 < m-schmoock> collect2: error: ld returned 1 exit status 09:24 < m-schmoock> see all fails on https://travis-ci.org/github/ElementsProject/lightning/builds/749102955 09:34 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #c-lightning 09:54 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-grtgkzfemgwjcvcq] has left #c-lightning [] 09:54 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-grtgkzfemgwjcvcq] has joined #c-lightning 10:00 <@cdecker> Interesting, seems some mocks broke in a weird way 10:00 <@cdecker> Will fix asap 10:03 <@cdecker> That's what I get for merging without rebase-testing it first ^^ 10:04 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 10:04 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #c-lightning 10:26 -!- jonatack [~jon@213.152.186.40] has quit [Ping timeout: 240 seconds] 10:30 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #c-lightning 10:34 -!- kexkey [~kexkey@static-198-54-132-158.cust.tzulo.com] has joined #c-lightning 10:35 <@cdecker> PR filed, can you ACK once it passes CI? Not before though, since I might need to dive in again 10:35 <@cdecker> Will ping you here once it's done 10:45 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 10:46 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #c-lightning 10:50 -!- jonatack [~jon@37.170.61.94] has joined #c-lightning 11:03 -!- jonatack [~jon@37.170.61.94] has quit [Read error: Connection reset by peer] 11:26 -!- jonatack [~jon@213.152.161.244] has joined #c-lightning 12:15 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds] 12:21 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #c-lightning 12:28 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 272 seconds] 12:44 -!- belcher [~belcher@unaffiliated/belcher] has joined #c-lightning 13:10 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds] 13:12 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #c-lightning 13:13 -!- liberliver [~Thunderbi@144.49.211.130.bc.googleusercontent.com] has joined #c-lightning 13:13 -!- liberliver [~Thunderbi@144.49.211.130.bc.googleusercontent.com] has quit [Client Quit] 13:33 < m-schmoock> cdecker: thx, the CI is running again 13:33 < m-schmoock> gn8 ... 13:36 -!- vincenzopalazzo [~vincent@2001:b07:6474:9d49:849d:db24:7f93:fb8a] has quit [Quit: Leaving] 13:51 -!- HelloShitty [~psysc0rpi@bl20-171-222.dsl.telepac.pt] has quit [Ping timeout: 258 seconds] 13:52 -!- HelloShitty [~psysc0rpi@bl20-171-222.dsl.telepac.pt] has joined #c-lightning 15:59 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 16:06 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 17:00 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #c-lightning 17:39 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 17:40 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #c-lightning 18:07 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-grtgkzfemgwjcvcq] has left #c-lightning [] 18:07 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-grtgkzfemgwjcvcq] has joined #c-lightning 19:46 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning 19:53 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Quit: Leaving.] 20:10 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning 20:38 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-grtgkzfemgwjcvcq] has left #c-lightning [] 20:38 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-grtgkzfemgwjcvcq] has joined #c-lightning 21:36 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-grtgkzfemgwjcvcq] has left #c-lightning [] 21:36 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-grtgkzfemgwjcvcq] has joined #c-lightning 21:40 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Ping timeout: 260 seconds] 23:26 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 23:26 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has joined #c-lightning 23:46 -!- alko89 [~alko89@unaffiliated/alko89] has quit [Quit: ZNC 1.7.5 - https://znc.in] 23:46 -!- alko89 [~alko89@unaffiliated/alko89] has joined #c-lightning 23:51 -!- alko89 [~alko89@unaffiliated/alko89] has quit [Client Quit] 23:51 -!- alko89 [~alko89@unaffiliated/alko89] has joined #c-lightning 23:56 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has quit [Read error: Connection reset by peer] 23:56 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has joined #c-lightning --- Log closed Sat Dec 12 00:00:44 2020