--- Log opened Thu Nov 24 00:00:26 2022
00:07 -!- NorrinRadd [~me@188.215.95.113] has joined #c-lightning
01:00 -!- openoms[m] [~openomsma@2001:470:69fc:105::c2f] has quit [Quit: You have been kicked for being idle]
01:03 -!- jarthur [~jarthur@user/jarthur] has quit [Quit: jarthur]
02:05 -!- opsec_x1222 [~opsec_x12@44-25-143-46.ip.hamwan.net] has joined #c-lightning
02:05 -!- opsec_x122 [~opsec_x12@44-25-143-46.ip.hamwan.net] has quit [Remote host closed the connection]
04:22 -!- NorrinRadd [~me@188.215.95.113] has quit [Ping timeout: 246 seconds]
04:47 -!- rusty [~rusty@115-166-20-247.tpgi.com.au] has joined #c-lightning
05:16 -!- rusty [~rusty@115-166-20-247.tpgi.com.au] has left #c-lightning []
07:16 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #c-lightning
07:46 -!- jonatack1 [~jonatack@user/jonatack] has joined #c-lightning
07:48 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 268 seconds]
08:08 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection]
08:12 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #c-lightning
08:38 -!- kexkey [~kexkey@static-198-54-132-142.cust.tzulo.com] has quit [Ping timeout: 268 seconds]
08:39 -!- kexkey [~kexkey@static-198-54-132-136.cust.tzulo.com] has joined #c-lightning
08:54 < cdecker[m]> Just one more question: I am wondering since we run DDL statements (and therefore the migrations) in a transaction, I think postgres would likely roll back all failed migrations. Since the `forwards` creation and the insert into that new table which is causing the conflict happened in the same commit, they should always have been either applied both or none of them should. If that's true, then we can slightly alter the query for that
08:54 < cdecker[m]> migration and avoid having to backfill. So the question to denis2342 is: after the migration fails, what version does the DB say it is? Do you have a `forwards` table or does that get cleaned up because the transaction as a whole failed?
08:56 < denis2342> cdecker[m]: it failed the day before yesterday for me and I could easyly switch back to 12.1 with DB version 199
08:56 < denis2342> so the transaction protection thingy is working
08:56 < cdecker[m]> Perfect, thanks for confirming
08:57 < cdecker[m]> That makes actually creating a fix so much easier, no half-migrated DBs to worry about
08:57 < vincenzopalazzo> cdecker: I think the problem is just how to manage the node that already migrated
08:57 < vincenzopalazzo>  
08:59 < denis2342> only nodes without NULL entries could successfully migrate
09:02 < vincenzopalazzo> I'm more in fevor to remove the primary key as nullable and put a id there, but i'm not sure I got why in the table there the in_htlc_id is a primary key.
09:03 < cdecker[m]> Why would we need an ID at all? It's not like we're referencing things in that table by an ID or even through the primary key at all. Rather we should have indices that match our query pattern. Introducing that primary key was a bad idea...
09:03 < cdecker[m]> And now we can't get rid of it, because sqlite3 is bad at ALTER TABLE statements and we'd have to copy the whole thing around once more.
09:04 < vincenzopalazzo> cdecker[m]: I noted yesterday!
09:05 < denis2342> sqlite3 was the bad idea! :)
09:05 < vincenzopalazzo> cdecker[m]: yeah I see that the primary key is not used no where, so I was imagine that I was missing something related to the primary key
09:07 < cdecker[m]> denis2342: I wouldn't go quite that far, but the SQL support for sqltie3 isn't quite as comfortable as it could be. For most people it works ok, and in this case it is a problem with it being too permissive
09:07 < cdecker[m]> Anyhow, I have a PR that is simple, papers over the issue for the release, and we can do a more in-depth cleanup later.
09:08 < vincenzopalazzo> I will review when it pop up!
09:08 < cdecker[m]> Here it is: https://github.com/ElementsProject/lightning/pull/5737
09:11 < denis2342> the color code is not a standard, right?
09:19 -!- NorrinRadd [~me@85.237.194.149] has joined #c-lightning
09:33 < cdecker[m]> What color?
09:37 < denis2342> the alias color which always has the same red because of the node version
09:40 < denis2342> uh, the node public key now starts with a 3, is that a new version?
09:50 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
09:51 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #c-lightning
09:59 < vincenzopalazzo> cdecker: COALESCE return `received_time * -1` if the `in_htlc_id` field  is null right?
10:02 < vincenzopalazzo> not the question before asking What happens if I try to insert a null value after the migration is When the in_htlc_id can be null? I assume never because an forward payments exist with an in htlc? so why there is some case where this id is null?
10:08 < cdecker[m]> Correct 
10:10 < vincenzopalazzo> So this null requirements is just for historical reason??
10:13 -!- NorrinRadd [~me@85.237.194.149] has quit [Ping timeout: 265 seconds]
10:15 < vincenzopalazzo> Self answer, yes before when the channel is deleted we are going to trigger ON DELETE SET NULL
10:16 -!- Guest42 [~Guest42@2604:3d08:5384:2600:679c:689b:432c:e25d] has joined #c-lightning
10:17 -!- denis2342_ [~denis@p4fd7d51a.dip0.t-ipconnect.de] has joined #c-lightning
10:18 -!- denis2342 [~denis@p4fd7d51a.dip0.t-ipconnect.de] has quit [Ping timeout: 256 seconds]
10:18 -!- denis2342_ is now known as denis2342
10:32 -!- NorrinRadd [~me@98.159.224.221] has joined #c-lightning
10:39 -!- Guest42 [~Guest42@2604:3d08:5384:2600:679c:689b:432c:e25d] has quit [Quit: Client closed]
10:45 < vincenzopalazzo> <denis2342> "uh, the node public key now..." <- the public key stat with 3 or 2, and it depends from the private key it is not a version
10:46 < denis2342> ok, thanks
11:45 -!- jarthur [~jarthur@user/jarthur] has joined #c-lightning
12:18 -!- NorrinRadd [~me@98.159.224.221] has quit [Ping timeout: 264 seconds]
12:21 -!- NorrinRadd [~me@98.159.224.221] has joined #c-lightning
12:32 -!- NorrinRadd [~me@98.159.224.221] has quit [Quit: NorrinRadd]
13:28 -!- denis2342_ [~denis@p4fd2bd99.dip0.t-ipconnect.de] has joined #c-lightning
13:28 -!- denis2342 [~denis@p4fd7d51a.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]
13:29 -!- denis2342_ is now known as denis2342
13:32 -!- denis2342_ [~denis@p4fd2bdb1.dip0.t-ipconnect.de] has joined #c-lightning
13:33 -!- denis2342 [~denis@p4fd2bd99.dip0.t-ipconnect.de] has quit [Ping timeout: 265 seconds]
13:33 -!- denis2342_ is now known as denis2342
13:49 -!- denis2342_ [~denis@p4fd2bdfb.dip0.t-ipconnect.de] has joined #c-lightning
13:51 -!- denis2342 [~denis@p4fd2bdb1.dip0.t-ipconnect.de] has quit [Ping timeout: 260 seconds]
13:51 -!- denis2342_ is now known as denis2342
14:04 -!- denis2342_ [~denis@p4fd2bc55.dip0.t-ipconnect.de] has joined #c-lightning
14:06 -!- denis2342 [~denis@p4fd2bdfb.dip0.t-ipconnect.de] has quit [Ping timeout: 268 seconds]
14:06 -!- denis2342_ is now known as denis2342
14:11 -!- denis2342_ [~denis@p4fd2bc81.dip0.t-ipconnect.de] has joined #c-lightning
14:13 -!- denis2342 [~denis@p4fd2bc55.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]
14:13 -!- denis2342_ is now known as denis2342
14:18 -!- denis2342_ [~denis@p4fd2bca3.dip0.t-ipconnect.de] has joined #c-lightning
14:20 -!- denis2342 [~denis@p4fd2bc81.dip0.t-ipconnect.de] has quit [Ping timeout: 260 seconds]
14:21 -!- denis2342 [~denis@p4fd2bcb3.dip0.t-ipconnect.de] has joined #c-lightning
14:22 -!- denis2342_ [~denis@p4fd2bca3.dip0.t-ipconnect.de] has quit [Ping timeout: 265 seconds]
15:01 -!- denis2342 [~denis@p4fd2bcb3.dip0.t-ipconnect.de] has quit [Quit: denis2342]
15:57 -!- NorrinRadd [~me@64.64.116.142] has joined #c-lightning
16:39 -!- NorrinRadd [~me@64.64.116.142] has quit [Ping timeout: 265 seconds]
16:52 -!- NorrinRadd [~me@188.215.95.25] has joined #c-lightning
17:00 -!- rusty [~rusty@115-166-20-247.tpgi.com.au] has joined #c-lightning
17:04 -!- rusty [~rusty@115-166-20-247.tpgi.com.au] has left #c-lightning []
18:34 -!- NorrinRadd [~me@188.215.95.25] has quit [Ping timeout: 264 seconds]
19:34 -!- rusty [~rusty@115-166-20-247.tpgi.com.au] has joined #c-lightning
19:48 -!- jonatack2 [~jonatack@user/jonatack] has joined #c-lightning
19:50 -!- jonatack1 [~jonatack@user/jonatack] has quit [Ping timeout: 264 seconds]
20:12 -!- jonatack2 [~jonatack@user/jonatack] has quit [Ping timeout: 265 seconds]
20:12 -!- jonatack2 [~jonatack@user/jonatack] has joined #c-lightning
20:59 -!- rusty [~rusty@115-166-20-247.tpgi.com.au] has quit [Ping timeout: 265 seconds]
23:35 -!- rusty [~rusty@115-166-20-247.tpgi.com.au] has joined #c-lightning
23:48 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
23:49 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #c-lightning
23:54 -!- rusty [~rusty@115-166-20-247.tpgi.com.au] has quit [Ping timeout: 265 seconds]
--- Log closed Fri Nov 25 00:00:27 2022