--- Log opened Thu Aug 12 00:00:36 2021 00:37 < JoinMarketRelay> [hackint/mojo] Hi. I Just have a generic suggestion regarding the codebase. Many function names include "senders" and "receivers". I feel it would be helpful to explain this semantic somewhere. I know the code is trying to be self documenting, and this would only help in that intent for new comers. 00:39 < JoinMarketRelay> [hackint/mojo] Either in the readme or somewhere in code. 00:55 < belcher> good idea 03:52 -!- belcher [~belcher@user/belcher] has quit [Quit: Leaving] 04:11 -!- belcher [~belcher@user/belcher] has joined #coinswap 05:56 -!- belcher [~belcher@user/belcher] has quit [Quit: Leaving] 06:07 -!- belcher [~belcher@user/belcher] has joined #coinswap 07:39 < JoinMarketRelay> [hackint/mojo] JoinMarketRelay, even I am not sure about the meaning of these two terms. If you find some time can you add it somewhere? 07:44 < belcher> ill briefly write something right now, and then later write something properly in the readme or another doc 07:45 < belcher> when there is a coinswap address (i.e. a 2of2 multisig), the senders contract tx is the contract tx that is known by the entity which paid into the coinswap address, the receivers contract is the contract tx known by the entity which will unilaterally control the coinswap address if the coinswap completes successfully 07:46 < belcher> the difference between senders contract tx and receivers contract tx arises because of small details such as miners, and that the senders contract tx will eventually have collateral inputs 07:46 < belcher> however both of them have the same actual contract redeemscript 07:48 < belcher> hope that helps mojo 07:49 < belcher> the names "senders" and "receivers" come from the role that the coinswap entities are in, the senders contract tx is known by the one who sent the coins into the coinswap address, the receivers contract tx is known by the one who will receive coins from the coinswap address if it completes successfully 07:51 < JoinMarketRelay> [hackint/mojo] JoinMarketRelay, Thanks, ya that helps a lot. I was guessing along that line. 07:51 < JoinMarketRelay> [hackint/mojo] > 07:51 < JoinMarketRelay> [hackint/mojo] > tx arises because of small details such as miners, 07:52 < JoinMarketRelay> [hackint/mojo] Would it be correct to say these differences are similar to how LN commitment transactions differs between two parties? ie. mirros of Hash and Time locking? 07:54 < JoinMarketRelay> [hackint/mojo] Answering myself, its already mentioned that they are exactly same except for collateral inputs. 07:54 < JoinMarketRelay> [hackint/mojo] https://github.com/bitcoin-teleport/teleport-transactions/blob/b67dab5ce1ae04e4de7665004d1ffba944ef2318/src/contracts.rs#L180-L182 09:03 < JoinMarketRelay> [hackint/mojo] Another issue I couldn't wrap clearly so far is, what exactly is being routed in a multihop coinswap? If it goes like Alice --> Bob --> Carol --> Alice, is it like Alice+Bob swap and then Bob+Carol swap and then Carol+Alice swap? So Alice ends up with both Bob's and Carol's history? 09:49 < belcher> that should be "small details such as miner fees" 09:49 < belcher> bitcoins are being routed in a multihop coinswap 09:50 < belcher> alice sends her bitcoins to bob, bob sends his to charlie, charlie sends his bitcoins to alice 09:50 < belcher> alice gives her history to bob, and she receives coins with a history from charlie 09:50 < belcher> the point of the routing is so that one maker doesnt know the whole route 09:54 < JoinMarketRelay> [hackint/mojo] Ok thanks. I guess i see now. So in the process does Bob also ends up with Charlie's history, and Charlie with Alice's history? 09:55 < belcher> depends how you define history i suppose 09:55 < belcher> bob receives coins from alice 09:55 < belcher> and alice receives coins from charlie 09:56 < belcher> so after its all done bob would look at his wallet at his coins and might think "whats the history of these coins?", that history would be alice's, not charlie's 09:56 < JoinMarketRelay> [hackint/mojo] Ok and what would Charlie see? 09:58 < JoinMarketRelay> [hackint/mojo] Also, Does Bob and Charlie swap among themselves? 10:02 < belcher> yes there is a coinswap between bob and charlie 10:02 < belcher> a coinswap where bob sends coins into the 2of2 multisig, and after the coinswap is done charlie now possesses those coins 10:03 < belcher> therefore after the coinswap is done charlie will have coins in his wallet that came from bob, so they have bob's history 16:54 -!- greypw [~greypw@user/greypw] has quit [Ping timeout: 245 seconds] 16:54 -!- openoms [~quassel@gateway/tor-sasl/openoms] has quit [Ping timeout: 244 seconds] 16:55 -!- robertspigler [~robertspi@2001:470:69fc:105::2d53] has quit [Ping timeout: 272 seconds] 16:55 -!- openoms [~quassel@gateway/tor-sasl/openoms] has joined #coinswap 17:16 -!- belcher_ [~belcher@user/belcher] has joined #coinswap 17:16 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 268 seconds] 18:17 -!- reallll [~belcher@user/belcher] has joined #coinswap 18:19 -!- belcher_ [~belcher@user/belcher] has quit [Ping timeout: 272 seconds] 18:56 -!- greypw [~greypw@user/greypw] has joined #coinswap 18:58 -!- robertspigler [~robertspi@2001:470:69fc:105::2d53] has joined #coinswap 22:48 -!- reallll is now known as belcher --- Log closed Fri Aug 13 00:00:37 2021