--- Day changed Fri Nov 16 2018
04:46 <@provoostenator> sipa what did the term "Visitor" refer to?
04:52 <@provoostenator> Anyway the new version is way shorter and seems to remove duplicate code, which is nice.
04:53 -!- provoostenator changed the topic of ##hwi to: Hardware Wallet Interaction scripts | https://github.com/achow101/HWI | Core branch to use: https://github.com/achow101/bitcoin/tree/hww | Logs: https://gist.github.com/Sjors/508e12bd7dbc250629db54342c537c8a
06:57 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has joined ##hwi     
07:58 < sipa> provoostenator: the visitor pattern
08:08 < sipa> https://en.wikipedia.org/wiki/Visitor_pattern
10:59 <@provoostenator> gwillen: +1 for counting everything as the wallet balance
11:02 <@provoostenator> instagibbs: can/should die_caffectedkeysvisitor_die be tested on top of achow101's hww branch?
11:03 <@achow101> what's it do? I haven't looked at it yet
11:03 < instagibbs> i mean i guess but it's a bigger delta than required for my purposes right now
11:04 <@achow101> let's just keep chaining prs like we chain unconfirmed transactions, nothing could possibly go wrong :)
11:04 < instagibbs> maybe just have both, one of top of eachother, such that as things get merged we rebase
11:05 <@achow101> is it really necessary though
11:05 < instagibbs> it's not until we go towards keypool replacement
11:05 < instagibbs> afaik
11:06 < instagibbs> will be helpful for records-based scanning of used keys(inside descriptors)
11:07 <@achow101> a quick look at the commits seems like this is kind of orthogonal to hww support
11:07 <@achow101> it seems like something more for moving to descriptor based wallets
11:08 < instagibbs> correct, though they're not completely unrelated
11:09 < instagibbs> descriptor based wallets being the method of getting us to record-based wallet etc
11:10 <@provoostenator> It's just one commit, orthogonal makes sense.
11:11 <@provoostenator> It doesn't actually _replace_ https://github.com/achow101/bitcoin/commit/6c9c8fa0fd556959e7ecc83c281a2537156115c7 right?
11:13 < instagibbs> I didn't look super closely
11:15 < sipa> achow101: it's just that instagibbs needed to make some changes to CAffectedKeyVisitor for some reason, and I want to make sure my plan to rip it out doesn't interfere with that
11:16 < instagibbs> it shouldn't
11:17 < sipa> instagibbs: well, interfere is a bad word
11:17 < sipa> does it *also* do what you need it to do?
11:19 < instagibbs> IIRC yes from my glancing at it
20:50 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 256 seconds]     
20:55 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined ##hwi