--- Day changed Thu Feb 14 2019 11:07 < instagibbs> achow101, I don't think current hww branch is importing pubkeys in right order 11:07 < instagibbs> based on review/comparison of recent PR 11:07 < achow101> instagibbs: I think you're wrong. that code hasn't been touched in a long time 11:07 < achow101> i'm adding a test right now, so we'll find out soon 11:08 < instagibbs> ok! 11:08 < instagibbs> so... map iteration is working? 11:08 < instagibbs> or am I taking crazy pills and it's a vector after all 11:10 < achow101> instagibbs: it's map iteration over the things at a specific descriptor 11:10 < achow101> then over the range 11:10 < achow101> the descriptor expands into a map of keys at index i 11:10 < instagibbs> ok maybe im looking at the wrong abstraction 11:11 < instagibbs> still a test is nice to shut me up 11:11 < instagibbs> per i there can be multiple pubkeys, right 11:11 < achow101> yes 11:11 < achow101> but only for things like multisig 11:11 < instagibbs> yep 11:12 < instagibbs> I recall this now 11:12 < instagibbs> I think I literally wrote this fix back when, you think I'd remember 11:13 < achow101> you did 11:14 < achow101> must be early onset alzeimer's :p 11:24 < achow101> instagibbs: there's a test now in the pr 11:25 < achow101> hww is a bit behind the prs due to the frequency of changes to 14021 over the past few days 11:27 < instagibbs> yeah no prob im not updating my own local branch anyways 11:27 < instagibbs> one issue with the test the linter caught 11:27 < instagibbs> (pretty cool it spared travis all the effort of running functional tests) 11:27 < instagibbs> will ACK once it's running 11:36 < achow101> instagibbs: update your ack, the text was broken (more than just the thing the linter caught) but should be fixed now 11:36 < achow101> *test 11:39 < instagibbs> ill wait until it passes :P 11:39 < achow101> by the time it does you'll have forgotten to ack it. travis takes too long these days 11:41 < instagibbs> would really be nice to be able to run 0.18 master... 11:41 < instagibbs> s/master// 11:42 < achow101> 14021 is rtm i think (maybe one or 2 more acks). 14075 needs more acks 11:43 < instagibbs> took like 2 seconds to build locally and run test, ACKing 11:43 < achow101> then we need to finish up hwi 1.0 in time for 0.18 release 11:58 < instagibbs> 1.0 TODO list is quite short 11:58 < instagibbs> 2 items AFAICT, one of which is PRd 12:01 <@provoostenator> Would be very cool to get these two things merged. Also means no more rebase hell for me. 12:02 <@provoostenator> (even nicer to get them in 0.18, so people without compiler skills can start testing the flow) 12:02 < instagibbs> less hazardous than just building whatever hww points to for sure 12:03 < instagibbs> attack vectors 16:49 < achow101> fyi when you upgrade your wallets from the old hww branch to the new one or to master, it's going to be broken 23:43 <@provoostenator> achow101: been there done that :-) 23:43 <@provoostenator> Rebase time!!!