--- Day changed Tue Aug 20 2019 07:12 -!- provoostenator [~vwDZ2BYsc@2a05:d014:5f:e100:fd30:8af7:2d6a:cbb1] has quit [Quit: ZNC 1.6.6+deb1ubuntu0.1 - http://znc.in] 08:31 -!- jnewbery [~john@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Ping timeout: 258 seconds] 10:28 -!- jnewbery [~john@rrcs-184-74-240-156.nyc.biz.rr.com] has joined ##hwi 10:55 -!- provoostenator [~quassel@62.140.137.124] has joined ##hwi 11:05 < instagibbs> provoostenator, running ledger nano s tests manually for x PR 11:05 < provoostenator> Did we improve the test suite so it tells us which button to press? 11:06 < provoostenator> Because afaik you can't just hit OK on the device all the time 11:06 < instagibbs> yeah you can?> 11:06 < instagibbs> at least last time i ran it it did 11:07 < instagibbs> test_big_tx takes foreveeeeeeer 11:08 < instagibbs> it's a lot of clicking of course 11:09 < provoostenator> Oh ok, I thought it also tested a rejection somewhere. maybe not 11:10 < provoostenator> When I ran it some of the tests didn't pass on the X. 11:10 < instagibbs> oh, that's a self-NACK then :) 11:10 < instagibbs> i just passed the signing tests fine 11:11 < provoostenator> @instagibbs see https://github.com/bitcoin-core/HWI/pull/175#issuecomment-494308410 11:11 < provoostenator> That's a while ago, I could run it again and see if magic helped 11:12 < provoostenator> Oh crap, another rebase, one sec 11:13 < instagibbs> interesting, maybe the firmware pukes on too-big-tx? 11:13 < instagibbs> which is odd, it has more memory than the s 11:13 < instagibbs> you might want to print out more shiz for debugging 11:13 < instagibbs> like the args to finalizepsbt 11:14 < instagibbs> yay promag has an X \o/ 11:16 < instagibbs> I'll have one... sometime soonish 11:19 < achow101> i just merged the full model name pr, so the nano x needs that too 11:19 < achow101> instagibbs: I thought one of the address tests required a reject 11:30 < provoostenator> Let's see if the setup_environment script works on macOS these days... 11:33 < provoostenator> No module named 'bitcoinrpc' 11:39 < achow101> ledger is sending me a x and another s so I'll be able to test for myself 11:39 < achow101> and have another device to brick in my attempst to figure out ledger firmware updating 11:39 < provoostenator> "pip3 install python-bitcoinlib" no bueno 11:40 < achow101> pip install python-bitcoinrpc 11:41 < provoostenator> Ah yes, that worked 11:41 < provoostenator> Do you call run_tests from root or from the test dir? 11:41 < achow101> test 11:42 < provoostenator> And device should be in testnet mode? 11:42 < achow101> doesn't matter 11:43 < achow101> IIRC we do all of the testnet/mainnet magic numbers within HWI itself 11:43 < achow101> although instagibbs should actually know since he wrote the ledger stuff 11:44 < provoostenator> test_enumerate (test_device.TestDeviceConnect) ... FAIL 11:44 < provoostenator> (and the test suite just keeps going) 11:45 < achow101> the test suite continuing is expected. each test case is supposed to be independent of the rest 11:48 < achow101> provoostenator: you're probably failing the check for the device model. one of the tests gives ledger_nano_s as the model, but you want ledger_nano_x 11:48 < achow101> https://github.com/bitcoin-core/HWI/pull/175/files#diff-967d13097f3392e27a845d7346143906R78 11:48 < provoostenator> Ah that might have happened during the rebase 11:48 < achow101> yes 11:48 < achow101> you'll need to add a parameter to test_ledger.py for nano x just like there is one in test_trezor.py for trezor t 11:59 < provoostenator> I think I got it, running the suite again... 12:00 < provoostenator> The Nano X requires a lot more clicks to review and approve stuff by the way. 12:03 < provoostenator> test_big_tx takes its time... several minutes before anything happens on the device 12:05 < provoostenator> test_signtx throws an error for me 12:06 < provoostenator> more details would indeed be helpful 13:13 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 260 seconds] 13:14 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined ##hwi 13:19 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection] 13:20 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined ##hwi 13:28 < instagibbs> why more clicks? 13:32 < instagibbs> provoostenator, https://github.com/bitcoin-core/HWI/pull/231 might have saved you some time 14:09 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 260 seconds] 14:14 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined ##hwi