--- Day changed Sun Dec 02 2018 00:15 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 252 seconds] 00:15 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket 01:22 -!- undeath [~undeath@hashcat/team/undeath] has joined #joinmarket 01:46 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 268 seconds] 02:00 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket 03:06 -!- belcher [~belcher@unaffiliated/belcher] has joined #joinmarket 07:02 -!- undeath [~undeath@hashcat/team/undeath] has quit [Quit: WeeChat 2.3] 09:05 < waxwing> Lightsword, do you happen to know how to make this line work in Py2 and 3 using future/builtins? (you get "name 'unicode' is not defined" in Py3) 09:05 < waxwing> (trying to avoid removing that function _byteify for now; although that might be the best thing to do. it's not too widely used.) 09:14 < waxwing> oh sorry, which line :) 09:14 < waxwing> https://github.com/JoinMarket-Org/joinmarket-clientserver/blob/96a058e36a6c2757edce0bf80457081297ea1189/jmbase/jmbase/support.py#L79 (although guess it was obvious!) 10:33 -!- so [~so@unaffiliated/so] has quit [Ping timeout: 246 seconds] 10:38 -!- so [~so@unaffiliated/so] has joined #joinmarket 12:07 < Lightsword> waxwing, probably if not isinstance(data, bytes): 12:09 < Lightsword> well for that case probably if isinstance(data, basestring) and not isinstance(data, bytes): 13:16 < Lightsword> waxwing, pushed those fixes if you want to test 13:16 < waxwing> Lightsword, yep, doing so already, thanks :) 13:20 < waxwing> Lightsword, before i forget, i had a problem with counterparty = crow[b'counterparty'] in transfer_commitment in daemon_protocol in py3. 13:20 < waxwing> builtins.KeyError: b'counterparty' 13:20 < waxwing> py3 seems to not like the b 13:21 < waxwing> i vaguely remember you said something about sqlite wrt this 13:22 < Lightsword> waxwing, where is sqlite initialized there? 13:22 < Lightsword> wallet_utils.py? 13:22 < waxwing> maybe orderbookwatch? i'll have to check 13:23 < waxwing> OrderbookWatch class is where the db is created 13:23 < waxwing> that transfer_commitment is a bit of an outlier, generally we don't talk to the db anywhere else but in Obwatch, it's just there we need to grab a random participant in the pit to send the message to 13:26 < Lightsword> hmm, transfer_commitment probably needs to be done within a lock right? 13:27 < waxwing> do you think? it's just reading one other counterparty in the pit, at random 13:27 < Lightsword> is there any other threads that might access it? 13:27 < waxwing> there's only one thread. except maybe in obwatcher, but that's a separate app 13:28 < Lightsword> ob-watcher.py had improper locking which I had to fix for py3 13:28 < waxwing> right. that's not actually part of joinmarket proper though. although thanks for fixing it all the same :) 13:28 < Lightsword> I guess for some reason py2 wasn’t as sensitive to that 13:30 < waxwing> i guess different dbs have different policies about reads; our particular use case there, there's no requirement for synchrony, so it wouldn't matter. 13:32 < Lightsword> waxwing, well it crashes if you don’t have proper locking 13:33 < Lightsword> you can’t have multiple threads doing stuff at the same time 13:36 < waxwing> Lightsword, i don't think you want the 'b' for the blacklisted_commitments join 13:36 < waxwing> >>> b'\n'.join(["abc", "def"]) 13:36 < waxwing> Traceback (most recent call last): 13:36 < waxwing> File "", line 1, in 13:36 < waxwing> TypeError: sequence item 0: expected a bytes-like object, str found 13:36 < waxwing> >>> '\n'.join(["abc", "def"]) 13:36 < waxwing> 'abc\ndef' 13:38 < Lightsword> hmm, yeah 13:38 < Lightsword> waxwing, try that 13:43 < waxwing> yeah i'm with you on those (the sqlite thing i haven't tried yet). now on to near the end, slight problem with sigs, think i can fix it. 13:44 < waxwing> first successful regtest join with py3 ... chance that this version of code works with py2 = .. :) 13:45 < waxwing> the sigs change is simple i'll just note it on the PR 13:45 < waxwing> oh i forgot, i cheated by removing _byteify :) but the reason i did that is, i actually think it'd be better to fix whatever caused me to put that silly code in in the first place, in py2 version, than try to make it work here. no sense to it. 14:01 < Lightsword> waxwing, well _byteify should work on both now I think 14:22 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 256 seconds] 14:27 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #joinmarket 14:39 < waxwing> Lightsword, working on both py2 and py3 after removing byteify now; i'll post the small diff to the PR 14:44 < waxwing> done 14:49 < waxwing> so I'll be testing out the various scripts and modes over the next day or two. doubtless a few more minor things will crop up but that breaks the back of it. great, thanks, Lightsword. 14:50 < Lightsword> waxwing, yeah, I didn’t really test much of the scripts stuff myself yet, I mostly just tried to fix any obvious issues 14:51 < waxwing> there's a few utilities that are hardly used. i can just work on that separately. as long as wallet-tool, sendpayment, tumbler and yieldgen function, that's what matters. 14:51 < Lightsword> mostly since I’ve been doing a lot of these changes without fully understanding all the logic involved yet so I was leaning heavially on the automated tests to generate backtraces 14:52 < waxwing> you can leave that part up to me, though. well, and undeath ofc 14:53 < Lightsword> waxwing, pushed _byteify removal just now 14:53 < waxwing> got it thanks 14:59 < waxwing> heh, pytest has a rather amusing warning message: 15:00 < waxwing> /home/adam/code/Joinmarket/joinmarket-clientserver/jmclient/jmclient/client_protocol.py:496: DeprecationWarning: The 'warn' method is deprecated, use 'warning' instead 15:41 < waxwing> arubi, any ideas what caused this one? https://travis-ci.org/JoinMarket-Org/joinmarket-clientserver/jobs/462579255 15:42 < waxwing> Lightsword, i guess this one's a trivial side-effect of removing _byteify https://travis-ci.org/JoinMarket-Org/joinmarket-clientserver/jobs/462579247#L2413 15:52 -!- GitHub186 [GitHub186@gateway/service/github.com/x-dhmpbgcpcejzzamb] has joined #joinmarket 15:52 < GitHub186> [joinmarket-clientserver] undeath opened pull request #246: display[all] extended usage status (master...display-addr-use) https://git.io/fpKiW 15:52 -!- GitHub186 [GitHub186@gateway/service/github.com/x-dhmpbgcpcejzzamb] has left #joinmarket [] 17:18 < Lightsword> waxwing, yeah forgot to remove that import 17:56 -!- AgoraRelay [~jmrelayfn@p5DE4A907.dip0.t-ipconnect.de] has quit [Ping timeout: 244 seconds] 18:09 -!- AgoraRelay [~jmrelayfn@p5DE4A76B.dip0.t-ipconnect.de] has joined #joinmarket 18:21 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection] 18:21 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #joinmarket 22:14 < arubi> waxwing, looks like network issue. dnf is trying to install the equivalent of the build-essential package and was stuck like that for 10 mins with no progress