--- Day changed Tue Nov 26 2019 00:33 -!- reallll [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 01:03 -!- trotski2000_ [uid206086@gateway/web/irccloud.com/x-utzdfeoffxfubizh] has joined #joinmarket 01:12 -!- achow101 [~achow101@unaffiliated/achow101] has quit [Ping timeout: 240 seconds] 01:34 -!- Zenton [~user@unaffiliated/vicenteh] has joined #joinmarket 01:36 -!- belcher [~belcher@unaffiliated/belcher] has joined #joinmarket 01:36 -!- belcher [~belcher@unaffiliated/belcher] has quit [Remote host closed the connection] 01:39 -!- achow101 [~achow101@unaffiliated/achow101] has joined #joinmarket 02:55 -!- takamatsu [~takamatsu@unaffiliated/takamatsu] has quit [Remote host closed the connection] 03:40 < waxwing> how is this possible? when i 'vim install.sh', literally do nothing except :wq i.e. save and quit, then git diff shows a diff on the file?! 03:40 < waxwing> if i just :q i.e. don't save, it doesn't show a diff 03:40 < waxwing> the diff is really hard to parse for me: 03:41 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Quit: "Fascism, Nazism, Communism and Socialism are only superficial variations of the same monstrous theme—collectivism." -- Ayn Rand] 03:41 < waxwing> waxwing@here~/testjm3/joinmarket-clientserver$ vi install.sh 03:41 < waxwing> waxwing@here~/testjm3/joinmarket-clientserver$ git diff 03:41 < waxwing> diff --git a/install.sh b/install.sh 03:41 < waxwing> index 872b4ba..036c65b 100755 03:41 < waxwing> --- a/install.sh 03:41 < waxwing> +++ b/install.sh 03:41 < waxwing> @@ -169,7 +169,7 @@ EOF 03:41 < waxwing> > [enable_docs=no], 03:41 < waxwing> > [enable_docs=yes]) 03:41 < waxwing> > AM_CONDITIONAL(BUILD_DOCS, [test x$enable_docs = xyes]) 03:41 < waxwing> -> 03:41 < waxwing> +> 03:41 < waxwing> EOF 03:41 < waxwing> patch Makefile.am Makefile.am.patch 03:41 < waxwing> patch configure.ac autoreconf.patch 03:42 < waxwing> can anyone else replicate that, out of interest? easy to test 03:52 < Zenton> In here: https://www.youtube.com/watch?v=xs4Vr3obF6o he says the only working coinjoin is wasabi by now. Does joinmarket work at this moment? 04:02 < waxwing> Zenton, joinmarket has been working continuously for more than 4 years on mainnet :) 04:19 < Zenton> thanks waxwing 05:01 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 05:02 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #joinmarket 05:09 -!- slivera [slivera@gateway/vpn/privateinternetaccess/slivera] has quit [Remote host closed the connection] 07:26 < qubenix> Zenton: i heard that pod too, he's wrong. that guy's supposed to be some expert on the darknet, but seems like he's the one in the dark. 07:43 -!- lnostdal [~lnostdal@77.70.119.51] has joined #joinmarket 09:47 -!- MaxSan [~four@103.254.153.99] has joined #joinmarket 10:52 -!- trotski2000_ [uid206086@gateway/web/irccloud.com/x-utzdfeoffxfubizh] has quit [Quit: Connection closed for inactivity] 10:55 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 240 seconds] 11:18 -!- midnightmagic is now known as midnight 11:30 < kristapsk> waxwing, probably docs should be changed before release in some places to indicate that sendpayment.py now accepts not only sat, but also BTC values? For example, payjoin doc explictly says "amount is always an integer, in satoshis", which isn't true anymore. I could go through all of them. 11:32 < waxwing> kristapsk, thanks, that'd be helpful. i'm going to look through docs in next day or two, also. 11:57 < kristapsk> waxwing, going through the docs, some places where outputs are displayed are not consistent with BTC / sat, but that's minor issue, but what I really don't like now is that scripts/receive-payjoin.py now accepts only amount-in-sats, while scripts/sendpayment.py accepts both btc or sats; change would be trivial - from "receiving_amount = int(argv[1])" to "receiving_amount = btc.amount_to_sat(argv[1])" 11:58 < waxwing> kristapsk, i see. makes sense, and agreed it should be done. in payjoin case, the receiving amount is sent out of band to sender who inputs it as argument to sendpayment, so it makes sense the two values should be compatible. 11:59 < waxwing> i mean strictly speaking the edit is not necessary, nothing is broken. but still, why not do it now. 12:02 < kristapsk> ok, then I will do that single line change, send a PR about that, then continue going through rest of the docs; not changing any other forgotten lines (log outputs), will later add that to #450 12:03 < waxwing> thanks 12:23 < kristapsk> done 12:24 < kristapsk> and in testing process found two other issues with receive-payjoin.py, will fill issues about that later 12:24 < kristapsk> (not critical ones) 12:30 < waxwing> the double reactor.stop() i know about already, decided to defer it (shouldn't happen in mainnet; but might) 12:33 < kristapsk> no, others 12:34 < kristapsk> Ctrl+C is not working in payjoin-receive if user changes his mind, but the same is also during manual order picking with -P in sendpayment.py ; only way is kill -9 from other terminal 12:35 < kristapsk> and it seems that payjoin-receive continues without any warnings / errors with empty wallet 12:36 -!- MaxSan [~four@103.254.153.99] has quit [Ping timeout: 246 seconds] 12:40 -!- slivera [slivera@gateway/vpn/privateinternetaccess/slivera] has joined #joinmarket 12:46 < waxwing> ah. thank you (i saw the first one happen but didn't realise it would *always* happen, so, good call.) 12:56 -!- Zenton [~user@unaffiliated/vicenteh] has joined #joinmarket 14:38 < waxwing> kristapsk, i think it's to do with 'input()'. but i'll look at it tomorrow or something. 14:46 < kristapsk> waxwing, don't think it is of so high importance right now, it could be looked after release 14:47 < kristapsk> #457 and #460 was meant for merging before that from me 15:47 -!- slivera [slivera@gateway/vpn/privateinternetaccess/slivera] has quit [Remote host closed the connection] 17:24 -!- MaxSan [~four@82.102.28.107] has joined #joinmarket 17:37 -!- CgRelayBot [~CgRelayBo@p5DE4A302.dip0.t-ipconnect.de] has quit [Ping timeout: 268 seconds] 17:37 -!- AgoraRelay [~jmrelayfn@p5DE4A302.dip0.t-ipconnect.de] has quit [Ping timeout: 246 seconds] 17:49 -!- CgRelayBot [~CgRelayBo@p5DE4A301.dip0.t-ipconnect.de] has joined #joinmarket 17:53 -!- AgoraRelay [~jmrelayfn@p5DE4A301.dip0.t-ipconnect.de] has joined #joinmarket 18:09 -!- technonerd [~techno@gateway/tor-sasl/technonerd] has quit [Ping timeout: 260 seconds] 18:17 -!- technonerd [~techno@gateway/tor-sasl/technonerd] has joined #joinmarket 18:30 -!- slivera [slivera@gateway/vpn/privateinternetaccess/slivera] has joined #joinmarket 19:18 -!- MaxSan [~four@82.102.28.107] has quit [Quit: Leaving.] 20:32 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 20:32 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #joinmarket 21:44 -!- MaxSan [~four@82.102.28.107] has joined #joinmarket 21:53 -!- MaxSan [~four@82.102.28.107] has quit [Quit: Leaving.] 23:11 -!- johnonchain [~johnoncha@2001:41d0:fc63:9c00:2931:aec:9468:a5e7] has quit [Ping timeout: 245 seconds]