--- Log opened Sun Apr 12 00:00:49 2020
00:25 -!- jonatack__ [~jon@37.165.200.74] has joined #joinmarket
00:29 -!- jonatack_ [~jon@37.165.242.44] has quit [Ping timeout: 256 seconds]
00:30 -!- viasil [~viasil@134.19.189.52] has quit [Ping timeout: 264 seconds]
00:35 -!- viasil [~viasil@134.19.189.52] has joined #joinmarket
03:06 -!- Elisa8Robel [~Elisa8Rob@ns334669.ip-5-196-64.eu] has joined #joinmarket
03:10 -!- jonatack__ [~jon@37.165.200.74] has quit [Ping timeout: 265 seconds]
03:10 -!- jonatack__ [~jon@213.152.161.149] has joined #joinmarket
03:28 -!- undeath [~undeath@hashcat/team/undeath] has joined #joinmarket
03:39 -!- viasil [~viasil@134.19.189.52] has quit [Ping timeout: 250 seconds]
03:45 -!- viasil [~viasil@134.19.189.52] has joined #joinmarket
03:53 -!- viasil [~viasil@134.19.189.52] has quit [Ping timeout: 250 seconds]
03:55 -!- viasil [~viasil@134.19.189.52] has joined #joinmarket
04:05 -!- cbeams [~cbeams@unaffiliated/cbeams] has joined #joinmarket
04:09 -!- cbeams [~cbeams@unaffiliated/cbeams] has quit [Remote host closed the connection]
04:58 -!- viasil [~viasil@134.19.189.52] has quit [Ping timeout: 250 seconds]
04:59 < kristapsk> probably configure should be moved from jmclient to jmbase? waxwing , belcher_ , any thoughts? (see above about #554 not working because of no jm_single in jmdaemon)
05:04 -!- viasil [~viasil@134.19.189.52] has joined #joinmarket
05:15 < waxwing> kristapsk, yes that's right (what you said yesterday). the idea with jmdaemon is it can be installed without the client or bitcoin parts. so the parts of the config needed for setup are transferred to the daemon in setup.
05:15 < waxwing> (sorry my IRC was offline this morning)
05:16 < waxwing> this is indeed why i did not change the location of commitmentlist, while i was doing that PR for datadir. but i'm afraid i forgot about it when writing the doc.
05:16 < waxwing> sorry i didn't do a quick regtest test of your change, was lazy on my part but i stupidly thought it was 'obvious'.
05:16 < waxwing> revert the commit now would be sensible.
05:17 < waxwing> the way i saw it at the time (and am now remembering) is: it's unfortunate that this particular chunk of data can't be kept in user area, but (a) it's public data (what's broadcast) and (b) changes are going to be very infrequent and shouldn't harm anything.
05:18 < waxwing> notice how it's different from the commitments.json, which is data you *do* need to "remember" so you don't try taker-side joins again with the same commitments.
05:21 < kristapsk> waxwing, ok, I reverted the commit
05:22 < kristapsk> but in any case, there are other references to jm_single in jmdaemon, so there are potential other bugs already there
05:33 < waxwing> oh. let me take a look.
05:39 < kristapsk> that's why I didn't look more carefully at it, as I saw jm_single() already there :(
05:40 < waxwing> kristapsk, yes that one place in daemonserverprotocol, on_commitment_seen - for sure it's a bug, i'll be checking more in a short while to see whether it's important and if so exactly what it means.
05:40 < waxwing> either way i'll update that after checking it out.
05:41 < waxwing> meanwhile a further point about this issue of location of commitmentlist, it does occur to me that it wouldn't be hard for jmdaemon to just store it in ~/.joinmarket anyway; that would be transparent - for normal users it'll be in the expected place, and for isolated daemon users they'll just have that one file in ~/.joinmarket , at least iirc
05:43 < waxwing> but always do a quick run on regtest, it's not hard, just get it so that you can run ygrunner with miniircd always, you can just check if one tx goes through. yes i know it should be automated, but i haven't managed to do that yet. (see test/test_full_coinjoin which was supposed to do that but there was some difficult point about getting failures recorded correctly).
05:43 < waxwing> for now just doing it manually is generally about 1-2 minutes once it's ready.
05:45 -!- jonatack__ [~jon@213.152.161.149] has quit [Quit: jonatack__]
05:45 -!- jonatack [~jon@213.152.161.149] has joined #joinmarket
05:57 < kristapsk> waxwing, you mean hardcoding ~/.joinmarket and ignoring --datadir ?
05:59 < kristapsk> about tests - it is in my TODO list to dig deeper there, but haven't managed to get priority for that
05:59 -!- nothingmuch [~nothingmu@unaffiliated/nothingmuch] has joined #joinmarket
06:00 -!- Elisa8Robel [~Elisa8Rob@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 265 seconds]
06:08 -!- viasil [~viasil@134.19.189.52] has quit [Ping timeout: 250 seconds]
06:10 < waxwing> kristapsk, re: ignoring datadir, no, don't intend to do that, but i just need to check the code (should be easy) to figure out how to do it "hardcoded" but respecting datadir.
06:11 < waxwing> hardcoded just means not using a global jm_single() var, but it'll be the same logic.
06:11 < waxwing> but while that is mildly important, i don't consider it urgent. otoh i do want to check out what is going on with the bug mentioned above. i will do that now.
06:13 -!- viasil [~viasil@134.19.189.52] has joined #joinmarket
06:27 < waxwing> so the bug is pretty significant, and it's related to a detail about how python's "finally" works: https://github.com/JoinMarket-Org/joinmarket-clientserver/blob/master/jmdaemon/jmdaemon/message_channel.py#L812
06:28 < waxwing> if we get an exception which is not an index error, this gets run - and that's what was happening basically every time a !hp2 message is received in the public channel. (exception was just a name error for 'jm_single()'
06:29 < waxwing> so basically according to my reading and a brief test, only privately communicated podle commitments or those during transactions you take part in, were being stored in the commitmentlist. not all of them.
06:29 < waxwing> also haven't checked yet how long this bug has been in place.
06:30 < waxwing> obviously it is not a functionality breaking bug, it just means our maker bots are too lax and are not in-the-know about all the commitments that have been used.
06:31 < waxwing> the fix is just to remove the 'accept_commitment_broadcasts' config var. iirc (a long time ago!) i only put it in there because i was a bit paranoid about people being upset about 'blacklisting'. but it's dumb, no one should ever switch that off.
07:02 < DSRelBot> [DS/AlexCato] you can replace "finally" with "else" then it works as the code intended
07:04 < DSRelBot> [DS/AlexCato] disregard what i just said, not true
07:05 < DSRelBot> [DS/AlexCato] and disregard that as well, my first hunch was indeed correct ;) Replacing it with "else" will work
07:07 < DSRelBot> [DS/AlexCato] "else" only runs if there's no exception in that try-block
07:14 < waxwing> AlexCato right, thanks :) but i believe the problem is not that "it always returns True"; that is actually intended. we don't want crashes from external data.
07:15 < waxwing> the problem is that it was failing silently, so we never knew there was an error in the JM code making it fail all the time.
07:15 < waxwing> anyway opened #555
07:30 -!- cbeams [~cbeams@unaffiliated/cbeams] has joined #joinmarket
07:54 -!- cbeams [~cbeams@unaffiliated/cbeams] has quit [Remote host closed the connection]
08:22 < midnight> w 16
08:47 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
08:48 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #joinmarket
09:14 -!- cbeams [~cbeams@unaffiliated/cbeams] has joined #joinmarket
09:17 -!- cbeams [~cbeams@unaffiliated/cbeams] has quit [Remote host closed the connection]
09:25 -!- cbeams [~cbeams@unaffiliated/cbeams] has joined #joinmarket
09:31 -!- cbeams [~cbeams@unaffiliated/cbeams] has quit [Remote host closed the connection]
12:16 -!- cbeams [~cbeams@unaffiliated/cbeams] has joined #joinmarket
12:21 -!- cbeams [~cbeams@unaffiliated/cbeams] has quit [Ping timeout: 260 seconds]
12:28 -!- jonatack [~jon@213.152.161.149] has quit [Ping timeout: 240 seconds]
12:31 -!- jonatack [~jon@37.170.20.209] has joined #joinmarket
12:52 -!- cbeams [~cbeams@unaffiliated/cbeams] has joined #joinmarket
12:59 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood]
13:00 -!- cbeams [~cbeams@unaffiliated/cbeams] has quit [Ping timeout: 256 seconds]
13:02 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket
13:06 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood]
13:07 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket
13:27 -!- cbeams [~cbeams@unaffiliated/cbeams] has joined #joinmarket
14:01 -!- cbeams [~cbeams@unaffiliated/cbeams] has quit [Ping timeout: 260 seconds]
14:12 -!- xochon [~user@gateway/tor-sasl/xochon] has quit [Ping timeout: 240 seconds]
14:13 -!- xochon [~user@gateway/tor-sasl/xochon] has joined #joinmarket
14:52 -!- cbeams [~cbeams@unaffiliated/cbeams] has joined #joinmarket
14:56 -!- cbeams [~cbeams@unaffiliated/cbeams] has quit [Ping timeout: 240 seconds]
15:46 -!- cbeams [~cbeams@unaffiliated/cbeams] has joined #joinmarket
16:20 -!- cbeams [~cbeams@unaffiliated/cbeams] has quit [Ping timeout: 250 seconds]
16:22 -!- opal [~wowaname@volatile/founder/wowaname] has quit [Ping timeout: 240 seconds]
16:23 -!- opal [~wowaname@volatile/founder/wowaname] has joined #joinmarket
17:10 -!- cbeams [~cbeams@unaffiliated/cbeams] has joined #joinmarket
17:21 -!- undeath [~undeath@hashcat/team/undeath] has quit [Quit: WeeChat 2.8]
17:24 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 258 seconds]
17:25 -!- Zenton [~user@unaffiliated/vicenteh] has joined #joinmarket
17:31 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 256 seconds]
17:32 -!- k3tan [~pi@unaffiliated/k3tan] has quit [Ping timeout: 265 seconds]
17:35 -!- DSRelBot [~DSRelBot@p5DE4A1AF.dip0.t-ipconnect.de] has quit [Ping timeout: 265 seconds]
17:35 -!- HackRelay [~jmrelayha@p5DE4A1AF.dip0.t-ipconnect.de] has quit [Ping timeout: 265 seconds]
17:37 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket
17:43 -!- cbeams [~cbeams@unaffiliated/cbeams] has quit [Ping timeout: 256 seconds]
17:49 -!- HackRelay [~jmrelayha@p5DE4ABF7.dip0.t-ipconnect.de] has joined #joinmarket
17:49 -!- DSRelBot [~DSRelBot@p5DE4ABF7.dip0.t-ipconnect.de] has joined #joinmarket
18:34 -!- cbeams [~cbeams@unaffiliated/cbeams] has joined #joinmarket
18:39 -!- cbeams [~cbeams@unaffiliated/cbeams] has quit [Ping timeout: 264 seconds]
19:27 -!- jonatack [~jon@37.170.20.209] has quit [Ping timeout: 265 seconds]
19:28 -!- cbeams [~cbeams@unaffiliated/cbeams] has joined #joinmarket
19:30 -!- k3tan [~pi@217.138.204.70] has joined #joinmarket
19:31 -!- k3tan [~pi@217.138.204.70] has quit [Changing host]
19:31 -!- k3tan [~pi@unaffiliated/k3tan] has joined #joinmarket
20:02 -!- cbeams [~cbeams@unaffiliated/cbeams] has quit [Ping timeout: 265 seconds]
20:05 -!- jonatack [~jon@37.170.20.209] has joined #joinmarket
20:41 -!- tlo1337 [~tlo1337@142.183.170.75] has joined #joinmarket
20:46 -!- tlo1337 [~tlo1337@142.183.170.75] has quit [Read error: Connection reset by peer]
20:52 -!- cbeams [~cbeams@unaffiliated/cbeams] has joined #joinmarket
20:57 -!- cbeams [~cbeams@unaffiliated/cbeams] has quit [Ping timeout: 265 seconds]
21:46 -!- cbeams [~cbeams@unaffiliated/cbeams] has joined #joinmarket
22:21 -!- cbeams [~cbeams@unaffiliated/cbeams] has quit [Ping timeout: 258 seconds]
22:44 -!- cbeams [~cbeams@unaffiliated/cbeams] has joined #joinmarket
--- Log closed Mon Apr 13 00:00:50 2020