--- Log opened Sat Jun 27 00:00:02 2020
01:33 -!- asymptotically [~asymptoti@gateway/tor-sasl/asymptotically] has joined #joinmarket
03:05 -!- Khalil54Sporer [~Khalil54S@static.57.1.216.95.clients.your-server.de] has joined #joinmarket
03:08 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Read error: Connection reset by peer]
03:09 -!- Zenton [~user@unaffiliated/vicenteh] has joined #joinmarket
03:13 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Read error: Connection reset by peer]
03:14 -!- Zenton [~user@unaffiliated/vicenteh] has joined #joinmarket
03:17 -!- Evanito [~Evanito@cpe-76-87-174-228.socal.res.rr.com] has quit [Read error: Connection reset by peer]
03:39 < waxwing> I figured it out this morning. See #611 for detailed explanation. It's pretty obscure; the bencode/bdecode will retrieve the variable as binary from the file, which makes perfect sense, but when you generate, you temporarily store the mnemonic extension as a string in the storage._data dict, before it gets persisted.
03:39 < waxwing> simple fix is ensure it's always binary, even on creation.
03:40 < waxwing> kristapsk, are you working on #610? if not i can do it.
03:41 < waxwing> re: the possible need to make a new release, i'm thinking maybe just go with 0.6.3.1 on the concept that 0.6.3 is 'last' and this is a quick fix.
03:41 < waxwing> on the one hand, these errors are not funds critical and somewhat corner cases, but they're also pretty annoying errors for a user, so certainly makes sense to fix them and re-release.
03:42 < waxwing> oh sorry i forgot, #610 is a very easy/quick fix and i think belcher already said he'd do it
03:42 < waxwing> certainly a lot easier to understand than that mnemonic one, wow
03:44 -!- Khalil54Sporer [~Khalil54S@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 256 seconds]
03:51 -!- reallll [~belcher@unaffiliated/belcher] has joined #joinmarket
03:55 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 256 seconds]
04:16 -!- reallll is now known as belcher
04:17 < belcher> im starting work on #610
04:33 < kristapsk> waxwing, I agree new release is needed and v0.6.3.1 sounds ok
05:06 -!- k3tan [~pi@unaffiliated/k3tan] has quit [Ping timeout: 260 seconds]
05:07 -!- k3tan [~pi@unaffiliated/k3tan] has joined #joinmarket
05:26 -!- k3tan [~pi@unaffiliated/k3tan] has quit [Ping timeout: 260 seconds]
05:29 -!- k3tan [~pi@unaffiliated/k3tan] has joined #joinmarket
07:20 < belcher> if people are interested, another bisq discussion about how arbitration should work https://github.com/bisq-network/proposals/issues/233
07:21 < belcher> it seems their plan of having funds in a 2of2 multisig which gets sent to the DAO in the backout case and users get refunded with DAOcoins instead of bitcoins, has finally hit the wall and they're open to new ideas
07:28 < waxwing> oh. interesting thread, thanks.
07:31 < waxwing> this is an interesting comment: "The DAO must realise that an offer is an option and trying to force traders to fulfill their obligations using other means (reputation, blacklisting by "trusted" team members, ...) will be a very cludgy method indeed, probably with plenty of not intended consequences."
07:34 < waxwing> it's funny that people are still discussing the same stuff in there that we discussed 6 years ago :)
07:39 < waxwing> kristapsk, re: your earlier comment "checklist" i agree, until we have something better, at least go through a list of things to test. at least pre- a release. tbh the checklist is simple, but daunting: every single function you can perform in Qt.
07:39 -!- slivera [~slivera@103.231.88.30] has quit [Remote host closed the connection]
07:39 < waxwing> if that is too much perhaps we can deliberately prune some minor things.
07:40 < waxwing> re: the obvious point 'automated testing for Qt', my intuition is it will require significant code rearchitect somehow. obviously it's desirable.
07:56 < belcher> yep waxwing 
07:57 < belcher> i could probably dig out some comments of mine on that same github of how its a bad idea to moving to the 2of2-multisig-refund-with-DAOcoins scheme
08:33 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #joinmarket
09:25 < waxwing> i think i'll merge #611 and rebuild the release tomorrow. most likely.
09:25 < waxwing> unless anyone has a different view. i guess we should go through more Qt corner cases and maybe push it back a couple more days, not sure.
09:33 < belcher> agree on merging #611
09:34 < belcher> since the places where the variable is used were checked
09:34 < belcher> cli/gui showseed/recover
09:38 -!- Evanito [~Evanito@cpe-76-87-174-228.socal.res.rr.com] has joined #joinmarket
10:03 < DeanWeen> stepping through this joinmarket install on centos 7
10:03 < DeanWeen> yum install automake autoconf libtool
10:03 < DeanWeen> ^was necessary otherwise ./install.sh was failing
10:24 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
10:25 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #joinmarket
10:52 -!- asymptotically [~asymptoti@gateway/tor-sasl/asymptotically] has quit [Remote host closed the connection]
11:38 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]
11:38 -!- belcher [~belcher@unaffiliated/belcher] has joined #joinmarket
11:50 -!- nixbitcoin_ [~nixbitcoi@gateway/tor-sasl/nixbitcoin] has joined #joinmarket
11:52 -!- nixbitcoin [~nixbitcoi@gateway/tor-sasl/nixbitcoin] has quit [Ping timeout: 240 seconds]
12:21 -!- coconutanna [~coconutan@gateway/tor-sasl/coconutanna] has quit [Remote host closed the connection]
12:22 -!- coconutanna [~coconutan@gateway/tor-sasl/coconutanna] has joined #joinmarket
13:10 < kristapsk> just randomly looked at docs/TODO.md, it has become outdated
13:23 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
13:24 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #joinmarket
14:34 < waxwing> kristapsk, sure but that's not part of a release cycle or something, just PR to change it
14:35 < waxwing> anyone know anything about centos that can help DeanWeen above?
15:02 -!- slivera [~slivera@103.231.88.10] has joined #joinmarket
15:12 -!- Evanito [~Evanito@cpe-76-87-174-228.socal.res.rr.com] has quit [Remote host closed the connection]
15:13 -!- Evanito [~Evanito@cpe-76-87-174-228.socal.res.rr.com] has joined #joinmarket
15:15 < kristapsk> waxwing, yeah, wasn't mean as a something related to v0.6.3.1 at all, just something I noticed today
15:46 < DeanWeen> waxwing: thanks I got it working, just trying to spread the info
15:48 < DeanWeen> https://github.com/JoinMarket-Org/joinmarket/wiki/Sending-payments-with-CoinJoin 
15:48 < DeanWeen> Is there another way to specify the bitcoin rpc wallet to use?  I'm getting an error: sendpayment.py: error: no such option: --rpcwallet
15:48 < DeanWeen> the bottom of that page says to use --rpcwallet
15:49 -!- k3tan [~pi@unaffiliated/k3tan] has quit [Quit: WeeChat 2.8]
15:51 -!- k3tan [~pi@unaffiliated/k3tan] has joined #joinmarket
15:54 -!- k3tan [~pi@unaffiliated/k3tan] has quit [Client Quit]
15:57 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net]
15:58 -!- k3tan [~pi@unaffiliated/k3tan] has joined #joinmarket
15:58 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket
16:03 -!- midnight [~midnight@unaffiliated/midnightmagic] has quit [Quit: -->]
16:09 -!- midnight [~midnight@unaffiliated/midnightmagic] has joined #joinmarket
16:28 < qubenix> DeanWeen: i think that's the old wiki, i'm not sure that info is relevant anymore. definitely --rpcwallet is no longer an option in sendpayment.py. current usage links are in the readme, in the usage section: https://github.com/JoinMarket-Org/joinmarket-clientserver
17:07 < DeanWeen> qubenix thanks
17:19 < DeanWeen> though I'm not seeing where it takes the rpcwallet name.  I see that in the joinmarket.cfg but sendpayment.py wants a joinmarket wallet name.  I don't have any of those.  Do I have to create one and then I guess import private keys?
17:23 < kristapsk> DeanWeen, --rpcwallet= was for sending coinjoins from Bitcoin Core wallet, that isn't supported since wallet rewrite for some time, see https://github.com/JoinMarket-Org/joinmarket-clientserver/issues/468
17:24 < kristapsk> rpcwallet in joinmarket.cfg is needed if you have multiple wallets loaded in Core
17:24 < kristapsk> JM wallet should be created using wallet-tool.py generate
17:24 < kristapsk> JM imports necessary addresses into Core wallet as watch-only, but all privkeys are in JM wallet
17:26 -!- k3tan [~pi@unaffiliated/k3tan] has quit [Quit: WeeChat 2.8]
17:26 < kristapsk> when JM wallet is created, then you deposit bitcoins into mixdepth 0 of the wallet
17:29 -!- slivera_ [~slivera@103.231.88.30] has joined #joinmarket
17:30 < DeanWeen> so if I import private keys, I'm guessing it does rescan=true on the importprivkey to the bitcoin core wallet?  Or how does it know about old transactions?
17:31 < kristapsk> DeanWeen, waxwing, about CentOS stuff - probably https://github.com/JoinMarket-Org/joinmarket-clientserver/blob/master/docs/INSTALL.md#installation-on-linux needs to be the place where required depedencies for various distros could be spcified
17:31 < kristapsk> DeanWeen, I have never used importprivkey feature of JM wallet
17:31 -!- slivera [~slivera@103.231.88.10] has quit [Ping timeout: 246 seconds]
17:32 < kristapsk> but when you restore old JM wallet with new Core instance then you need to do bitcoin-cli rescanblockchain
17:35 -!- k3tan [~pi@unaffiliated/k3tan] has joined #joinmarket
17:37 < DeanWeen> ok thanks kristapsk
17:44 -!- DSRelBot [~DSRelBot@p54866559.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
17:44 -!- HackRelay [~jmrelayha@p54866559.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
17:59 -!- DSRelBot [~DSRelBot@p54866aac.dip0.t-ipconnect.de] has joined #joinmarket
18:00 -!- HackRelay [~jmrelayha@p54866aac.dip0.t-ipconnect.de] has joined #joinmarket
18:46 -!- slivera_ [~slivera@103.231.88.30] has quit [Remote host closed the connection]
19:27 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
19:27 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #joinmarket
19:46 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
19:46 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #joinmarket
20:16 -!- deafboy [quasselcor@cicolina.org] has quit [Ping timeout: 240 seconds]
20:40 -!- k3tan [~pi@unaffiliated/k3tan] has quit [Read error: Connection reset by peer]
21:05 -!- EvanitoC [~Evanito@cpe-76-87-174-228.socal.res.rr.com] has joined #joinmarket
21:06 -!- Evanito [~Evanito@cpe-76-87-174-228.socal.res.rr.com] has quit [Ping timeout: 260 seconds]
21:31 -!- k3tan [~pi@unaffiliated/k3tan] has joined #joinmarket
22:17 < HackRelay> [hackint-irc/Anything1] Hello all
22:18 < HackRelay> [hackint-irc/Anything1] Need some help, anyone online please?
22:38 < HackRelay> [hackint-irc/Anything1] disconnect
23:37 -!- deafboy [quasselcor@cicolina.org] has joined #joinmarket
--- Log closed Sun Jun 28 00:00:03 2020