--- Log opened Thu Aug 06 00:00:41 2020
00:19 -!- Livestradamus [~quassel@unaffiliated/livestradamus] has quit [Quit: I'm out.]
00:19 -!- Livestradamus [~quassel@unaffiliated/livestradamus] has joined #joinmarket
01:02 -!- takamatsu [~takamatsu@unaffiliated/takamatsu] has quit [Ping timeout: 246 seconds]
01:04 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #joinmarket
01:57 -!- M1 [~Michail@66.113.248.97] has quit [Ping timeout: 246 seconds]
01:58 -!- takamatsu [~takamatsu@unaffiliated/takamatsu] has joined #joinmarket
02:00 -!- M1 [~Michail@michail.com] has joined #joinmarket
02:07 -!- takamatsu [~takamatsu@unaffiliated/takamatsu] has quit [Remote host closed the connection]
02:07 -!- takamatsu [~takamatsu@unaffiliated/takamatsu] has joined #joinmarket
02:15 -!- slivera__ [~slivera@217.138.204.138] has quit [Quit: Leaving]
02:53 -!- takamatsu [~takamatsu@unaffiliated/takamatsu] has quit [Ping timeout: 264 seconds]
02:57 -!- Evanito [~Evanito@cpe-76-87-174-228.socal.res.rr.com] has quit [Read error: Connection reset by peer]
03:02 -!- Dulce39Parisian [~Dulce39Pa@static.57.1.216.95.clients.your-server.de] has quit [Remote host closed the connection]
03:04 -!- Kasey41Wuckert [~Kasey41Wu@static.57.1.216.95.clients.your-server.de] has joined #joinmarket
04:06 -!- takamatsu [~takamatsu@unaffiliated/takamatsu] has joined #joinmarket
05:14 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #joinmarket
05:17 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds]
06:12 -!- Tralfaz is now known as davterra
07:05 -!- MaxSan [~four@185.156.175.171] has joined #joinmarket
07:35 -!- undeath [~undeath@hashcat/team/undeath] has joined #joinmarket
07:44 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Read error: Connection reset by peer]
07:44 -!- Zenton [~user@unaffiliated/vicenteh] has joined #joinmarket
08:52 -!- Evanito [~Evanito@cpe-76-87-174-228.socal.res.rr.com] has joined #joinmarket
10:29 -!- jules23 [ced9cd4e@206.217.205.78] has joined #joinmarket
10:36 < jules23> waxwing i have a question about import_private_key in wallet.py
10:36 < jules23> kristapsk let me know if you are here as well
10:38 < jules23> my question is the following: calling import_private_key should not change the object's wallet TYPE right? 
10:39 < jules23> im asking because in test_coinjoin_mixed_maker addresses, we import private keys from the second list of wallets to the first
10:39 < jules23> which at the moment does not change the wallet's type in the first list
10:40 -!- Kasey41Wuckert [~Kasey41Wu@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 246 seconds]
10:40 < jules23> but now that i am relying on the wallet type to send a sigmsg with the correct syntax, this causes problems when doing signature exchange
10:40 < kristapsk> jules23, I'm here now
10:41 < jules23> ok! what do you think?
10:43 < jules23> essentially, there are two options for changing the wallet types in the first list to the correct ones
10:44 < jules23> either i do it in import_private_key or I do it separately 
10:46 < kristapsk> I'm no expert of that part of code, need to look at it
10:47 < jules23> ok! thanks i'll be here so let me know if i can clarify anything
10:48 < jules23> jmclient/test/test_coinjoin.py line 290 is the key line i'm asking about
10:48 < jules23> a well line numbers are probably different on your machine
11:30 < jules23> also i am aware that the issue here only shows up in the test for mixed maker addresses, which we don't support officially, so let me know if we can get rid of this test... im saying this because i don't know how important it is to have this test work like it should
11:38 -!- undeath [~undeath@hashcat/team/undeath] has quit [Quit: WeeChat 2.8]
11:40 -!- fiatjaf [~fiatjaf@2804:7f2:2a84:85ff:ea40:f2ff:fe85:d2dc] has joined #joinmarket
11:55 -!- xochon [~user@gateway/tor-sasl/xochon] has quit [Remote host closed the connection]
11:55 -!- xochon [~user@gateway/tor-sasl/xochon] has joined #joinmarket
12:21 < waxwing> jules23, pong
12:23 < jules23> ping!
12:23 < waxwing> hmm it'll take me a bit to figure out, but: there was a long standing problem with importing keys and setting a 'wallet_type', since as the comment in cryptoengine said, we weren't working on an actual standard for representing script types in WIF
12:24 < jules23> right
12:25 < jules23> as i mentioned above, im just not sure if this should be a priority, because this is a problem only for this particular test as far as I know
12:25 < waxwing> First, see #639 for a recent edit and note the comment in cryptoengine.wif_to_privkey that i added
12:26 < waxwing> and the other is https://github.com/JoinMarket-Org/joinmarket-clientserver/blob/master/jmclient/jmclient/wallet.py#L1568-L1573 so the upshot is basically we can't use that key_type field, we can only import, check it's valid WIF and assume it's our current script type.
12:27 < waxwing> sorry if i'm repeating what is already known.
12:27 < jules23> no at all thanks for clarifying i appreciate your time
12:28 < waxwing> damn it's tricky to figure out exactly what's going on in that test. i think undeath wrote it. i'll try to remember.
12:30 < waxwing> Ah ok. that is something that #639 might have changed? are you saying it fails now?
12:31 < waxwing> sorry #652 not #639
12:32 < waxwing> oh no, i'm wrong, i didn't actually change the engine code in that commit
12:32 < jules23> it only fails when I add logic in maker.py that relies on the wallet type to determine the correct syntax to use for sigmsg
12:36 < waxwing> ah i see. interesting.
12:37 < waxwing> as i'm reading this, i appreciate the idea behind it, but i'm inclined towards removing this idea, since i don't think we really can support multiple address types in the wallet right now.
12:38 < jules23> what's the idea you have in mind exactly?
12:39 < waxwing> yeah my inclination is to (a) remove that test (it is never happening irl), and (b) enforce that import_private_key doesn't allow alternative key types (all the more so because we don't have a standard for it)
12:39 < waxwing> (there will be descriptors later, but not now)
12:41 < waxwing> i.e. i think we should/can only support import of keys of the same type that we have in the wallet, for now. even supporting private key import is one of the more icky and dangerous things we have, let alone keys of multiple types. that's a bit of a wallet maintenance nightmare.
12:42 < jules23> ok yes i see
12:42 < jules23> for the bech32 PR should I just remove that test, or do you want me to add a commit that adds this enforcement logic in import_private_key?
12:43 < jules23> * meaning either a) i remove that test or b) I remove that test and add the enforcement logic
12:43 < waxwing> i think just put up a small PR to remove that test and to just drop the argument for key_type to import_private_key (and make edits elsewhere in line with that)
12:43 < waxwing> then we can merge that straight away
12:43 < waxwing> and you can rebase
12:43 < jules23> sounds good
12:50 < jules23> im working on this small pr right now will put it up soon hopefully
12:55 < jules23> i'm working through the tests right now, there are actually quite a few that use this key_type argument i'm dropping
13:02 < waxwing> mostly just the wallet test though isn't it
13:02 < jules23> right yes
13:39 -!- davterra [~Davterra@37.120.215.173] has quit [Ping timeout: 256 seconds]
14:35 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Read error: Connection reset by peer]
14:36 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket
15:52 -!- slivera [~slivera@217.138.204.138] has joined #joinmarket
15:56 -!- davterra [~Davterra@37.120.215.173] has joined #joinmarket
15:57 -!- asymptotically [~asymptoti@gateway/tor-sasl/asymptotically] has quit [Quit: Leaving]
16:02 -!- jules23 [ced9cd4e@206.217.205.78] has quit [Ping timeout: 245 seconds]
17:31 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Read error: Connection reset by peer]
17:32 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket
17:54 -!- DSRelBot [~DSRelBot@p54866cb9.dip0.t-ipconnect.de] has quit [Ping timeout: 256 seconds]
17:55 -!- HackRelay [~jmrelayha@p54866cb9.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
18:08 -!- DSRelBot [~DSRelBot@p54866d3d.dip0.t-ipconnect.de] has joined #joinmarket
18:11 -!- HackRelay [~jmrelayha@p54866d3d.dip0.t-ipconnect.de] has joined #joinmarket
18:19 -!- xochon [~user@gateway/tor-sasl/xochon] has quit [Remote host closed the connection]
18:20 -!- xochon [~user@gateway/tor-sasl/xochon] has joined #joinmarket
18:22 -!- jules23 [4486dbb5@pool-68-134-219-181.bltmmd.fios.verizon.net] has joined #joinmarket
18:23 < jules23> kristapsk do you want me to try to attempt a BIP78 payjoin with your PR? or do you want me to wait for further changes?
18:30 < kristapsk> jules23, you can definitely try, further changes will be UI/UX nuances (+ docs)
18:30 < kristapsk> I hope to get back to this in weekend
18:38 -!- MaxSan [~four@185.156.175.171] has quit [Quit: Leaving.]
18:40 < jules23> ok!
18:50 -!- Evanito [~Evanito@cpe-76-87-174-228.socal.res.rr.com] has quit [Remote host closed the connection]
18:50 -!- Evanito [~Evanito@cpe-76-87-174-228.socal.res.rr.com] has joined #joinmarket
18:51 -!- Evanito [~Evanito@cpe-76-87-174-228.socal.res.rr.com] has quit [Read error: Connection reset by peer]
18:51 -!- Evanito [~Evanito@cpe-76-87-174-228.socal.res.rr.com] has joined #joinmarket
19:06 -!- HackRelay [~jmrelayha@p54866d3d.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
19:06 -!- DSRelBot [~DSRelBot@p54866d3d.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
19:20 -!- HackRelay [~jmrelayha@p548665a8.dip0.t-ipconnect.de] has joined #joinmarket
19:22 -!- DSRelBot [~DSRelBot@p548665a8.dip0.t-ipconnect.de] has joined #joinmarket
19:25 -!- jules23 [4486dbb5@pool-68-134-219-181.bltmmd.fios.verizon.net] has quit [Remote host closed the connection]
20:44 -!- Evanito [~Evanito@cpe-76-87-174-228.socal.res.rr.com] has quit [Read error: Connection reset by peer]
20:44 -!- Evanito [~Evanito@cpe-76-87-174-228.socal.res.rr.com] has joined #joinmarket
23:11 -!- sosthene [~sosthene@gateway/tor-sasl/sosthene] has quit [Remote host closed the connection]
23:12 -!- sosthene [~sosthene@gateway/tor-sasl/sosthene] has joined #joinmarket
23:43 -!- davterra [~Davterra@37.120.215.173] has quit [Ping timeout: 240 seconds]
--- Log closed Fri Aug 07 00:00:42 2020