--- Log opened Fri Aug 07 00:00:42 2020 00:08 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #joinmarket 00:29 -!- Evanito [~Evanito@cpe-76-87-174-228.socal.res.rr.com] has quit [Read error: Connection reset by peer] 00:33 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 01:23 -!- Davterra [~Davterra@37.120.215.165] has joined #joinmarket 01:23 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has joined #joinmarket 01:24 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds] 01:48 -!- asymptotically [~asymptoti@gateway/tor-sasl/asymptotically] has joined #joinmarket 02:07 -!- azizLIGHT [~azizLIGHT@unaffiliated/azizlight] has quit [Ping timeout: 265 seconds] 02:37 -!- k3tan [~pi@unaffiliated/k3tan] has quit [Ping timeout: 246 seconds] 02:37 -!- k3tan [~pi@unaffiliated/k3tan] has joined #joinmarket 02:42 -!- azizLIGHT [~azizLIGHT@unaffiliated/azizlight] has joined #joinmarket 02:52 -!- k3tan [~pi@unaffiliated/k3tan] has quit [Ping timeout: 246 seconds] 03:03 -!- Mathew7Kuhn [~Mathew7Ku@static.57.1.216.95.clients.your-server.de] has joined #joinmarket 04:00 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 04:20 -!- Mathew7Kuhn [~Mathew7Ku@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 260 seconds] 04:28 -!- sosthene [~sosthene@gateway/tor-sasl/sosthene] has quit [Remote host closed the connection] 04:33 -!- sosthene [~sosthene@gateway/tor-sasl/sosthene] has joined #joinmarket 05:14 -!- reallll [~belcher@unaffiliated/belcher] has joined #joinmarket 05:17 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Ping timeout: 246 seconds] 05:18 -!- reallll is now known as belcher 05:52 -!- takamatsu [~takamatsu@unaffiliated/takamatsu] has quit [Remote host closed the connection] 06:04 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds] 06:05 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #joinmarket 06:17 -!- jules23 [ced9cd6a@206.217.205.106] has joined #joinmarket 06:27 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #joinmarket 06:52 < jules23> waxwing in this comment from a few days ago: *** There is a detail about running manual coinjoins: open_test_wallet_maybe uses a test_wallet_cls argument 06:53 < jules23> in this one https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/656#issuecomment-669153633 06:53 < jules23> the testing infrastructure you mention 06:53 < waxwing> yes 06:53 < jules23> did you mean running multiple instances of ygrunner and having a taker work against them? 06:54 < waxwing> one instance of ygrunner; which is multiple (3) ygs (makers) 06:54 < waxwing> see the parametrization in ygrunner.py, you can edit that and have as many makers as you like running 06:55 < jules23> ok! and then run sendpayment and tumbler against them by following the usual wallet creation / funding flow? 06:57 < waxwing> yeah the idea is that that will start up the backend blockchain, fund the wallets and give you a taker seed 06:57 < waxwing> roughly explained in docs/TESTING.md (example invocation there) 06:57 < jules23> alright ok thanks 06:57 < waxwing> ignore the first line which i keep forgetting to remove :) 07:00 < waxwing> another thing easy to forget: since we changed to homedir for config, if you run `python sendpayment.py ... blah` for your taker in this scenario, you have to add `--datadir=.` to pick up your local test joinmarket.cfg, not the default homedir one 07:00 < waxwing> another thing needs updating in testing.md, that. 07:00 < waxwing> but it is not needed for the pytest commands which do that automatically (see `load_test_config()`) 07:01 < jules23> ok thanks for the tip 07:06 -!- undeath [~undeath@hashcat/team/undeath] has joined #joinmarket 07:06 < waxwing> oh and btw in case it isn't obvious, everything can be done on Qt there too, you just `python joinmarket-qt.py --datadir=.` and you can load the regtest wallet there. 07:08 < jules23> ok! can i pass in the taker wallet seed to the recover method on CLI? 07:08 < waxwing> no, that's where the special/weird test class logic comes in. 07:08 < waxwing> you just pass the hex seed as the wallet name on the command line 07:08 < jules23> ah ok 07:08 < waxwing> and it autodetects it in `open_test_wallet_maybe` 07:09 < waxwing> kind of a hangover, we should probably get rid of it just because it's a bit messy. you can also generate wallets in the normal way on regtest and get it saved to a file. 07:09 < waxwing> which for testing some things wallet related, is necessary. 07:09 < waxwing> but for transactions this hex thing is marginally more convenient (and again, works also on Qt) 07:11 < jules23> sounds good 07:13 < waxwing> test/payjoinserver.py operates the same way, but it's a bit "scuffed" ... i only just set up the bare minimum needed to do some local tests of bip78. for sure we can make that file significantly more usable/featured (have it spit out different bip21uris to copy/paste, plus see various TODOs in there) 07:16 < waxwing> i will fix up TESTING.md a bit 07:36 -!- slivera [~slivera@217.138.204.138] has quit [Remote host closed the connection] 07:39 < waxwing> belcher, can we bin the `addr-display-star-out` branch? since you closed it 08:19 -!- nixbitcoin_ [~nixbitcoi@gateway/tor-sasl/nixbitcoin] has quit [Ping timeout: 240 seconds] 08:20 -!- nixbitcoin [~nixbitcoi@gateway/tor-sasl/nixbitcoin] has joined #joinmarket 08:56 -!- MaxSan [~four@185.156.175.171] has joined #joinmarket 09:04 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 09:04 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket 09:09 -!- Evanito [~Evanito@cpe-76-87-174-228.socal.res.rr.com] has joined #joinmarket 09:12 < Davterra> jules32 what further help do you need in testing you Bech32 orderbook. I just put some testnet coins up using yg-privacyenhanced.py/default settings. 09:15 < dave_uy2> I have a Dockerfile project which I have yield generator running but everytime it is stopped it leaves the .lock file around. What signal does Joinmarket need to close cleanly, deleting the .lock file? 09:16 -!- dave_uy2 [~david@108.61.193.26] has quit [Quit: The Lounge - https://thelounge.chat] 09:17 -!- dave_uy [~david@108.61.193.26] has joined #joinmarket 09:22 < dave_uy> What signal does Joinmarket need to close cleanly, deleting the .lock file? 09:25 < waxwing> dave_uy, SIGINT, perhaps openoms message here might be helpful: https://github.com/JoinMarket-Org/joinmarket-clientserver/issues/628#issuecomment-654187593 09:25 < waxwing> from this: https://github.com/JoinMarket-Org/joinmarket-clientserver/blob/master/jmclient/jmclient/storage.py#L301 09:26 < dave_uy> Thank you! 09:26 < waxwing> Davterra, thanks that could be helpful. having a testnet pit running is a nice thing to have. we did it before segwit. 09:27 < dave_uy> I'm going to be running my own testnet yeildgenerator too Davterra. Thanks for doing that. 09:29 < Davterra> Sure...I can also fund a testnet taker wallet to run if needed. I'm rather new to joinmarket but I'm assuming I can''t run a maker/YG and taker function at the same time? 09:33 < jules23> Davterra thanks for the offer im actually planning to update the branch either today or tomorrow. What would be most helpful is to run the tests after I publish those changes 09:33 < jules23> *run the tests and do the testing you mention 09:33 < Davterra> No problem. I'm going to be afk most of today anyway, so I'll update after you do. 09:33 < jules23> great thanks 09:34 < Davterra> my pleasure 09:35 < waxwing> Davterra, basically you only run one bot against one wallet at a time. so you'd just fund multiple wallets to do that. 09:39 < Davterra> yeah, just figured that out...thank you 10:16 -!- stoner19_ is now known as stoner19 10:21 -!- tralfaz [uid458765@gateway/web/irccloud.com/x-ainivozefwllvmve] has joined #joinmarket 10:33 -!- tralfaz [uid458765@gateway/web/irccloud.com/x-ainivozefwllvmve] has quit [Quit: Updating details, brb] 10:33 -!- tralfaz [uid458765@gateway/web/irccloud.com/x-tirzfnobmtkfrlqh] has joined #joinmarket --- Log closed Fri Aug 07 10:58:26 2020 --- Log opened Fri Aug 07 10:58:26 2020 11:08 -!- k3tan [~pi@unaffiliated/k3tan] has joined #joinmarket 11:08 -!- Evanito [~Evanito@cpe-76-87-174-228.socal.res.rr.com] has quit [Remote host closed the connection] 11:09 -!- Evanito [~Evanito@cpe-76-87-174-228.socal.res.rr.com] has joined #joinmarket 11:13 -!- Davterra [~Davterra@37.120.215.165] has quit [Ping timeout: 256 seconds] 11:40 < jules23> hello ! im currently looking at parse_proposal_to_signed_tx in wallet.py 11:40 < jules23> i'm having some trouble making it work for bech32 wallets 11:41 < jules23> specifically this line 11:41 < jules23> https://github.com/JoinMarket-Org/joinmarket-clientserver/blob/7bf2ebb2cecbe9566b6416fca5d00c974067377b/jmclient/jmclient/wallet.py#L1472 11:41 < jules23> i'm working on this in order to make the test suite happy essentially 11:41 < waxwing> jules23, first point, it definitely has worked, since i tested it with the code currently on master against a live mainnet btcpay instance 11:42 < waxwing> oh sorry wrong feature :) 11:42 < waxwing> yeah that might be a bit tricky. but not too bad i guess. 11:43 < jules23> this issue shows up when i change the argument of open_test_wallet_maybe as you mentioned here 11:43 < jules23> https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/656#issuecomment-669153633 11:44 -!- vrana [~mvranic@gateway/tor-sasl/vrana] has quit [Ping timeout: 240 seconds] 11:45 < belcher> belcher, can we bin the `addr-display-star-out` branch? since you closed it <---- i just deleted it now 11:45 < waxwing> thanks 11:47 < waxwing> jules23, can you explain a bit more as this looks like it's going to be a bit obscure; you changed the `test_wallet_cls` argument to SegwitWallet, something like that? 11:47 < waxwing> and what exactly is the error also, since it'll be easier to figure it out from that 11:48 < jules23> so three things i changed: 11:48 < jules23> 1) open_test_wallet_maybe in wallet_utils to SegwitWallet 11:49 < jules23> 2) make_wallets to SegwitWallet in commontest 11:49 < jules23> 3) and same thing to make_wallets in test/common.py 11:50 < waxwing> right so changing defaults, makes sense 11:50 < waxwing> and error message? 11:50 < waxwing> could pastebin it 11:51 < jules23> yes coming in 11:52 -!- vrana [~mvranic@gateway/tor-sasl/vrana] has joined #joinmarket 11:52 < jules23> https://pastebin.com/F1cqfJFK 11:58 < jules23> unfortunately i am not familiar with the psbt spec so i could figure it out but would take me a while 12:01 < waxwing> it looks on the face of it like you are getting a blank PSBT_InputSignInfo for the unsigned input, instead of None 12:02 < waxwing> which is interesting/weird, it must have been returning None before. 12:03 < waxwing> (see the printed out "got sign result:" line) 12:04 < waxwing> this is the function that returns the signinfo data: https://github.com/Simplexum/python-bitcointx/blob/master/bitcointx/core/psbt.py#L827 12:05 < waxwing> see https://github.com/Simplexum/python-bitcointx/commit/5d46995adf01733beba1b51da0e185da792e2208 12:06 < waxwing> i have a suspicion maybe this was not in the release i was testing on when i wrote the snicker stuff, but so far i don't think i have a full explanation since it looks like maybe the same edit was done to all/both script types 12:08 < jules23> ok i'll be afk for a few hours then i'll get back to this 12:09 < waxwing> this line looks relevant: https://github.com/Simplexum/python-bitcointx/blob/master/bitcointx/core/psbt.py#L918 12:11 < waxwing> i can do some checking but my bet is that the return of None is just specific to the p2sh due to a quirk of that psbt input signing function, so the behaviour i was relying on does not cross over. we may PR it into python-bitcointx but in any case i can add a check that if a psbt input sign info is returned, it appropriately represents unsigned. 12:11 < waxwing> you don't need to worry about it, it's nothing to do with your stuff. 12:12 < jules23> ok 12:18 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 12:29 -!- Davterra [~Davterra@45.87.214.250] has joined #joinmarket 12:34 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #joinmarket 13:05 < waxwing> https://github.com/Simplexum/python-bitcointx/issues/39 just in case you want to keep track of it. it's not that big a deal whichever way it gets resolved. 13:17 < jules23> great thank you. To clarify, this error is cropping up when doing the test with p2wkh it seems to me, not so much p2sh. Just making sure we are on the same page here 13:22 -!- lnostdal [~lnostdal@cable-84-43-233-231.mnet.bg] has quit [Quit: "Fascism, Nazism, Communism and Socialism are only superficial variations of the same monstrous theme—collectivism." -- Ayn Rand] 13:30 -!- jules2390 [4486dbb5@pool-68-134-219-181.bltmmd.fios.verizon.net] has joined #joinmarket 13:32 -!- jules23 [ced9cd6a@206.217.205.106] has quit [Ping timeout: 245 seconds] 13:59 -!- jules2390 [4486dbb5@pool-68-134-219-181.bltmmd.fios.verizon.net] has quit [Remote host closed the connection] 14:05 < waxwing> yes 14:34 -!- slivera [~slivera@217.138.204.153] has joined #joinmarket 16:07 -!- xochon [~user@gateway/tor-sasl/xochon] has quit [Remote host closed the connection] 16:07 -!- xochon [~user@gateway/tor-sasl/xochon] has joined #joinmarket 16:27 -!- asymptotically [~asymptoti@gateway/tor-sasl/asymptotically] has quit [Quit: Leaving] 16:31 -!- Davterra [~Davterra@45.87.214.250] has quit [Ping timeout: 240 seconds] 16:44 -!- undeath [~undeath@hashcat/team/undeath] has quit [Quit: WeeChat 2.8] 17:00 -!- Davterra [~Davterra@37.120.215.165] has joined #joinmarket 17:05 -!- DSRelBot [~DSRelBot@p548665a8.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds] 17:06 -!- HackRelay [~jmrelayha@p548665a8.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds] 17:17 -!- DSRelBot [~DSRelBot@p5de4aa2a.dip0.t-ipconnect.de] has joined #joinmarket 17:22 -!- slivera [~slivera@217.138.204.153] has quit [Ping timeout: 246 seconds] 17:23 -!- HackRelay [~jmrelayha@p5de4aa2a.dip0.t-ipconnect.de] has joined #joinmarket 18:51 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 18:52 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #joinmarket 21:08 -!- fs1_ [~fs1@197.37.186.55] has joined #joinmarket 22:16 -!- rdymac [uid31665@gateway/web/irccloud.com/x-uemcvwaweymcefbu] has quit [Quit: Connection closed for inactivity] 22:52 -!- ponkaloupe [~ponkaloup@c-73-97-138-50.hsd1.wa.comcast.net] has quit [Ping timeout: 240 seconds] 22:53 -!- ponkaloupe [~ponkaloup@c-73-97-138-50.hsd1.wa.comcast.net] has joined #joinmarket 23:39 -!- slivera [~slivera@217.138.204.153] has joined #joinmarket --- Log closed Sat Aug 08 00:00:42 2020