--- Log opened Mon Mar 22 00:00:03 2021
00:16 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net]
00:17 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket
00:30 -!- jungly [~jungly@host-82-49-48-222.retail.telecomitalia.it] has joined #joinmarket
02:18 -!- undeath [~undeath@hashcat/team/undeath] has joined #joinmarket
02:24 -!- jonatack_ [~jon@37.166.124.247] has joined #joinmarket
02:27 -!- jonatack [~jon@37.166.26.72] has quit [Ping timeout: 240 seconds]
03:35 -!- jonatack_ [~jon@37.166.124.247] has quit [Ping timeout: 276 seconds]
03:40 -!- jonatack [~jon@37.166.124.247] has joined #joinmarket
04:20 -!- Margie64Predovic [~Margie64P@static.57.1.216.95.clients.your-server.de] has joined #joinmarket
04:44 -!- jonatack [~jon@37.166.124.247] has quit [Ping timeout: 265 seconds]
04:56 -!- jonatack [~jon@37.166.124.247] has joined #joinmarket
05:12 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
05:12 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #joinmarket
05:40 -!- Margie64Predovic [~Margie64P@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 246 seconds]
06:09 -!- jonatack [~jon@37.166.124.247] has quit [Read error: Connection reset by peer]
06:30 < waxwing> belcher, check log from 15:27 yesterday. although i think i pinged you about it on github anyway.
06:31 < belcher> looking now
06:33 < belcher> regarding iteritems() i really dont remember
06:34 < belcher> searching the web now
06:35 < belcher> honestly i think iv never heard of iteritems(), and the web says its a py2 feature that isnt in py3... which sounds weird to me because i definitely developed the fidelity bond wallet PR with python3... and git blame definitely shows i wrote that line.. so im a bit confused now
06:36 < belcher> but yeah looks like the best way is to replace it with dict.items() ? i always wouldve used items() anyway i think
06:37 < belcher> as for the old deserialization format, i havent been following joinmarket dev since i wrote the fidelity bond wallet PR so i dont know about the new format.... its slightly concerned that the tests didnt pick up on this mistake
06:38 < belcher> as i said i dont know what the new deserialization format looks like, so maybe it actually does still work
06:51 < waxwing> qubenix, so i tried on a debian 10 VM and everything seems to work correctly with that current PR835 code, assuming i follow the instructions: https://github.com/JoinMarket-Org/joinmarket-clientserver/blob/master/docs/PAYJOIN.md#configuring-tor-to-setup-a-hidden-service ; so i guess your input is to tell me what i should change there if it's not going to be sufficient either security wise, or depending on a different OS/setup
06:52 < waxwing> belcher, about iteritems: yeah it was that py2/py3 compatibility layer we had, i'm almost sure.
06:52 < waxwing> it got removed around that time. it allowed to write iteritems() i think, so it would still work on both py versions. we dropped py2 around then.
06:53 < waxwing> for the deserialization, i can help you, basically you have CTransaction.vin and .vout lists. i'll dig up a couple of code references, it's fairly formulaic and not a big deal.
06:53 < waxwing> re: tests not picking up issues here, yeah, we can/should look into that (albeit perfect coverage is a bit of a pipe dream right now)
06:59 < waxwing> (confusing but dict.iteritems() is def a py2 feature, but i think iteritems() is as above .. although at this point, academic :) )
07:01 < belcher> yes maybe there was a `from somewhere import iteritems` in py3
07:02 < waxwing> yeah it was .. forget the name of it .. but a boilerplate import we had in every file .. like from future import blah blah
07:02 < waxwing> and something else
07:02 < waxwing> here is definition of contents of CTransaction objects now: https://github.com/Simplexum/python-bitcointx/blob/master/bitcointx/core/__init__.py#L985-L989
07:03 < waxwing> you can chase the sub-object links, if you need to know the contents of e.g. CTxIn and CTxOut, but it's all fairly intuitive
07:03 < waxwing> there's some meaningful uses of those structures in jmbitcoin.secp256k1_transaction and jmclient.wallet as you'd expect
07:06 < waxwing> ah; this chunk of code, for reasons obvious in retrospect, is particularly useful for understanding the contents of a CTransaction: https://github.com/JoinMarket-Org/joinmarket-clientserver/blob/master/jmbitcoin/jmbitcoin/secp256k1_transaction.py#L24-L85
07:20 -!- undeath [~undeath@hashcat/team/undeath] has quit [Quit: WeeChat 3.0.1]
08:53 -!- undeath [~undeath@hashcat/team/undeath] has joined #joinmarket
10:25 -!- jonatack [~jon@37.166.77.159] has joined #joinmarket
12:06 -!- jungly [~jungly@host-82-49-48-222.retail.telecomitalia.it] has quit [Ping timeout: 246 seconds]
12:56 < qubenix> waxwing: i think you're good to merge #835. i can get it to work if i disable onion-grater. i don't think there's any reason to hold up the pr for a nuance that only concerns privacy focused OSs.
14:00 -!- jonatack [~jon@37.166.77.159] has quit [Remote host closed the connection]
14:00 -!- jonatack [~jon@37.166.77.159] has joined #joinmarket
14:23 -!- jonatack_ [~jon@37.166.59.253] has joined #joinmarket
14:27 -!- jonatack [~jon@37.166.77.159] has quit [Ping timeout: 260 seconds]
14:37 < waxwing> qubenix, gotcha, thanks. i am def open to making a change to reduce the queries it's doing on the control port though.
15:49 < qubenix> waxwing: if you could eliminate the call `SETEVENTS CONF_CHANGED HS_DESC`, it would work on Whonix with my onion-grater profile. It would be cool to also get it to where the private key of the onion is not needed (bitcoind replaces an empty onion private key: https://github.com/bitcoin/bitcoin/blob/c46f1ce75196860c8b036d2965faac7db3aa4414/src/torcontrol.cpp#L378 ).
16:05 < waxwing> qubenix, great. i'll try to look into it tomorrow and get back to you.
16:56 -!- undeath [~undeath@hashcat/team/undeath] has quit [Quit: WeeChat 3.0.1]
17:20 -!- jonatack_ [~jon@37.166.59.253] has quit [Ping timeout: 240 seconds]
19:20 -!- achow101 [~achow101@unaffiliated/achow101] has quit [Quit: Bye]
19:22 -!- achow101 [~achow101@unaffiliated/achow101] has joined #joinmarket
20:10 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #joinmarket
20:15 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Client Quit]
20:15 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #joinmarket
21:21 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #joinmarket
21:24 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds]
22:32 -!- jungly [~jungly@host-82-59-148-94.retail.telecomitalia.it] has joined #joinmarket
23:28 -!- jungly [~jungly@host-82-59-148-94.retail.telecomitalia.it] has quit [Ping timeout: 256 seconds]
23:28 -!- jungly [~jungly@host-82-59-148-94.retail.telecomitalia.it] has joined #joinmarket
23:59 -!- jungly [~jungly@host-82-59-148-94.retail.telecomitalia.it] has quit [Ping timeout: 256 seconds]
--- Log closed Tue Mar 23 00:00:04 2021