--- Log opened Wed Jun 30 00:00:52 2021
00:37 <+JoinMarketRelay> [hackint/yPsTDQ]fhmlCimA]] if Wallet service transaction_monitor recognize external removed utxo, the maker not update it maxsize accordingly? i tried call the the resync_wallet(fast=False) does not notify offerlist ? because mixdepth balance return value didnt include newly added utxos balance
01:07 < waxwing> it will only reflect the new balance after you restart your yieldgenerator. also only confirmed coins are offered for coinjoins.
01:08 -!- jungly [~jungly@host-87-20-186-85.retail.telecomitalia.it] has joined #joinmarket
01:26 <+JoinMarketRelay> [hackint/yPsTDQ]fhmlCimA]] ok. yes, i saw the minconfs=1 in the balance check.
01:27 <+JoinMarketRelay> [hackint/yPsTDQ]fhmlCimA]] i thought the monitior may could add newly confirmed utxos to it just in time.
01:28 < waxwing> it could and should
01:28 < waxwing> just nobody's done it yet
01:37 <+JoinMarketRelay> [hackint/yPsTDQ]fhmlCimA]] oh
01:38 <+JoinMarketRelay> [hackint/yPsTDQ]fhmlCimA]] that can be nice to have.
01:38 <+JoinMarketRelay> [hackint/yPsTDQ]fhmlCimA]] but for the removed utxos,
01:38 <+JoinMarketRelay> [hackint/yPsTDQ]fhmlCimA]] the maxsize in offer is not decreased,
01:39 < waxwing> it should be. after a coinjoin happens, the offer is recalculated on the new utxo set.
01:39 <+JoinMarketRelay> [hackint/yPsTDQ]fhmlCimA]] but mixdepth balance does not include theam anymore. leading into no answer on !fill from taker
01:39 < waxwing> maxsize may not change in case the offer was filled from a mixdepth which is not the max
01:42 <+JoinMarketRelay> [hackint/yPsTDQ]fhmlCimA]] that could be it. in my logs, the "mix depths that have enough" size was < offers maxsize
01:42 <+JoinMarketRelay> [hackint/yPsTDQ]fhmlCimA]] so i did fear, if taker asks for offered maxsized, it couldn't be filled
01:49 <+JoinMarketRelay> [hackint/yPsTDQ]fhmlCimA]] if you say "it could and should" is this worth a issue on github?
01:50 < waxwing> i'm not sure if it's there already but sure. it's something i've pointed  out like 5 times on here and probably on github, it should be added.
01:51 < waxwing> actually i remember writing this somewhere on one issue or another, feel free.
01:51 <+JoinMarketRelay> [hackint/yPsTDQ]fhmlCimA]] i missed that berofe
01:51 <+JoinMarketRelay> [hackint/yPsTDQ]fhmlCimA]] before*
01:54 < waxwing> wasn't a criticism, i didn't expect you to have seen it before
01:54 <+JoinMarketRelay> [hackint/yPsTDQ]fhmlCimA]] :)
03:22 -!- SomeFellow [~SomeFello@194.54.28.203] has joined #joinmarket
03:57 < waxwing> belcher_, i just realised something about what you said yesterday. you said squashing might be a non-trivial step, and i remembered that's because you're planning to squash in groups, right.
03:57 < waxwing> and those groups are not all currently in order.
03:57 < belcher_> yes
03:58 < waxwing> i've never tried to do that but might it end up needing non-trivial rebasing (or whatever the right term is)
03:58 < belcher_> it should be ok
03:58 < belcher_> i did similar stuff for the fidelity bond wallets PR
03:58 < waxwing> if that's the case, can i reverse my previous statement:
03:58 < belcher_> its a bit fiddly but not impossible
03:58 < waxwing> please do it now or asap, anyway.
03:58 < belcher_> ah ok
03:58 < belcher_> sure
03:58 < waxwing> because there's no point me doing detailed testing and then having to do it again in case something changed.
03:58 < waxwing> right :)
03:58 <+JoinMarketRelay> [hackint/yPsTDQ]fhmlCimA]] fiddly fidelity
03:59 < belcher_> yep
03:59 < belcher_> my intention was i would squish first before detailed testing
03:59 < belcher_> i would only wait to squish if you want to glance at the code edits in the last time you looked
03:59 < belcher_> so yes ill do that
03:59 < waxwing> yeah got it. i think those changes are fine.
04:00 < waxwing> the first thing i'll do is probably a repeat of https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/872#issuecomment-852220865 but then a few other things too.
04:25 -!- lg28 [~lg@cpe-95.143.151.80.cable.kanet.si] has joined #joinmarket
04:26 -!- lg28 [~lg@cpe-95.143.151.80.cable.kanet.si] has quit [Client Quit]
04:47 < belcher_> yep
04:47 < belcher_> i replied to undeath's comment about exception vs return value
04:48 < belcher_> i didnt know it was also used in the lnd codebase
04:54 < waxwing> yeah pretty sure it's a golang thing, but there's some finesse there about exactly *how* one uses that pattern.
04:55 < belcher_> its also used in rust which surely influenced me a bit, rust doesnt have exceptions at all only return values, and its pretty nice although the features that make it very nice are not included in python so its not easy to just adopt that pattern
05:07 < waxwing> ah i see, didn't know
10:30 -!- shiza [~admin@ec2-52-208-131-13.eu-west-1.compute.amazonaws.com] has joined #joinmarket
11:12 -!- belcher_ is now known as belcher
11:49 -!- SomeFellow [~SomeFello@194.54.28.203] has quit [Quit: Connection closed]
12:02 -!- openoms [~quassel@gateway/tor-sasl/openoms] has quit [Remote host closed the connection]
12:02 -!- openoms [~quassel@gateway/tor-sasl/openoms] has joined #joinmarket
12:05 -!- k3tan [~pi@user/k3tan] has quit [Ping timeout: 265 seconds]
12:19 -!- jungly [~jungly@host-87-20-186-85.retail.telecomitalia.it] has quit [Ping timeout: 272 seconds]
13:05 -!- jungly [~jungly@host-87-20-186-85.retail.telecomitalia.it] has joined #joinmarket
13:15 -!- WGJammie [~WGJammie@66.115.189.149] has joined #joinmarket
13:19 < WGJammie> i cant find any doc info on how to run multiple orders from one yg instance 
13:20 < WGJammie> I many counter partys with some number of Order IDs in the orderbook coming from the same yg instance i assume 
13:20 < belcher> you probably have to run one of the scripts here https://github.com/JoinMarket-Org/custom-scripts
13:20 < belcher> a different yield-generator script in other words
13:21 < WGJammie> ooo thanks ill check it out
13:33 <+JoinMarketRelay> [hackint/kristapsk] WGJammie, no public yg by JM project itself does that, you need to do custom coding
13:46 -!- k3tan [~pi@user/k3tan] has joined #joinmarket
14:24 -!- jungly [~jungly@host-87-20-186-85.retail.telecomitalia.it] has quit [Ping timeout: 240 seconds]
14:48 -!- undeath [~undeath@user/undeath] has quit [Quit: WeeChat 3.1]
15:00 -!- deafboy [quasselcor@cicolina.org] has quit [Quit: deafboy]
15:00 -!- deafboy [quasselcor@cicolina.org] has joined #joinmarket
15:08 -!- openoms[m] [~openomsma@2001:470:69fc:105::c2f] has quit [Remote host closed the connection]
15:08 -!- xyy [~xyy@2001:470:69fc:105::f2d] has quit [Remote host closed the connection]
15:08 -!- tiker[m] [~tikerfunk@2001:470:69fc:105::103a] has quit [Read error: Connection reset by peer]
15:08 -!- Evanito[m] [~evanito@2001:470:69fc:105::1ec] has quit [Remote host closed the connection]
15:09 -!- Evanito[m] [~evanito@2001:470:69fc:105::1ec] has joined #joinmarket
15:16 -!- xyy [~xyy@2001:470:69fc:105::f2d] has joined #joinmarket
15:16 -!- openoms[m] [~openomsma@2001:470:69fc:105::c2f] has joined #joinmarket
15:16 -!- tiker[m] [~tikerfunk@2001:470:69fc:105::103a] has joined #joinmarket
17:21 -!- belcher_ [~belcher@user/belcher] has joined #joinmarket
17:24 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 240 seconds]
21:00 -!- achow101 [~achow101@user/achow101] has quit [Quit: Bye]
21:00 -!- achow101 [~achow101@user/achow101] has joined #joinmarket
21:42 -!- surfer91 [~surfer91@102.67.16.112] has quit [Ping timeout: 246 seconds]
--- Log closed Thu Jul 01 00:00:53 2021