--- Day changed Thu Nov 09 2017 00:10 -!- cryptosoap [~cryptosoa@gateway/tor-sasl/cryptosoap] has quit [Remote host closed the connection] 00:10 -!- cryptosoap [~cryptosoa@gateway/tor-sasl/cryptosoap] has joined #lnd 00:15 -!- JackH [~laptop@85.219.170.195] has quit [Ping timeout: 268 seconds] 00:41 -!- JackH [~laptop@91.189.61.70] has joined #lnd 00:53 -github-lnd:#lnd- [lnd] samvrlewis opened pull request #402: chainntnfs: Fix btcdnotify race condition causing double heap add (master...btcd_chainntf_double_heap_add) https://git.io/vFuHM 01:17 -!- sycofly [~sycofly@121.99.240.44] has joined #lnd 01:30 -!- berndj [~berndj@mail.azna.co.za] has quit [Quit: ZNC - http://znc.in] 01:30 -!- berndj [~berndj@mail.azna.co.za] has joined #lnd 01:58 -!- sycofly [~sycofly@121.99.240.44] has quit [Quit: This computer has gone to sleep] 02:01 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-cjsvjihbxcftwfcq] has quit [Quit: Connection closed for inactivity] 02:04 -!- cryptosoap [~cryptosoa@gateway/tor-sasl/cryptosoap] has quit [Ping timeout: 248 seconds] 02:05 -!- cryptosoap [~cryptosoa@gateway/tor-sasl/cryptosoap] has joined #lnd 02:29 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #lnd 02:58 -!- moctos [~moctos@cpe-107-9-138-59.neo.res.rr.com] has joined #lnd 03:19 -!- moctos [~moctos@cpe-107-9-138-59.neo.res.rr.com] has quit [Ping timeout: 258 seconds] 03:37 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Remote host closed the connection] 03:38 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #lnd 05:23 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-qwadsucfsuxnbdzp] has quit [Quit: Connection closed for inactivity] 05:54 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has quit [Ping timeout: 240 seconds] 05:55 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has joined #lnd 06:30 -!- jakem [603b8952@gateway/web/freenode/ip.96.59.137.82] has joined #lnd 07:54 -!- StopAndDecrypt_ [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has joined #lnd 07:55 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has quit [Ping timeout: 260 seconds] 07:59 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has joined #lnd 08:01 -!- JackH [~laptop@91.189.61.70] has quit [Ping timeout: 240 seconds] 08:04 -!- pepesza [~pepesza@185.83.218.228] has joined #lnd 08:15 -!- JackH [~laptop@85.219.170.195] has joined #lnd 08:33 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 08:33 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #lnd 08:36 -!- jimmymow [~textual@73.110.37.219] has joined #lnd 08:40 -!- jimmymow [~textual@73.110.37.219] has quit [Ping timeout: 240 seconds] 08:44 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has quit [Quit: Leaving.] 09:03 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has joined #lnd 09:22 -!- sycofly [~sycofly@121.99.240.44] has joined #lnd 09:43 -!- sycofly [~sycofly@121.99.240.44] has quit [Quit: Leaving] 09:43 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has quit [Quit: Leaving.] 09:53 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has joined #lnd 10:35 -!- bule [~bule@gateway/tor-sasl/bule] has joined #lnd 10:40 < jimpo> I was looking over https://github.com/lightningnetwork/lnd/pull/402 and it looks like the btcd notifier doesn't handle reorgs well. I assume that's a known issue? https://github.com/lightningnetwork/lnd/blob/master/chainntnfs/btcdnotify/btcd.go#L310 10:40 <@roasbeef> jimpo: yep that's a known issue, iirc there's an issue tracking it 10:41 <@roasbeef> there's a slot for "negative" confirmations within the returned event struct which isn't being used atm 10:41 < jimpo> Yep 10:41 < jimpo> I can't find an open issue with a cursory search. Can you link if you know where it is? 10:42 < jimpo> Or I can make a new one. 10:54 -!- deusexbeer [~deusexbee@079-170-139-198-dynamic-pool-adsl.wbt.ru] has joined #lnd 10:55 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-trzimhxoutdkrwys] has joined #lnd 10:57 < jimpo> Also, can I get a look on #360 eventually? I think it would help as I'm looking at btcdnotify. 11:05 -!- aakselrod [~aakselrod@2601:281:c702:8621:d54:c4d:c0bc:2101] has quit [Ping timeout: 252 seconds] 11:18 -!- aakselrod [~aakselrod@2601:281:c702:8621:9f8:14b6:e092:f2b9] has joined #lnd 11:27 -!- chjj [~chjj@unaffiliated/chjj] has joined #lnd 11:34 -!- alanc__ [~chatzilla@109.255.196.64] has quit [Ping timeout: 240 seconds] 11:36 -!- alanc_ [~chatzilla@109.255.196.64] has joined #lnd 11:37 -!- bule [~bule@gateway/tor-sasl/bule] has quit [Ping timeout: 248 seconds] 11:45 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 248 seconds] 11:54 -!- bule [~bule@gateway/tor-sasl/bule] has joined #lnd 11:58 -!- rjromero [~rjromero@209.147.148.5] has joined #lnd 12:00 -!- rjromero [~rjromero@209.147.148.5] has quit [Client Quit] 12:03 -github-lnd:#lnd- [lnd] Roasbeef pushed 2 new commits to master: https://git.io/vFglC 12:03 -github-lnd:#lnd- lnd/master 9a2c2cd Olaoluwa Osuntokun: lnwire: add new FundingFlag type for OpenChannel... 12:03 -github-lnd:#lnd- lnd/master 3764e5c Olaoluwa Osuntokun: funding: by default, signal to announce initiated channel to network 12:05 <@roasbeef> aight w/ that latest push, we should achieve green-ness on cdecker's set of initial cross-impl integration tests 12:25 -!- cl0uding [~cl0uding@79.109.241.185.dyn.user.ono.com] has quit [Ping timeout: 268 seconds] 12:36 < lndbot> ;o 12:38 -!- cl0uding [~cl0uding@79.109.241.185.dyn.user.ono.com] has joined #lnd 12:59 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection] 12:59 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #lnd 13:00 -!- bule [~bule@gateway/tor-sasl/bule] has quit [Quit: Leaving] 13:08 -!- bule [~bule@gateway/tor-sasl/bule] has joined #lnd 13:15 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection] 13:15 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #lnd 13:37 -!- zshlyk is now known as intcat 13:52 -!- alanc_ [~chatzilla@109.255.196.64] has quit [Ping timeout: 248 seconds] 14:06 -!- _yes [57b8a23d@gateway/web/freenode/ip.87.184.162.61] has joined #lnd 14:36 -!- chjj [~chjj@unaffiliated/chjj] has joined #lnd 14:43 -!- _yes [57b8a23d@gateway/web/freenode/ip.87.184.162.61] has quit [Quit: Page closed] 14:56 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has joined #lnd 14:56 -!- StopAndDecrypt_ [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has quit [Ping timeout: 268 seconds] 15:01 -!- cryptosoap [~cryptosoa@gateway/tor-sasl/cryptosoap] has quit [Remote host closed the connection] 15:01 -!- cryptosoap [~cryptosoa@gateway/tor-sasl/cryptosoap] has joined #lnd 15:01 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 268 seconds] 15:12 -!- chjj [~chjj@unaffiliated/chjj] has joined #lnd 15:25 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 268 seconds] 15:26 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has quit [Ping timeout: 240 seconds] 15:27 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has joined #lnd 15:46 -!- moctos [~moctos@cpe-107-9-138-59.neo.res.rr.com] has joined #lnd 15:55 -!- moctos [~moctos@cpe-107-9-138-59.neo.res.rr.com] has quit [Ping timeout: 240 seconds] 16:14 -!- mnkk___ [~mnk4@95.90.233.42] has quit [] 16:14 -!- moctos [~moctos@cpe-107-9-138-59.neo.res.rr.com] has joined #lnd 16:19 -!- moctos [~moctos@cpe-107-9-138-59.neo.res.rr.com] has quit [Ping timeout: 248 seconds] 16:29 <@roasbeef> aight all the unit tests on my retransmission branch pass now!! 16:29 <@roasbeef> quite the yak shaving escapade in the branch lol 16:29 <@roasbeef> will hopefully be able to get it out by the EOD 16:33 <@roasbeef> want to follow up witha more comprehensive fuzzer based on the testing/quick package, but this'll do for now 16:51 -github-lnd:#lnd- [lnd] cfromknecht opened pull request #404: lnrpc: Adds PendingHtlcs to ForceClosedChannels (master...lnrpc-pending-htlcs) https://git.io/vFgNd 17:03 -github-lnd:#lnd- [lnd] cfromknecht opened pull request #405: lnwallet: Add 2nd-stage htlc size constants and outgoing GenWitnessFunc (master...lnwallet-htlc-witness) https://git.io/vFgAN 17:48 -!- chjj [~chjj@unaffiliated/chjj] has joined #lnd 17:49 -!- mnkk___ [~mnk4@ip5f5ae92a.dynamic.kabel-deutschland.de] has joined #lnd 17:54 -!- deusexbeer [~deusexbee@079-170-139-198-dynamic-pool-adsl.wbt.ru] has quit [Quit: Konversation terminated!] 18:02 -!- deusexbeer [~deusexbee@079-170-139-198-dynamic-pool-adsl.wbt.ru] has joined #lnd 18:33 -!- StopAndDecrypt_ [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has joined #lnd 18:34 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has quit [Ping timeout: 268 seconds] 18:36 -!- PaulCape_ [~PaulCapes@ip68-100-207-53.dc.dc.cox.net] has quit [Read error: Connection reset by peer] 18:37 -!- PaulCapestany [~PaulCapes@ip68-100-207-53.dc.dc.cox.net] has joined #lnd 18:44 -!- StopAndDecrypt_ [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has quit [Ping timeout: 248 seconds] 18:44 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has joined #lnd 19:15 -!- StopAndDecrypt_ [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has joined #lnd 19:16 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has quit [Ping timeout: 268 seconds] 19:26 <@roasbeef> jimpo: here's that tool I was talking about: https://godoc.org/golang.org/x/tools/cmd/benchcmp 19:30 <@roasbeef> jimpo: the "Traps for young players" section goes over some of the golang gotchas https://dave.cheney.net/2013/06/30/how-to-write-benchmarks-in-go 19:42 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 248 seconds] 20:46 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has quit [Ping timeout: 240 seconds] 20:46 -!- pigeons_ is now known as pigeons 21:27 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has joined #lnd 22:11 -!- warxhead [warxhead@c-73-243-180-191.hsd1.co.comcast.net] has joined #lnd 22:20 -!- snadge [~snadge@unaffiliated/snadge] has quit [Quit: ZNC 1.6.5+deb1 - http://znc.in] 22:34 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-oxfjtavbgbgevgpn] has joined #lnd 22:34 -!- snadge [~snadge@2404:9400:1::6d7:0:1] has joined #lnd 22:34 -!- snadge [~snadge@2404:9400:1::6d7:0:1] has quit [Changing host] 22:34 -!- snadge [~snadge@unaffiliated/snadge] has joined #lnd 23:48 -!- JackH [~laptop@85.219.170.195] has quit [Ping timeout: 248 seconds] 23:51 -!- bule [~bule@gateway/tor-sasl/bule] has quit [Ping timeout: 248 seconds]