--- Day changed Mon Jun 08 2020
00:19 < sanket1729> Since, we are expecting users to only use Miniscript via Descriptors, I was thinking context is implicitly captured in descriptor. 
00:49 < sanket1729> Keeping it miniscript also makes sense. It would require a separate struct to capture the MiniscriptTreeRoot since we probably don't want that info stored recursively.
01:07 -!- jonatack_ [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Quit: jonatack_]     
01:23 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined ##miniscript     
04:45 -!- instagibbs [~instagibb@pool-71-178-191-230.washdc.fios.verizon.net] has quit [Ping timeout: 256 seconds]     
04:46 -!- instagibbs [~instagibb@pool-71-178-191-230.washdc.fios.verizon.net] has joined ##miniscript     
05:35 -!- dr-orlovsky [~Dr_Orlovs@31.14.40.19] has quit [Ping timeout: 265 seconds]     
06:47 -!- dr-orlovsky [~Dr_Orlovs@31.14.40.19] has joined ##miniscript     
07:37 -!- davterra [~dulyNoded@185.212.170.229] has quit [Remote host closed the connection]     
07:37 -!- davterra [~dulyNoded@185.212.170.229] has joined ##miniscript     
10:05 < sanket1729> https://gist.github.com/sanket1729/a53fcdc6bbcc4bf71c257b69c5931d87 Does this reflect what you were thinking?
10:17 < andytoshi> sanket1729: sure .. empty enums rather than empty structs
10:17 < andytoshi> but also, i'm surprised that the context needs to be parameterized by pk
10:19 < andytoshi> see e.g. https://github.com/rust-bitcoin/rust-secp256k1/blob/master/src/context.rs for ideas
10:19 < andytoshi> notice the empty enums and also the use of the `Sealed` trait
10:20 < andytoshi> also that the `Sealed` trait is declared `pub` inside a private module, which is a hack to evade rust's rules about what things need to be pub
10:42 < sanket1729> andytoshi, looking at it now. Would it be possible to use pub(crate) trait Context instead of private Sealed trait?
10:42 < sanket1729> Or maybe it is not supported for 1.22.0
10:46 < andytoshi> i'm not sure
10:46 < andytoshi> iirc it's 1.23
10:46 < andytoshi> but worth a shot
11:31 < sanket1729> w.r.t paramterized by Pk, I was thinking the is_valid() could check whether the fragment was valid was not. And would require a `Terminal<Pk>`.  
11:32 < sanket1729> Atleast somewhere in the code we need to check the context conditions
11:32 < sanket1729> And those have to depend on Pk?
13:27 -!- davterra [~dulyNoded@185.212.170.229] has quit [Ping timeout: 260 seconds]     
13:48 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Remote host closed the connection]     
13:48 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined ##miniscript     
15:18 -!- davterra [~dulyNoded@s17612523583.blix.com] has joined ##miniscript     
15:28 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection]     
15:29 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined ##miniscript     
18:50 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined ##miniscript     
18:50 -!- harrigan- [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Read error: Connection reset by peer]     
23:24 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Remote host closed the connection]