--- Day changed Mon Oct 19 2020 00:24 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 272 seconds] 00:30 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 256 seconds] 01:27 -!- jonatack [~jon@37.165.8.123] has joined ##miniscript 03:01 -!- jonatack [~jon@37.165.8.123] has quit [Read error: Connection reset by peer] 03:15 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 04:51 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined ##miniscript 05:08 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has joined ##miniscript 05:09 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds] 05:28 -!- shesek [~shesek@164.90.217.137] has joined ##miniscript 05:28 -!- shesek [~shesek@164.90.217.137] has quit [Changing host] 05:28 -!- shesek [~shesek@unaffiliated/shesek] has joined ##miniscript 07:55 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Quit: jonatack] 08:00 -!- jonatack [~jon@213.152.161.35] has joined ##miniscript 09:53 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined ##miniscript 15:54 < sanket1729> I think we are close to finalizing miniscript(without tapscript) once we have resource limits PRs in. 15:54 < sanket1729> One of things that I wanted to do is consensus test miniscripts created by rust-miniscript 15:55 < sanket1729> But the problem is that libbitcoinconsensus only exposes consensus rules and not standardness rules 15:55 < sanket1729> And we want to check miniscript against bitcoin-core standardness policy rules. 15:57 < sanket1729> So, I think the (only? ) way to do this is via creating transactions and mining them in bitcoin-core regtest. This adds bunch of unnecessary things that I ideally don't want to be doing (creating the entire tx, managing utxos etc). 15:58 < sipa> i had tests (with the C++ code) that tested standardness for miniscript-signed transactions iirc 15:59 < sanket1729> But I think you had internal access to bitcoin-core VerifyScript function. 15:59 < sipa> yes 15:59 < sipa> if that would exist, and be tested, it would be easier to create a set of test vectors and verify that all codebases sign them identically 16:00 < sanket1729> I see, so you recommend testing the c++ versions and use the identical tests for rust-miniscript 16:01 < sipa> having integration tests that create and sign transactions and submit them to a bitcoind instance is something you'd want anyway too, i think 16:02 < sipa> but there are two distinct aspects, i think 16:02 < sipa> 1) wanting to test/validate the miniscript "spec" itself, to make sure that everything we've written in it actually results in standard and valid signatures 16:02 < sanket1729> There are rust bindings for libbitcoinconsensus that have VerifyScript function. But it only has by default the consensus rules, not the standardness one 16:03 < sipa> yeah i mean create full transactions/blocks, and submit them to a regtest bitcoind node 16:03 < sipa> 2) testing specific implementations of miniscript against that standard 16:05 < sipa> (the reason for not exposing standardless via a library is because it's a poor approximation of "will my transactions make it into the chain" - which depends on things like feerates, transaction sizes, mempool limits, dependency/replacement rules, ...) 16:05 < sipa> and those questions can't be answered without access to a real network node 16:06 < sipa> anyway, that's a tangent... i think the first priority should be validation of the miniscript spec itself 16:06 < sanket1729> yeah, makes sense. 16:06 < sipa> and for that, simpler and more performant approaches exist 16:06 < sanket1729> I will work on the long promised updates for c++ version 16:07 < sipa> \o/ 18:08 -!- willcl_ark [~quassel@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has quit [Quit: No Ping reply in 210 seconds.] 18:10 -!- willcl_ark [~quassel@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined ##miniscript 21:39 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 21:40 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined ##miniscript 22:28 -!- jonatack [~jon@213.152.161.35] has quit [Ping timeout: 246 seconds] 22:59 -!- jonatack [~jon@213.152.162.10] has joined ##miniscript