--- Day changed Wed Nov 11 2020 02:08 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 260 seconds] 06:33 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 06:37 < sanket1729_> There are a few other breaking changes we would like to get in before another release. We should have a release in 1-2 weeks. 08:08 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined ##miniscript 08:53 < justinmoon> sanket1729_ helped me a ton behind the scenes. Thanks Sanket! 09:08 -!- shesek [~shesek@164.90.217.137] has joined ##miniscript 09:08 -!- shesek [~shesek@164.90.217.137] has quit [Changing host] 09:08 -!- shesek [~shesek@unaffiliated/shesek] has joined ##miniscript 10:11 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 11:32 -!- shesek [~shesek@164.90.217.137] has joined ##miniscript 11:32 -!- shesek [~shesek@164.90.217.137] has quit [Changing host] 11:32 -!- shesek [~shesek@unaffiliated/shesek] has joined ##miniscript 12:40 < andytoshi> thanks justinmoon !! 12:41 < andytoshi> sanket1729_: just merged descriptorsecret key/keymap parsing 12:41 < sanket1729_> andytoshi: I will rebase the remaining PRs 12:41 < sanket1729_> we should have a release soon 12:42 < andytoshi> which means that all we have left are your big refactors (and i might have one or two followup ones, i think there are some clones i can kill and also i really want to rename miniscript::descriptor::from_txin_with_witness_stack) 12:42 < andytoshi> awesome :) 12:42 < andytoshi> what order should we do your prs in? 12:43 < sanket1729_> We should get 167 in first 12:43 < andytoshi> kk 12:43 < sanket1729_> I will rebase that first 12:43 < sanket1729_> I also some PRs locally 12:43 < andytoshi> i should also push forward on getting a new rust-bitcoin release out 12:43 < sanket1729_> Yeah, then we can also get the integration test PR 12:43 < sanket1729_> thanks justinmoon :) 13:12 < sanket1729_> andytoshi: 166 is up 13:13 < sanket1729_> I would have to rebase others on 166 since it touches many parts of the codebase 13:37 -!- Netsplit *.net <-> *.split quits: dr_orlovsky, justinmoon, willcl_ark 13:37 -!- Netsplit over, joins: dr_orlovsky, willcl_ark, justinmoon 13:40 -!- Netsplit *.net <-> *.split quits: nothingmuch, harrigan 13:40 -!- Netsplit *.net <-> *.split quits: martindale 13:40 -!- Netsplit *.net <-> *.split quits: sgeisler 13:41 -!- Netsplit over, joins: martindale 13:41 -!- Netsplit over, joins: sgeisler 13:41 -!- Netsplit over, joins: harrigan, nothingmuch 13:41 -!- Netsplit *.net <-> *.split quits: gwillen, darosior, andytoshi 13:41 -!- Netsplit *.net <-> *.split quits: jeremyrubin 13:42 -!- Netsplit over, joins: jeremyrubin 13:42 -!- Netsplit over, joins: gwillen, andytoshi, darosior 13:43 -!- Netsplit *.net <-> *.split quits: ghost43, sipa, jb55 13:43 -!- martindale [ericfabric@gateway/shell/matrix.org/x-celxqezddzqzzrcu] has quit [Ping timeout: 260 seconds] 13:44 -!- meshcollider [meshcollid@gateway/shell/ircnow/x-lesqambwizyhgzeh] has quit [Ping timeout: 264 seconds] 13:45 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-vkxamqyuloefpaxf] has quit [Ping timeout: 264 seconds] 13:45 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined ##miniscript 13:45 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined ##miniscript 13:45 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined ##miniscript 13:45 -!- meshcollider [meshcollid@gateway/shell/ircnow/x-vmynyavngcrbrncl] has joined ##miniscript 13:46 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-rzimnonivggyksik] has joined ##miniscript 13:46 -!- Netsplit *.net <-> *.split quits: darosior, michaelfolkson, harding, shesek, midnight, jeremyrubin, achow101, schmidty, jnewbery, jb55, (+22 more, use /NETSPLIT to show all of them) 13:47 -!- Netsplit over, joins: elichai2, ghost43, jb55, darosior, andytoshi, gwillen, harrigan, sgeisler, willcl_ark, shesek (+21 more) 13:48 -!- Netsplit *.net <-> *.split quits: digi_james 13:50 -!- Netsplit over, joins: digi_james 13:50 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds] 13:50 -!- Netsplit over, joins: sanket1729_ 13:51 -!- Netsplit *.net <-> *.split quits: jonatack 13:53 < andytoshi> kk 13:53 -!- Netsplit over, joins: jonatack 13:53 -!- Netsplit *.net <-> *.split quits: jnewbery, aj 13:54 -!- Netsplit *.net <-> *.split quits: windsok, kallewoof, harding, michaelfolkson, RubenSomsen 13:54 -!- Netsplit over, joins: aj, jnewbery 13:54 < andytoshi> re your thoughts about not doing this, and instead making the user translate the descriptor...hmm 13:54 < andytoshi> we should definitely have something much more ergonomic than the existing translate_pk method 13:54 -!- Netsplit *.net <-> *.split quits: shesek 13:54 < andytoshi> e.g. we could provide a wrapper which doesn't allow errors and which doesn't translate pkhashes 13:54 -!- Netsplit over, joins: RubenSomsen, michaelfolkson, windsok, harding, kallewoof 13:55 -!- Netsplit over, joins: shesek 13:55 < andytoshi> and we still wouldn't have the ability to add context to satisfiers, which i think we'd want to do anyway 13:57 < andytoshi> hmm actually, i'm not sure what i had in mind wrt providing satisfier context.. 13:57 < andytoshi> i think we could just implement Satisfier on a (seckey, hashtype) and we'd be good 13:58 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-rzimnonivggyksik] has quit [Ping timeout: 244 seconds] 14:00 < andytoshi> one thing we could do to make #166 more ergonomic would be to provide alternate/wrapper methods for everything that takes NullCtx 14:00 < andytoshi> very frustrating that Rust doesn't have default parameters or function overloading 14:00 < andytoshi> but like .... i really like the ergonomics of this in the case of p2c. where you can just take a single descriptor, provide a tweak and it'll give you an address. no conversion required 14:01 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-rbfbgiogvwgpuexh] has joined ##miniscript 14:03 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined ##miniscript 14:03 < sanket1729_> yep, default parameter would really be helpful 14:04 < sanket1729_> That discussion comment is old 14:05 < andytoshi> heh good to know 14:05 < sanket1729_> We decided to allow the breaking change and keep 166 14:05 < andytoshi> so ... the question would be, do we name the context-requiring functions encode_with_context etc 14:06 < andytoshi> or the default ones encode_simple or somethng 14:06 < andytoshi> the issue is that WalletPublicKey doesn't impl ToPublicKey ... so if we expect the common case is that users use DescriptorPublicKey 14:06 < andytoshi> then they'll have to use the context-taking functions all the time. so it'd be nice if they were easyi to type 14:07 < sanket1729_> yeah. 14:08 < sanket1729_> I think the current way with documentation may also be good enough. 14:08 < andytoshi> yeah, i think you're right 14:08 < andytoshi> in practice i think people using simple pubkeys will be a fairly uncommon case ... basically only for example code 14:08 < andytoshi> wallets will almost always have keyorigins to think about, at least. liquid has tweaks 14:10 < sanket1729_> Currently, I have the same 3 line doccomment pasted on every function that has the topkctx param 14:11 < andytoshi> heh 14:17 -!- martindale [ericfabric@gateway/shell/matrix.org/x-sokykneyrotskzoh] has joined ##miniscript 14:38 < andytoshi> lol i'm kinda scared to merge this 14:39 < andytoshi> i think we should just do it, and do a release, and if it turns out that it's a nightmare to use i guess we'll have to undo it...which is a lot of work but at least it's just chasing compiler errors, nothing too intellectually demanding 14:39 < andytoshi> but my expectation is that we'll be happy with this 14:39 < andytoshi> it's just a big change. lol. 15:20 < sanket1729_> yeah,pretty big change 15:23 < andytoshi> merged :P 15:34 < sanket1729_> nice. Rebasing other PRs