--- Log opened Wed Feb 09 00:00:54 2022
08:22 -!- Guest154444 [~Guest1544@87-231-29-23.rev.numericable.fr] has joined ##miniscript
08:23 -!- Guest154444 [~Guest1544@87-231-29-23.rev.numericable.fr] has left ##miniscript []
09:44 < jeremyrubin> that's why i think those haskell programmers are silly, there is already a haskell in the C++ templating system just use that!
11:19 < andytoshi> lol
14:17 < sanket1729> andytoshi: Do you want me to merge or are you merging it?
14:19 < andytoshi> sanket1729: go for it
14:19 < andytoshi> i'd rather not merge major stuff right now because i'm still a bit out of the loop on this library
14:24 < sanket1729> One fixup PR up: https://github.com/rust-bitcoin/rust-miniscript/pull/296. I am working on another PR to add PreTaprootDescriptor (these don't fail on inner_script/script_code) and AddressableDescriptor (These don't fail on address)
14:26 < andytoshi> dope
14:26 < andytoshi> reviewing this nowe
14:28 < andytoshi> hmm sanket1729 concept ACK this refactoring. it's definitely an improvement but still feels a bit messy
14:29 < andytoshi> maybe this logic is just inherently messy
14:29 < andytoshi> and i guess, we're never going to look at it again, this code never changes..
14:30 < sanket1729> If you can think of any improvements, I would be happy to implement them
14:46 < andytoshi> heh, nope, let's go with thits
14:50 < sanket1729> Do you also want another enum like `PreTaprootDescriptor` that has everything but Tr? And similarly for AddressableDescriptor that has everything but `Bare`. There maybe lot of seemingly duplicated code that we cannot easily dedup without macros 
14:55 < andytoshi> sanket1729: hmm, i think we could get away with using the same enum
14:55 < andytoshi> it may force users to write a bunch of unreachable!()s, not sure
14:56 < andytoshi> but tbh i think this enum should be #[non_exhaustive] and we should warn users that we might add descriptors that they don't understand at any moment
14:56 < andytoshi> so they already would need a catchall "unknown descriptor type" case
15:02 < sanket1729> So, we don't implement PreTaprootDescriptor for DescriptorTrait?
15:02 < sanket1729> Sorry PretaprootDescriptor on Descriptor
15:02 < sanket1729> What is the user API of PreTaprootDescriptor that you in mind?
15:03 < sanket1729> I mean how they do parse a descriptor that is pre taproot
15:07 < sanket1729> Yup, lot of things are getting #[non_exhuastive] after 1.41 MSRV bump
--- Log closed Thu Feb 10 00:00:55 2022