--- Log opened Mon Nov 21 00:00:23 2022 00:09 -!- jonatack1 [~jonatack@user/jonatack] has quit [Ping timeout: 260 seconds] 01:53 -!- sipa [~sipa@user/sipa] has quit [Read error: Software caused connection abort] 01:53 -!- sipa [~sipa@user/sipa] has joined ##miniscript 01:53 -!- mode/##miniscript [+o sipa] by ChanServ 04:27 < darosior> In rust-bitcoin when computing the satisfaction size of a wsh descriptor, why do we add a varint of the number of satisfaction stack elements? https://github.com/rust-bitcoin/rust-miniscript/blob/a7bfff46b15bd42c12da4ef39d8769f64ade848c/src/descriptor/segwitv0.rs#L108-L111 04:27 < darosior> It seems it assumes the satisfaction is pushed on the stack as one whole element (like the witness script is), but it is not the case. All satisfaction elements are directly pushed to the stack one by one. I think this '+ varint_len(max_sat_elems)' should be removed? 05:18 <@sipa> darosior: The serialization of the witness stack does involve a varint that encodes the number of elements on the stack. 05:19 <@sipa> (though that does include the script itself too) 05:20 < darosior> I assumed it was accounted for separately because it didn't include the witness script, but indeed maybe it's that 07:23 -!- jonatack1 [~jonatack@user/jonatack] has joined ##miniscript 08:01 -!- jonatack2 [~jonatack@user/jonatack] has joined ##miniscript 08:04 -!- jonatack1 [~jonatack@user/jonatack] has quit [Ping timeout: 268 seconds] 14:57 -!- jonatack2 [~jonatack@user/jonatack] has quit [Read error: Connection reset by peer] 15:21 -!- jonatack2 [~jonatack@user/jonatack] has joined ##miniscript 19:25 -!- jonatack2 [~jonatack@user/jonatack] has quit [Ping timeout: 256 seconds] 19:44 -!- jonatack2 [~jonatack@user/jonatack] has joined ##miniscript --- Log closed Tue Nov 22 00:00:25 2022